1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
|
package objectpool
import (
"os"
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v15/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/v15/internal/helper/perm"
"gitlab.com/gitlab-org/gitaly/v15/internal/structerr"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
)
func TestFromProto(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg := testcfg.Build(t)
locator := config.NewLocator(cfg)
t.Run("successful", func(t *testing.T) {
cfg, pool, _ := setupObjectPool(t, ctx)
locator := config.NewLocator(cfg)
_, err := FromProto(locator, nil, nil, nil, nil, pool.ToProto())
require.NoError(t, err)
})
t.Run("nonexistent", func(t *testing.T) {
_, err := FromProto(locator, nil, nil, nil, nil, &gitalypb.ObjectPool{
Repository: &gitalypb.Repository{
StorageName: cfg.Storages[0].Name,
RelativePath: gittest.NewObjectPoolName(t),
},
})
require.Equal(t, ErrInvalidPoolRepository, err)
})
t.Run("unknown storage", func(t *testing.T) {
_, err := FromProto(locator, nil, nil, nil, nil, &gitalypb.ObjectPool{
Repository: &gitalypb.Repository{
StorageName: "mepmep",
RelativePath: gittest.NewObjectPoolName(t),
},
})
require.Equal(t, structerr.NewInvalidArgument("GetStorageByName: no such storage: %q", "mepmep"), err)
})
}
func TestFromRepo_successful(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, pool, repo := setupObjectPool(t, ctx)
locator := config.NewLocator(cfg)
require.NoError(t, pool.Link(ctx, repo))
poolFromRepo, err := FromRepo(locator, pool.gitCmdFactory, nil, nil, nil, repo)
require.NoError(t, err)
require.Equal(t, pool.GetRelativePath(), poolFromRepo.GetRelativePath())
require.Equal(t, pool.GetStorageName(), poolFromRepo.GetStorageName())
}
func TestFromRepo_failures(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
t.Run("without alternates file", func(t *testing.T) {
cfg, pool, repo := setupObjectPool(t, ctx)
locator := config.NewLocator(cfg)
poolFromRepo, err := FromRepo(locator, pool.gitCmdFactory, nil, nil, nil, repo)
require.Equal(t, ErrAlternateObjectDirNotExist, err)
require.Nil(t, poolFromRepo)
})
for _, tc := range []struct {
desc string
fileContent []byte
expectedErr error
}{
{
desc: "alternates points to non existent path",
fileContent: []byte("/tmp/invalid_path"),
expectedErr: ErrInvalidPoolRepository,
},
{
desc: "alternates is empty",
fileContent: nil,
expectedErr: nil,
},
{
desc: "alternates is commented",
fileContent: []byte("#/tmp/invalid/path"),
expectedErr: ErrAlternateObjectDirNotExist,
},
} {
t.Run(tc.desc, func(t *testing.T) {
cfg, pool, repo := setupObjectPool(t, ctx)
locator := config.NewLocator(cfg)
repoPath, err := repo.Path()
require.NoError(t, err)
require.NoError(t, os.MkdirAll(filepath.Join(repoPath, "objects", "info"), perm.SharedDir))
alternateFilePath := filepath.Join(repoPath, "objects", "info", "alternates")
require.NoError(t, os.WriteFile(alternateFilePath, tc.fileContent, perm.SharedFile))
poolFromRepo, err := FromRepo(locator, pool.gitCmdFactory, nil, nil, nil, repo)
require.Equal(t, tc.expectedErr, err)
require.Nil(t, poolFromRepo)
require.NoError(t, os.Remove(alternateFilePath))
})
}
}
func TestRemove(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
_, pool, _ := setupObjectPool(t, ctx)
require.True(t, pool.Exists())
require.NoError(t, pool.Remove(ctx))
require.False(t, pool.Exists())
}
|
