1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
|
package git
import (
"context"
"fmt"
"io/ioutil"
"strconv"
"strings"
"gitlab.com/gitlab-org/gitaly/v14/internal/command"
)
// minimumVersion is the minimum required Git version. If updating this version, be sure to
// also update the following locations:
// - https://gitlab.com/gitlab-org/gitaly/blob/master/README.md#installation
// - https://gitlab.com/gitlab-org/gitaly/blob/master/.gitlab-ci.yml
// - https://gitlab.com/gitlab-org/gitlab-foss/blob/master/.gitlab-ci.yml
// - https://gitlab.com/gitlab-org/gitlab-foss/blob/master/lib/system_check/app/git_version_check.rb
var minimumVersion = Version{
versionString: "2.31.0",
major: 2,
minor: 31,
patch: 0,
rc: false,
// gl is the GitLab patch level.
gl: 0,
}
// Version represents the version of git itself.
type Version struct {
// versionString is the string representation of the version. The string representation is
// not directly derived from the parsed version information because we do not extract all
// information from the original version string. Deriving it from parsed information would
// thus potentially lose information.
versionString string
major, minor, patch uint32
rc bool
gl uint32
}
// CurrentVersion returns the used git version.
func CurrentVersion(ctx context.Context, gitCmdFactory CommandFactory) (Version, error) {
cmd, err := gitCmdFactory.NewWithoutRepo(ctx, SubCmd{
Name: "version",
})
if err != nil {
return Version{}, fmt.Errorf("spawning version command: %w", err)
}
return parseVersionFromCommand(cmd)
}
// CurrentVersionForExecutor returns the git version used by the given executor.
func CurrentVersionForExecutor(ctx context.Context, executor RepositoryExecutor) (Version, error) {
cmd, err := executor.Exec(ctx, SubCmd{
Name: "version",
})
if err != nil {
return Version{}, fmt.Errorf("spawning version command: %w", err)
}
return parseVersionFromCommand(cmd)
}
func parseVersionFromCommand(cmd *command.Command) (Version, error) {
versionOutput, err := ioutil.ReadAll(cmd)
if err != nil {
return Version{}, fmt.Errorf("reading version output: %w", err)
}
if err := cmd.Wait(); err != nil {
return Version{}, fmt.Errorf("waiting for version command: %w", err)
}
trimmedVersionOutput := strings.Trim(string(versionOutput), " \n")
versionString := strings.SplitN(trimmedVersionOutput, " ", 3)
if len(versionString) != 3 {
return Version{}, fmt.Errorf("invalid version format: %q", string(versionOutput))
}
version, err := parseVersion(versionString[2])
if err != nil {
return Version{}, fmt.Errorf("cannot parse git version: %w", err)
}
return version, nil
}
// String returns the string representation of the version.
func (v Version) String() string {
return v.versionString
}
// IsSupported checks if a version string corresponds to a Git version
// supported by Gitaly.
func (v Version) IsSupported() bool {
return !v.LessThan(minimumVersion)
}
// SupportsObjectTypeFilter checks if a version corresponds to a Git version which supports object
// type filters.
func (v Version) SupportsObjectTypeFilter() bool {
return !v.LessThan(Version{major: 2, minor: 32, patch: 0})
}
// FlushesUpdaterefStatus determines whether the given Git version properly flushes status messages
// in git-update-ref(1).
func (v Version) FlushesUpdaterefStatus() bool {
// We need to be a bit more careful here given that this comes in via a custom patch. The
// fix will be released as part of v2.34, so it's either in v2.33 with at least patch level
// 3, or it's greater than or equal to v2.34.
switch {
case v.major == 2 && v.minor == 33 && v.gl >= 3:
return true
case v.major == 2 && v.minor >= 34:
return true
case v.major >= 3:
return true
}
return false
}
// LessThan determines whether the version is older than another version.
func (v Version) LessThan(other Version) bool {
switch {
case v.major < other.major:
return true
case v.major > other.major:
return false
case v.minor < other.minor:
return true
case v.minor > other.minor:
return false
case v.patch < other.patch:
return true
case v.patch > other.patch:
return false
case v.rc && !other.rc:
return true
case !v.rc && other.rc:
return false
case v.gl < other.gl:
return true
case v.gl > other.gl:
return false
default:
// this should only be reachable when versions are equal
return false
}
}
func parseVersion(versionStr string) (Version, error) {
versionSplit := strings.SplitN(versionStr, ".", 4)
if len(versionSplit) < 3 {
return Version{}, fmt.Errorf("expected major.minor.patch in %q", versionStr)
}
ver := Version{
versionString: versionStr,
}
for i, v := range []*uint32{&ver.major, &ver.minor, &ver.patch} {
var n64 uint64
if versionSplit[i] == "GIT" {
// Git falls back to vx.x.GIT if it's unable to describe the current version
// or if there's a version file. We should just treat this as "0", even
// though it may have additional commits on top.
n64 = 0
} else {
rcSplit := strings.SplitN(versionSplit[i], "-", 2)
var err error
n64, err = strconv.ParseUint(rcSplit[0], 10, 32)
if err != nil {
return Version{}, err
}
if len(rcSplit) == 2 && strings.HasPrefix(rcSplit[1], "rc") {
ver.rc = true
}
}
*v = uint32(n64)
}
if len(versionSplit) == 4 {
if strings.HasPrefix(versionSplit[3], "rc") {
ver.rc = true
} else if strings.HasPrefix(versionSplit[3], "gl") {
gitlabPatchLevel := versionSplit[3][2:]
gl, err := strconv.ParseUint(gitlabPatchLevel, 10, 32)
if err != nil {
return Version{}, err
}
ver.gl = uint32(gl)
}
}
return ver, nil
}
|
