1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
|
package hook
import (
"bufio"
"bytes"
"fmt"
"io/ioutil"
"os"
"path/filepath"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/internal/helper/text"
"gitlab.com/gitlab-org/gitaly/internal/storage"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
)
// printAllScript is a bash script that prints out stdin, the arguments,
// and the environment variables in the following format:
// stdin:old new ref0
// args: arg1 arg2
// env: VAR1=VAL1 VAR2=VAL2
// NOTE: this script only prints one line of stdin
var printAllScript = []byte(`#!/bin/bash
read stdin
echo stdin:$stdin
echo args:$@
echo env: $(printenv)`)
// printStdinScript prints stdin line by line
var printStdinScript = []byte(`#!/bin/bash
while read line
do
echo "$line"
done
`)
// failScript prints the name of the command and exits with exit code 1
var failScript = []byte(`#!/bin/bash
echo "$0" >&2
exit 1`)
// successScript prints the name of the command and exits with exit code 0
var successScript = []byte(`#!/bin/bash
echo "$0"
exit 0`)
func TestCustomHooksSuccess(t *testing.T) {
cfg, repo, repoPath := testcfg.BuildWithRepo(t)
testCases := []struct {
hookName string
stdin string
args []string
env []string
hookDir string
}{
{
hookName: "pre-receive",
stdin: "old new ref0",
args: nil,
env: []string{"GL_ID=user-123", "GL_USERNAME=username123", "GL_PROTOCOL=ssh", "GL_REPOSITORY=repo1"},
},
{
hookName: "update",
stdin: "",
args: []string{"old", "new", "ref0"},
env: []string{"GL_ID=user-123", "GL_USERNAME=username123", "GL_PROTOCOL=ssh", "GL_REPOSITORY=repo1"},
},
{
hookName: "post-receive",
stdin: "old new ref1",
args: nil,
env: []string{"GL_ID=user-123", "GL_USERNAME=username123", "GL_PROTOCOL=ssh", "GL_REPOSITORY=repo1"},
},
}
for _, tc := range testCases {
t.Run(tc.hookName, func(t *testing.T) {
globalCustomHooksDir := testhelper.TempDir(t)
locator := config.NewLocator(cfg)
// hook is in project custom hook directory <repository>.git/custom_hooks/<hook_name>
hookDir := filepath.Join(repoPath, "custom_hooks")
callAndVerifyHooks(t, locator, repo, tc.hookName, globalCustomHooksDir, hookDir, tc.stdin, tc.args, tc.env)
// hook is in project custom hooks directory <repository>.git/custom_hooks/<hook_name>.d/*
hookDir = filepath.Join(repoPath, "custom_hooks", fmt.Sprintf("%s.d", tc.hookName))
callAndVerifyHooks(t, locator, repo, tc.hookName, globalCustomHooksDir, hookDir, tc.stdin, tc.args, tc.env)
// hook is in global custom hooks directory <global_custom_hooks_dir>/<hook_name>.d/*
hookDir = filepath.Join(globalCustomHooksDir, fmt.Sprintf("%s.d", tc.hookName))
callAndVerifyHooks(t, locator, repo, tc.hookName, globalCustomHooksDir, hookDir, tc.stdin, tc.args, tc.env)
})
}
}
func TestCustomHookPartialFailure(t *testing.T) {
cfg, repo, repoPath := testcfg.BuildWithRepo(t)
globalCustomHooksDir := testhelper.TempDir(t)
ctx, cancel := testhelper.Context()
defer cancel()
testCases := []struct {
hook string
projectHookSucceeds bool
globalHookSucceeds bool
}{
{
hook: "pre-receive",
projectHookSucceeds: true,
globalHookSucceeds: false,
},
{
hook: "post-receive",
projectHookSucceeds: false,
globalHookSucceeds: true,
},
{
hook: "update",
projectHookSucceeds: false,
globalHookSucceeds: true,
},
}
for _, tc := range testCases {
t.Run(tc.hook, func(t *testing.T) {
projectHookScript := successScript
if !tc.projectHookSucceeds {
projectHookScript = failScript
}
projectHookPath := filepath.Join(repoPath, "custom_hooks")
cleanup := writeCustomHook(t, tc.hook, projectHookPath, projectHookScript)
defer cleanup()
globalHookScript := successScript
if !tc.globalHookSucceeds {
globalHookScript = failScript
}
globalHookPath := filepath.Join(globalCustomHooksDir, fmt.Sprintf("%s.d", tc.hook))
cleanup = writeCustomHook(t, tc.hook, globalHookPath, globalHookScript)
defer cleanup()
mgr := GitLabHookManager{
locator: config.NewLocator(cfg),
hooksConfig: config.Hooks{
CustomHooksDir: globalCustomHooksDir,
},
}
caller, err := mgr.newCustomHooksExecutor(repo, tc.hook)
require.NoError(t, err)
var stdout, stderr bytes.Buffer
require.Error(t, caller(ctx, nil, nil, &bytes.Buffer{}, &stdout, &stderr))
if tc.projectHookSucceeds && tc.globalHookSucceeds {
require.Equal(t, filepath.Join(projectHookPath, tc.hook), text.ChompBytes(stdout.Bytes()))
require.Equal(t, filepath.Join(globalHookPath, tc.hook), text.ChompBytes(stdout.Bytes()))
} else if tc.projectHookSucceeds && !tc.globalHookSucceeds {
require.Equal(t, filepath.Join(projectHookPath, tc.hook), text.ChompBytes(stdout.Bytes()))
require.Equal(t, filepath.Join(globalHookPath, tc.hook), text.ChompBytes(stderr.Bytes()))
} else {
require.Equal(t, filepath.Join(projectHookPath, tc.hook), text.ChompBytes(stderr.Bytes()))
}
})
}
}
func TestCustomHooksMultipleHooks(t *testing.T) {
cfg, repo, repoPath := testcfg.BuildWithRepo(t)
globalCustomHooksDir := testhelper.TempDir(t)
ctx, cancel := testhelper.Context()
defer cancel()
var expectedExecutedScripts []string
projectUpdateHooks := 9
projectHooksPath := filepath.Join(repoPath, "custom_hooks", "update.d")
for i := 0; i < projectUpdateHooks; i++ {
fileName := fmt.Sprintf("update_%d", i)
writeCustomHook(t, fileName, projectHooksPath, successScript)
expectedExecutedScripts = append(expectedExecutedScripts, filepath.Join(projectHooksPath, fileName))
}
globalUpdateHooks := 6
globalHooksPath := filepath.Join(globalCustomHooksDir, "update.d")
for i := 0; i < globalUpdateHooks; i++ {
fileName := fmt.Sprintf("update_%d", i)
writeCustomHook(t, fileName, globalHooksPath, successScript)
expectedExecutedScripts = append(expectedExecutedScripts, filepath.Join(globalHooksPath, fileName))
}
mgr := GitLabHookManager{
locator: config.NewLocator(cfg),
hooksConfig: config.Hooks{
CustomHooksDir: globalCustomHooksDir,
},
}
hooksExecutor, err := mgr.newCustomHooksExecutor(repo, "update")
require.NoError(t, err)
var stdout, stderr bytes.Buffer
require.NoError(t, hooksExecutor(ctx, nil, nil, &bytes.Buffer{}, &stdout, &stderr))
require.Empty(t, stderr.Bytes())
outputScanner := bufio.NewScanner(&stdout)
for _, expectedScript := range expectedExecutedScripts {
require.True(t, outputScanner.Scan())
require.Equal(t, expectedScript, outputScanner.Text())
}
}
func TestCustomHooksWithSymlinks(t *testing.T) {
cfg, repo, _ := testcfg.BuildWithRepo(t)
globalCustomHooksDir := testhelper.TempDir(t)
ctx, cancel := testhelper.Context()
defer cancel()
globalHooksPath := filepath.Join(globalCustomHooksDir, "update.d")
// Test directory structure:
//
// first_dir/update
// first_dir/update~
// second_dir -> first_dir
// update -> second_dir/update GOOD
// update_tilde -> first_dir/update~ GOOD
// update~ -> first_dir/update BAD
// something -> not-executable BAD
// bad -> /path/to/nowhere BAD
firstDir := filepath.Join(globalHooksPath, "first_dir")
secondDir := filepath.Join(globalHooksPath, "second_dir")
require.NoError(t, os.MkdirAll(firstDir, 0755))
require.NoError(t, os.Symlink(firstDir, secondDir))
filename := filepath.Join(firstDir, "update")
updateTildePath := filepath.Join(globalHooksPath, "update_tilde")
require.NoError(t, os.Symlink(filename, updateTildePath))
updateHookPath := filepath.Join(globalHooksPath, "update")
require.NoError(t, os.Symlink(filename, updateHookPath))
badUpdatePath := filepath.Join(globalHooksPath, "update~")
badUpdateHook := filepath.Join(firstDir, "update~")
require.NoError(t, os.Symlink(badUpdateHook, badUpdatePath))
notExecPath := filepath.Join(globalHooksPath, "not-executable")
badExecHook := filepath.Join(firstDir, "something")
_, err := os.Create(notExecPath)
require.NoError(t, err)
require.NoError(t, os.Symlink(notExecPath, badExecHook))
badPath := filepath.Join(globalHooksPath, "bad")
require.NoError(t, os.Symlink("/path/to/nowhere", badPath))
writeCustomHook(t, "update", firstDir, successScript)
writeCustomHook(t, "update~", firstDir, successScript)
expectedExecutedScripts := []string{updateHookPath, updateTildePath}
mgr := GitLabHookManager{
locator: config.NewLocator(cfg),
hooksConfig: config.Hooks{
CustomHooksDir: globalCustomHooksDir,
},
}
hooksExecutor, err := mgr.newCustomHooksExecutor(repo, "update")
require.NoError(t, err)
var stdout, stderr bytes.Buffer
require.NoError(t, hooksExecutor(ctx, nil, nil, &bytes.Buffer{}, &stdout, &stderr))
require.Empty(t, stderr.Bytes())
outputScanner := bufio.NewScanner(&stdout)
for _, expectedScript := range expectedExecutedScripts {
require.True(t, outputScanner.Scan())
require.Equal(t, expectedScript, outputScanner.Text())
}
}
func TestMultilineStdin(t *testing.T) {
cfg, repo, repoPath := testcfg.BuildWithRepo(t)
globalCustomHooksDir := testhelper.TempDir(t)
ctx, cancel := testhelper.Context()
defer cancel()
projectHooksPath := filepath.Join(repoPath, "custom_hooks", "pre-receive.d")
writeCustomHook(t, "pre-receive-script", projectHooksPath, printStdinScript)
mgr := GitLabHookManager{
locator: config.NewLocator(cfg),
hooksConfig: config.Hooks{
CustomHooksDir: globalCustomHooksDir,
},
}
hooksExecutor, err := mgr.newCustomHooksExecutor(repo, "pre-receive")
require.NoError(t, err)
changes := `old1 new1 ref1
old2 new2 ref2
old3 new3 ref3
`
stdin := bytes.NewBufferString(changes)
var stdout, stderr bytes.Buffer
require.NoError(t, hooksExecutor(ctx, nil, nil, stdin, &stdout, &stderr))
require.Equal(t, changes, stdout.String())
}
func TestMultipleScriptsStdin(t *testing.T) {
cfg, repo, repoPath := testcfg.BuildWithRepo(t)
globalCustomHooksDir := testhelper.TempDir(t)
ctx, cancel := testhelper.Context()
defer cancel()
projectUpdateHooks := 9
projectHooksPath := filepath.Join(repoPath, "custom_hooks", "pre-receive.d")
for i := 0; i < projectUpdateHooks; i++ {
fileName := fmt.Sprintf("pre-receive_%d", i)
writeCustomHook(t, fileName, projectHooksPath, printStdinScript)
}
mgr := GitLabHookManager{
locator: config.NewLocator(cfg),
hooksConfig: config.Hooks{
CustomHooksDir: globalCustomHooksDir,
},
}
hooksExecutor, err := mgr.newCustomHooksExecutor(repo, "pre-receive")
require.NoError(t, err)
changes := "oldref11 newref00 ref123445"
var stdout, stderr bytes.Buffer
require.NoError(t, hooksExecutor(ctx, nil, nil, bytes.NewBufferString(changes+"\n"), &stdout, &stderr))
require.Empty(t, stderr.Bytes())
outputScanner := bufio.NewScanner(&stdout)
for i := 0; i < projectUpdateHooks; i++ {
require.True(t, outputScanner.Scan())
require.Equal(t, changes, outputScanner.Text())
}
}
func callAndVerifyHooks(t *testing.T, locator storage.Locator, repo *gitalypb.Repository, hookName, globalHooksDir, hookDir, stdin string, args, env []string) {
ctx, cancel := testhelper.Context()
defer cancel()
var stdout, stderr bytes.Buffer
cleanup := writeCustomHook(t, hookName, hookDir, printAllScript)
defer cleanup()
mgr := GitLabHookManager{
locator: locator,
hooksConfig: config.Hooks{
CustomHooksDir: globalHooksDir,
},
}
callHooks, err := mgr.newCustomHooksExecutor(repo, hookName)
require.NoError(t, err)
require.NoError(t, callHooks(ctx, args, env, bytes.NewBufferString(stdin), &stdout, &stderr))
require.Empty(t, stderr.Bytes())
results := getCustomHookResults(&stdout)
assert.Equal(t, stdin, results.stdin)
assert.Equal(t, args, results.args)
assert.Subset(t, results.env, env)
}
func getCustomHookResults(stdout *bytes.Buffer) customHookResults {
lines := strings.SplitN(stdout.String(), "\n", 3)
stdinLine := strings.SplitN(strings.TrimSpace(lines[0]), ":", 2)
argsLine := strings.SplitN(strings.TrimSpace(lines[1]), ":", 2)
envLine := strings.SplitN(strings.TrimSpace(lines[2]), ":", 2)
var args, env []string
if len(argsLine) == 2 && argsLine[1] != "" {
args = strings.Split(argsLine[1], " ")
}
if len(envLine) == 2 && envLine[1] != "" {
env = strings.Split(envLine[1], " ")
}
var stdin string
if len(stdinLine) == 2 {
stdin = stdinLine[1]
}
return customHookResults{
stdin: stdin,
args: args,
env: env,
}
}
type customHookResults struct {
stdin string
args []string
env []string
}
func writeCustomHook(t *testing.T, hookName, dir string, content []byte) func() {
require.NoError(t, os.MkdirAll(dir, 0755))
require.NoError(t, ioutil.WriteFile(filepath.Join(dir, hookName), content, 0755))
return func() {
os.RemoveAll(dir)
}
}
func TestPushOptionsEnv(t *testing.T) {
testCases := []struct {
desc string
input []string
expected []string
}{
{
desc: "empty input",
input: []string{},
expected: []string{},
},
{
desc: "nil input",
input: nil,
expected: []string{},
},
{
desc: "one option",
input: []string{"option1"},
expected: []string{"GIT_PUSH_OPTION_COUNT=1", "GIT_PUSH_OPTION_0=option1"},
},
{
desc: "multiple options",
input: []string{"option1", "option2"},
expected: []string{"GIT_PUSH_OPTION_COUNT=2", "GIT_PUSH_OPTION_0=option1", "GIT_PUSH_OPTION_1=option2"},
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
require.Equal(t, tc.expected, pushOptionsEnv(tc.input))
})
}
}
|