1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
|
package maintenance
import (
"context"
"math/rand"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/catfile"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/housekeeping"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/v16/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/v16/internal/gitaly/storage"
"gitlab.com/gitlab-org/gitaly/v16/internal/gitaly/transaction"
"gitlab.com/gitlab-org/gitaly/v16/internal/grpc/backchannel"
"gitlab.com/gitlab-org/gitaly/v16/internal/helper"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/v16/proto/go/gitalypb"
)
type mockOptimizer struct {
t testing.TB
actual []storage.Repository
cfg config.Cfg
}
func (mo *mockOptimizer) OptimizeRepository(ctx context.Context, repository storage.Repository) error {
mo.actual = append(mo.actual, repository)
l := config.NewLocator(mo.cfg)
gitCmdFactory := gittest.NewCommandFactory(mo.t, mo.cfg)
catfileCache := catfile.NewCache(mo.cfg)
mo.t.Cleanup(catfileCache.Stop)
txManager := transaction.NewManager(mo.cfg, backchannel.NewRegistry())
housekeepingManager := housekeeping.NewManager(mo.cfg.Prometheus, txManager)
return housekeepingManager.OptimizeRepository(ctx, localrepo.New(l, gitCmdFactory, catfileCache, repository))
}
func TestOptimizeReposRandomly(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfgBuilder := testcfg.NewGitalyCfgBuilder(testcfg.WithStorages("0", "1", "2"))
cfg := cfgBuilder.Build(t)
for _, storage := range cfg.Storages {
gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
SkipCreationViaService: true,
Storage: storage,
RelativePath: "a",
})
gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
SkipCreationViaService: true,
Storage: storage,
RelativePath: "b",
})
}
cfg.Storages = append(cfg.Storages, config.Storage{
Name: "duplicate",
Path: cfg.Storages[0].Path,
})
for _, tc := range []struct {
desc string
storages []string
expected []*gitalypb.Repository
}{
{
desc: "two storages",
storages: []string{"0", "1"},
expected: []*gitalypb.Repository{
{RelativePath: "a", StorageName: "0"},
{RelativePath: "a", StorageName: "1"},
{RelativePath: "b", StorageName: "0"},
{RelativePath: "b", StorageName: "1"},
},
},
{
desc: "duplicate storages",
storages: []string{"0", "1", "duplicate"},
expected: []*gitalypb.Repository{
{RelativePath: "a", StorageName: "0"},
{RelativePath: "a", StorageName: "1"},
{RelativePath: "b", StorageName: "0"},
{RelativePath: "b", StorageName: "1"},
},
},
} {
t.Run(tc.desc, func(t *testing.T) {
tickerDone := false
tickerCount := 0
ticker := helper.NewManualTicker()
ticker.ResetFunc = func() {
tickerCount++
ticker.Tick()
}
ticker.StopFunc = func() {
tickerDone = true
}
mo := &mockOptimizer{
t: t,
cfg: cfg,
}
walker := OptimizeReposRandomly(cfg, mo, ticker, rand.New(rand.NewSource(1)))
require.NoError(t, walker(ctx, testhelper.SharedLogger(t), tc.storages))
require.ElementsMatch(t, tc.expected, mo.actual)
require.True(t, tickerDone)
// We expect one more tick than optimized repositories because of the
// initial tick up front to re-start the timer.
require.Equal(t, len(tc.expected)+1, tickerCount)
})
}
}
|
