1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
|
package blob
import (
"bytes"
"fmt"
"io"
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/v15/internal/structerr"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
"gitlab.com/gitlab-org/gitaly/v15/streamio"
)
func TestGetBlob_successful(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, client := setupWithoutRepo(t, ctx)
repoProto, _ := gittest.CreateRepository(t, ctx, cfg)
repo := localrepo.NewTestRepo(t, cfg, repoProto)
smallBlobContents := []byte("small blob")
smallBlobLen := int64(len(smallBlobContents))
smallBlobID := localrepo.MustWriteBlob(t, repo, "", string(smallBlobContents))
largeBlobContents := bytes.Repeat([]byte{1}, 1024*1024)
largeBlobID := localrepo.MustWriteBlob(t, repo, "", string(largeBlobContents))
for _, tc := range []struct {
desc string
oid string
limit int64
expectedContent []byte
expectedSize int64
}{
{
desc: "unlimited fetch",
oid: smallBlobID.String(),
limit: -1,
expectedContent: smallBlobContents,
expectedSize: smallBlobLen,
},
{
desc: "limit larger than blob size",
oid: smallBlobID.String(),
limit: smallBlobLen + 1,
expectedContent: smallBlobContents,
expectedSize: smallBlobLen,
},
{
desc: "limit zero",
oid: smallBlobID.String(),
limit: 0,
expectedSize: smallBlobLen,
},
{
desc: "limit greater than zero, less than blob size",
oid: smallBlobID.String(),
limit: 10,
expectedContent: smallBlobContents[:10],
expectedSize: smallBlobLen,
},
{
desc: "large blob",
oid: largeBlobID.String(),
limit: 10,
expectedContent: largeBlobContents[:10],
expectedSize: int64(len(largeBlobContents)),
},
} {
t.Run(tc.desc, func(t *testing.T) {
stream, err := client.GetBlob(ctx, &gitalypb.GetBlobRequest{
Repository: repoProto,
Oid: tc.oid,
Limit: tc.limit,
})
require.NoError(t, err, "initiate RPC")
reportedSize, reportedOid, data, err := getBlob(stream)
require.NoError(t, err, "consume response")
require.Equal(t, tc.expectedSize, reportedSize, "real blob size")
require.NotEmpty(t, reportedOid)
require.True(t, bytes.Equal(tc.expectedContent, data), "returned data exactly as expected")
})
}
}
func TestGetBlob_notFound(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, client := setupWithoutRepo(t, ctx)
repo, _ := gittest.CreateRepository(t, ctx, cfg)
stream, err := client.GetBlob(ctx, &gitalypb.GetBlobRequest{
Repository: repo,
Oid: "doesnotexist",
})
require.NoError(t, err)
reportedSize, reportedOid, data, err := getBlob(stream)
require.NoError(t, err)
require.Zero(t, reportedSize)
require.Empty(t, reportedOid)
require.Zero(t, len(data))
}
func getBlob(stream gitalypb.BlobService_GetBlobClient) (int64, string, []byte, error) {
firstResponse, err := stream.Recv()
if err != nil {
return 0, "", nil, err
}
data := &bytes.Buffer{}
_, err = data.Write(firstResponse.GetData())
if err != nil {
return 0, "", nil, err
}
reader := streamio.NewReader(func() ([]byte, error) {
response, err := stream.Recv()
if response.GetSize() != 0 {
return nil, fmt.Errorf("size may only be set in the first response message")
}
if len(response.GetOid()) != 0 {
return nil, fmt.Errorf("oid may only be set in the first response message")
}
return response.GetData(), err
})
_, err = io.Copy(data, reader)
return firstResponse.Size, firstResponse.Oid, data.Bytes(), err
}
func TestGetBlob_invalidRequest(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, client := setupWithoutRepo(t, ctx)
repo, _ := gittest.CreateRepository(t, ctx, cfg)
oid := localrepo.MustWriteBlob(t, localrepo.NewTestRepo(t, cfg, repo), "", "something").String()
for _, tc := range []struct {
desc string
request *gitalypb.GetBlobRequest
expectedErr error
}{
{
desc: "missing repository",
request: &gitalypb.GetBlobRequest{
Repository: nil,
Oid: oid,
},
expectedErr: structerr.NewInvalidArgument(testhelper.GitalyOrPraefect(
"empty Repository",
"repo scoped: empty Repository",
)),
},
{
desc: "invalid storage name",
request: &gitalypb.GetBlobRequest{
Repository: &gitalypb.Repository{
StorageName: "fake",
RelativePath: "path",
},
Oid: oid,
},
expectedErr: structerr.NewInvalidArgument(testhelper.GitalyOrPraefect(
fmt.Sprintf("create object reader: GetStorageByName: no such storage: %q", "fake"),
"repo scoped: invalid Repository",
)),
},
{
desc: "invalid relative path",
request: &gitalypb.GetBlobRequest{
Repository: &gitalypb.Repository{
StorageName: cfg.Storages[0].Name,
RelativePath: "path",
},
Oid: oid,
},
expectedErr: structerr.NewNotFound(testhelper.GitalyOrPraefect(
fmt.Sprintf("create object reader: GetRepoPath: not a git repository: %q", filepath.Join(cfg.Storages[0].Path, "path")),
fmt.Sprintf("accessor call: route repository accessor: consistent storages: repository %q/%q not found", cfg.Storages[0].Name, "path"),
)),
},
{
desc: "missing object ID",
request: &gitalypb.GetBlobRequest{
Repository: repo,
},
expectedErr: structerr.NewInvalidArgument("empty Oid"),
},
} {
t.Run(tc.desc, func(t *testing.T) {
stream, err := client.GetBlob(ctx, tc.request)
require.NoError(t, err)
_, err = stream.Recv()
testhelper.RequireGrpcError(t, tc.expectedErr, err)
})
}
}
|
