1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
|
package commit
import (
"fmt"
"io"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v14/internal/helper"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"
)
func TestCheckObjectsExist(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, client := setupCommitService(ctx, t)
repo, repoPath := gittest.CreateRepository(ctx, t, cfg)
commitID1 := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithBranch("master"), gittest.WithMessage("commit-1"), gittest.WithParents(),
)
commitID2 := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithBranch("feature"), gittest.WithMessage("commit-2"), gittest.WithParents(commitID1),
)
commitID3 := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithMessage("commit-3"), gittest.WithParents(commitID1),
)
for _, tc := range []struct {
desc string
requests []*gitalypb.CheckObjectsExistRequest
expectedResults map[string]bool
expectedErr error
}{
{
desc: "no requests",
requests: []*gitalypb.CheckObjectsExistRequest{},
// Ideally, we'd return an invalid-argument error in case there aren't any
// requests. We can't do this though as this would diverge from Praefect's
// behaviour, which always returns `io.EOF`.
expectedResults: map[string]bool{},
},
{
desc: "missing repository",
requests: []*gitalypb.CheckObjectsExistRequest{
{
Revisions: [][]byte{},
},
},
expectedErr: func() error {
if testhelper.IsPraefectEnabled() {
return helper.ErrInvalidArgumentf("repo scoped: empty Repository")
}
return helper.ErrInvalidArgumentf("empty Repository")
}(),
expectedResults: map[string]bool{},
},
{
desc: "request without revisions",
requests: []*gitalypb.CheckObjectsExistRequest{
{
Repository: repo,
},
},
expectedResults: map[string]bool{},
},
{
desc: "commit ids and refs that exist",
requests: []*gitalypb.CheckObjectsExistRequest{
{
Repository: repo,
Revisions: [][]byte{
[]byte(commitID1),
[]byte("master"),
[]byte(commitID2),
[]byte(commitID3),
[]byte("feature"),
},
},
},
expectedResults: map[string]bool{
commitID1.String(): true,
"master": true,
commitID2.String(): true,
commitID3.String(): true,
"feature": true,
},
},
{
desc: "ref and objects missing",
requests: []*gitalypb.CheckObjectsExistRequest{
{
Repository: repo,
Revisions: [][]byte{
[]byte(commitID1),
[]byte("master"),
[]byte(commitID2),
[]byte(commitID3),
[]byte("feature"),
[]byte("refs/does/not/exist"),
},
},
},
expectedResults: map[string]bool{
commitID1.String(): true,
"master": true,
commitID2.String(): true,
commitID3.String(): true,
"feature": true,
"refs/does/not/exist": false,
},
},
{
desc: "chunked input",
requests: []*gitalypb.CheckObjectsExistRequest{
{
Repository: repo,
Revisions: [][]byte{
[]byte(commitID1),
},
},
{
Revisions: [][]byte{
[]byte(commitID2),
},
},
{
Revisions: [][]byte{
[]byte("refs/does/not/exist"),
},
},
{
Revisions: [][]byte{
[]byte(commitID3),
},
},
},
expectedResults: map[string]bool{
commitID1.String(): true,
commitID2.String(): true,
commitID3.String(): true,
"refs/does/not/exist": false,
},
},
{
desc: "invalid input",
requests: []*gitalypb.CheckObjectsExistRequest{
{
Repository: repo,
Revisions: [][]byte{
[]byte("-not-a-rev"),
},
},
},
expectedErr: helper.ErrInvalidArgumentf("invalid revision %q: revision can't start with '-'", "-not-a-rev"),
expectedResults: map[string]bool{},
},
{
desc: "input with whitespace",
requests: []*gitalypb.CheckObjectsExistRequest{
{
Repository: repo,
Revisions: [][]byte{
[]byte(fmt.Sprintf("%s\n%s", commitID1, commitID2)),
},
},
},
// This is a bug: instead of disallowing revisions with newlines, we just
// handle them funnily. Git things we're asking it for two different
// revisions, and we expect only one output. So the result is that this
// weirdly formatted revision looks like it would exist. Instead, we should
// raise an error.
expectedErr: nil,
expectedResults: map[string]bool{
fmt.Sprintf("%s\n%s", commitID1, commitID2): true,
},
},
{
desc: "chunked invalid input",
requests: []*gitalypb.CheckObjectsExistRequest{
{
Repository: repo,
Revisions: [][]byte{
[]byte(commitID1),
},
},
{
Revisions: [][]byte{
[]byte("-not-a-rev"),
},
},
},
expectedErr: helper.ErrInvalidArgumentf("invalid revision %q: revision can't start with '-'", "-not-a-rev"),
expectedResults: map[string]bool{},
},
} {
t.Run(tc.desc, func(t *testing.T) {
client, err := client.CheckObjectsExist(ctx)
require.NoError(t, err)
for _, request := range tc.requests {
require.NoError(t, client.Send(request))
}
require.NoError(t, client.CloseSend())
results := map[string]bool{}
for {
var response *gitalypb.CheckObjectsExistResponse
response, err = client.Recv()
if err != nil {
break
}
for _, revision := range response.GetRevisions() {
results[string(revision.GetName())] = revision.GetExists()
}
}
if tc.expectedErr == nil {
tc.expectedErr = io.EOF
}
testhelper.RequireGrpcError(t, tc.expectedErr, err)
require.Equal(t, tc.expectedResults, results)
})
}
}
|
