1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
|
package diff
import (
"fmt"
"strings"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v16/internal/gitaly/storage"
"gitlab.com/gitlab-org/gitaly/v16/internal/structerr"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v16/proto/go/gitalypb"
)
func TestGetPatchID(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, client := setupDiffService(t)
type setupData struct {
request *gitalypb.GetPatchIDRequest
expectedResponse *gitalypb.GetPatchIDResponse
expectedErr error
}
testCases := []struct {
desc string
setup func(t *testing.T) setupData
}{
{
desc: "retruns patch-id successfully",
setup: func(t *testing.T) setupData {
repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg)
oldCommit := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "file", Mode: "100644", Content: "old"},
),
)
gittest.WriteCommit(t, cfg, repoPath,
gittest.WithBranch("main"),
gittest.WithParents(oldCommit),
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "file", Mode: "100644", Content: "new"},
),
)
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
OldRevision: []byte("main~"),
NewRevision: []byte("main"),
},
expectedResponse: &gitalypb.GetPatchIDResponse{
PatchId: "a79c7e9df0094ee44fa7a2a9ae27e914e6b7e00b",
},
}
},
},
{
desc: "returns patch-id successfully with commit ids",
setup: func(t *testing.T) setupData {
repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg)
oldCommit := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "file", Mode: "100644", Content: "old"},
),
)
newCommit := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "file", Mode: "100644", Content: "new"},
),
)
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
OldRevision: []byte(oldCommit),
NewRevision: []byte(newCommit),
},
expectedResponse: &gitalypb.GetPatchIDResponse{
PatchId: "a79c7e9df0094ee44fa7a2a9ae27e914e6b7e00b",
},
}
},
},
{
desc: "returns patch-id successfully for a specific file",
setup: func(t *testing.T) setupData {
repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg)
oldCommit := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "file", Mode: "100644", Content: "old"},
),
)
newCommit := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "file", Mode: "100644", Content: "new"},
),
)
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
OldRevision: []byte(fmt.Sprintf("%s:file", oldCommit)),
NewRevision: []byte(fmt.Sprintf("%s:file", newCommit)),
},
expectedResponse: &gitalypb.GetPatchIDResponse{
PatchId: "a79c7e9df0094ee44fa7a2a9ae27e914e6b7e00b",
},
}
},
},
{
desc: "returns patch-id with binary file",
setup: func(t *testing.T) setupData {
repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg)
oldCommit := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "binary", Mode: "100644", Content: "\000old"},
),
)
newCommit := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "binary", Mode: "100644", Content: "\000new"},
),
)
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
OldRevision: []byte(oldCommit),
NewRevision: []byte(newCommit),
},
expectedResponse: &gitalypb.GetPatchIDResponse{
PatchId: func() string {
// Before Git v2.39.0, git-patch-id(1) would skip over any
// lines that have an "index " prefix. This causes issues
// with diffs of binaries though: we don't generate the diff
// with `--binary`, so the "index" line that contains the
// pre- and post-image blob IDs of the binary is the only
// bit of information we have that something changed. But
// because Git used to skip over it we wouldn't actually
// take into account the contents of the changed blob at
// all.
//
// This was fixed in Git v2.39.0 so that "index" lines will
// now be hashed to correctly account for binary changes. As
// a result, the patch ID has changed.
switch gittest.DefaultObjectHash.Format {
case "sha1":
return "13e4e9b9cd44ec511bac24fdbdeab9b74ba3000b"
case "sha256":
return "32f6beb9a210ac89a3e15e44dcd174c87c904e9d"
default:
require.FailNow(t, "unsupported object hash")
return ""
}
}(),
},
}
},
},
{
// This test is essentially the same test set up as the preceding one, but
// with different binary contents. This is done to ensure that we indeed
// generate different patch IDs as expected.
desc: "different binary diff has different patch ID",
setup: func(t *testing.T) setupData {
repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg)
oldCommit := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "binary", Mode: "100644", Content: "\000old2"},
),
)
newCommit := gittest.WriteCommit(t, cfg, repoPath,
gittest.WithTreeEntries(
gittest.TreeEntry{Path: "binary", Mode: "100644", Content: "\000new2"},
),
)
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
OldRevision: []byte(oldCommit),
NewRevision: []byte(newCommit),
},
expectedResponse: &gitalypb.GetPatchIDResponse{
PatchId: func() string {
switch gittest.DefaultObjectHash.Format {
case "sha1":
return "f678855867b112ac2c5466260b3b3a5e75fca875"
case "sha256":
return "10443cf318b577ea41526825ba034aaaedfeaa4b"
default:
require.FailNow(t, "unsupported object hash")
return ""
}
}(),
},
}
},
},
{
desc: "file didn't exist in the old revision",
setup: func(t *testing.T) setupData {
repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg)
oldCommit := gittest.WriteCommit(t, cfg, repoPath)
newCommit := gittest.WriteCommit(t, cfg, repoPath, gittest.WithTreeEntries(
gittest.TreeEntry{Path: "file", Mode: "100644", Content: "new"},
))
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
OldRevision: []byte(fmt.Sprintf("%s:file", oldCommit)),
NewRevision: []byte(fmt.Sprintf("%s:file", newCommit)),
},
//nolint:gitaly-linters
expectedErr: testhelper.WithInterceptedMetadata(
structerr.NewInternal("waiting for git-diff: exit status 128"),
"stderr", fmt.Sprintf("fatal: path 'file' does not exist in '%s'\n", oldCommit)),
}
},
},
{
desc: "unknown revisions",
setup: func(t *testing.T) setupData {
repoProto, _ := gittest.CreateRepository(t, ctx, cfg)
newRevision := strings.Replace(string(gittest.DefaultObjectHash.ZeroOID), "0", "1", -1)
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
OldRevision: []byte(gittest.DefaultObjectHash.ZeroOID),
NewRevision: []byte(newRevision),
},
expectedErr: testhelper.WithInterceptedMetadata(
structerr.NewInternal("waiting for git-diff: exit status 128"),
"stderr", fmt.Sprintf("fatal: bad object %s\n", gittest.DefaultObjectHash.ZeroOID)),
}
},
},
{
desc: "no diff from the given revisions",
setup: func(t *testing.T) setupData {
repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg)
commit := gittest.WriteCommit(t, cfg, repoPath)
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
OldRevision: []byte(commit),
NewRevision: []byte(commit),
},
expectedErr: structerr.NewFailedPrecondition("no difference between old and new revision"),
}
},
},
{
desc: "empty repository",
setup: func(t *testing.T) setupData {
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: nil,
OldRevision: []byte("HEAD~1"),
NewRevision: []byte("HEAD"),
},
expectedErr: structerr.NewInvalidArgument("%w", storage.ErrRepositoryNotSet),
}
},
},
{
desc: "empty old revision",
setup: func(t *testing.T) setupData {
repoProto, _ := gittest.CreateRepository(t, ctx, cfg)
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
NewRevision: []byte("HEAD"),
},
expectedErr: structerr.NewInvalidArgument("empty OldRevision"),
}
},
},
{
desc: "empty new revision",
setup: func(t *testing.T) setupData {
repoProto, _ := gittest.CreateRepository(t, ctx, cfg)
return setupData{
request: &gitalypb.GetPatchIDRequest{
Repository: repoProto,
OldRevision: []byte("HEAD~1"),
},
expectedErr: structerr.NewInvalidArgument("empty NewRevision"),
}
},
},
}
for _, tc := range testCases {
tc := tc
t.Run(tc.desc, func(t *testing.T) {
t.Parallel()
setupData := tc.setup(t)
response, err := client.GetPatchID(ctx, setupData.request)
testhelper.RequireGrpcError(t, setupData.expectedErr, err)
testhelper.ProtoEqual(t, setupData.expectedResponse, response)
})
}
}
|
