1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
|
package diff
import (
"fmt"
"io"
"regexp"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"
"gitlab.com/gitlab-org/gitaly/v14/streamio"
"google.golang.org/grpc/codes"
)
func TestSuccessfulRawDiffRequest(t *testing.T) {
ctx := testhelper.Context(t)
cfg, repo, repoPath, client := setupDiffService(ctx, t)
rightCommit := "e395f646b1499e8e0279445fc99a0596a65fab7e"
leftCommit := "8a0f2ee90d940bfb0ba1e14e8214b0649056e4ab"
rpcRequest := &gitalypb.RawDiffRequest{Repository: repo, RightCommitId: rightCommit, LeftCommitId: leftCommit}
c, err := client.RawDiff(ctx, rpcRequest)
require.NoError(t, err)
_, sandboxRepoPath := gittest.CloneRepo(t, cfg, cfg.Storages[0], gittest.CloneRepoOpts{
WithWorktree: true,
})
reader := streamio.NewReader(func() ([]byte, error) {
response, err := c.Recv()
return response.GetData(), err
})
committerName := "Scrooge McDuck"
committerEmail := "scrooge@mcduck.com"
gittest.Exec(t, cfg, "-C", sandboxRepoPath, "reset", "--hard", leftCommit)
gittest.ExecOpts(t, cfg, gittest.ExecConfig{Stdin: reader}, "-C", sandboxRepoPath, "apply")
gittest.Exec(t, cfg, "-C", sandboxRepoPath, "add", ".")
gittest.Exec(t, cfg, "-C", sandboxRepoPath,
"-c", fmt.Sprintf("user.name=%s", committerName),
"-c", fmt.Sprintf("user.email=%s", committerEmail),
"commit", "-m", "Applying received raw diff")
expectedTreeStructure := gittest.Exec(t, cfg, "-C", repoPath, "ls-tree", "-r", rightCommit)
actualTreeStructure := gittest.Exec(t, cfg, "-C", sandboxRepoPath, "ls-tree", "-r", "HEAD")
require.Equal(t, expectedTreeStructure, actualTreeStructure)
}
func TestFailedRawDiffRequestDueToValidations(t *testing.T) {
ctx := testhelper.Context(t)
_, repo, _, client := setupDiffService(ctx, t)
testCases := []struct {
desc string
request *gitalypb.RawDiffRequest
code codes.Code
}{
{
desc: "empty left commit",
request: &gitalypb.RawDiffRequest{
Repository: repo,
LeftCommitId: "",
RightCommitId: "e395f646b1499e8e0279445fc99a0596a65fab7e",
},
code: codes.InvalidArgument,
},
{
desc: "empty right commit",
request: &gitalypb.RawDiffRequest{
Repository: repo,
RightCommitId: "",
LeftCommitId: "e395f646b1499e8e0279445fc99a0596a65fab7e",
},
code: codes.InvalidArgument,
},
{
desc: "empty repo",
request: &gitalypb.RawDiffRequest{
Repository: nil,
RightCommitId: "8a0f2ee90d940bfb0ba1e14e8214b0649056e4ab",
LeftCommitId: "e395f646b1499e8e0279445fc99a0596a65fab7e",
},
code: codes.InvalidArgument,
},
}
for _, testCase := range testCases {
t.Run(testCase.desc, func(t *testing.T) {
c, _ := client.RawDiff(ctx, testCase.request)
testhelper.RequireGrpcCode(t, drainRawDiffResponse(c), testCase.code)
})
}
}
func TestSuccessfulRawPatchRequest(t *testing.T) {
ctx := testhelper.Context(t)
cfg, repo, repoPath, client := setupDiffService(ctx, t)
rightCommit := "e395f646b1499e8e0279445fc99a0596a65fab7e"
leftCommit := "8a0f2ee90d940bfb0ba1e14e8214b0649056e4ab"
rpcRequest := &gitalypb.RawPatchRequest{Repository: repo, RightCommitId: rightCommit, LeftCommitId: leftCommit}
c, err := client.RawPatch(ctx, rpcRequest)
require.NoError(t, err)
reader := streamio.NewReader(func() ([]byte, error) {
response, err := c.Recv()
return response.GetData(), err
})
_, sandboxRepoPath := gittest.CloneRepo(t, cfg, cfg.Storages[0], gittest.CloneRepoOpts{
WithWorktree: true,
})
gittest.Exec(t, cfg, "-C", sandboxRepoPath, "reset", "--hard", leftCommit)
gittest.ExecOpts(t, cfg, gittest.ExecConfig{Stdin: reader}, "-C", sandboxRepoPath, "am")
expectedTreeStructure := gittest.Exec(t, cfg, "-C", repoPath, "ls-tree", "-r", rightCommit)
actualTreeStructure := gittest.Exec(t, cfg, "-C", sandboxRepoPath, "ls-tree", "-r", "HEAD")
require.Equal(t, expectedTreeStructure, actualTreeStructure)
}
func TestFailedRawPatchRequestDueToValidations(t *testing.T) {
ctx := testhelper.Context(t)
_, repo, _, client := setupDiffService(ctx, t)
testCases := []struct {
desc string
request *gitalypb.RawPatchRequest
code codes.Code
}{
{
desc: "empty left commit",
request: &gitalypb.RawPatchRequest{
Repository: repo,
LeftCommitId: "",
RightCommitId: "e395f646b1499e8e0279445fc99a0596a65fab7e",
},
code: codes.InvalidArgument,
},
{
desc: "empty right commit",
request: &gitalypb.RawPatchRequest{
Repository: repo,
RightCommitId: "",
LeftCommitId: "e395f646b1499e8e0279445fc99a0596a65fab7e",
},
code: codes.InvalidArgument,
},
{
desc: "empty repo",
request: &gitalypb.RawPatchRequest{
Repository: nil,
RightCommitId: "8a0f2ee90d940bfb0ba1e14e8214b0649056e4ab",
LeftCommitId: "e395f646b1499e8e0279445fc99a0596a65fab7e",
},
code: codes.InvalidArgument,
},
}
for _, testCase := range testCases {
t.Run(testCase.desc, func(t *testing.T) {
c, _ := client.RawPatch(ctx, testCase.request)
testhelper.RequireGrpcCode(t, drainRawPatchResponse(c), testCase.code)
})
}
}
func TestRawPatchContainsGitLabSignature(t *testing.T) {
ctx := testhelper.Context(t)
_, repo, _, client := setupDiffService(ctx, t)
rightCommit := "e395f646b1499e8e0279445fc99a0596a65fab7e"
leftCommit := "8a0f2ee90d940bfb0ba1e14e8214b0649056e4ab"
rpcRequest := &gitalypb.RawPatchRequest{Repository: repo, RightCommitId: rightCommit, LeftCommitId: leftCommit}
c, err := client.RawPatch(ctx, rpcRequest)
require.NoError(t, err)
reader := streamio.NewReader(func() ([]byte, error) {
response, err := c.Recv()
return response.GetData(), err
})
patch, err := io.ReadAll(reader)
require.NoError(t, err)
require.Regexp(t, regexp.MustCompile(`\n-- \nGitLab\s+$`), string(patch))
}
func drainRawDiffResponse(c gitalypb.DiffService_RawDiffClient) error {
var err error
for err == nil {
_, err = c.Recv()
}
return err
}
func drainRawPatchResponse(c gitalypb.DiffService_RawPatchClient) error {
var err error
for err == nil {
_, err = c.Recv()
}
return err
}
|