1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
|
package hook
import (
"context"
"crypto/sha1"
"net"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/backchannel"
"gitlab.com/gitlab-org/gitaly/internal/git"
"gitlab.com/gitlab-org/gitaly/internal/helper"
"gitlab.com/gitlab-org/gitaly/internal/metadata/featureflag"
"gitlab.com/gitlab-org/gitaly/internal/praefect/metadata"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testserver"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
)
type testTransactionServer struct {
gitalypb.UnimplementedRefTransactionServer
handler func(in *gitalypb.VoteTransactionRequest) (*gitalypb.VoteTransactionResponse, error)
}
func (s *testTransactionServer) VoteTransaction(ctx context.Context, in *gitalypb.VoteTransactionRequest) (*gitalypb.VoteTransactionResponse, error) {
if s.handler != nil {
return s.handler(in)
}
return nil, nil
}
func TestReferenceTransactionHookInvalidArgument(t *testing.T) {
cfg := testcfg.Build(t)
serverSocketPath := runHooksServer(t, cfg, nil)
client, conn := newHooksClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
stream, err := client.ReferenceTransactionHook(ctx)
require.NoError(t, err)
require.NoError(t, stream.Send(&gitalypb.ReferenceTransactionHookRequest{}))
_, err = stream.Recv()
testhelper.RequireGrpcError(t, err, codes.InvalidArgument)
}
func TestReferenceTransactionHook(t *testing.T) {
testhelper.NewFeatureSets([]featureflag.FeatureFlag{
featureflag.BackchannelVoting,
}).Run(t, func(t *testing.T, ctx context.Context) {
testCases := []struct {
desc string
stdin []byte
state gitalypb.ReferenceTransactionHookRequest_State
voteResponse gitalypb.VoteTransactionResponse_TransactionState
expectedCode codes.Code
expectedReftxHash []byte
}{
{
desc: "hook triggers transaction with default state",
stdin: []byte("foobar"),
voteResponse: gitalypb.VoteTransactionResponse_COMMIT,
expectedCode: codes.OK,
expectedReftxHash: []byte("foobar"),
},
{
desc: "hook triggers transaction with explicit prepared state",
stdin: []byte("foobar"),
state: gitalypb.ReferenceTransactionHookRequest_PREPARED,
voteResponse: gitalypb.VoteTransactionResponse_COMMIT,
expectedCode: codes.OK,
expectedReftxHash: []byte("foobar"),
},
{
desc: "hook does not trigger transaction with aborted state",
stdin: []byte("foobar"),
state: gitalypb.ReferenceTransactionHookRequest_ABORTED,
expectedCode: codes.OK,
},
{
desc: "hook does not trigger transaction with committed state",
stdin: []byte("foobar"),
state: gitalypb.ReferenceTransactionHookRequest_COMMITTED,
expectedCode: codes.OK,
},
{
desc: "hook fails with failed vote",
stdin: []byte("foobar"),
voteResponse: gitalypb.VoteTransactionResponse_ABORT,
expectedCode: codes.Aborted,
expectedReftxHash: []byte("foobar"),
},
{
desc: "hook fails with stopped vote",
stdin: []byte("foobar"),
voteResponse: gitalypb.VoteTransactionResponse_STOP,
expectedCode: codes.FailedPrecondition,
expectedReftxHash: []byte("foobar"),
},
}
transactionServer := &testTransactionServer{}
grpcServer := grpc.NewServer()
gitalypb.RegisterRefTransactionServer(grpcServer, transactionServer)
listener, err := net.Listen("tcp", "127.0.0.1:0")
require.NoError(t, err)
backchannelConn, err := grpc.Dial(listener.Addr().String(), grpc.WithInsecure())
require.NoError(t, err)
defer backchannelConn.Close()
registry := backchannel.NewRegistry()
backchannelID := registry.RegisterBackchannel(backchannelConn)
errQ := make(chan error)
go func() {
errQ <- grpcServer.Serve(listener)
}()
defer func() {
grpcServer.Stop()
require.NoError(t, <-errQ)
}()
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
cfg, repo, _ := testcfg.BuildWithRepo(t)
var reftxHash []byte
transactionServer.handler = func(in *gitalypb.VoteTransactionRequest) (*gitalypb.VoteTransactionResponse, error) {
reftxHash = in.ReferenceUpdatesHash
return &gitalypb.VoteTransactionResponse{
State: tc.voteResponse,
}, nil
}
serverSocketPath := runHooksServer(t, cfg, nil, testserver.WithBackchannelRegistry(registry))
praefectServer := &metadata.PraefectServer{ListenAddr: "tcp://" + listener.Addr().String()}
if featureflag.IsEnabled(ctx, featureflag.BackchannelVoting) {
praefectServer = &metadata.PraefectServer{BackchannelID: backchannelID}
}
hooksPayload, err := git.NewHooksPayload(
cfg,
repo,
&metadata.Transaction{
ID: 1234,
Node: "node-1",
},
praefectServer,
nil,
git.ReferenceTransactionHook,
featureflag.RawFromContext(ctx),
).Env()
require.NoError(t, err)
environment := []string{
hooksPayload,
}
client, conn := newHooksClient(t, serverSocketPath)
defer conn.Close()
stream, err := client.ReferenceTransactionHook(ctx)
require.NoError(t, err)
require.NoError(t, stream.Send(&gitalypb.ReferenceTransactionHookRequest{
Repository: repo,
State: tc.state,
EnvironmentVariables: environment,
}))
require.NoError(t, stream.Send(&gitalypb.ReferenceTransactionHookRequest{
Stdin: tc.stdin,
}))
require.NoError(t, stream.CloseSend())
resp, err := stream.Recv()
require.Equal(t, helper.GrpcCode(err), tc.expectedCode)
if tc.expectedCode == codes.OK {
require.Equal(t, resp.GetExitStatus().GetValue(), int32(0))
}
var expectedReftxHash []byte
if tc.expectedReftxHash != nil {
hash := sha1.Sum(tc.expectedReftxHash)
expectedReftxHash = hash[:]
}
require.Equal(t, expectedReftxHash[:], reftxHash)
})
}
})
}
|
