1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
|
package ref
import (
"context"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/service"
hookservice "gitlab.com/gitlab-org/gitaly/internal/gitaly/service/hook"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/transaction"
"gitlab.com/gitlab-org/gitaly/internal/helper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testserver"
"gitlab.com/gitlab-org/gitaly/internal/transaction/txinfo"
"gitlab.com/gitlab-org/gitaly/internal/transaction/voting"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
)
func TestSuccessfulDeleteRefs(t *testing.T) {
cfg, client := setupRefServiceWithoutRepo(t)
testCases := []struct {
desc string
request *gitalypb.DeleteRefsRequest
}{
{
desc: "delete all except refs with certain prefixes",
request: &gitalypb.DeleteRefsRequest{
ExceptWithPrefix: [][]byte{[]byte("refs/keep"), []byte("refs/also-keep"), []byte("refs/heads/")},
},
},
{
desc: "delete certain refs",
request: &gitalypb.DeleteRefsRequest{
Refs: [][]byte{[]byte("refs/delete/a"), []byte("refs/also-delete/b")},
},
},
}
for _, testCase := range testCases {
t.Run(testCase.desc, func(t *testing.T) {
repo, repoPath, cleanupFn := gittest.CloneRepoAtStorage(t, cfg.Storages[0], testCase.desc)
defer cleanupFn()
testhelper.MustRunCommand(t, nil, "git", "-C", repoPath, "update-ref", "refs/delete/a", "b83d6e391c22777fca1ed3012fce84f633d7fed0")
testhelper.MustRunCommand(t, nil, "git", "-C", repoPath, "update-ref", "refs/also-delete/b", "1b12f15a11fc6e62177bef08f47bc7b5ce50b141")
testhelper.MustRunCommand(t, nil, "git", "-C", repoPath, "update-ref", "refs/keep/c", "498214de67004b1da3d820901307bed2a68a8ef6")
testhelper.MustRunCommand(t, nil, "git", "-C", repoPath, "update-ref", "refs/also-keep/d", "b83d6e391c22777fca1ed3012fce84f633d7fed0")
ctx, cancel := testhelper.Context()
defer cancel()
testCase.request.Repository = repo
_, err := client.DeleteRefs(ctx, testCase.request)
require.NoError(t, err)
// Ensure that the internal refs are gone, but the others still exist
refs, err := localrepo.NewTestRepo(t, cfg, repo).GetReferences(ctx, "refs/")
require.NoError(t, err)
refNames := make([]string, len(refs))
for i, branch := range refs {
refNames[i] = branch.Name.String()
}
require.NotContains(t, refNames, "refs/delete/a")
require.NotContains(t, refNames, "refs/also-delete/b")
require.Contains(t, refNames, "refs/keep/c")
require.Contains(t, refNames, "refs/also-keep/d")
require.Contains(t, refNames, "refs/heads/master")
})
}
}
func TestDeleteRefs_transaction(t *testing.T) {
cfg := testcfg.Build(t)
testhelper.ConfigureGitalyHooksBin(t, cfg)
var votes int
txManager := &transaction.MockManager{
VoteFn: func(context.Context, txinfo.Transaction, txinfo.PraefectServer, voting.Vote) error {
votes++
return nil
},
}
addr := testserver.RunGitalyServer(t, cfg, nil, func(srv *grpc.Server, deps *service.Dependencies) {
gitalypb.RegisterRefServiceServer(srv, NewServer(
deps.GetCfg(),
deps.GetLocator(),
deps.GetGitCmdFactory(),
deps.GetTxManager(),
deps.GetCatfileCache(),
))
gitalypb.RegisterHookServiceServer(srv, hookservice.NewServer(deps.GetCfg(), deps.GetHookManager(), deps.GetGitCmdFactory()))
}, testserver.WithTransactionManager(txManager))
client, conn := newRefServiceClient(t, addr)
t.Cleanup(func() { conn.Close() })
ctx, cancel := testhelper.Context()
t.Cleanup(cancel)
ctx, err := txinfo.InjectTransaction(ctx, 1, "node", true)
require.NoError(t, err)
ctx, err = (&txinfo.PraefectServer{SocketPath: "i-dont-care"}).Inject(ctx)
require.NoError(t, err)
ctx = helper.IncomingToOutgoing(ctx)
for _, tc := range []struct {
desc string
request *gitalypb.DeleteRefsRequest
expectedVotes int
}{
{
desc: "delete nothing",
request: &gitalypb.DeleteRefsRequest{
ExceptWithPrefix: [][]byte{[]byte("refs/")},
},
expectedVotes: 1,
},
{
desc: "delete all refs",
request: &gitalypb.DeleteRefsRequest{
ExceptWithPrefix: [][]byte{[]byte("nonexisting/prefix/")},
},
expectedVotes: 1,
},
} {
t.Run(tc.desc, func(t *testing.T) {
votes = 0
repo, _, cleanup := gittest.CloneRepoAtStorage(t, cfg.Storages[0], tc.desc)
t.Cleanup(cleanup)
tc.request.Repository = repo
response, err := client.DeleteRefs(ctx, tc.request)
require.NoError(t, err)
require.Empty(t, response.GitError)
require.Equal(t, tc.expectedVotes, votes)
})
}
}
func TestFailedDeleteRefsRequestDueToGitError(t *testing.T) {
_, repo, _, client := setupRefService(t)
ctx, cancel := testhelper.Context()
defer cancel()
request := &gitalypb.DeleteRefsRequest{
Repository: repo,
Refs: [][]byte{[]byte(`refs\tails\invalid-ref-format`)},
}
response, err := client.DeleteRefs(ctx, request)
require.NoError(t, err)
assert.Contains(t, response.GitError, "unable to delete refs")
}
func TestFailedDeleteRefsDueToValidation(t *testing.T) {
_, repo, _, client := setupRefService(t)
testCases := []struct {
desc string
request *gitalypb.DeleteRefsRequest
// repo *gitalypb.Repository
// prefixes [][]byte
code codes.Code
}{
{
desc: "Invalid repository",
request: &gitalypb.DeleteRefsRequest{
Repository: &gitalypb.Repository{StorageName: "fake", RelativePath: "path"},
ExceptWithPrefix: [][]byte{[]byte("exclude-this")},
},
code: codes.InvalidArgument,
},
{
desc: "Repository is nil",
request: &gitalypb.DeleteRefsRequest{
Repository: nil,
ExceptWithPrefix: [][]byte{[]byte("exclude-this")},
},
code: codes.InvalidArgument,
},
{
desc: "No prefixes nor refs",
request: &gitalypb.DeleteRefsRequest{
Repository: repo,
},
code: codes.InvalidArgument,
},
{
desc: "prefixes with refs",
request: &gitalypb.DeleteRefsRequest{
Repository: repo,
ExceptWithPrefix: [][]byte{[]byte("exclude-this")},
Refs: [][]byte{[]byte("delete-this")},
},
code: codes.InvalidArgument,
},
{
desc: "Empty prefix",
request: &gitalypb.DeleteRefsRequest{
Repository: repo,
ExceptWithPrefix: [][]byte{[]byte("exclude-this"), []byte{}},
},
code: codes.InvalidArgument,
},
{
desc: "Empty ref",
request: &gitalypb.DeleteRefsRequest{
Repository: repo,
Refs: [][]byte{[]byte("delete-this"), []byte{}},
},
code: codes.InvalidArgument,
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
_, err := client.DeleteRefs(ctx, tc.request)
testhelper.RequireGrpcError(t, err, tc.code)
})
}
}
|
