1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
package remote
import (
"fmt"
"net/http"
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/internal/helper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testserver"
"gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)
func TestFindRemoteRootRefSuccess(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, repo, repoPath, client := setupRemoteService(ctx, t)
gitCmdFactory := gittest.NewCommandFactory(t, cfg)
const (
host = "example.com"
secret = "mysecret"
)
port, stopGitServer := gittest.HTTPServer(ctx, t, gitCmdFactory, repoPath, newGitRequestValidationMiddleware(host, secret))
defer func() { require.NoError(t, stopGitServer()) }()
originURL := fmt.Sprintf("http://127.0.0.1:%d/%s", port, filepath.Base(repoPath))
for _, tc := range []struct {
desc string
request *gitalypb.FindRemoteRootRefRequest
}{
{
desc: "with remote URL",
request: &gitalypb.FindRemoteRootRefRequest{
Repository: repo,
RemoteUrl: originURL,
HttpAuthorizationHeader: secret,
HttpHost: host,
},
},
} {
t.Run(tc.desc, func(t *testing.T) {
response, err := client.FindRemoteRootRef(ctx, tc.request)
require.NoError(t, err)
require.Equal(t, "master", response.Ref)
})
}
}
func TestFindRemoteRootRefWithUnbornRemoteHead(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, remoteRepo, remoteRepoPath, client := setupRemoteService(ctx, t)
// We're creating an empty repository. Empty repositories do have a HEAD set up, but they
// point to an unborn branch because the default branch hasn't yet been created.
_, clientRepoPath := gittest.InitRepo(t, cfg, cfg.Storages[0])
gittest.Exec(t, cfg, "-C", remoteRepoPath, "remote", "add", "foo", "file://"+clientRepoPath)
response, err := client.FindRemoteRootRef(ctx, &gitalypb.FindRemoteRootRefRequest{
Repository: remoteRepo,
RemoteUrl: "file://" + clientRepoPath,
},
)
testhelper.RequireGrpcError(t, status.Error(codes.NotFound, "no remote HEAD found"), err)
require.Nil(t, response)
}
func TestFindRemoteRootRefFailedDueToValidation(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
// We're running tests with Praefect disabled given that we don't want to exercise
// Praefect's validation, but Gitaly's.
_, repo, _, client := setupRemoteService(ctx, t, testserver.WithDisablePraefect())
invalidRepo := &gitalypb.Repository{StorageName: "fake", RelativePath: "path"}
testCases := []struct {
desc string
request *gitalypb.FindRemoteRootRefRequest
expectedErr error
}{
{
desc: "Invalid repository",
request: &gitalypb.FindRemoteRootRefRequest{
Repository: invalidRepo,
RemoteUrl: "remote-url",
},
expectedErr: helper.ErrInvalidArgumentf("GetStorageByName: no such storage: \"fake\""),
},
{
desc: "Repository is nil",
request: &gitalypb.FindRemoteRootRefRequest{
RemoteUrl: "remote-url",
},
expectedErr: helper.ErrInvalidArgumentf("missing repository"),
},
{
desc: "Remote URL is empty",
request: &gitalypb.FindRemoteRootRefRequest{
Repository: repo,
},
expectedErr: helper.ErrInvalidArgumentf("missing remote URL"),
},
}
for _, testCase := range testCases {
t.Run(testCase.desc, func(t *testing.T) {
_, err := client.FindRemoteRootRef(ctx, testCase.request)
testhelper.RequireGrpcError(t, testCase.expectedErr, err)
})
}
}
func TestFindRemoteRootRefFailedDueToInvalidRemote(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
_, repo, _, client := setupRemoteService(ctx, t)
t.Run("invalid remote URL", func(t *testing.T) {
fakeRepoDir := testhelper.TempDir(t)
// We're using a nonexistent filepath remote URL so we avoid hitting the internet.
request := &gitalypb.FindRemoteRootRefRequest{
Repository: repo, RemoteUrl: "file://" + fakeRepoDir,
}
_, err := client.FindRemoteRootRef(ctx, request)
testhelper.RequireGrpcCode(t, err, codes.Internal)
})
}
func newGitRequestValidationMiddleware(host, secret string) func(http.ResponseWriter, *http.Request, http.Handler) {
return func(w http.ResponseWriter, r *http.Request, next http.Handler) {
if r.Host != host {
http.Error(w, "No Host", http.StatusBadRequest)
return
}
if r.Header.Get("Authorization") != secret {
http.Error(w, "Unauthorized", http.StatusUnauthorized)
return
}
next.ServeHTTP(w, r)
}
}
|
