1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
|
package repository
import (
"os"
"path/filepath"
"testing"
"time"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper/testserver"
"gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)
func TestWriteCommitGraph_withExistingCommitGraphCreatedWithDefaults(t *testing.T) {
cfg, repo, repoPath, client := setupRepositoryService(t)
commitGraphPath := filepath.Join(repoPath, CommitGraphRelPath)
require.NoFileExists(t, commitGraphPath, "sanity check no commit graph")
chainPath := filepath.Join(repoPath, CommitGraphChainRelPath)
require.NoFileExists(t, chainPath, "sanity check no commit graph chain exists")
// write commit graph using an old approach
gittest.Exec(t, cfg, "-C", repoPath, "commit-graph", "write", "--reachable")
require.FileExists(t, commitGraphPath)
treeEntry := gittest.TreeEntry{Mode: "100644", Path: "file.txt", Content: "something"}
gittest.WriteCommit(
t,
cfg,
repoPath,
gittest.WithBranch(t.Name()),
gittest.WithTreeEntries(treeEntry),
)
ctx, cancel := testhelper.Context()
defer cancel()
res, err := client.WriteCommitGraph(ctx, &gitalypb.WriteCommitGraphRequest{
Repository: repo,
SplitStrategy: gitalypb.WriteCommitGraphRequest_SizeMultiple,
})
require.NoError(t, err)
require.NotNil(t, res)
require.FileExists(t, chainPath, "commit graph chain should be created")
require.NoFileExists(t, commitGraphPath, "commit-graph file should be replaced with commit graph chain")
}
func TestWriteCommitGraph(t *testing.T) {
_, repo, repoPath, client := setupRepositoryService(t)
ctx, cancel := testhelper.Context()
defer cancel()
chainPath := filepath.Join(repoPath, CommitGraphChainRelPath)
require.NoFileExists(t, chainPath)
res, err := client.WriteCommitGraph(ctx, &gitalypb.WriteCommitGraphRequest{
Repository: repo,
SplitStrategy: gitalypb.WriteCommitGraphRequest_SizeMultiple,
})
require.NoError(t, err)
require.NotNil(t, res)
require.FileExists(t, chainPath)
}
func TestWriteCommitGraph_validationChecks(t *testing.T) {
_, repo, _, client := setupRepositoryService(t, testserver.WithDisablePraefect())
ctx, cancel := testhelper.Context()
defer cancel()
for _, tc := range []struct {
desc string
req *gitalypb.WriteCommitGraphRequest
expErr error
}{
{
desc: "invalid split strategy",
req: &gitalypb.WriteCommitGraphRequest{
Repository: repo,
SplitStrategy: gitalypb.WriteCommitGraphRequest_SplitStrategy(42),
},
expErr: status.Error(codes.InvalidArgument, "unsupported split strategy: 42"),
},
{
desc: "no repository",
req: &gitalypb.WriteCommitGraphRequest{},
expErr: status.Error(codes.InvalidArgument, `GetStorageByName: no such storage: ""`),
},
{
desc: "invalid storage",
req: &gitalypb.WriteCommitGraphRequest{Repository: &gitalypb.Repository{StorageName: "invalid"}},
expErr: status.Error(codes.InvalidArgument, `GetStorageByName: no such storage: "invalid"`),
},
} {
t.Run(tc.desc, func(t *testing.T) {
_, err := client.WriteCommitGraph(ctx, tc.req)
require.Equal(t, tc.expErr, err)
})
}
}
func TestUpdateCommitGraph(t *testing.T) {
cfg, repo, repoPath, client := setupRepositoryService(t)
ctx, cancel := testhelper.Context()
defer cancel()
chainPath := filepath.Join(repoPath, CommitGraphChainRelPath)
require.NoFileExists(t, chainPath)
res, err := client.WriteCommitGraph(ctx, &gitalypb.WriteCommitGraphRequest{
Repository: repo,
SplitStrategy: gitalypb.WriteCommitGraphRequest_SizeMultiple,
})
require.NoError(t, err)
require.NotNil(t, res)
require.FileExists(t, chainPath)
// Reset the mtime of commit-graph-chain file to use
// as basis to detect changes
require.NoError(t, os.Chtimes(chainPath, time.Time{}, time.Time{}))
info, err := os.Stat(chainPath)
require.NoError(t, err)
mt := info.ModTime()
treeEntry := gittest.TreeEntry{Mode: "100644", Path: "file.txt", Content: "something"}
gittest.WriteCommit(
t,
cfg,
repoPath,
gittest.WithBranch(t.Name()),
gittest.WithTreeEntries(treeEntry),
)
res, err = client.WriteCommitGraph(ctx, &gitalypb.WriteCommitGraphRequest{
Repository: repo,
SplitStrategy: gitalypb.WriteCommitGraphRequest_SizeMultiple,
})
require.NoError(t, err)
require.NotNil(t, res)
require.FileExists(t, chainPath)
assertModTimeAfter(t, mt, chainPath)
}
|
