1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
|
package repository
import (
"bytes"
"io"
"os"
"path/filepath"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git/log"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/internal/tempdir"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
"gitlab.com/gitlab-org/gitaly/streamio"
"google.golang.org/grpc/codes"
)
func TestServer_CreateRepositoryFromBundle_successful(t *testing.T) {
locator := config.NewLocator(config.Config)
serverSocketPath, stop := runRepoServer(t, locator, testhelper.WithInternalSocket(config.Config))
defer stop()
client, conn := newRepositoryClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
testRepo, testRepoPath, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
tmpdir, err := tempdir.New(ctx, testRepo)
require.NoError(t, err)
bundlePath := filepath.Join(tmpdir, "original.bundle")
testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "update-ref", "refs/custom-refs/ref1", "HEAD")
testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "bundle", "create", bundlePath, "--all")
defer os.RemoveAll(bundlePath)
stream, err := client.CreateRepositoryFromBundle(ctx)
require.NoError(t, err)
importedRepo := &gitalypb.Repository{
StorageName: testhelper.DefaultStorageName,
RelativePath: "a-repo-from-bundle",
}
importedRepoPath, err := locator.GetPath(importedRepo)
require.NoError(t, err)
defer os.RemoveAll(importedRepoPath)
request := &gitalypb.CreateRepositoryFromBundleRequest{Repository: importedRepo}
writer := streamio.NewWriter(func(p []byte) error {
request.Data = p
if err := stream.Send(request); err != nil {
return err
}
request = &gitalypb.CreateRepositoryFromBundleRequest{}
return nil
})
file, err := os.Open(bundlePath)
require.NoError(t, err)
defer file.Close()
_, err = io.Copy(writer, file)
require.NoError(t, err)
_, err = stream.CloseAndRecv()
require.NoError(t, err)
testhelper.MustRunCommand(t, nil, "git", "-C", importedRepoPath, "fsck")
info, err := os.Lstat(filepath.Join(importedRepoPath, "hooks"))
require.NoError(t, err)
require.NotEqual(t, 0, info.Mode()&os.ModeSymlink)
commit, err := log.GetCommit(ctx, locator, importedRepo, "refs/custom-refs/ref1")
require.NoError(t, err)
require.NotNil(t, commit)
}
func TestServer_CreateRepositoryFromBundle_failed_invalid_bundle(t *testing.T) {
locator := config.NewLocator(config.Config)
serverSocketPath, stop := runRepoServer(t, locator)
defer stop()
client, conn := newRepositoryClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
stream, err := client.CreateRepositoryFromBundle(ctx)
require.NoError(t, err)
importedRepo := &gitalypb.Repository{
StorageName: testhelper.DefaultStorageName,
RelativePath: "a-repo-from-bundle",
}
importedRepoPath, err := locator.GetPath(importedRepo)
require.NoError(t, err)
defer os.RemoveAll(importedRepoPath)
request := &gitalypb.CreateRepositoryFromBundleRequest{Repository: importedRepo}
writer := streamio.NewWriter(func(p []byte) error {
request.Data = p
if err := stream.Send(request); err != nil {
return err
}
request = &gitalypb.CreateRepositoryFromBundleRequest{}
return nil
})
_, err = io.Copy(writer, bytes.NewBufferString("not-a-bundle"))
require.NoError(t, err)
_, err = stream.CloseAndRecv()
require.Error(t, err)
require.Contains(t, err.Error(), "invalid gitfile format")
}
func TestServer_CreateRepositoryFromBundle_failed_validations(t *testing.T) {
locator := config.NewLocator(config.Config)
serverSocketPath, stop := runRepoServer(t, locator)
defer stop()
client, conn := newRepositoryClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
stream, err := client.CreateRepositoryFromBundle(ctx)
require.NoError(t, err)
require.NoError(t, stream.Send(&gitalypb.CreateRepositoryFromBundleRequest{}))
_, err = stream.CloseAndRecv()
testhelper.RequireGrpcError(t, err, codes.InvalidArgument)
}
func TestServer_CreateRepositoryFromBundle_failed_existing_directory(t *testing.T) {
locator := config.NewLocator(config.Config)
serverSocketPath, stop := runRepoServer(t, locator)
defer stop()
testRepo, _, cleanup := testhelper.NewTestRepo(t)
defer cleanup()
client, conn := newRepositoryClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
stream, err := client.CreateRepositoryFromBundle(ctx)
require.NoError(t, err)
require.NoError(t, stream.Send(&gitalypb.CreateRepositoryFromBundleRequest{
Repository: testRepo,
}))
_, err = stream.CloseAndRecv()
testhelper.RequireGrpcError(t, err, codes.FailedPrecondition)
testhelper.GrpcErrorHasMessage(err, "CreateRepositoryFromBundle: target directory is non-empty")
}
func TestSanitizedError(t *testing.T) {
testCases := []struct {
path string
format string
a []interface{}
expected string
}{
{
path: "/home/git/storage",
format: "failed to create from bundle in /home/git/storage/my-project",
expected: "failed to create from bundle in [REPO PATH]/my-project",
},
{
path: "/home/git/storage",
format: "failed to %s in [REPO PATH]/my-project",
a: []interface{}{"create from bundle"},
expected: "failed to create from bundle in [REPO PATH]/my-project",
},
}
for _, tc := range testCases {
str := sanitizedError(tc.path, tc.format, tc.a...)
assert.Equal(t, tc.expected, str)
}
}
|
