1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
|
package repository
import (
"context"
"encoding/base64"
"fmt"
"net/http"
"os"
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v14/internal/git"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v14/internal/praefect/praefectutil"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"
"google.golang.org/grpc/codes"
)
func TestCreateRepotitoryFromURL_successful(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, _, repoPath, client := setupRepositoryService(ctx, t)
gitCmdFactory := gittest.NewCommandFactory(t, cfg)
importedRepo := &gitalypb.Repository{
RelativePath: "imports/test-repo-imported.git",
StorageName: cfg.Storages[0].Name,
}
user := "username123"
password := "password321localhost"
port, stopGitServer := gitServerWithBasicAuth(ctx, t, gitCmdFactory, user, password, repoPath)
defer func() {
require.NoError(t, stopGitServer())
}()
url := fmt.Sprintf("http://%s:%s@localhost:%d/%s", user, password, port, filepath.Base(repoPath))
req := &gitalypb.CreateRepositoryFromURLRequest{
Repository: importedRepo,
Url: url,
}
_, err := client.CreateRepositoryFromURL(ctx, req)
require.NoError(t, err)
importedRepoPath := filepath.Join(cfg.Storages[0].Path, gittest.GetReplicaPath(ctx, t, cfg, importedRepo))
gittest.Exec(t, cfg, "-C", importedRepoPath, "fsck")
remotes := gittest.Exec(t, cfg, "-C", importedRepoPath, "remote")
require.NotContains(t, string(remotes), "origin")
_, err = os.Lstat(filepath.Join(importedRepoPath, "hooks"))
require.True(t, os.IsNotExist(err), "hooks directory should not have been created")
}
func TestCreateRepositoryFromURL_existingTarget(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
testCases := []struct {
desc string
repoPath string
isDir bool
}{
{
desc: "target is a directory",
isDir: true,
},
{
desc: "target is a file",
isDir: false,
},
}
for _, testCase := range testCases {
t.Run(testCase.desc, func(t *testing.T) {
cfg, client := setupRepositoryServiceWithoutRepo(t)
importedRepo := &gitalypb.Repository{
RelativePath: praefectutil.DeriveReplicaPath(1),
StorageName: cfg.Storages[0].Name,
}
importedRepoPath := filepath.Join(cfg.Storages[0].Path, importedRepo.GetRelativePath())
if testCase.isDir {
require.NoError(t, os.MkdirAll(importedRepoPath, 0o770))
} else {
require.NoError(t, os.MkdirAll(filepath.Dir(importedRepoPath), os.ModePerm))
require.NoError(t, os.WriteFile(importedRepoPath, nil, 0o644))
}
t.Cleanup(func() { require.NoError(t, os.RemoveAll(importedRepoPath)) })
req := &gitalypb.CreateRepositoryFromURLRequest{
Repository: importedRepo,
Url: "https://gitlab.com/gitlab-org/gitlab-test.git",
}
_, err := client.CreateRepositoryFromURL(ctx, req)
testhelper.RequireGrpcCode(t, err, codes.AlreadyExists)
})
}
}
func TestCreateRepositoryFromURL_redirect(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, client := setupRepositoryServiceWithoutRepo(t)
importedRepo := &gitalypb.Repository{
RelativePath: "imports/test-repo-imported.git",
StorageName: cfg.Storages[0].Name,
}
httpServerState, redirectingServer := StartRedirectingTestServer()
defer redirectingServer.Close()
req := &gitalypb.CreateRepositoryFromURLRequest{
Repository: importedRepo,
Url: redirectingServer.URL,
}
_, err := client.CreateRepositoryFromURL(ctx, req)
require.True(t, httpServerState.serverVisited, "git command should make the initial HTTP request")
require.False(t, httpServerState.serverVisitedAfterRedirect, "git command should not follow HTTP redirection")
require.Error(t, err)
require.Contains(t, err.Error(), "The requested URL returned error: 301")
}
func TestServer_CloneFromURLCommand(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
var authToken string
userInfo := "user:pass%21%3F%40"
repositoryFullPath := "full/path/to/repository"
url := fmt.Sprintf("https://%s@192.0.2.1/secretrepo.git", userInfo)
host := "www.example.com"
cfg := testcfg.Build(t)
s := server{cfg: cfg, gitCmdFactory: gittest.NewCommandFactory(t, cfg)}
cmd, err := s.cloneFromURLCommand(ctx, url, host, repositoryFullPath, authToken, git.WithDisabledHooks())
require.NoError(t, err)
expectedScrubbedURL := "https://192.0.2.1/secretrepo.git"
expectedBasicAuthHeader := fmt.Sprintf("Authorization: Basic %s", base64.StdEncoding.EncodeToString([]byte("user:pass!?@")))
expectedAuthHeader := fmt.Sprintf("http.extraHeader=%s", expectedBasicAuthHeader)
expectedHostHeader := "http.extraHeader=Host: www.example.com"
args := cmd.Args()
require.Contains(t, args, expectedScrubbedURL)
require.Contains(t, args, expectedAuthHeader)
require.Contains(t, args, expectedHostHeader)
require.NotContains(t, args, userInfo)
}
func TestServer_CloneFromURLCommand_withToken(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
repositoryFullPath := "full/path/to/repository"
url := "https://www.example.com/secretrepo.git"
authToken := "GL-Geo EhEhKSUk_385GSLnS7BI:eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJkYXRhIjoie1wic2NvcGVcIjpcInJvb3QvZ2l0bGFiLWNlXCJ9IiwianRpIjoiNmQ4ZDM1NGQtZjUxYS00MDQ5LWExZjctMjUyMjk4YmQwMTI4IiwiaWF0IjoxNjQyMDk1MzY5LCJuYmYiOjE2NDIwOTUzNjQsImV4cCI6MTY0MjA5NTk2OX0.YEpfzg8305dUqkYOiB7_dhbL0FVSaUPgpSpMuKrgNrg"
cfg := testcfg.Build(t)
s := server{cfg: cfg, gitCmdFactory: gittest.NewCommandFactory(t, cfg)}
cmd, err := s.cloneFromURLCommand(ctx, url, "", repositoryFullPath, authToken, git.WithDisabledHooks())
require.NoError(t, err)
expectedScrubbedURL := "https://www.example.com/secretrepo.git"
expectedBasicAuthHeader := fmt.Sprintf("Authorization: %s", authToken)
expectedHeader := fmt.Sprintf("http.extraHeader=%s", expectedBasicAuthHeader)
args := cmd.Args()
require.Contains(t, args, expectedScrubbedURL)
require.Contains(t, args, expectedHeader)
}
func gitServerWithBasicAuth(ctx context.Context, t testing.TB, gitCmdFactory git.CommandFactory, user, pass, repoPath string) (int, func() error) {
return gittest.HTTPServer(ctx, t, gitCmdFactory, repoPath, basicAuthMiddleware(t, user, pass))
}
func basicAuthMiddleware(t testing.TB, user, pass string) func(http.ResponseWriter, *http.Request, http.Handler) {
return func(w http.ResponseWriter, r *http.Request, next http.Handler) {
authUser, authPass, ok := r.BasicAuth()
require.True(t, ok, "should contain basic auth")
require.Equal(t, user, authUser, "username should match")
require.Equal(t, pass, authPass, "password should match")
next.ServeHTTP(w, r)
}
}
|
