1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
|
package repository
import (
"context"
"fmt"
"io/ioutil"
"os"
"path"
"path/filepath"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git"
"gitlab.com/gitlab-org/gitaly/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/config/auth"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/transaction"
"gitlab.com/gitlab-org/gitaly/internal/helper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testserver"
"gitlab.com/gitlab-org/gitaly/internal/transaction/txinfo"
"gitlab.com/gitlab-org/gitaly/internal/transaction/voting"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
"google.golang.org/grpc/codes"
)
func TestRepoNoAuth(t *testing.T) {
cfg, repo, _ := testcfg.BuildWithRepo(t, testcfg.WithBase(config.Cfg{Auth: auth.Config{Token: "some"}}))
serverSocketPath := runRepositoryServerWithConfig(t, cfg, nil)
client := newRepositoryClient(t, config.Cfg{Auth: auth.Config{Token: ""}}, serverSocketPath)
ctx, cancel := testhelper.Context()
defer cancel()
_, err := client.CreateRepository(ctx, &gitalypb.CreateRepositoryRequest{Repository: repo})
testhelper.RequireGrpcError(t, err, codes.Unauthenticated)
}
func TestCreateRepositorySuccess(t *testing.T) {
cfg, client := setupRepositoryServiceWithoutRepo(t)
ctx, cancel := testhelper.Context()
defer cancel()
relativePath := "create-repository-test.git"
repoDir := filepath.Join(cfg.Storages[0].Path, relativePath)
repo := &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: relativePath}
req := &gitalypb.CreateRepositoryRequest{Repository: repo}
_, err := client.CreateRepository(ctx, req)
require.NoError(t, err)
fi, err := os.Stat(repoDir)
require.NoError(t, err)
require.Equal(t, "drwxr-x---", fi.Mode().String())
for _, dir := range []string{repoDir, filepath.Join(repoDir, "refs")} {
fi, err := os.Stat(dir)
require.NoError(t, err)
require.True(t, fi.IsDir(), "%q must be a directory", fi.Name())
}
symRef, err := ioutil.ReadFile(path.Join(repoDir, "HEAD"))
require.NoError(t, err)
require.Equal(t, symRef, []byte(fmt.Sprintf("ref: %s\n", git.DefaultRef)))
}
func TestCreateRepositoryFailure(t *testing.T) {
cfg, client := setupRepositoryServiceWithoutRepo(t)
ctx, cancel := testhelper.Context()
defer cancel()
storagePath := cfg.Storages[0].Path
fullPath := filepath.Join(storagePath, "foo.git")
_, err := os.Create(fullPath)
require.NoError(t, err)
_, err = client.CreateRepository(ctx, &gitalypb.CreateRepositoryRequest{
Repository: &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: "foo.git"},
})
testhelper.RequireGrpcError(t, err, codes.Internal)
}
func TestCreateRepositoryFailureInvalidArgs(t *testing.T) {
_, client := setupRepositoryServiceWithoutRepo(t)
ctx, cancel := testhelper.Context()
defer cancel()
testCases := []struct {
repo *gitalypb.Repository
code codes.Code
}{
{
repo: &gitalypb.Repository{StorageName: "does not exist", RelativePath: "foobar.git"},
code: codes.InvalidArgument,
},
}
for _, tc := range testCases {
t.Run(fmt.Sprintf("%+v", tc.repo), func(t *testing.T) {
_, err := client.CreateRepository(ctx, &gitalypb.CreateRepositoryRequest{Repository: tc.repo})
require.Error(t, err)
testhelper.RequireGrpcError(t, err, tc.code)
})
}
}
func TestCreateRepositoryTransactional(t *testing.T) {
var actualVote voting.Vote
var called int
mockTxManager := transaction.MockManager{
VoteFn: func(ctx context.Context, tx txinfo.Transaction, server txinfo.PraefectServer, v voting.Vote) error {
actualVote = v
called++
return nil
},
}
cfg, client := setupRepositoryServiceWithoutRepo(t, testserver.WithTransactionManager(&mockTxManager))
ctx, cancel := testhelper.Context()
defer cancel()
ctx, err := (&txinfo.PraefectServer{SocketPath: "something"}).Inject(ctx)
require.NoError(t, err)
ctx, err = txinfo.InjectTransaction(ctx, 1, "node", true)
require.NoError(t, err)
ctx = helper.IncomingToOutgoing(ctx)
t.Run("initial creation without refs", func(t *testing.T) {
called = 0
actualVote = voting.Vote{}
_, err = client.CreateRepository(ctx, &gitalypb.CreateRepositoryRequest{
Repository: &gitalypb.Repository{
StorageName: cfg.Storages[0].Name,
RelativePath: "repo.git",
},
})
require.NoError(t, err)
require.DirExists(t, filepath.Join(cfg.Storages[0].Path, "repo.git"))
require.Equal(t, 1, called, "expected transactional vote")
require.Equal(t, voting.VoteFromData([]byte{}), actualVote)
})
t.Run("idempotent creation with preexisting refs", func(t *testing.T) {
called = 0
actualVote = voting.Vote{}
repo, repoPath, cleanup := gittest.CloneRepoAtStorage(t, cfg.Storages[0], "clone.git")
defer cleanup()
_, err = client.CreateRepository(ctx, &gitalypb.CreateRepositoryRequest{
Repository: repo,
})
require.NoError(t, err)
refs := gittest.Exec(t, cfg, "-C", repoPath, "for-each-ref")
require.NotEmpty(t, refs)
require.Equal(t, 1, called, "expected transactional vote")
require.Equal(t, voting.VoteFromData(refs), actualVote)
})
}
func TestCreateRepositoryIdempotent(t *testing.T) {
cfg, repo, repoPath, client := setupRepositoryService(t)
ctx, cancel := testhelper.Context()
defer cancel()
refsBefore := strings.Split(string(gittest.Exec(t, cfg, "-C", repoPath, "for-each-ref")), "\n")
req := &gitalypb.CreateRepositoryRequest{Repository: repo}
_, err := client.CreateRepository(ctx, req)
require.NoError(t, err)
refsAfter := strings.Split(string(gittest.Exec(t, cfg, "-C", repoPath, "for-each-ref")), "\n")
assert.Equal(t, refsBefore, refsAfter)
}
|
