1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
|
package repository
import (
"fmt"
"gitlab.com/gitlab-org/gitaly/v15/structerr"
"os"
"path/filepath"
"strings"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/proto/v15/go/gitalypb"
"gitlab.com/gitlab-org/gitaly/v15/internal/errors"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v15/internal/helper/perm"
"gitlab.com/gitlab-org/gitaly/v15/internal/structerr"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper"
)
func TestObjectFormat(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, client := setupRepositoryServiceWithoutRepo(t)
type setupData struct {
request *gitalypb.ObjectFormatRequest
expectedErr error
expectedResponse *gitalypb.ObjectFormatResponse
}
for _, tc := range []struct {
desc string
setup func(t *testing.T) setupData
}{
{
desc: "unset repository",
setup: func(t *testing.T) setupData {
return setupData{
request: &gitalypb.ObjectFormatRequest{},
expectedErr: testhelper.GitalyOrPraefect(
structerr.NewInvalidArgument("%w", errors.ErrEmptyRepository),
structerr.NewInvalidArgument("repo scoped: %w", errors.ErrEmptyRepository),
),
}
},
},
{
desc: "missing storage name",
setup: func(t *testing.T) setupData {
return setupData{
request: &gitalypb.ObjectFormatRequest{
Repository: &gitalypb.Repository{},
},
expectedErr: testhelper.GitalyOrPraefect(
structerr.NewInvalidArgument("%w", errors.ErrEmptyStorageName),
structerr.NewInvalidArgument("repo scoped: %w", errors.ErrInvalidRepository),
),
}
},
},
{
desc: "missing relative path",
setup: func(t *testing.T) setupData {
return setupData{
request: &gitalypb.ObjectFormatRequest{
Repository: &gitalypb.Repository{
StorageName: cfg.Storages[0].Name,
},
},
expectedErr: testhelper.GitalyOrPraefect(
structerr.NewInvalidArgument("%w", errors.ErrEmptyRelativePath),
structerr.NewInvalidArgument("repo scoped: %w", errors.ErrInvalidRepository),
),
}
},
},
{
desc: "nonexistent repository",
setup: func(t *testing.T) setupData {
return setupData{
request: &gitalypb.ObjectFormatRequest{
Repository: &gitalypb.Repository{
StorageName: cfg.Storages[0].Name,
RelativePath: "nonexistent.git",
},
},
expectedErr: testhelper.GitalyOrPraefect(
structerr.NewNotFound(
"GetRepoPath: not a git repository: %q", filepath.Join(cfg.Storages[0].Path, "nonexistent.git"),
),
structerr.NewNotFound(
"accessor call: route repository accessor: consistent storages: repository %q/%q not found",
cfg.Storages[0].Name, "nonexistent.git",
),
),
}
},
},
{
desc: "SHA1",
setup: func(t *testing.T) setupData {
repoProto, _ := gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
ObjectFormat: "sha1",
})
return setupData{
request: &gitalypb.ObjectFormatRequest{
Repository: repoProto,
},
expectedResponse: &gitalypb.ObjectFormatResponse{
Format: gitalypb.ObjectFormat_OBJECT_FORMAT_SHA1,
},
}
},
},
{
desc: "SHA256",
setup: func(t *testing.T) setupData {
repoProto, _ := gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
ObjectFormat: "sha256",
})
return setupData{
request: &gitalypb.ObjectFormatRequest{
Repository: repoProto,
},
expectedResponse: &gitalypb.ObjectFormatResponse{
Format: gitalypb.ObjectFormat_OBJECT_FORMAT_SHA256,
},
}
},
},
{
desc: "invalid object format",
setup: func(t *testing.T) setupData {
repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg)
// We write the config file manually so that we can use an
// exact-match for the error down below.
require.NoError(t, os.WriteFile(filepath.Join(repoPath, "config"), []byte(
strings.Join([]string{
"[core]",
"repositoryformatversion = 1",
"bare = true",
"[extensions]",
"objectFormat = blake2b",
}, "\n"),
), perm.SharedFile))
return setupData{
request: &gitalypb.ObjectFormatRequest{
Repository: repoProto,
},
expectedErr: structerr.New("detecting object hash: reading object format: exit status 128").WithInterceptedMetadata(
"stderr",
fmt.Sprintf("error: invalid value for 'extensions.objectformat': 'blake2b'\n"+
"fatal: bad config line 5 in file %s\n", filepath.Join(repoPath, "config"),
),
),
}
},
},
} {
tc := tc
t.Run(tc.desc, func(t *testing.T) {
t.Parallel()
setupData := tc.setup(t)
response, err := client.ObjectFormat(ctx, setupData.request)
testhelper.RequireGrpcError(t, setupData.expectedErr, err)
testhelper.ProtoEqual(t, setupData.expectedResponse, response)
})
}
}
|
