1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
|
//go:build !gitaly_test_sha256
package repository
import (
"context"
"fmt"
"os"
"path/filepath"
"strings"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v15/internal/git"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v15/internal/gitaly/storage"
"gitlab.com/gitlab-org/gitaly/v15/internal/metadata/featureflag"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver"
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)
func TestRenameRepository_success(t *testing.T) {
testhelper.NewFeatureSets(featureflag.PraefectGeneratedReplicaPaths).Run(t, testRenameRepositorySuccess)
}
func testRenameRepositorySuccess(t *testing.T, ctx context.Context) {
t.Parallel()
// Praefect does not move repositories on the disk so this test case is not run with Praefect.
cfg, repo, _, client := setupRepositoryService(t, ctx, testserver.WithDisablePraefect())
const targetPath = "a-new-location"
_, err := client.RenameRepository(ctx, &gitalypb.RenameRepositoryRequest{
Repository: repo,
RelativePath: targetPath,
})
require.NoError(t, err)
newDirectory := filepath.Join(cfg.Storages[0].Path, targetPath)
require.DirExists(t, newDirectory)
defer func() { require.NoError(t, os.RemoveAll(newDirectory)) }()
require.True(t, storage.IsGitDirectory(newDirectory), "moved Git repository has been corrupted")
// ensure the git directory that got renamed contains a sha in the seed repo
gittest.RequireObjectExists(t, cfg, newDirectory, git.ObjectID("913c66a37b4a45b9769037c55c2d238bd0942d2e"))
}
func TestRenameRepository_DestinationExists(t *testing.T) {
testhelper.NewFeatureSets(featureflag.PraefectGeneratedReplicaPaths).Run(t, testRenameRepositoryDestinationExists)
}
func testRenameRepositoryDestinationExists(t *testing.T, ctx context.Context) {
t.Parallel()
cfg, client := setupRepositoryServiceWithoutRepo(t)
existingDestinationRepo := &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: "repository-1"}
_, err := client.CreateRepository(ctx, &gitalypb.CreateRepositoryRequest{Repository: existingDestinationRepo})
require.NoError(t, err)
renamedRepo := &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: "repository-2"}
_, err = client.CreateRepository(ctx, &gitalypb.CreateRepositoryRequest{Repository: renamedRepo})
require.NoError(t, err)
destinationRepoPath := filepath.Join(cfg.Storages[0].Path, gittest.GetReplicaPath(t, ctx, cfg, existingDestinationRepo))
commitID := gittest.WriteCommit(t, cfg, destinationRepoPath)
_, err = client.RenameRepository(ctx, &gitalypb.RenameRepositoryRequest{
Repository: renamedRepo,
RelativePath: existingDestinationRepo.RelativePath,
})
testhelper.RequireGrpcCode(t, err, codes.AlreadyExists)
// ensure the git directory that already existed didn't get overwritten
gittest.RequireObjectExists(t, cfg, destinationRepoPath, commitID)
}
func TestRenameRepository_invalidRequest(t *testing.T) {
testhelper.NewFeatureSets(featureflag.PraefectGeneratedReplicaPaths).Run(t, testRenameRepositoryInvalidRequest)
}
func testRenameRepositoryInvalidRequest(t *testing.T, ctx context.Context) {
t.Parallel()
_, repo, repoPath, client := setupRepositoryService(t, ctx)
storagePath := strings.TrimSuffix(repoPath, "/"+repo.RelativePath)
testCases := []struct {
desc string
req *gitalypb.RenameRepositoryRequest
exp error
}{
{
desc: "empty repository",
req: &gitalypb.RenameRepositoryRequest{Repository: nil, RelativePath: "/tmp/abc"},
exp: status.Error(codes.InvalidArgument, "empty Repository"),
},
{
desc: "empty destination relative path",
req: &gitalypb.RenameRepositoryRequest{Repository: repo, RelativePath: ""},
exp: status.Error(codes.InvalidArgument, "destination relative path is empty"),
},
{
desc: "destination relative path contains path traversal",
req: &gitalypb.RenameRepositoryRequest{Repository: repo, RelativePath: "../usr/bin"},
exp: status.Error(codes.InvalidArgument, "GetRepoPath: relative path escapes root directory"),
},
{
desc: "repository storage doesn't exist",
req: &gitalypb.RenameRepositoryRequest{Repository: &gitalypb.Repository{StorageName: "stub", RelativePath: repo.RelativePath}, RelativePath: "usr/bin"},
exp: status.Error(codes.InvalidArgument, `GetStorageByName: no such storage: "stub"`),
},
{
desc: "repository relative path doesn't exist",
req: &gitalypb.RenameRepositoryRequest{Repository: &gitalypb.Repository{StorageName: repo.StorageName, RelativePath: "stub"}, RelativePath: "non-existent/directory"},
exp: status.Error(codes.NotFound, fmt.Sprintf(`GetRepoPath: not a git repository: "%s/stub"`, testhelper.GitalyOrPraefectMessage(storagePath, repo.GetStorageName()))),
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
_, err := client.RenameRepository(ctx, tc.req)
testhelper.RequireGrpcError(t, tc.exp, err)
})
}
}
|
