1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
|
//go:build !gitaly_test_sha256
package ssh
import (
"fmt"
"os"
"testing"
"time"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/proto/v15/go/gitalypb"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testcfg"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
"google.golang.org/protobuf/encoding/protojson"
)
func TestFailedUploadArchiveRequestDueToTimeout(t *testing.T) {
t.Parallel()
cfg := testcfg.Build(t)
cfg.SocketPath = runSSHServerWithOptions(t, cfg, []ServerOpt{WithArchiveRequestTimeout(100 * time.Microsecond)})
ctx := testhelper.Context(t)
repo, _ := gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
Seed: gittest.SeedGitLabTest,
})
client := newSSHClient(t, cfg.SocketPath)
stream, err := client.SSHUploadArchive(ctx)
require.NoError(t, err)
// The first request is not limited by timeout, but also not under attacker control
require.NoError(t, stream.Send(&gitalypb.SSHUploadArchiveRequest{Repository: repo}))
// Because the client says nothing, the server would block. Because of
// the timeout, it won't block forever, and return with a non-zero exit
// code instead.
requireFailedSSHStream(t, structerr.NewDeadlineExceeded("waiting for packfile negotiation: context canceled"), func() (int32, error) {
resp, err := stream.Recv()
if err != nil {
return 0, err
}
var code int32
if status := resp.GetExitStatus(); status != nil {
code = status.Value
}
return code, nil
})
}
func TestFailedUploadArchiveRequestDueToValidationError(t *testing.T) {
t.Parallel()
cfg := testcfg.Build(t)
serverSocketPath := runSSHServer(t, cfg)
client := newSSHClient(t, serverSocketPath)
tests := []struct {
Desc string
Req *gitalypb.SSHUploadArchiveRequest
expectedErr error
}{
{
Desc: "Repository.RelativePath is empty",
Req: &gitalypb.SSHUploadArchiveRequest{Repository: &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: ""}},
expectedErr: status.Error(codes.InvalidArgument, testhelper.GitalyOrPraefect(
"empty RelativePath",
"repo scoped: invalid Repository",
)),
},
{
Desc: "Repository is nil",
Req: &gitalypb.SSHUploadArchiveRequest{Repository: nil},
expectedErr: status.Error(codes.InvalidArgument, testhelper.GitalyOrPraefect(
"empty Repository",
"repo scoped: empty Repository",
)),
},
{
Desc: "Data exists on first request",
Req: &gitalypb.SSHUploadArchiveRequest{Repository: &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: "path/to/repo"}, Stdin: []byte("Fail")},
expectedErr: func() error {
if testhelper.IsPraefectEnabled() {
return status.Error(codes.NotFound, `accessor call: route repository accessor: consistent storages: repository "default"/"path/to/repo" not found`)
}
return status.Error(codes.InvalidArgument, "non-empty stdin in first request")
}(),
},
}
for _, test := range tests {
t.Run(test.Desc, func(t *testing.T) {
ctx := testhelper.Context(t)
stream, err := client.SSHUploadArchive(ctx)
if err != nil {
t.Fatal(err)
}
if err = stream.Send(test.Req); err != nil {
t.Fatal(err)
}
require.NoError(t, stream.CloseSend())
err = testUploadArchiveFailedResponse(t, stream)
testhelper.RequireGrpcError(t, test.expectedErr, err)
})
}
}
func TestUploadArchiveSuccess(t *testing.T) {
t.Parallel()
cfg := testcfg.Build(t)
testcfg.BuildGitalySSH(t, cfg)
cfg.SocketPath = runSSHServer(t, cfg)
ctx := testhelper.Context(t)
repo, _ := gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
Seed: gittest.SeedGitLabTest,
})
payload, err := protojson.Marshal(&gitalypb.SSHUploadArchiveRequest{
Repository: repo,
})
require.NoError(t, err)
gittest.ExecOpts(t, cfg, gittest.ExecConfig{
Env: []string{
fmt.Sprintf("GITALY_ADDRESS=%s", cfg.SocketPath),
fmt.Sprintf("GITALY_PAYLOAD=%s", payload),
fmt.Sprintf("PATH=%s", ".:"+os.Getenv("PATH")),
fmt.Sprintf(`GIT_SSH_COMMAND=%s upload-archive`, cfg.BinaryPath("gitaly-ssh")),
},
}, "archive", "master", "--remote=git@localhost:test/test.git")
}
func testUploadArchiveFailedResponse(t *testing.T, stream gitalypb.SSHService_SSHUploadArchiveClient) error {
var err error
var res *gitalypb.SSHUploadArchiveResponse
for err == nil {
res, err = stream.Recv()
require.Nil(t, res.GetStdout())
}
return err
}
|
