1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
|
//go:build !gitaly_test_sha256
package storage
import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
)
func TestValidateRelativePath(t *testing.T) {
for _, tc := range []struct {
path string
cleaned string
error error
}{
{"/parent", "parent", nil},
{"parent/", "parent", nil},
{"/parent-with-suffix", "parent-with-suffix", nil},
{"/subfolder", "subfolder", nil},
{"subfolder", "subfolder", nil},
{"subfolder/", "subfolder", nil},
{"subfolder//", "subfolder", nil},
{"subfolder/..", ".", nil},
{"subfolder/../..", "", ErrRelativePathEscapesRoot},
{"/..", "", ErrRelativePathEscapesRoot},
{"..", "", ErrRelativePathEscapesRoot},
{"../", "", ErrRelativePathEscapesRoot},
{"", ".", nil},
{".", ".", nil},
} {
const parent = "/parent"
t.Run(parent+" and "+tc.path, func(t *testing.T) {
cleaned, err := ValidateRelativePath(parent, tc.path)
assert.Equal(t, tc.cleaned, cleaned)
assert.Equal(t, tc.error, err)
})
}
}
func TestQuarantineDirectoryPrefix(t *testing.T) {
// An nil repository works alright, even if nonsensical.
require.Equal(t, "quarantine-0000000000000000-", QuarantineDirectoryPrefix(nil))
// A repository with only a relative path.
require.Equal(t, "quarantine-8843d7f92416211d-", QuarantineDirectoryPrefix(&gitalypb.Repository{
RelativePath: "foobar",
}))
// A different relative path has a different hash.
require.Equal(t, "quarantine-60518c1c11dc0452-", QuarantineDirectoryPrefix(&gitalypb.Repository{
RelativePath: "barfoo",
}))
// Only the relative path matters. The storage name doesn't matter either given that the
// temporary directory is per storage.
require.Equal(t, "quarantine-60518c1c11dc0452-", QuarantineDirectoryPrefix(&gitalypb.Repository{
StorageName: "storage-name",
RelativePath: "barfoo",
GitObjectDirectory: "object-directory",
GitAlternateObjectDirectories: []string{
"alternate",
},
GlRepository: "gl-repo",
GlProjectPath: "gl/repo",
}))
}
|
