1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
|
package limithandler_test
import (
"net"
"sync"
"testing"
"time"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler"
pb "gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler/testpb"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"golang.org/x/net/context"
"google.golang.org/grpc"
)
func fixedLockKey(ctx context.Context) string {
return "fixed-id"
}
func TestUnaryLimitHandler(t *testing.T) {
s := &server{blockCh: make(chan struct{})}
limithandler.SetMaxRepoConcurrency(map[string]int{"/test.Test/Unary": 2})
lh := limithandler.New(fixedLockKey)
interceptor := lh.UnaryInterceptor()
srv, serverSocketPath := runServer(t, s, grpc.UnaryInterceptor(interceptor))
defer srv.Stop()
client, conn := newClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
wg := &sync.WaitGroup{}
for i := 0; i < 10; i++ {
wg.Add(1)
go func() {
defer wg.Done()
resp, err := client.Unary(ctx, &pb.UnaryRequest{})
require.NotNil(t, resp)
require.NoError(t, err)
require.True(t, resp.Ok)
}()
}
time.Sleep(100 * time.Millisecond)
require.Equal(t, 2, s.getRequestCount())
close(s.blockCh)
wg.Wait()
}
func TestStreamLimitHandler(t *testing.T) {
testCases := []struct {
desc string
fullname string
f func(*testing.T, context.Context, pb.TestClient)
maxConcurrency int
expectedRequestCount int
}{
{
desc: "Single request, multiple responses",
fullname: "/test.Test/StreamOutput",
f: func(t *testing.T, ctx context.Context, client pb.TestClient) {
stream, err := client.StreamOutput(ctx, &pb.StreamOutputRequest{})
require.NotNil(t, stream)
require.NoError(t, err)
r, err := stream.Recv()
require.NotNil(t, r)
require.NoError(t, err)
require.True(t, r.Ok)
},
maxConcurrency: 3,
expectedRequestCount: 3,
},
{
desc: "Multiple requests, single response",
fullname: "/test.Test/StreamInput",
f: func(t *testing.T, ctx context.Context, client pb.TestClient) {
stream, err := client.StreamInput(ctx)
require.NotNil(t, stream)
require.NoError(t, err)
require.NoError(t, stream.Send(&pb.StreamInputRequest{}))
r, err := stream.CloseAndRecv()
require.NotNil(t, r)
require.NoError(t, err)
require.True(t, r.Ok)
},
maxConcurrency: 3,
expectedRequestCount: 3,
},
{
desc: "Multiple requests, multiple responses",
fullname: "/test.Test/Bidirectional",
f: func(t *testing.T, ctx context.Context, client pb.TestClient) {
stream, err := client.Bidirectional(ctx)
require.NotNil(t, stream)
require.NoError(t, err)
require.NoError(t, stream.Send(&pb.BidirectionalRequest{}))
stream.CloseSend()
r, err := stream.Recv()
require.NotNil(t, r)
require.NoError(t, err)
require.True(t, r.Ok)
},
maxConcurrency: 3,
expectedRequestCount: 3,
},
{
// Make sure that _streams_ are limited but that _requests_ on each
// allowed stream are not limited.
desc: "Multiple requests with same id, multiple responses",
fullname: "/test.Test/Bidirectional",
f: func(t *testing.T, ctx context.Context, client pb.TestClient) {
stream, err := client.Bidirectional(ctx)
require.NotNil(t, stream)
require.NoError(t, err)
// Since the concurrency id is fixed all requests have the same
// id, but subsequent requests in a stream, even with the same
// id, should bypass the concurrency limiter
for i := 0; i < 10; i++ {
require.NoError(t, stream.Send(&pb.BidirectionalRequest{}))
}
stream.CloseSend()
r, err := stream.Recv()
require.NotNil(t, r)
require.NoError(t, err)
require.True(t, r.Ok)
},
maxConcurrency: 3,
// 3 (concurrent streams allowed) * 10 (requests per stream)
expectedRequestCount: 30,
},
{
desc: "With a max concurrency of 0",
fullname: "/test.Test/StreamOutput",
f: func(t *testing.T, ctx context.Context, client pb.TestClient) {
stream, err := client.StreamOutput(ctx, &pb.StreamOutputRequest{})
require.NotNil(t, stream)
require.NoError(t, err)
r, err := stream.Recv()
require.NotNil(t, r)
require.NoError(t, err)
require.True(t, r.Ok)
},
maxConcurrency: 0,
expectedRequestCount: 10, // Allow all
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
s := &server{blockCh: make(chan struct{})}
limithandler.SetMaxRepoConcurrency(map[string]int{
tc.fullname: tc.maxConcurrency,
})
lh := limithandler.New(fixedLockKey)
interceptor := lh.StreamInterceptor()
srv, serverSocketPath := runServer(t, s, grpc.StreamInterceptor(interceptor))
defer srv.Stop()
client, conn := newClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
wg := &sync.WaitGroup{}
for i := 0; i < 10; i++ {
wg.Add(1)
go func() {
defer wg.Done()
tc.f(t, ctx, client)
}()
}
time.Sleep(100 * time.Millisecond)
require.Equal(t, tc.expectedRequestCount, s.getRequestCount())
close(s.blockCh)
wg.Wait()
})
}
}
func runServer(t *testing.T, s *server, opt ...grpc.ServerOption) (*grpc.Server, string) {
serverSocketPath := testhelper.GetTemporaryGitalySocketFileName()
grpcServer := grpc.NewServer(opt...)
pb.RegisterTestServer(grpcServer, s)
lis, err := net.Listen("unix", serverSocketPath)
require.NoError(t, err)
go grpcServer.Serve(lis)
return grpcServer, serverSocketPath
}
func newClient(t *testing.T, serverSocketPath string) (pb.TestClient, *grpc.ClientConn) {
connOpts := []grpc.DialOption{
grpc.WithInsecure(),
grpc.WithDialer(func(addr string, timeout time.Duration) (net.Conn, error) {
return net.DialTimeout("unix", addr, timeout)
}),
}
conn, err := grpc.Dial(serverSocketPath, connOpts...)
if err != nil {
t.Fatal(err)
}
return pb.NewTestClient(conn), conn
}
|
