1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
|
package config
import (
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/config/log"
gitaly_prometheus "gitlab.com/gitlab-org/gitaly/internal/config/prometheus"
"gitlab.com/gitlab-org/gitaly/internal/config/sentry"
"gitlab.com/gitlab-org/gitaly/internal/praefect/models"
)
func TestConfigValidation(t *testing.T) {
nodes := []*models.Node{
{Storage: "internal-1", Address: "localhost:23456", Token: "secret-token", DefaultPrimary: true},
{Storage: "internal-2", Address: "localhost:23457", Token: "secret-token"},
{Storage: "internal-3", Address: "localhost:23458", Token: "secret-token"},
}
testCases := []struct {
desc string
config Config
err error
}{
{
desc: "No ListenAddr or SocketPath",
config: Config{ListenAddr: "", VirtualStorages: []*VirtualStorage{&VirtualStorage{Nodes: nodes}}},
err: errNoListener,
},
{
desc: "Only a SocketPath",
config: Config{SocketPath: "/tmp/praefect.socket", VirtualStorages: []*VirtualStorage{&VirtualStorage{Nodes: nodes}}},
err: nil,
},
{
desc: "No servers",
config: Config{ListenAddr: "localhost:1234"},
err: errNoVirtualStorages,
},
{
desc: "duplicate storage",
config: Config{
ListenAddr: "localhost:1234",
VirtualStorages: []*VirtualStorage{
&VirtualStorage{Nodes: append(nodes, &models.Node{Storage: nodes[0].Storage, Address: nodes[1].Address})},
},
},
err: errDuplicateStorage,
},
{
desc: "Valid config",
config: Config{ListenAddr: "localhost:1234", VirtualStorages: []*VirtualStorage{&VirtualStorage{Nodes: nodes}}},
err: nil,
},
{
desc: "No designated primaries",
config: Config{ListenAddr: "localhost:1234", VirtualStorages: []*VirtualStorage{&VirtualStorage{Nodes: nodes[1:]}}},
err: errNoPrimaries,
},
{
desc: "More than 1 primary",
config: Config{
ListenAddr: "localhost:1234",
VirtualStorages: []*VirtualStorage{
&VirtualStorage{
Nodes: append(nodes,
&models.Node{
Storage: "internal-4",
Address: "localhost:23459",
Token: "secret-token",
DefaultPrimary: true,
}),
},
},
},
err: errMoreThanOnePrimary,
},
{
desc: "Node storage not unique",
config: Config{
ListenAddr: "localhost:1234",
VirtualStorages: []*VirtualStorage{
&VirtualStorage{Name: "default", Nodes: nodes},
&VirtualStorage{
Name: "backup",
Nodes: []*models.Node{
&models.Node{
Storage: nodes[0].Storage,
Address: "some.other.address",
DefaultPrimary: true},
},
},
},
},
err: errStorageAddressMismatch,
},
{
desc: "Node storage not unique",
config: Config{
ListenAddr: "localhost:1234",
VirtualStorages: []*VirtualStorage{
&VirtualStorage{Name: "default", Nodes: nodes},
&VirtualStorage{
Name: "default",
Nodes: []*models.Node{
&models.Node{
Storage: nodes[0].Storage,
Address: "some.other.address",
DefaultPrimary: true}},
},
},
},
err: errVirtualStoragesNotUnique,
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
err := tc.config.Validate()
if tc.err == nil {
assert.NoError(t, err)
return
}
assert.True(t, strings.Contains(err.Error(), tc.err.Error()))
})
}
}
func TestConfigParsing(t *testing.T) {
testCases := []struct {
filePath string
expected Config
}{
{
filePath: "testdata/config.toml",
expected: Config{
Logging: log.Config{
Level: "info",
Format: "json",
},
Sentry: sentry.Config{
DSN: "abcd123",
Environment: "production",
},
VirtualStorages: []*VirtualStorage{
&VirtualStorage{
Name: "praefect",
Nodes: []*models.Node{
&models.Node{
Address: "tcp://gitaly-internal-1.example.com",
Storage: "praefect-internal-1",
DefaultPrimary: true,
},
{
Address: "tcp://gitaly-internal-2.example.com",
Storage: "praefect-internal-2",
},
{
Address: "tcp://gitaly-internal-3.example.com",
Storage: "praefect-internal-3",
},
},
},
},
Prometheus: gitaly_prometheus.Config{
GRPCLatencyBuckets: []float64{0.1, 0.2, 0.3},
},
DB: DB{
Host: "1.2.3.4",
Port: 5432,
User: "praefect",
Password: "db-secret",
DBName: "praefect_production",
SSLMode: "require",
SSLCert: "/path/to/cert",
SSLKey: "/path/to/key",
SSLRootCert: "/path/to/root-cert",
},
PostgresQueueEnabled: true,
},
},
}
for _, tc := range testCases {
t.Run(tc.filePath, func(t *testing.T) {
cfg, err := FromFile(tc.filePath)
require.NoError(t, err)
require.Equal(t, tc.expected, cfg)
})
}
}
func TestToPQString(t *testing.T) {
testCases := []struct {
desc string
in DB
out string
}{
{desc: "empty", in: DB{}, out: "binary_parameters=yes"},
{
desc: "basic example",
in: DB{
Host: "1.2.3.4",
Port: 2345,
User: "praefect-user",
Password: "secret",
DBName: "praefect_production",
SSLMode: "require",
SSLCert: "/path/to/cert",
SSLKey: "/path/to/key",
SSLRootCert: "/path/to/root-cert",
},
out: `port=2345 host=1.2.3.4 user=praefect-user password=secret dbname=praefect_production sslmode=require sslcert=/path/to/cert sslkey=/path/to/key sslrootcert=/path/to/root-cert binary_parameters=yes`,
},
{
desc: "with spaces and quotes",
in: DB{
Password: "secret foo'bar",
},
out: `password=secret\ foo\'bar binary_parameters=yes`,
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
require.Equal(t, tc.out, tc.in.ToPQString())
})
}
}
func TestNeedsSQL(t *testing.T) {
testCases := []struct {
desc string
config Config
expected bool
}{
{
desc: "default",
config: Config{},
expected: false,
},
{
desc: "PostgreSQL queue enabled",
config: Config{PostgresQueueEnabled: true},
expected: true,
},
{
desc: "Failover enabled with default election strategy",
config: Config{Failover: Failover{Enabled: true}},
expected: false,
},
{
desc: "Failover enabled with SQL election strategy",
config: Config{Failover: Failover{Enabled: true, ElectionStrategy: "sql"}},
expected: true,
},
{
desc: "Both PostgresQL and SQL election strategy enabled",
config: Config{PostgresQueueEnabled: true, Failover: Failover{Enabled: true, ElectionStrategy: "sql"}},
expected: true,
},
{
desc: "Both PostgresQL and SQL election strategy enabled but failover disabled",
config: Config{PostgresQueueEnabled: true, Failover: Failover{Enabled: false, ElectionStrategy: "sql"}},
expected: true,
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
require.Equal(t, tc.expected, tc.config.NeedsSQL())
})
}
}
|
