1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
|
package datastore
import (
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper"
)
func TestAssignmentStore_GetHostAssignments(t *testing.T) {
type assignment struct {
virtualStorage string
relativePath string
storage string
}
configuredStorages := []string{"storage-1", "storage-2", "storage-3"}
for _, tc := range []struct {
desc string
virtualStorage string
existingAssignments []assignment
expectedAssignments []string
error error
}{
{
desc: "virtual storage not found",
virtualStorage: "invalid-virtual-storage",
error: newVirtualStorageNotFoundError("invalid-virtual-storage"),
},
{
desc: "configured storages fallback when no records",
virtualStorage: "virtual-storage",
expectedAssignments: configuredStorages,
},
{
desc: "configured storages fallback when a repo exists in different virtual storage",
virtualStorage: "virtual-storage",
existingAssignments: []assignment{
{virtualStorage: "other-virtual-storage", relativePath: "relative-path", storage: "storage-1"},
},
expectedAssignments: configuredStorages,
},
{
desc: "configured storages fallback when a different repo exists in the virtual storage ",
virtualStorage: "virtual-storage",
existingAssignments: []assignment{
{virtualStorage: "virtual-storage", relativePath: "other-relative-path", storage: "storage-1"},
},
expectedAssignments: configuredStorages,
},
{
desc: "unconfigured storages are ignored",
virtualStorage: "virtual-storage",
existingAssignments: []assignment{
{virtualStorage: "virtual-storage", relativePath: "relative-path", storage: "unconfigured-storage"},
},
expectedAssignments: configuredStorages,
},
{
desc: "assignments found",
virtualStorage: "virtual-storage",
existingAssignments: []assignment{
{virtualStorage: "virtual-storage", relativePath: "relative-path", storage: "storage-1"},
{virtualStorage: "virtual-storage", relativePath: "relative-path", storage: "storage-2"},
{virtualStorage: "virtual-storage", relativePath: "relative-path", storage: "unconfigured"},
},
expectedAssignments: []string{"storage-1", "storage-2"},
},
} {
t.Run(tc.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
db := getDB(t)
for _, assignment := range tc.existingAssignments {
_, err := db.ExecContext(ctx, `
INSERT INTO repositories (virtual_storage, relative_path)
VALUES ($1, $2)
ON CONFLICT DO NOTHING
`, assignment.virtualStorage, assignment.relativePath)
require.NoError(t, err)
_, err = db.ExecContext(ctx, `
INSERT INTO repository_assignments VALUES ($1, $2, $3)
`, assignment.virtualStorage, assignment.relativePath, assignment.storage)
require.NoError(t, err)
}
actualAssignments, err := NewAssignmentStore(
db,
map[string][]string{"virtual-storage": configuredStorages},
).GetHostAssignments(ctx, tc.virtualStorage, "relative-path")
require.Equal(t, tc.error, err)
require.ElementsMatch(t, tc.expectedAssignments, actualAssignments)
})
}
}
func TestAssignmentStore_SetReplicationFactor(t *testing.T) {
type matcher func(testing.TB, []string)
equal := func(expected []string) matcher {
return func(t testing.TB, actual []string) {
t.Helper()
require.Equal(t, expected, actual)
}
}
contains := func(expecteds ...[]string) matcher {
return func(t testing.TB, actual []string) {
t.Helper()
require.Contains(t, expecteds, actual)
}
}
for _, tc := range []struct {
desc string
existingAssignments []string
nonExistentRepository bool
replicationFactor int
requireStorages matcher
error error
}{
{
desc: "increase replication factor of non-existent repository",
nonExistentRepository: true,
replicationFactor: 1,
error: newRepositoryNotFoundError("virtual-storage", "relative-path"),
},
{
desc: "primary prioritized when setting the first assignments",
replicationFactor: 1,
requireStorages: equal([]string{"primary"}),
},
{
desc: "increasing replication factor ignores unconfigured storages",
existingAssignments: []string{"unconfigured-storage"},
replicationFactor: 1,
requireStorages: equal([]string{"primary"}),
},
{
desc: "replication factor already achieved",
existingAssignments: []string{"primary", "secondary-1"},
replicationFactor: 2,
requireStorages: equal([]string{"primary", "secondary-1"}),
},
{
desc: "increase replication factor by a step",
existingAssignments: []string{"primary"},
replicationFactor: 2,
requireStorages: contains([]string{"primary", "secondary-1"}, []string{"primary", "secondary-2"}),
},
{
desc: "increase replication factor to maximum",
existingAssignments: []string{"primary"},
replicationFactor: 3,
requireStorages: equal([]string{"primary", "secondary-1", "secondary-2"}),
},
{
desc: "increased replication factor unattainable",
existingAssignments: []string{"primary"},
replicationFactor: 4,
error: newUnattainableReplicationFactorError(4, 3),
},
{
desc: "decreasing replication factor ignores unconfigured storages",
existingAssignments: []string{"secondary-1", "unconfigured-storage"},
replicationFactor: 1,
requireStorages: equal([]string{"secondary-1"}),
},
{
desc: "decrease replication factor by a step",
existingAssignments: []string{"primary", "secondary-1", "secondary-2"},
replicationFactor: 2,
requireStorages: contains([]string{"primary", "secondary-1"}, []string{"primary", "secondary-2"}),
},
{
desc: "decrease replication factor to minimum",
existingAssignments: []string{"primary", "secondary-1", "secondary-2"},
replicationFactor: 1,
requireStorages: equal([]string{"primary"}),
},
{
desc: "minimum replication factor is enforced",
replicationFactor: 0,
error: newMinimumReplicationFactorError(0),
},
} {
t.Run(tc.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
db := getDB(t)
configuredStorages := map[string][]string{"virtual-storage": {"primary", "secondary-1", "secondary-2"}}
if !tc.nonExistentRepository {
_, err := db.ExecContext(ctx, `
INSERT INTO repositories (virtual_storage, relative_path, "primary")
VALUES ('virtual-storage', 'relative-path', 'primary')
`)
require.NoError(t, err)
}
for _, storage := range tc.existingAssignments {
_, err := db.ExecContext(ctx, `
INSERT INTO repository_assignments VALUES ('virtual-storage', 'relative-path', $1)
`, storage)
require.NoError(t, err)
}
store := NewAssignmentStore(db, configuredStorages)
setStorages, err := store.SetReplicationFactor(ctx, "virtual-storage", "relative-path", tc.replicationFactor)
require.Equal(t, tc.error, err)
if tc.error != nil {
return
}
tc.requireStorages(t, setStorages)
assignedStorages, err := store.GetHostAssignments(ctx, "virtual-storage", "relative-path")
require.NoError(t, err)
tc.requireStorages(t, assignedStorages)
})
}
}
|
