1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
|
//go:build !gitaly_test_sha256
package praefect
import (
"context"
"net"
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/proto/v15/go/gitalypb"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v15/internal/gitaly/service/setup"
"gitlab.com/gitlab-org/gitaly/v15/internal/praefect/config"
"gitlab.com/gitlab-org/gitaly/v15/internal/praefect/datastore"
"gitlab.com/gitlab-org/gitaly/v15/internal/praefect/grpc-proxy/proxy"
"gitlab.com/gitlab-org/gitaly/v15/internal/praefect/protoregistry"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testdb"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testserver"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/credentials/insecure"
"google.golang.org/grpc/status"
)
func TestRemoveRepositoryHandler(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
errServedByGitaly := status.Error(codes.Unknown, "request passed to Gitaly")
const virtualStorage, relativePath = "virtual-storage", "relative-path"
db := testdb.New(t)
for _, tc := range []struct {
desc string
routeToGitaly bool
repository *gitalypb.Repository
repoDeleted bool
error error
}{
{
desc: "missing repository",
error: errMissingRepository,
},
{
desc: "repository not found",
repository: &gitalypb.Repository{StorageName: "virtual-storage", RelativePath: "doesn't exist"},
error: structerr.NewNotFound("repository does not exist"),
},
{
desc: "repository found",
repository: &gitalypb.Repository{StorageName: "virtual-storage", RelativePath: relativePath},
repoDeleted: true,
},
{
desc: "routed to gitaly",
routeToGitaly: true,
error: errServedByGitaly,
},
} {
t.Run(tc.desc, func(t *testing.T) {
db.TruncateAll(t)
const gitaly1Storage = "gitaly-1"
gitaly1Cfg := testcfg.Build(t, testcfg.WithStorages(gitaly1Storage))
gitaly1RepoPath := filepath.Join(gitaly1Cfg.Storages[0].Path, relativePath)
gitaly1Addr := testserver.RunGitalyServer(t, gitaly1Cfg, nil, setup.RegisterAll, testserver.WithDisablePraefect())
const gitaly2Storage = "gitaly-2"
gitaly2Cfg := testcfg.Build(t, testcfg.WithStorages(gitaly2Storage))
gitaly2RepoPath := filepath.Join(gitaly2Cfg.Storages[0].Path, relativePath)
gitaly2Addr := testserver.RunGitalyServer(t, gitaly2Cfg, nil, setup.RegisterAll, testserver.WithDisablePraefect())
cfg := config.Config{VirtualStorages: []*config.VirtualStorage{
{
Name: virtualStorage,
Nodes: []*config.Node{
{Storage: gitaly1Storage, Address: gitaly1Addr},
{Storage: gitaly2Storage, Address: gitaly2Addr},
},
},
}}
for _, repoPath := range []string{gitaly1RepoPath, gitaly2RepoPath} {
gittest.Exec(t, gitaly1Cfg, "init", "--bare", repoPath)
}
rs := datastore.NewPostgresRepositoryStore(db, cfg.StorageNames())
require.NoError(t, rs.CreateRepository(ctx, 0, virtualStorage, relativePath, relativePath, gitaly1Storage, []string{gitaly2Storage, "non-existent-storage"}, nil, false, false))
tmp := testhelper.TempDir(t)
ln, err := net.Listen("unix", filepath.Join(tmp, "praefect"))
require.NoError(t, err)
electionStrategy := config.ElectionStrategyPerRepository
if tc.routeToGitaly {
electionStrategy = config.ElectionStrategySQL
}
nodeSet, err := DialNodes(ctx, cfg.VirtualStorages, nil, nil, nil, nil)
require.NoError(t, err)
defer nodeSet.Close()
srv := NewGRPCServer(
config.Config{Failover: config.Failover{ElectionStrategy: electionStrategy}},
testhelper.NewDiscardingLogEntry(t),
protoregistry.GitalyProtoPreregistered,
func(ctx context.Context, fullMethodName string, peeker proxy.StreamPeeker) (*proxy.StreamParameters, error) {
return nil, errServedByGitaly
},
nil,
rs,
nil,
nodeSet.Connections(),
nil,
nil,
nil,
)
defer srv.Stop()
go testhelper.MustServe(t, srv, ln)
clientConn, err := grpc.DialContext(ctx, "unix:"+ln.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials()))
require.NoError(t, err)
defer clientConn.Close()
client := gitalypb.NewRepositoryServiceClient(clientConn)
_, err = client.RepositorySize(ctx, &gitalypb.RepositorySizeRequest{Repository: tc.repository})
testhelper.RequireGrpcError(t, errServedByGitaly, err)
assertExistence := require.DirExists
if tc.repoDeleted {
assertExistence = require.NoDirExists
}
resp, err := client.RemoveRepository(ctx, &gitalypb.RemoveRepositoryRequest{Repository: tc.repository})
if tc.error != nil {
testhelper.RequireGrpcError(t, tc.error, err)
assertExistence(t, gitaly1RepoPath)
assertExistence(t, gitaly2RepoPath)
return
}
require.NoError(t, err)
testhelper.ProtoEqual(t, &gitalypb.RemoveRepositoryResponse{}, resp)
assertExistence(t, gitaly1RepoPath)
assertExistence(t, gitaly2RepoPath)
})
}
}
|
