1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
|
package rubyserver
import (
"errors"
"testing"
"time"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/config"
"gitlab.com/gitlab-org/gitaly/internal/supervisor"
)
func TestWorker(t *testing.T) {
restartDelay := 10 * time.Millisecond
defer func(old time.Duration) {
config.Config.Ruby.RestartDelay = old
}(config.Config.Ruby.RestartDelay)
config.Config.Ruby.RestartDelay = restartDelay
events := make(chan supervisor.Event)
addr := "the address"
w := newWorker(&supervisor.Process{Name: "testing"}, addr, events, true)
t.Log("ignore health failures during startup")
mustIgnore(t, w, func() { events <- healthBadEvent() })
firstPid := 123
t.Log("register first PID as 'up'")
mustAdd(t, w, addr, func() { events <- upEvent(firstPid) })
t.Log("ignore repeated up event")
mustIgnore(t, w, func() { events <- upEvent(firstPid) })
t.Log("send mem high events but too fast to trigger restart")
for i := 0; i < 5; i++ {
mustIgnore(t, w, func() { events <- memHighEvent(firstPid) })
}
t.Log("mem low resets mem high counter")
mustIgnore(t, w, func() { events <- memLowEvent(firstPid) })
t.Log("send mem high events but too fast to trigger restart")
for i := 0; i < 5; i++ {
mustIgnore(t, w, func() { events <- memHighEvent(firstPid) })
}
time.Sleep(2 * restartDelay)
t.Log("this mem high should push us over the threshold")
mustRemove(t, w, addr, func() { events <- memHighEvent(firstPid) })
t.Log("ignore health failures during startup")
mustIgnore(t, w, func() { events <- healthBadEvent() })
secondPid := 456
t.Log("registering a new PID")
mustAdd(t, w, addr, func() { events <- upEvent(secondPid) })
t.Log("ignore mem high events for the previous pid")
mustIgnore(t, w, func() { events <- memHighEvent(firstPid) })
time.Sleep(2 * restartDelay)
t.Log("ignore mem high also after restart delay has expired")
mustIgnore(t, w, func() { events <- memHighEvent(firstPid) })
t.Log("start high memory timer")
mustIgnore(t, w, func() { events <- memHighEvent(secondPid) })
t.Log("ignore mem low event for wrong pid")
mustIgnore(t, w, func() { events <- memLowEvent(firstPid) })
t.Log("send mem high count over the threshold")
time.Sleep(2 * restartDelay)
mustRemove(t, w, addr, func() { events <- memHighEvent(secondPid) })
}
func TestWorkerHealthChecks(t *testing.T) {
restartDelay := 10 * time.Millisecond
defer func(old time.Duration) {
healthRestartDelay = old
}(healthRestartDelay)
healthRestartDelay = restartDelay
defer func(old time.Duration) {
healthRestartCoolOff = old
}(healthRestartCoolOff)
healthRestartCoolOff = restartDelay
events := make(chan supervisor.Event)
addr := "the address"
w := newWorker(&supervisor.Process{Name: "testing"}, addr, events, true)
t.Log("ignore health failures during startup")
mustIgnore(t, w, func() { events <- healthBadEvent() })
firstPid := 123
t.Log("register first PID as 'up'")
mustAdd(t, w, addr, func() { events <- upEvent(firstPid) })
t.Log("still ignore health failures during startup")
mustIgnore(t, w, func() { events <- healthBadEvent() })
time.Sleep(2 * restartDelay)
t.Log("waited long enough, this health check should start health timer")
mustIgnore(t, w, func() { events <- healthBadEvent() })
time.Sleep(2 * restartDelay)
t.Log("this second failed health check should trigger failover")
mustRemove(t, w, addr, func() { events <- healthBadEvent() })
t.Log("ignore extra health failures")
mustIgnore(t, w, func() { events <- healthBadEvent() })
}
func mustIgnore(t *testing.T, w *worker, f func()) {
nothing := ¬hingBalancer{t}
w.balancerUpdate <- nothing
t.Log("executing function that should be ignored by balancer")
f()
// This second balancer update is used to synchronize with the monitor
// goroutine. When the channel send finishes, we know the event we sent
// before must have been processed.
w.balancerUpdate <- nothing
}
func mustAdd(t *testing.T, w *worker, addr string, f func()) {
add := newAdd(t, addr)
w.balancerUpdate <- add
t.Log("executing function that should lead to balancer.AddAddress")
f()
add.wait()
}
func mustRemove(t *testing.T, w *worker, addr string, f func()) {
remove := newRemove(t, addr)
w.balancerUpdate <- remove
t.Log("executing function that should lead to balancer.RemoveAddress")
f()
remove.wait()
}
func waitFail(t *testing.T, done chan struct{}) {
select {
case <-time.After(1 * time.Second):
t.Fatal("timeout waiting for balancer method call")
case <-done:
}
}
func upEvent(pid int) supervisor.Event {
return supervisor.Event{Type: supervisor.Up, Pid: pid}
}
func memHighEvent(pid int) supervisor.Event {
return supervisor.Event{Type: supervisor.MemoryHigh, Pid: pid}
}
func memLowEvent(pid int) supervisor.Event {
return supervisor.Event{Type: supervisor.MemoryLow, Pid: pid}
}
func healthBadEvent() supervisor.Event {
return supervisor.Event{Type: supervisor.HealthBad, Error: errors.New("test bad health")}
}
func newAdd(t *testing.T, addr string) *addBalancer {
return &addBalancer{
t: t,
addr: addr,
done: make(chan struct{}),
}
}
type addBalancer struct {
addr string
t *testing.T
done chan struct{}
}
func (ab *addBalancer) RemoveAddress(string) bool {
ab.t.Fatal("unexpected RemoveAddress call")
return false
}
func (ab *addBalancer) AddAddress(s string) {
require.Equal(ab.t, ab.addr, s, "addBalancer expected AddAddress argument")
close(ab.done)
}
func (ab *addBalancer) wait() {
waitFail(ab.t, ab.done)
}
func newRemove(t *testing.T, addr string) *removeBalancer {
return &removeBalancer{
t: t,
addr: addr,
done: make(chan struct{}),
}
}
type removeBalancer struct {
addr string
t *testing.T
done chan struct{}
}
func (rb *removeBalancer) RemoveAddress(s string) bool {
require.Equal(rb.t, rb.addr, s, "removeBalancer expected RemoveAddress argument")
close(rb.done)
return true
}
func (rb *removeBalancer) AddAddress(s string) {
rb.t.Fatal("unexpected AddAddress call")
}
func (rb *removeBalancer) wait() {
waitFail(rb.t, rb.done)
}
type nothingBalancer struct {
t *testing.T
}
func (nb *nothingBalancer) RemoveAddress(s string) bool {
nb.t.Fatal("unexpected RemoveAddress call")
return true
}
func (nb *nothingBalancer) AddAddress(s string) {
nb.t.Fatal("unexpected AddAddress call")
}
|