1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
|
package safe_test
import (
"errors"
"io/fs"
"os"
"path/filepath"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v14/internal/safe"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper"
)
func TestLockingDirectory(t *testing.T) {
t.Parallel()
t.Run("normal lifecycle", func(t *testing.T) {
path := testhelper.TempDir(t)
lockingDir, err := safe.NewLockingDirectory(path)
require.NoError(t, err)
require.NoError(t, lockingDir.Lock())
secondLockingDir, err := safe.NewLockingDirectory(path)
require.NoError(t, err)
require.NoError(t, os.WriteFile(
filepath.Join(path, "somefile"),
[]byte("data"),
0o644),
)
assert.ErrorIs(t, secondLockingDir.Lock(), safe.ErrFileAlreadyLocked)
require.NoError(t, lockingDir.Unlock())
})
t.Run("multiple locks fail", func(t *testing.T) {
path := testhelper.TempDir(t)
lockingDir, err := safe.NewLockingDirectory(path)
require.NoError(t, err)
require.NoError(t, lockingDir.Lock())
assert.Equal(
t,
errors.New("locking directory not lockable"),
lockingDir.Lock(),
)
})
t.Run("unlock without lock fails", func(t *testing.T) {
path := testhelper.TempDir(t)
lockingDir, err := safe.NewLockingDirectory(path)
require.NoError(t, err)
assert.Equal(
t,
errors.New("locking directory not locked"),
lockingDir.Unlock(),
)
})
t.Run("multiple unlocks fail", func(t *testing.T) {
path := testhelper.TempDir(t)
lockingDir, err := safe.NewLockingDirectory(path)
require.NoError(t, err)
require.NoError(t, lockingDir.Lock())
require.NoError(t, lockingDir.Unlock())
assert.Equal(
t,
errors.New("locking directory not locked"),
lockingDir.Unlock(),
)
})
t.Run("fails if directory is missing", func(t *testing.T) {
path := testhelper.TempDir(t)
require.NoError(t, os.RemoveAll(path))
_, err := safe.NewLockingDirectory(path)
assert.True(t, errors.Is(err, fs.ErrNotExist))
})
}
|
