1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
|
package server
import (
"net"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/auth"
"gitlab.com/gitlab-org/gitaly/internal/config"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
netctx "golang.org/x/net/context"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
healthpb "google.golang.org/grpc/health/grpc_health_v1"
)
func TestSanity(t *testing.T) {
srv, serverSocketPath := runServer(t)
defer srv.Stop()
connOpts := []grpc.DialOption{
grpc.WithInsecure(),
}
conn, err := dial(serverSocketPath, connOpts)
require.NoError(t, err)
defer conn.Close()
require.NoError(t, healthCheck(conn))
}
func TestAuthFailures(t *testing.T) {
defer func(oldAuth config.Auth) {
config.Config.Auth = oldAuth
}(config.Config.Auth)
config.Config.Auth.Token = "quxbaz"
testCases := []struct {
desc string
opts []grpc.DialOption
code codes.Code
}{
{desc: "no auth", opts: nil, code: codes.Unauthenticated},
{
desc: "invalid auth",
opts: []grpc.DialOption{grpc.WithPerRPCCredentials(brokenAuth{})},
code: codes.Unauthenticated,
},
{
desc: "wrong secret",
opts: []grpc.DialOption{grpc.WithPerRPCCredentials(gitalyauth.RPCCredentials("foobar"))},
code: codes.PermissionDenied,
},
{
desc: "wrong secret new auth",
opts: []grpc.DialOption{grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2("foobar"))},
code: codes.PermissionDenied,
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
srv, serverSocketPath := runServer(t)
defer srv.Stop()
connOpts := append(tc.opts, grpc.WithInsecure())
conn, err := dial(serverSocketPath, connOpts)
require.NoError(t, err, tc.desc)
defer conn.Close()
testhelper.RequireGrpcError(t, healthCheck(conn), tc.code)
})
}
}
func TestAuthSuccess(t *testing.T) {
defer func(oldAuth config.Auth) {
config.Config.Auth = oldAuth
}(config.Config.Auth)
token := "foobar"
testCases := []struct {
desc string
opts []grpc.DialOption
required bool
token string
}{
{desc: "no auth, not required"},
{
desc: "v1 incorrect auth, not required",
opts: []grpc.DialOption{grpc.WithPerRPCCredentials(gitalyauth.RPCCredentials("incorrect"))},
token: token,
},
{
desc: "v1 correct auth, not required",
opts: []grpc.DialOption{grpc.WithPerRPCCredentials(gitalyauth.RPCCredentials(token))},
token: token,
},
{
desc: "v1 correct auth, required",
opts: []grpc.DialOption{grpc.WithPerRPCCredentials(gitalyauth.RPCCredentials(token))},
token: token,
required: true,
},
{
desc: "v2 correct new auth, not required",
opts: []grpc.DialOption{grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2(token))},
token: token,
},
{
desc: "v2 incorrect auth, not required",
opts: []grpc.DialOption{grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2("incorrect"))},
token: token,
},
{
desc: "v2 correct new auth, required",
opts: []grpc.DialOption{grpc.WithPerRPCCredentials(gitalyauth.RPCCredentialsV2(token))},
token: token,
required: true,
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
config.Config.Auth = config.Auth{
Transitioning: !tc.required,
Token: tc.token,
}
srv, serverSocketPath := runServer(t)
defer srv.Stop()
connOpts := append(tc.opts, grpc.WithInsecure())
conn, err := dial(serverSocketPath, connOpts)
require.NoError(t, err, tc.desc)
defer conn.Close()
assert.NoError(t, healthCheck(conn), tc.desc)
})
}
}
type brokenAuth struct{}
func (brokenAuth) RequireTransportSecurity() bool { return false }
func (brokenAuth) GetRequestMetadata(netctx.Context, ...string) (map[string]string, error) {
return map[string]string{"authorization": "Bearer blablabla"}, nil
}
func dial(serverSocketPath string, opts []grpc.DialOption) (*grpc.ClientConn, error) {
return grpc.Dial(serverSocketPath, opts...)
}
func healthCheck(conn *grpc.ClientConn) error {
ctx, cancel := testhelper.Context()
defer cancel()
client := healthpb.NewHealthClient(conn)
_, err := client.Check(ctx, &healthpb.HealthCheckRequest{})
return err
}
func runServer(t *testing.T) (*grpc.Server, string) {
srv := New(nil)
serverSocketPath := testhelper.GetTemporaryGitalySocketFileName()
listener, err := net.Listen("unix", serverSocketPath)
require.NoError(t, err)
go srv.Serve(listener)
return srv, "unix://" + serverSocketPath
}
|
