1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
|
package commit
import (
"io"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly-proto/go/gitalypb"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"google.golang.org/grpc/codes"
)
func TestSuccessfulGetCommitSignaturesRequest(t *testing.T) {
server, serverSocketPath := startTestServices(t)
defer server.Stop()
client, conn := newCommitServiceClient(t, serverSocketPath)
defer conn.Close()
testRepo, _, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
ctx, cancel := testhelper.Context()
defer cancel()
request := &gitalypb.GetCommitSignaturesRequest{
Repository: testRepo,
CommitIds: []string{
"5937ac0a7beb003549fc5fd26fc247adbce4a52e", // has signature
"e63f41fe459e62e1228fcef60d7189127aeba95a", // has no signature
"0000000000000000000000000000000000000000", // does not exist
"a17a9f66543673edf0a3d1c6b93bdda3fe600f32", // has signature
},
}
c, err := client.GetCommitSignatures(ctx, request)
require.NoError(t, err)
expectedSignautes := []*gitalypb.GetCommitSignaturesResponse{
{
CommitId: "5937ac0a7beb003549fc5fd26fc247adbce4a52e",
Signature: testhelper.MustReadFile(t, "testdata/commit-5937ac0a7beb003549fc5fd26fc247adbce4a52e-signature"),
SignedText: testhelper.MustReadFile(t, "testdata/commit-5937ac0a7beb003549fc5fd26fc247adbce4a52e-signed-text"),
},
{
CommitId: "a17a9f66543673edf0a3d1c6b93bdda3fe600f32",
Signature: testhelper.MustReadFile(t, "testdata/gitlab-test-commit-a17a9f66543673edf0a3d1c6b93bdda3fe600f32-signature"),
SignedText: testhelper.MustReadFile(t, "testdata/gitlab-test-commit-a17a9f66543673edf0a3d1c6b93bdda3fe600f32-signed-text"),
},
}
fetchedSignatures := readAllSignaturesFromClient(t, c)
require.Equal(t, expectedSignautes, fetchedSignatures)
}
func TestFailedGetCommitSignaturesRequest(t *testing.T) {
server, serverSocketPath := startTestServices(t)
defer server.Stop()
client, conn := newCommitServiceClient(t, serverSocketPath)
defer conn.Close()
testRepo, _, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
testCases := []struct {
desc string
request *gitalypb.GetCommitSignaturesRequest
code codes.Code
}{
{
desc: "empty Repository",
request: &gitalypb.GetCommitSignaturesRequest{
Repository: nil,
CommitIds: []string{"5937ac0a7beb003549fc5fd26fc247adbce4a52e"},
},
code: codes.InvalidArgument,
},
{
desc: "empty CommitIds",
request: &gitalypb.GetCommitSignaturesRequest{
Repository: testRepo,
CommitIds: []string{},
},
code: codes.InvalidArgument,
},
}
for _, testCase := range testCases {
t.Run(testCase.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
c, err := client.GetCommitSignatures(ctx, testCase.request)
require.NoError(t, err)
for {
_, err = c.Recv()
if err != nil {
break
}
}
testhelper.RequireGrpcError(t, err, testCase.code)
})
}
}
func readAllSignaturesFromClient(t *testing.T, c gitalypb.CommitService_GetCommitSignaturesClient) (signatures []*gitalypb.GetCommitSignaturesResponse) {
for {
resp, err := c.Recv()
if err == io.EOF {
break
}
require.NoError(t, err)
if resp.CommitId != "" {
signatures = append(signatures, resp)
// first message contains either Signature or SignedText so no need to append anything
continue
}
currentSignature := signatures[len(signatures)-1]
if len(resp.Signature) != 0 {
currentSignature.Signature = append(currentSignature.Signature, resp.Signature...)
} else if len(resp.SignedText) != 0 {
currentSignature.SignedText = append(currentSignature.SignedText, resp.SignedText...)
}
}
return
}
|
