1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
|
package objectpool
import (
"fmt"
"io/ioutil"
"os"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git"
"gitlab.com/gitlab-org/gitaly/internal/git/objectpool"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
)
func TestDisconnectGitAlternates(t *testing.T) {
stop, serverSocketPath := runObjectPoolServer(t)
defer stop()
client, conn := newObjectPoolClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
testRepo, testRepoPath, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
pool, err := objectpool.NewObjectPool(testRepo.GetStorageName(), testhelper.NewTestObjectPoolName(t))
require.NoError(t, err)
defer pool.Remove(ctx)
require.NoError(t, pool.Create(ctx, testRepo))
require.NoError(t, pool.Link(ctx, testRepo))
testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "gc")
existingObjectID := "55bc176024cfa3baaceb71db584c7e5df900ea65"
// Corrupt the repository to check that existingObjectID can no longer be found
altPath, err := git.InfoAlternatesPath(testRepo)
require.NoError(t, err, "find info/alternates")
require.NoError(t, os.RemoveAll(altPath))
cmd, err := git.SafeCmd(ctx, testRepo, nil,
git.SubCmd{Name: "cat-file", Flags: []git.Option{git.Flag{Name: "-e"}}, Args: []string{existingObjectID}})
require.NoError(t, err)
require.Error(t, cmd.Wait(), "expect cat-file to fail because object cannot be found")
require.NoError(t, pool.Link(ctx, testRepo))
require.FileExists(t, altPath, "objects/info/alternates should be back")
// At this point we know that the repository has access to
// existingObjectID, but only if objects/info/alternates is in place.
_, err = client.DisconnectGitAlternates(ctx, &gitalypb.DisconnectGitAlternatesRequest{Repository: testRepo})
require.NoError(t, err, "call DisconnectGitAlternates")
// Check that the object can still be found, even though
// objects/info/alternates is gone. This is the purpose of
// DisconnectGitAlternates.
testhelper.AssertPathNotExists(t, altPath)
testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "cat-file", "-e", existingObjectID)
}
func TestDisconnectGitAlternatesNoAlternates(t *testing.T) {
stop, serverSocketPath := runObjectPoolServer(t)
defer stop()
client, conn := newObjectPoolClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
testRepo, testRepoPath, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
altPath, err := git.InfoAlternatesPath(testRepo)
require.NoError(t, err, "find info/alternates")
testhelper.AssertPathNotExists(t, altPath)
_, err = client.DisconnectGitAlternates(ctx, &gitalypb.DisconnectGitAlternatesRequest{Repository: testRepo})
require.NoError(t, err, "call DisconnectGitAlternates on repository without alternates")
testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "fsck")
}
func TestDisconnectGitAlternatesUnexpectedAlternates(t *testing.T) {
stop, serverSocketPath := runObjectPoolServer(t)
defer stop()
client, conn := newObjectPoolClient(t, serverSocketPath)
defer conn.Close()
ctx, cancel := testhelper.Context()
defer cancel()
testCases := []struct {
desc string
altContent string
}{
{desc: "multiple alternates", altContent: "/foo/bar\n/qux/baz\n"},
{desc: "directory not found", altContent: "/does/not/exist/\n"},
{desc: "not a directory", altContent: "../HEAD\n"},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
testRepo, _, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
altPath, err := git.InfoAlternatesPath(testRepo)
require.NoError(t, err, "find info/alternates")
require.NoError(t, ioutil.WriteFile(altPath, []byte(tc.altContent), 0644))
_, err = client.DisconnectGitAlternates(ctx, &gitalypb.DisconnectGitAlternatesRequest{Repository: testRepo})
require.Error(t, err, "call DisconnectGitAlternates on repository with unexpected objects/info/alternates")
contentAfterRPC, err := ioutil.ReadFile(altPath)
require.NoError(t, err, "read back objects/info/alternates")
require.Equal(t, tc.altContent, string(contentAfterRPC), "objects/info/alternates content should not have changed")
})
}
}
func TestRemoveAlternatesIfOk(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
testRepo, testRepoPath, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
altPath, err := git.InfoAlternatesPath(testRepo)
require.NoError(t, err, "find info/alternates")
altContent := "/var/empty\n"
require.NoError(t, ioutil.WriteFile(altPath, []byte(altContent), 0644), "write alternates file")
// Intentionally break the repository, so that 'git fsck' will fail later.
testhelper.MustRunCommand(t, nil, "sh", "-c", fmt.Sprintf("rm %s/objects/pack/*.pack", testRepoPath))
altBackup := altPath + ".backup"
err = removeAlternatesIfOk(ctx, testRepo, altPath, altBackup)
require.Error(t, err, "removeAlternatesIfOk should fail")
require.IsType(t, &fsckError{}, err, "error must be because of fsck")
// We expect objects/info/alternates to have been restored when
// removeAlternatesIfOk returned.
assertAlternates(t, altPath, altContent)
// We expect the backup alternates file to still exist.
assertAlternates(t, altBackup, altContent)
}
func assertAlternates(t *testing.T, altPath string, altContent string) {
actualContent, err := ioutil.ReadFile(altPath)
require.NoError(t, err, "read %s after fsck failure", altPath)
require.Equal(t, altContent, string(actualContent), "%s content after fsck failure", altPath)
}
|
