1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
|
package repository
import (
"bufio"
"bytes"
"strings"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)
func TestDeleteConfig(t *testing.T) {
server, serverSocketPath := runRepoServer(t)
defer server.Stop()
client, conn := newRepositoryClient(t, serverSocketPath)
defer conn.Close()
testcases := []struct {
desc string
addKeys []string
reqKeys []string
code codes.Code
}{
{
desc: "empty request",
},
{
desc: "keys that don't exist",
reqKeys: []string{"test.foo", "test.bar"},
},
{
desc: "mix of keys that do and do not exist",
addKeys: []string{"test.bar"},
reqKeys: []string{"test.foo", "test.bar", "test.baz"},
},
}
for _, tc := range testcases {
t.Run(tc.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
testRepo, testRepoPath, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
for _, k := range tc.addKeys {
testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "config", k, "blabla")
}
_, err := client.DeleteConfig(ctx, &gitalypb.DeleteConfigRequest{Repository: testRepo, Keys: tc.reqKeys})
if tc.code == codes.OK {
require.NoError(t, err)
} else {
require.Equal(t, tc.code, status.Code(err), "expected grpc error code")
return
}
actualConfig := testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "config", "-l")
scanner := bufio.NewScanner(bytes.NewReader(actualConfig))
for scanner.Scan() {
for _, k := range tc.reqKeys {
require.False(t, strings.HasPrefix(scanner.Text(), k+"="), "key %q must not occur in config", k)
}
}
require.NoError(t, scanner.Err())
})
}
}
func TestSetConfig(t *testing.T) {
server, serverSocketPath := runRepoServer(t)
defer server.Stop()
client, conn := newRepositoryClient(t, serverSocketPath)
defer conn.Close()
testcases := []struct {
desc string
entries []*gitalypb.SetConfigRequest_Entry
expected []string
code codes.Code
}{
{
desc: "empty request",
},
{
desc: "mix of different types",
entries: []*gitalypb.SetConfigRequest_Entry{
&gitalypb.SetConfigRequest_Entry{Key: "test.foo1", Value: &gitalypb.SetConfigRequest_Entry_ValueStr{"hello world"}},
&gitalypb.SetConfigRequest_Entry{Key: "test.foo2", Value: &gitalypb.SetConfigRequest_Entry_ValueInt32{1234}},
&gitalypb.SetConfigRequest_Entry{Key: "test.foo3", Value: &gitalypb.SetConfigRequest_Entry_ValueBool{true}},
},
expected: []string{
"test.foo1=hello world",
"test.foo2=1234",
"test.foo3=true",
},
},
}
for _, tc := range testcases {
t.Run(tc.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
testRepo, testRepoPath, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
_, err := client.SetConfig(ctx, &gitalypb.SetConfigRequest{Repository: testRepo, Entries: tc.entries})
if tc.code == codes.OK {
require.NoError(t, err)
} else {
require.Equal(t, tc.code, status.Code(err), "expected grpc error code")
return
}
actualConfigBytes := testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "config", "--local", "-l")
scanner := bufio.NewScanner(bytes.NewReader(actualConfigBytes))
var actualConfig []string
for scanner.Scan() {
actualConfig = append(actualConfig, scanner.Text())
}
require.NoError(t, scanner.Err())
for _, entry := range tc.expected {
require.Contains(t, actualConfig, entry)
}
})
}
}
|