1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
|
package repository
import (
"bytes"
"path"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
"google.golang.org/grpc/codes"
)
func TestWriteRefSuccessful(t *testing.T) {
server, serverSocketPath := runRepoServer(t)
defer server.Stop()
client, conn := newRepositoryClient(t, serverSocketPath)
defer conn.Close()
testRepo, testRepoPath, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
testCases := []struct {
desc string
req *gitalypb.WriteRefRequest
}{
{
desc: "shell update HEAD to refs/heads/master",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Ref: []byte("HEAD"),
Revision: []byte("refs/heads/master"),
},
},
{
desc: "shell update refs/heads/master",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Ref: []byte("refs/heads/master"),
Revision: []byte("b83d6e391c22777fca1ed3012fce84f633d7fed0"),
},
},
{
desc: "shell update refs/heads/master w/ validation",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Ref: []byte("refs/heads/master"),
Revision: []byte("498214de67004b1da3d820901307bed2a68a8ef6"),
OldRevision: []byte("b83d6e391c22777fca1ed3012fce84f633d7fed0"),
},
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
_, err := client.WriteRef(ctx, tc.req)
require.NoError(t, err)
if bytes.Equal(tc.req.Ref, []byte("HEAD")) {
content := testhelper.MustReadFile(t, path.Join(testRepoPath, "HEAD"))
refRevision := bytes.Join([][]byte{[]byte("ref: "), tc.req.Revision, []byte("\n")}, nil)
require.EqualValues(t, content, refRevision)
return
}
rev := testhelper.MustRunCommand(t, nil, "git", "--git-dir", testRepoPath, "log", "--pretty=%H", "-1", string(tc.req.Ref))
rev = bytes.Replace(rev, []byte("\n"), nil, 1)
require.Equal(t, string(tc.req.Revision), string(rev))
})
}
}
func TestWriteRefValidationError(t *testing.T) {
server, serverSocketPath := runRepoServer(t)
defer server.Stop()
client, conn := newRepositoryClient(t, serverSocketPath)
defer conn.Close()
testRepo, _, cleanupFn := testhelper.NewTestRepo(t)
defer cleanupFn()
testCases := []struct {
desc string
req *gitalypb.WriteRefRequest
}{
{
desc: "empty revision",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Ref: []byte("refs/heads/master"),
},
},
{
desc: "empty ref name",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Revision: []byte("498214de67004b1da3d820901307bed2a68a8ef6"),
},
},
{
desc: "non-prefixed ref name for shell",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Ref: []byte("master"),
Revision: []byte("498214de67004b1da3d820901307bed2a68a8ef6"),
},
},
{
desc: "revision contains \\x00",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Ref: []byte("refs/heads/master"),
Revision: []byte("012301230123\x001243"),
},
},
{
desc: "ref contains \\x00",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Ref: []byte("refs/head\x00s/master\x00"),
Revision: []byte("0123012301231243"),
},
},
{
desc: "ref contains whitespace",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Ref: []byte("refs/heads /master"),
Revision: []byte("0123012301231243"),
},
},
{
desc: "invalid revision",
req: &gitalypb.WriteRefRequest{
Repository: testRepo,
Ref: []byte("refs/heads/master"),
Revision: []byte("--output=/meow"),
},
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
_, err := client.WriteRef(ctx, tc.req)
testhelper.RequireGrpcError(t, err, codes.InvalidArgument)
})
}
}
|
