1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
|
package ssh
import (
"bytes"
"fmt"
"os"
"os/exec"
"path"
"strings"
"testing"
"github.com/golang/protobuf/jsonpb"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly-proto/go/gitalypb"
"gitlab.com/gitlab-org/gitaly/internal/config"
"gitlab.com/gitlab-org/gitaly/internal/git"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"golang.org/x/net/context"
"google.golang.org/grpc/codes"
)
func TestFailedUploadPackRequestDueToValidationError(t *testing.T) {
server, serverSocketPath := runSSHServer(t)
defer server.Stop()
client, conn := newSSHClient(t, serverSocketPath)
defer conn.Close()
tests := []struct {
Desc string
Req *gitalypb.SSHUploadPackRequest
Code codes.Code
}{
{
Desc: "Repository.RelativePath is empty",
Req: &gitalypb.SSHUploadPackRequest{Repository: &gitalypb.Repository{StorageName: "default", RelativePath: ""}},
Code: codes.InvalidArgument,
},
{
Desc: "Repository is nil",
Req: &gitalypb.SSHUploadPackRequest{Repository: nil},
Code: codes.InvalidArgument,
},
{
Desc: "Data exists on first request",
Req: &gitalypb.SSHUploadPackRequest{Repository: &gitalypb.Repository{StorageName: "default", RelativePath: "path/to/repo"}, Stdin: []byte("Fail")},
Code: codes.InvalidArgument,
},
}
for _, test := range tests {
t.Run(test.Desc, func(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
stream, err := client.SSHUploadPack(ctx)
if err != nil {
t.Fatal(err)
}
if err = stream.Send(test.Req); err != nil {
t.Fatal(err)
}
stream.CloseSend()
err = drainPostUploadPackResponse(stream)
testhelper.RequireGrpcError(t, err, test.Code)
})
}
}
func TestUploadPackCloneSuccess(t *testing.T) {
server, serverSocketPath := runSSHServer(t)
defer server.Stop()
localRepoPath := path.Join(testRepoRoot, "gitlab-test-upload-pack-local")
tests := []struct {
cmd *exec.Cmd
desc string
}{
{
cmd: exec.Command("git", "clone", "git@localhost:test/test.git", localRepoPath),
desc: "full clone",
},
{
cmd: exec.Command("git", "clone", "--depth", "1", "git@localhost:test/test.git", localRepoPath),
desc: "shallow clone",
},
}
for _, tc := range tests {
t.Run(tc.desc, func(t *testing.T) {
lHead, rHead, _, _, err := testClone(t, serverSocketPath, testRepo.GetStorageName(), testRepo.GetRelativePath(), localRepoPath, "", tc.cmd, "")
require.NoError(t, err, "clone failed")
require.Equal(t, lHead, rHead, "local and remote head not equal")
})
}
}
func TestUploadPackCloneSuccessWithGitProtocol(t *testing.T) {
defer func(old string) {
config.Config.Git.BinPath = old
}(config.Config.Git.BinPath)
config.Config.Git.BinPath = "../../testhelper/env_git"
server, serverSocketPath := runSSHServer(t)
defer server.Stop()
localRepoPath := path.Join(testRepoRoot, "gitlab-test-upload-pack-local")
tests := []struct {
cmd *exec.Cmd
desc string
}{
{
cmd: exec.Command("git", "clone", "git@localhost:test/test.git", localRepoPath),
desc: "full clone",
},
{
cmd: exec.Command("git", "clone", "--depth", "1", "git@localhost:test/test.git", localRepoPath),
desc: "shallow clone",
},
}
for _, tc := range tests {
t.Run(tc.desc, func(t *testing.T) {
lHead, rHead, _, _, err := testClone(t, serverSocketPath, testRepo.GetStorageName(), testRepo.GetRelativePath(), localRepoPath, "", tc.cmd, git.ProtocolV2)
require.NoError(t, err, "clone failed")
require.Equal(t, lHead, rHead, "local and remote head not equal")
envData, err := testhelper.GetGitEnvData()
require.NoError(t, err)
require.Equal(t, fmt.Sprintf("GIT_PROTOCOL=%s\n", git.ProtocolV2), envData)
})
}
}
func TestUploadPackCloneHideTags(t *testing.T) {
server, serverSocketPath := runSSHServer(t)
defer server.Stop()
localRepoPath := path.Join(testRepoRoot, "gitlab-test-upload-pack-local-hide-tags")
cmd := exec.Command("git", "clone", "--mirror", "git@localhost:test/test.git", localRepoPath)
_, _, lTags, rTags, err := testClone(t, serverSocketPath, testRepo.GetStorageName(), testRepo.GetRelativePath(), localRepoPath, "transfer.hideRefs=refs/tags", cmd, "")
if err != nil {
t.Fatalf("clone failed: %v", err)
}
if lTags == rTags {
t.Fatalf("local and remote tags are equal. clone failed: %q != %q", lTags, rTags)
}
if tag := "v1.0.0"; !strings.Contains(rTags, tag) {
t.Fatalf("sanity check failed, tag %q not found in %q", tag, rTags)
}
}
func TestUploadPackCloneFailure(t *testing.T) {
server, serverSocketPath := runSSHServer(t)
defer server.Stop()
localRepoPath := path.Join(testRepoRoot, "gitlab-test-upload-pack-local-failure")
cmd := exec.Command("git", "clone", "git@localhost:test/test.git", localRepoPath)
_, _, _, _, err := testClone(t, serverSocketPath, "foobar", testRepo.GetRelativePath(), localRepoPath, "", cmd, "")
if err == nil {
t.Fatalf("clone didn't fail")
}
}
func testClone(t *testing.T, serverSocketPath, storageName, relativePath, localRepoPath string, gitConfig string, cmd *exec.Cmd, gitProtocol string) (string, string, string, string, error) {
defer os.RemoveAll(localRepoPath)
pbTempRepo := &gitalypb.Repository{StorageName: storageName, RelativePath: relativePath}
req := &gitalypb.SSHUploadPackRequest{
Repository: pbTempRepo,
GitProtocol: gitProtocol,
}
if gitConfig != "" {
req.GitConfigOptions = strings.Split(gitConfig, " ")
}
pbMarshaler := &jsonpb.Marshaler{}
payload, err := pbMarshaler.MarshalToString(req)
require.NoError(t, err)
cmd.Env = []string{
fmt.Sprintf("GITALY_ADDRESS=unix:%s", serverSocketPath),
fmt.Sprintf("GITALY_PAYLOAD=%s", payload),
fmt.Sprintf("PATH=%s", ".:"+os.Getenv("PATH")),
fmt.Sprintf(`GIT_SSH_COMMAND=%s upload-pack`, gitalySSHPath),
}
out, err := cmd.CombinedOutput()
if err != nil {
return "", "", "", "", fmt.Errorf("%v: %q", err, out)
}
if !cmd.ProcessState.Success() {
return "", "", "", "", fmt.Errorf("Failed to run `git clone`: %q", out)
}
storagePath := testhelper.GitlabTestStoragePath()
testRepoPath := path.Join(storagePath, testRepo.GetRelativePath())
remoteHead := bytes.TrimSpace(testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "rev-parse", "master"))
localHead := bytes.TrimSpace(testhelper.MustRunCommand(t, nil, "git", "-C", localRepoPath, "rev-parse", "master"))
remoteTags := bytes.TrimSpace(testhelper.MustRunCommand(t, nil, "git", "-C", testRepoPath, "tag"))
localTags := bytes.TrimSpace(testhelper.MustRunCommand(t, nil, "git", "-C", localRepoPath, "tag"))
return string(localHead), string(remoteHead), string(localTags), string(remoteTags), nil
}
func drainPostUploadPackResponse(stream gitalypb.SSHService_SSHUploadPackClient) error {
var err error
for err == nil {
_, err = stream.Recv()
}
return err
}
|
