1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
|
package wiki
import (
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly-proto/go/gitalypb"
gitlog "gitlab.com/gitlab-org/gitaly/internal/git/log"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"google.golang.org/grpc/codes"
)
func TestSuccessfulWikiDeletePageRequest(t *testing.T) {
wikiRepo, wikiRepoPath, cleanupFunc := setupWikiRepo(t)
defer cleanupFunc()
ctx, cancel := testhelper.Context()
defer cancel()
server, serverSocketPath := runWikiServiceServer(t)
defer server.Stop()
client, conn := newWikiClient(t, serverSocketPath)
defer conn.Close()
pageName := "A talé of two wikis"
authorID := int32(1)
authorUserName := []byte("ahmad")
authorName := []byte("Ahmad Sherif")
authorEmail := []byte("ahmad@gitlab.com")
message := []byte("Delete " + pageName)
content := []byte("It was the best of wikis, it was the worst of wikis")
testCases := []struct {
desc string
req *gitalypb.WikiDeletePageRequest
}{
{
desc: "with user id and username",
req: &gitalypb.WikiDeletePageRequest{
Repository: wikiRepo,
PagePath: []byte("a-talé-of-two-wikis"),
CommitDetails: &gitalypb.WikiCommitDetails{
Name: authorName,
Email: authorEmail,
Message: message,
UserId: authorID,
UserName: authorUserName,
},
},
},
{
desc: "without user id and username", // deprecate in GitLab 11.0 https://gitlab.com/gitlab-org/gitaly/issues/1154
req: &gitalypb.WikiDeletePageRequest{
Repository: wikiRepo,
PagePath: []byte("a-talé-of-two-wikis"),
CommitDetails: &gitalypb.WikiCommitDetails{
Name: authorName,
Email: authorEmail,
Message: message,
},
},
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
writeWikiPage(t, client, wikiRepo, createWikiPageOpts{title: pageName, content: content})
_, err := client.WikiDeletePage(ctx, tc.req)
require.NoError(t, err)
headID := testhelper.MustRunCommand(t, nil, "git", "-C", wikiRepoPath, "show", "--format=format:%H", "--no-patch", "HEAD")
commit, err := gitlog.GetCommit(ctx, wikiRepo, string(headID))
require.NoError(t, err, "look up git commit after deleting a wiki page")
require.Equal(t, authorName, commit.Author.Name, "author name mismatched")
require.Equal(t, authorEmail, commit.Author.Email, "author email mismatched")
require.Equal(t, message, commit.Subject, "message mismatched")
})
}
}
func TestFailedWikiDeletePageDueToValidations(t *testing.T) {
wikiRepo, _, cleanupFunc := setupWikiRepo(t)
defer cleanupFunc()
server, serverSocketPath := runWikiServiceServer(t)
defer server.Stop()
client, conn := newWikiClient(t, serverSocketPath)
defer conn.Close()
commitDetails := &gitalypb.WikiCommitDetails{
Name: []byte("Ahmad Sherif"),
Email: []byte("ahmad@gitlab.com"),
Message: []byte("Delete a wiki page"),
UserId: int32(1),
UserName: []byte("ahmad"),
}
testCases := []struct {
desc string
request *gitalypb.WikiDeletePageRequest
code codes.Code
}{
{
desc: "non existent page path",
request: &gitalypb.WikiDeletePageRequest{
Repository: wikiRepo,
PagePath: []byte("does-not-exist"),
CommitDetails: commitDetails,
},
code: codes.Unknown,
},
{
desc: "empty page path",
request: &gitalypb.WikiDeletePageRequest{
Repository: wikiRepo,
CommitDetails: commitDetails,
},
code: codes.InvalidArgument,
},
{
desc: "empty commit details",
request: &gitalypb.WikiDeletePageRequest{
Repository: wikiRepo,
PagePath: []byte("does-not-matter"),
},
code: codes.InvalidArgument,
},
{
desc: "empty commit details' name",
request: &gitalypb.WikiDeletePageRequest{
Repository: wikiRepo,
PagePath: []byte("does-not-matter"),
CommitDetails: &gitalypb.WikiCommitDetails{
Email: []byte("a@b.com"),
Message: []byte("A message"),
UserId: int32(1),
UserName: []byte("username"),
},
},
code: codes.InvalidArgument,
},
{
desc: "empty commit details' email",
request: &gitalypb.WikiDeletePageRequest{
Repository: wikiRepo,
PagePath: []byte("does-not-matter"),
CommitDetails: &gitalypb.WikiCommitDetails{
Name: []byte("A name"),
Message: []byte("A message"),
UserId: int32(1),
UserName: []byte("username"),
},
},
code: codes.InvalidArgument,
},
{
desc: "empty commit details' message",
request: &gitalypb.WikiDeletePageRequest{
Repository: wikiRepo,
PagePath: []byte("does-not-matter"),
CommitDetails: &gitalypb.WikiCommitDetails{
Name: []byte("A name"),
Email: []byte("a@b.com"),
UserId: int32(1),
UserName: []byte("username"),
},
},
code: codes.InvalidArgument,
},
}
for _, testCase := range testCases {
t.Run(testCase.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
_, err := client.WikiDeletePage(ctx, testCase.request)
testhelper.RequireGrpcError(t, err, testCase.code)
})
}
}
|
