1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
|
package wiki
import (
"bytes"
"testing"
"github.com/stretchr/testify/require"
gitlog "gitlab.com/gitlab-org/gitaly/internal/git/log"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
"google.golang.org/grpc/codes"
)
func TestSuccessfulWikiUpdatePageRequest(t *testing.T) {
wikiRepo, wikiRepoPath, cleanupFunc := setupWikiRepo(t)
defer cleanupFunc()
ctx, cancel := testhelper.Context()
defer cancel()
server, serverSocketPath := runWikiServiceServer(t)
defer server.Stop()
client, conn := newWikiClient(t, serverSocketPath)
defer conn.Close()
writeWikiPage(t, client, wikiRepo, createWikiPageOpts{title: "Instálling Gitaly", content: []byte("foobar")})
authorID := int32(1)
authorUserName := []byte("ahmad")
authorName := []byte("Ahmad Sherif")
authorEmail := []byte("ahmad@gitlab.com")
message := []byte("Add installation instructions")
testCases := []struct {
desc string
req *gitalypb.WikiUpdatePageRequest
content []byte
}{
{
desc: "with user id and username",
req: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
PagePath: []byte("//Instálling Gitaly"),
Title: []byte("Instálling Gitaly"),
Format: "markdown",
CommitDetails: &gitalypb.WikiCommitDetails{
Name: authorName,
Email: authorEmail,
Message: message,
UserId: authorID,
UserName: authorUserName,
},
},
content: bytes.Repeat([]byte("Mock wiki page content"), 10000),
},
{
desc: "without user id and username", // deprecate in gitlab 11.0 https://gitlab.com/gitlab-org/gitaly/issues/1154
req: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
PagePath: []byte("//Instálling Gitaly"),
Title: []byte("Instálling Gitaly"),
Format: "markdown",
CommitDetails: &gitalypb.WikiCommitDetails{
Name: authorName,
Email: authorEmail,
Message: message,
},
},
content: bytes.Repeat([]byte("Mock wiki page content 2"), 10000),
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
stream, err := client.WikiUpdatePage(ctx)
require.NoError(t, err)
request := tc.req
nSends, err := sendBytes(tc.content, 1000, func(p []byte) error {
request.Content = p
if err := stream.Send(request); err != nil {
return err
}
// Use a new response so we don't send other fields (Repository, ...) over and over
request = &gitalypb.WikiUpdatePageRequest{}
return nil
})
require.NoError(t, err)
require.True(t, nSends > 1, "should have sent more than one message")
_, err = stream.CloseAndRecv()
require.NoError(t, err)
headID := testhelper.MustRunCommand(t, nil, "git", "-C", wikiRepoPath, "show", "--format=format:%H", "--no-patch", "HEAD")
commit, err := gitlog.GetCommit(ctx, wikiRepo, string(headID))
require.NoError(t, err, "look up git commit before merge is applied")
require.Equal(t, authorName, commit.Author.Name, "author name mismatched")
require.Equal(t, authorEmail, commit.Author.Email, "author email mismatched")
require.Equal(t, message, commit.Subject, "message mismatched")
pageContent := testhelper.MustRunCommand(t, nil, "git", "-C", wikiRepoPath, "cat-file", "blob", "HEAD:Instálling-Gitaly.md")
require.Equal(t, tc.content, pageContent, "mismatched content")
})
}
}
func TestFailedWikiUpdatePageDueToValidations(t *testing.T) {
wikiRepo, _, cleanupFunc := setupWikiRepo(t)
defer cleanupFunc()
server, serverSocketPath := runWikiServiceServer(t)
defer server.Stop()
client, conn := newWikiClient(t, serverSocketPath)
defer conn.Close()
writeWikiPage(t, client, wikiRepo, createWikiPageOpts{title: "Installing Gitaly", content: []byte("foobar")})
commitDetails := &gitalypb.WikiCommitDetails{
Name: []byte("Ahmad Sherif"),
Email: []byte("ahmad@gitlab.com"),
Message: []byte("Add installation instructions"),
UserId: int32(1),
UserName: []byte("ahmad"),
}
testCases := []struct {
desc string
request *gitalypb.WikiUpdatePageRequest
code codes.Code
}{
{
desc: "empty page_path",
request: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
Title: []byte("Installing Gitaly"),
Format: "markdown",
CommitDetails: commitDetails,
Content: []byte(""),
},
code: codes.InvalidArgument,
},
{
desc: "page does not exist",
request: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
PagePath: []byte("//Installing Gibaly"),
Title: []byte("Installing Gitaly"),
Format: "markdown",
CommitDetails: commitDetails,
Content: []byte(""),
},
code: codes.NotFound,
},
{
desc: "empty title",
request: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
PagePath: []byte("//Installing Gitaly"),
Format: "markdown",
CommitDetails: commitDetails,
Content: []byte(""),
},
code: codes.InvalidArgument,
},
{
desc: "empty format",
request: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
PagePath: []byte("//Installing Gitaly.md"),
Title: []byte("Installing Gitaly"),
CommitDetails: commitDetails,
Content: []byte(""),
},
code: codes.InvalidArgument,
},
{
desc: "empty commit details",
request: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
PagePath: []byte("//Installing Gitaly.md"),
Title: []byte("Installing Gitaly"),
Format: "markdown",
Content: []byte(""),
},
code: codes.InvalidArgument,
},
{
desc: "empty commit details' name",
request: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
PagePath: []byte("//Installing Gitaly.md"),
Title: []byte("Installing Gitaly"),
Format: "markdown",
CommitDetails: &gitalypb.WikiCommitDetails{
Email: []byte("a@b.com"),
Message: []byte("A message"),
UserId: int32(1),
UserName: []byte("username"),
},
Content: []byte(""),
},
code: codes.InvalidArgument,
},
{
desc: "empty commit details' email",
request: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
PagePath: []byte("//Installing Gitaly.md"),
Title: []byte("Installing Gitaly"),
Format: "markdown",
CommitDetails: &gitalypb.WikiCommitDetails{
Name: []byte("A name"),
Message: []byte("A message"),
UserId: int32(1),
UserName: []byte("username"),
},
Content: []byte(""),
},
code: codes.InvalidArgument,
},
{
desc: "empty commit details' message",
request: &gitalypb.WikiUpdatePageRequest{
Repository: wikiRepo,
PagePath: []byte("//Installing Gitaly.md"),
Title: []byte("Installing Gitaly"),
Format: "markdown",
CommitDetails: &gitalypb.WikiCommitDetails{
Name: []byte("A name"),
Email: []byte("a@b.com"),
UserId: int32(1),
UserName: []byte("username"),
},
Content: []byte(""),
},
code: codes.InvalidArgument,
},
}
for _, testCase := range testCases {
t.Run(testCase.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
stream, err := client.WikiUpdatePage(ctx)
require.NoError(t, err)
require.NoError(t, stream.Send(testCase.request))
_, err = stream.CloseAndRecv()
testhelper.RequireGrpcError(t, err, testCase.code)
})
}
}
|
