1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
package tempdir
import (
"io/ioutil"
"os"
"path/filepath"
"testing"
"time"
"github.com/sirupsen/logrus"
"github.com/sirupsen/logrus/hooks/test"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
)
func TestNewAsRepositorySuccess(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
cfg, repo, _ := testcfg.BuildWithRepo(t)
locator := config.NewLocator(cfg)
tempRepo, tempDir, err := NewAsRepository(ctx, repo, locator)
require.NoError(t, err)
require.NotEqual(t, repo, tempRepo)
require.Equal(t, repo.StorageName, tempRepo.StorageName)
require.NotEqual(t, repo.RelativePath, tempRepo.RelativePath)
calculatedPath, err := locator.GetPath(tempRepo)
require.NoError(t, err)
require.Equal(t, tempDir, calculatedPath)
err = ioutil.WriteFile(filepath.Join(tempDir, "test"), []byte("hello"), 0644)
require.NoError(t, err, "write file in tempdir")
cancel() // This should trigger async removal of the temporary directory
// Poll because the directory removal is async
for i := 0; i < 100; i++ {
_, err = os.Stat(tempDir)
if err != nil {
break
}
time.Sleep(10 * time.Millisecond)
}
require.True(t, os.IsNotExist(err), "expected directory to have been removed, got error %v", err)
}
func TestNewAsRepositoryFailStorageUnknown(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
_, err := New(ctx, &gitalypb.Repository{StorageName: "does-not-exist", RelativePath: "foobar.git"}, config.NewLocator(config.Cfg{}))
require.Error(t, err)
}
func TestCleanerSafety(t *testing.T) {
defer func() {
if p := recover(); p != nil {
if _, ok := p.(invalidCleanRoot); !ok {
t.Fatalf("expected invalidCleanRoot panic, got %v", p)
}
}
}()
//This directory is invalid because it does not end in '+gitaly/tmp'
invalidDir := "testdata/does-not-exist"
require.NoError(t, clean(invalidDir))
t.Fatal("expected panic")
}
func TestCleanSuccess(t *testing.T) {
require.NoError(t, os.MkdirAll(cleanRoot, 0755), "create clean root before setup")
testhelper.MustRunCommand(t, nil, "chmod", "-R", "0700", cleanRoot)
require.NoError(t, os.RemoveAll(cleanRoot), "clean up test clean root")
old := time.Unix(0, 0)
recent := time.Now()
makeDir(t, "a", old)
makeDir(t, "a/b", recent) // Messes up mtime of "a", we fix that below
makeDir(t, "c", recent)
makeDir(t, "f", old)
makeFile(t, "a/b/g", old)
makeFile(t, "c/d", old)
makeFile(t, "e", recent)
// This is really evil and even breaks 'rm -rf'
require.NoError(t, chmod("a/b", 0), "apply evil permissions to 'a/b'")
require.NoError(t, chmod("a", 0), "apply evil permissions to 'a'")
require.NoError(t, chtimes("a", old), "reset mtime of 'a'")
assertEntries(t, "a", "c", "e", "f")
require.NoError(t, clean(cleanRoot), "walk first pass")
assertEntries(t, "c", "e")
}
func TestCleanTempDir(t *testing.T) {
cfg := testcfg.Build(t, testcfg.WithStorages("first", "second"))
gittest.CloneRepoAtStorage(t, cfg.Storages[0], t.Name())
logrus.SetLevel(logrus.InfoLevel)
logrus.SetOutput(ioutil.Discard)
hook := test.NewGlobal()
cleanTempDir(cfg.Storages)
require.Equal(t, 2, len(hook.Entries), hook.Entries)
require.Equal(t, "finished tempdir cleaner walk", hook.LastEntry().Message)
}
func chmod(p string, mode os.FileMode) error {
return os.Chmod(filepath.Join(cleanRoot, p), mode)
}
func chtimes(p string, t time.Time) error {
return os.Chtimes(filepath.Join(cleanRoot, p), t, t)
}
func assertEntries(t *testing.T, entries ...string) {
foundEntries, err := ioutil.ReadDir(cleanRoot)
require.NoError(t, err)
require.Len(t, foundEntries, len(entries))
for i, name := range entries {
require.Equal(t, name, foundEntries[i].Name())
}
}
func makeFile(t *testing.T, filePath string, mtime time.Time) {
fullPath := filepath.Join(cleanRoot, filePath)
require.NoError(t, ioutil.WriteFile(fullPath, nil, 0644))
require.NoError(t, os.Chtimes(fullPath, mtime, mtime))
}
func makeDir(t *testing.T, dirPath string, mtime time.Time) {
fullPath := filepath.Join(cleanRoot, dirPath)
require.NoError(t, os.MkdirAll(fullPath, 0700))
require.NoError(t, os.Chtimes(fullPath, mtime, mtime))
}
func TestCleanNoTmpExists(t *testing.T) {
// This directory is valid because it ends in the special prefix
dir := filepath.Join("testdata", "does-not-exist", tmpRootPrefix)
require.NoError(t, clean(dir))
}
|
