1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
|
package testhelper
import (
"context"
"testing"
"github.com/stretchr/testify/require"
ff "gitlab.com/gitlab-org/gitaly/v14/internal/metadata/featureflag"
"google.golang.org/grpc/metadata"
)
var (
featureFlagA = ff.FeatureFlag{Name: "test_feature_flag_a"}
featureFlagB = ff.FeatureFlag{Name: "test_feature_flag_b"}
)
func TestNewFeatureSetsWithRubyFlags(t *testing.T) {
testcases := []struct {
desc string
features []ff.FeatureFlag
rubyFeatures []ff.FeatureFlag
expected FeatureSets
}{
{
desc: "single Go feature flag",
features: []ff.FeatureFlag{featureFlagA},
expected: FeatureSets{
FeatureSet{
features: map[ff.FeatureFlag]bool{featureFlagA: false},
rubyFeatures: map[ff.FeatureFlag]bool{},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{featureFlagA: true},
rubyFeatures: map[ff.FeatureFlag]bool{},
},
},
},
{
desc: "two Go feature flags",
features: []ff.FeatureFlag{featureFlagA, featureFlagB},
expected: FeatureSets{
FeatureSet{
features: map[ff.FeatureFlag]bool{
featureFlagA: false,
featureFlagB: false,
},
rubyFeatures: map[ff.FeatureFlag]bool{},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{
featureFlagA: true,
featureFlagB: false,
},
rubyFeatures: map[ff.FeatureFlag]bool{},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{
featureFlagA: false,
featureFlagB: true,
},
rubyFeatures: map[ff.FeatureFlag]bool{},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{
featureFlagA: true,
featureFlagB: true,
},
rubyFeatures: map[ff.FeatureFlag]bool{},
},
},
},
{
desc: "single Ruby feature flag",
rubyFeatures: []ff.FeatureFlag{featureFlagA},
expected: FeatureSets{
FeatureSet{
features: map[ff.FeatureFlag]bool{},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: false,
},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: true,
},
},
},
},
{
desc: "two Ruby feature flags",
rubyFeatures: []ff.FeatureFlag{featureFlagA, featureFlagB},
expected: FeatureSets{
FeatureSet{
features: map[ff.FeatureFlag]bool{},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: false,
featureFlagB: false,
},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: true,
featureFlagB: false,
},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: false,
featureFlagB: true,
},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: true,
featureFlagB: true,
},
},
},
},
{
desc: "Go and Ruby feature flag",
features: []ff.FeatureFlag{featureFlagB},
rubyFeatures: []ff.FeatureFlag{featureFlagA},
expected: FeatureSets{
FeatureSet{
features: map[ff.FeatureFlag]bool{
featureFlagB: false,
},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: false,
},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{
featureFlagB: true,
},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: false,
},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{
featureFlagB: false,
},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: true,
},
},
FeatureSet{
features: map[ff.FeatureFlag]bool{
featureFlagB: true,
},
rubyFeatures: map[ff.FeatureFlag]bool{
featureFlagA: true,
},
},
},
},
}
for _, tc := range testcases {
t.Run(tc.desc, func(t *testing.T) {
featureSets := NewFeatureSetsWithRubyFlags(tc.features, tc.rubyFeatures)
require.Equal(t, tc.expected, featureSets)
})
}
}
func TestFeatureSets_Run(t *testing.T) {
// This test depends on feature flags being default-enabled in the test
// context, which requires those flags to exist in the ff.All slice. So
// let's just append them here so we do not need to use a "real"
// feature flag, as that would require constant change when we remove
// old feature flags.
defer func(old []ff.FeatureFlag) {
ff.All = old
}(ff.All)
ff.All = append(ff.All, featureFlagA, featureFlagB)
var featureFlags [][2]bool
NewFeatureSets(featureFlagB, featureFlagA).Run(t, func(t *testing.T, ctx context.Context) {
incomingMD, ok := metadata.FromIncomingContext(ctx)
require.True(t, ok)
outgoingMD, ok := metadata.FromOutgoingContext(ctx)
require.True(t, ok)
require.Equal(t, incomingMD, outgoingMD)
featureFlags = append(featureFlags, [2]bool{
featureFlagA.IsEnabled(ctx), featureFlagB.IsEnabled(ctx),
})
})
require.Equal(t, [][2]bool{
{false, false},
{false, true},
{true, false},
{true, true},
}, featureFlags)
}
|
