1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
|
package unarycache
import (
"context"
"errors"
"fmt"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testcfg"
)
func TestCache_GetOrCompute(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg := testcfg.Build(t)
repoProto, _ := gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
SkipCreationViaService: true,
})
repo := localrepo.NewTestRepo(t, cfg, repoProto)
t.Run("returns identical value", func(t *testing.T) {
generator := func(ctx context.Context, repo *localrepo.Repo, key string) (string, error) {
return "hello", nil
}
cacher, err := New(5, generator)
require.NoError(t, err)
actual, err := cacher.GetOrCompute(ctx, repo, "foo")
require.NoError(t, err)
require.Equal(t, "hello", actual)
})
t.Run("returns identical error when generator fails", func(t *testing.T) {
generator := func(ctx context.Context, repo *localrepo.Repo, key string) (string, error) {
return "", errors.New("broken")
}
cacher, err := New(5, generator)
require.NoError(t, err)
_, err = cacher.GetOrCompute(ctx, repo, "foo")
require.EqualError(t, err, "broken")
})
t.Run("returns cached response", func(t *testing.T) {
first := true
generator := func(ctx context.Context, repo *localrepo.Repo, key string) (string, error) {
if first {
first = false
return "hello", nil
}
return "", errors.New("broken")
}
cacher, err := New(5, generator)
require.NoError(t, err)
// Populate cache
actual, err := cacher.GetOrCompute(ctx, repo, "foo")
require.NoError(t, err)
require.Equal(t, "hello", actual)
// Sanity check on generator
_, err = generator(ctx, repo, "foo")
require.EqualError(t, err, "broken")
// Fetch from cache
actual, err = cacher.GetOrCompute(ctx, repo, "foo")
require.NoError(t, err)
require.Equal(t, "hello", actual)
})
t.Run("different values for different keys", func(t *testing.T) {
count := 0
generator := func(ctx context.Context, repo *localrepo.Repo, key string) (string, error) {
count++
return fmt.Sprintf("You're number %d", count), nil
}
cacher, err := New(5, generator)
require.NoError(t, err)
actual, err := cacher.GetOrCompute(ctx, repo, "foo")
require.NoError(t, err)
require.Equal(t, "You're number 1", actual)
actual, err = cacher.GetOrCompute(ctx, repo, "bar")
require.NoError(t, err)
require.Equal(t, "You're number 2", actual)
actual, err = cacher.GetOrCompute(ctx, repo, "foo")
require.NoError(t, err)
require.Equal(t, "You're number 1", actual)
})
t.Run("only keeps given max entries", func(t *testing.T) {
count := 0
generator := func(ctx context.Context, repo *localrepo.Repo, key string) (string, error) {
count++
return fmt.Sprintf("You're number %d", count), nil
}
cacher, err := New(5, generator)
require.NoError(t, err)
actual, err := cacher.GetOrCompute(ctx, repo, "foo")
require.NoError(t, err)
require.Equal(t, "You're number 1", actual)
for i, key := range []string{"a", "b", "c", "d", "e"} {
actual, err = cacher.GetOrCompute(ctx, repo, key)
require.NoError(t, err)
require.Equal(t, fmt.Sprintf("You're number %d", i+2), actual)
}
actual, err = cacher.GetOrCompute(ctx, repo, "foo")
require.NoError(t, err)
require.Equal(t, "You're number 7", actual)
})
t.Run("same cache key on different repos", func(t *testing.T) {
otherProto, _ := gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
SkipCreationViaService: true,
})
otherRepo := localrepo.NewTestRepo(t, cfg, otherProto)
count := 0
generator := func(ctx context.Context, repo *localrepo.Repo, key string) (string, error) {
count++
return fmt.Sprintf("You're number %d", count), nil
}
cacher, err := New(5, generator)
require.NoError(t, err)
actual, err := cacher.GetOrCompute(ctx, repo, "foo")
require.NoError(t, err)
require.Equal(t, "You're number 1", actual)
actual, err = cacher.GetOrCompute(ctx, otherRepo, "foo")
require.NoError(t, err)
require.Equal(t, "You're number 2", actual)
actual, err = cacher.GetOrCompute(ctx, repo, "foo")
require.NoError(t, err)
require.Equal(t, "You're number 1", actual)
})
}
|
