diff options
author | Evan Read <eread@gitlab.com> | 2023-01-23 08:12:46 +0300 |
---|---|---|
committer | Evan Read <eread@gitlab.com> | 2023-01-23 08:12:46 +0300 |
commit | b9a35adb8887465cfcfea4b965d1164409ed686c (patch) | |
tree | e575938699b3fc3edf3a5982633399488b976fab | |
parent | ebb3f300355e224eafafe90916dd83851ade92f6 (diff) |
Make RSpec test adhere to RuboCop rules
-rw-r--r-- | spec/lib/helpers/versions_spec.rb | 64 |
1 files changed, 31 insertions, 33 deletions
diff --git a/spec/lib/helpers/versions_spec.rb b/spec/lib/helpers/versions_spec.rb index 76f31ab6..2c7e61cb 100644 --- a/spec/lib/helpers/versions_spec.rb +++ b/spec/lib/helpers/versions_spec.rb @@ -5,37 +5,35 @@ require 'nanoc' require 'helpers/versions' RSpec.describe Nanoc::Helpers::VersionsDropdown do - let(:mock_class) { Class.new { extend Nanoc::Helpers::VersionsDropdown } } - subject { mock_class.latest? } - - describe '#latest?' do - - before(:each) do - versions_mock = {:next=>"15.8",:current=>"15.7",:last_minor=>["15.6", "15.5"],:last_major=>["14.10", "13.12"]} - allow(mock_class).to receive(:get_current_stable_version).and_return(versions_mock[:current]) - stub_const('ENV', ENV.to_hash.merge('CI_DEFAULT_BRANCH' => 'main')) - end - - it 'returns correct value for pre-release version' do - stub_const('ENV', ENV.to_hash.merge('CI_COMMIT_REF_NAME' => 'main')) - expect(subject).to eq(true) - end - - it 'returns correct value for current stable version' do - stub_const('ENV', ENV.to_hash.merge('CI_COMMIT_REF_NAME' => '15.7')) - expect(subject).to eq(true) - end - - it 'returns correct value for last minor version' do - stub_const('ENV', ENV.to_hash.merge('CI_COMMIT_REF_NAME' => '15.6')) - expect(subject).to eq(false) - end - - it 'returns correct value for last major' do - stub_const('ENV', ENV.to_hash.merge('CI_COMMIT_REF_NAME' => '14.10')) - expect(subject).to eq(false) - end - - end - + let(:mock_class) { Class.new { extend Nanoc::Helpers::VersionsDropdown } } + + subject { mock_class.latest? } + + describe '#latest?' do + before do + versions_mock = { next: "15.8", current: "15.7", last_minor: ["15.6", "15.5"], last_major: ["14.10", "13.12"] } + allow(mock_class).to receive(:get_current_stable_version).and_return(versions_mock[:current]) + stub_const('ENV', ENV.to_hash.merge('CI_DEFAULT_BRANCH' => 'main')) + end + + it 'returns correct value for pre-release version' do + stub_const('ENV', ENV.to_hash.merge('CI_COMMIT_REF_NAME' => 'main')) + expect(subject).to be(true) + end + + it 'returns correct value for current stable version' do + stub_const('ENV', ENV.to_hash.merge('CI_COMMIT_REF_NAME' => '15.7')) + expect(subject).to be(true) + end + + it 'returns correct value for last minor version' do + stub_const('ENV', ENV.to_hash.merge('CI_COMMIT_REF_NAME' => '15.6')) + expect(subject).to be(false) + end + + it 'returns correct value for last major' do + stub_const('ENV', ENV.to_hash.merge('CI_COMMIT_REF_NAME' => '14.10')) + expect(subject).to be(false) + end + end end |