diff options
author | David O'Regan <doregan@gitlab.com> | 2022-04-12 19:25:30 +0300 |
---|---|---|
committer | David O'Regan <doregan@gitlab.com> | 2022-04-12 19:25:30 +0300 |
commit | 5fc9e9b42354b30864f5924512767ba33ab8ee19 (patch) | |
tree | a531b5e789231d10cd6a6b01786ddd97c455fc3f | |
parent | 66a70edb32ee27db0d0a20e5fe09a9ef5d1be6be (diff) | |
parent | aead1a951198c7e5874edda892ffc1190397357c (diff) |
Merge branch 'eread/rename-banner-compontent' into 'main'
For eslint, avoid single word component names
See merge request gitlab-org/gitlab-docs!2564
-rw-r--r-- | content/frontend/default/components/version_banner.vue | 8 | ||||
-rw-r--r-- | content/frontend/shared/components/docs_banner.vue (renamed from content/frontend/shared/components/banner.vue) | 0 | ||||
-rw-r--r-- | spec/frontend/shared/components/docs_banner_spec.js (renamed from spec/frontend/shared/components/banner_spec.js) | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/content/frontend/default/components/version_banner.vue b/content/frontend/default/components/version_banner.vue index 540e547d..22004a95 100644 --- a/content/frontend/default/components/version_banner.vue +++ b/content/frontend/default/components/version_banner.vue @@ -1,9 +1,9 @@ <script> -import Banner from '../../shared/components/banner.vue'; +import DocsBanner from '../../shared/components/docs_banner.vue'; export default { components: { - Banner, + DocsBanner, }, props: { isOutdated: { @@ -28,8 +28,8 @@ export default { </script> <template> - <banner :show="isOutdated" @toggle="toggleVersionBanner"> + <docs-banner :show="isOutdated" @toggle="toggleVersionBanner"> This is <a :href="archivesUrl">archived documentation</a> for GitLab. Go to <a :href="latestVersionUrl">the latest</a>. - </banner> + </docs-banner> </template> diff --git a/content/frontend/shared/components/banner.vue b/content/frontend/shared/components/docs_banner.vue index 3748bf8e..3748bf8e 100644 --- a/content/frontend/shared/components/banner.vue +++ b/content/frontend/shared/components/docs_banner.vue diff --git a/spec/frontend/shared/components/banner_spec.js b/spec/frontend/shared/components/docs_banner_spec.js index f7a387a5..eb89eb91 100644 --- a/spec/frontend/shared/components/banner_spec.js +++ b/spec/frontend/shared/components/docs_banner_spec.js @@ -3,7 +3,7 @@ */ import { mount } from '@vue/test-utils'; -import Banner from '../../../../content/frontend/shared/components/banner.vue'; +import DocsBanner from '../../../../content/frontend/shared/components/docs_banner.vue'; const propsData = { text: 'Some text', show: true }; @@ -11,7 +11,7 @@ describe('component: Banner', () => { let wrapper; beforeEach(() => { - wrapper = mount(Banner, { propsData }); + wrapper = mount(DocsBanner, { propsData }); }); it('renders a banner', () => { |