diff options
author | Achilleas Pipinellis <axil@gitlab.com> | 2022-05-12 10:08:59 +0300 |
---|---|---|
committer | Achilleas Pipinellis <axil@gitlab.com> | 2022-05-12 10:08:59 +0300 |
commit | c1574ef490adf643954203bc2086d25003956114 (patch) | |
tree | 50d6a4e7855d0282c6270cca59886c734fd7bb38 | |
parent | 192e2c3b8ab682757da9b09a800b753eedeca010 (diff) | |
parent | 520363ae2ff5b1bc4d306150cb2a51daa8d02dfd (diff) |
Merge branch 'eread/avoid-disabling-hadolint-rule-dl3025' into 'main'
Avoid disabling hadolint rule DL3025
See merge request gitlab-org/gitlab-docs!2653
-rw-r--r-- | dockerfiles/archives.Dockerfile | 3 | ||||
-rw-r--r-- | dockerfiles/nginx.onbuild.Dockerfile | 3 | ||||
-rw-r--r-- | latest.Dockerfile | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/dockerfiles/archives.Dockerfile b/dockerfiles/archives.Dockerfile index 961d0cfd..d2e8eeb2 100644 --- a/dockerfiles/archives.Dockerfile +++ b/dockerfiles/archives.Dockerfile @@ -49,5 +49,4 @@ COPY --from=registry.gitlab.com/gitlab-org/gitlab-docs:10.4 ${TARGET} ${TARGET} COPY --from=registry.gitlab.com/gitlab-org/gitlab-docs:10.3 ${TARGET} ${TARGET} # Serve the site (target), which is now all static HTML -# hadolint ignore=DL3025 -CMD echo -e "GitLab docs are viewable at:\nhttp://0.0.0.0:4000"; exec nginx -g 'daemon off;' +CMD ["sh", "-c", "echo 'GitLab docs are viewable at: http://0.0.0.0:4000'; exec nginx -g 'daemon off;'"] diff --git a/dockerfiles/nginx.onbuild.Dockerfile b/dockerfiles/nginx.onbuild.Dockerfile index 585f67c4..d785efff 100644 --- a/dockerfiles/nginx.onbuild.Dockerfile +++ b/dockerfiles/nginx.onbuild.Dockerfile @@ -18,5 +18,4 @@ ONBUILD COPY --from=builder /site /usr/share/nginx/html COPY dockerfiles/nginx-overrides.conf /etc/nginx/conf.d/default.conf # Start Nginx to serve the archive at / (which will redirect to the version-specific dir) -# hadolint ignore=DL3025 -CMD echo -e "GitLab docs are viewable at:\nhttp://0.0.0.0:4000"; exec nginx -g 'daemon off;' +CMD ["sh", "-c", "echo 'GitLab docs are viewable at: http://0.0.0.0:4000'; exec nginx -g 'daemon off;'"] diff --git a/latest.Dockerfile b/latest.Dockerfile index 55195aee..7cf809d7 100644 --- a/latest.Dockerfile +++ b/latest.Dockerfile @@ -62,5 +62,4 @@ COPY --from=builder /source/public ${TARGET} COPY --from=builder /scripts/minify* /scripts/ # Serve the site (target), which is now all static HTML -# hadolint ignore=DL3025 -CMD echo -e "GitLab docs are viewable at:\nhttp://0.0.0.0:4000"; exec nginx -g 'daemon off;' +CMD ["sh", "-c", "echo 'GitLab docs are viewable at: http://0.0.0.0:4000'; exec nginx -g 'daemon off;'"] |