diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-02-20 16:49:51 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-02-20 16:49:51 +0300 |
commit | 71786ddc8e28fbd3cb3fcc4b3ff15e5962a1c82e (patch) | |
tree | 6a2d93ef3fb2d353bb7739e4b57e6541f51cdd71 /.gitlab/issue_templates | |
parent | a7253423e3403b8c08f8a161e5937e1488f5f407 (diff) |
Add latest changes from gitlab-org/gitlab@15-9-stable-eev15.9.0-rc42
Diffstat (limited to '.gitlab/issue_templates')
13 files changed, 106 insertions, 4 deletions
diff --git a/.gitlab/issue_templates/Experiment Successful Cleanup.md b/.gitlab/issue_templates/Experiment Successful Cleanup.md index 14a29452e49..3831090aad6 100644 --- a/.gitlab/issue_templates/Experiment Successful Cleanup.md +++ b/.gitlab/issue_templates/Experiment Successful Cleanup.md @@ -10,6 +10,8 @@ The changes need to become an official part of the product. - [ ] Determine whether the feature should apply to SaaS and/or self-managed - [ ] Determine whether the feature should apply to EE - and which tiers - and/or Core - [ ] Determine if tracking should be kept as is, removed, or modified. +- [ ] Determine if any UX experiences need to be "polished" i.e. updated to further improve the end user experience. This task should be completed by the designated UX counterpart. + - [ ] (placeholder for UX polish work that needs to be completed for this cleanup issue to be considered completed) - [ ] Ensure any relevant documentation has been updated. - [ ] Determine whether there are other concerns that need to be considered before removing the feature flag. - These are typically captured in the `Experiment Successful Cleanup Concerns` section of the rollout issue. diff --git a/.gitlab/issue_templates/Feature Flag Roll Out.md b/.gitlab/issue_templates/Feature Flag Roll Out.md index 8aa631dce76..5791eca11ff 100644 --- a/.gitlab/issue_templates/Feature Flag Roll Out.md +++ b/.gitlab/issue_templates/Feature Flag Roll Out.md @@ -107,6 +107,7 @@ For visibility, all `/chatops` commands that target production should be execute - [ ] Leave a comment on [the feature issue][main-issue] announcing estimated time when this feature flag will be enabled on GitLab.com. - [ ] Ensure that any breaking changes have been announced following the [release post process](https://about.gitlab.com/handbook/marketing/blog/release-posts/#deprecations-removals-and-breaking-changes) to ensure GitLab customers are aware. - [ ] Notify `#support_gitlab-com` and your team channel ([more guidance when this is necessary in the dev docs](https://docs.gitlab.com/ee/development/feature_flags/controls.html#communicate-the-change)). +- [ ] Ensure that the feature flag rollout plan is reviewed by another developer familiar with the domain. ### Global rollout on production diff --git a/.gitlab/issue_templates/Feature Proposal - basic.md b/.gitlab/issue_templates/Feature Proposal - basic.md index b447bcfe0ae..e9815d85f9b 100644 --- a/.gitlab/issue_templates/Feature Proposal - basic.md +++ b/.gitlab/issue_templates/Feature Proposal - basic.md @@ -9,6 +9,7 @@ <!-- Label reminders Use the following resources to find the appropriate labels: +- Use only one tier label choosing the lowest tier this is intended for - https://gitlab.com/gitlab-org/gitlab/-/labels - https://about.gitlab.com/handbook/product/categories/features/ --> diff --git a/.gitlab/issue_templates/Feature Proposal - lean.md b/.gitlab/issue_templates/Feature Proposal - lean.md index c902c254618..3997ffa5c85 100644 --- a/.gitlab/issue_templates/Feature Proposal - lean.md +++ b/.gitlab/issue_templates/Feature Proposal - lean.md @@ -48,6 +48,7 @@ Create tracking issue using the Snowplow event tracking template. See https://gi <!-- Label reminders Use the following resources to find the appropriate labels: +- Use only one tier label choosing the lowest tier this is intended for - https://gitlab.com/gitlab-org/gitlab/-/labels - https://about.gitlab.com/handbook/product/categories/features/ --> diff --git a/.gitlab/issue_templates/Feature proposal - detailed.md b/.gitlab/issue_templates/Feature proposal - detailed.md index 9eac2ca27c5..dcf6d417155 100644 --- a/.gitlab/issue_templates/Feature proposal - detailed.md +++ b/.gitlab/issue_templates/Feature proposal - detailed.md @@ -125,6 +125,7 @@ In which enterprise tier should this feature go? See https://about.gitlab.com/ha <!-- Label reminders - you should have one of each of the following labels. Use the following resources to find the appropriate labels: +- Use only one tier label choosing the lowest tier this is intended for - https://gitlab.com/gitlab-org/gitlab/-/labels - https://about.gitlab.com/handbook/product/categories/features/ --> diff --git a/.gitlab/issue_templates/Geo Replicate a new Git repository type.md b/.gitlab/issue_templates/Geo Replicate a new Git repository type.md index 97f756f0d02..eee989ed21e 100644 --- a/.gitlab/issue_templates/Geo Replicate a new Git repository type.md +++ b/.gitlab/issue_templates/Geo Replicate a new Git repository type.md @@ -517,7 +517,6 @@ That's all of the required database changes. module Geo class CoolWidgetState < ApplicationRecord - include EachBatch include ::Geo::VerificationStateDefinition self.primary_key = :cool_widget_id diff --git a/.gitlab/issue_templates/Geo Replicate a new blob type.md b/.gitlab/issue_templates/Geo Replicate a new blob type.md index 9dfc83309cc..88a7fad4975 100644 --- a/.gitlab/issue_templates/Geo Replicate a new blob type.md +++ b/.gitlab/issue_templates/Geo Replicate a new blob type.md @@ -482,7 +482,6 @@ That's all of the required database changes. module Geo class CoolWidgetState < ApplicationRecord - include EachBatch include ::Geo::VerificationStateDefinition self.primary_key = :cool_widget_id diff --git a/.gitlab/issue_templates/Pipeline Authoring Issue Implementation.md b/.gitlab/issue_templates/Pipeline Authoring Issue Implementation.md index 523a50dfdf8..7bb602feed2 100644 --- a/.gitlab/issue_templates/Pipeline Authoring Issue Implementation.md +++ b/.gitlab/issue_templates/Pipeline Authoring Issue Implementation.md @@ -50,4 +50,4 @@ _NOTE: This section is optional, but can be used for easy access to any relevant -/label ~"group::pipeline authoring" ~"Category:Pipeline Authoring" ~"section::ops" ~"devops::verify" ~"workflow::planning breakdown" +/label ~"group::pipeline authoring" ~"Category:Pipeline Composition" ~"section::ops" ~"devops::verify" ~"workflow::planning breakdown" diff --git a/.gitlab/issue_templates/Release group - bug.md b/.gitlab/issue_templates/Release group - bug.md new file mode 100644 index 00000000000..f542041593f --- /dev/null +++ b/.gitlab/issue_templates/Release group - bug.md @@ -0,0 +1,43 @@ +## Summary + +<!-- Summarize the bug encountered concisely. --> + +## Steps to reproduce + +<!-- Describe how one can reproduce the issue - this is very important. Please use an ordered list. --> + +## What is the current *bug* behavior? + +<!-- Describe what actually happens. --> + +## What is the expected *correct* behavior? + +<!-- Describe what you should see instead. --> + +## Relevant logs and/or screenshots + +<!-- Paste any relevant logs - please use code blocks (```) to format console output, logs, and code + as it's tough to read otherwise. --> + +## Possible fixes + +<!-- If you can, link to the line of code that might be responsible for the problem. --> + +<!-- Default labels --> +/label ~"group::release" +/label ~"type::bug" +/label ~"workflow::planning breakdown" + +<!-- Optional labels --> +/label ~backend ~frontend ~UX + +<!-- https://about.gitlab.com/handbook/engineering/quality/issue-triage/#severity --> +/label ~"severity::3" ~"priority::3" + +<!-- If you already have an implementation plan, please fill in detail below https://about.gitlab.com/handbook/engineering/development/ops/release/planning/#weights --> +/weight X +/label ~"backend-weight::" ~"frontend-weight::" ~"workflow::ready for development" +## Implementation guide + +<!-- If the issue clear enough, consider inviting community contributors --> +/label ~"Seeking community contributions" ~"good for new contributors" diff --git a/.gitlab/issue_templates/Release group - feature.md b/.gitlab/issue_templates/Release group - feature.md new file mode 100644 index 00000000000..0a695dac2ad --- /dev/null +++ b/.gitlab/issue_templates/Release group - feature.md @@ -0,0 +1,26 @@ +## Problem to solve + +<!-- What problem do we solve? Try to define the who/what/why of the opportunity as a user story. For example, "As a (who), I want (what), so I can (why/value)." --> + +## Proposal + +<!-- Use this section to explain the feature and how it will work. It can be helpful to add technical details, design proposals, and links to related epics or issues. --> + +<!-- Default labels --> +/label ~"group::release" +/label ~"type::feature" +/label ~"workflow::problem validation" +/label ~UX + +<!-- Optional labels --> +/label ~backend ~frontend + +<!-- If you already have an implementation plan, please fill in detail below https://about.gitlab.com/handbook/engineering/development/ops/release/planning/#weights --> +/weight X +/label ~"backend-weight::" ~"frontend-weight::" ~"workflow::ready for development" +## Implementation guide + +<!-- If the issue clear enough, consider inviting community contributors --> +/label ~"Seeking community contributions" ~"good for new contributors" + + diff --git a/.gitlab/issue_templates/Release group - maintenance.md b/.gitlab/issue_templates/Release group - maintenance.md new file mode 100644 index 00000000000..aa87015a44a --- /dev/null +++ b/.gitlab/issue_templates/Release group - maintenance.md @@ -0,0 +1,18 @@ +## Background + +## Proposal + +<!-- Use this section to explain the feature and how it will work. It can be helpful to add technical details, design proposals, and links to related epics or issues. --> + +<!-- Set labels and other metadata --> +/label ~"group::release" +/label ~"type::maintenance" +/label ~"workflow::planning breakdown" + +<!-- If you already have an implementation plan, please fill in detail below https://about.gitlab.com/handbook/engineering/development/ops/release/planning/#weights --> +/weight X +/label ~"backend-weight::" ~"frontend-weight::" ~"workflow::ready for development" +## Implementation guide + +<!-- If the issue clear enough, consider inviting community contributors --> +/label ~"Seeking community contributions" ~"good for new contributors" diff --git a/.gitlab/issue_templates/Security developer workflow.md b/.gitlab/issue_templates/Security developer workflow.md index 7c6c86f5e78..3857303f2c4 100644 --- a/.gitlab/issue_templates/Security developer workflow.md +++ b/.gitlab/issue_templates/Security developer workflow.md @@ -22,6 +22,7 @@ MUST be linked for the release bot to know that the associated merge requests sh - [ ] Run `scripts/security-harness` in your local repository to prevent accidentally pushing to any remote besides `gitlab.com/gitlab-org/security`. - [ ] Create a new branch prefixing it with `security-`. - [ ] Create a merge request targeting `master` on `gitlab.com/gitlab-org/security` and use the [Security Release merge request template]. +- [ ] If this includes a breaking change, make sure to include a mention of it for the relevant versions in [`doc/update/index.md`](https://gitlab.com/gitlab-org/security/gitlab/-/blob/master/doc/update/index.md#version-specific-upgrading-instructions) After your merge request has been approved according to our [approval guidelines] and by a team member of the AppSec team, you're ready to prepare the backports @@ -46,7 +47,6 @@ After your merge request has been approved according to our [approval guidelines - [ ] Fill in any upgrade notes that users may need to take into account in the [details section](#details) - [ ] Add Yes/No and further details if needed to the migration and settings columns in the [details section](#details) - [ ] Add the nickname of the external user who found the issue (and/or HackerOne profile) to the Thanks row in the [details section](#details) -- [ ] If this includes a breaking change, make sure it is mentioned for the relevant versions in [`doc/update/index.md`](https://gitlab.com/gitlab-org/security/gitlab/-/blob/master/doc/update/index.md#version-specific-upgrading-instructions) ## Summary diff --git a/.gitlab/issue_templates/Synchronous Database Index.md b/.gitlab/issue_templates/Synchronous Database Index.md new file mode 100644 index 00000000000..c61cf7abf0c --- /dev/null +++ b/.gitlab/issue_templates/Synchronous Database Index.md @@ -0,0 +1,11 @@ +<!-- Title suggestion: <async-index-name> synchronous database index(es) addition/removal --> + +## Summary + +This issue is to add a migration(s) to create/destroy the `<async-index-name>` database index(es) synchronously after it has been created/destroyed on GitLab.com. + +The asynchronous index(es) was introduced in <!-- Link to MR that introduced the asynchronous index -->. + +/assign me +/due in 2 weeks +/label ~database ~"type::maintenance" ~"maintenance::scalability" |