diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-12-17 14:59:07 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-12-17 14:59:07 +0300 |
commit | 8b573c94895dc0ac0e1d9d59cf3e8745e8b539ca (patch) | |
tree | 544930fb309b30317ae9797a9683768705d664c4 /.gitlab/issue_templates | |
parent | 4b1de649d0168371549608993deac953eb692019 (diff) |
Add latest changes from gitlab-org/gitlab@13-7-stable-eev13.7.0-rc42
Diffstat (limited to '.gitlab/issue_templates')
-rw-r--r-- | .gitlab/issue_templates/Doc Review.md | 2 | ||||
-rw-r--r-- | .gitlab/issue_templates/Experiment Successful Cleanup.md | 18 | ||||
-rw-r--r-- | .gitlab/issue_templates/Feature Flag Roll Out.md | 7 | ||||
-rw-r--r-- | .gitlab/issue_templates/Feature proposal.md | 7 | ||||
-rw-r--r-- | .gitlab/issue_templates/Implementation.md | 2 | ||||
-rw-r--r-- | .gitlab/issue_templates/Lean Feature Proposal.md | 6 | ||||
-rw-r--r-- | .gitlab/issue_templates/Security Release Tracking Issue.md | 41 | ||||
-rw-r--r-- | .gitlab/issue_templates/Snowplow event tracking.md | 6 | ||||
-rw-r--r-- | .gitlab/issue_templates/actionable_insight.md | 3 |
9 files changed, 40 insertions, 52 deletions
diff --git a/.gitlab/issue_templates/Doc Review.md b/.gitlab/issue_templates/Doc Review.md index bd3843ac5cd..5b470ed7c75 100644 --- a/.gitlab/issue_templates/Doc Review.md +++ b/.gitlab/issue_templates/Doc Review.md @@ -3,7 +3,7 @@ <!-- NOTE: Please add a DevOps stage label (format `devops:<stage_name>`) and assign the technical writer who is - [listed for that stage](https://about.gitlab.com/handbook/product/product-categories/#devops-stages). --> + [listed for that stage](https://about.gitlab.com/handbook/product/categories/#devops-stages). --> ## References diff --git a/.gitlab/issue_templates/Experiment Successful Cleanup.md b/.gitlab/issue_templates/Experiment Successful Cleanup.md new file mode 100644 index 00000000000..3f148ec00b1 --- /dev/null +++ b/.gitlab/issue_templates/Experiment Successful Cleanup.md @@ -0,0 +1,18 @@ +<!-- Title suggestion: [Experiment Name] Successful Cleanup --> + +## Summary + +The experiment is currently rolled out to 100% of users and has been deemed a success. +The changes need to become an official part of the product. + +## Steps + +- [ ] Determine whether the feature should apply to SaaS and/or self-managed +- [ ] Determine whether the feature should apply to EE - and which tiers - and/or Core +- [ ] Determine if tracking should be kept as is, removed, or modified. +- [ ] Migrate experiment to a default enabled [feature flag](https://docs.gitlab.com/ee/development/feature_flags/development.html) for one milestone and add a changelog. Converting to a feature flag can be skipped at the ICs discretion if risk is deemed low with consideration to both SaaS and (if applicable) self managed. +- [ ] Ensure any relevant documentation has been updated. +- [ ] In the next milestone, [remove the feature flag](https://docs.gitlab.com/ee/development/feature_flags/controls.html#cleaning-up). +- [ ] After the flag removal is deployed, [clean up the feature/experiment feature flags](https://docs.gitlab.com/ee/development/feature_flags/controls.html#cleaning-up) by running chatops command in `#production` channel + +/label ~"feature" ~"feature::maintenance" ~"workflow::scheduling" ~"growth experiment" ~"feature flag" diff --git a/.gitlab/issue_templates/Feature Flag Roll Out.md b/.gitlab/issue_templates/Feature Flag Roll Out.md index a0b64b53250..67686b654bd 100644 --- a/.gitlab/issue_templates/Feature Flag Roll Out.md +++ b/.gitlab/issue_templates/Feature Flag Roll Out.md @@ -18,7 +18,8 @@ Remove the `:feature_name` feature flag ... ### What can we monitor to detect problems with this? -<!-- Which dashboards from https://dashboards.gitlab.net are most relevant? --> +<!-- Which dashboards from https://dashboards.gitlab.net are most relevant? Sentry errors reports can alse be useful to review --> + ## Beta groups/projects @@ -30,13 +31,13 @@ If applicable, any groups/projects that are happy to have this feature turned on ## Roll Out Steps +- [ ] Confirm that QA tests pass with the feature flag enabled (if you're unsure how, contact the relevant [stable counterpart in the Quality department](https://about.gitlab.com/handbook/engineering/quality/#individual-contributors)) - [ ] Enable on staging (`/chatops run feature set feature_name true --staging`) - [ ] Test on staging - [ ] Ensure that documentation has been updated - [ ] Enable on GitLab.com for individual groups/projects listed above and verify behaviour (`/chatops run feature set --project=gitlab-org/gitlab feature_name true`) - [ ] Coordinate a time to enable the flag with the SRE oncall and release managers - - In `#production` by pinging `@sre-oncall` - - In `#g_delivery` by pinging `@release-managers` + - In `#production` mention `@sre-oncall` and `@release-managers`. Once an SRE on call and Release Manager on call confirm, you can proceed with the rollout - [ ] Announce on the issue an estimated time this will be enabled on GitLab.com - [ ] Enable on GitLab.com by running chatops command in `#production` (`/chatops run feature set feature_name true`) - [ ] Cross post chatops Slack command to `#support_gitlab-com` ([more guidance when this is necessary in the dev docs](https://docs.gitlab.com/ee/development/feature_flags/controls.html#where-to-run-commands)) and in your team channel diff --git a/.gitlab/issue_templates/Feature proposal.md b/.gitlab/issue_templates/Feature proposal.md index b6f83be9121..5ab46bfa26f 100644 --- a/.gitlab/issue_templates/Feature proposal.md +++ b/.gitlab/issue_templates/Feature proposal.md @@ -96,8 +96,11 @@ In which enterprise tier should this feature go? See https://about.gitlab.com/ha ### Links / references -<!-- Label reminders - you should have one of each of the following labels. -Read the descriptions on https://gitlab.com/gitlab-org/gitlab/-/labels to find the correct ones --> +<!-- Label reminders - you should have one of each of the following labels. +Use the following resources to find the appropriate labels: +- https://gitlab.com/gitlab-org/gitlab/-/labels +- https://about.gitlab.com/handbook/product/categories/features/ +--> /label ~devops:: ~group: ~Category: /label ~feature diff --git a/.gitlab/issue_templates/Implementation.md b/.gitlab/issue_templates/Implementation.md index dc5eb18a25e..888c993766a 100644 --- a/.gitlab/issue_templates/Implementation.md +++ b/.gitlab/issue_templates/Implementation.md @@ -42,7 +42,7 @@ call-out responsibilities for other team members or teams. --> - [ ] ~frontend Step 1 - - [ ] @person Step 1a + - [ ] `@person` Step 1a - [ ] ~frontend Step 2 diff --git a/.gitlab/issue_templates/Lean Feature Proposal.md b/.gitlab/issue_templates/Lean Feature Proposal.md index b1cb98ba5e9..44210a89023 100644 --- a/.gitlab/issue_templates/Lean Feature Proposal.md +++ b/.gitlab/issue_templates/Lean Feature Proposal.md @@ -17,7 +17,11 @@ /label ~"feature" ~"group::" ~"section::" ~"Category::" ~"GitLab Core"/~"GitLab Starter"/~"GitLab Premium"/~"GitLab Ultimate" -<!-- Read the labels descriptions on https://gitlab.com/gitlab-org/gitlab/-/labels to find the appropriate labels. Consider adding related issues and epics to this issue. You can also reference the Feature Proposal Template (https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/issue_templates/Feature%20proposal.md) for additional details to consider adding to this issue. Additionally, as a data oriented organization, when your feature exits planning breakdown, consider adding the `What does success look like, and how can we measure that?` section. +<!--- Use the following resources to find the appropriate labels: +- https://gitlab.com/gitlab-org/gitlab/-/labels +- https://about.gitlab.com/handbook/product/categories/features/ + +Consider adding related issues and epics to this issue. You can also reference the Feature Proposal Template (https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/issue_templates/Feature%20proposal.md) for additional details to consider adding to this issue. Additionally, as a data oriented organization, when your feature exits planning breakdown, consider adding the `What does success look like, and how can we measure that?` section. Other sections to consider adding: diff --git a/.gitlab/issue_templates/Security Release Tracking Issue.md b/.gitlab/issue_templates/Security Release Tracking Issue.md deleted file mode 100644 index fce68d61204..00000000000 --- a/.gitlab/issue_templates/Security Release Tracking Issue.md +++ /dev/null @@ -1,41 +0,0 @@ -<!-- -# Read me first! - -Set the title to: `Security Release: 12.2.X, 12.1.X, and 12.0.X` ---> - -:warning: **Only Release Managers and members of the AppSec team can edit the description of this issue** - -------- - -## Version issues: - -12.2.X, 12.1.X, 12.0.X: {release task link} - -## Issues in GitLab Security - -To include your issue and merge requests in this Security Release, please mark -your security issues as related to this release tracking issue. You can do this -in the "Linked issues" section below this issue description. - -:warning: If your security issues are not marked as related to this release -tracking issue, their merge requests will not be included in the security -release. - -### Branches to target in GitLab Security - -Your Security Implementation Issue should have `4` merge requests associated: - -- [master and 3 backports](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/security/developer.md#backports) -- Backports should target the stable branches for the versions mentioned included in this Security Release - -## Blog post - -Security: {https://gitlab.com/gitlab-org/security/www-gitlab-com/merge_requests/ link}<br/> -GitLab.com: {https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/ link} - -## Email notification -{https://gitlab.com/gitlab-com/marketing/general/issues/ link} - -/label ~security ~"upcoming security release" -/confidential diff --git a/.gitlab/issue_templates/Snowplow event tracking.md b/.gitlab/issue_templates/Snowplow event tracking.md index 47b97f377c2..4a906b61378 100644 --- a/.gitlab/issue_templates/Snowplow event tracking.md +++ b/.gitlab/issue_templates/Snowplow event tracking.md @@ -37,6 +37,10 @@ We generally recommend events be tracked using a [structured event](https://docs * [ ] Create chart(s) to track your event(s) in the relevant dashboard * [ ] Use the [Chart Snowplow Actions](https://app.periscopedata.com/app/gitlab/snippet/Chart-Snowplow-Actions/5546da87ae2c4a3fbc98415c88b3eedd/edit) SQL snippet to quickly visualize usage. See [example](https://app.periscopedata.com/app/gitlab/737489/Health-Group-Dashboard?widget=9797112&udv=0) -<!-- Label reminders - you should have one of each of the following labels if you can figure out the correct ones --> +<!-- Label reminders - you should have one of each of the following labels. +Use the following resources to find the appropriate labels: +- https://gitlab.com/gitlab-org/gitlab/-/labels +- https://about.gitlab.com/handbook/product/categories/features/ +--> /label ~devops:: ~group: ~Category: /label ~"snowplow tracking events" diff --git a/.gitlab/issue_templates/actionable_insight.md b/.gitlab/issue_templates/actionable_insight.md index 68b2b153831..ff6a4f12918 100644 --- a/.gitlab/issue_templates/actionable_insight.md +++ b/.gitlab/issue_templates/actionable_insight.md @@ -31,5 +31,4 @@ Actionable insights always have a follow-up action that needs to take place as a - - /label ~"Actionable Insight" +/label ~"Actionable Insight" |