Add latest changes from gitlab-org/gitlab@master

1 files changed, 67 insertions, 1 deletions

diff --git a/.rubocop.yml b/.rubocop.yml
index 300cfe3d74c..fbcad46a0c7 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -335,10 +335,76 @@ RSpec/AnyInstanceOf:
 RSpec/ImplicitSubject:
   Enabled: false
 
+# WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/211580
 RSpec/LeakyConstantDeclaration:
   Enabled: true
   Exclude:
-    - 'spec/**/*.rb'
+    - 'spec/db/schema_spec.rb'
+    - 'spec/graphql/gitlab_schema_spec.rb'
+    - 'spec/helpers/visibility_level_helper_spec.rb'
+    - 'spec/initializers/secret_token_spec.rb'
+    - 'spec/lib/declarative_policy_spec.rb'
+    - 'spec/lib/feature_spec.rb'
+    - 'spec/lib/gitlab/background_migration/migrate_issue_trackers_sensitive_data_spec.rb'
+    - 'spec/lib/gitlab/ci/build/credentials/factory_spec.rb'
+    - 'spec/lib/gitlab/ci/config/entry/retry_spec.rb'
+    - 'spec/lib/gitlab/cluster/mixins/puma_cluster_spec.rb'
+    - 'spec/lib/gitlab/cluster/mixins/unicorn_http_server_spec.rb'
+    - 'spec/lib/gitlab/config/entry/factory_spec.rb'
+    - 'spec/lib/gitlab/config/entry/simplifiable_spec.rb'
+    - 'spec/lib/gitlab/database/migration_helpers_spec.rb'
+    - 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb'
+    - 'spec/lib/gitlab/database/with_lock_retries_spec.rb'
+    - 'spec/lib/gitlab/git/diff_collection_spec.rb'
+    - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb'
+    - 'spec/lib/gitlab/health_checks/master_check_spec.rb'
+    - 'spec/lib/gitlab/import_export/attribute_configuration_spec.rb'
+    - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb'
+    - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
+    - 'spec/lib/gitlab/jira_import/issues_importer_spec.rb'
+    - 'spec/lib/gitlab/no_cache_headers_spec.rb'
+    - 'spec/lib/gitlab/path_regex_spec.rb'
+    - 'spec/lib/gitlab/quick_actions/dsl_spec.rb'
+    - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb'
+    - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb'
+    - 'spec/lib/gitlab/sidekiq_middleware_spec.rb'
+    - 'spec/lib/gitlab/view/presenter/factory_spec.rb'
+    - 'spec/lib/marginalia_spec.rb'
+    - 'spec/lib/omni_auth/strategies/jwt_spec.rb'
+    - 'spec/lib/system_check/simple_executor_spec.rb'
+    - 'spec/lib/system_check_spec.rb'
+    - 'spec/mailers/notify_spec.rb'
+    - 'spec/migrations/20191125114345_add_admin_mode_protected_path_spec.rb'
+    - 'spec/migrations/encrypt_plaintext_attributes_on_application_settings_spec.rb'
+    - 'spec/migrations/cleanup_optimistic_locking_nulls_pt2_fixed_spec.rb'
+    - 'spec/models/clusters/cluster_spec.rb'
+    - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb'
+    - 'spec/models/concerns/blocks_json_serialization_spec.rb'
+    - 'spec/models/concerns/bulk_insert_safe_spec.rb'
+    - 'spec/models/concerns/bulk_insertable_associations_spec.rb'
+    - 'spec/models/concerns/mentionable_spec.rb'
+    - 'spec/models/concerns/reactive_caching_spec.rb'
+    - 'spec/models/concerns/triggerable_hooks_spec.rb'
+    - 'spec/models/repository_spec.rb'
+    - 'spec/models/tree_spec.rb'
+    - 'spec/policies/merge_request_policy_spec.rb'
+    - 'spec/requests/api/graphql/tasks/task_completion_status_spec.rb'
+    - 'spec/requests/api/statistics_spec.rb'
+    - 'spec/rubocop/cop/rspec/env_assignment_spec.rb'
+    - 'spec/serializers/commit_entity_spec.rb'
+    - 'spec/services/ci/retry_build_service_spec.rb'
+    - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb'
+    - 'spec/services/clusters/applications/check_uninstall_progress_service_spec.rb'
+    - 'spec/services/clusters/applications/check_upgrade_progress_service_spec.rb'
+    - 'spec/services/clusters/applications/ingress_modsecurity_usage_service_spec.rb'
+    - 'spec/services/issues/resolve_discussions_spec.rb'
+    - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb'
+    - 'spec/support/shared_contexts/spam_constants.rb'
+    - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb'
+    - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb'
+    - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb'
+    - 'spec/uploaders/content_type_whitelist_spec.rb'
+    - 'spec/uploaders/records_uploads_spec.rb'
 
 RSpec/EmptyLineAfterHook:
   Enabled: false