diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-11-17 14:33:21 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-11-17 14:33:21 +0300 |
commit | 7021455bd1ed7b125c55eb1b33c5a01f2bc55ee0 (patch) | |
tree | 5bdc2229f5198d516781f8d24eace62fc7e589e9 /.rubocop_todo/style | |
parent | 185b095e93520f96e9cfc31d9c3e69b498cdab7c (diff) |
Add latest changes from gitlab-org/gitlab@15-6-stable-eev15.6.0-rc42
Diffstat (limited to '.rubocop_todo/style')
19 files changed, 52 insertions, 436 deletions
diff --git a/.rubocop_todo/style/accessor_grouping.yml b/.rubocop_todo/style/accessor_grouping.yml index a2ba217dbcc..a4fae856953 100644 --- a/.rubocop_todo/style/accessor_grouping.yml +++ b/.rubocop_todo/style/accessor_grouping.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/AccessorGrouping: - Details: grace period Exclude: - 'app/finders/template_finder.rb' - 'app/models/commit.rb' diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml index 1a155e3cca0..cb40669ca02 100644 --- a/.rubocop_todo/style/bare_percent_literals.yml +++ b/.rubocop_todo/style/bare_percent_literals.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/BarePercentLiterals: - Details: grace period Exclude: - 'app/models/commit.rb' - 'app/models/concerns/storage/legacy_namespace.rb' diff --git a/.rubocop_todo/style/case_like_if.yml b/.rubocop_todo/style/case_like_if.yml deleted file mode 100644 index 61f2e6bc238..00000000000 --- a/.rubocop_todo/style/case_like_if.yml +++ /dev/null @@ -1,63 +0,0 @@ ---- -# Cop supports --auto-correct. -Style/CaseLikeIf: - Details: grace period - Exclude: - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/groups/dependency_proxy/application_controller.rb' - - 'app/controllers/projects/labels_controller.rb' - - 'app/graphql/types/ci/job_need_union.rb' - - 'app/helpers/avatars_helper.rb' - - 'app/helpers/broadcast_messages_helper.rb' - - 'app/helpers/issues_helper.rb' - - 'app/helpers/routing/pseudonymization_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/members/member_task.rb' - - 'app/models/namespace.rb' - - 'app/models/packages/go/module_version.rb' - - 'app/serializers/group_child_serializer.rb' - - 'app/services/google_cloud/generate_pipeline_service.rb' - - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/todo_service.rb' - - 'app/services/user_project_access_changed_service.rb' - - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' - - 'ee/app/finders/ee/notes_finder.rb' - - 'ee/app/finders/security/scan_execution_policies_finder.rb' - - 'ee/app/finders/security/training_providers/secure_code_warrior_url_finder.rb' - - 'ee/app/helpers/ee/branches_helper.rb' - - 'ee/app/services/epics/tree_reorder_service.rb' - - 'ee/app/services/merge_request_approval_settings/update_service.rb' - - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb' - - 'ee/spec/config/metrics/every_metric_definition_spec.rb' - - 'ee/spec/features/boards/user_adds_lists_to_board_spec.rb' - - 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb' - - 'ee/spec/features/projects/custom_projects_template_spec.rb' - - 'ee/spec/support/matchers/ee/epic_aggregate_matchers.rb' - - 'lib/api/helpers/label_helpers.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/ci/ansi2json/converter.rb' - - 'lib/gitlab/ci/build/image.rb' - - 'lib/gitlab/identifier.rb' - - 'lib/gitlab/issues/rebalancing/state.rb' - - 'lib/gitlab/pagination/gitaly_keyset_pager.rb' - - 'lib/gitlab/utils.rb' - - 'lib/gitlab/utils/strong_memoize.rb' - - 'qa/qa/git/repository.rb' - - 'qa/qa/scenario/bootable.rb' - - 'spec/features/boards/user_adds_lists_to_board_spec.rb' - - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - - 'spec/lib/gitlab/database/load_balancing_spec.rb' - - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - - 'spec/models/concerns/sha_attribute_spec.rb' - - 'spec/models/preloaders/labels_preloader_spec.rb' - - 'spec/requests/api/personal_access_tokens_spec.rb' - - 'spec/requests/api/rubygem_packages_spec.rb' - - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' - - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'spec/services/resource_events/change_state_service_spec.rb' - - 'spec/support/helpers/filter_spec_helper.rb' - - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - - 'spec/workers/loose_foreign_keys/cleanup_worker_spec.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 7fbec98ead5..300d8678719 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/EmptyMethod: - Details: grace period Exclude: - 'app/controllers/admin/application_settings/appearances_controller.rb' - 'app/controllers/admin/applications_controller.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index 346be201322..20e8c976fb7 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/ExplicitBlockArgument: - Details: grace period Exclude: - 'app/controllers/admin/background_migrations_controller.rb' - 'app/controllers/admin/batched_jobs_controller.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index a4ae491b902..f46f8c8f4f6 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -693,7 +693,6 @@ Style/GuardClause: - 'qa/qa/specs/helpers/feature_flag.rb' - 'qa/qa/vendor/jenkins/job.rb' - 'rubocop/cop/api/grape_array_missing_coerce.rb' - - 'rubocop/cop/gitlab/duplicate_spec_location.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' - 'rubocop/cop/gitlab/finder_with_find_by.rb' - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' @@ -717,7 +716,6 @@ Style/GuardClause: - 'spec/support/capybara.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/support/helpers/access_matchers_helpers.rb' - - 'spec/support/helpers/bare_repo_operations.rb' - 'spec/support/helpers/capybara_helpers.rb' - 'spec/support/helpers/dropzone_helper.rb' - 'spec/support/helpers/fake_blob_helpers.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 8e295c68623..fc05a8bc163 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -309,7 +309,6 @@ Style/IfUnlessModifier: - 'app/services/issues/update_service.rb' - 'app/services/lfs/lock_file_service.rb' - 'app/services/members/destroy_service.rb' - - 'app/services/members/update_service.rb' - 'app/services/merge_requests/add_context_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' @@ -743,7 +742,6 @@ Style/IfUnlessModifier: - 'ee/spec/support/http_io/http_io_helpers.rb' - 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb' - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - - 'ee/spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - 'lib/api/api_guard.rb' - 'lib/api/boards_responses.rb' @@ -1202,7 +1200,6 @@ Style/IfUnlessModifier: - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/profiles/keys/_key.html.haml_spec.rb' - 'spec/views/projects/edit.html.haml_spec.rb' - - 'spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - 'tooling/danger/product_intelligence.rb' - 'tooling/lib/tooling/find_codeowners.rb' diff --git a/.rubocop_todo/style/keyword_parameters_order.yml b/.rubocop_todo/style/keyword_parameters_order.yml index 3521f295cc1..ca6cb416b93 100644 --- a/.rubocop_todo/style/keyword_parameters_order.yml +++ b/.rubocop_todo/style/keyword_parameters_order.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/KeywordParametersOrder: - Details: grace period Exclude: - 'app/controllers/concerns/product_analytics_tracking.rb' - 'app/finders/group_descendants_finder.rb' @@ -50,7 +49,6 @@ Style/KeywordParametersOrder: - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - 'qa/spec/runtime/env_spec.rb' - - 'spec/features/projects/branches_spec.rb' - 'spec/graphql/types/ci/pipeline_counts_type_spec.rb' - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' diff --git a/.rubocop_todo/style/lambda.yml b/.rubocop_todo/style/lambda.yml index f733af601ec..f37c2c4967e 100644 --- a/.rubocop_todo/style/lambda.yml +++ b/.rubocop_todo/style/lambda.yml @@ -1,273 +1,82 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/Lambda: - # Offense count: 653 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - - 'app/controllers/concerns/notes_actions.rb' - - 'app/controllers/concerns/spammable_actions/captcha_check/rest_api_actions_support.rb' - - 'app/controllers/projects/issues_controller.rb' - - 'app/controllers/search_controller.rb' - - 'app/graphql/mutations/container_repositories/destroy_tags.rb' - - 'app/graphql/mutations/design_management/delete.rb' - - 'app/graphql/types/permission_types/base_permission_type.rb' - - 'app/models/analytics/cycle_analytics/issue_stage_event.rb' - - 'app/models/analytics/cycle_analytics/merge_request_stage_event.rb' - - 'app/models/bulk_imports/tracker.rb' - - 'app/models/ci/build.rb' - - 'app/models/ci/deleted_object.rb' - - 'app/models/ci/instance_variable.rb' - - 'app/models/ci/job_artifact.rb' - - 'app/models/ci/namespace_mirror.rb' - - 'app/models/ci/pending_build.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/ci/processable.rb' - - 'app/models/ci/runner.rb' - - 'app/models/clusters/cluster.rb' - - 'app/models/clusters/concerns/application_status.rb' - - 'app/models/commit_status.rb' - - 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb' - - 'app/models/concerns/approvable_base.rb' - - 'app/models/concerns/atomic_internal_id.rb' - - 'app/models/concerns/ci/has_status.rb' - - 'app/models/concerns/clusters/agents/authorization_config_scopes.rb' - - 'app/models/concerns/has_environment_scope.rb' - - 'app/models/concerns/has_wiki_page_meta_attributes.rb' - - 'app/models/concerns/id_in_ordered.rb' - - 'app/models/concerns/integrations/has_issue_tracker_fields.rb' - - 'app/models/concerns/issuable.rb' - - 'app/models/concerns/issue_resource_event.rb' - - 'app/models/concerns/milestoneable.rb' - - 'app/models/concerns/mirror_authentication.rb' - - 'app/models/concerns/packages/debian/component_file.rb' - - 'app/models/concerns/reactive_caching.rb' - - 'app/models/concerns/timebox.rb' - - 'app/models/container_repository.rb' - - 'app/models/custom_emoji.rb' - - 'app/models/deployment.rb' - - 'app/models/design_management/action.rb' - - 'app/models/design_management/design.rb' - - 'app/models/design_management/version.rb' - - 'app/models/environment.rb' - - 'app/models/event.rb' - - 'app/models/group.rb' - - 'app/models/group_deploy_key.rb' - - 'app/models/group_group_link.rb' - - 'app/models/hooks/web_hook.rb' - - 'app/models/identity.rb' - - 'app/models/import_failure.rb' - - 'app/models/integrations/zentao_tracker_data.rb' - - 'app/models/internal_id.rb' - - 'app/models/issue.rb' - - 'app/models/issue/metrics.rb' - - 'app/models/jira_connect_installation.rb' - - 'app/models/label.rb' - - 'app/models/label_link.rb' - - 'app/models/loose_foreign_keys/deleted_record.rb' - - 'app/models/member.rb' - - 'app/models/members/project_member.rb' - - 'app/models/merge_request.rb' - - 'app/models/merge_request/cleanup_schedule.rb' - - 'app/models/merge_request_diff.rb' - - 'app/models/merge_request_diff_file.rb' - - 'app/models/merge_requests_closing_issues.rb' - - 'app/models/milestone.rb' - - 'app/models/namespace.rb' - - 'app/models/note.rb' - - 'app/models/note_diff_file.rb' - - 'app/models/notification_setting.rb' - - 'app/models/onboarding/progress.rb' - - 'app/models/operations/feature_flags/user_list.rb' - - 'app/models/packages/package.rb' - - 'app/models/packages/package_file.rb' - - 'app/models/pages_domain.rb' - - 'app/models/product_analytics_event.rb' - - 'app/models/programming_language.rb' - - 'app/models/project.rb' + - 'app/controllers/concerns/project_unauthorized.rb' + - 'app/controllers/profiles/two_factor_auths_controller.rb' + - 'app/models/concerns/featurable.rb' - 'app/models/project_feature.rb' - - 'app/models/project_feature_usage.rb' - - 'app/models/projects/topic.rb' - - 'app/models/prometheus_alert_event.rb' - - 'app/models/raw_usage_data.rb' - - 'app/models/redirect_route.rb' - - 'app/models/release.rb' - - 'app/models/remote_mirror.rb' - - 'app/models/repository_language.rb' - - 'app/models/snippet.rb' - - 'app/models/timelog.rb' - - 'app/models/todo.rb' - - 'app/models/user.rb' - - 'app/models/users/in_product_marketing_email.rb' - 'app/serializers/ci/daily_build_group_report_result_entity.rb' - 'app/serializers/group_child_entity.rb' - 'app/serializers/issuable_sidebar_basic_entity.rb' - 'app/serializers/merge_request_sidebar_basic_entity.rb' - - 'app/services/issues/referenced_merge_requests_service.rb' - - 'config/initializers/deprecations.rb' - - 'config/initializers/rspec_profiling.rb' + - 'config/application.rb' + - 'config/initializers/0_license.rb' + - 'config/initializers/0_log_deprecations.rb' + - 'config/initializers/action_cable.rb' + - 'config/initializers/gitlab_experiment.rb' + - 'config/initializers/lograge.rb' + - 'config/routes.rb' - 'config/routes/dashboard.rb' - 'config/routes/group.rb' - 'config/routes/issues.rb' - - 'db/post_migrate/20210303121224_update_gitlab_subscriptions_start_at_post_eoa.rb' - - 'db/post_migrate/20210513155546_backfill_nuget_temporary_packages_to_processing_status.rb' - - 'db/post_migrate/20210823132600_remove_duplicate_dast_site_tokens.rb' - - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' - - 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb' - - 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb' - - 'ee/app/models/analytics/devops_adoption/snapshot.rb' - - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - - 'ee/app/models/approval_merge_request_rule.rb' - - 'ee/app/models/boards/epic_board_position.rb' - - 'ee/app/models/boards/epic_user_preference.rb' - - 'ee/app/models/ci/minutes/project_monthly_usage.rb' - - 'ee/app/models/concerns/ee/protected_ref.rb' - - 'ee/app/models/concerns/geo/replicable_model.rb' - - 'ee/app/models/concerns/issue_widgets/acts_like_requirement.rb' - - 'ee/app/models/dast/profile.rb' - - 'ee/app/models/dast_site_validation.rb' - - 'ee/app/models/dora/daily_metrics.rb' - - 'ee/app/models/ee/ci/build.rb' - - 'ee/app/models/ee/ci/daily_build_group_report_result.rb' - - 'ee/app/models/ee/ci/job_artifact.rb' - - 'ee/app/models/ee/ci/pipeline.rb' - - 'ee/app/models/ee/environment.rb' - - 'ee/app/models/ee/epic.rb' - - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/group_member.rb' - - 'ee/app/models/ee/identity.rb' - - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/iteration.rb' - - 'ee/app/models/ee/label.rb' - - 'ee/app/models/ee/member.rb' - - 'ee/app/models/ee/merge_request.rb' - - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/namespace_ci_cd_setting.rb' - - 'ee/app/models/ee/note.rb' - - 'ee/app/models/ee/project.rb' - - 'ee/app/models/ee/user.rb' - - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/models/gitlab_subscription.rb' - - 'ee/app/models/incident_management/oncall_rotation.rb' - - 'ee/app/models/incident_management/oncall_shift.rb' - - 'ee/app/models/iterations/cadence.rb' - - 'ee/app/models/merge_request_block.rb' - - 'ee/app/models/merge_requests/external_status_check.rb' - - 'ee/app/models/merge_train.rb' - - 'ee/app/models/protected_environment.rb' - - 'ee/app/models/requirements_management/requirement.rb' - - 'ee/app/models/security/finding.rb' - - 'ee/app/models/security/orchestration_policy_configuration.rb' - - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' - - 'ee/app/models/security/scan.rb' - - 'ee/app/models/security/training_provider.rb' - - 'ee/app/models/software_license_policy.rb' - - 'ee/app/models/vulnerabilities/feedback.rb' - - 'ee/app/models/vulnerabilities/finding.rb' - - 'ee/app/models/vulnerabilities/historical_statistic.rb' - - 'ee/app/models/vulnerabilities/read.rb' - - 'ee/app/models/vulnerabilities/scanner.rb' + - 'ee/app/controllers/concerns/ee/routable_actions/sso_enforcement_redirect.rb' - 'ee/app/serializers/ee/group_child_entity.rb' - - 'ee/lib/ee/api/entities/application_setting.rb' - - 'ee/lib/ee/api/entities/geo_node_status.rb' - - 'ee/lib/ee/api/entities/group.rb' + - 'ee/app/services/ee/issues/export_csv_service.rb' + - 'ee/lib/ee/api/entities/group_detail.rb' - 'ee/lib/ee/api/entities/group_push_rule.rb' - - 'ee/lib/ee/api/entities/project.rb' - - 'ee/lib/ee/api/entities/vulnerability_issue_link.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' + - 'ee/lib/ee/banzai/filter/sanitization_filter.rb' + - 'ee/lib/ee/gitlab/checks/diff_check.rb' + - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/gem_extensions/elasticsearch/model/adapter/active_record/importing.rb' - - 'ee/spec/migrations/backfill_delayed_group_deletion_spec.rb' - - 'ee/spec/migrations/remove_schedule_and_status_null_constraints_from_pending_escalations_alert_spec.rb' + - 'ee/spec/elastic_integration/global_search_spec.rb' + - 'ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb' - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' - - 'ee/spec/services/ee/notes/create_service_spec.rb' + - 'ee/spec/support/helpers/elasticsearch_helpers.rb' - 'ee/spec/support/shared_examples/lib/gitlab/middleware/maintenance_mode_gitlab_ee_instance_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_ee_instance_shared_examples.rb' - - 'lib/api/ci/jobs.rb' - - 'lib/api/ci/pipelines.rb' - - 'lib/api/entities/group_detail.rb' - - 'lib/api/entities/issue.rb' - 'lib/api/entities/label.rb' - - 'lib/api/entities/merge_request.rb' - 'lib/api/entities/project.rb' - 'lib/api/entities/project_export_status.rb' - - 'lib/api/feature_flags_user_lists.rb' - - 'lib/container_registry/base_client.rb' - - 'lib/container_registry/client.rb' - - 'lib/csv_builder.rb' - - 'lib/event_filter.rb' - - 'lib/gitlab/background_migration/backfill_ci_namespace_mirrors.rb' - - 'lib/gitlab/background_migration/backfill_ci_project_mirrors.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'lib/gitlab/ci/config/entry/includes.rb' - - 'lib/gitlab/ci/config/entry/trigger.rb' - - 'lib/gitlab/config/entry/validatable.rb' - - 'lib/gitlab/database/background_migration/batched_migration.rb' - - 'lib/gitlab/database/background_migration_job.rb' - - 'lib/gitlab/database/postgres_foreign_key.rb' - - 'lib/gitlab/database/postgres_index.rb' - - 'lib/gitlab/database/postgres_partition.rb' - - 'lib/gitlab/database/postgres_partitioned_table.rb' - - 'lib/gitlab/gl_repository.rb' - - 'lib/gitlab/import_export/import_failure_service.rb' - - 'lib/gitlab/merge_requests/commit_message_generator.rb' - - 'lib/gitlab/seeder.rb' + - 'lib/api/validations/types/comma_separated_to_array.rb' + - 'lib/api/validations/types/comma_separated_to_integer_array.rb' + - 'lib/api/validations/types/hash_of_integer_values.rb' + - 'lib/api/validations/validators/check_assignees_count.rb' + - 'lib/banzai/filter/ascii_doc_sanitization_filter.rb' + - 'lib/banzai/filter/base_sanitization_filter.rb' + - 'lib/banzai/filter/sanitization_filter.rb' + - 'lib/gitlab/action_cable/request_store_callbacks.rb' + - 'lib/gitlab/checks/diff_check.rb' + - 'lib/gitlab/database/load_balancing/action_cable_callbacks.rb' + - 'lib/gitlab/memory/watchdog/configurator.rb' + - 'lib/gitlab/middleware/rack_multipart_tempfile_factory.rb' + - 'lib/gitlab/omniauth_initializer.rb' + - 'lib/gitlab/prometheus/queries/query_additional_metrics.rb' + - 'lib/gitlab/rack_attack.rb' - 'lib/gitlab/sidekiq_config/worker_matcher.rb' - - 'lib/gitlab/sidekiq_signals.rb' - - 'lib/gitlab/utils/measuring.rb' - - 'lib/gitlab/visibility_level.rb' - - 'rubocop/cop/rspec/modify_sidekiq_middleware.rb' - - 'rubocop/cop/rspec/timecop_freeze.rb' - - 'rubocop/cop/rspec/timecop_travel.rb' + - 'lib/gitlab/sidekiq_middleware.rb' + - 'lib/gitlab/utils/usage_data.rb' + - 'qa/qa/page/base.rb' + - 'qa/qa/runtime/allure_report.rb' + - 'qa/qa/specs/features/api/1_manage/import/import_large_github_repo_spec.rb' + - 'qa/qa/support/api.rb' + - 'rubocop/cop/inject_enterprise_edition_module.rb' + - 'rubocop/cop/rspec/have_gitlab_http_status.rb' - 'spec/controllers/concerns/routable_actions_spec.rb' - - 'spec/deprecation_toolkit_env.rb' - - 'spec/factories/design_management/designs.rb' - - 'spec/features/projects/issues/design_management/user_views_designs_with_svg_xss_spec.rb' - - 'spec/graphql/resolvers/concerns/resolves_groups_spec.rb' + - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' + - 'spec/graphql/types/base_object_spec.rb' + - 'spec/lib/gitlab/action_cable/request_store_callbacks_spec.rb' - 'spec/lib/gitlab/cross_project_access/class_methods_spec.rb' - - 'spec/lib/gitlab/database/consistency_spec.rb' - - 'spec/lib/gitlab/database/dynamic_model_helpers_spec.rb' - 'spec/lib/gitlab/database/load_balancing/action_cable_callbacks_spec.rb' - - 'spec/lib/gitlab/database/load_balancing_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_metrics_spec.rb' + - 'spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb' - 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb' - - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/validator_spec.rb' - - 'spec/migrations/20210722150102_operations_feature_flags_correct_flexible_rollout_values_spec.rb' - - 'spec/migrations/20210804150320_create_base_work_item_types_spec.rb' - - 'spec/migrations/20210819145000_drop_temporary_columns_and_triggers_for_ci_builds_runner_session_spec.rb' - - 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb' - - 'spec/migrations/20210902144144_drop_temporary_columns_and_triggers_for_ci_build_needs_spec.rb' - - 'spec/migrations/20210906100316_drop_temporary_columns_and_triggers_for_ci_build_trace_chunks_spec.rb' - - 'spec/migrations/20210906130643_drop_temporary_columns_and_triggers_for_taggings_spec.rb' - - 'spec/migrations/20210907013944_cleanup_bigint_conversion_for_ci_builds_metadata_spec.rb' - - 'spec/migrations/20210915022415_cleanup_bigint_conversion_for_ci_builds_spec.rb' - - 'spec/migrations/20210922021816_drop_int4_columns_for_ci_job_artifacts_spec.rb' - - 'spec/migrations/20210922025631_drop_int4_column_for_ci_sources_pipelines_spec.rb' - - 'spec/migrations/20210922082019_drop_int4_column_for_events_spec.rb' - - 'spec/migrations/20210922091402_drop_int4_column_for_push_event_payloads_spec.rb' - - 'spec/migrations/20211126115449_encrypt_static_objects_external_storage_auth_token_spec.rb' - - 'spec/migrations/20211203091642_add_index_to_projects_on_marked_for_deletion_at_spec.rb' - - 'spec/migrations/20220120094340_drop_position_from_security_findings_spec.rb' - - 'spec/migrations/20220128155814_fix_approval_rules_code_owners_rule_type_index_spec.rb' - - 'spec/migrations/20220305223212_add_security_training_providers_spec.rb' - - 'spec/migrations/20220505174658_update_index_on_alerts_to_exclude_null_fingerprints_spec.rb' - - 'spec/migrations/generate_customers_dot_jwt_signing_key_spec.rb' - - 'spec/migrations/insert_ci_daily_pipeline_schedule_triggers_plan_limits_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb' - - 'spec/migrations/remove_schedule_and_status_from_pending_alert_escalations_spec.rb' - - 'spec/models/ability_spec.rb' - - 'spec/models/broadcast_message_spec.rb' - - 'spec/models/concerns/participable_spec.rb' + - 'spec/lib/gitlab/middleware/rack_multipart_tempfile_factory_spec.rb' + - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/services/groups/autocomplete_service_spec.rb' - - 'spec/services/notes/create_service_spec.rb' + - 'spec/services/issues/referenced_merge_requests_service_spec.rb' - 'spec/services/projects/autocomplete_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - 'spec/support/helpers/email_helpers.rb' + - 'spec/support/helpers/reference_parser_helpers.rb' - 'spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_instance_shared_examples.rb' - - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' - - 'spec/workers/process_commit_worker_spec.rb' diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml index 9570bd7b036..295aa2f6878 100644 --- a/.rubocop_todo/style/next.yml +++ b/.rubocop_todo/style/next.yml @@ -2,32 +2,4 @@ # Cop supports --auto-correct. Style/Next: Exclude: - - 'app/models/concerns/integrations/slack_mattermost_notifier.rb' - - 'app/validators/nested_attributes_duplicates_validator.rb' - - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb' - - 'ee/db/fixtures/development/20_vulnerabilities.rb' - - 'ee/lib/ee/audit/protected_branches_changes_auditor.rb' - - 'ee/lib/gitlab/elastic/search_results.rb' - - 'ee/lib/system_check/geo/authorized_keys_check.rb' - - 'lib/backup/manager.rb' - - 'lib/banzai/filter/external_link_filter.rb' - - 'lib/banzai/filter/footnote_filter.rb' - - 'lib/banzai/filter/kroki_filter.rb' - - 'lib/banzai/filter/math_filter.rb' - - 'lib/banzai/filter/plantuml_filter.rb' - - 'lib/banzai/filter/table_of_contents_filter.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/database.rb' - 'lib/gitlab/fogbugz_import/importer.rb' - - 'lib/gitlab/gitaly_client/repository_service.rb' - - 'lib/gitlab/import_export/attributes_permitter.rb' - - 'lib/gitlab/import_export/base/relation_object_saver.rb' - - 'lib/gitlab/metrics/samplers/base_sampler.rb' - - 'lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy.rb' - - 'lib/gitlab/reference_extractor.rb' - - 'lib/tasks/gitlab/assets.rake' - - 'lib/tasks/gitlab/db/validate_config.rake' - - 'scripts/perf/query_limiting_report.rb' - - 'scripts/qa/quarantine-types-check' - - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb' - - 'spec/presenters/packages/npm/package_presenter_spec.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index 5de15180438..4e8b608e424 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/NumericLiteralPrefix: - Details: grace period Exclude: - 'app/models/container_repository.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 472a722ed22..bac2e807053 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -696,7 +696,6 @@ Style/PercentLiteralDelimiters: - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/projects/active_tabs_spec.rb' - 'spec/features/projects/artifacts/user_downloads_artifacts_spec.rb' - - 'spec/features/projects/branches_spec.rb' - 'spec/features/projects/environments/environment_spec.rb' - 'spec/features/projects/integrations/user_activates_jira_spec.rb' - 'spec/features/projects/jobs_spec.rb' diff --git a/.rubocop_todo/style/redundant_begin.yml b/.rubocop_todo/style/redundant_begin.yml index e96cdb26b08..d2851de201b 100644 --- a/.rubocop_todo/style/redundant_begin.yml +++ b/.rubocop_todo/style/redundant_begin.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/RedundantBegin: - Details: grace period Exclude: - 'app/controllers/concerns/membership_actions.rb' - 'app/controllers/concerns/metrics_dashboard.rb' diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml index 3747312f2c4..ca7e01ffa61 100644 --- a/.rubocop_todo/style/redundant_interpolation.yml +++ b/.rubocop_todo/style/redundant_interpolation.yml @@ -94,83 +94,4 @@ Style/RedundantInterpolation: - 'qa/qa/tools/generate_perf_testdata.rb' - 'scripts/perf/gc/print_gc_stats.rb' - 'scripts/qa/testcases-check' - - 'spec/controllers/admin/integrations_controller_spec.rb' - - 'spec/features/commits_spec.rb' - - 'spec/features/issues/user_edits_issue_spec.rb' - - 'spec/features/merge_request/user_scrolls_to_note_on_load_spec.rb' - - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb' - - 'spec/features/one_trust_spec.rb' - - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' - - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' - - 'spec/graphql/resolvers/container_repositories_resolver_spec.rb' - - 'spec/helpers/environments_helper_spec.rb' - - 'spec/helpers/snippets_helper_spec.rb' - - 'spec/lib/api/helpers/packages/dependency_proxy_helpers_spec.rb' - - 'spec/lib/api/validations/validators/git_ref_spec.rb' - - 'spec/lib/api/validations/validators/limit_spec.rb' - - 'spec/lib/backup/database_backup_error_spec.rb' - - 'spec/lib/backup/file_backup_error_spec.rb' - - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - - 'spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb' - - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/milestone_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/project_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' - - 'spec/lib/feature_spec.rb' - - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/job_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb' - - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb' - - 'spec/lib/gitlab/database/batch_count_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' - - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/url_spec.rb' - - 'spec/lib/gitlab/redis/multi_store_spec.rb' - - 'spec/lib/grafana/client_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/models/active_session_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/diff_discussion_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/presenters/project_presenter_spec.rb' - - 'spec/rack_servers/configs/config.ru' - - 'spec/requests/api/alert_management_alerts_spec.rb' - - 'spec/requests/api/markdown_spec.rb' - - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/metrics/dashboard/annotations_spec.rb' - - 'spec/requests/api/tags_spec.rb' - - 'spec/requests/api/terraform/state_spec.rb' - - 'spec/requests/projects/google_cloud/deployments_controller_spec.rb' - - 'spec/requests/projects/google_cloud/service_accounts_controller_spec.rb' - - 'spec/routing/project_routing_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - - 'spec/services/groups/transfer_service_spec.rb' - - 'spec/services/members/invite_service_spec.rb' - - 'spec/services/todo_service_spec.rb' - - 'spec/services/todos/destroy/entity_leave_service_spec.rb' - - 'spec/services/users/approve_service_spec.rb' - - 'spec/services/users/ban_service_spec.rb' - - 'spec/services/users/reject_service_spec.rb' - - 'spec/services/users/unban_service_spec.rb' - - 'spec/support/google_api/cloud_platform_helpers.rb' - - 'spec/support/helpers/features/releases_helpers.rb' - - 'spec/support/helpers/graphql_helpers.rb' - - 'spec/support/helpers/kubernetes_helpers.rb' - - 'spec/support/matchers/exceed_query_limit.rb' - - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - - 'spec/support/shared_examples/graphql/resolvers/packages_resolvers_shared_examples.rb' - - 'spec/support/shared_examples/lib/sentry/client_shared_examples.rb' - - 'spec/support/shared_examples/mailers/notify_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/issues_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/services/users/dismiss_user_callout_service_shared_examples.rb' - - 'spec/support_specs/graphql/arguments_spec.rb' - - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb' - 'tooling/rspec_flaky/flaky_example.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index 3ffd27d26ae..a85039a45f5 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/SingleArgumentDig: - Details: grace period Exclude: - 'app/graphql/resolvers/namespace_projects_resolver.rb' - 'app/models/ci/build.rb' diff --git a/.rubocop_todo/style/sole_nested_conditional.yml b/.rubocop_todo/style/sole_nested_conditional.yml index 535b8d20765..3c663b5f89a 100644 --- a/.rubocop_todo/style/sole_nested_conditional.yml +++ b/.rubocop_todo/style/sole_nested_conditional.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/SoleNestedConditional: - Details: grace period Exclude: - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/ldap/omniauth_callbacks_controller.rb' diff --git a/.rubocop_todo/style/special_global_vars.yml b/.rubocop_todo/style/special_global_vars.yml deleted file mode 100644 index df688872d71..00000000000 --- a/.rubocop_todo/style/special_global_vars.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -# Cop supports --auto-correct. -Style/SpecialGlobalVars: - Details: grace period diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index ec15edbc206..65389d798d3 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -100,7 +100,6 @@ Style/StringConcatenation: - 'ee/spec/support/shared_examples/models/geo_framework_registry_shared_examples.rb' - 'ee/spec/tasks/gitlab/license_rake_spec.rb' - 'lib/api/entities/tree_object.rb' - - 'lib/api/go_proxy.rb' - 'lib/api/internal/kubernetes.rb' - 'lib/backup/files.rb' - 'lib/backup/manager.rb' @@ -316,7 +315,6 @@ Style/StringConcatenation: - 'spec/services/verify_pages_domain_service_spec.rb' - 'spec/support/capybara.rb' - 'spec/support/helpers/ci_artifact_metadata_generator.rb' - - 'spec/support/helpers/git_helpers.rb' - 'spec/support/helpers/gitaly_setup.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' - 'spec/support/helpers/kubernetes_helpers.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index fc90e1ce6a6..29e94e77345 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/StringLiteralsInInterpolation: - Details: grace period Exclude: - 'app/graphql/mutations/base_mutation.rb' - 'app/helpers/colors_helper.rb' |