diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-07-19 17:16:28 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-07-19 17:16:28 +0300 |
| commit | e4384360a16dd9a19d4d2d25d0ef1f2b862ed2a6 (patch) | |
| tree | 2fcdfa7dcdb9db8f5208b2562f4b4e803d671243 /.rubocop_todo | |
| parent | ffda4e7bcac36987f936b4ba515995a6698698f0 (diff) | |
Add latest changes from gitlab-org/gitlab@16-2-stable-eev16.2.0-rc42
Diffstat (limited to '.rubocop_todo')
64 files changed, 2350 insertions, 844 deletions
diff --git a/.rubocop_todo/background_migration/avoid_silent_rescue_exceptions.yml b/.rubocop_todo/background_migration/avoid_silent_rescue_exceptions.yml new file mode 100644 index 00000000000..5e8da636254 --- /dev/null +++ b/.rubocop_todo/background_migration/avoid_silent_rescue_exceptions.yml @@ -0,0 +1,8 @@ +--- +BackgroundMigration/AvoidSilentRescueExceptions: + Exclude: + - 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb' + - 'lib/gitlab/background_migration/migrate_links_for_vulnerability_findings.rb' + - 'lib/gitlab/background_migration/populate_vulnerability_dismissal_fields.rb' + - 'lib/gitlab/background_migration/reset_status_on_container_repositories.rb' + - 'lib/gitlab/background_migration/migrate_remediations_for_vulnerability_findings.rb' diff --git a/.rubocop_todo/factory_bot/create_list.yml b/.rubocop_todo/factory_bot/create_list.yml new file mode 100644 index 00000000000..289be6ef20b --- /dev/null +++ b/.rubocop_todo/factory_bot/create_list.yml @@ -0,0 +1,83 @@ +--- +# Cop supports --autocorrect. +FactoryBot/CreateList: + Details: grace period + Exclude: + - 'ee/spec/controllers/ee/search_controller_spec.rb' + - 'ee/spec/controllers/projects/licenses_controller_spec.rb' + - 'ee/spec/factories/geo_nodes.rb' + - 'ee/spec/features/projects/environments/environments_spec.rb' + - 'ee/spec/features/projects/licenses/maintainer_views_policies_spec.rb' + - 'ee/spec/finders/security/findings_finder_spec.rb' + - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/frontend/fixtures/dast_profiles.rb' + - 'ee/spec/frontend/fixtures/merge_requests.rb' + - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' + - 'ee/spec/helpers/ee/branches_helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' + - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' + - 'ee/spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' + - 'ee/spec/lib/gitlab/license_scanning/sbom_scanner_spec.rb' + - 'ee/spec/lib/gitlab/vulnerabilities/findings_preloader_spec.rb' + - 'ee/spec/models/approval_project_rule_spec.rb' + - 'ee/spec/models/ci/build_spec.rb' + - 'ee/spec/models/ee/project_spec.rb' + - 'ee/spec/models/geo_node_spec.rb' + - 'ee/spec/models/label_note_spec.rb' + - 'ee/spec/models/merge_request_spec.rb' + - 'ee/spec/models/merge_requests/external_status_check_spec.rb' + - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' + - 'ee/spec/models/protected_environment_spec.rb' + - 'ee/spec/models/sca/license_compliance_spec.rb' + - 'ee/spec/models/visible_approvable_spec.rb' + - 'ee/spec/models/vulnerabilities/finding_spec.rb' + - 'ee/spec/presenters/merge_request_presenter_spec.rb' + - 'ee/spec/requests/api/search_spec.rb' + - 'ee/spec/requests/api/status_checks_spec.rb' + - 'ee/spec/requests/projects/pipelines_controller_spec.rb' + - 'ee/spec/serializers/license_compliance/collapsed_comparer_entity_spec.rb' + - 'ee/spec/serializers/license_compliance/comparer_entity_spec.rb' + - 'ee/spec/services/approval_rules/params_filtering_service_spec.rb' + - 'ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb' + - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' + - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' + - 'ee/spec/services/epics/epic_links/create_service_spec.rb' + - 'ee/spec/services/geo/node_update_service_spec.rb' + - 'ee/spec/services/iterations/roll_over_issues_service_spec.rb' + - 'ee/spec/services/members/activate_service_spec.rb' + - 'ee/spec/services/sbom/ingestion/tasks/ingest_components_spec.rb' + - 'ee/spec/services/sbom/ingestion/tasks/ingest_sources_spec.rb' + - 'ee/spec/services/security/findings/dismiss_service_spec.rb' + - 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb' + - 'ee/spec/services/security/ingestion/mark_as_resolved_service_spec.rb' + - 'ee/spec/services/vulnerabilities/find_or_create_from_security_finding_service_spec.rb' + - 'ee/spec/support/shared_examples/requests/api/graphql/issue_list_shared_examples.rb' + - 'spec/controllers/groups/children_controller_spec.rb' + - 'spec/features/groups/milestone_spec.rb' + - 'spec/features/projects/environments/environments_spec.rb' + - 'spec/finders/clusters/agent_tokens_finder_spec.rb' + - 'spec/graphql/resolvers/design_management/design_resolver_spec.rb' + - 'spec/helpers/branches_helper_spec.rb' + - 'spec/helpers/groups/group_members_helper_spec.rb' + - 'spec/lib/atlassian/jira_connect/serializers/repository_entity_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/report_spec.rb' + - 'spec/lib/gitlab/usage_data_spec.rb' + - 'spec/mailers/repository_check_mailer_spec.rb' + - 'spec/models/ci/group_spec.rb' + - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/deploy_key_spec.rb' + - 'spec/models/group_spec.rb' + - 'spec/models/label_note_spec.rb' + - 'spec/models/note_spec.rb' + - 'spec/models/work_items/widgets/assignees_spec.rb' + - 'spec/models/work_items/widgets/labels_spec.rb' + - 'spec/requests/api/graphql/project/pipeline_spec.rb' + - 'spec/requests/api/protected_branches_spec.rb' + - 'spec/requests/api/protected_tags_spec.rb' + - 'spec/services/clusters/management/validate_management_project_permissions_service_spec.rb' + - 'spec/services/issuable/bulk_update_service_spec.rb' + - 'spec/services/issues/resolve_discussions_spec.rb' + - 'spec/services/merge_requests/assign_issues_service_spec.rb' + - 'spec/services/projects/fork_service_spec.rb' + - 'spec/support/shared_examples/models/concerns/bulk_users_by_email_load_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/issue_list_shared_examples.rb' diff --git a/.rubocop_todo/fips/md5.yml b/.rubocop_todo/fips/md5.yml index d50aaf79502..4a1994635b7 100644 --- a/.rubocop_todo/fips/md5.yml +++ b/.rubocop_todo/fips/md5.yml @@ -17,5 +17,3 @@ Fips/MD5: - 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb' - 'spec/models/concerns/checksummable_spec.rb' - 'spec/services/gravatar_service_spec.rb' - - 'spec/tooling/rspec_flaky/example_spec.rb' - - 'tooling/rspec_flaky/example.rb' diff --git a/.rubocop_todo/gettext/static_identifier.yml b/.rubocop_todo/gettext/static_identifier.yml index f14c4884102..2db2a2f130f 100644 --- a/.rubocop_todo/gettext/static_identifier.yml +++ b/.rubocop_todo/gettext/static_identifier.yml @@ -13,7 +13,6 @@ Gettext/StaticIdentifier: - 'app/services/users/banned_user_base_service.rb' - 'app/services/work_items/widgets/hierarchy_service/base_service.rb' - 'ee/app/controllers/admin/licenses_controller.rb' - - 'ee/app/controllers/subscriptions/groups_controller.rb' - 'ee/app/mailers/ee/emails/admin_notification.rb' - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' - 'ee/app/models/ee/member.rb' diff --git a/.rubocop_todo/gitlab/doc_url.yml b/.rubocop_todo/gitlab/doc_url.yml index 119de2296ce..13537a142a1 100644 --- a/.rubocop_todo/gitlab/doc_url.yml +++ b/.rubocop_todo/gitlab/doc_url.yml @@ -43,7 +43,6 @@ Gitlab/DocUrl: - 'lib/gitlab/pagination/keyset/unsupported_scope_order.rb' - 'lib/gitlab/redis/hll.rb' - 'lib/gitlab/slash_commands/presenters/help.rb' - - 'lib/gitlab/utils/strong_memoize.rb' - 'lib/initializer_connections.rb' - 'lib/security/ci_configuration/base_build_action.rb' - 'lib/tasks/db_obsolete_ignored_columns.rake' diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index d7eec700a9d..a0c71dec923 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -38,7 +38,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/models/approval_state.rb' - 'ee/app/models/concerns/ee/approvable.rb' - 'ee/app/models/concerns/ee/project_security_scanners_information.rb' - - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/concerns/insights_feature.rb' - 'ee/app/models/ee/board.rb' - 'ee/app/models/ee/ci/build.rb' @@ -68,7 +67,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/services/ci/audit_variable_change_service.rb' - 'ee/app/services/dashboard/projects/create_service.rb' - 'ee/app/services/dashboard/projects/list_service.rb' - - 'ee/app/services/ee/alert_management/http_integrations/create_service.rb' - 'ee/app/services/ee/audit_event_service.rb' - 'ee/app/services/ee/boards/issues/list_service.rb' - 'ee/app/services/ee/boards/lists/create_service.rb' @@ -91,6 +89,31 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/services/projects/mark_for_deletion_service.rb' - 'ee/app/services/requirements_management/process_test_reports_service.rb' - 'ee/app/services/security/store_scans_service.rb' + - 'ee/app/views/compliance_management/compliance_framework/_project_settings.html.haml.rb' + - 'ee/app/views/groups/epics/index.html.haml.rb' + - 'ee/app/views/product_analytics/_project_settings.html.haml.rb' + - 'ee/app/views/projects/_merge_request_settings.html.haml.rb' + - 'ee/app/views/projects/_merge_request_settings_description_text.html.haml.rb' + - 'ee/app/views/projects/_remove.html.haml.rb' + - 'ee/app/views/projects/audit_events/index.html.haml.rb' + - 'ee/app/views/projects/blob/_header_file_locks.html.haml.rb' + - 'ee/app/views/projects/branch_defaults/_branch_names_help.html.haml.rb' + - 'ee/app/views/projects/merge_requests/show.html.haml.rb' + - 'ee/app/views/projects/push_rules/_index.html.haml.rb' + - 'ee/app/views/projects/quality/test_cases/index.html.haml.rb' + - 'ee/app/views/projects/settings/_default_issue_template.html.haml.rb' + - 'ee/app/views/projects/settings/_restore.html.haml.rb' + - 'ee/app/views/projects/settings/ci_cd/_auto_rollback.html.haml.rb' + - 'ee/app/views/projects/settings/ci_cd/_pipeline_subscriptions.html.haml.rb' + - 'ee/app/views/projects/settings/merge_requests/_merge_request_approvals_settings.html.haml.rb' + - 'ee/app/views/projects/settings/operations/_status_page.html.haml.rb' + - 'ee/app/views/projects/settings/repository/_protected_branches.html.haml.rb' + - 'ee/app/views/protected_branches/ee/_code_owner_approval_form.html.haml.rb' + - 'ee/app/views/protected_branches/ee/_code_owner_approval_table.html.haml.rb' + - 'ee/app/views/protected_branches/ee/_code_owner_approval_table_head.html.haml.rb' + - 'ee/app/views/shared/labels/_create_label_help_text.html.haml.rb' + - 'ee/app/views/shared/promotions/_promote_mr_features.html.haml.rb' + - 'ee/app/views/shared/promotions/_promote_repository_features.html.haml.rb' - 'ee/app/workers/analytics/code_review_metrics_worker.rb' - 'ee/app/workers/group_saml_group_sync_worker.rb' - 'ee/lib/ee/api/entities/approval_state.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 8a0dd63ae7c..8c8306124c1 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -808,6 +808,7 @@ Gitlab/NamespacedClass: - 'app/workers/purge_dependency_proxy_cache_worker.rb' - 'app/workers/reactive_caching_worker.rb' - 'app/workers/rebase_worker.rb' + - 'app/workers/redis_migration_worker.rb' - 'app/workers/remote_mirror_notification_worker.rb' - 'app/workers/remove_expired_group_links_worker.rb' - 'app/workers/remove_expired_members_worker.rb' @@ -1248,7 +1249,6 @@ Gitlab/NamespacedClass: - 'lib/gitlab/user_access.rb' - 'lib/gitlab/user_access_snippet.rb' - 'lib/gitlab/uuid.rb' - - 'lib/gitlab/version_info.rb' - 'lib/gitlab/visibility_level_checker.rb' - 'lib/gitlab/wiki_file_finder.rb' - 'lib/gitlab/workhorse.rb' diff --git a/.rubocop_todo/gitlab/service_response.yml b/.rubocop_todo/gitlab/service_response.yml index a61bb27ed2e..eef625fed0c 100644 --- a/.rubocop_todo/gitlab/service_response.yml +++ b/.rubocop_todo/gitlab/service_response.yml @@ -49,7 +49,6 @@ Gitlab/ServiceResponse: - 'ee/app/services/external_status_checks/destroy_service.rb' - 'ee/app/services/external_status_checks/dispatch_service.rb' - 'ee/app/services/external_status_checks/update_service.rb' - - 'ee/app/services/gitlab_subscriptions/create_trial_or_lead_service.rb' - 'ee/app/services/group_saml/saml_group_links/create_service.rb' - 'ee/app/services/iterations/cadences/create_iterations_in_advance_service.rb' - 'ee/app/services/iterations/cadences/create_service.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 62457a0108e..b30a18be6ba 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -1,6 +1,7 @@ --- # Cop supports --autocorrect. Gitlab/StrongMemoizeAttr: + Details: grace period Exclude: - 'app/components/pajamas/avatar_component.rb' - 'app/controllers/application_controller.rb' @@ -27,7 +28,6 @@ Gitlab/StrongMemoizeAttr: - 'app/controllers/projects/incidents_controller.rb' - 'app/controllers/projects/merge_requests/drafts_controller.rb' - 'app/controllers/projects/merge_requests_controller.rb' - - 'app/controllers/projects/metrics_dashboard_controller.rb' - 'app/controllers/projects/milestones_controller.rb' - 'app/controllers/projects/pipelines/application_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' @@ -52,7 +52,6 @@ Gitlab/StrongMemoizeAttr: - 'app/finders/merge_requests_finder/params.rb' - 'app/finders/projects/members/effective_access_level_finder.rb' - 'app/finders/releases/evidence_pipeline_finder.rb' - - 'app/finders/releases_finder.rb' - 'app/finders/snippets_finder.rb' - 'app/finders/todos_finder.rb' - 'app/graphql/resolvers/issue_status_counts_resolver.rb' @@ -125,7 +124,6 @@ Gitlab/StrongMemoizeAttr: - 'app/models/namespaces/traversal/linear.rb' - 'app/models/namespaces/traversal/recursive.rb' - 'app/models/note.rb' - - 'app/models/pages/lookup_path.rb' - 'app/models/project.rb' - 'app/models/release.rb' - 'app/models/resource_event.rb' @@ -134,7 +132,6 @@ Gitlab/StrongMemoizeAttr: - 'app/models/snippet_input_action_collection.rb' - 'app/models/state_note.rb' - 'app/models/tree.rb' - - 'app/models/uploads/fog.rb' - 'app/models/user.rb' - 'app/models/wiki_page.rb' - 'app/models/work_item.rb' @@ -173,7 +170,6 @@ Gitlab/StrongMemoizeAttr: - 'app/services/ci/queue/build_queue_service.rb' - 'app/services/ci/update_build_state_service.rb' - 'app/services/clusters/agents/authorizations/ci_access/refresh_service.rb' - - 'app/services/clusters/integrations/prometheus_health_check_service.rb' - 'app/services/concerns/alert_management/alert_processing.rb' - 'app/services/concerns/incident_management/settings.rb' - 'app/services/concerns/issues/resolve_discussions.rb' @@ -250,7 +246,6 @@ Gitlab/StrongMemoizeAttr: - 'app/workers/merge_request_cleanup_refs_worker.rb' - 'app/workers/packages/cleanup/execute_policy_worker.rb' - 'app/workers/packages/debian/generate_distribution_worker.rb' - - 'app/workers/packages/debian/process_changes_worker.rb' - 'app/workers/packages/maven/metadata/sync_worker.rb' - 'app/workers/projects/inactive_projects_deletion_cron_worker.rb' - 'ee/app/controllers/admin/audit_logs_controller.rb' @@ -284,10 +279,10 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/helpers/ee/preferences_helper.rb' - 'ee/app/helpers/ee/registrations_helper.rb' - 'ee/app/helpers/ee/timeboxes_helper.rb' - - 'ee/app/helpers/trials_helper.rb' - - 'ee/app/helpers/welcome_helper.rb' - 'ee/app/helpers/license_monitoring_helper.rb' - 'ee/app/helpers/subscriptions_helper.rb' + - 'ee/app/helpers/trials_helper.rb' + - 'ee/app/helpers/welcome_helper.rb' - 'ee/app/models/approval_merge_request_rule.rb' - 'ee/app/models/approval_state.rb' - 'ee/app/models/approval_wrapped_any_approver_rule.rb' @@ -317,7 +312,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/ee/snippet.rb' - - 'ee/app/models/ee/user.rb' - 'ee/app/models/ee/work_item.rb' - 'ee/app/models/gitlab/seat_link_data.rb' - 'ee/app/models/gitlab_subscription.rb' @@ -329,6 +323,7 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/models/vulnerabilities/finding.rb' - 'ee/app/presenters/approval_rule_presenter.rb' - 'ee/app/presenters/ci/minutes/usage_presenter.rb' + - 'ee/app/presenters/merge_request_approver_presenter.rb' - 'ee/app/serializers/dashboard_operations_project_entity.rb' - 'ee/app/serializers/ee/member_user_entity.rb' - 'ee/app/services/app_sec/dast/pipelines/find_latest_service.rb' @@ -338,7 +333,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/services/ci/compare_license_scanning_reports_collapsed_service.rb' - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' - 'ee/app/services/ci/subscribe_bridge_service.rb' - - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' - 'ee/app/services/deployments/approval_service.rb' - 'ee/app/services/ee/allowed_email_domains/update_service.rb' - 'ee/app/services/ee/auto_merge_service.rb' @@ -389,13 +383,11 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/services/status_page/publish_service.rb' - 'ee/app/services/status_page/trigger_publish_service.rb' - 'ee/app/services/timebox_report_service.rb' - - 'ee/app/services/vulnerabilities/create_service.rb' - 'ee/app/services/vulnerability_feedback/create_service.rb' - 'ee/app/services/vulnerability_feedback/destroy_service.rb' - 'ee/app/workers/auth/saml_group_sync_worker.rb' - 'ee/app/workers/geo/repository_cleanup_worker.rb' - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' - - 'ee/app/workers/group_saml_group_sync_worker.rb' - 'ee/app/workers/status_page/publish_worker.rb' - 'ee/lib/api/analytics/project_deployment_frequency.rb' - 'ee/lib/api/epic_links.rb' @@ -417,7 +409,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/lib/ee/gitlab/checks/diff_check.rb' - 'ee/lib/ee/gitlab/ci/matching/runner_matcher.rb' - 'ee/lib/ee/gitlab/ci/pipeline/chain/validate/external.rb' - - 'ee/lib/ee/gitlab/ci/pipeline/quota/activity.rb' - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' - 'ee/lib/ee/gitlab/etag_caching/router/rails.rb' - 'ee/lib/ee/gitlab/git_access.rb' @@ -427,7 +418,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/lib/ee/gitlab/security/scan_configuration.rb' - 'ee/lib/ee/gitlab/web_hooks/rate_limiter.rb' - 'ee/lib/ee/sidebars/groups/menus/issues_menu.rb' - - 'ee/lib/ee/sidebars/groups/menus/settings_menu.rb' - 'ee/lib/elastic/multi_version_util.rb' - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' - 'ee/lib/gitlab/auth/group_saml/membership_updater.rb' @@ -481,7 +471,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/atlassian/jira_connect/jwt/symmetric.rb' - 'lib/banzai/filter/base_sanitization_filter.rb' - 'lib/banzai/filter/custom_emoji_filter.rb' - - 'lib/banzai/filter/inline_metrics_redactor_filter.rb' - 'lib/banzai/filter/issuable_reference_expansion_filter.rb' - 'lib/banzai/filter/references/reference_cache.rb' - 'lib/banzai/filter/repository_link_filter.rb' @@ -571,7 +560,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/config/entry/composable_array.rb' - 'lib/gitlab/config/loader/yaml.rb' - 'lib/gitlab/conflict/file.rb' - - 'lib/gitlab/database/background_migration/health_status/indicators/write_ahead_log.rb' - 'lib/gitlab/database/bulk_update.rb' - 'lib/gitlab/database/load_balancing/srv_resolver.rb' - 'lib/gitlab/database/metrics.rb' @@ -614,7 +602,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/import_export/importer.rb' - 'lib/gitlab/import_export/lfs_restorer.rb' - 'lib/gitlab/import_export/project/sample/date_calculator.rb' - - 'lib/gitlab/import_export/project/tree_restorer.rb' - 'lib/gitlab/inactive_projects_deletion_warning_tracker.rb' - 'lib/gitlab/instrumentation/redis_base.rb' - 'lib/gitlab/instrumentation/redis_payload.rb' diff --git a/.rubocop_todo/graphql/resource_not_available_error.yml b/.rubocop_todo/graphql/resource_not_available_error.yml index 5a9d2f9b1a2..316cd4a99cb 100644 --- a/.rubocop_todo/graphql/resource_not_available_error.yml +++ b/.rubocop_todo/graphql/resource_not_available_error.yml @@ -40,4 +40,3 @@ Graphql/ResourceNotAvailableError: - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/incident_management/oncall_shifts_resolver.rb' - 'ee/app/graphql/resolvers/product_analytics/visualization_resolver.rb' - - 'ee/app/graphql/resolvers/remote_development/workspaces_resolver.rb' diff --git a/.rubocop_todo/internal_affairs/use_restrict_on_send.yml b/.rubocop_todo/internal_affairs/use_restrict_on_send.yml new file mode 100644 index 00000000000..def67cd71b1 --- /dev/null +++ b/.rubocop_todo/internal_affairs/use_restrict_on_send.yml @@ -0,0 +1,13 @@ +--- +InternalAffairs/UseRestrictOnSend: + Details: grace period + Exclude: + - 'rubocop/cop/gitlab/feature_available_usage.rb' + - 'rubocop/cop/migration/add_concurrent_foreign_key.rb' + - 'rubocop/cop/migration/add_concurrent_index.rb' + - 'rubocop/cop/migration/add_timestamps.rb' + - 'rubocop/cop/migration/background_migrations.rb' + - 'rubocop/cop/migration/remove_concurrent_index.rb' + - 'rubocop/cop/migration/with_lock_retries_with_change.rb' + - 'rubocop/cop/project_path_helper.rb' + - 'rubocop/cop/safe_params.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index ca7dba5c8db..be750a04f7c 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -1034,53 +1034,6 @@ Layout/ArgumentAlignment: - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/elastic/migrate/20221124090600_add_namespace_ancestry_ids_to_original_index_mapping_spec.rb' - 'ee/spec/elastic/migrate/20221221110300_backfill_traversal_ids_to_blobs_and_wiki_blobs_spec.rb' - - 'ee/spec/features/account_recovery_regular_check_spec.rb' - - 'ee/spec/features/admin/admin_emails_spec.rb' - - 'ee/spec/features/admin/admin_settings_spec.rb' - - 'ee/spec/features/billings/billing_plans_spec.rb' - - 'ee/spec/features/boards/boards_spec.rb' - - 'ee/spec/features/boards/swimlanes/epics_swimlanes_drag_drop_spec.rb' - - 'ee/spec/features/burndown_charts_spec.rb' - - 'ee/spec/features/dashboards/todos_spec.rb' - - 'ee/spec/features/epic_boards/epic_boards_spec.rb' - - 'ee/spec/features/groups/saml_enforcement_spec.rb' - - 'ee/spec/features/groups/settings/domain_verification_spec.rb' - - 'ee/spec/features/groups/settings/protected_environments_spec.rb' - - 'ee/spec/features/groups/usage_quotas/pipelines_tab_spec.rb' - - 'ee/spec/features/markdown/metrics_spec.rb' - - 'ee/spec/features/merge_request/user_sees_approval_widget_spec.rb' - - 'ee/spec/features/namespace_user_cap_reached_alert_spec.rb' - - 'ee/spec/features/projects/environments/environment_spec.rb' - - 'ee/spec/features/projects/environments/environments_spec.rb' - - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - - 'ee/spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' - - 'ee/spec/features/projects/feature_flags/user_updates_feature_flag_spec.rb' - - 'ee/spec/features/projects/merge_requests/user_edits_merge_request_spec.rb' - - 'ee/spec/features/projects/milestones/milestone_spec.rb' - - 'ee/spec/features/projects/security/user_views_security_configuration_spec.rb' - - 'ee/spec/features/projects/settings/ee/repository_mirrors_settings_spec.rb' - - 'ee/spec/features/projects/settings/merge_requests/user_manages_approval_settings_spec.rb' - - 'ee/spec/features/projects/settings/merge_requests/user_manages_merge_pipelines_spec.rb' - - 'ee/spec/features/projects/settings/merge_requests/user_manages_merge_requests_template_spec.rb' - - 'ee/spec/features/projects/settings/merge_requests/user_manages_merge_trains_spec.rb' - - 'ee/spec/features/projects/settings/user_manages_approval_settings_spec.rb' - - 'ee/spec/features/projects/settings/user_manages_merge_requests_template_spec.rb' - - 'ee/spec/features/registrations/email_confirmation_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_company_creating_project_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_company_joining_project_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_just_me_creating_project_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_just_me_importing_project_spec.rb' - - 'ee/spec/features/registrations/saas/standard_flow_just_me_joining_project_spec.rb' - - 'ee/spec/features/registrations/saas/subscription_flow_paid_plan_spec.rb' - - 'ee/spec/features/registrations/saas/trial_flow_company_creating_project_spec.rb' - - 'ee/spec/features/registrations/saas/trial_flow_company_importing_project_spec.rb' - - 'ee/spec/features/registrations/saas/trial_flow_just_me_creating_project_spec.rb' - - 'ee/spec/features/registrations/saas/trial_flow_just_me_importing_project_spec.rb' - - 'ee/spec/features/registrations/sign_up_with_trial_from_external_site_without_confirmation_spec.rb' - - 'ee/spec/features/search/elastic/global_search_spec.rb' - - 'ee/spec/features/search/elastic/group_search_spec.rb' - - 'ee/spec/features/security/project/discover_spec.rb' - - 'ee/spec/features/users/identity_verification_spec.rb' - 'ee/spec/frontend/fixtures/dora/metrics.rb' - 'ee/spec/frontend/fixtures/oncall_schedule.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' @@ -1143,7 +1096,6 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - 'ee/spec/lib/ee/gitlab/usage/service_ping_report_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - - 'ee/spec/lib/elastic/latest/project_wiki_class_proxy_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/distinct_stage_loader_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/stage_time_summary_spec.rb' @@ -1326,7 +1278,6 @@ Layout/ArgumentAlignment: - 'ee/spec/services/vulnerabilities/user_notes_count_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/vulnerability_merge_request_links/create_service_spec.rb' - - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'lib/api/access_requests.rb' - 'lib/api/admin/plan_limits.rb' - 'lib/api/alert_management_alerts.rb' @@ -1570,70 +1521,8 @@ Layout/ArgumentAlignment: - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/banner_component_preview.rb' - 'spec/components/previews/pajamas/button_component_preview.rb' - - 'spec/features/admin/admin_mode/login_spec.rb' - - 'spec/features/admin/integrations/user_activates_mattermost_slash_command_spec.rb' - - 'spec/features/atom/issues_spec.rb' - - 'spec/features/atom/merge_requests_spec.rb' - - 'spec/features/atom/users_spec.rb' - - 'spec/features/boards/issue_ordering_spec.rb' - - 'spec/features/boards/multi_select_spec.rb' - - 'spec/features/boards/sidebar_assignee_spec.rb' - - 'spec/features/calendar_spec.rb' - - 'spec/features/clusters/cluster_health_dashboard_spec.rb' - - 'spec/features/commits_spec.rb' - - 'spec/features/dashboard/activity_spec.rb' - - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' - - 'spec/features/dashboard/merge_requests_spec.rb' - - 'spec/features/dashboard/todos/todos_sorting_spec.rb' - - 'spec/features/dashboard/todos/todos_spec.rb' - - 'spec/features/error_tracking/user_filters_errors_by_status_spec.rb' - - 'spec/features/error_tracking/user_searches_sentry_errors_spec.rb' - - 'spec/features/error_tracking/user_sees_error_details_spec.rb' - - 'spec/features/error_tracking/user_sees_error_index_spec.rb' - - 'spec/features/groups_spec.rb' - - 'spec/features/help_pages_spec.rb' - - 'spec/features/ics/dashboard_issues_spec.rb' - - 'spec/features/ics/group_issues_spec.rb' - - 'spec/features/ics/project_issues_spec.rb' - - 'spec/features/incidents/incident_timeline_events_spec.rb' - - 'spec/features/incidents/user_views_incident_spec.rb' - - 'spec/features/issuables/issuable_list_spec.rb' - - 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb' - - 'spec/features/issues/user_creates_branch_and_merge_request_spec.rb' - - 'spec/features/issues/user_filters_issues_spec.rb' - 'spec/features/jira_oauth_provider_authorize_spec.rb' - 'spec/features/markdown/gitlab_flavored_markdown_spec.rb' - - 'spec/features/merge_request/maintainer_edits_fork_spec.rb' - - 'spec/features/merge_request/user_allows_commits_from_memebers_who_can_merge_spec.rb' - - 'spec/features/merge_request/user_closes_reopens_merge_request_state_spec.rb' - - 'spec/features/merge_request/user_creates_merge_request_spec.rb' - - 'spec/features/merge_request/user_interacts_with_batched_mr_diffs_spec.rb' - - 'spec/features/merge_request/user_merges_immediately_spec.rb' - - 'spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb' - - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb' - - 'spec/features/merge_request/user_opens_checkout_branch_modal_spec.rb' - - 'spec/features/merge_request/user_posts_notes_spec.rb' - - 'spec/features/merge_request/user_resolves_diff_notes_and_discussions_resolve_spec.rb' - - 'spec/features/merge_request/user_resolves_outdated_diff_discussions_spec.rb' - - 'spec/features/merge_request/user_resolves_wip_mr_spec.rb' - - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb' - - 'spec/features/merge_request/user_sees_discussions_navigation_spec.rb' - - 'spec/features/merge_request/user_sees_merge_button_depending_on_unresolved_discussions_spec.rb' - - 'spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb' - - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' - - 'spec/features/merge_request/user_sees_mr_from_deleted_forked_project_spec.rb' - - 'spec/features/merge_request/user_sees_mr_with_deleted_source_branch_spec.rb' - - 'spec/features/merge_request/user_sees_notes_from_forked_project_spec.rb' - - 'spec/features/merge_request/user_sees_pipelines_from_forked_project_spec.rb' - - 'spec/features/merge_request/user_sees_pipelines_spec.rb' - - 'spec/features/merge_request/user_sees_versions_spec.rb' - - 'spec/features/merge_request/user_selects_branches_for_new_mr_spec.rb' - - 'spec/features/merge_request/user_squashes_merge_request_spec.rb' - - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' - - 'spec/features/merge_request/user_tries_to_access_private_project_info_through_new_mr_spec.rb' - - 'spec/features/merge_request/user_uses_quick_actions_spec.rb' - - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' - - 'spec/features/merge_requests/user_views_open_merge_requests_spec.rb' - 'spec/features/nav/top_nav_tooltip_spec.rb' - 'spec/features/oauth_provider_authorize_spec.rb' - 'spec/features/participants_autocomplete_spec.rb' @@ -1641,45 +1530,6 @@ Layout/ArgumentAlignment: - 'spec/features/profiles/active_sessions_spec.rb' - 'spec/features/profiles/keys_spec.rb' - 'spec/features/profiles/user_changes_notified_of_own_activity_spec.rb' - - 'spec/features/projects/activity/user_sees_activity_spec.rb' - - 'spec/features/projects/badges/coverage_spec.rb' - - 'spec/features/projects/branches/download_buttons_spec.rb' - - 'spec/features/projects/branches_spec.rb' - - 'spec/features/projects/commit/builds_spec.rb' - - 'spec/features/projects/commit/mini_pipeline_graph_spec.rb' - - 'spec/features/projects/commits/user_browses_commits_spec.rb' - - 'spec/features/projects/environments/environment_spec.rb' - - 'spec/features/projects/environments/environments_spec.rb' - - 'spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - - 'spec/features/projects/files/download_buttons_spec.rb' - - 'spec/features/projects/files/editing_a_file_spec.rb' - - 'spec/features/projects/files/project_owner_sees_link_to_create_license_file_in_empty_project_spec.rb' - - 'spec/features/projects/files/user_browses_a_tree_with_a_folder_containing_only_a_folder_spec.rb' - - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' - - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' - - 'spec/features/projects/members/group_member_cannot_request_access_to_his_group_project_spec.rb' - - 'spec/features/projects/members/group_requester_cannot_request_access_to_project_spec.rb' - - 'spec/features/projects/members/user_requests_access_spec.rb' - - 'spec/features/projects/pipelines/pipeline_spec.rb' - - 'spec/features/projects/pipelines/pipelines_spec.rb' - - 'spec/features/projects/releases/user_views_release_spec.rb' - - 'spec/features/projects/settings/external_authorization_service_settings_spec.rb' - - 'spec/features/projects/settings/monitor_settings_spec.rb' - - 'spec/features/projects/settings/registry_settings_cleanup_tags_spec.rb' - - 'spec/features/projects/settings/registry_settings_spec.rb' - - 'spec/features/projects/show/download_buttons_spec.rb' - - 'spec/features/projects/show/user_interacts_with_auto_devops_banner_spec.rb' - - 'spec/features/projects/tags/download_buttons_spec.rb' - - 'spec/features/projects/wiki/user_views_wiki_in_project_page_spec.rb' - - 'spec/features/search/user_searches_for_milestones_spec.rb' - - 'spec/features/search/user_searches_for_wiki_pages_spec.rb' - - 'spec/features/snippets/spam_snippets_spec.rb' - - 'spec/features/snippets/user_creates_snippet_spec.rb' - - 'spec/features/task_lists_spec.rb' - - 'spec/features/user_sees_revert_modal_spec.rb' - - 'spec/features/users/email_verification_on_login_spec.rb' - - 'spec/features/users/login_spec.rb' - - 'spec/features/users/overview_spec.rb' - 'spec/frontend/fixtures/autocomplete.rb' - 'spec/frontend/fixtures/autocomplete_sources.rb' - 'spec/frontend/fixtures/environments.rb' @@ -1906,7 +1756,6 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/usage_data_queries_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/lazy_attributes_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/workhorse_spec.rb' - 'spec/lib/google_api/cloud_platform/client_spec.rb' - 'spec/lib/peek/views/detailed_view_spec.rb' @@ -2046,7 +1895,6 @@ Layout/ArgumentAlignment: - 'spec/requests/recursive_webhook_detection_spec.rb' - 'spec/requests/users/group_callouts_spec.rb' - 'spec/requests/users/project_callouts_spec.rb' - - 'spec/requests/verifies_with_email_spec.rb' - 'spec/routing/environments_spec.rb' - 'spec/routing/group_routing_spec.rb' - 'spec/routing/project_routing_spec.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 435efc1c5b3..698247e419c 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -232,7 +232,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/app/services/ee/ip_restrictions/update_service.rb' - 'ee/app/services/ee/projects/autocomplete_service.rb' - 'ee/app/services/ee/system_notes/issuables_service.rb' - - 'ee/app/services/gitlab_subscriptions/create_trial_or_lead_service.rb' - 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb' - 'ee/app/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service.rb' - 'ee/app/services/group_saml/group_managed_accounts/clean_up_members_service.rb' @@ -290,7 +289,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/features/projects/kerberos_clone_instructions_spec.rb' - 'ee/spec/features/projects/settings/merge_request_approvals_settings_spec.rb' - 'ee/spec/features/projects/settings/merge_requests_settings_spec.rb' - - 'ee/spec/features/trial_registrations/company_information_spec.rb' - 'ee/spec/finders/auth/group_saml_identity_finder_spec.rb' - 'ee/spec/finders/geo/design_registry_finder_spec.rb' - 'ee/spec/finders/geo/project_registry_status_finder_spec.rb' @@ -687,7 +685,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/requests/lfs_http_spec.rb' - 'spec/rubocop/cop/migration/complex_indexes_require_name_spec.rb' - 'spec/rubocop/cop/migration/refer_to_index_by_name_spec.rb' - - 'spec/rubocop/formatter/todo_formatter_spec.rb' - 'spec/scripts/lib/glfm/parse_examples_spec.rb' - 'spec/scripts/lib/glfm/shared_spec.rb' - 'spec/scripts/lib/glfm/update_example_snapshots_spec.rb' diff --git a/.rubocop_todo/layout/extra_spacing.yml b/.rubocop_todo/layout/extra_spacing.yml new file mode 100644 index 00000000000..6da17195834 --- /dev/null +++ b/.rubocop_todo/layout/extra_spacing.yml @@ -0,0 +1,8 @@ +--- +# Cop supports --autocorrect. +Layout/ExtraSpacing: + Details: grace period + Exclude: + - 'ee/spec/requests/api/debian_project_packages_spec.rb' + - 'spec/serializers/admin/abuse_report_details_entity_spec.rb' + - 'spec/services/bulk_imports/create_service_spec.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index c95fc3010d0..5f586cc6206 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -9,7 +9,6 @@ Layout/FirstHashElementIndentation: - 'app/controllers/projects/badges_controller.rb' - 'app/controllers/projects/merge_requests_controller.rb' - 'app/controllers/repositories/lfs_locks_api_controller.rb' - - 'app/experiments/concerns/project_commit_count.rb' - 'app/graphql/mutations/notes/create/diff_note.rb' - 'app/graphql/mutations/notes/create/image_diff_note.rb' - 'app/graphql/mutations/notes/create/note.rb' @@ -98,7 +97,6 @@ Layout/FirstHashElementIndentation: - 'ee/spec/lib/gitlab/ci/reports/coverage_fuzzing/report_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/models/concerns/elastic/issue_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 7a1dd906310..62bf63d1bb9 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -78,7 +78,6 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' - 'ee/lib/ee/gitlab/git_access.rb' - - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - 'ee/lib/tasks/gitlab/geo.rake' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' @@ -102,7 +101,6 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' - - 'ee/spec/lib/ee/gitlab/namespace_storage_size_error_message_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/api_security_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/api_security_latest_gitlab_ci_yaml_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 8c283bdf6ce..ef2e380ea95 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -46,7 +46,6 @@ Layout/LineLength: - 'app/controllers/import/bulk_imports_controller.rb' - 'app/controllers/import/fogbugz_controller.rb' - 'app/controllers/import/gitea_controller.rb' - - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/gitlab_groups_controller.rb' - 'app/controllers/import/gitlab_projects_controller.rb' - 'app/controllers/invites_controller.rb' @@ -77,11 +76,6 @@ Layout/LineLength: - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/jobs_controller.rb' - 'app/controllers/projects/labels_controller.rb' - - 'app/controllers/projects/merge_requests/conflicts_controller.rb' - - 'app/controllers/projects/merge_requests/creations_controller.rb' - - 'app/controllers/projects/merge_requests/diffs_controller.rb' - - 'app/controllers/projects/merge_requests/drafts_controller.rb' - - 'app/controllers/projects/merge_requests_controller.rb' - 'app/controllers/projects/milestones_controller.rb' - 'app/controllers/projects/notes_controller.rb' - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' @@ -91,7 +85,6 @@ Layout/LineLength: - 'app/controllers/projects/settings/ci_cd_controller.rb' - 'app/controllers/projects/settings/repository_controller.rb' - 'app/controllers/projects/templates_controller.rb' - - 'app/controllers/projects/tree_controller.rb' - 'app/controllers/projects/triggers_controller.rb' - 'app/controllers/projects/web_ide_schemas_controller.rb' - 'app/controllers/projects_controller.rb' @@ -106,7 +99,6 @@ Layout/LineLength: - 'app/finders/ci/runners_finder.rb' - 'app/finders/clusters/agents/authorizations/ci_access/finder.rb' - 'app/finders/group_descendants_finder.rb' - - 'app/finders/group_members_finder.rb' - 'app/finders/group_projects_finder.rb' - 'app/finders/issuable_finder.rb' - 'app/finders/issuable_finder/params.rb' @@ -159,7 +151,6 @@ Layout/LineLength: - 'app/graphql/mutations/snippets/update.rb' - 'app/graphql/mutations/todos/create.rb' - 'app/graphql/mutations/todos/mark_all_done.rb' - - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/container_repository_tags_resolver.rb' - 'app/graphql/resolvers/project_merge_requests_resolver.rb' - 'app/graphql/resolvers/user_discussions_count_resolver.rb' @@ -210,7 +201,6 @@ Layout/LineLength: - 'app/graphql/types/query_type.rb' - 'app/graphql/types/repository/blob_type.rb' - 'app/graphql/types/repository_type.rb' - - 'app/graphql/types/root_storage_statistics_type.rb' - 'app/graphql/types/snippets/visibility_scopes_enum.rb' - 'app/graphql/types/todo_action_enum.rb' - 'app/helpers/application_helper.rb' @@ -265,13 +255,11 @@ Layout/LineLength: - 'app/helpers/sorting_helper.rb' - 'app/helpers/ssh_keys_helper.rb' - 'app/helpers/startupjs_helper.rb' - - 'app/helpers/storage_helper.rb' - 'app/helpers/submodule_helper.rb' - 'app/helpers/tags_helper.rb' - 'app/helpers/timeboxes_helper.rb' - 'app/helpers/tree_helper.rb' - 'app/helpers/users_helper.rb' - - 'app/helpers/version_check_helper.rb' - 'app/helpers/visibility_level_helper.rb' - 'app/helpers/whats_new_helper.rb' - 'app/helpers/wiki_helper.rb' @@ -329,17 +317,14 @@ Layout/LineLength: - 'app/models/concerns/packages/debian/distribution.rb' - 'app/models/concerns/packages/debian/distribution_key.rb' - 'app/models/concerns/partitioned_table.rb' - - 'app/models/concerns/protected_ref.rb' - 'app/models/concerns/redis_cacheable.rb' - 'app/models/concerns/restricted_signup.rb' - - 'app/models/concerns/routable.rb' - 'app/models/concerns/shardable.rb' - 'app/models/concerns/sortable.rb' - 'app/models/concerns/storage/legacy_namespace.rb' - 'app/models/concerns/subscribable.rb' - 'app/models/concerns/token_authenticatable_strategies/base.rb' - 'app/models/concerns/token_authenticatable_strategies/encrypted.rb' - - 'app/models/concerns/token_authenticatable_strategies/encryption_helper.rb' - 'app/models/concerns/update_highest_role.rb' - 'app/models/concerns/update_project_statistics.rb' - 'app/models/concerns/x509_serial_number_attribute.rb' @@ -348,7 +333,6 @@ Layout/LineLength: - 'app/models/customer_relations/issue_contact.rb' - 'app/models/deploy_key.rb' - 'app/models/deployment.rb' - - 'app/models/design_management/repository.rb' - 'app/models/diff_note.rb' - 'app/models/environment.rb' - 'app/models/error_tracking/project_error_tracking_setting.rb' @@ -403,7 +387,6 @@ Layout/LineLength: - 'app/models/list.rb' - 'app/models/loose_foreign_keys/modification_tracker.rb' - 'app/models/member.rb' - - 'app/models/members_preloader.rb' - 'app/models/merge_request.rb' - 'app/models/merge_request_assignee.rb' - 'app/models/merge_request_diff.rb' @@ -493,7 +476,6 @@ Layout/LineLength: - 'app/services/ci/create_pipeline_service.rb' - 'app/services/ci/drop_pipeline_service.rb' - 'app/services/ci/generate_coverage_reports_service.rb' - - 'app/services/ci/job_artifacts/destroy_all_expired_service.rb' - 'app/services/ci/job_artifacts/expire_project_build_artifacts_service.rb' - 'app/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service.rb' - 'app/services/ci/pipelines/add_job_service.rb' @@ -506,7 +488,6 @@ Layout/LineLength: - 'app/services/clusters/agents/delete_service.rb' - 'app/services/clusters/build_kubernetes_namespace_service.rb' - 'app/services/clusters/integrations/create_service.rb' - - 'app/services/clusters/integrations/prometheus_health_check_service.rb' - 'app/services/clusters/kubernetes/create_or_update_service_account_service.rb' - 'app/services/clusters/management/validate_management_project_permissions_service.rb' - 'app/services/compare_service.rb' @@ -528,9 +509,7 @@ Layout/LineLength: - 'app/services/emails/create_service.rb' - 'app/services/environments/reset_auto_stop_service.rb' - 'app/services/environments/schedule_to_delete_review_apps_service.rb' - - 'app/services/event_create_service.rb' - 'app/services/feature_flags/update_service.rb' - - 'app/services/git/branch_hooks_service.rb' - 'app/services/git/process_ref_changes_service.rb' - 'app/services/google_cloud/create_service_accounts_service.rb' - 'app/services/google_cloud/generate_pipeline_service.rb' @@ -564,7 +543,6 @@ Layout/LineLength: - 'app/services/lfs/unlock_file_service.rb' - 'app/services/loose_foreign_keys/batch_cleaner_service.rb' - 'app/services/loose_foreign_keys/cleaner_service.rb' - - 'app/services/members/destroy_service.rb' - 'app/services/members/invitation_reminder_email_service.rb' - 'app/services/merge_requests/add_context_service.rb' - 'app/services/merge_requests/assign_issues_service.rb' @@ -585,7 +563,6 @@ Layout/LineLength: - 'app/services/milestones/destroy_service.rb' - 'app/services/namespace_settings/update_service.rb' - 'app/services/notes/build_service.rb' - - 'app/services/notes/quick_actions_service.rb' - 'app/services/notes/resolve_service.rb' - 'app/services/notification_recipients/builder/default.rb' - 'app/services/notification_service.rb' @@ -623,7 +600,6 @@ Layout/LineLength: - 'app/services/projects/hashed_storage/migrate_attachments_service.rb' - 'app/services/projects/hashed_storage/migrate_repository_service.rb' - 'app/services/projects/hashed_storage/rollback_repository_service.rb' - - 'app/services/projects/import_service.rb' - 'app/services/projects/lfs_pointers/lfs_download_service.rb' - 'app/services/projects/operations/update_service.rb' - 'app/services/projects/overwrite_project_service.rb' @@ -636,7 +612,6 @@ Layout/LineLength: - 'app/services/repository_archive_clean_up_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - 'app/services/resource_access_tokens/revoke_service.rb' - - 'app/services/search/global_service.rb' - 'app/services/search_service.rb' - 'app/services/security/ci_configuration/container_scanning_create_service.rb' - 'app/services/security/ci_configuration/dependency_scanning_create_service.rb' @@ -680,8 +655,6 @@ Layout/LineLength: - 'app/workers/container_registry/migration/guard_worker.rb' - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/error_tracking_issue_link_worker.rb' - - 'app/workers/gitlab/github_import/stage/finish_import_worker.rb' - - 'app/workers/gitlab/github_import/stage/import_repository_worker.rb' - 'app/workers/gitlab/import/stuck_import_job.rb' - 'app/workers/gitlab/jira_import/stage/import_attachments_worker.rb' - 'app/workers/gitlab/jira_import/stage/import_labels_worker.rb' @@ -691,13 +664,11 @@ Layout/LineLength: - 'app/workers/issues/rebalancing_worker.rb' - 'app/workers/jira_connect/sync_branch_worker.rb' - 'app/workers/jira_connect/sync_merge_request_worker.rb' - - 'app/workers/jira_connect/sync_project_worker.rb' - 'app/workers/merge_request_mergeability_check_worker.rb' - 'app/workers/object_storage/migrate_uploads_worker.rb' - 'app/workers/packages/maven/metadata/sync_worker.rb' - 'app/workers/pipeline_metrics_worker.rb' - 'app/workers/repository_fork_worker.rb' - - 'app/workers/repository_import_worker.rb' - 'app/workers/ssh_keys/expired_notification_worker.rb' - 'config/application.rb' - 'config/initializers/00_rails_disable_joins.rb' @@ -723,7 +694,6 @@ Layout/LineLength: - 'config/initializers/validate_database_config.rb' - 'config/initializers/validate_puma.rb' - 'config/initializers/zz_metrics.rb' - - 'config/object_store_settings.rb' - 'config/puma.rb' - 'config/routes.rb' - 'config/routes/admin.rb' @@ -742,14 +712,6 @@ Layout/LineLength: - 'danger/roulette/Dangerfile' - 'danger/vue_shared_documentation/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20220314184209_add_group_fk_to_protected_environment_approval_rules.rb' - - 'db/migrate/20220314204009_add_approval_rule_fk_to_deployment_approvals.rb' - - 'db/post_migrate/20220315171027_add_tmp_index_to_support_leaky_regex_cleanup.rb' - - 'db/post_migrate/20220316102902_add_user_foreign_key_to_deploy_tokens.rb' - - 'db/post_migrate/20220317161914_remove_ci_runners_ci_builds_runner_id_fk.rb' - - 'db/post_migrate/20220318111729_cleanup_after_fixing_issue_when_admin_changed_primary_email.rb' - - 'db/post_migrate/20220322205008_change_search_rate_limit_values.rb' - - 'db/post_migrate/20220323130000_add_temp_index_on_null_project_namespace_ids.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/projects_controller.rb' @@ -786,7 +748,6 @@ Layout/LineLength: - 'ee/app/controllers/projects/requirements_management/requirements_controller.rb' - 'ee/app/controllers/projects/security/policies_controller.rb' - 'ee/app/controllers/projects/security/vulnerabilities/notes_controller.rb' - - 'ee/app/controllers/subscriptions_controller.rb' - 'ee/app/enums/vulnerabilities/dismissal_reason_enum.rb' - 'ee/app/finders/compliance_management/merge_requests/compliance_violations_finder.rb' - 'ee/app/finders/incident_management/escalation_rules_finder.rb' @@ -878,7 +839,6 @@ Layout/LineLength: - 'ee/app/helpers/billing_plans_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/button_helper.rb' - - 'ee/app/helpers/ee/feature_flags_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' @@ -1000,7 +960,6 @@ Layout/LineLength: - 'ee/app/models/vulnerabilities/read.rb' - 'ee/app/models/vulnerabilities/remediation.rb' - 'ee/app/models/vulnerabilities/scanner.rb' - - 'ee/app/models/vulnerabilities/stat_diff.rb' - 'ee/app/policies/ee/group_policy.rb' - 'ee/app/policies/ee/identity_provider_policy.rb' - 'ee/app/policies/ee/project_policy.rb' @@ -1011,7 +970,6 @@ Layout/LineLength: - 'ee/app/serializers/ee/merge_request_poll_widget_entity.rb' - 'ee/app/serializers/ee/merge_request_user_entity.rb' - 'ee/app/serializers/ee/merge_request_widget_entity.rb' - - 'ee/app/serializers/ee/note_user_entity.rb' - 'ee/app/serializers/ee/user_entity.rb' - 'ee/app/serializers/vulnerabilities/feedback_entity.rb' - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' @@ -1039,7 +997,6 @@ Layout/LineLength: - 'ee/app/services/boards/epics/move_service.rb' - 'ee/app/services/ci/compare_security_reports_service.rb' - 'ee/app/services/ci/minutes/track_live_consumption_service.rb' - - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' - 'ee/app/services/compliance_management/frameworks/create_service.rb' - 'ee/app/services/compliance_management/merge_requests/create_compliance_violations_service.rb' - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' @@ -1055,7 +1012,6 @@ Layout/LineLength: - 'ee/app/services/ee/ci/register_job_service.rb' - 'ee/app/services/ee/ci/retry_pipeline_service.rb' - 'ee/app/services/ee/groups/autocomplete_service.rb' - - 'ee/app/services/ee/groups/create_service.rb' - 'ee/app/services/ee/groups/deploy_tokens/create_service.rb' - 'ee/app/services/ee/groups/deploy_tokens/destroy_service.rb' - 'ee/app/services/ee/groups/deploy_tokens/revoke_service.rb' @@ -1133,7 +1089,6 @@ Layout/LineLength: - 'ee/app/services/security/report_summary_service.rb' - 'ee/app/services/security/scanned_resources_counting_service.rb' - 'ee/app/services/security/scanned_resources_service.rb' - - 'ee/app/services/security/security_orchestration_policies/fetch_policy_approvers_service.rb' - 'ee/app/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service.rb' - 'ee/app/services/security/security_orchestration_policies/policy_commit_service.rb' - 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb' @@ -1146,7 +1101,6 @@ Layout/LineLength: - 'ee/app/services/start_pull_mirroring_service.rb' - 'ee/app/services/system_notes/escalations_service.rb' - 'ee/app/services/timebox_report_service.rb' - - 'ee/app/services/vulnerabilities/base_service.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/revert_to_detected_service.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' @@ -1169,7 +1123,6 @@ Layout/LineLength: - 'ee/app/workers/geo/batch/project_registry_scheduler_worker.rb' - 'ee/app/workers/geo/batch/project_registry_worker.rb' - 'ee/app/workers/geo/destroy_worker.rb' - - 'ee/app/workers/geo/file_registry_removal_worker.rb' - 'ee/app/workers/geo/repositories_clean_up_worker.rb' - 'ee/app/workers/geo/repository_shard_sync_worker.rb' - 'ee/app/workers/geo/repository_verification/secondary/shard_worker.rb' @@ -1228,7 +1181,6 @@ Layout/LineLength: - 'ee/lib/api/resource_iteration_events.rb' - 'ee/lib/api/status_checks.rb' - 'ee/lib/api/vulnerability_issue_links.rb' - - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/api/deployments.rb' - 'ee/lib/ee/api/entities/application_setting.rb' - 'ee/lib/ee/api/entities/dependency.rb' @@ -1239,8 +1191,6 @@ Layout/LineLength: - 'ee/lib/ee/api/entities/namespace.rb' - 'ee/lib/ee/api/entities/project.rb' - 'ee/lib/ee/api/entities/project_approval_rule.rb' - - 'ee/lib/ee/api/entities/user_basic.rb' - - 'ee/lib/ee/api/entities/user_path.rb' - 'ee/lib/ee/api/geo.rb' - 'ee/lib/ee/api/helpers/groups_helpers.rb' - 'ee/lib/ee/api/helpers/issues_helpers.rb' @@ -1308,7 +1258,6 @@ Layout/LineLength: - 'ee/lib/gitlab/analytics/cycle_analytics/summary/base_time.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/group/deployment_frequency.rb' - 'ee/lib/gitlab/auth/group_saml/response_check.rb' - - 'ee/lib/gitlab/auth/group_saml/session_enforcer.rb' - 'ee/lib/gitlab/auth/group_saml/user.rb' - 'ee/lib/gitlab/auth/group_saml/xml_response.rb' - 'ee/lib/gitlab/authority_analyzer.rb' @@ -1346,7 +1295,6 @@ Layout/LineLength: - 'ee/lib/gitlab/status_page/storage/s3_client.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/approval_project_rules_with_user_metric.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/count_ci_builds_metric.rb' - - 'ee/lib/gitlab/usage/metrics/instrumentations/count_users_creating_ci_builds_metric.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' - 'ee/lib/gitlab/usage_data_counters/license_testing_counter.rb' - 'ee/lib/system_check/geo/authorized_keys_check.rb' @@ -1354,11 +1302,9 @@ Layout/LineLength: - 'ee/lib/system_check/geo/geo_database_configured_check.rb' - 'ee/lib/tasks/geo.rake' - 'ee/lib/tasks/geo/git.rake' - - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/lib/tasks/gitlab/elastic/test.rake' - 'ee/lib/tasks/gitlab/seed/metrics.rake' - 'ee/lib/world.rb' - - 'ee/spec/config/metrics/every_metric_definition_spec.rb' - 'ee/spec/controllers/admin/elasticsearch_controller_spec.rb' - 'ee/spec/controllers/admin/geo/projects_controller_spec.rb' - 'ee/spec/controllers/admin/impersonations_controller_spec.rb' @@ -1401,7 +1347,6 @@ Layout/LineLength: - 'ee/spec/controllers/projects/subscriptions_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/subscriptions/groups_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/factories/ci/builds.rb' @@ -1492,7 +1437,6 @@ Layout/LineLength: - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - 'ee/spec/features/projects/settings/issues_settings_spec.rb' - 'ee/spec/features/projects/settings/merge_requests_settings_spec.rb' - - 'ee/spec/features/projects/settings/protected_environments_spec.rb' - 'ee/spec/features/projects/user_applies_custom_file_template_spec.rb' - 'ee/spec/features/projects_spec.rb' - 'ee/spec/features/promotion_spec.rb' @@ -1500,7 +1444,6 @@ Layout/LineLength: - 'ee/spec/features/search/elastic/project_search_spec.rb' - 'ee/spec/features/search/elastic/snippet_search_spec.rb' - 'ee/spec/features/subscriptions_spec.rb' - - 'ee/spec/features/trial_registrations/company_information_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/finders/analytics/devops_adoption/enabled_namespaces_finder_spec.rb' - 'ee/spec/finders/analytics/devops_adoption/snapshots_finder_spec.rb' @@ -1552,7 +1495,6 @@ Layout/LineLength: - 'ee/spec/graphql/ee/types/board_type_spec.rb' - 'ee/spec/graphql/ee/types/issue_sort_enum_spec.rb' - 'ee/spec/graphql/ee/types/merge_request_type_spec.rb' - - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - 'ee/spec/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb' @@ -1601,7 +1543,6 @@ Layout/LineLength: - 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb' - 'ee/spec/graphql/resolvers/timebox_report_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities/details_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/vulnerabilities/issue_links_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities/scanners_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_count_per_day_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' @@ -1614,7 +1555,6 @@ Layout/LineLength: - 'ee/spec/graphql/types/epic_sort_enum_spec.rb' - 'ee/spec/graphql/types/incident_management/escalation_rule_input_type_spec.rb' - 'ee/spec/graphql/types/issue_type_spec.rb' - - 'ee/spec/graphql/types/permission_types/vulnerability_spec.rb' - 'ee/spec/graphql/types/project_type_spec.rb' - 'ee/spec/graphql/types/security_scanner_type_enum_spec.rb' - 'ee/spec/graphql/types/vulnerability_details/file_location_type_spec.rb' @@ -1637,7 +1577,6 @@ Layout/LineLength: - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - - 'ee/spec/helpers/ee/issuables_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' - 'ee/spec/helpers/ee/lock_helper_spec.rb' - 'ee/spec/helpers/ee/operations_helper_spec.rb' @@ -1647,7 +1586,6 @@ Layout/LineLength: - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - - 'ee/spec/helpers/ee/version_check_helper_spec.rb' - 'ee/spec/helpers/epics_helper_spec.rb' - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' - 'ee/spec/helpers/groups/security_features_helper_spec.rb' @@ -1686,8 +1624,6 @@ Layout/LineLength: - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' @@ -1696,7 +1632,6 @@ Layout/LineLength: - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/reports/security/reports_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/status/build/manual_spec.rb' - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' @@ -1707,7 +1642,6 @@ Layout/LineLength: - 'ee/spec/lib/ee/gitlab/import_export/wiki_repo_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/repo_path_spec.rb' - 'ee/spec/lib/ee/gitlab/repository_size_checker_spec.rb' - - 'ee/spec/lib/ee/gitlab/security/scan_configuration_spec.rb' - 'ee/spec/lib/ee/gitlab/url_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/usage/service_ping/payload_keys_processor_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_counters/hll_redis_counter_spec.rb' @@ -1728,7 +1662,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_for_duration_chart_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/distinct_stage_loader_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_first_associated_with_milestone_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_label_added_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_label_removed_spec.rb' @@ -1822,7 +1755,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/status_page/filter/image_filter_spec.rb' - 'ee/spec/lib/gitlab/status_page/filter/mention_anonymization_filter_spec.rb' - 'ee/spec/lib/gitlab/status_page/storage/s3_multipart_upload_spec.rb' - - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/approval_project_rules_with_user_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_ci_builds_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_distinct_merged_merge_requests_using_approval_rules_metric_spec.rb' @@ -1906,7 +1838,6 @@ Layout/LineLength: - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/models/ee/lfs_object_spec.rb' - 'ee/spec/models/ee/merge_request_diff_spec.rb' - - 'ee/spec/models/ee/namespace/root_storage_statistics_spec.rb' - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/ee/namespace_statistics_spec.rb' - 'ee/spec/models/ee/preloaders/group_policy_preloader_spec.rb' @@ -1954,7 +1885,6 @@ Layout/LineLength: - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/project_member_spec.rb' - 'ee/spec/models/project_security_setting_spec.rb' - - 'ee/spec/models/protected_branch/unprotect_access_level_spec.rb' - 'ee/spec/models/protected_environment_spec.rb' - 'ee/spec/models/protected_environments/approval_rule_spec.rb' - 'ee/spec/models/release_highlight_spec.rb' @@ -2093,7 +2023,6 @@ Layout/LineLength: - 'ee/spec/requests/api/ldap_group_links_spec.rb' - 'ee/spec/requests/api/license_spec.rb' - 'ee/spec/requests/api/members_spec.rb' - - 'ee/spec/requests/api/merge_request_approval_rules_spec.rb' - 'ee/spec/requests/api/merge_request_approvals_spec.rb' - 'ee/spec/requests/api/merge_requests_spec.rb' - 'ee/spec/requests/api/namespaces_spec.rb' @@ -2255,7 +2184,6 @@ Layout/LineLength: - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - 'ee/spec/services/geo/hashed_storage_attachments_event_store_spec.rb' - 'ee/spec/services/geo/hashed_storage_migration_service_spec.rb' - - 'ee/spec/services/geo/metrics_update_service_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' - 'ee/spec/services/geo/rename_repository_service_spec.rb' - 'ee/spec/services/geo/repository_destroy_service_spec.rb' @@ -2357,7 +2285,6 @@ Layout/LineLength: - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/user_permissions/export_service_spec.rb' - 'ee/spec/services/vulnerabilities/dismiss_service_spec.rb' - - 'ee/spec/services/vulnerabilities/finding_dismiss_service_spec.rb' - 'ee/spec/services/vulnerabilities/historical_statistics/adjustment_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'ee/spec/services/vulnerabilities/revert_to_detected_service_spec.rb' @@ -2371,9 +2298,7 @@ Layout/LineLength: - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/destroy_service_spec.rb' - 'ee/spec/services/vulnerability_scanners/list_service_spec.rb' - - 'ee/spec/services/wiki_pages/create_service_spec.rb' - 'ee/spec/services/wiki_pages/destroy_service_spec.rb' - - 'ee/spec/services/wiki_pages/update_service_spec.rb' - 'ee/spec/support/features/redacted_search_results_examples.rb' - 'ee/spec/support/helpers/search_results_helpers.rb' - 'ee/spec/support/helpers/subscription_portal_helpers.rb' @@ -2389,7 +2314,6 @@ Layout/LineLength: - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/features/epics_filtered_search_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - 'ee/spec/support/shared_examples/features/sidebar_shared_examples.rb' - 'ee/spec/support/shared_examples/finders/geo/file_registry_finder_shared_examples.rb' - 'ee/spec/support/shared_examples/finders/geo/registry_finder_shared_examples.rb' @@ -2457,7 +2381,6 @@ Layout/LineLength: - 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - 'ee/spec/workers/elastic_association_indexer_worker_spec.rb' - - 'ee/spec/workers/elastic_commit_indexer_worker_spec.rb' - 'ee/spec/workers/geo/batch/project_registry_scheduler_worker_spec.rb' - 'ee/spec/workers/geo/destroy_worker_spec.rb' - 'ee/spec/workers/geo/project_sync_worker_spec.rb' @@ -2480,7 +2403,6 @@ Layout/LineLength: - 'ee/spec/workers/iterations_update_status_worker_spec.rb' - 'ee/spec/workers/merge_request_reset_approvals_worker_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - - 'ee/spec/workers/refresh_license_compliance_checks_worker_spec.rb' - 'ee/spec/workers/repository_import_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb' @@ -2508,7 +2430,6 @@ Layout/LineLength: - 'lib/api/concerns/packages/conan_endpoints.rb' - 'lib/api/concerns/packages/debian_distribution_endpoints.rb' - 'lib/api/concerns/packages/debian_package_endpoints.rb' - - 'lib/api/concerns/packages/nuget_endpoints.rb' - 'lib/api/debian_group_packages.rb' - 'lib/api/debian_project_packages.rb' - 'lib/api/deploy_keys.rb' @@ -2556,7 +2477,6 @@ Layout/LineLength: - 'lib/api/internal/base.rb' - 'lib/api/internal/kubernetes.rb' - 'lib/api/internal/mail_room.rb' - - 'lib/api/internal/pages.rb' - 'lib/api/invitations.rb' - 'lib/api/issues.rb' - 'lib/api/lint.rb' @@ -2601,7 +2521,6 @@ Layout/LineLength: - 'lib/api/templates.rb' - 'lib/api/terraform/modules/v1/packages.rb' - 'lib/api/terraform/state.rb' - - 'lib/api/time_tracking_endpoints.rb' - 'lib/api/todos.rb' - 'lib/api/users.rb' - 'lib/api/wikis.rb' @@ -2612,7 +2531,6 @@ Layout/LineLength: - 'lib/backup/gitaly_backup.rb' - 'lib/backup/manager.rb' - 'lib/banzai/filter/autolink_filter.rb' - - 'lib/banzai/filter/inline_diff_filter.rb' - 'lib/banzai/filter/markdown_post_escape_filter.rb' - 'lib/banzai/filter/references/external_issue_reference_filter.rb' - 'lib/banzai/filter/references/issue_reference_filter.rb' @@ -2645,7 +2563,6 @@ Layout/LineLength: - 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb' - 'lib/gitlab/analytics/cycle_analytics/aggregated/stage_query_helpers.rb' - 'lib/gitlab/analytics/cycle_analytics/base_query_builder.rb' - - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_events.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_events/issue_deployed_to_production.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_events/issue_stage_end.rb' @@ -2660,7 +2577,6 @@ Layout/LineLength: - 'lib/gitlab/auth/ldap/adapter.rb' - 'lib/gitlab/auth/ldap/dn.rb' - 'lib/gitlab/auth/ldap/person.rb' - - 'lib/gitlab/auth/o_auth/session.rb' - 'lib/gitlab/auth/o_auth/user.rb' - 'lib/gitlab/auth/saml/auth_hash.rb' - 'lib/gitlab/auth/user_access_denied_reason.rb' @@ -2678,7 +2594,6 @@ Layout/LineLength: - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/bitbucket_import/importer.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/buffered_io.rb' @@ -2722,7 +2637,6 @@ Layout/LineLength: - 'lib/gitlab/ci/runner_releases.rb' - 'lib/gitlab/ci/runner_upgrade_check.rb' - 'lib/gitlab/ci/status/build/manual.rb' - - 'lib/gitlab/ci/status/build/waiting_for_approval.rb' - 'lib/gitlab/ci/variables/builder.rb' - 'lib/gitlab/cleanup/project_uploads.rb' - 'lib/gitlab/composer/version_index.rb' @@ -2770,7 +2684,6 @@ Layout/LineLength: - 'lib/gitlab/database/similarity_score.rb' - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/database/with_lock_retries_outside_transaction.rb' - - 'lib/gitlab/database_importers/instance_administrators/create_group.rb' - 'lib/gitlab/dependency_linker/base_linker.rb' - 'lib/gitlab/dependency_linker/go_mod_linker.rb' - 'lib/gitlab/dependency_linker/go_sum_linker.rb' @@ -2844,7 +2757,6 @@ Layout/LineLength: - 'lib/gitlab/import_export/base/object_builder.rb' - 'lib/gitlab/import_export/base/relation_factory.rb' - 'lib/gitlab/import_export/base/relation_object_saver.rb' - - 'lib/gitlab/import_export/file_importer.rb' - 'lib/gitlab/import_export/group/relation_tree_restorer.rb' - 'lib/gitlab/import_export/importer.rb' - 'lib/gitlab/import_export/json/streaming_serializer.rb' @@ -2856,7 +2768,6 @@ Layout/LineLength: - 'lib/gitlab/import_export/snippet_repo_restorer.rb' - 'lib/gitlab/import_export/version_checker.rb' - 'lib/gitlab/instrumentation/redis_base.rb' - - 'lib/gitlab/instrumentation_helper.rb' - 'lib/gitlab/issues/rebalancing/state.rb' - 'lib/gitlab/jira/http_client.rb' - 'lib/gitlab/jira_import.rb' @@ -2909,9 +2820,7 @@ Layout/LineLength: - 'lib/gitlab/quick_actions/issue_actions.rb' - 'lib/gitlab/quick_actions/issue_and_merge_request_actions.rb' - 'lib/gitlab/quick_actions/merge_request_actions.rb' - - 'lib/gitlab/quick_actions/relate_actions.rb' - 'lib/gitlab/rack_attack.rb' - - 'lib/gitlab/redis/wrapper.rb' - 'lib/gitlab/regex.rb' - 'lib/gitlab/relative_positioning/item_context.rb' - 'lib/gitlab/repository_size_error_message.rb' @@ -2955,9 +2864,7 @@ Layout/LineLength: - 'lib/gitlab/utils/override.rb' - 'lib/gitlab/utils/usage_data.rb' - 'lib/gitlab/webpack/manifest.rb' - - 'lib/gitlab/wiki_pages/front_matter_parser.rb' - 'lib/gitlab/word_diff/parser.rb' - - 'lib/gitlab/x509/tag.rb' - 'lib/google_api/cloud_platform/client.rb' - 'lib/peek/views/memory.rb' - 'lib/quality/seeders/issues.rb' @@ -2997,7 +2904,6 @@ Layout/LineLength: - 'lib/tasks/migrate/schema_check.rake' - 'lib/tasks/tanuki_emoji.rake' - 'lib/tasks/test.rake' - - 'lib/uploaded_file.rb' - 'qa/qa/ee/page/group/secure/show.rb' - 'qa/qa/ee/page/group/settings/general.rb' - 'qa/qa/ee/page/group/settings/saml_sso.rb' @@ -3018,7 +2924,6 @@ Layout/LineLength: - 'qa/qa/page/project/registry/show.rb' - 'qa/qa/page/project/settings/protected_branches.rb' - 'qa/qa/page/project/web_ide/edit.rb' - - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/file.rb' - 'qa/qa/resource/protected_branch.rb' - 'qa/qa/resource/registry_repository.rb' @@ -3045,14 +2950,12 @@ Layout/LineLength: - 'qa/qa/specs/features/api/3_create/repository/push_postreceive_idempotent_spec.rb' - 'qa/qa/specs/features/api/3_create/snippet/snippet_repository_storage_move_spec.rb' - 'qa/qa/specs/features/api/4_verify/cancel_pipeline_when_block_user_spec.rb' - - 'qa/qa/specs/features/api/5_package/container_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/group/create_group_with_mattermost_team_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_into_gitlab_via_ldap_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/login/maintain_log_in_mixed_env_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb' @@ -3103,13 +3006,10 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pass_dotenv_variables_to_downstream_via_bridge_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_branch_switcher_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/trigger_matrix_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/update_ci_file_with_pipeline_editor_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/runner/register_runner_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/testing/view_code_coverage_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/container_registry/online_garbage_collection_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/conan_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb' @@ -3153,9 +3053,7 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/default_merge_request_template_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/assign_code_owners_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_with_protected_branch_and_squashed_commits_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_root_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_subgroup_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_http_spec.rb' @@ -3165,7 +3063,6 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/transient/merge_trains_transient_bug_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/5_package/dependency_proxy_sso_spec.rb' - - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - 'qa/qa/support/run.rb' - 'qa/qa/support/ssh.rb' @@ -3201,7 +3098,6 @@ Layout/LineLength: - 'scripts/api/cancel_pipeline.rb' - 'scripts/api/get_job_id.rb' - 'scripts/changed-feature-flags' - - 'scripts/flaky_examples/prune-old-flaky-examples' - 'scripts/lint_templates_bash.rb' - 'scripts/no-dir-check' - 'scripts/perf/query_limiting_report.rb' @@ -3223,14 +3119,12 @@ Layout/LineLength: - 'spec/controllers/concerns/check_rate_limit_spec.rb' - 'spec/controllers/concerns/confirm_email_warning_spec.rb' - 'spec/controllers/concerns/metrics_dashboard_spec.rb' - - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' - 'spec/controllers/concerns/send_file_upload_spec.rb' - 'spec/controllers/concerns/sourcegraph_decorator_spec.rb' - 'spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb' - 'spec/controllers/concerns/static_object_external_storage_spec.rb' - 'spec/controllers/dashboard/milestones_controller_spec.rb' - 'spec/controllers/dashboard/projects_controller_spec.rb' - - 'spec/controllers/every_controller_spec.rb' - 'spec/controllers/explore/projects_controller_spec.rb' - 'spec/controllers/groups/children_controller_spec.rb' - 'spec/controllers/groups/clusters_controller_spec.rb' @@ -3239,7 +3133,6 @@ Layout/LineLength: - 'spec/controllers/groups/milestones_controller_spec.rb' - 'spec/controllers/groups/releases_controller_spec.rb' - 'spec/controllers/groups/settings/applications_controller_spec.rb' - - 'spec/controllers/groups/settings/integrations_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/import/bitbucket_controller_spec.rb' - 'spec/controllers/import/bitbucket_server_controller_spec.rb' @@ -3254,7 +3147,6 @@ Layout/LineLength: - 'spec/controllers/passwords_controller_spec.rb' - 'spec/controllers/profiles/accounts_controller_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' - - 'spec/controllers/profiles/webauthn_registrations_controller_spec.rb' - 'spec/controllers/profiles_controller_spec.rb' - 'spec/controllers/projects/alerting/notifications_controller_spec.rb' - 'spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' @@ -3294,7 +3186,6 @@ Layout/LineLength: - 'spec/controllers/projects/registry/tags_controller_spec.rb' - 'spec/controllers/projects/repositories_controller_spec.rb' - 'spec/controllers/projects/runners_controller_spec.rb' - - 'spec/controllers/projects/service_desk_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects/settings/operations_controller_spec.rb' - 'spec/controllers/projects/settings/repository_controller_spec.rb' @@ -3312,7 +3203,6 @@ Layout/LineLength: - 'spec/controllers/uploads_controller_spec.rb' - 'spec/db/schema_spec.rb' - 'spec/deprecation_toolkit_env.rb' - - 'spec/experiments/concerns/project_commit_count_spec.rb' - 'spec/factories/ci/job_artifacts.rb' - 'spec/factories/ci/pipelines.rb' - 'spec/factories/ci/reports/codequality_degradations.rb' @@ -3356,7 +3246,6 @@ Layout/LineLength: - 'spec/features/commits_spec.rb' - 'spec/features/contextual_sidebar_spec.rb' - 'spec/features/cycle_analytics_spec.rb' - - 'spec/features/dashboard/issues_spec.rb' - 'spec/features/dashboard/projects_spec.rb' - 'spec/features/dashboard/todos/todos_spec.rb' - 'spec/features/dashboard/user_filters_projects_spec.rb' @@ -3406,7 +3295,6 @@ Layout/LineLength: - 'spec/features/labels_hierarchy_spec.rb' - 'spec/features/markdown/copy_as_gfm_spec.rb' - 'spec/features/markdown/gitlab_flavored_markdown_spec.rb' - - 'spec/features/markdown/metrics_spec.rb' - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/user_accepts_merge_request_spec.rb' - 'spec/features/merge_request/user_allows_commits_from_memebers_who_can_merge_spec.rb' @@ -3506,7 +3394,6 @@ Layout/LineLength: - 'spec/features/projects/settings/access_tokens_spec.rb' - 'spec/features/projects/settings/project_settings_spec.rb' - 'spec/features/projects/settings/registry_settings_spec.rb' - - 'spec/features/projects/settings/service_desk_setting_spec.rb' - 'spec/features/projects/settings/user_manages_merge_requests_settings_spec.rb' - 'spec/features/projects/settings/user_renames_a_project_spec.rb' - 'spec/features/projects/settings/visibility_settings_spec.rb' @@ -3551,7 +3438,6 @@ Layout/LineLength: - 'spec/finders/environments/environments_by_deployments_finder_spec.rb' - 'spec/finders/environments/environments_finder_spec.rb' - 'spec/finders/events_finder_spec.rb' - - 'spec/finders/fork_targets_finder_spec.rb' - 'spec/finders/group_descendants_finder_spec.rb' - 'spec/finders/group_members_finder_spec.rb' - 'spec/finders/group_projects_finder_spec.rb' @@ -3693,7 +3579,6 @@ Layout/LineLength: - 'spec/helpers/environments_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/external_link_helper_spec.rb' - - 'spec/helpers/feature_flags_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/gitlab_script_tag_helper_spec.rb' - 'spec/helpers/groups/group_members_helper_spec.rb' @@ -3764,9 +3649,7 @@ Layout/LineLength: - 'spec/lib/banzai/filter/external_link_filter_spec.rb' - 'spec/lib/banzai/filter/gollum_tags_filter_spec.rb' - 'spec/lib/banzai/filter/image_link_filter_spec.rb' - - 'spec/lib/banzai/filter/inline_alert_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/inline_diff_filter_spec.rb' - - 'spec/lib/banzai/filter/inline_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/kroki_filter_spec.rb' - 'spec/lib/banzai/filter/math_filter_spec.rb' - 'spec/lib/banzai/filter/mermaid_filter_spec.rb' @@ -3852,22 +3735,11 @@ Layout/LineLength: - 'spec/lib/gitlab/auth/user_access_denied_reason_spec.rb' - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/authorized_keys_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_member_namespace_for_group_members_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_duplicate_project_name_and_path_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_container_repository_migration_plan_spec.rb' - - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' @@ -3885,13 +3757,11 @@ Layout/LineLength: - 'spec/lib/gitlab/ci/badge/coverage/report_spec.rb' - 'spec/lib/gitlab/ci/build/releaser_spec.rb' - 'spec/lib/gitlab/ci/build/step_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/cache_spec.rb' - 'spec/lib/gitlab/ci/config/entry/environment_spec.rb' - 'spec/lib/gitlab/ci/config/entry/reports_spec.rb' - 'spec/lib/gitlab/ci/config/entry/root_spec.rb' - 'spec/lib/gitlab/ci/config/entry/services_spec.rb' - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' - - 'spec/lib/gitlab/ci/config/external/file/base_spec.rb' - 'spec/lib/gitlab/ci/config/external/file/local_spec.rb' - 'spec/lib/gitlab/ci/config/external/file/project_spec.rb' - 'spec/lib/gitlab/ci/config/external/file/remote_spec.rb' @@ -3922,7 +3792,6 @@ Layout/LineLength: - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb' - 'spec/lib/gitlab/ci/status/build/manual_spec.rb' - - 'spec/lib/gitlab/ci/status/build/waiting_for_approval_spec.rb' - 'spec/lib/gitlab/ci/status/stage/play_manual_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/deploy_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' @@ -4186,7 +4055,6 @@ Layout/LineLength: - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/compressor_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - 'spec/lib/gitlab/slash_commands/presenters/issue_new_spec.rb' - 'spec/lib/gitlab/spamcheck/client_spec.rb' - 'spec/lib/gitlab/sql/pattern_spec.rb' @@ -4194,6 +4062,7 @@ Layout/LineLength: - 'spec/lib/gitlab/string_range_marker_spec.rb' - 'spec/lib/gitlab/string_regex_marker_spec.rb' - 'spec/lib/gitlab/suggestions/commit_message_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/lib/gitlab/template/issue_template_spec.rb' - 'spec/lib/gitlab/template/merge_request_template_spec.rb' - 'spec/lib/gitlab/throttle_spec.rb' @@ -4231,7 +4100,6 @@ Layout/LineLength: - 'spec/lib/gitlab/utils/measuring_spec.rb' - 'spec/lib/gitlab/utils/nokogiri_spec.rb' - 'spec/lib/gitlab/utils/usage_data_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/web_ide/config/entry/global_spec.rb' - 'spec/lib/gitlab/web_ide/config/entry/terminal_spec.rb' - 'spec/lib/gitlab/webpack/file_loader_spec.rb' @@ -4270,9 +4138,6 @@ Layout/LineLength: - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - 'spec/migrations/active_record/schema_spec.rb' - - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - - 'spec/migrations/finalize_project_namespaces_backfill_spec.rb' - - 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/acts_as_taggable_on/tag_spec.rb' - 'spec/models/acts_as_taggable_on/tagging_spec.rb' @@ -4284,7 +4149,6 @@ Layout/LineLength: - 'spec/models/authentication_event_spec.rb' - 'spec/models/award_emoji_spec.rb' - 'spec/models/blob_viewer/go_mod_spec.rb' - - 'spec/models/blob_viewer/metrics_dashboard_yml_spec.rb' - 'spec/models/bulk_import_spec.rb' - 'spec/models/bulk_imports/entity_spec.rb' - 'spec/models/bulk_imports/file_transfer/project_config_spec.rb' @@ -4387,7 +4251,6 @@ Layout/LineLength: - 'spec/models/metrics/users_starred_dashboard_spec.rb' - 'spec/models/milestone_spec.rb' - 'spec/models/namespace/package_setting_spec.rb' - - 'spec/models/namespace/root_storage_statistics_spec.rb' - 'spec/models/namespace_setting_spec.rb' - 'spec/models/namespace_spec.rb' - 'spec/models/namespace_statistics_spec.rb' @@ -4402,7 +4265,6 @@ Layout/LineLength: - 'spec/models/packages/dependency_spec.rb' - 'spec/models/packages/go/module_version_spec.rb' - 'spec/models/packages/nuget/dependency_link_metadatum_spec.rb' - - 'spec/models/packages/nuget/metadatum_spec.rb' - 'spec/models/packages/package_file_spec.rb' - 'spec/models/packages/package_spec.rb' - 'spec/models/pages/virtual_domain_spec.rb' @@ -4426,7 +4288,6 @@ Layout/LineLength: - 'spec/models/projects/topic_spec.rb' - 'spec/models/projects/triggered_hooks_spec.rb' - 'spec/models/prometheus_metric_spec.rb' - - 'spec/models/protected_branch/merge_access_level_spec.rb' - 'spec/models/protected_branch/push_access_level_spec.rb' - 'spec/models/protected_branch_spec.rb' - 'spec/models/redirect_route_spec.rb' @@ -4473,13 +4334,11 @@ Layout/LineLength: - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/detail/package_presenter_spec.rb' - 'spec/presenters/packages/helm/index_presenter_spec.rb' - - 'spec/presenters/packages/npm/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/package_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' - 'spec/presenters/projects/security/configuration_presenter_spec.rb' - 'spec/presenters/prometheus_alert_presenter_spec.rb' - - 'spec/presenters/service_hook_presenter_spec.rb' - 'spec/presenters/snippet_blob_presenter_spec.rb' - 'spec/rack_servers/puma_spec.rb' - 'spec/requests/admin/background_migrations_controller_spec.rb' @@ -4584,7 +4443,6 @@ Layout/LineLength: - 'spec/requests/api/group_clusters_spec.rb' - 'spec/requests/api/group_debian_distributions_spec.rb' - 'spec/requests/api/group_labels_spec.rb' - - 'spec/requests/api/group_milestones_spec.rb' - 'spec/requests/api/group_packages_spec.rb' - 'spec/requests/api/group_variables_spec.rb' - 'spec/requests/api/groups_spec.rb' @@ -4759,7 +4617,6 @@ Layout/LineLength: - 'spec/services/ci/update_pending_build_service_spec.rb' - 'spec/services/clusters/agents/authorizations/ci_access/filter_service_spec.rb' - 'spec/services/clusters/create_service_spec.rb' - - 'spec/services/clusters/integrations/prometheus_health_check_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/clusters/management/validate_management_project_permissions_service_spec.rb' @@ -4991,7 +4848,6 @@ Layout/LineLength: - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/support/db_cleaner.rb' - - 'spec/support/fast_quarantine.rb' - 'spec/support/helpers/api_helpers.rb' - 'spec/support/helpers/board_helpers.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' @@ -5022,12 +4878,6 @@ Layout/LineLength: - 'spec/support/matchers/project_namespace_matcher.rb' - 'spec/support/matchers/query_matcher.rb' - 'spec/support/matchers/route_to_route_not_found_matcher.rb' - - 'spec/support/migrations_helpers/schema_version_finder.rb' - - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb' - - 'spec/support/prometheus/additional_metrics_shared_examples.rb' - - 'spec/support/redis/redis_shared_examples.rb' - - 'spec/support/services/deploy_token_shared_examples.rb' - - 'spec/support/services/issuable_update_service_shared_examples.rb' - 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb' - 'spec/support/shared_contexts/container_repositories_shared_context.rb' - 'spec/support/shared_contexts/finders/group_projects_finder_shared_contexts.rb' @@ -5169,7 +5019,6 @@ Layout/LineLength: - 'spec/support/shared_examples/services/namespace_package_settings_shared_examples.rb' - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' - 'spec/support/shared_examples/services/projects/update_repository_storage_service_shared_examples.rb' - - 'spec/support/shared_examples/services/rate_limited_service_shared_examples.rb' - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' - 'spec/support/shared_examples/services/resource_events/change_milestone_service_shared_examples.rb' - 'spec/support/shared_examples/services/security/ci_configuration/create_service_shared_examples.rb' @@ -5199,22 +5048,18 @@ Layout/LineLength: - 'spec/tasks/gitlab/smtp_rake_spec.rb' - 'spec/tasks/gitlab/snippets_rake_spec.rb' - 'spec/tasks/gitlab/storage_rake_spec.rb' - - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - 'spec/tasks/gitlab/uploads/check_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' - 'spec/tasks/migrate/schema_check_rake_spec.rb' + - 'spec/tooling/danger/analytics_instrumentation_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/feature_flag_spec.rb' - - 'spec/tooling/danger/analytics_instrumentation_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' - 'spec/tooling/lib/tooling/test_map_generator_spec.rb' - 'spec/tooling/quality/test_level_spec.rb' - - 'spec/tooling/rspec_flaky/config_spec.rb' - - 'spec/tooling/rspec_flaky/flaky_examples_collection_spec.rb' - - 'spec/tooling/rspec_flaky/report_spec.rb' - 'spec/uploaders/ci/pipeline_artifact_uploader_spec.rb' - 'spec/uploaders/file_mover_spec.rb' - 'spec/uploaders/file_uploader_spec.rb' @@ -5233,7 +5078,6 @@ Layout/LineLength: - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/help/index.html.haml_spec.rb' - 'spec/views/layouts/_head.html.haml_spec.rb' - - 'spec/views/layouts/application.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/notify/push_to_merge_request_email.text.haml_spec.rb' - 'spec/views/profiles/keys/_form.html.haml_spec.rb' @@ -5243,7 +5087,6 @@ Layout/LineLength: - 'spec/views/projects/jobs/_generic_commit_status.html.haml_spec.rb' - 'spec/views/projects/merge_requests/creations/_new_submit.html.haml_spec.rb' - 'spec/views/projects/pages_domains/show.html.haml_spec.rb' - - 'spec/views/projects/pipeline_schedules/_pipeline_schedule.html.haml_spec.rb' - 'spec/views/projects/settings/ci_cd/_autodevops_form.html.haml_spec.rb' - 'spec/views/projects/settings/operations/show.html.haml_spec.rb' - 'spec/views/projects/tags/index.html.haml_spec.rb' @@ -5269,7 +5112,6 @@ Layout/LineLength: - 'spec/workers/ci/pipeline_success_unlock_artifacts_worker_spec.rb' - 'spec/workers/ci/ref_delete_unlock_artifacts_worker_spec.rb' - 'spec/workers/ci/resource_groups/assign_resource_from_resource_group_worker_spec.rb' - - 'spec/workers/clusters/integrations/check_prometheus_health_worker_spec.rb' - 'spec/workers/concerns/application_worker_spec.rb' - 'spec/workers/concerns/project_import_options_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' @@ -5323,11 +5165,8 @@ Layout/LineLength: - 'spec/workers/users/deactivate_dormant_users_worker_spec.rb' - 'tooling/danger/analytics_instrumentation.rb' - 'tooling/danger/project_helper.rb' - - 'tooling/danger/specs.rb' - 'tooling/graphql/docs/helper.rb' - 'tooling/lib/tooling/helm3_client.rb' - 'tooling/lib/tooling/kubernetes_client.rb' - 'tooling/merge_request_rspec_failure_rake_task.rb' - 'tooling/quality/test_level.rb' - - 'tooling/rspec_flaky/listener.rb' - - 'tooling/rspec_flaky/report.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 3bc63853043..ca6803be7e8 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -46,7 +46,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/environment.rb' - 'app/models/error_tracking/client_key.rb' - 'app/models/error_tracking/error.rb' - - 'app/models/external_pull_request.rb' - 'app/models/group.rb' - 'app/models/group_group_link.rb' - 'app/models/incident_management/timeline_event_tag.rb' diff --git a/.rubocop_todo/lint/ambiguous_regexp_literal.yml b/.rubocop_todo/lint/ambiguous_regexp_literal.yml index c3b06ede5be..4754e381780 100644 --- a/.rubocop_todo/lint/ambiguous_regexp_literal.yml +++ b/.rubocop_todo/lint/ambiguous_regexp_literal.yml @@ -66,7 +66,6 @@ Lint/AmbiguousRegexpLiteral: - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb' - - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' - 'spec/lib/gitlab/web_ide/config/entry/global_spec.rb' - 'spec/lib/gitlab/web_ide/config/entry/terminal_spec.rb' - 'spec/lib/object_storage/direct_upload_spec.rb' diff --git a/.rubocop_todo/lint/assignment_in_condition.yml b/.rubocop_todo/lint/assignment_in_condition.yml new file mode 100644 index 00000000000..0d893f4c1a0 --- /dev/null +++ b/.rubocop_todo/lint/assignment_in_condition.yml @@ -0,0 +1,259 @@ +--- +# Cop supports --autocorrect. +Lint/AssignmentInCondition: + Details: grace period + Exclude: + - 'app/controllers/concerns/uploads_actions.rb' + - 'app/controllers/concerns/verifies_with_email.rb' + - 'app/controllers/omniauth_callbacks_controller.rb' + - 'app/controllers/projects/blob_controller.rb' + - 'app/controllers/projects/commit_controller.rb' + - 'app/controllers/projects/merge_requests/diffs_controller.rb' + - 'app/controllers/projects/settings/integrations_controller.rb' + - 'app/controllers/repositories/lfs_api_controller.rb' + - 'app/controllers/users/terms_controller.rb' + - 'app/finders/merge_requests/oldest_per_commit_finder.rb' + - 'app/finders/pending_todos_finder.rb' + - 'app/finders/repositories/changelog_commits_finder.rb' + - 'app/graphql/mutations/ci/runner/bulk_delete.rb' + - 'app/graphql/mutations/merge_requests/accept.rb' + - 'app/graphql/mutations/notes/create/note.rb' + - 'app/graphql/resolvers/deployments_resolver.rb' + - 'app/graphql/types/global_id_type.rb' + - 'app/helpers/blob_helper.rb' + - 'app/helpers/button_helper.rb' + - 'app/helpers/issuables_helper.rb' + - 'app/helpers/snippets_helper.rb' + - 'app/mailers/emails/service_desk.rb' + - 'app/mailers/notify.rb' + - 'app/models/blob_viewer/go_mod.rb' + - 'app/models/ci/build_metadata.rb' + - 'app/models/ci/runner.rb' + - 'app/models/clusters/platforms/kubernetes.rb' + - 'app/models/concerns/after_commit_queue.rb' + - 'app/models/concerns/atomic_internal_id.rb' + - 'app/models/concerns/bulk_insert_safe.rb' + - 'app/models/concerns/has_unique_internal_users.rb' + - 'app/models/concerns/subscribable.rb' + - 'app/models/design_management/design_collection.rb' + - 'app/models/diff_note.rb' + - 'app/models/merge_request.rb' + - 'app/models/merge_request_diff.rb' + - 'app/models/repository.rb' + - 'app/models/snippet_repository.rb' + - 'app/models/user.rb' + - 'app/presenters/ci/pipeline_presenter.rb' + - 'app/presenters/commit_status_presenter.rb' + - 'app/presenters/project_presenter.rb' + - 'app/serializers/fork_namespace_entity.rb' + - 'app/serializers/merge_request_poll_cached_widget_entity.rb' + - 'app/services/ci/create_pipeline_service.rb' + - 'app/services/ci/find_exposed_artifacts_service.rb' + - 'app/services/ci/runners/register_runner_service.rb' + - 'app/services/clusters/agents/authorize_proxy_user_service.rb' + - 'app/services/deployments/create_for_build_service.rb' + - 'app/services/deployments/create_service.rb' + - 'app/services/deployments/link_merge_requests_service.rb' + - 'app/services/deployments/update_environment_service.rb' + - 'app/services/design_management/on_success_callbacks.rb' + - 'app/services/environments/schedule_to_delete_review_apps_service.rb' + - 'app/services/groups/nested_create_service.rb' + - 'app/services/issuable_base_service.rb' + - 'app/services/issues/zoom_link_service.rb' + - 'app/services/lfs/file_transformer.rb' + - 'app/services/merge_requests/base_service.rb' + - 'app/services/merge_requests/mergeability_check_service.rb' + - 'app/services/metrics/dashboard/dynamic_embed_service.rb' + - 'app/services/packages/debian/parse_debian822_service.rb' + - 'app/services/pages/migrate_from_legacy_storage_service.rb' + - 'app/services/projects/operations/update_service.rb' + - 'app/services/projects/prometheus/alerts/notify_service.rb' + - 'app/services/projects/unlink_fork_service.rb' + - 'app/services/releases/update_service.rb' + - 'app/services/repositories/changelog_service.rb' + - 'app/services/system_notes/incident_service.rb' + - 'app/services/system_notes/merge_requests_service.rb' + - 'app/services/task_list_toggle_service.rb' + - 'app/services/tasks_to_be_done/base_service.rb' + - 'app/services/users/last_push_event_service.rb' + - 'app/services/users/refresh_authorized_projects_service.rb' + - 'app/services/users/update_service.rb' + - 'app/uploaders/file_mover.rb' + - 'app/uploaders/file_uploader.rb' + - 'app/validators/x509_certificate_credentials_validator.rb' + - 'app/workers/ci/build_finished_worker.rb' + - 'app/workers/clusters/agents/delete_expired_events_worker.rb' + - 'app/workers/clusters/agents/notify_git_push_worker.rb' + - 'app/workers/concerns/gitlab/bitbucket_server_import/object_importer.rb' + - 'app/workers/concerns/gitlab/bitbucket_server_import/stage_methods.rb' + - 'app/workers/concerns/gitlab/github_import/object_importer.rb' + - 'app/workers/concerns/gitlab/github_import/stage_methods.rb' + - 'app/workers/concerns/gitlab/notify_upon_death.rb' + - 'app/workers/deployments/hooks_worker.rb' + - 'app/workers/deployments/link_merge_request_worker.rb' + - 'app/workers/gitlab/github_gists_import/import_gist_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_lfs_objects_worker.rb' + - 'app/workers/gitlab/import/advance_stage.rb' + - 'app/workers/ml/experiment_tracking/associate_ml_candidate_to_package_worker.rb' + - 'app/workers/new_note_worker.rb' + - 'app/workers/terraform/states/destroy_worker.rb' + - 'config/initializers/carrierwave_performance_patch.rb' + - 'config/initializers/peek.rb' + - 'config/initializers/validate_database_config.rb' + - 'config/initializers/zz_metrics.rb' + - 'db/post_migrate/20220919080303_delete_migrate_shared_vulnerability_scanners.rb' + - 'ee/app/controllers/concerns/gitlab_subscriptions/seat_count_alert.rb' + - 'ee/app/controllers/omniauth_kerberos_controller.rb' + - 'ee/app/controllers/users/identity_verification_controller.rb' + - 'ee/app/finders/ee/projects_finder.rb' + - 'ee/app/finders/incident_management/oncall_users_finder.rb' + - 'ee/app/graphql/mutations/boards/update_epic_user_preferences.rb' + - 'ee/app/graphql/mutations/incident_management/escalation_policy/base.rb' + - 'ee/app/models/ee/ci/build.rb' + - 'ee/app/models/ee/merge_request.rb' + - 'ee/app/models/ee/preloaders/single_hierarchy_project_group_plans_preloader.rb' + - 'ee/app/models/productivity_analytics.rb' + - 'ee/app/presenters/ee/ci/pipeline_presenter.rb' + - 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb' + - 'ee/app/services/app_sec/dast/site_profiles/update_service.rb' + - 'ee/app/services/deployments/approval_service.rb' + - 'ee/app/services/dora/aggregate_metrics_service.rb' + - 'ee/app/services/ee/application_settings/update_service.rb' + - 'ee/app/services/ee/issues/clone_service.rb' + - 'ee/app/services/ee/issues/move_service.rb' + - 'ee/app/services/ee/lfs/unlock_file_service.rb' + - 'ee/app/services/ee/projects/operations/update_service.rb' + - 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb' + - 'ee/app/services/incident_management/issuable_resource_links/zoom_link_service.rb' + - 'ee/app/services/incident_management/pending_escalations/create_service.rb' + - 'ee/app/services/security/security_orchestration_policies/rule_schedule_service.rb' + - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' + - 'ee/app/services/vulnerabilities/starboard_vulnerability_create_service.rb' + - 'ee/app/validators/vulnerabilities/cvss_vector_validator.rb' + - 'ee/db/fixtures/development/20_burndown.rb' + - 'ee/lib/ee/api/entities/approval_state.rb' + - 'ee/lib/ee/gitlab/auth/ldap/sync/group.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' + - 'ee/lib/ee/gitlab/checks/diff_check.rb' + - 'ee/lib/ee/gitlab/repo_path.rb' + - 'ee/lib/gem_extensions/elasticsearch/model/indexing/instance_methods.rb' + - 'ee/lib/gitlab/group_plans_preloader.rb' + - 'ee/lib/gitlab/llm/content_parser.rb' + - 'ee/lib/gitlab/path_locks_finder.rb' + - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb' + - 'ee/lib/system_check/geo/authorized_keys_check.rb' + - 'ee/spec/factories/protected_environments.rb' + - 'lib/api/base.rb' + - 'lib/api/integrations.rb' + - 'lib/banzai/filter/ascii_doc_sanitization_filter.rb' + - 'lib/banzai/filter/broadcast_message_placeholders_filter.rb' + - 'lib/banzai/filter/footnote_filter.rb' + - 'lib/banzai/filter/gollum_tags_filter.rb' + - 'lib/banzai/filter/inline_observability_filter.rb' + - 'lib/banzai/filter/references/abstract_reference_filter.rb' + - 'lib/banzai/filter/references/merge_request_reference_filter.rb' + - 'lib/banzai/filter/references/project_reference_filter.rb' + - 'lib/banzai/filter/references/user_reference_filter.rb' + - 'lib/banzai/filter/table_of_contents_filter.rb' + - 'lib/feature/definition.rb' + - 'lib/file_size_validator.rb' + - 'lib/gitlab/audit/type/definition.rb' + - 'lib/gitlab/authorized_keys.rb' + - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' + - 'lib/gitlab/blob_helper.rb' + - 'lib/gitlab/buffered_io.rb' + - 'lib/gitlab/changelog/config.rb' + - 'lib/gitlab/changelog/generator.rb' + - 'lib/gitlab/chat/output.rb' + - 'lib/gitlab/checks/diff_check.rb' + - 'lib/gitlab/ci/ansi2html.rb' + - 'lib/gitlab/ci/ansi2json/style.rb' + - 'lib/gitlab/ci/build/rules.rb' + - 'lib/gitlab/ci/build/rules/rule.rb' + - 'lib/gitlab/ci/components/instance_path.rb' + - 'lib/gitlab/ci/config/external/rules.rb' + - 'lib/gitlab/ci/config/normalizer.rb' + - 'lib/gitlab/ci/parsers/coverage/sax_document.rb' + - 'lib/gitlab/ci/yaml_processor.rb' + - 'lib/gitlab/counters/buffered_counter.rb' + - 'lib/gitlab/data_builder/deployment.rb' + - 'lib/gitlab/database/background_migration/batched_migration_runner.rb' + - 'lib/gitlab/database/gitlab_schema.rb' + - 'lib/gitlab/database/load_balancing/configuration.rb' + - 'lib/gitlab/database/load_balancing/host.rb' + - 'lib/gitlab/database/load_balancing/load_balancer.rb' + - 'lib/gitlab/database/load_balancing/wal_tracking_receiver.rb' + - 'lib/gitlab/database/load_balancing/wal_tracking_sender.rb' + - 'lib/gitlab/database/partitioning/monthly_strategy.rb' + - 'lib/gitlab/database/partitioning/partition_manager.rb' + - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base.rb' + - 'lib/gitlab/database/shared_model.rb' + - 'lib/gitlab/diff/formatters/base_formatter.rb' + - 'lib/gitlab/diff/lines_unfolder.rb' + - 'lib/gitlab/diff/position.rb' + - 'lib/gitlab/diff/suggestions_parser.rb' + - 'lib/gitlab/email/handler/create_issue_handler.rb' + - 'lib/gitlab/email/handler/create_merge_request_handler.rb' + - 'lib/gitlab/email/handler/create_note_on_issuable_handler.rb' + - 'lib/gitlab/email/handler/service_desk_handler.rb' + - 'lib/gitlab/encoding_helper.rb' + - 'lib/gitlab/exception_log_formatter.rb' + - 'lib/gitlab/file_markdown_link_builder.rb' + - 'lib/gitlab/fogbugz_import/importer.rb' + - 'lib/gitlab/git/blame.rb' + - 'lib/gitlab/git/pre_receive_error.rb' + - 'lib/gitlab/git/repository.rb' + - 'lib/gitlab/gitaly_client/cleanup_service.rb' + - 'lib/gitlab/gitaly_client/operation_service.rb' + - 'lib/gitlab/gitaly_client/repository_service.rb' + - 'lib/gitlab/github_import/importer/issue_importer.rb' + - 'lib/gitlab/github_import/importer/label_links_importer.rb' + - 'lib/gitlab/github_import/importer/note_importer.rb' + - 'lib/gitlab/graphql/deprecations_base.rb' + - 'lib/gitlab/i18n/metadata_entry.rb' + - 'lib/gitlab/i18n/po_linter.rb' + - 'lib/gitlab/mail_room.rb' + - 'lib/gitlab/metrics/samplers/base_sampler.rb' + - 'lib/gitlab/metrics/subscribers/load_balancing.rb' + - 'lib/gitlab/metrics/transaction.rb' + - 'lib/gitlab/patch/global_id.rb' + - 'lib/gitlab/patch/sprockets_base_file_digest_key.rb' + - 'lib/gitlab/performance_bar/redis_adapter_when_peek_enabled.rb' + - 'lib/gitlab/performance_bar/stats.rb' + - 'lib/gitlab/quick_actions/merge_request_actions.rb' + - 'lib/gitlab/slash_commands/global_slack_handler.rb' + - 'lib/gitlab/slash_commands/presenters/run.rb' + - 'lib/gitlab/string_regex_marker.rb' + - 'lib/gitlab/task_helpers.rb' + - 'lib/gitlab/usage/metric_definition.rb' + - 'lib/gitlab/usage_data/topology.rb' + - 'lib/gitlab/usage_data_counters/ci_template_unique_counter.rb' + - 'lib/gitlab/utils/merge_hash.rb' + - 'lib/gitlab/version_info.rb' + - 'lib/gitlab/webpack/dev_server_middleware.rb' + - 'lib/gitlab/wiki_pages/front_matter_parser.rb' + - 'lib/prometheus/pid_provider.rb' + - 'lib/tasks/gitlab/banzai.rake' + - 'qa/lib/slack/page/chat.rb' + - 'qa/qa/resource/registry_repository.rb' + - 'qa/qa/scenario/template.rb' + - 'qa/qa/vendor/jenkins/helpers.rb' + - 'rubocop/cop/gitlab/const_get_inherit_false.rb' + - 'rubocop/cop/migration/add_limit_to_text_columns.rb' + - 'rubocop/cop/migration/background_migration_missing_active_concern.rb' + - 'rubocop/cop/prefer_class_methods_over_module.rb' + - 'rubocop/cop/rspec/httparty_basic_auth.rb' + - 'scripts/lib/glfm/render_static_html.rb' + - 'scripts/lib/glfm/update_example_snapshots.rb' + - 'scripts/lint-docs-blueprints.rb' + - 'spec/factories/ci/processable.rb' + - 'spec/lib/gitlab/background_migration/backfill_root_storage_statistics_fork_storage_sizes_spec.rb' + - 'spec/models/packages/go/module_version_spec.rb' + - 'spec/models/project_feature_spec.rb' + - 'spec/requests/api/go_proxy_spec.rb' + - 'spec/services/members/invitation_reminder_email_service_spec.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/helpers/next_found_instance_of.rb' + - 'spec/support/matchers/request_urgency_matcher.rb' + - 'spec/support/shared_contexts/glfm/api_markdown_snapshot_shared_context.rb' + - 'tooling/danger/database.rb' diff --git a/.rubocop_todo/lint/empty_block.yml b/.rubocop_todo/lint/empty_block.yml index 5751ca7641f..dbcef42eab4 100644 --- a/.rubocop_todo/lint/empty_block.yml +++ b/.rubocop_todo/lint/empty_block.yml @@ -4,7 +4,6 @@ Lint/EmptyBlock: - 'app/controllers/groups/boards_controller.rb' - 'app/controllers/projects/boards_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' - - 'app/experiments/logged_out_marketing_header_experiment.rb' - 'config/application.rb' - 'ee/app/controllers/projects/learn_gitlab_controller.rb' - 'ee/spec/factories/incident_management/escalation_rules.rb' diff --git a/.rubocop_todo/lint/empty_class.yml b/.rubocop_todo/lint/empty_class.yml deleted file mode 100644 index c8caff58c35..00000000000 --- a/.rubocop_todo/lint/empty_class.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -Lint/EmptyClass: - Exclude: - - 'spec/lib/gitlab/multi_destination_logger_spec.rb' diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 8cfecb87f2b..1522d935008 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -139,7 +139,6 @@ Lint/MissingCopEnableDirective: - 'ee/lib/api/ldap_group_links.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/gitlab/spdx/license.rb' - 'ee/spec/helpers/groups/security_features_helper_spec.rb' - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' diff --git a/.rubocop_todo/lint/non_atomic_file_operation.yml b/.rubocop_todo/lint/non_atomic_file_operation.yml index cd700870448..d9d415de923 100644 --- a/.rubocop_todo/lint/non_atomic_file_operation.yml +++ b/.rubocop_todo/lint/non_atomic_file_operation.yml @@ -41,5 +41,3 @@ Lint/NonAtomicFileOperation: - 'spec/services/bulk_imports/repository_bundle_export_service_spec.rb' - 'spec/services/bulk_imports/uploads_export_service_spec.rb' - 'spec/support/database/query_recorder.rb' - - 'spec/tooling/rspec_flaky/report_spec.rb' - - 'tooling/rspec_flaky/report.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 29f15deac2e..7a07242ab29 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -140,7 +140,6 @@ Lint/RedundantCopDisableDirective: - 'ee/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb' - 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb' - - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb' - 'ee/lib/gitlab/elastic/bool_expr.rb' - 'ee/lib/gitlab/spdx/license.rb' @@ -183,7 +182,6 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb' - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' - 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb' - - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - 'lib/gitlab/background_migration/re_expire_o_auth_tokens.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' @@ -264,8 +262,6 @@ Lint/RedundantCopDisableDirective: - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - 'spec/lib/gitlab/database/load_balancing/transaction_leaking_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' @@ -284,7 +280,6 @@ Lint/RedundantCopDisableDirective: - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' - - 'spec/migrations/20220725150127_update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - 'spec/migrations/add_namespaces_emails_enabled_column_data_spec.rb' - 'spec/migrations/add_projects_emails_enabled_column_data_spec.rb' - 'spec/models/ci/build_trace_chunk_spec.rb' @@ -300,7 +295,6 @@ Lint/RedundantCopDisableDirective: - 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb' - 'spec/requests/api/alert_management_alerts_spec.rb' - 'spec/requests/api/graphql/ci/config_spec.rb' - - 'spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb' - 'spec/services/alert_management/metric_images/upload_service_spec.rb' - 'spec/services/boards/lists/list_service_spec.rb' - 'spec/services/projects/update_statistics_service_spec.rb' @@ -322,4 +316,3 @@ Lint/RedundantCopDisableDirective: - 'tooling/lib/tooling/helm3_client.rb' - 'tooling/lib/tooling/kubernetes_client.rb' - 'tooling/quality/test_level.rb' - - 'tooling/rspec_flaky/listener.rb' diff --git a/.rubocop_todo/lint/redundant_safe_navigation.yml b/.rubocop_todo/lint/redundant_safe_navigation.yml new file mode 100644 index 00000000000..8c4b66313eb --- /dev/null +++ b/.rubocop_todo/lint/redundant_safe_navigation.yml @@ -0,0 +1,15 @@ +--- +# Cop supports --autocorrect. +Lint/RedundantSafeNavigation: + Details: grace period + Exclude: + - 'app/controllers/import/base_controller.rb' + - 'app/graphql/resolvers/users_resolver.rb' + - 'app/graphql/types/countable_connection_type.rb' + - 'app/helpers/search_helper.rb' + - 'app/models/deployment.rb' + - 'ee/app/graphql/ee/types/issue_connection_type.rb' + - 'ee/app/models/search/namespace_index_assignment.rb' + - 'lib/api/projects.rb' + - 'lib/sidebars/projects/menus/infrastructure_menu.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' diff --git a/.rubocop_todo/lint/redundant_string_coercion.yml b/.rubocop_todo/lint/redundant_string_coercion.yml new file mode 100644 index 00000000000..8d9bb93395b --- /dev/null +++ b/.rubocop_todo/lint/redundant_string_coercion.yml @@ -0,0 +1,7 @@ +--- +# Cop supports --autocorrect. +Lint/RedundantStringCoercion: + Details: grace period + Exclude: + - 'ee/bin/geo_log_cursor' + - 'ee/db/fixtures/development/31_devops_adoption.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml index 147cd66f993..0fb6641d2a7 100644 --- a/.rubocop_todo/lint/symbol_conversion.yml +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -10,7 +10,6 @@ Lint/SymbolConversion: - 'config/puma.rb' - 'ee/app/components/billing/plan_component.rb' - 'ee/app/controllers/projects/security/scanned_resources_controller.rb' - - 'ee/app/models/product_analytics/jitsu_authentication.rb' - 'ee/app/serializers/integrations/zentao_serializers/issue_entity.rb' - 'ee/db/fixtures/development/35_merge_request_predictions.rb' - 'ee/lib/api/analytics/product_analytics.rb' @@ -34,7 +33,6 @@ Lint/SymbolConversion: - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - 'ee/spec/lib/gitlab/search/aggregation_parser_spec.rb' - 'ee/spec/lib/gitlab/search/aggregation_spec.rb' - - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' - 'ee/spec/models/ee/integrations/jira_spec.rb' - 'ee/spec/models/integrations/github_spec.rb' - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' @@ -117,7 +115,6 @@ Lint/SymbolConversion: - 'spec/lib/gitlab/search/abuse_validators/no_abusive_coercion_from_string_validator_spec.rb' - 'spec/lib/gitlab/slug/path_spec.rb' - 'spec/lib/gitlab/tracking_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/google_api/cloud_platform/client_spec.rb' - 'spec/lib/service_ping/devops_report_spec.rb' - 'spec/models/integrations/prometheus_spec.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index 0b4120a152c..05e30a7f9ad 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -115,7 +115,6 @@ Lint/UnusedBlockArgument: - 'ee/lib/gitlab/insights/reducers/count_per_label_reducer.rb' - 'ee/lib/gitlab/proxy.rb' - 'ee/lib/tasks/contracts/merge_requests.rake' - - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/lib/tasks/gitlab/indexer.rake' - 'ee/lib/tasks/gitlab/seed/insights.rake' - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' @@ -427,6 +426,5 @@ Lint/UnusedBlockArgument: - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - 'spec/support/shared_examples/workers/concerns/reenqueuer_shared_examples.rb' - 'spec/tooling/lib/tooling/find_codeowners_spec.rb' - - 'spec/tooling/rspec_flaky/config_spec.rb' - 'spec/workers/projects/git_garbage_collect_worker_spec.rb' - 'tooling/lib/tooling/find_codeowners.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index bbd12e608a9..086882b0f1b 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -316,7 +316,6 @@ Lint/UnusedMethodArgument: - 'ee/lib/gitlab/package_metadata/connector/gcp.rb' - 'ee/lib/gitlab/package_metadata/connector/offline.rb' - 'ee/lib/gitlab/zoekt/search_results.rb' - - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' - 'ee/spec/features/groups/group_roadmap_spec.rb' - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' @@ -456,7 +455,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/diff/file_collection/merge_request_diff_base.rb' - 'lib/gitlab/diff/line.rb' - 'lib/gitlab/encoding_helper.rb' - - 'lib/gitlab/error_tracking/error_repository/active_record_strategy.rb' - 'lib/gitlab/fogbugz_import/importer.rb' - 'lib/gitlab/git/commit_stats.rb' - 'lib/gitlab/git/conflict/parser.rb' @@ -480,7 +478,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/graphql/calls_gitaly/field_extension.rb' - 'lib/gitlab/graphql/connection_redaction.rb' - 'lib/gitlab/graphql/extensions/externally_paginated_array_extension.rb' - - 'lib/gitlab/graphql/generic_tracing.rb' - 'lib/gitlab/graphql/lazy.rb' - 'lib/gitlab/graphql/project/dast_profile_connection_extension.rb' - 'lib/gitlab/graphql/query_analyzers/ast/logger_analyzer.rb' diff --git a/.rubocop_todo/metrics/cyclomatic_complexity.yml b/.rubocop_todo/metrics/cyclomatic_complexity.yml index 414f4f6243c..e345c2be451 100644 --- a/.rubocop_todo/metrics/cyclomatic_complexity.yml +++ b/.rubocop_todo/metrics/cyclomatic_complexity.yml @@ -8,13 +8,12 @@ Metrics/CyclomaticComplexity: - 'app/models/concerns/issuable.rb' - 'app/services/projects/create_service.rb' - 'ee/app/controllers/ee/groups_controller.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb' + - 'ee/spec/support/shared_contexts/remote_development/remote_development_shared_contexts.rb' - 'lib/banzai/filter/references/abstract_reference_filter.rb' - 'lib/gitlab/conflict/file.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - 'lib/gitlab/utils/merge_hash.rb' - 'lib/kramdown/parser/atlassian_document_format.rb' - - 'qa/qa/runtime/browser.rb' - 'qa/qa/support/repeater.rb' - 'sidekiq_cluster/cli.rb' diff --git a/.rubocop_todo/metrics/perceived_complexity.yml b/.rubocop_todo/metrics/perceived_complexity.yml index 51ec88c1582..2ad1c1d1f33 100644 --- a/.rubocop_todo/metrics/perceived_complexity.yml +++ b/.rubocop_todo/metrics/perceived_complexity.yml @@ -7,13 +7,12 @@ Metrics/PerceivedComplexity: - 'app/helpers/nav/top_nav_helper.rb' - 'app/services/projects/create_service.rb' - 'ee/app/controllers/ee/groups_controller.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' + - 'ee/spec/support/shared_contexts/remote_development/remote_development_shared_contexts.rb' - 'lib/banzai/filter/references/abstract_reference_filter.rb' - 'lib/banzai/renderer.rb' - 'lib/gitlab/conflict/file.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - 'lib/gitlab/utils/merge_hash.rb' - - 'qa/qa/runtime/browser.rb' - 'qa/qa/support/repeater.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'sidekiq_cluster/cli.rb' diff --git a/.rubocop_todo/migration/avoid_finalize_background_migration.yml b/.rubocop_todo/migration/avoid_finalize_background_migration.yml new file mode 100644 index 00000000000..bde85ce3e48 --- /dev/null +++ b/.rubocop_todo/migration/avoid_finalize_background_migration.yml @@ -0,0 +1,7 @@ +--- +Migration/AvoidFinalizeBackgroundMigration: + Details: grace period + Exclude: + - 'db/post_migrate/20220502015011_clean_up_fix_merge_request_diff_commit_users.rb' + - 'db/post_migrate/20220525131557_cleanup_backfill_integrations_enable_ssl_verification.rb' + - 'db/post_migrate/20220713133515_cleanup_backfill_draft_statuses_on_merge_requests.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index 02cc7d2a85c..68129f910d1 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -25,7 +25,6 @@ Naming/HeredocDelimiterNaming: - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/policy_commit_service_spec.rb' - 'ee/spec/support/helpers/ee/ldap_helpers.rb' - - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'lib/api/metadata.rb' - 'lib/backup/helper.rb' - 'lib/feature/shared.rb' @@ -91,7 +90,9 @@ Naming/HeredocDelimiterNaming: - 'spec/lib/gitlab/webpack/graphql_known_operations_spec.rb' - 'spec/lib/gitlab/webpack/manifest_spec.rb' - 'spec/lib/gitlab/word_diff/parser_spec.rb' + - 'spec/lib/json_web_token/rsa_token_spec.rb' - 'spec/models/ci/bridge_spec.rb' + - 'spec/models/commit_spec.rb' - 'spec/models/concerns/ci/maskable_spec.rb' - 'spec/models/integrations/asana_spec.rb' - 'spec/models/ssh_host_key_spec.rb' @@ -109,10 +110,11 @@ Naming/HeredocDelimiterNaming: - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' - 'spec/services/task_list_toggle_service_spec.rb' + - 'spec/support/helpers/repo_helpers.rb' + - 'spec/support/helpers/seed_repo.rb' - 'spec/support/helpers/stub_object_storage.rb' - 'spec/support/shared_examples/helm_commands_shared_examples.rb' - 'spec/support/shared_examples/models/taskable_shared_examples.rb' - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' - - 'spec/support/test_reports/test_reports_helper.rb' - 'spec/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences_rake_spec.rb' - 'spec/workers/post_receive_spec.rb' diff --git a/.rubocop_todo/naming/inclusive_language.yml b/.rubocop_todo/naming/inclusive_language.yml index 8950e2e77f4..271286d4752 100644 --- a/.rubocop_todo/naming/inclusive_language.yml +++ b/.rubocop_todo/naming/inclusive_language.yml @@ -1,26 +1,19 @@ --- Naming/InclusiveLanguage: Exclude: - - 'app/controllers/admin/application_settings/appearances_controller.rb' - - 'app/controllers/concerns/requires_whitelisted_monitoring_client.rb' - - 'app/controllers/health_check_controller.rb' - - 'app/controllers/health_controller.rb' - - 'app/controllers/metrics_controller.rb' + - 'app/controllers/concerns/requires_allowlisted_monitoring_client.rb' - 'app/helpers/application_settings_helper.rb' - - 'app/helpers/blob_helper.rb' - 'app/helpers/markup_helper.rb' - 'app/models/application_setting.rb' - 'app/models/application_setting_implementation.rb' - 'app/models/concerns/cache_markdown_field.rb' - 'app/services/application_settings/update_service.rb' - - 'app/services/projects/download_service.rb' - 'app/uploaders/avatar_uploader.rb' - 'app/uploaders/content_type_whitelist.rb' - 'app/uploaders/design_management/design_v432x230_uploader.rb' - 'app/uploaders/favicon_uploader.rb' - 'app/uploaders/gitlab_uploader.rb' - 'app/uploaders/import_export_uploader.rb' - - 'app/validators/cron_validator.rb' - 'app/validators/qualified_domain_array_validator.rb' - 'config/initializers/1_settings.rb' - 'config/initializers/doorkeeper.rb' @@ -28,15 +21,12 @@ Naming/InclusiveLanguage: - 'ee/app/controllers/projects/push_rules_controller.rb' - 'ee/lib/arkose/verify_response.rb' - 'ee/lib/system_check/geo/http_connection_check.rb' - - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - - 'ee/spec/models/dora/lead_time_for_changes_metric_spec.rb' - 'lib/api/entities/application_setting.rb' - 'lib/api/settings.rb' - 'lib/banzai/filter/asset_proxy_filter.rb' - 'lib/gitlab/asset_proxy.rb' - 'lib/gitlab/auth/ip_rate_limiter.rb' - 'lib/gitlab/ci/config/external/file/base.rb' - - 'lib/gitlab/git/hook_env.rb' - 'lib/gitlab/github_import/markdown/attachment.rb' - 'lib/gitlab/markdown_cache/active_record/extension.rb' - 'lib/gitlab/markdown_cache/field_data.rb' @@ -45,48 +35,21 @@ Naming/InclusiveLanguage: - 'lib/gitlab/sanitizers/svg.rb' - 'lib/gitlab/sanitizers/svg/whitelist.rb' - 'lib/system_check/app/git_user_default_ssh_config_check.rb' - - 'rubocop/cop/active_record_association_reload.rb' - - 'rubocop/cop/avoid_becomes.rb' - - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' - - 'rubocop/cop/avoid_return_from_blocks.rb' - - 'rubocop/cop/default_scope.rb' - - 'rubocop/cop/destroy_all.rb' - - 'rubocop/cop/graphql/id_type.rb' - - 'rubocop/cop/group_public_or_visible_to_user.rb' - - 'rubocop/cop/inject_enterprise_edition_module.rb' - - 'rubocop/cop/migration/add_columns_to_wide_tables.rb' - - 'spec/controllers/concerns/issuable_collections_spec.rb' - 'spec/controllers/health_check_controller_spec.rb' - 'spec/controllers/metrics_controller_spec.rb' - - 'spec/features/projects/import_export/export_file_spec.rb' - 'spec/helpers/markup_helper_spec.rb' - 'spec/lib/banzai/filter/asset_proxy_filter_spec.rb' - 'spec/lib/gitlab/asset_proxy_spec.rb' - 'spec/lib/gitlab/auth/ip_rate_limiter_spec.rb' - 'spec/lib/gitlab/git/hook_env_spec.rb' - 'spec/lib/gitlab/github_import/markdown/attachment_spec.rb' - - 'spec/lib/gitlab/import_export/attribute_configuration_spec.rb' - - 'spec/lib/gitlab/import_export/references_configuration_spec.rb' - - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/middleware/basic_health_check_spec.rb' - - 'spec/lib/gitlab/middleware/go_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb' - 'spec/models/application_setting_spec.rb' - 'spec/requests/api/settings_spec.rb' - 'spec/requests/health_controller_spec.rb' - - 'spec/rubocop/cop/avoid_return_from_blocks_spec.rb' - - 'spec/rubocop/cop/graphql/id_type_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - - 'spec/services/design_management/generate_image_versions_service_spec.rb' - - 'spec/services/error_tracking/list_issues_service_spec.rb' - - 'spec/services/projects/download_service_spec.rb' - - 'spec/support/import_export/export_file_helper.rb' - 'spec/support/shared_contexts/upload_type_check_shared_context.rb' - - 'spec/support/shared_examples/lib/banzai/filters/sanitization_filter_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - - 'spec/uploaders/avatar_uploader_spec.rb' - 'spec/uploaders/content_type_whitelist_spec.rb' - - 'spec/uploaders/design_management/design_v432x230_uploader_spec.rb' - - 'spec/uploaders/favicon_uploader_spec.rb' - - 'spec/validators/cron_validator_spec.rb' diff --git a/.rubocop_todo/performance/active_record_subtransaction_methods.yml b/.rubocop_todo/performance/active_record_subtransaction_methods.yml index 0c0a527a065..a61bac45eff 100644 --- a/.rubocop_todo/performance/active_record_subtransaction_methods.yml +++ b/.rubocop_todo/performance/active_record_subtransaction_methods.yml @@ -9,7 +9,7 @@ Performance/ActiveRecordSubtransactionMethods: - 'app/models/container_repository.rb' - 'app/models/design_management/design_collection.rb' - 'app/models/error_tracking/error.rb' - - 'app/models/external_pull_request.rb' + - 'app/models/ci/external_pull_request.rb' - 'app/models/plan.rb' - 'app/models/project.rb' - 'app/models/shard.rb' diff --git a/.rubocop_todo/performance/regexp_match.yml b/.rubocop_todo/performance/regexp_match.yml new file mode 100644 index 00000000000..2c80a74c538 --- /dev/null +++ b/.rubocop_todo/performance/regexp_match.yml @@ -0,0 +1,60 @@ +--- +# Cop supports --autocorrect. +Performance/RegexpMatch: + Details: grace period + Exclude: + - 'config/initializers/wikicloth_redos_patch.rb' + - 'ee/app/controllers/concerns/audit_events/enforces_valid_date_params.rb' + - 'ee/lib/ee/banzai/filter/references/vulnerability_reference_filter.rb' + - 'ee/lib/elastic/latest/git_class_proxy.rb' + - 'ee/lib/gitlab/llm/chain/utils/text_processing.rb' + - 'ee/lib/gitlab/llm/open_ai/response_modifiers/tanuki_bot.rb' + - 'ee/lib/gitlab/middleware/ip_restrictor.rb' + - 'ee/spec/spec_helper.rb' + - 'lib/api/helpers.rb' + - 'lib/api/helpers/common_helpers.rb' + - 'lib/api/validations/validators/bulk_imports.rb' + - 'lib/banzai/color_parser.rb' + - 'lib/banzai/filter/ascii_doc_sanitization_filter.rb' + - 'lib/banzai/filter/references/abstract_reference_filter.rb' + - 'lib/banzai/filter/references/reference_filter.rb' + - 'lib/bulk_imports/path_normalization.rb' + - 'lib/feature/definition.rb' + - 'lib/gitlab/authorized_keys.rb' + - 'lib/gitlab/checks/branch_check.rb' + - 'lib/gitlab/ci/build/artifacts/metadata.rb' + - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' + - 'lib/gitlab/ci/project_config/remote.rb' + - 'lib/gitlab/database/postgres_constraint.rb' + - 'lib/gitlab/database/postgres_foreign_key.rb' + - 'lib/gitlab/database/postgres_index.rb' + - 'lib/gitlab/database/postgres_partition.rb' + - 'lib/gitlab/database/postgres_partitioned_table.rb' + - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' + - 'lib/gitlab/dependency_linker/base_linker.rb' + - 'lib/gitlab/dependency_linker/composer_json_linker.rb' + - 'lib/gitlab/diff/parser.rb' + - 'lib/gitlab/email/reply_parser.rb' + - 'lib/gitlab/git/gitmodules_parser.rb' + - 'lib/gitlab/metrics/samplers/threads_sampler.rb' + - 'lib/gitlab/middleware/sidekiq_web_static.rb' + - 'lib/gitlab/middleware/static.rb' + - 'lib/gitlab/url_blocker.rb' + - 'lib/tasks/gitlab/update_templates.rake' + - 'lib/uploaded_file.rb' + - 'qa/qa/flow/integrations/slack.rb' + - 'qa/qa/git/location.rb' + - 'qa/qa/resource/api_fabricator.rb' + - 'qa/qa/runtime/search.rb' + - 'qa/qa/service/cluster_provider/k3d.rb' + - 'qa/qa/specs/spec_helper.rb' + - 'qa/qa/tools/ci/ff_changes.rb' + - 'scripts/changed-feature-flags' + - 'scripts/failed_tests.rb' + - 'scripts/lib/glfm/parse_examples.rb' + - 'scripts/lib/glfm/update_specification.rb' + - 'scripts/lint-docs-blueprints.rb' + - 'scripts/perf/query_limiting_report.rb' + - 'scripts/qa/testcases-check' + - 'scripts/trigger-build.rb' + - 'sidekiq_cluster/cli.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index 49182a51ea7..eef5e580e43 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -1,4 +1,5 @@ --- +# Cop supports --autocorrect. Rails/FilePath: Exclude: - 'app/controllers/help_controller.rb' @@ -12,7 +13,6 @@ Rails/FilePath: - 'config/initializers/1_settings.rb' - 'config/initializers/7_prometheus_metrics.rb' - 'config/initializers/lograge.rb' - - 'config/initializers_before_autoloader/001_fast_gettext.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/services/security/security_orchestration_policies/project_create_service.rb' - 'ee/lib/ee/feature/definition.rb' @@ -57,7 +57,6 @@ Rails/FilePath: - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' - 'lib/system_check/app/uploads_directory_exists_check.rb' - 'lib/system_check/incoming_email/imap_authentication_check.rb' - - 'lib/tasks/gitlab/db.rake' - 'lib/tasks/gitlab/metrics_exporter.rake' - 'lib/tasks/gitlab/usage_data.rake' - 'lib/tasks/tanuki_emoji.rake' @@ -66,10 +65,8 @@ Rails/FilePath: - 'spec/config/object_store_settings_spec.rb' - 'spec/db/development/add_security_training_providers_spec.rb' - 'spec/db/development/create_base_work_item_types_spec.rb' - - 'spec/db/development/import_common_metrics_spec.rb' - 'spec/db/production/add_security_training_providers_spec.rb' - 'spec/db/production/create_base_work_item_types_spec.rb' - - 'spec/db/production/import_common_metrics_spec.rb' - 'spec/db/schema_spec.rb' - 'spec/factories/design_management/designs.rb' - 'spec/factories/design_management/versions.rb' @@ -109,6 +106,7 @@ Rails/FilePath: - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/finder_spec.rb' - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb' + - 'spec/lib/gitlab/multi_destination_logger_spec.rb' - 'spec/lib/gitlab/project_transfer_spec.rb' - 'spec/lib/gitlab/sanitizers/svg_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' diff --git a/.rubocop_todo/rails/output_safety.yml b/.rubocop_todo/rails/output_safety.yml new file mode 100644 index 00000000000..53f9381099f --- /dev/null +++ b/.rubocop_todo/rails/output_safety.yml @@ -0,0 +1,157 @@ +--- +Rails/OutputSafety: + Details: grace period + Exclude: + - 'app/controllers/concerns/confirm_email_warning.rb' + - 'app/controllers/concerns/web_hooks/hook_actions.rb' + - 'app/controllers/groups_controller.rb' + - 'app/controllers/profiles/two_factor_auths_controller.rb' + - 'app/controllers/projects/mirrors_controller.rb' + - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' + - 'app/controllers/projects/pipeline_schedules_controller.rb' + - 'app/controllers/projects/protected_refs_controller.rb' + - 'app/controllers/search_controller.rb' + - 'app/graphql/types/ci/job_trace_type.rb' + - 'app/graphql/types/project_type.rb' + - 'app/helpers/admin/application_settings/settings_helper.rb' + - 'app/helpers/appearances_helper.rb' + - 'app/helpers/auth_helper.rb' + - 'app/helpers/broadcast_messages_helper.rb' + - 'app/helpers/commits_helper.rb' + - 'app/helpers/diff_helper.rb' + - 'app/helpers/dropdowns_helper.rb' + - 'app/helpers/emails_helper.rb' + - 'app/helpers/emoji_helper.rb' + - 'app/helpers/environment_helper.rb' + - 'app/helpers/external_link_helper.rb' + - 'app/helpers/form_helper.rb' + - 'app/helpers/groups/group_members_helper.rb' + - 'app/helpers/groups_helper.rb' + - 'app/helpers/import_helper.rb' + - 'app/helpers/issuables_helper.rb' + - 'app/helpers/issues_helper.rb' + - 'app/helpers/labels_helper.rb' + - 'app/helpers/markup_helper.rb' + - 'app/helpers/members_helper.rb' + - 'app/helpers/merge_requests_helper.rb' + - 'app/helpers/notify_helper.rb' + - 'app/helpers/page_layout_helper.rb' + - 'app/helpers/profiles_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/reminder_emails_helper.rb' + - 'app/helpers/safe_format_helper.rb' + - 'app/helpers/search_helper.rb' + - 'app/helpers/sidebars_helper.rb' + - 'app/helpers/sourcegraph_helper.rb' + - 'app/helpers/tags_helper.rb' + - 'app/helpers/timeboxes_helper.rb' + - 'app/helpers/todos_helper.rb' + - 'app/helpers/tree_helper.rb' + - 'app/helpers/version_check_helper.rb' + - 'app/helpers/visibility_level_helper.rb' + - 'app/helpers/whats_new_helper.rb' + - 'app/mailers/notify.rb' + - 'app/models/concerns/restricted_signup.rb' + - 'app/models/integrations/apple_app_store.rb' + - 'app/models/integrations/asana.rb' + - 'app/models/integrations/bamboo.rb' + - 'app/models/integrations/bugzilla.rb' + - 'app/models/integrations/campfire.rb' + - 'app/models/integrations/clickup.rb' + - 'app/models/integrations/confluence.rb' + - 'app/models/integrations/custom_issue_tracker.rb' + - 'app/models/integrations/datadog.rb' + - 'app/models/integrations/discord.rb' + - 'app/models/integrations/ewm.rb' + - 'app/models/integrations/external_wiki.rb' + - 'app/models/integrations/google_play.rb' + - 'app/models/integrations/hangouts_chat.rb' + - 'app/models/integrations/irker.rb' + - 'app/models/integrations/jenkins.rb' + - 'app/models/integrations/mattermost.rb' + - 'app/models/integrations/pivotaltracker.rb' + - 'app/models/integrations/pumble.rb' + - 'app/models/integrations/redmine.rb' + - 'app/models/integrations/squash_tm.rb' + - 'app/models/integrations/telegram.rb' + - 'app/models/integrations/unify_circuit.rb' + - 'app/models/integrations/webex_teams.rb' + - 'app/models/integrations/youtrack.rb' + - 'app/presenters/ci/pipeline_presenter.rb' + - 'app/presenters/key_presenter.rb' + - 'app/presenters/project_presenter.rb' + - 'app/serializers/analytics/cycle_analytics/stage_entity.rb' + - 'app/serializers/build_details_entity.rb' + - 'app/serializers/entity_date_helper.rb' + - 'app/services/jira/requests/base.rb' + - 'app/services/projects/update_service.rb' + - 'app/services/security/ci_configuration/base_create_service.rb' + - 'app/services/system_notes/commit_service.rb' + - 'ee/app/components/namespaces/combined_storage_users/base_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/base_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/enforcement_at_limit_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/non_owner_enforcement_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/non_owner_notification_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/notification_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/usage_quota_trial_alert_component.rb' + - 'ee/app/components/namespaces/storage/limit_alert_component.rb' + - 'ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb' + - 'ee/app/components/namespaces/storage/repository_limit_alert_component.rb' + - 'ee/app/components/namespaces/storage/user_pre_enforcement_alert_component.rb' + - 'ee/app/controllers/admin/elasticsearch_controller.rb' + - 'ee/app/controllers/admin/geo/application_controller.rb' + - 'ee/app/controllers/admin/licenses_controller.rb' + - 'ee/app/controllers/ee/projects/issues_controller.rb' + - 'ee/app/controllers/ee/projects/mirrors_controller.rb' + - 'ee/app/controllers/ee/repositories/lfs_api_controller.rb' + - 'ee/app/helpers/billing_plans_helper.rb' + - 'ee/app/helpers/ee/application_helper.rb' + - 'ee/app/helpers/ee/geo_helper.rb' + - 'ee/app/helpers/ee/import_helper.rb' + - 'ee/app/helpers/ee/integrations_helper.rb' + - 'ee/app/helpers/ee/labels_helper.rb' + - 'ee/app/helpers/ee/members_helper.rb' + - 'ee/app/helpers/ee/mirror_helper.rb' + - 'ee/app/helpers/ee/search_helper.rb' + - 'ee/app/helpers/ee/users_helper.rb' + - 'ee/app/helpers/push_rules_helper.rb' + - 'ee/app/models/integrations/github.rb' + - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb' + - 'ee/lib/gitlab/email/message/account_validation.rb' + - 'ee/lib/gitlab/expiring_subscription_message.rb' + - 'ee/lib/gitlab/licenses/submit_license_usage_data_banner.rb' + - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' + - 'ee/spec/controllers/admin/licenses_controller_spec.rb' + - 'lib/banzai/filter/autolink_filter.rb' + - 'lib/banzai/filter/references/milestone_reference_filter.rb' + - 'lib/banzai/filter/spaced_link_filter.rb' + - 'lib/banzai/object_renderer.rb' + - 'lib/banzai/renderer.rb' + - 'lib/gitlab/asciidoc.rb' + - 'lib/gitlab/blame.rb' + - 'lib/gitlab/ci/trace/stream.rb' + - 'lib/gitlab/dependency_linker/base_linker.rb' + - 'lib/gitlab/dependency_linker/go_mod_linker.rb' + - 'lib/gitlab/dependency_linker/go_sum_linker.rb' + - 'lib/gitlab/diff/char_diff.rb' + - 'lib/gitlab/diff/highlight.rb' + - 'lib/gitlab/diff/inline_diff_marker.rb' + - 'lib/gitlab/diff/line.rb' + - 'lib/gitlab/diff/rendered/notebook/diff_file_helper.rb' + - 'lib/gitlab/email/message/in_product_marketing/helper.rb' + - 'lib/gitlab/email/message/in_product_marketing/trial.rb' + - 'lib/gitlab/email/message/in_product_marketing/verify.rb' + - 'lib/gitlab/highlight.rb' + - 'lib/gitlab/observability.rb' + - 'lib/gitlab/other_markup.rb' + - 'lib/gitlab/string_range_marker.rb' + - 'spec/helpers/application_helper_spec.rb' + - 'spec/helpers/notify_helper_spec.rb' + - 'spec/helpers/profiles_helper_spec.rb' + - 'spec/helpers/safe_format_helper_spec.rb' + - 'spec/helpers/sidebars_helper_spec.rb' + - 'spec/lib/banzai/filter/output_safety_spec.rb' + - 'spec/lib/gitlab/string_range_marker_spec.rb' + - 'spec/lib/gitlab/string_regex_marker_spec.rb' diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index e8cc0e77ca9..18c225fb9ec 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -112,7 +112,6 @@ RSpec/AnyInstanceOf: - 'spec/features/projects/container_registry_spec.rb' - 'spec/features/projects/files/user_browses_lfs_files_spec.rb' - 'spec/features/projects/jobs_spec.rb' - - 'spec/features/projects/settings/service_desk_setting_spec.rb' - 'spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb' - 'spec/features/snippets/embedded_snippet_spec.rb' - 'spec/features/usage_stats_consent_spec.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml new file mode 100644 index 00000000000..4b58f6fc52f --- /dev/null +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -0,0 +1,1584 @@ +--- +RSpec/BeforeAllRoleAssignment: + Details: grace period + Exclude: + - 'ee/spec/components/namespaces/free_user_cap/non_owner_notification_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb' + - 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb' + - 'ee/spec/components/namespaces/storage/subgroup_pre_enforcement_alert_component_spec.rb' + - 'ee/spec/controllers/autocomplete_controller_spec.rb' + - 'ee/spec/controllers/dashboard_controller_spec.rb' + - 'ee/spec/controllers/ee/dashboard/projects_controller_spec.rb' + - 'ee/spec/controllers/ee/groups/settings/ci_cd_controller_spec.rb' + - 'ee/spec/controllers/ee/groups/usage_quotas_controller_spec.rb' + - 'ee/spec/controllers/ee/groups_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/autocomplete_sources_controller_spec.rb' + - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/coverage_reports_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/repository_analytics_controller_spec.rb' + - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' + - 'ee/spec/controllers/groups/billings_controller_spec.rb' + - 'ee/spec/controllers/groups/clusters_controller_spec.rb' + - 'ee/spec/controllers/groups/contribution_analytics_controller_spec.rb' + - 'ee/spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb' + - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' + - 'ee/spec/controllers/groups/insights_controller_spec.rb' + - 'ee/spec/controllers/groups/issues_analytics_controller_spec.rb' + - 'ee/spec/controllers/groups/merge_requests_controller_spec.rb' + - 'ee/spec/controllers/groups/push_rules_controller_spec.rb' + - 'ee/spec/controllers/groups/runners_controller_spec.rb' + - 'ee/spec/controllers/groups/seat_usage_controller_spec.rb' + - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' + - 'ee/spec/controllers/groups/todos_controller_spec.rb' + - 'ee/spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' + - 'ee/spec/controllers/projects/analytics/issues_analytics_controller_spec.rb' + - 'ee/spec/controllers/projects/analytics/merge_request_analytics_controller_spec.rb' + - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' + - 'ee/spec/controllers/projects/environments_controller_spec.rb' + - 'ee/spec/controllers/projects/incident_management/escalation_policies_controller_spec.rb' + - 'ee/spec/controllers/projects/incident_management/oncall_schedules_controller_spec.rb' + - 'ee/spec/controllers/projects/insights_controller_spec.rb' + - 'ee/spec/controllers/projects/issue_links_controller_spec.rb' + - 'ee/spec/controllers/projects/iterations_controller_spec.rb' + - 'ee/spec/controllers/projects/learn_gitlab_controller_spec.rb' + - 'ee/spec/controllers/projects/licenses_controller_spec.rb' + - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' + - 'ee/spec/controllers/projects/pipelines_controller_spec.rb' + - 'ee/spec/controllers/projects/repositories_controller_spec.rb' + - 'ee/spec/controllers/projects/requirements_management/requirements_controller_spec.rb' + - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' + - 'ee/spec/controllers/projects/security/dashboard_controller_spec.rb' + - 'ee/spec/controllers/projects/security/scanned_resources_controller_spec.rb' + - 'ee/spec/controllers/projects/security/vulnerabilities/notes_controller_spec.rb' + - 'ee/spec/controllers/projects/security/vulnerabilities_controller_spec.rb' + - 'ee/spec/controllers/projects/security/vulnerability_report_controller_spec.rb' + - 'ee/spec/controllers/projects/settings/ci_cd_controller_spec.rb' + - 'ee/spec/controllers/projects/settings/integrations_controller_spec.rb' + - 'ee/spec/controllers/projects/settings/operations_controller_spec.rb' + - 'ee/spec/controllers/projects/settings/repository_controller_spec.rb' + - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' + - 'ee/spec/controllers/projects_controller_spec.rb' + - 'ee/spec/controllers/registrations/groups_controller_spec.rb' + - 'ee/spec/controllers/security/projects_controller_spec.rb' + - 'ee/spec/controllers/subscriptions_controller_spec.rb' + - 'ee/spec/features/admin/admin_sends_notification_spec.rb' + - 'ee/spec/features/analytics/code_analytics_spec.rb' + - 'ee/spec/features/analytics/group_analytics_spec.rb' + - 'ee/spec/features/boards/board_filters_spec.rb' + - 'ee/spec/features/boards/boards_licensed_features_spec.rb' + - 'ee/spec/features/boards/new_issue_spec.rb' + - 'ee/spec/features/boards/scoped_issue_board_spec.rb' + - 'ee/spec/features/boards/sidebar_spec.rb' + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_spec.rb' + - 'ee/spec/features/burnup_charts_spec.rb' + - 'ee/spec/features/ci/ci_catalog_spec.rb' + - 'ee/spec/features/dashboards/todos_spec.rb' + - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' + - 'ee/spec/features/epic_boards/epic_boards_spec.rb' + - 'ee/spec/features/epic_boards/new_epic_spec.rb' + - 'ee/spec/features/epics/epic_show_spec.rb' + - 'ee/spec/features/epics/user_uses_quick_actions_spec.rb' + - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb' + - 'ee/spec/features/group_protected_branches_spec.rb' + - 'ee/spec/features/groups/analytics/ci_cd_analytics_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' + - 'ee/spec/features/groups/audit_events_spec.rb' + - 'ee/spec/features/groups/group_roadmap_spec.rb' + - 'ee/spec/features/groups/groups_security_credentials_spec.rb' + - 'ee/spec/features/groups/hooks/user_adds_hook_spec.rb' + - 'ee/spec/features/groups/hooks/user_edits_hooks_spec.rb' + - 'ee/spec/features/groups/hooks/user_views_hooks_spec.rb' + - 'ee/spec/features/groups/members/list_members_spec.rb' + - 'ee/spec/features/groups/members/manage_members_spec.rb' + - 'ee/spec/features/groups/navbar_spec.rb' + - 'ee/spec/features/groups/new_spec.rb' + - 'ee/spec/features/groups/push_rules_spec.rb' + - 'ee/spec/features/groups/saml_group_links_spec.rb' + - 'ee/spec/features/groups/scim_token_spec.rb' + - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' + - 'ee/spec/features/groups/settings/user_searches_in_settings_spec.rb' + - 'ee/spec/features/groups/usage_quotas/seats_tab_spec.rb' + - 'ee/spec/features/groups/user_interacts_with_unlimited_members_during_trial_alert_spec.rb' + - 'ee/spec/features/groups_spec.rb' + - 'ee/spec/features/incidents/user_uses_quick_actions_spec.rb' + - 'ee/spec/features/issues/epic_in_issue_sidebar_spec.rb' + - 'ee/spec/features/issues/filtered_search/filter_issues_by_health_spec.rb' + - 'ee/spec/features/issues/filtered_search/filter_issues_epic_spec.rb' + - 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb' + - 'ee/spec/features/issues/gfm_autocomplete_ee_spec.rb' + - 'ee/spec/features/issues/issue_sidebar_spec.rb' + - 'ee/spec/features/issues/related_issues_spec.rb' + - 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb' + - 'ee/spec/features/issues/user_sees_empty_state_spec.rb' + - 'ee/spec/features/issues/user_uses_quick_actions_spec.rb' + - 'ee/spec/features/markdown/observability_spec.rb' + - 'ee/spec/features/merge_request/user_creates_merge_request_spec.rb' + - 'ee/spec/features/merge_request/user_edits_approval_rules_mr_spec.rb' + - 'ee/spec/features/merge_request/user_sees_mr_approvals_promo_spec.rb' + - 'ee/spec/features/merge_request/user_sees_security_widget_spec.rb' + - 'ee/spec/features/merge_request/user_sees_status_checks_widget_spec.rb' + - 'ee/spec/features/merge_request/user_sets_approval_rules_spec.rb' + - 'ee/spec/features/merge_request/user_sets_approvers_spec.rb' + - 'ee/spec/features/milestones/user_views_milestone_spec.rb' + - 'ee/spec/features/oncall_schedules/user_creates_schedule_spec.rb' + - 'ee/spec/features/projects/analytics/cycle_analytics_spec.rb' + - 'ee/spec/features/projects/analytics/dashboards_spec.rb' + - 'ee/spec/features/projects/analytics/visualization_designer_spec.rb' + - 'ee/spec/features/projects/audit_events_spec.rb' + - 'ee/spec/features/projects/issues/user_creates_issue_spec.rb' + - 'ee/spec/features/projects/iterations/iteration_cadences_list_spec.rb' + - 'ee/spec/features/projects/members/manage_members_spec.rb' + - 'ee/spec/features/projects/navbar_spec.rb' + - 'ee/spec/features/projects/quality/shortcuts_test_case_spec.rb' + - 'ee/spec/features/projects/quality/test_case_create_spec.rb' + - 'ee/spec/features/projects/quality/test_case_list_spec.rb' + - 'ee/spec/features/projects/quality/test_case_show_spec.rb' + - 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb' + - 'ee/spec/features/projects/security/vulnerability_report_spec.rb' + - 'ee/spec/features/projects/settings/disable_merge_trains_setting_spec.rb' + - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' + - 'ee/spec/features/projects/settings/merge_request_approvals_settings_spec.rb' + - 'ee/spec/features/projects/settings/merge_requests/disable_merge_trains_setting_spec.rb' + - 'ee/spec/features/projects/settings/merge_requests_settings_spec.rb' + - 'ee/spec/features/projects/settings/user_manages_members_spec.rb' + - 'ee/spec/features/projects/show_project_spec.rb' + - 'ee/spec/features/projects/user_interacts_with_unlimited_members_during_trial_alert_spec.rb' + - 'ee/spec/features/projects/wiki/user_views_wiki_empty_spec.rb' + - 'ee/spec/features/projects_spec.rb' + - 'ee/spec/features/protected_branches_spec.rb' + - 'ee/spec/features/search/user_searches_for_epics_spec.rb' + - 'ee/spec/features/search/zoekt/search_spec.rb' + - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' + - 'ee/spec/features/trials/show_trial_banner_spec.rb' + - 'ee/spec/finders/approval_rules/group_finder_spec.rb' + - 'ee/spec/finders/compliance_management/merge_requests/compliance_violations_finder_spec.rb' + - 'ee/spec/finders/concerns/epics/with_access_check_spec.rb' + - 'ee/spec/finders/ee/ci/daily_build_group_report_results_finder_spec.rb' + - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' + - 'ee/spec/finders/ee/projects_finder_spec.rb' + - 'ee/spec/finders/ee/work_items/work_items_finder_spec.rb' + - 'ee/spec/finders/epics/cross_hierarchy_ancestors_finder_spec.rb' + - 'ee/spec/finders/epics/cross_hierarchy_children_finder_spec.rb' + - 'ee/spec/finders/epics_finder_spec.rb' + - 'ee/spec/finders/incident_management/escalation_policies_finder_spec.rb' + - 'ee/spec/finders/incident_management/issuable_resource_links_finder_spec.rb' + - 'ee/spec/finders/incident_management/oncall_schedules_finder_spec.rb' + - 'ee/spec/finders/iterations/cadences_finder_spec.rb' + - 'ee/spec/finders/iterations_finder_spec.rb' + - 'ee/spec/finders/merge_requests_finder_spec.rb' + - 'ee/spec/finders/snippets_finder_spec.rb' + - 'ee/spec/frontend/fixtures/analytics/charts.rb' + - 'ee/spec/frontend/fixtures/analytics/contributions_spec.rb' + - 'ee/spec/frontend/fixtures/dast_profiles.rb' + - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' + - 'ee/spec/frontend/fixtures/users.rb' + - 'ee/spec/graphql/ee/mutations/boards/issues/issue_move_list_spec.rb' + - 'ee/spec/graphql/ee/mutations/ci/job_token_scope/add_project_spec.rb' + - 'ee/spec/graphql/ee/mutations/ci/job_token_scope/remove_project_spec.rb' + - 'ee/spec/graphql/ee/resolvers/project_issues_resolver_spec.rb' + - 'ee/spec/graphql/ee/types/clusters/agent_type_spec.rb' + - 'ee/spec/graphql/ee/types/group_type_spec.rb' + - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' + - 'ee/spec/graphql/mutations/boards/epic_boards/destroy_spec.rb' + - 'ee/spec/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' + - 'ee/spec/graphql/mutations/boards/epic_boards/update_spec.rb' + - 'ee/spec/graphql/mutations/boards/update_epic_user_preferences_spec.rb' + - 'ee/spec/graphql/mutations/ci/ai/generate_config_spec.rb' + - 'ee/spec/graphql/mutations/compliance_management/frameworks/create_spec.rb' + - 'ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' + - 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb' + - 'ee/spec/graphql/mutations/dast/profiles/delete_spec.rb' + - 'ee/spec/graphql/mutations/dast/profiles/run_spec.rb' + - 'ee/spec/graphql/mutations/dast/profiles/update_spec.rb' + - 'ee/spec/graphql/mutations/dast_scanner_profiles/delete_spec.rb' + - 'ee/spec/graphql/mutations/dast_scanner_profiles/update_spec.rb' + - 'ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb' + - 'ee/spec/graphql/mutations/dast_site_profiles/update_spec.rb' + - 'ee/spec/graphql/mutations/dast_site_validations/revoke_spec.rb' + - 'ee/spec/graphql/mutations/epics/add_issue_spec.rb' + - 'ee/spec/graphql/mutations/epics/create_spec.rb' + - 'ee/spec/graphql/mutations/epics/update_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/escalation_policy/create_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/escalation_policy/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/escalation_policy/update_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/issuable_resource_link/create_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/issuable_resource_link/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_rotation/create_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_rotation/update_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/create_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb' + - 'ee/spec/graphql/mutations/instance_security_dashboard/add_project_spec.rb' + - 'ee/spec/graphql/mutations/issues/promote_to_epic_spec.rb' + - 'ee/spec/graphql/mutations/issues/set_epic_spec.rb' + - 'ee/spec/graphql/mutations/issues/update_spec.rb' + - 'ee/spec/graphql/mutations/projects/set_compliance_framework_spec.rb' + - 'ee/spec/graphql/mutations/projects/set_locked_spec.rb' + - 'ee/spec/graphql/mutations/releases/update_spec.rb' + - 'ee/spec/graphql/mutations/requirements_management/create_requirement_spec.rb' + - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb' + - 'ee/spec/graphql/mutations/requirements_management/update_requirement_spec.rb' + - 'ee/spec/graphql/mutations/security/training_provider_update_spec.rb' + - 'ee/spec/graphql/mutations/security_policy/create_security_policy_project_spec.rb' + - 'ee/spec/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' + - 'ee/spec/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/board_groupings/epics_resolvers_spec.rb' + - 'ee/spec/graphql/resolvers/boards/board_list_epics_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/boards/epic_boards_resolvers_spec.rb' + - 'ee/spec/graphql/resolvers/boards/epic_list_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/boards/epic_lists_resolvers_spec.rb' + - 'ee/spec/graphql/resolvers/ci/catalog/resource_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/ci/catalog/resources_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/ci/catalog/versions_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/dast_site_validation_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/epic_ancestors_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/epic_issues_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/epics/children_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/epics/default_project_for_issue_creation_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/incident_management/escalation_policies_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/incident_management/issuable_resource_links_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/incident_management/oncall_rotations_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/incident_management/oncall_schedule_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/incident_management/oncall_shifts_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/incident_management/oncall_users_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/iterations_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/product_analytics/dashboards_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/product_analytics/state_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/requirements_management/test_reports_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/security_training_urls_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/vulnerabilities/container_images_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/vulnerabilities/scanners_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/vulnerabilities_count_per_day_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' + - 'ee/spec/graphql/types/asset_type_spec.rb' + - 'ee/spec/graphql/types/boards/board_epic_type_spec.rb' + - 'ee/spec/graphql/types/ci/pipeline_type_spec.rb' + - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' + - 'ee/spec/graphql/types/dast_site_validation_type_spec.rb' + - 'ee/spec/graphql/types/instance_security_dashboard_type_spec.rb' + - 'ee/spec/graphql/types/issue_type_spec.rb' + - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' + - 'ee/spec/graphql/types/project_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_evidence_source_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_evidence_supporting_message_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_evidence_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_location/coverage_fuzzing_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_scanner_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_type_spec.rb' + - 'ee/spec/helpers/ee/ci/catalog/resources_helper_spec.rb' + - 'ee/spec/helpers/ee/ci/pipeline_editor_helper_spec.rb' + - 'ee/spec/helpers/ee/environments_helper_spec.rb' + - 'ee/spec/helpers/ee/groups_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' + - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' + - 'ee/spec/helpers/merge_requests_helper_spec.rb' + - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' + - 'ee/spec/helpers/projects/project_members_helper_spec.rb' + - 'ee/spec/helpers/projects_helper_spec.rb' + - 'ee/spec/helpers/subscriptions_helper_spec.rb' + - 'ee/spec/helpers/timeboxes_helper_spec.rb' + - 'ee/spec/helpers/tree_helper_spec.rb' + - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' + - 'ee/spec/helpers/web_hooks/web_hooks_helper_spec.rb' + - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' + - 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/project_feature_changes_auditor_spec.rb' + - 'ee/spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' + - 'ee/spec/lib/bulk_imports/groups/pipelines/epics_pipeline_spec.rb' + - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' + - 'ee/spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' + - 'ee/spec/lib/ee/api/entities/group_detail_spec.rb' + - 'ee/spec/lib/ee/api/helpers/issues_helpers_spec.rb' + - 'ee/spec/lib/ee/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/abilities_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/after_config_spec.rb' + - 'ee/spec/lib/ee/gitlab/git_access_project_spec.rb' + - 'ee/spec/lib/ee/gitlab/import_export/project/tree_saver_spec.rb' + - 'ee/spec/lib/elastic/latest/git_class_proxy_spec.rb' + - 'ee/spec/lib/elastic/latest/user_instance_proxy_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/stage_time_summary_spec.rb' + - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb' + - 'ee/spec/lib/gitlab/code_owners/loader_spec.rb' + - 'ee/spec/lib/gitlab/code_owners/validator_spec.rb' + - 'ee/spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb' + - 'ee/spec/lib/gitlab/elastic/project_search_results_spec.rb' + - 'ee/spec/lib/gitlab/git_access_spec.rb' + - 'ee/spec/lib/gitlab/git_access_wiki_spec.rb' + - 'ee/spec/lib/gitlab/llm/chain/agents/zero_shot/executor_spec.rb' + - 'ee/spec/lib/gitlab/llm/chain/tools/gitlab_documentation/executor_spec.rb' + - 'ee/spec/lib/gitlab/llm/chain/tools/issue_identifier/executor_spec.rb' + - 'ee/spec/lib/gitlab/llm/chain/tools/summarize_comments/executor_spec.rb' + - 'ee/spec/lib/gitlab/quick_actions/users_extractor_spec.rb' + - 'ee/spec/lib/gitlab/reference_extractor_spec.rb' + - 'ee/spec/models/ai/project/conversations_spec.rb' + - 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb' + - 'ee/spec/models/dast/profile_schedule_spec.rb' + - 'ee/spec/models/ee/award_emoji_spec.rb' + - 'ee/spec/models/ee/group_spec.rb' + - 'ee/spec/models/ee/namespaces/namespace_ban_spec.rb' + - 'ee/spec/models/ee/project_authorization_spec.rb' + - 'ee/spec/models/ee/project_group_link_spec.rb' + - 'ee/spec/models/ee/user_spec.rb' + - 'ee/spec/models/ee/vulnerability_spec.rb' + - 'ee/spec/models/epic_issue_spec.rb' + - 'ee/spec/models/epic_spec.rb' + - 'ee/spec/models/group_member_spec.rb' + - 'ee/spec/models/instance_security_dashboard_spec.rb' + - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/models/merge_request_spec.rb' + - 'ee/spec/models/vulnerabilities/projects_grade_spec.rb' + - 'ee/spec/policies/app_sec/fuzzing/coverage/corpus_policy_spec.rb' + - 'ee/spec/policies/ci/editor/ai_conversation/message_policy_spec.rb' + - 'ee/spec/policies/ci/job_artifact_policy_spec.rb' + - 'ee/spec/policies/compliance_management/framework_policy_spec.rb' + - 'ee/spec/policies/dependencies/dependency_list_export_policy_spec.rb' + - 'ee/spec/policies/epic_policy_spec.rb' + - 'ee/spec/policies/event_policy_spec.rb' + - 'ee/spec/policies/global_policy_spec.rb' + - 'ee/spec/policies/group_policy_spec.rb' + - 'ee/spec/policies/identity_provider_policy_spec.rb' + - 'ee/spec/policies/incident_management/oncall_rotation_policy_spec.rb' + - 'ee/spec/policies/incident_management/oncall_schedule_policy_spec.rb' + - 'ee/spec/policies/incident_management/oncall_shift_policy_spec.rb' + - 'ee/spec/policies/issue_policy_spec.rb' + - 'ee/spec/policies/merge_request/diff_llm_summary_policy_spec.rb' + - 'ee/spec/policies/merge_request_policy_spec.rb' + - 'ee/spec/policies/merge_requests/external_status_check_policy_spec.rb' + - 'ee/spec/policies/packages/policies/project_policy_spec.rb' + - 'ee/spec/policies/project_policy_spec.rb' + - 'ee/spec/policies/requirements_management/requirement_policy_spec.rb' + - 'ee/spec/policies/resource_iteration_event_policy_spec.rb' + - 'ee/spec/policies/resource_weight_event_policy_spec.rb' + - 'ee/spec/policies/security/scan_policy_spec.rb' + - 'ee/spec/policies/vulnerabilities/issue_link_policy_spec.rb' + - 'ee/spec/policies/vulnerabilities/merge_request_link_policy_spec.rb' + - 'ee/spec/presenters/approval_rule_presenter_spec.rb' + - 'ee/spec/requests/admin/credentials_controller_spec.rb' + - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' + - 'ee/spec/requests/api/award_emoji_spec.rb' + - 'ee/spec/requests/api/ci/jobs_spec.rb' + - 'ee/spec/requests/api/ci/triggers_spec.rb' + - 'ee/spec/requests/api/commits_spec.rb' + - 'ee/spec/requests/api/composer_packages_spec.rb' + - 'ee/spec/requests/api/conan_project_packages_spec.rb' + - 'ee/spec/requests/api/debian_group_packages_spec.rb' + - 'ee/spec/requests/api/debian_project_packages_spec.rb' + - 'ee/spec/requests/api/dependencies_spec.rb' + - 'ee/spec/requests/api/dependency_list_exports_spec.rb' + - 'ee/spec/requests/api/deployments_spec.rb' + - 'ee/spec/requests/api/epic_links_spec.rb' + - 'ee/spec/requests/api/experiments_spec.rb' + - 'ee/spec/requests/api/generic_packages_spec.rb' + - 'ee/spec/requests/api/go_proxy_spec.rb' + - 'ee/spec/requests/api/graphql/app_sec/fuzzing/api/ci_configuration_type_spec.rb' + - 'ee/spec/requests/api/graphql/app_sec/fuzzing/coverage/corpus_type_spec.rb' + - 'ee/spec/requests/api/graphql/boards/boards_query_spec.rb' + - 'ee/spec/requests/api/graphql/boards/epic_board_list_epics_query_spec.rb' + - 'ee/spec/requests/api/graphql/boards/epic_boards_query_spec.rb' + - 'ee/spec/requests/api/graphql/boards/epic_lists_query_spec.rb' + - 'ee/spec/requests/api/graphql/ci/catalog/resources_spec.rb' + - 'ee/spec/requests/api/graphql/ci/minutes/usage_spec.rb' + - 'ee/spec/requests/api/graphql/compliance_management/merge_requests/compliance_violations_spec.rb' + - 'ee/spec/requests/api/graphql/dora/dora_scores_spec.rb' + - 'ee/spec/requests/api/graphql/epics/epic_resolver_spec.rb' + - 'ee/spec/requests/api/graphql/gitlab_subscriptions/preview_billable_user_change_spec.rb' + - 'ee/spec/requests/api/graphql/group/dast_profile_schedule_spec.rb' + - 'ee/spec/requests/api/graphql/group/epic/epic_aggregate_query_spec.rb' + - 'ee/spec/requests/api/graphql/group/epic/epic_ancestors_spec.rb' + - 'ee/spec/requests/api/graphql/group/epic/epic_children_spec.rb' + - 'ee/spec/requests/api/graphql/group/epic/epic_issues_spec.rb' + - 'ee/spec/requests/api/graphql/group/epics_spec.rb' + - 'ee/spec/requests/api/graphql/group/external_audit_event_destinations_spec.rb' + - 'ee/spec/requests/api/graphql/group_query_spec.rb' + - 'ee/spec/requests/api/graphql/incident_management/issuable_resource_links_spec.rb' + - 'ee/spec/requests/api/graphql/instance_security_dashboard_spec.rb' + - 'ee/spec/requests/api/graphql/issue/issue_spec.rb' + - 'ee/spec/requests/api/graphql/iterations/cadences_spec.rb' + - 'ee/spec/requests/api/graphql/iterations/iterations_spec.rb' + - 'ee/spec/requests/api/graphql/merge_requests/finding_reports_comparer_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/google_cloud_logging_configurations/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/google_cloud_logging_configurations/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/google_cloud_logging_configurations/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/epics/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/lists/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/update_epic_user_preferences_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/ci/catalog/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/ci/namespace_ci_cd_settings_update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epic_tree/reorder_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epics/add_issue_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epics/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/escalation_policy/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/escalation_policy/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/escalation_policy/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/issuable_resource_link/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/issuable_resource_link/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_schedule/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/issues/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/issues/set_epic_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/issues/set_escalation_policy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/issues/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/delete_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/members/groups/ee/bulk_update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/merge_requests/set_assignees_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/merge_requests/update_approval_rule_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/notes/create/note_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/projects/chat_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/projects/initialize_product_analytics_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/projects/lock_path_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/projects/set_compliance_framework_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/releases/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/requirements_management/create_requirement_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/requirements_management/export_requirements_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/requirements_management/update_requirement_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security/finding/create_issue_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security_policy/assign_security_policy_project_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security_policy/create_security_policy_project_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/users/abuse/namespace_bans/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_issue_link_spec.rb' + - 'ee/spec/requests/api/graphql/namespace/compliance_frameworks_spec.rb' + - 'ee/spec/requests/api/graphql/namespace/projects_spec.rb' + - 'ee/spec/requests/api/graphql/pipeline_security_report_finding_spec.rb' + - 'ee/spec/requests/api/graphql/product_analytics/dashboards_spec.rb' + - 'ee/spec/requests/api/graphql/product_analytics/project_visualizations_spec.rb' + - 'ee/spec/requests/api/graphql/project/alert_management/integrations_spec.rb' + - 'ee/spec/requests/api/graphql/project/branch_rules/approval_project_rules_spec.rb' + - 'ee/spec/requests/api/graphql/project/branch_rules/branch_protection_spec.rb' + - 'ee/spec/requests/api/graphql/project/branch_rules/external_status_checks_spec.rb' + - 'ee/spec/requests/api/graphql/project/branch_rules_spec.rb' + - 'ee/spec/requests/api/graphql/project/compliance_framework_filters_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_profile_schedule_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_profile_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_profiles_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_scanner_profiles_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_site_profile_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_site_profiles_spec.rb' + - 'ee/spec/requests/api/graphql/project/dast_site_validations_spec.rb' + - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policies_spec.rb' + - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policy/rules_spec.rb' + - 'ee/spec/requests/api/graphql/project/incident_management/oncall_schedules_spec.rb' + - 'ee/spec/requests/api/graphql/project/issue_status_counts_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/code_quality_report_summary_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/code_quality_reports_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/dast_profile_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/security_report_finding_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/security_report_findings_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipelines/dast_profile_spec.rb' + - 'ee/spec/requests/api/graphql/project/product_analytics_spec.rb' + - 'ee/spec/requests/api/graphql/project/requirements_management/requirement_counts_spec.rb' + - 'ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb' + - 'ee/spec/requests/api/graphql/project/requirements_management/test_reports_spec.rb' + - 'ee/spec/requests/api/graphql/project/security_orchestration/scan_result_policy_spec.rb' + - 'ee/spec/requests/api/graphql/project/vulnerability_severities_count_spec.rb' + - 'ee/spec/requests/api/graphql/subscriptions/ai_completion_response_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/description_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/details_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/external_issue_links_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/identifiers_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/issue_links_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/location_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/primary_identifier_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/scanner_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/sort_spec.rb' + - 'ee/spec/requests/api/group_hooks_spec.rb' + - 'ee/spec/requests/api/groups_spec.rb' + - 'ee/spec/requests/api/helm_packages_spec.rb' + - 'ee/spec/requests/api/internal/base_spec.rb' + - 'ee/spec/requests/api/invitations_spec.rb' + - 'ee/spec/requests/api/issue_links_spec.rb' + - 'ee/spec/requests/api/issues_spec.rb' + - 'ee/spec/requests/api/managed_licenses_spec.rb' + - 'ee/spec/requests/api/maven_packages_spec.rb' + - 'ee/spec/requests/api/member_roles_spec.rb' + - 'ee/spec/requests/api/members_spec.rb' + - 'ee/spec/requests/api/merge_request_approval_settings_spec.rb' + - 'ee/spec/requests/api/merge_requests_spec.rb' + - 'ee/spec/requests/api/namespaces_spec.rb' + - 'ee/spec/requests/api/npm_project_packages_spec.rb' + - 'ee/spec/requests/api/nuget_group_packages_spec.rb' + - 'ee/spec/requests/api/nuget_project_packages_spec.rb' + - 'ee/spec/requests/api/project_mirror_spec.rb' + - 'ee/spec/requests/api/project_push_rule_spec.rb' + - 'ee/spec/requests/api/projects_spec.rb' + - 'ee/spec/requests/api/protected_branches_spec.rb' + - 'ee/spec/requests/api/protected_environments_spec.rb' + - 'ee/spec/requests/api/pypi_packages_spec.rb' + - 'ee/spec/requests/api/related_epic_links_spec.rb' + - 'ee/spec/requests/api/remote_mirrors_spec.rb' + - 'ee/spec/requests/api/repositories_spec.rb' + - 'ee/spec/requests/api/rubygem_packages_spec.rb' + - 'ee/spec/requests/api/saml_group_links_spec.rb' + - 'ee/spec/requests/api/search_spec.rb' + - 'ee/spec/requests/api/todos_spec.rb' + - 'ee/spec/requests/api/v3/github_spec.rb' + - 'ee/spec/requests/api/vulnerabilities_spec.rb' + - 'ee/spec/requests/api/vulnerability_exports_spec.rb' + - 'ee/spec/requests/api/vulnerability_findings_spec.rb' + - 'ee/spec/requests/api/vulnerability_issue_links_spec.rb' + - 'ee/spec/requests/ee/groups/autocomplete_sources_spec.rb' + - 'ee/spec/requests/ee/groups/settings/repository_controller_spec.rb' + - 'ee/spec/requests/ee/projects/cycle_analytics_controller_spec.rb' + - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' + - 'ee/spec/requests/ee/projects/repositories_controller_spec.rb' + - 'ee/spec/requests/ee/projects/service_desk_controller_spec.rb' + - 'ee/spec/requests/git_http_geo_spec.rb' + - 'ee/spec/requests/git_http_spec.rb' + - 'ee/spec/requests/groups/analytics/devops_adoption_controller_spec.rb' + - 'ee/spec/requests/groups/dependencies_controller_spec.rb' + - 'ee/spec/requests/groups/epics/epic_links_controller_spec.rb' + - 'ee/spec/requests/groups/protected_branches_controller_spec.rb' + - 'ee/spec/requests/groups/security/compliance_framework_reports_controller_spec.rb' + - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' + - 'ee/spec/requests/groups/service_accounts_controller_spec.rb' + - 'ee/spec/requests/groups/settings/merge_requests_controller_spec.rb' + - 'ee/spec/requests/groups/two_factor_auths_controller_spec.rb' + - 'ee/spec/requests/jwt_controller_spec.rb' + - 'ee/spec/requests/lfs_locks_api_spec.rb' + - 'ee/spec/requests/projects/analytics/cycle_analytics/stages_controller_spec.rb' + - 'ee/spec/requests/projects/ci/catalog/resources_controller_spec.rb' + - 'ee/spec/requests/projects/dependencies_controller_spec.rb' + - 'ee/spec/requests/projects/issues_controller_spec.rb' + - 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb' + - 'ee/spec/requests/projects/pipelines/email_campaigns_controller_spec.rb' + - 'ee/spec/requests/projects/requirements_management/requirements_controller_spec.rb' + - 'ee/spec/requests/projects/security/dast_configuration_controller_spec.rb' + - 'ee/spec/requests/projects/security/dast_scanner_profiles_controller_spec.rb' + - 'ee/spec/requests/projects/security/policies_controller_spec.rb' + - 'ee/spec/requests/projects/security/scanned_resources_controller_spec.rb' + - 'ee/spec/requests/projects/settings/access_tokens_controller_spec.rb' + - 'ee/spec/requests/registrations/groups_controller_spec.rb' + - 'ee/spec/requests/repositories/git_http_controller_spec.rb' + - 'ee/spec/serializers/clusters/environment_entity_spec.rb' + - 'ee/spec/serializers/dependency_list_serializer_spec.rb' + - 'ee/spec/serializers/ee/deployment_entity_spec.rb' + - 'ee/spec/serializers/ee/issue_sidebar_basic_entity_spec.rb' + - 'ee/spec/serializers/epics/related_epic_entity_spec.rb' + - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb' + - 'ee/spec/serializers/security/vulnerability_report_data_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/feedback_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/issue_link_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/merge_request_link_entity_spec.rb' + - 'ee/spec/services/alert_management/extract_alert_payload_fields_service_spec.rb' + - 'ee/spec/services/app_sec/dast/profiles/destroy_service_spec.rb' + - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' + - 'ee/spec/services/app_sec/dast/scans/create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/scans/run_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/destroy_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profiles/create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profiles/update_service_spec.rb' + - 'ee/spec/services/approval_rules/create_service_spec.rb' + - 'ee/spec/services/approval_rules/update_service_spec.rb' + - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' + - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' + - 'ee/spec/services/award_emojis/add_service_spec.rb' + - 'ee/spec/services/award_emojis/destroy_service_spec.rb' + - 'ee/spec/services/boards/epic_lists/destroy_service_spec.rb' + - 'ee/spec/services/boards/epics/create_service_spec.rb' + - 'ee/spec/services/boards/epics/list_service_spec.rb' + - 'ee/spec/services/boards/epics/move_service_spec.rb' + - 'ee/spec/services/boards/epics/position_create_service_spec.rb' + - 'ee/spec/services/boards/update_service_spec.rb' + - 'ee/spec/services/ci/catalog/add_resource_service_spec.rb' + - 'ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/needs_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/runnable_builds_spec.rb' + - 'ee/spec/services/ci/llm/async_generate_config_service_spec.rb' + - 'ee/spec/services/ci/pipeline_trigger_service_spec.rb' + - 'ee/spec/services/ci/process_pipeline_service_spec.rb' + - 'ee/spec/services/ci/retry_pipeline_service_spec.rb' + - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' + - 'ee/spec/services/compliance_management/frameworks/destroy_service_spec.rb' + - 'ee/spec/services/compliance_management/frameworks/export_service_spec.rb' + - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' + - 'ee/spec/services/compliance_management/projects/create_ci_config_service_spec.rb' + - 'ee/spec/services/deployments/approval_service_spec.rb' + - 'ee/spec/services/dora/aggregate_metrics_service_spec.rb' + - 'ee/spec/services/ee/alert_management/create_alert_issue_service_spec.rb' + - 'ee/spec/services/ee/alert_management/http_integrations/create_service_spec.rb' + - 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb' + - 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb' + - 'ee/spec/services/ee/authorized_project_update/project_recalculate_service_spec.rb' + - 'ee/spec/services/ee/design_management/delete_designs_service_spec.rb' + - 'ee/spec/services/ee/design_management/save_designs_service_spec.rb' + - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' + - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' + - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' + - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' + - 'ee/spec/services/ee/groups/group_links/create_service_spec.rb' + - 'ee/spec/services/ee/groups/group_links/destroy_service_spec.rb' + - 'ee/spec/services/ee/groups/group_links/update_service_spec.rb' + - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' + - 'ee/spec/services/ee/issues/clone_service_spec.rb' + - 'ee/spec/services/ee/issues/close_service_spec.rb' + - 'ee/spec/services/ee/issues/create_service_spec.rb' + - 'ee/spec/services/ee/issues/reopen_service_spec.rb' + - 'ee/spec/services/ee/issues/update_service_spec.rb' + - 'ee/spec/services/ee/members/approve_access_request_service_spec.rb' + - 'ee/spec/services/ee/members/create_service_spec.rb' + - 'ee/spec/services/ee/members/destroy_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_reviewers_service_spec.rb' + - 'ee/spec/services/ee/notes/quick_actions_service_spec.rb' + - 'ee/spec/services/ee/notification_service_spec.rb' + - 'ee/spec/services/ee/post_receive_service_spec.rb' + - 'ee/spec/services/ee/protected_branches/create_service_spec.rb' + - 'ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb' + - 'ee/spec/services/ee/two_factor/destroy_service_spec.rb' + - 'ee/spec/services/ee/work_items/import_csv_service_spec.rb' + - 'ee/spec/services/epic_issues/create_service_spec.rb' + - 'ee/spec/services/epic_issues/update_service_spec.rb' + - 'ee/spec/services/epics/close_service_spec.rb' + - 'ee/spec/services/epics/create_service_spec.rb' + - 'ee/spec/services/epics/epic_links/create_service_spec.rb' + - 'ee/spec/services/epics/issue_promote_service_spec.rb' + - 'ee/spec/services/epics/related_epic_links/create_service_spec.rb' + - 'ee/spec/services/epics/related_epic_links/list_service_spec.rb' + - 'ee/spec/services/epics/reopen_service_spec.rb' + - 'ee/spec/services/epics/transfer_service_spec.rb' + - 'ee/spec/services/epics/tree_reorder_service_spec.rb' + - 'ee/spec/services/epics/update_service_spec.rb' + - 'ee/spec/services/external_status_checks/retry_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' + - 'ee/spec/services/group_saml/saml_group_links/create_service_spec.rb' + - 'ee/spec/services/groups/destroy_service_spec.rb' + - 'ee/spec/services/groups/enterprise_users/associate_service_spec.rb' + - 'ee/spec/services/groups/epics_count_service_spec.rb' + - 'ee/spec/services/groups/transfer_service_spec.rb' + - 'ee/spec/services/ide/schemas_config_service_spec.rb' + - 'ee/spec/services/incident_management/oncall_rotations/destroy_service_spec.rb' + - 'ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb' + - 'ee/spec/services/incident_management/oncall_schedules/create_service_spec.rb' + - 'ee/spec/services/incident_management/oncall_schedules/destroy_service_spec.rb' + - 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb' + - 'ee/spec/services/issuable/discussions_list_service_spec.rb' + - 'ee/spec/services/issues/build_service_spec.rb' + - 'ee/spec/services/iterations/cadences/create_iterations_in_advance_service_spec.rb' + - 'ee/spec/services/iterations/roll_over_issues_service_spec.rb' + - 'ee/spec/services/iterations/update_service_spec.rb' + - 'ee/spec/services/llm/analyze_ci_job_failure_service_spec.rb' + - 'ee/spec/services/llm/base_service_spec.rb' + - 'ee/spec/services/llm/chat_service_spec.rb' + - 'ee/spec/services/llm/explain_code_service_spec.rb' + - 'ee/spec/services/llm/explain_vulnerability_service_spec.rb' + - 'ee/spec/services/llm/fill_in_merge_request_template_service_spec.rb' + - 'ee/spec/services/llm/generate_commit_message_service_spec.rb' + - 'ee/spec/services/llm/generate_description_service_spec.rb' + - 'ee/spec/services/llm/generate_summary_service_spec.rb' + - 'ee/spec/services/llm/generate_test_file_service_spec.rb' + - 'ee/spec/services/llm/git_command_service_spec.rb' + - 'ee/spec/services/llm/merge_requests/summarize_diff_service_spec.rb' + - 'ee/spec/services/llm/merge_requests/summarize_review_service_spec.rb' + - 'ee/spec/services/members/activate_service_spec.rb' + - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' + - 'ee/spec/services/notes/create_visual_review_service_spec.rb' + - 'ee/spec/services/product_analytics/cube_data_query_service_spec.rb' + - 'ee/spec/services/product_analytics/initialize_stack_service_spec.rb' + - 'ee/spec/services/projects/deregister_suggested_reviewers_project_service_spec.rb' + - 'ee/spec/services/projects/group_links/create_service_spec.rb' + - 'ee/spec/services/projects/group_links/update_service_spec.rb' + - 'ee/spec/services/projects/register_suggested_reviewers_project_service_spec.rb' + - 'ee/spec/services/projects/transfer_service_spec.rb' + - 'ee/spec/services/projects/update_service_spec.rb' + - 'ee/spec/services/protected_environments/base_service_spec.rb' + - 'ee/spec/services/quick_actions/interpret_service_spec.rb' + - 'ee/spec/services/requirements_management/import_csv_service_spec.rb' + - 'ee/spec/services/requirements_management/process_test_reports_service_spec.rb' + - 'ee/spec/services/security/orchestration/assign_service_spec.rb' + - 'ee/spec/services/security/orchestration/create_bot_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/policy_commit_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/process_scan_result_policy_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/project_create_service_spec.rb' + - 'ee/spec/services/status_page/mark_for_publication_service_spec.rb' + - 'ee/spec/services/todos/destroy/confidential_epic_service_spec.rb' + - 'ee/spec/services/users/abuse/git_abuse/namespace_throttle_service_spec.rb' + - 'ee/spec/services/vulnerabilities/destroy_dismissal_feedback_service_spec.rb' + - 'ee/spec/services/vulnerabilities/find_or_create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/findings/find_or_create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/security_finding/create_issue_service_spec.rb' + - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/bulk_create_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/delete_service_spec.rb' + - 'ee/spec/services/vulnerability_merge_request_links/create_service_spec.rb' + - 'ee/spec/services/work_items/widgets/health_status_service/update_service_spec.rb' + - 'ee/spec/services/work_items/widgets/iteration_service/update_service_spec.rb' + - 'ee/spec/services/work_items/widgets/progress_service/update_service_spec.rb' + - 'ee/spec/services/work_items/widgets/status_service/update_service_spec.rb' + - 'ee/spec/services/work_items/widgets/weight_service/update_service_spec.rb' + - 'ee/spec/support/shared_contexts/gitlab_team_member_shared_context.rb' + - 'ee/spec/support/shared_contexts/project_approval_rules_shared_context.rb' + - 'ee/spec/support/shared_examples/controllers/projects/license_scanning_report_comparison_shared_examples.rb' + - 'ee/spec/support/shared_examples/finders/scan_policy_base_finder_examples.rb' + - 'ee/spec/support/shared_examples/models/protected_environments/authorizable_examples.rb' + - 'ee/spec/support/shared_examples/policies/dast_on_demand_scans_shared_examples.rb' + - 'ee/spec/support/shared_examples/serializers/report_status_shared_examples.rb' + - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' + - 'ee/spec/views/layouts/header/_new_dropdown.haml_spec.rb' + - 'ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' + - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' + - 'ee/spec/views/shared/promotions/_promotion_link_project.html.haml_spec.rb' + - 'ee/spec/workers/abuse/new_abuse_report_worker_spec.rb' + - 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb' + - 'ee/spec/workers/compliance_management/framework_export_mailer_worker_spec.rb' + - 'ee/spec/workers/compliance_management/update_default_framework_worker_spec.rb' + - 'ee/spec/workers/ee/ci/build_finished_worker_spec.rb' + - 'ee/spec/workers/ee/new_issue_worker_spec.rb' + - 'ee/spec/workers/groups/export_memberships_worker_spec.rb' + - 'ee/spec/workers/llm/completion_worker_spec.rb' + - 'ee/spec/workers/merge_requests/llm/summarize_merge_request_worker_spec.rb' + - 'ee/spec/workers/security/orchestration_configuration_create_bot_worker_spec.rb' + - 'spec/controllers/autocomplete_controller_spec.rb' + - 'spec/controllers/concerns/metrics_dashboard_spec.rb' + - 'spec/controllers/dashboard_controller_spec.rb' + - 'spec/controllers/explore/projects_controller_spec.rb' + - 'spec/controllers/graphql_controller_spec.rb' + - 'spec/controllers/groups/clusters_controller_spec.rb' + - 'spec/controllers/groups/dependency_proxies_controller_spec.rb' + - 'spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb' + - 'spec/controllers/groups/group_members_controller_spec.rb' + - 'spec/controllers/groups/imports_controller_spec.rb' + - 'spec/controllers/groups/labels_controller_spec.rb' + - 'spec/controllers/groups/runners_controller_spec.rb' + - 'spec/controllers/groups/settings/applications_controller_spec.rb' + - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' + - 'spec/controllers/groups/settings/integrations_controller_spec.rb' + - 'spec/controllers/groups_controller_spec.rb' + - 'spec/controllers/import/manifest_controller_spec.rb' + - 'spec/controllers/profiles/notifications_controller_spec.rb' + - 'spec/controllers/profiles/slacks_controller_spec.rb' + - 'spec/controllers/projects/analytics/cycle_analytics/stages_controller_spec.rb' + - 'spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' + - 'spec/controllers/projects/analytics/cycle_analytics/value_streams_controller_spec.rb' + - 'spec/controllers/projects/artifacts_controller_spec.rb' + - 'spec/controllers/projects/blame_controller_spec.rb' + - 'spec/controllers/projects/blob_controller_spec.rb' + - 'spec/controllers/projects/ci/lints_controller_spec.rb' + - 'spec/controllers/projects/ci/pipeline_editor_controller_spec.rb' + - 'spec/controllers/projects/clusters_controller_spec.rb' + - 'spec/controllers/projects/commit_controller_spec.rb' + - 'spec/controllers/projects/commits_controller_spec.rb' + - 'spec/controllers/projects/compare_controller_spec.rb' + - 'spec/controllers/projects/environments/sample_metrics_controller_spec.rb' + - 'spec/controllers/projects/error_tracking_controller_spec.rb' + - 'spec/controllers/projects/feature_flags_clients_controller_spec.rb' + - 'spec/controllers/projects/group_links_controller_spec.rb' + - 'spec/controllers/projects/import/jira_controller_spec.rb' + - 'spec/controllers/projects/issue_links_controller_spec.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/projects/jobs_controller_spec.rb' + - 'spec/controllers/projects/labels_controller_spec.rb' + - 'spec/controllers/projects/merge_requests_controller_spec.rb' + - 'spec/controllers/projects/packages/infrastructure_registry_controller_spec.rb' + - 'spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb' + - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' + - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/controllers/projects/project_members_controller_spec.rb' + - 'spec/controllers/projects/prometheus/alerts_controller_spec.rb' + - 'spec/controllers/projects/prometheus/metrics_controller_spec.rb' + - 'spec/controllers/projects/raw_controller_spec.rb' + - 'spec/controllers/projects/refs_controller_spec.rb' + - 'spec/controllers/projects/registry/repositories_controller_spec.rb' + - 'spec/controllers/projects/repositories_controller_spec.rb' + - 'spec/controllers/projects/runner_projects_controller_spec.rb' + - 'spec/controllers/projects/runners_controller_spec.rb' + - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' + - 'spec/controllers/projects/settings/integrations_controller_spec.rb' + - 'spec/controllers/projects/settings/slacks_controller_spec.rb' + - 'spec/controllers/projects/snippets_controller_spec.rb' + - 'spec/controllers/projects/terraform_controller_spec.rb' + - 'spec/controllers/projects/tree_controller_spec.rb' + - 'spec/controllers/projects/usage_quotas_controller_spec.rb' + - 'spec/controllers/projects/web_ide_schemas_controller_spec.rb' + - 'spec/controllers/projects/work_items_controller_spec.rb' + - 'spec/controllers/projects_controller_spec.rb' + - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' + - 'spec/experiments/ios_specific_templates_experiment_spec.rb' + - 'spec/features/admin/admin_projects_spec.rb' + - 'spec/features/admin/users/user_spec.rb' + - 'spec/features/admin/users/users_spec.rb' + - 'spec/features/boards/board_filters_spec.rb' + - 'spec/features/boards/new_issue_spec.rb' + - 'spec/features/boards/sidebar_assignee_spec.rb' + - 'spec/features/boards/sidebar_labels_spec.rb' + - 'spec/features/boards/sidebar_spec.rb' + - 'spec/features/commit_spec.rb' + - 'spec/features/commits/user_view_commits_spec.rb' + - 'spec/features/commits_spec.rb' + - 'spec/features/dashboard/issues_filter_spec.rb' + - 'spec/features/dashboard/todos/todos_spec.rb' + - 'spec/features/emails/issues_spec.rb' + - 'spec/features/global_search_spec.rb' + - 'spec/features/groups/board_spec.rb' + - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' + - 'spec/features/groups/group_runners_spec.rb' + - 'spec/features/groups/import_export/export_file_spec.rb' + - 'spec/features/groups/members/manage_groups_spec.rb' + - 'spec/features/groups/members/manage_members_spec.rb' + - 'spec/features/groups/members/master_adds_member_with_expiration_date_spec.rb' + - 'spec/features/groups/new_group_page_spec.rb' + - 'spec/features/groups/packages_spec.rb' + - 'spec/features/groups/settings/access_tokens_spec.rb' + - 'spec/features/groups/settings/manage_applications_spec.rb' + - 'spec/features/groups/settings/user_searches_in_settings_spec.rb' + - 'spec/features/groups/show_spec.rb' + - 'spec/features/groups_spec.rb' + - 'spec/features/incidents/user_uses_quick_actions_spec.rb' + - 'spec/features/integrations_settings_spec.rb' + - 'spec/features/invites_spec.rb' + - 'spec/features/issues/filtered_search/dropdown_assignee_spec.rb' + - 'spec/features/issues/filtered_search/dropdown_author_spec.rb' + - 'spec/features/issues/filtered_search/dropdown_base_spec.rb' + - 'spec/features/issues/filtered_search/dropdown_emoji_spec.rb' + - 'spec/features/issues/filtered_search/dropdown_hint_spec.rb' + - 'spec/features/issues/filtered_search/dropdown_label_spec.rb' + - 'spec/features/issues/filtered_search/dropdown_milestone_spec.rb' + - 'spec/features/issues/filtered_search/dropdown_release_spec.rb' + - 'spec/features/issues/filtered_search/search_bar_spec.rb' + - 'spec/features/issues/incident_issue_spec.rb' + - 'spec/features/issues/issue_detail_spec.rb' + - 'spec/features/issues/issue_header_spec.rb' + - 'spec/features/issues/issue_sidebar_spec.rb' + - 'spec/features/issues/issue_state_spec.rb' + - 'spec/features/issues/user_comments_on_issue_spec.rb' + - 'spec/features/issues/user_creates_issue_by_email_spec.rb' + - 'spec/features/issues/user_creates_issue_spec.rb' + - 'spec/features/issues/user_edits_issue_spec.rb' + - 'spec/features/issues/user_resets_their_incoming_email_token_spec.rb' + - 'spec/features/markdown/keyboard_shortcuts_spec.rb' + - 'spec/features/markdown/observability_spec.rb' + - 'spec/features/merge_request/user_can_see_draft_toggle_spec.rb' + - 'spec/features/merge_request/user_closes_reopens_merge_request_state_spec.rb' + - 'spec/features/merge_request/user_comments_on_whitespace_hidden_diff_spec.rb' + - 'spec/features/merge_request/user_creates_discussion_on_diff_file_spec.rb' + - 'spec/features/merge_request/user_creates_merge_request_spec.rb' + - 'spec/features/merge_request/user_edits_reviewers_sidebar_spec.rb' + - 'spec/features/merge_request/user_posts_notes_spec.rb' + - 'spec/features/merge_request/user_sees_discussions_navigation_spec.rb' + - 'spec/features/merge_requests/user_views_open_merge_requests_spec.rb' + - 'spec/features/milestones/user_edits_milestone_spec.rb' + - 'spec/features/milestones/user_promotes_milestone_spec.rb' + - 'spec/features/milestones/user_views_milestones_spec.rb' + - 'spec/features/monitor_sidebar_link_spec.rb' + - 'spec/features/profiles/user_uses_comment_template_spec.rb' + - 'spec/features/projects/blobs/blame_spec.rb' + - 'spec/features/projects/blobs/blob_show_spec.rb' + - 'spec/features/projects/blobs/edit_spec.rb' + - 'spec/features/projects/blobs/user_views_pipeline_editor_button_spec.rb' + - 'spec/features/projects/branches/user_creates_branch_spec.rb' + - 'spec/features/projects/branches_spec.rb' + - 'spec/features/projects/commit/user_sees_pipelines_tab_spec.rb' + - 'spec/features/projects/commit/user_views_user_status_on_commit_spec.rb' + - 'spec/features/projects/deploy_keys_spec.rb' + - 'spec/features/projects/environments/environment_spec.rb' + - 'spec/features/projects/feature_flag_user_lists/user_deletes_feature_flag_user_list_spec.rb' + - 'spec/features/projects/feature_flag_user_lists/user_edits_feature_flag_user_list_spec.rb' + - 'spec/features/projects/feature_flag_user_lists/user_sees_feature_flag_user_list_details_spec.rb' + - 'spec/features/projects/infrastructure_registry_spec.rb' + - 'spec/features/projects/issues/email_participants_spec.rb' + - 'spec/features/projects/jobs/permissions_spec.rb' + - 'spec/features/projects/labels/user_creates_labels_spec.rb' + - 'spec/features/projects/labels/user_edits_labels_spec.rb' + - 'spec/features/projects/labels/user_promotes_label_spec.rb' + - 'spec/features/projects/labels/user_views_labels_spec.rb' + - 'spec/features/projects/members/groups_with_access_list_spec.rb' + - 'spec/features/projects/members/manage_groups_spec.rb' + - 'spec/features/projects/members/manage_members_spec.rb' + - 'spec/features/projects/members/master_adds_member_with_expiration_date_spec.rb' + - 'spec/features/projects/members/user_requests_access_spec.rb' + - 'spec/features/projects/merge_request_button_spec.rb' + - 'spec/features/projects/new_project_spec.rb' + - 'spec/features/projects/packages_spec.rb' + - 'spec/features/projects/pages/user_adds_domain_spec.rb' + - 'spec/features/projects/pages/user_configures_pages_pipeline_spec.rb' + - 'spec/features/projects/pages/user_edits_lets_encrypt_settings_spec.rb' + - 'spec/features/projects/pages/user_edits_settings_spec.rb' + - 'spec/features/projects/pipelines/pipeline_spec.rb' + - 'spec/features/projects/releases/user_creates_release_spec.rb' + - 'spec/features/projects/releases/user_views_edit_release_spec.rb' + - 'spec/features/projects/releases/user_views_releases_spec.rb' + - 'spec/features/projects/settings/access_tokens_spec.rb' + - 'spec/features/projects/settings/branch_names_settings_spec.rb' + - 'spec/features/projects/settings/service_desk_setting_spec.rb' + - 'spec/features/projects/show/clone_button_spec.rb' + - 'spec/features/projects/snippets/user_comments_on_snippet_spec.rb' + - 'spec/features/projects/snippets/user_updates_snippet_spec.rb' + - 'spec/features/projects/snippets/user_views_snippets_spec.rb' + - 'spec/features/projects/tags/user_edits_tags_spec.rb' + - 'spec/features/projects/terraform_spec.rb' + - 'spec/features/projects/user_sees_user_popover_spec.rb' + - 'spec/features/projects/user_views_empty_project_spec.rb' + - 'spec/features/projects/work_items/work_item_children_spec.rb' + - 'spec/features/projects/work_items/work_item_spec.rb' + - 'spec/features/promotion_spec.rb' + - 'spec/features/registrations/oauth_registration_spec.rb' + - 'spec/features/reportable_note/snippets_spec.rb' + - 'spec/features/runners_spec.rb' + - 'spec/features/search/user_searches_for_code_spec.rb' + - 'spec/features/search/user_searches_for_comments_spec.rb' + - 'spec/features/search/user_searches_for_commits_spec.rb' + - 'spec/features/search/user_searches_for_issues_spec.rb' + - 'spec/features/search/user_searches_for_milestones_spec.rb' + - 'spec/features/search/user_searches_for_users_spec.rb' + - 'spec/features/search/user_searches_for_wiki_pages_spec.rb' + - 'spec/features/search/user_uses_header_search_field_spec.rb' + - 'spec/features/user_can_display_performance_bar_spec.rb' + - 'spec/features/user_sorts_things_spec.rb' + - 'spec/finders/alert_management/alerts_finder_spec.rb' + - 'spec/finders/autocomplete/deploy_keys_with_write_access_finder_spec.rb' + - 'spec/finders/autocomplete/routes_finder_spec.rb' + - 'spec/finders/autocomplete/users_finder_spec.rb' + - 'spec/finders/ci/commit_statuses_finder_spec.rb' + - 'spec/finders/ci/jobs_finder_spec.rb' + - 'spec/finders/ci/pipelines_finder_spec.rb' + - 'spec/finders/ci/runners_finder_spec.rb' + - 'spec/finders/clusters/agent_tokens_finder_spec.rb' + - 'spec/finders/concerns/finder_with_group_hierarchy_spec.rb' + - 'spec/finders/container_repositories_finder_spec.rb' + - 'spec/finders/crm/contacts_finder_spec.rb' + - 'spec/finders/crm/organizations_finder_spec.rb' + - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' + - 'spec/finders/design_management/designs_finder_spec.rb' + - 'spec/finders/design_management/versions_finder_spec.rb' + - 'spec/finders/environments/environments_finder_spec.rb' + - 'spec/finders/group_members_finder_spec.rb' + - 'spec/finders/groups/accepting_project_creations_finder_spec.rb' + - 'spec/finders/groups/accepting_project_imports_finder_spec.rb' + - 'spec/finders/groups/accepting_project_shares_finder_spec.rb' + - 'spec/finders/groups/accepting_project_transfers_finder_spec.rb' + - 'spec/finders/groups_finder_spec.rb' + - 'spec/finders/incident_management/timeline_event_tags_finder_spec.rb' + - 'spec/finders/incident_management/timeline_events_finder_spec.rb' + - 'spec/finders/labels_finder_spec.rb' + - 'spec/finders/merge_request/metrics_finder_spec.rb' + - 'spec/finders/merge_requests_finder_spec.rb' + - 'spec/finders/packages/composer/packages_finder_spec.rb' + - 'spec/finders/packages/group_packages_finder_spec.rb' + - 'spec/finders/packages/maven/package_finder_spec.rb' + - 'spec/finders/packages/nuget/package_finder_spec.rb' + - 'spec/finders/packages/pypi/packages_finder_spec.rb' + - 'spec/finders/projects/groups_finder_spec.rb' + - 'spec/finders/projects/members/effective_access_level_finder_spec.rb' + - 'spec/finders/projects/members/effective_access_level_per_user_finder_spec.rb' + - 'spec/finders/projects_finder_spec.rb' + - 'spec/finders/releases_finder_spec.rb' + - 'spec/finders/terraform/states_finder_spec.rb' + - 'spec/finders/user_group_notification_settings_finder_spec.rb' + - 'spec/frontend/fixtures/autocomplete.rb' + - 'spec/frontend/fixtures/autocomplete_sources.rb' + - 'spec/frontend/fixtures/groups.rb' + - 'spec/frontend/fixtures/metrics_dashboard.rb' + - 'spec/frontend/fixtures/milestones.rb' + - 'spec/frontend/fixtures/pipelines.rb' + - 'spec/frontend/fixtures/project.rb' + - 'spec/frontend/fixtures/releases.rb' + - 'spec/frontend/fixtures/runner.rb' + - 'spec/frontend/fixtures/users.rb' + - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' + - 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb' + - 'spec/graphql/mutations/alert_management/http_integration/destroy_spec.rb' + - 'spec/graphql/mutations/alert_management/http_integration/reset_token_spec.rb' + - 'spec/graphql/mutations/alert_management/http_integration/update_spec.rb' + - 'spec/graphql/mutations/alert_management/prometheus_integration/create_spec.rb' + - 'spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb' + - 'spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb' + - 'spec/graphql/mutations/alert_management/update_alert_status_spec.rb' + - 'spec/graphql/mutations/branches/create_spec.rb' + - 'spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb' + - 'spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb' + - 'spec/graphql/mutations/commits/create_spec.rb' + - 'spec/graphql/mutations/custom_emoji/create_spec.rb' + - 'spec/graphql/mutations/custom_emoji/destroy_spec.rb' + - 'spec/graphql/mutations/customer_relations/contacts/update_spec.rb' + - 'spec/graphql/mutations/customer_relations/organizations/create_spec.rb' + - 'spec/graphql/mutations/customer_relations/organizations/update_spec.rb' + - 'spec/graphql/mutations/incident_management/timeline_event/create_spec.rb' + - 'spec/graphql/mutations/incident_management/timeline_event/destroy_spec.rb' + - 'spec/graphql/mutations/incident_management/timeline_event/promote_from_note_spec.rb' + - 'spec/graphql/mutations/incident_management/timeline_event/update_spec.rb' + - 'spec/graphql/mutations/incident_management/timeline_event_tag/create_spec.rb' + - 'spec/graphql/mutations/issues/create_spec.rb' + - 'spec/graphql/mutations/issues/move_spec.rb' + - 'spec/graphql/mutations/issues/set_subscription_spec.rb' + - 'spec/graphql/mutations/issues/update_spec.rb' + - 'spec/graphql/mutations/merge_requests/create_spec.rb' + - 'spec/graphql/mutations/merge_requests/set_subscription_spec.rb' + - 'spec/graphql/mutations/releases/create_spec.rb' + - 'spec/graphql/mutations/releases/delete_spec.rb' + - 'spec/graphql/mutations/releases/update_spec.rb' + - 'spec/graphql/mutations/timelogs/delete_spec.rb' + - 'spec/graphql/mutations/users/set_namespace_commit_email_spec.rb' + - 'spec/graphql/resolvers/alert_management/alert_resolver_spec.rb' + - 'spec/graphql/resolvers/alert_management/http_integrations_resolver_spec.rb' + - 'spec/graphql/resolvers/alert_management/integrations_resolver_spec.rb' + - 'spec/graphql/resolvers/blobs_resolver_spec.rb' + - 'spec/graphql/resolvers/board_list_resolver_spec.rb' + - 'spec/graphql/resolvers/ci/config_resolver_spec.rb' + - 'spec/graphql/resolvers/ci/project_pipeline_counts_resolver_spec.rb' + - 'spec/graphql/resolvers/clusters/agents_resolver_spec.rb' + - 'spec/graphql/resolvers/concerns/resolves_pipelines_spec.rb' + - 'spec/graphql/resolvers/crm/contact_state_counts_resolver_spec.rb' + - 'spec/graphql/resolvers/crm/contacts_resolver_spec.rb' + - 'spec/graphql/resolvers/crm/organization_state_counts_resolver_spec.rb' + - 'spec/graphql/resolvers/crm/organizations_resolver_spec.rb' + - 'spec/graphql/resolvers/data_transfer/group_data_transfer_resolver_spec.rb' + - 'spec/graphql/resolvers/data_transfer/project_data_transfer_resolver_spec.rb' + - 'spec/graphql/resolvers/design_management/design_at_version_resolver_spec.rb' + - 'spec/graphql/resolvers/design_management/design_resolver_spec.rb' + - 'spec/graphql/resolvers/design_management/designs_resolver_spec.rb' + - 'spec/graphql/resolvers/group_issues_resolver_spec.rb' + - 'spec/graphql/resolvers/group_members/notification_email_resolver_spec.rb' + - 'spec/graphql/resolvers/group_milestones_resolver_spec.rb' + - 'spec/graphql/resolvers/group_releases_resolver_spec.rb' + - 'spec/graphql/resolvers/incident_management/timeline_event_tags_resolver_spec.rb' + - 'spec/graphql/resolvers/incident_management/timeline_events_resolver_spec.rb' + - 'spec/graphql/resolvers/merge_requests_count_resolver_spec.rb' + - 'spec/graphql/resolvers/merge_requests_resolver_spec.rb' + - 'spec/graphql/resolvers/nested_groups_resolver_spec.rb' + - 'spec/graphql/resolvers/project_issues_resolver_spec.rb' + - 'spec/graphql/resolvers/project_jobs_resolver_spec.rb' + - 'spec/graphql/resolvers/project_merge_requests_resolver_spec.rb' + - 'spec/graphql/resolvers/project_milestones_resolver_spec.rb' + - 'spec/graphql/resolvers/project_pipeline_resolver_spec.rb' + - 'spec/graphql/resolvers/project_pipeline_schedules_resolver_spec.rb' + - 'spec/graphql/resolvers/project_pipeline_statistics_resolver_spec.rb' + - 'spec/graphql/resolvers/project_pipelines_resolver_spec.rb' + - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' + - 'spec/graphql/resolvers/projects/services_resolver_spec.rb' + - 'spec/graphql/resolvers/release_resolver_spec.rb' + - 'spec/graphql/resolvers/releases_resolver_spec.rb' + - 'spec/graphql/resolvers/snippets_resolver_spec.rb' + - 'spec/graphql/resolvers/user_discussions_count_resolver_spec.rb' + - 'spec/graphql/resolvers/user_notes_count_resolver_spec.rb' + - 'spec/graphql/resolvers/users/snippets_resolver_spec.rb' + - 'spec/graphql/types/ci/pipeline_counts_type_spec.rb' + - 'spec/graphql/types/environment_type_spec.rb' + - 'spec/graphql/types/issue_type_spec.rb' + - 'spec/graphql/types/project_type_spec.rb' + - 'spec/graphql/types/terraform/state_version_type_spec.rb' + - 'spec/graphql/types/todo_type_spec.rb' + - 'spec/graphql/types/user_merge_request_interaction_type_spec.rb' + - 'spec/graphql/types/user_type_spec.rb' + - 'spec/helpers/admin/user_actions_helper_spec.rb' + - 'spec/helpers/broadcast_messages_helper_spec.rb' + - 'spec/helpers/ci/pipelines_helper_spec.rb' + - 'spec/helpers/clusters_helper_spec.rb' + - 'spec/helpers/events_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' + - 'spec/helpers/issuables_helper_spec.rb' + - 'spec/helpers/packages_helper_spec.rb' + - 'spec/helpers/projects/pipeline_helper_spec.rb' + - 'spec/helpers/projects/project_members_helper_spec.rb' + - 'spec/helpers/projects_helper_spec.rb' + - 'spec/helpers/search_helper_spec.rb' + - 'spec/helpers/timeboxes_helper_spec.rb' + - 'spec/helpers/tree_helper_spec.rb' + - 'spec/helpers/users/group_callouts_helper_spec.rb' + - 'spec/helpers/web_hooks/web_hooks_helper_spec.rb' + - 'spec/lib/api/entities/release_spec.rb' + - 'spec/lib/api/helpers/packages_helpers_spec.rb' + - 'spec/lib/api/helpers_spec.rb' + - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' + - 'spec/lib/banzai/reference_parser/issue_parser_spec.rb' + - 'spec/lib/banzai/reference_parser/work_item_parser_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/labels_pipeline_spec.rb' + - 'spec/lib/bulk_imports/common/transformers/user_reference_transformer_spec.rb' + - 'spec/lib/bulk_imports/groups/pipelines/group_pipeline_spec.rb' + - 'spec/lib/bulk_imports/groups/pipelines/namespace_settings_pipeline_spec.rb' + - 'spec/lib/bulk_imports/groups/pipelines/project_entities_pipeline_spec.rb' + - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/ci_pipelines_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/commit_notes_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/merge_requests_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/pipeline_schedules_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/references_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/releases_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/snippets_pipeline_spec.rb' + - 'spec/lib/gitlab/alert_management/alert_status_counts_spec.rb' + - 'spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' + - 'spec/lib/gitlab/auth_spec.rb' + - 'spec/lib/gitlab/changelog/config_spec.rb' + - 'spec/lib/gitlab/ci/components/instance_path_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/project_spec.rb' + - 'spec/lib/gitlab/ci/config/external/processor_spec.rb' + - 'spec/lib/gitlab/ci/config_spec.rb' + - 'spec/lib/gitlab/ci/lint_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/build/associations_spec.rb' + - 'spec/lib/gitlab/ci/status/build/play_spec.rb' + - 'spec/lib/gitlab/ci/variables/builder/pipeline_spec.rb' + - 'spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb' + - 'spec/lib/gitlab/database/schema_validation/track_inconsistency_spec.rb' + - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/git_access_wiki_spec.rb' + - 'spec/lib/gitlab/group_search_results_spec.rb' + - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' + - 'spec/lib/gitlab/import_export/wiki_repo_saver_spec.rb' + - 'spec/lib/gitlab/metrics/dashboard/finder_spec.rb' + - 'spec/lib/gitlab/pipeline_scope_counts_spec.rb' + - 'spec/lib/gitlab/project_authorizations_spec.rb' + - 'spec/lib/gitlab/project_search_results_spec.rb' + - 'spec/lib/gitlab/reference_extractor_spec.rb' + - 'spec/lib/gitlab/search_results_spec.rb' + - 'spec/lib/gitlab/slash_commands/presenters/issue_move_spec.rb' + - 'spec/lib/gitlab/tree_summary_spec.rb' + - 'spec/mailers/emails/in_product_marketing_spec.rb' + - 'spec/models/ci/bridge_spec.rb' + - 'spec/models/ci/catalog/listing_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/processable_spec.rb' + - 'spec/models/concerns/has_user_type_spec.rb' + - 'spec/models/concerns/loaded_in_group_list_spec.rb' + - 'spec/models/event_spec.rb' + - 'spec/models/group_spec.rb' + - 'spec/models/integrations/microsoft_teams_spec.rb' + - 'spec/models/issue_spec.rb' + - 'spec/models/members/group_member_spec.rb' + - 'spec/models/members/project_member_spec.rb' + - 'spec/models/namespace_spec.rb' + - 'spec/models/note_spec.rb' + - 'spec/models/preloaders/user_max_access_level_in_projects_preloader_spec.rb' + - 'spec/models/preloaders/users_max_access_level_by_project_preloader_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/models/project_team_spec.rb' + - 'spec/models/protected_branch_spec.rb' + - 'spec/models/users/merge_request_interaction_spec.rb' + - 'spec/policies/alert_management/alert_policy_spec.rb' + - 'spec/policies/ci/pipeline_schedule_policy_spec.rb' + - 'spec/policies/incident_management/timeline_event_policy_spec.rb' + - 'spec/policies/issuable_policy_spec.rb' + - 'spec/policies/merge_request_policy_spec.rb' + - 'spec/policies/packages/package_policy_spec.rb' + - 'spec/policies/project_snippet_policy_spec.rb' + - 'spec/policies/resource_label_event_policy_spec.rb' + - 'spec/policies/resource_milestone_event_policy_spec.rb' + - 'spec/policies/resource_state_event_policy_spec.rb' + - 'spec/policies/timelog_policy_spec.rb' + - 'spec/presenters/ci/pipeline_presenter_spec.rb' + - 'spec/presenters/ci/trigger_presenter_spec.rb' + - 'spec/presenters/milestone_presenter_spec.rb' + - 'spec/presenters/project_presenter_spec.rb' + - 'spec/presenters/projects/import_export/project_export_presenter_spec.rb' + - 'spec/presenters/release_presenter_spec.rb' + - 'spec/presenters/snippet_blob_presenter_spec.rb' + - 'spec/requests/api/alert_management_alerts_spec.rb' + - 'spec/requests/api/api_spec.rb' + - 'spec/requests/api/award_emoji_spec.rb' + - 'spec/requests/api/bulk_imports_spec.rb' + - 'spec/requests/api/ci/pipeline_schedules_spec.rb' + - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' + - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/commits_spec.rb' + - 'spec/requests/api/container_repositories_spec.rb' + - 'spec/requests/api/deploy_keys_spec.rb' + - 'spec/requests/api/deploy_tokens_spec.rb' + - 'spec/requests/api/draft_notes_spec.rb' + - 'spec/requests/api/environments_spec.rb' + - 'spec/requests/api/error_tracking/client_keys_spec.rb' + - 'spec/requests/api/files_spec.rb' + - 'spec/requests/api/freeze_periods_spec.rb' + - 'spec/requests/api/go_proxy_spec.rb' + - 'spec/requests/api/graphql/ci/ci_cd_setting_spec.rb' + - 'spec/requests/api/graphql/ci/config_variables_spec.rb' + - 'spec/requests/api/graphql/ci/group_environment_scopes_spec.rb' + - 'spec/requests/api/graphql/ci/group_variables_spec.rb' + - 'spec/requests/api/graphql/ci/inherited_ci_variables_spec.rb' + - 'spec/requests/api/graphql/ci/manual_variables_spec.rb' + - 'spec/requests/api/graphql/ci/project_variables_spec.rb' + - 'spec/requests/api/graphql/ci/runner_spec.rb' + - 'spec/requests/api/graphql/ci/runners_spec.rb' + - 'spec/requests/api/graphql/crm/contacts_spec.rb' + - 'spec/requests/api/graphql/custom_emoji_query_spec.rb' + - 'spec/requests/api/graphql/group/container_repositories_spec.rb' + - 'spec/requests/api/graphql/group/data_transfer_spec.rb' + - 'spec/requests/api/graphql/group/dependency_proxy_blobs_spec.rb' + - 'spec/requests/api/graphql/group/dependency_proxy_manifests_spec.rb' + - 'spec/requests/api/graphql/group/group_members_spec.rb' + - 'spec/requests/api/graphql/group/issues_spec.rb' + - 'spec/requests/api/graphql/group/merge_requests_spec.rb' + - 'spec/requests/api/graphql/group/milestones_spec.rb' + - 'spec/requests/api/graphql/group/packages_spec.rb' + - 'spec/requests/api/graphql/group/timelogs_spec.rb' + - 'spec/requests/api/graphql/group_query_spec.rb' + - 'spec/requests/api/graphql/issue/issue_spec.rb' + - 'spec/requests/api/graphql/issue_status_counts_spec.rb' + - 'spec/requests/api/graphql/merge_request/merge_request_spec.rb' + - 'spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/alerts/create_alert_issue_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/alerts/todo/create_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/alerts/update_alert_status_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/http_integration/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/http_integration/reset_token_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/http_integration/update_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/prometheus_integration/create_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb' + - 'spec/requests/api/graphql/mutations/alert_management/prometheus_integration/update_spec.rb' + - 'spec/requests/api/graphql/mutations/award_emojis/add_spec.rb' + - 'spec/requests/api/graphql/mutations/branches/create_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/job_token_scope/add_project_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/job_token_scope/remove_project_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_create_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_delete_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_play_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_update_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/project_ci_cd_settings_update_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/runner/create_spec.rb' + - 'spec/requests/api/graphql/mutations/commits/create_spec.rb' + - 'spec/requests/api/graphql/mutations/custom_emoji/create_spec.rb' + - 'spec/requests/api/graphql/mutations/custom_emoji/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/groups/update_spec.rb' + - 'spec/requests/api/graphql/mutations/incident_management/timeline_event/create_spec.rb' + - 'spec/requests/api/graphql/mutations/incident_management/timeline_event/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/incident_management/timeline_event/promote_from_note_spec.rb' + - 'spec/requests/api/graphql/mutations/incident_management/timeline_event/update_spec.rb' + - 'spec/requests/api/graphql/mutations/incident_management/timeline_event_tag/create_spec.rb' + - 'spec/requests/api/graphql/mutations/issues/create_spec.rb' + - 'spec/requests/api/graphql/mutations/issues/link_alerts_spec.rb' + - 'spec/requests/api/graphql/mutations/issues/move_spec.rb' + - 'spec/requests/api/graphql/mutations/issues/set_crm_contacts_spec.rb' + - 'spec/requests/api/graphql/mutations/issues/set_locked_spec.rb' + - 'spec/requests/api/graphql/mutations/issues/update_spec.rb' + - 'spec/requests/api/graphql/mutations/jira_import/import_users_spec.rb' + - 'spec/requests/api/graphql/mutations/merge_requests/accept_spec.rb' + - 'spec/requests/api/graphql/mutations/merge_requests/set_assignees_spec.rb' + - 'spec/requests/api/graphql/mutations/merge_requests/set_reviewers_spec.rb' + - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb' + - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb' + - 'spec/requests/api/graphql/mutations/packages/bulk_destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/packages/destroy_files_spec.rb' + - 'spec/requests/api/graphql/mutations/releases/create_spec.rb' + - 'spec/requests/api/graphql/mutations/releases/delete_spec.rb' + - 'spec/requests/api/graphql/mutations/releases/update_spec.rb' + - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' + - 'spec/requests/api/graphql/mutations/snippets/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/snippets/update_spec.rb' + - 'spec/requests/api/graphql/namespace/projects_spec.rb' + - 'spec/requests/api/graphql/namespace_query_spec.rb' + - 'spec/requests/api/graphql/notes/note_spec.rb' + - 'spec/requests/api/graphql/notes/synthetic_note_resolver_spec.rb' + - 'spec/requests/api/graphql/packages/package_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/alert/assignees_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/alert/issue_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/alert/metrics_dashboard_url_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/alert/notes_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/alert/todos_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/alert_status_counts_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/alerts_spec.rb' + - 'spec/requests/api/graphql/project/alert_management/integrations_spec.rb' + - 'spec/requests/api/graphql/project/base_service_spec.rb' + - 'spec/requests/api/graphql/project/branch_rules/branch_protection_spec.rb' + - 'spec/requests/api/graphql/project/branch_rules_spec.rb' + - 'spec/requests/api/graphql/project/ci_access_authorized_agents_spec.rb' + - 'spec/requests/api/graphql/project/data_transfer_spec.rb' + - 'spec/requests/api/graphql/project/grafana_integration_spec.rb' + - 'spec/requests/api/graphql/project/incident_management/timeline_events_spec.rb' + - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' + - 'spec/requests/api/graphql/project/issue/designs/notes_spec.rb' + - 'spec/requests/api/graphql/project/issue_spec.rb' + - 'spec/requests/api/graphql/project/jira_import_spec.rb' + - 'spec/requests/api/graphql/project/jira_projects_spec.rb' + - 'spec/requests/api/graphql/project/jira_service_spec.rb' + - 'spec/requests/api/graphql/project/job_spec.rb' + - 'spec/requests/api/graphql/project/merge_request_spec.rb' + - 'spec/requests/api/graphql/project/milestones_spec.rb' + - 'spec/requests/api/graphql/project/project_members_spec.rb' + - 'spec/requests/api/graphql/project/project_pipeline_statistics_spec.rb' + - 'spec/requests/api/graphql/project/project_statistics_redirect_spec.rb' + - 'spec/requests/api/graphql/project/runners_spec.rb' + - 'spec/requests/api/graphql/project/user_access_authorized_agents_spec.rb' + - 'spec/requests/api/graphql/project/work_items_spec.rb' + - 'spec/requests/api/graphql/query_spec.rb' + - 'spec/requests/api/graphql/subscriptions/notes/created_spec.rb' + - 'spec/requests/api/graphql/subscriptions/notes/deleted_spec.rb' + - 'spec/requests/api/graphql/subscriptions/notes/updated_spec.rb' + - 'spec/requests/api/graphql/subscriptions/work_item_updated_spec.rb' + - 'spec/requests/api/graphql/todo_query_spec.rb' + - 'spec/requests/api/graphql/user/starred_projects_query_spec.rb' + - 'spec/requests/api/graphql/users/set_namespace_commit_email_spec.rb' + - 'spec/requests/api/graphql/work_item_spec.rb' + - 'spec/requests/api/group_boards_spec.rb' + - 'spec/requests/api/group_container_repositories_spec.rb' + - 'spec/requests/api/group_export_spec.rb' + - 'spec/requests/api/group_import_spec.rb' + - 'spec/requests/api/group_milestones_spec.rb' + - 'spec/requests/api/groups_spec.rb' + - 'spec/requests/api/issue_links_spec.rb' + - 'spec/requests/api/issues/get_group_issues_spec.rb' + - 'spec/requests/api/issues/issues_spec.rb' + - 'spec/requests/api/labels_spec.rb' + - 'spec/requests/api/lint_spec.rb' + - 'spec/requests/api/maven_packages_spec.rb' + - 'spec/requests/api/merge_request_approvals_spec.rb' + - 'spec/requests/api/merge_requests_spec.rb' + - 'spec/requests/api/metrics/dashboard/annotations_spec.rb' + - 'spec/requests/api/metrics/user_starred_dashboards_spec.rb' + - 'spec/requests/api/nuget_group_packages_spec.rb' + - 'spec/requests/api/package_files_spec.rb' + - 'spec/requests/api/pages/internal_access_spec.rb' + - 'spec/requests/api/pages/pages_spec.rb' + - 'spec/requests/api/pages/private_access_spec.rb' + - 'spec/requests/api/pages/public_access_spec.rb' + - 'spec/requests/api/pages_domains_spec.rb' + - 'spec/requests/api/project_clusters_spec.rb' + - 'spec/requests/api/project_export_spec.rb' + - 'spec/requests/api/project_job_token_scope_spec.rb' + - 'spec/requests/api/project_milestones_spec.rb' + - 'spec/requests/api/project_packages_spec.rb' + - 'spec/requests/api/project_snippets_spec.rb' + - 'spec/requests/api/project_statistics_spec.rb' + - 'spec/requests/api/project_templates_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/requests/api/protected_tags_spec.rb' + - 'spec/requests/api/pypi_packages_spec.rb' + - 'spec/requests/api/releases_spec.rb' + - 'spec/requests/api/remote_mirrors_spec.rb' + - 'spec/requests/api/rpm_project_packages_spec.rb' + - 'spec/requests/api/rubygem_packages_spec.rb' + - 'spec/requests/api/search_spec.rb' + - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' + - 'spec/requests/api/v3/github_spec.rb' + - 'spec/requests/api/wikis_spec.rb' + - 'spec/requests/concerns/planning_hierarchy_spec.rb' + - 'spec/requests/groups/deploy_tokens_controller_spec.rb' + - 'spec/requests/groups/email_campaigns_controller_spec.rb' + - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' + - 'spec/requests/groups/settings/applications_controller_spec.rb' + - 'spec/requests/groups/usage_quotas_controller_spec.rb' + - 'spec/requests/groups_controller_spec.rb' + - 'spec/requests/lfs_http_spec.rb' + - 'spec/requests/lfs_locks_api_spec.rb' + - 'spec/requests/projects/aws/configuration_controller_spec.rb' + - 'spec/requests/projects/commits_controller_spec.rb' + - 'spec/requests/projects/google_cloud/configuration_controller_spec.rb' + - 'spec/requests/projects/google_cloud/databases_controller_spec.rb' + - 'spec/requests/projects/google_cloud/deployments_controller_spec.rb' + - 'spec/requests/projects/google_cloud/gcp_regions_controller_spec.rb' + - 'spec/requests/projects/google_cloud/service_accounts_controller_spec.rb' + - 'spec/requests/projects/incident_management/timeline_events_spec.rb' + - 'spec/requests/projects/issues/discussions_spec.rb' + - 'spec/requests/projects/issues_controller_spec.rb' + - 'spec/requests/projects/merge_requests/content_spec.rb' + - 'spec/requests/projects/merge_requests/context_commit_diffs_spec.rb' + - 'spec/requests/projects/merge_requests/diffs_spec.rb' + - 'spec/requests/projects/merge_requests_controller_spec.rb' + - 'spec/requests/projects/merge_requests_spec.rb' + - 'spec/requests/projects/metrics/dashboards/builder_spec.rb' + - 'spec/requests/projects/releases_controller_spec.rb' + - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' + - 'spec/requests/projects/tags_controller_spec.rb' + - 'spec/requests/projects/usage_quotas_spec.rb' + - 'spec/requests/projects/work_items_spec.rb' + - 'spec/requests/projects_controller_spec.rb' + - 'spec/requests/rack_attack_global_spec.rb' + - 'spec/serializers/ci/pipeline_entity_spec.rb' + - 'spec/serializers/container_repository_entity_spec.rb' + - 'spec/serializers/container_tag_entity_spec.rb' + - 'spec/serializers/fork_namespace_entity_spec.rb' + - 'spec/serializers/group_access_token_entity_spec.rb' + - 'spec/serializers/group_access_token_serializer_spec.rb' + - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' + - 'spec/serializers/profile/event_entity_spec.rb' + - 'spec/serializers/project_access_token_entity_spec.rb' + - 'spec/serializers/project_access_token_serializer_spec.rb' + - 'spec/services/alert_management/create_alert_issue_service_spec.rb' + - 'spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb' + - 'spec/services/authorized_project_update/project_recalculate_service_spec.rb' + - 'spec/services/award_emojis/add_service_spec.rb' + - 'spec/services/award_emojis/destroy_service_spec.rb' + - 'spec/services/boards/issues/list_service_spec.rb' + - 'spec/services/boards/issues/move_service_spec.rb' + - 'spec/services/bulk_imports/create_service_spec.rb' + - 'spec/services/bulk_imports/export_service_spec.rb' + - 'spec/services/bulk_imports/relation_export_service_spec.rb' + - 'spec/services/ci/build_cancel_service_spec.rb' + - 'spec/services/ci/build_unschedule_service_spec.rb' + - 'spec/services/ci/components/fetch_service_spec.rb' + - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' + - 'spec/services/ci/create_pipeline_service/needs_spec.rb' + - 'spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb' + - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' + - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/ci/create_web_ide_terminal_service_spec.rb' + - 'spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb' + - 'spec/services/ci/job_artifacts/bulk_delete_by_project_service_spec.rb' + - 'spec/services/ci/job_token_scope/add_project_service_spec.rb' + - 'spec/services/ci/job_token_scope/remove_project_service_spec.rb' + - 'spec/services/ci/pipeline_trigger_service_spec.rb' + - 'spec/services/ci/retry_pipeline_service_spec.rb' + - 'spec/services/ci/runners/assign_runner_service_spec.rb' + - 'spec/services/ci/runners/bulk_delete_runners_service_spec.rb' + - 'spec/services/ci/runners/create_runner_service_spec.rb' + - 'spec/services/design_management/delete_designs_service_spec.rb' + - 'spec/services/discussions/resolve_service_spec.rb' + - 'spec/services/discussions/unresolve_service_spec.rb' + - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' + - 'spec/services/files/base_service_spec.rb' + - 'spec/services/git/branch_push_service_spec.rb' + - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' + - 'spec/services/groups/auto_devops_service_spec.rb' + - 'spec/services/groups/autocomplete_service_spec.rb' + - 'spec/services/groups/group_links/create_service_spec.rb' + - 'spec/services/groups/group_links/destroy_service_spec.rb' + - 'spec/services/groups/group_links/update_service_spec.rb' + - 'spec/services/groups/merge_requests_count_service_spec.rb' + - 'spec/services/groups/open_issues_count_service_spec.rb' + - 'spec/services/groups/transfer_service_spec.rb' + - 'spec/services/ide/base_config_service_spec.rb' + - 'spec/services/ide/schemas_config_service_spec.rb' + - 'spec/services/ide/terminal_config_service_spec.rb' + - 'spec/services/import/github/cancel_project_import_service_spec.rb' + - 'spec/services/incident_management/timeline_event_tags/create_service_spec.rb' + - 'spec/services/incident_management/timeline_events/update_service_spec.rb' + - 'spec/services/integrations/slack_interactions/incident_management/incident_modal_submit_service_spec.rb' + - 'spec/services/integrations/slack_options/label_search_handler_spec.rb' + - 'spec/services/integrations/slack_options/user_search_handler_spec.rb' + - 'spec/services/issuable/bulk_update_service_spec.rb' + - 'spec/services/issue_links/create_service_spec.rb' + - 'spec/services/issue_links/destroy_service_spec.rb' + - 'spec/services/issues/clone_service_spec.rb' + - 'spec/services/issues/create_service_spec.rb' + - 'spec/services/issues/move_service_spec.rb' + - 'spec/services/issues/reorder_service_spec.rb' + - 'spec/services/issues/set_crm_contacts_service_spec.rb' + - 'spec/services/issues/update_service_spec.rb' + - 'spec/services/jira_connect_subscriptions/create_service_spec.rb' + - 'spec/services/jira_import/cloud_users_mapper_service_spec.rb' + - 'spec/services/jira_import/server_users_mapper_service_spec.rb' + - 'spec/services/jira_import/users_importer_spec.rb' + - 'spec/services/labels/transfer_service_spec.rb' + - 'spec/services/members/approve_access_request_service_spec.rb' + - 'spec/services/members/destroy_service_spec.rb' + - 'spec/services/members/unassign_issuables_service_spec.rb' + - 'spec/services/members/update_service_spec.rb' + - 'spec/services/merge_requests/add_spent_time_service_spec.rb' + - 'spec/services/merge_requests/post_merge_service_spec.rb' + - 'spec/services/merge_requests/retarget_chain_service_spec.rb' + - 'spec/services/merge_requests/update_assignees_service_spec.rb' + - 'spec/services/merge_requests/update_reviewers_service_spec.rb' + - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' + - 'spec/services/metrics/dashboard/cluster_dashboard_service_spec.rb' + - 'spec/services/metrics/dashboard/cluster_metrics_embed_service_spec.rb' + - 'spec/services/metrics/dashboard/custom_dashboard_service_spec.rb' + - 'spec/services/metrics/dashboard/default_embed_service_spec.rb' + - 'spec/services/metrics/dashboard/dynamic_embed_service_spec.rb' + - 'spec/services/metrics/dashboard/pod_dashboard_service_spec.rb' + - 'spec/services/metrics/dashboard/system_dashboard_service_spec.rb' + - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' + - 'spec/services/metrics/dashboard/update_dashboard_service_spec.rb' + - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' + - 'spec/services/notes/build_service_spec.rb' + - 'spec/services/notes/create_service_spec.rb' + - 'spec/services/notes/quick_actions_service_spec.rb' + - 'spec/services/notification_recipients/builder/new_note_spec.rb' + - 'spec/services/notification_service_spec.rb' + - 'spec/services/packages/conan/search_service_spec.rb' + - 'spec/services/packages/mark_packages_for_destruction_service_spec.rb' + - 'spec/services/packages/maven/metadata/sync_service_spec.rb' + - 'spec/services/packages/nuget/search_service_spec.rb' + - 'spec/services/packages/rubygems/dependency_resolver_service_spec.rb' + - 'spec/services/pages_domains/create_service_spec.rb' + - 'spec/services/post_receive_service_spec.rb' + - 'spec/services/projects/autocomplete_service_spec.rb' + - 'spec/services/projects/container_repository/destroy_service_spec.rb' + - 'spec/services/projects/create_service_spec.rb' + - 'spec/services/projects/group_links/create_service_spec.rb' + - 'spec/services/projects/group_links/destroy_service_spec.rb' + - 'spec/services/projects/group_links/update_service_spec.rb' + - 'spec/services/projects/import_export/export_service_spec.rb' + - 'spec/services/projects/operations/update_service_spec.rb' + - 'spec/services/projects/participants_service_spec.rb' + - 'spec/services/projects/transfer_service_spec.rb' + - 'spec/services/protected_branches/cache_service_spec.rb' + - 'spec/services/quick_actions/interpret_service_spec.rb' + - 'spec/services/releases/links/create_service_spec.rb' + - 'spec/services/releases/links/destroy_service_spec.rb' + - 'spec/services/releases/links/update_service_spec.rb' + - 'spec/services/resource_access_tokens/revoke_service_spec.rb' + - 'spec/services/search/global_service_spec.rb' + - 'spec/services/search_service_spec.rb' + - 'spec/services/security/ci_configuration/sast_create_service_spec.rb' + - 'spec/services/service_desk/custom_email_verifications/create_service_spec.rb' + - 'spec/services/snippets/bulk_destroy_service_spec.rb' + - 'spec/services/snippets/create_service_spec.rb' + - 'spec/services/snippets/destroy_service_spec.rb' + - 'spec/services/snippets/update_service_spec.rb' + - 'spec/services/tasks_to_be_done/base_service_spec.rb' + - 'spec/services/todo_service_spec.rb' + - 'spec/services/todos/destroy/entity_leave_service_spec.rb' + - 'spec/services/uploads/destroy_service_spec.rb' + - 'spec/services/users/set_namespace_commit_email_service_spec.rb' + - 'spec/services/work_items/import_csv_service_spec.rb' + - 'spec/services/work_items/parent_links/base_service_spec.rb' + - 'spec/services/work_items/parent_links/create_service_spec.rb' + - 'spec/services/work_items/parent_links/destroy_service_spec.rb' + - 'spec/services/work_items/parent_links/reorder_service_spec.rb' + - 'spec/services/work_items/update_service_spec.rb' + - 'spec/services/work_items/widgets/description_service/update_service_spec.rb' + - 'spec/services/work_items/widgets/hierarchy_service/create_service_spec.rb' + - 'spec/services/work_items/widgets/hierarchy_service/update_service_spec.rb' + - 'spec/support/helpers/cycle_analytics_helpers/test_generation.rb' + - 'spec/support/shared_contexts/changes_access_checks_shared_context.rb' + - 'spec/support/shared_contexts/design_management_shared_contexts.rb' + - 'spec/support/shared_contexts/features/integrations/project_integrations_shared_context.rb' + - 'spec/support/shared_contexts/sentry_error_tracking_shared_context.rb' + - 'spec/support/shared_examples/features/board_sidebar_labels_examples.rb' + - 'spec/support/shared_examples/features/search/redacted_search_results_shared_examples.rb' + - 'spec/support/shared_examples/features/snippets_shared_examples.rb' + - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' + - 'spec/support/shared_examples/graphql/members_shared_examples.rb' + - 'spec/support/shared_examples/graphql/mutations/security/ci_configuration_shared_examples.rb' + - 'spec/support/shared_examples/models/chat_integration_shared_examples.rb' + - 'spec/support/shared_examples/quick_actions/issue/issue_links_quick_actions_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/projects/branch_protections/access_level_request_examples.rb' + - 'spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb' + - 'spec/support/shared_examples/services/issuable/issuable_import_csv_service_shared_examples.rb' + - 'spec/support/shared_examples/services/security/ci_configuration/create_service_shared_examples.rb' + - 'spec/views/groups/group_members/index.html.haml_spec.rb' + - 'spec/views/layouts/header/_new_dropdown.haml_spec.rb' + - 'spec/views/projects/issues/_service_desk_info_content.html.haml_spec.rb' + - 'spec/views/projects/pages/new.html.haml_spec.rb' + - 'spec/views/projects/project_members/index.html.haml_spec.rb' + - 'spec/workers/group_destroy_worker_spec.rb' + - 'spec/workers/merge_requests/update_head_pipeline_worker_spec.rb' + - 'spec/workers/pipeline_schedule_worker_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index d32abc64f94..c1751ebed4c 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -1,5 +1,6 @@ --- RSpec/ContextWording: + Details: grace period Exclude: - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - 'ee/spec/controllers/admin/audit_logs_controller_spec.rb' @@ -64,10 +65,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/controllers/trial_registrations_controller_spec.rb' - 'ee/spec/controllers/users_controller_spec.rb' - - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - - 'ee/spec/elastic/migrate/20220512150000_pause_indexing_for_unsupported_es_versions_spec.rb' - - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' - - 'ee/spec/elastic/migrate/20220713103500_delete_commits_from_original_index_spec.rb' - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/elastic_integration/global_search_spec.rb' - 'ee/spec/features/admin/admin_audit_logs_spec.rb' @@ -87,6 +84,7 @@ RSpec/ContextWording: - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_labels_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_spec.rb' + - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/dashboards/todos_spec.rb' - 'ee/spec/features/discussion_comments/epic_quick_actions_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' @@ -125,7 +123,6 @@ RSpec/ContextWording: - 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb' - 'ee/spec/features/labels_hierarchy_spec.rb' - 'ee/spec/features/markdown/markdown_spec.rb' - - 'ee/spec/features/markdown/metrics_spec.rb' - 'ee/spec/features/merge_request/merge_request_widget_blocking_mrs_spec.rb' - 'ee/spec/features/merge_request/user_approves_spec.rb' - 'ee/spec/features/merge_request/user_creates_merge_request_with_blocking_mrs_spec.rb' @@ -168,7 +165,6 @@ RSpec/ContextWording: - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/protected_branches_spec.rb' - 'ee/spec/features/signup_spec.rb' - - 'ee/spec/features/trial_registrations/company_information_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/features/users/signup_spec.rb' - 'ee/spec/finders/approval_rules/group_finder_spec.rb' @@ -184,7 +180,6 @@ RSpec/ContextWording: - 'ee/spec/finders/ee/clusters/agents/authorizations/ci_access/finder_spec.rb' - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' - - 'ee/spec/finders/ee/namespaces/projects_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' - 'ee/spec/finders/ee/user_recent_events_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' @@ -207,14 +202,12 @@ RSpec/ContextWording: - 'ee/spec/finders/security/vulnerabilities_finder_spec.rb' - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - 'ee/spec/finders/snippets_finder_spec.rb' - - 'ee/spec/finders/software_license_policies_finder_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' - 'ee/spec/frontend/fixtures/search.rb' - 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' - - 'ee/spec/graphql/ee/types/projects/service_type_enum_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/headers/create_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' @@ -245,7 +238,6 @@ RSpec/ContextWording: - 'ee/spec/graphql/resolvers/boards/board_list_epics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/dora_metrics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/oncall_schedule_resolver_spec.rb' - 'ee/spec/graphql/resolvers/instance_security_dashboard/projects_resolver_spec.rb' @@ -256,6 +248,7 @@ RSpec/ContextWording: - 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb' - 'ee/spec/graphql/types/global_id_type_spec.rb' - 'ee/spec/graphql/types/incident_management/escalation_rule_input_type_spec.rb' + - 'ee/spec/graphql/types/incident_management/oncall_rotation_date_input_type_spec.rb' - 'ee/spec/graphql/types/issue_type_spec.rb' - 'ee/spec/graphql/types/project_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' @@ -276,16 +269,15 @@ RSpec/ContextWording: - 'ee/spec/helpers/ee/operations_helper_spec.rb' - 'ee/spec/helpers/ee/personal_access_tokens_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb' - - 'ee/spec/helpers/groups/security_features_helper_spec.rb' - 'ee/spec/helpers/license_helper_spec.rb' - 'ee/spec/helpers/license_monitoring_helper_spec.rb' - - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' + - 'ee/spec/helpers/web_hooks/web_hooks_helper_spec.rb' - 'ee/spec/initializers/1_settings_spec.rb' - 'ee/spec/initializers/session_store_spec.rb' - 'ee/spec/lib/audit/details_spec.rb' @@ -310,7 +302,6 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/needs_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/templates/templates_spec.rb' - 'ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_batch_spec.rb' @@ -338,7 +329,6 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/gma_membership_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/identity_linker_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/sso_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/token_actor_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/adapter_spec.rb' @@ -369,8 +359,6 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/code_owners/groups_loader_spec.rb' - 'ee/spec/lib/gitlab/code_owners/loader_spec.rb' - 'ee/spec/lib/gitlab/code_owners/users_loader_spec.rb' - - 'ee/spec/lib/gitlab/com_spec.rb' - - 'ee/spec/lib/gitlab/contribution_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb' - 'ee/spec/lib/gitlab/elastic/client_spec.rb' @@ -432,6 +420,7 @@ RSpec/ContextWording: - 'ee/spec/models/boards/epic_board_position_spec.rb' - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' + - 'ee/spec/models/ci/pipeline_spec.rb' - 'ee/spec/models/ci/sources/project_spec.rb' - 'ee/spec/models/ci/subscriptions/project_spec.rb' - 'ee/spec/models/concerns/approval_rule_like_spec.rb' @@ -546,7 +535,6 @@ RSpec/ContextWording: - 'ee/spec/requests/api/ci/runner_spec.rb' - 'ee/spec/requests/api/commits_spec.rb' - 'ee/spec/requests/api/deployments_spec.rb' - - 'ee/spec/requests/api/dora/metrics_spec.rb' - 'ee/spec/requests/api/epic_issues_spec.rb' - 'ee/spec/requests/api/epic_links_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' @@ -785,6 +773,7 @@ RSpec/ContextWording: - 'ee/spec/services/merge_requests/reload_merge_head_diff_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - 'ee/spec/services/milestones/update_service_spec.rb' + - 'ee/spec/services/package_metadata/ingestion/ingestion_service_spec.rb' - 'ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb' - 'ee/spec/services/personal_access_tokens/rotation_verifier_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' @@ -829,6 +818,7 @@ RSpec/ContextWording: - 'ee/spec/services/status_page/publish_attachments_service_spec.rb' - 'ee/spec/services/status_page/publish_details_service_spec.rb' - 'ee/spec/services/system_notes/epics_service_spec.rb' + - 'ee/spec/services/system_notes/vulnerabilities_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' @@ -882,7 +872,6 @@ RSpec/ContextWording: - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - 'ee/spec/support/shared_examples/services/search_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/update_issuable_health_status_shared_examples.rb' - - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'ee/spec/tasks/gitlab/license_rake_spec.rb' - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' - 'ee/spec/views/admin/users/show.html.haml_spec.rb' @@ -932,6 +921,7 @@ RSpec/ContextWording: - 'ee/spec/workers/post_receive_spec.rb' - 'ee/spec/workers/project_import_schedule_worker_spec.rb' - 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb' + - 'ee/spec/workers/security/store_scans_worker_spec.rb' - 'ee/spec/workers/security/track_secure_scans_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' @@ -949,7 +939,6 @@ RSpec/ContextWording: - 'qa/qa/specs/features/ee/browser_ui/2_plan/epic/epics_management_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' - 'qa/spec/git/repository_spec.rb' - 'qa/spec/page/element_spec.rb' - 'qa/spec/service/docker_run/gitlab_runner_spec.rb' @@ -960,6 +949,7 @@ RSpec/ContextWording: - 'qa/spec/support/page_error_checker_spec.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/bin/feature_flag_spec.rb' + - 'spec/commands/metrics_server/metrics_server_spec.rb' - 'spec/commands/sidekiq_cluster/cli_spec.rb' - 'spec/components/diffs/overflow_warning_component_spec.rb' - 'spec/components/pajamas/alert_component_spec.rb' @@ -1008,7 +998,6 @@ RSpec/ContextWording: - 'spec/controllers/import/bulk_imports_controller_spec.rb' - 'spec/controllers/import/fogbugz_controller_spec.rb' - 'spec/controllers/import/github_controller_spec.rb' - - 'spec/controllers/import/gitlab_controller_spec.rb' - 'spec/controllers/jira_connect/events_controller_spec.rb' - 'spec/controllers/jira_connect/subscriptions_controller_spec.rb' - 'spec/controllers/ldap/omniauth_callbacks_controller_spec.rb' @@ -1073,6 +1062,7 @@ RSpec/ContextWording: - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/controllers/registrations_controller_spec.rb' + - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - 'spec/controllers/root_controller_spec.rb' - 'spec/controllers/search_controller_spec.rb' - 'spec/controllers/sessions_controller_spec.rb' @@ -1110,13 +1100,10 @@ RSpec/ContextWording: - 'spec/features/boards/sidebar_labels_in_namespaces_spec.rb' - 'spec/features/boards/sidebar_labels_spec.rb' - 'spec/features/boards/user_visits_board_spec.rb' - - 'spec/features/calendar_spec.rb' - - 'spec/features/clusters/cluster_health_dashboard_spec.rb' - 'spec/features/commits_spec.rb' - 'spec/features/dashboard/activity_spec.rb' - 'spec/features/dashboard/groups_list_spec.rb' - 'spec/features/dashboard/issues_filter_spec.rb' - - 'spec/features/dashboard/label_filter_spec.rb' - 'spec/features/dashboard/merge_requests_spec.rb' - 'spec/features/dashboard/projects_spec.rb' - 'spec/features/dashboard/shortcuts_spec.rb' @@ -1181,7 +1168,6 @@ RSpec/ContextWording: - 'spec/features/markdown/copy_as_gfm_spec.rb' - 'spec/features/markdown/keyboard_shortcuts_spec.rb' - 'spec/features/markdown/markdown_spec.rb' - - 'spec/features/markdown/metrics_spec.rb' - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/close_reopen_report_toggle_spec.rb' - 'spec/features/merge_request/merge_request_discussion_lock_spec.rb' @@ -1195,7 +1181,6 @@ RSpec/ContextWording: - 'spec/features/merge_request/user_manages_subscription_spec.rb' - 'spec/features/merge_request/user_merges_merge_request_spec.rb' - 'spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb' - - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb' - 'spec/features/merge_request/user_posts_diff_notes_spec.rb' - 'spec/features/merge_request/user_resolves_conflicts_spec.rb' - 'spec/features/merge_request/user_resolves_diff_notes_and_discussions_resolve_spec.rb' @@ -1281,7 +1266,6 @@ RSpec/ContextWording: - 'spec/features/projects/settings/project_settings_spec.rb' - 'spec/features/projects/settings/repository_settings_spec.rb' - 'spec/features/projects/settings/secure_files_spec.rb' - - 'spec/features/projects/settings/service_desk_setting_spec.rb' - 'spec/features/projects/settings/user_interacts_with_deploy_keys_spec.rb' - 'spec/features/projects/settings/visibility_settings_spec.rb' - 'spec/features/projects/settings/webhooks_settings_spec.rb' @@ -1315,7 +1299,6 @@ RSpec/ContextWording: - 'spec/features/users/show_spec.rb' - 'spec/features/users/snippets_spec.rb' - 'spec/features/users/terms_spec.rb' - - 'spec/finders/abuse_reports_finder_spec.rb' - 'spec/finders/admin/projects_finder_spec.rb' - 'spec/finders/alert_management/alerts_finder_spec.rb' - 'spec/finders/alert_management/http_integrations_finder_spec.rb' @@ -1414,7 +1397,6 @@ RSpec/ContextWording: - 'spec/graphql/resolvers/alert_management/integrations_resolver_spec.rb' - 'spec/graphql/resolvers/base_resolver_spec.rb' - 'spec/graphql/resolvers/blobs_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/runner_status_resolver_spec.rb' - 'spec/graphql/resolvers/clusters/agent_activity_events_resolver_spec.rb' - 'spec/graphql/resolvers/clusters/agent_tokens_resolver_spec.rb' - 'spec/graphql/resolvers/clusters/agents_resolver_spec.rb' @@ -1448,6 +1430,7 @@ RSpec/ContextWording: - 'spec/graphql/resolvers/users/group_count_resolver_spec.rb' - 'spec/graphql/resolvers/users/participants_resolver_spec.rb' - 'spec/graphql/subscriptions/issuable_updated_spec.rb' + - 'spec/graphql/types/alert_management/prometheus_integration_type_spec.rb' - 'spec/graphql/types/base_field_spec.rb' - 'spec/graphql/types/global_id_type_spec.rb' - 'spec/graphql/types/issue_type_spec.rb' @@ -1470,13 +1453,11 @@ RSpec/ContextWording: - 'spec/helpers/commits_helper_spec.rb' - 'spec/helpers/diff_helper_spec.rb' - 'spec/helpers/emails_helper_spec.rb' - - 'spec/helpers/environments_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/git_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/groups/group_members_helper_spec.rb' - 'spec/helpers/groups_helper_spec.rb' - - 'spec/helpers/integrations_helper_spec.rb' - 'spec/helpers/jira_connect_helper_spec.rb' - 'spec/helpers/labels_helper_spec.rb' - 'spec/helpers/listbox_helper_spec.rb' @@ -1496,13 +1477,11 @@ RSpec/ContextWording: - 'spec/helpers/timeboxes_helper_spec.rb' - 'spec/helpers/todos_helper_spec.rb' - 'spec/helpers/tree_helper_spec.rb' - - 'spec/helpers/users/callouts_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - 'spec/helpers/visibility_level_helper_spec.rb' - 'spec/helpers/web_hooks/web_hooks_helper_spec.rb' - 'spec/helpers/whats_new_helper_spec.rb' - 'spec/helpers/wiki_helper_spec.rb' - - 'spec/initializers/00_rails_disable_joins_spec.rb' - 'spec/initializers/1_acts_as_taggable_spec.rb' - 'spec/initializers/carrierwave_s3_encryption_headers_patch_spec.rb' - 'spec/initializers/enumerator_next_patch_spec.rb' @@ -1515,6 +1494,7 @@ RSpec/ContextWording: - 'spec/lib/api/entities/basic_project_details_spec.rb' - 'spec/lib/api/entities/clusters/agents/authorizations/ci_access_spec.rb' - 'spec/lib/api/entities/nuget/dependency_group_spec.rb' + - 'spec/lib/api/entities/nuget/metadatum_spec.rb' - 'spec/lib/api/entities/user_spec.rb' - 'spec/lib/api/every_api_endpoint_spec.rb' - 'spec/lib/api/helpers/caching_spec.rb' @@ -1536,7 +1516,7 @@ RSpec/ContextWording: - 'spec/lib/api/validations/validators/untrusted_regexp_spec.rb' - 'spec/lib/atlassian/jira_connect/jwt/asymmetric_spec.rb' - 'spec/lib/atlassian/jira_connect/jwt/symmetric_spec.rb' - - 'spec/lib/atlassian/jira_connect/serializers/deployment_entity_spec.rb' + - 'spec/lib/atlassian/jira_connect/serializers/build_entity_spec.rb' - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - 'spec/lib/atlassian/jira_connect_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' @@ -1552,8 +1532,6 @@ RSpec/ContextWording: - 'spec/lib/banzai/filter/external_link_filter_spec.rb' - 'spec/lib/banzai/filter/front_matter_filter_spec.rb' - 'spec/lib/banzai/filter/gollum_tags_filter_spec.rb' - - 'spec/lib/banzai/filter/inline_metrics_redactor_filter_spec.rb' - - 'spec/lib/banzai/filter/markdown_filter_spec.rb' - 'spec/lib/banzai/filter/reference_redactor_filter_spec.rb' - 'spec/lib/banzai/filter/references/abstract_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb' @@ -1645,9 +1623,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/blame_spec.rb' @@ -1690,7 +1666,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/config/external/file/local_spec.rb' - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - - 'spec/lib/gitlab/ci/jwt_spec.rb' - 'spec/lib/gitlab/ci/lint_spec.rb' - 'spec/lib/gitlab/ci/matching/runner_matcher_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' @@ -1709,6 +1684,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/reports/security/aggregated_report_spec.rb' - 'spec/lib/gitlab/ci/reports/test_suite_comparer_spec.rb' - 'spec/lib/gitlab/ci/runner_instructions_spec.rb' + - 'spec/lib/gitlab/ci/runner_releases_spec.rb' - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb' - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' @@ -1716,7 +1692,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/status/factory_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/code_quality_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_latest_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/test_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/templates_spec.rb' @@ -1756,6 +1731,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/database/count/reltuples_count_strategy_spec.rb' - 'spec/lib/gitlab/database/count/tablesample_count_strategy_spec.rb' - 'spec/lib/gitlab/database/count_spec.rb' + - 'spec/lib/gitlab/database/gitlab_schema_spec.rb' - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb' @@ -1764,6 +1740,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - 'spec/lib/gitlab/database/migration_spec.rb' @@ -1795,7 +1772,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/database/schema_migrations/context_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' - - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/default_branch_spec.rb' - 'spec/lib/gitlab/deploy_key_access_spec.rb' @@ -1846,6 +1822,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - 'spec/lib/gitlab/git/merge_base_spec.rb' + - 'spec/lib/gitlab/git/pre_receive_error_spec.rb' - 'spec/lib/gitlab/git/raw_diff_change_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' @@ -1913,6 +1890,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' + - 'spec/lib/gitlab/import_export/references_configuration_spec.rb' - 'spec/lib/gitlab/import_export/version_checker_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_base_spec.rb' - 'spec/lib/gitlab/instrumentation_helper_spec.rb' @@ -2035,6 +2013,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ssh_public_key_spec.rb' - 'spec/lib/gitlab/submodule_links_spec.rb' - 'spec/lib/gitlab/suggestions/commit_message_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/time_tracking_formatter_spec.rb' - 'spec/lib/gitlab/tracking/destinations/snowplow_spec.rb' @@ -2062,10 +2041,10 @@ RSpec/ContextWording: - 'spec/lib/gitlab/usage_data_counters/search_counter_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/lazy_attributes_spec.rb' + - 'spec/lib/gitlab/utils/markdown_spec.rb' - 'spec/lib/gitlab/utils/mime_type_spec.rb' - - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' + - 'spec/lib/gitlab/utils/sanitize_node_link_spec.rb' - 'spec/lib/gitlab/utils/usage_data_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/view/presenter/base_spec.rb' - 'spec/lib/gitlab/visibility_level_checker_spec.rb' - 'spec/lib/gitlab/visibility_level_spec.rb' @@ -2168,6 +2147,7 @@ RSpec/ContextWording: - 'spec/models/concerns/ci/artifactable_spec.rb' - 'spec/models/concerns/ci/has_ref_spec.rb' - 'spec/models/concerns/ci/has_status_spec.rb' + - 'spec/models/concerns/counter_attribute_spec.rb' - 'spec/models/concerns/deployment_platform_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/issuable_spec.rb' @@ -2177,9 +2157,9 @@ RSpec/ContextWording: - 'spec/models/concerns/noteable_spec.rb' - 'spec/models/concerns/nullify_if_blank_spec.rb' - 'spec/models/concerns/participable_spec.rb' - - 'spec/models/concerns/protected_ref_access_spec.rb' - 'spec/models/concerns/reactive_caching_spec.rb' - 'spec/models/concerns/resolvable_note_spec.rb' + - 'spec/models/concerns/sensitive_serializable_hash_spec.rb' - 'spec/models/concerns/token_authenticatable_spec.rb' - 'spec/models/concerns/triggerable_hooks_spec.rb' - 'spec/models/concerns/usage_statistics_spec.rb' @@ -2203,7 +2183,6 @@ RSpec/ContextWording: - 'spec/models/environment_status_spec.rb' - 'spec/models/error_tracking/error_spec.rb' - 'spec/models/event_spec.rb' - - 'spec/models/external_pull_request_spec.rb' - 'spec/models/gpg_key_spec.rb' - 'spec/models/grafana_integration_spec.rb' - 'spec/models/group_label_spec.rb' @@ -2214,7 +2193,6 @@ RSpec/ContextWording: - 'spec/models/import_export_upload_spec.rb' - 'spec/models/import_failure_spec.rb' - 'spec/models/integration_spec.rb' - - 'spec/models/integrations/asana_spec.rb' - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/chat_message/issue_message_spec.rb' @@ -2341,7 +2319,6 @@ RSpec/ContextWording: - 'spec/presenters/gitlab/blame_presenter_spec.rb' - 'spec/presenters/merge_request_presenter_spec.rb' - 'spec/presenters/packages/conan/package_presenter_spec.rb' - - 'spec/presenters/packages/npm/package_presenter_spec.rb' - 'spec/presenters/project_presenter_spec.rb' - 'spec/presenters/projects/import_export/project_export_presenter_spec.rb' - 'spec/presenters/projects/security/configuration_presenter_spec.rb' @@ -2369,7 +2346,6 @@ RSpec/ContextWording: - 'spec/requests/api/ci/pipeline_schedules_spec.rb' - 'spec/requests/api/ci/pipelines_spec.rb' - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' - - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - 'spec/requests/api/ci/runner/runners_post_spec.rb' - 'spec/requests/api/ci/runner/runners_reset_spec.rb' - 'spec/requests/api/ci/runners_spec.rb' @@ -2464,7 +2440,6 @@ RSpec/ContextWording: - 'spec/requests/api/internal/kubernetes_spec.rb' - 'spec/requests/api/internal/lfs_spec.rb' - 'spec/requests/api/internal/mail_room_spec.rb' - - 'spec/requests/api/internal/pages_spec.rb' - 'spec/requests/api/internal/workhorse_spec.rb' - 'spec/requests/api/invitations_spec.rb' - 'spec/requests/api/issue_links_spec.rb' @@ -2500,6 +2475,7 @@ RSpec/ContextWording: - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/remote_mirrors_spec.rb' - 'spec/requests/api/repositories_spec.rb' + - 'spec/requests/api/resource_access_tokens_spec.rb' - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/search_spec.rb' - 'spec/requests/api/settings_spec.rb' @@ -2579,6 +2555,8 @@ RSpec/ContextWording: - 'spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb' - 'spec/rubocop/cop/qa/element_with_pattern_spec.rb' - 'spec/rubocop/cop/qa/selector_usage_spec.rb' + - 'spec/rubocop/cop/rspec/be_success_matcher_spec.rb' + - 'spec/rubocop/cop/rspec/expect_gitlab_tracking_spec.rb' - 'spec/rubocop/cop/rspec/factory_bot/inline_association_spec.rb' - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' @@ -2586,7 +2564,6 @@ RSpec/ContextWording: - 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb' - 'spec/serializers/diff_file_base_entity_spec.rb' - 'spec/serializers/diffs_entity_spec.rb' - - 'spec/serializers/environment_entity_spec.rb' - 'spec/serializers/environment_serializer_spec.rb' - 'spec/serializers/group_child_entity_spec.rb' - 'spec/serializers/group_link/group_group_link_entity_spec.rb' @@ -2643,8 +2620,8 @@ RSpec/ContextWording: - 'spec/services/ci/update_build_queue_service_spec.rb' - 'spec/services/ci/update_pending_build_service_spec.rb' - 'spec/services/clusters/agent_tokens/track_usage_service_spec.rb' - - 'spec/services/clusters/agents/delete_expired_events_service_spec.rb' - 'spec/services/clusters/agents/authorizations/ci_access/refresh_service_spec.rb' + - 'spec/services/clusters/agents/delete_expired_events_service_spec.rb' - 'spec/services/clusters/build_kubernetes_namespace_service_spec.rb' - 'spec/services/clusters/create_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' @@ -2671,8 +2648,8 @@ RSpec/ContextWording: - 'spec/services/draft_notes/publish_service_spec.rb' - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' - 'spec/services/environments/stop_service_spec.rb' - - 'spec/services/error_tracking/list_issues_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' + - 'spec/services/event_create_service_spec.rb' - 'spec/services/events/destroy_service_spec.rb' - 'spec/services/feature_flags/update_service_spec.rb' - 'spec/services/files/create_service_spec.rb' @@ -2799,13 +2776,13 @@ RSpec/ContextWording: - 'spec/services/packages/maven/metadata/create_versions_xml_service_spec.rb' - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - 'spec/services/packages/npm/create_package_service_spec.rb' - - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' - 'spec/services/packages/nuget/search_service_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/packages/rubygems/dependency_resolver_service_spec.rb' - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - 'spec/services/pages/zip_directory_service_spec.rb' + - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - 'spec/services/personal_access_tokens/create_service_spec.rb' - 'spec/services/personal_access_tokens/revoke_service_spec.rb' - 'spec/services/post_receive_service_spec.rb' @@ -2900,14 +2877,7 @@ RSpec/ContextWording: - 'spec/services/wikis/create_attachment_service_spec.rb' - 'spec/services/work_items/create_service_spec.rb' - 'spec/services/work_items/parent_links/create_service_spec.rb' - - 'spec/support/banzai/reference_filter_shared_examples.rb' - - 'spec/support/prometheus/additional_metrics_shared_examples.rb' - - 'spec/support/redis/redis_shared_examples.rb' - - 'spec/support/services/clusters/create_service_shared.rb' - - 'spec/support/services/deploy_token_shared_examples.rb' - - 'spec/support/services/issuable_import_csv_service_shared_examples.rb' - - 'spec/support/services/issuable_update_service_shared_examples.rb' - - 'spec/support/services/migrate_to_ghost_user_service_shared_examples.rb' + - 'spec/support/helpers/cycle_analytics_helpers/test_generation.rb' - 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb' - 'spec/support/shared_contexts/changes_access_checks_shared_context.rb' - 'spec/support/shared_contexts/container_repositories_shared_context.rb' @@ -2927,13 +2897,11 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/finders/group_projects_finder_shared_contexts.rb' - 'spec/support/shared_contexts/finders/issues_finder_shared_contexts.rb' - 'spec/support/shared_contexts/finders/merge_requests_finder_shared_contexts.rb' - - 'spec/support/shared_contexts/finders/packages/npm/package_finder_shared_context.rb' - 'spec/support/shared_contexts/finders/users_finder_shared_contexts.rb' - 'spec/support/shared_contexts/finders/work_items_finder_shared_contexts.rb' - 'spec/support/shared_contexts/fixtures/analytics_shared_context.rb' - 'spec/support/shared_contexts/graphql/requests/packages_shared_context.rb' - 'spec/support/shared_contexts/graphql/resolvers/runners_resolver_shared_context.rb' - - 'spec/support/shared_contexts/issuable/merge_request_shared_context.rb' - 'spec/support/shared_contexts/issuable/project_shared_context.rb' - 'spec/support/shared_contexts/json_response_shared_context.rb' - 'spec/support/shared_contexts/lib/api/helpers/packages/dependency_proxy_helpers_shared_context.rb' @@ -2976,7 +2944,6 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/unique_ip_check_shared_context.rb' - 'spec/support/shared_contexts/upload_type_check_shared_context.rb' - 'spec/support/shared_contexts/url_shared_context.rb' - - 'spec/support/shared_examples/banzai/filters/inline_metrics_redactor_shared_examples.rb' - 'spec/support/shared_examples/boards/multiple_issue_boards_shared_examples.rb' - 'spec/support/shared_examples/controllers/clusters_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' @@ -2988,6 +2955,7 @@ RSpec/ContextWording: - 'spec/support/shared_examples/features/access_tokens_shared_examples.rb' - 'spec/support/shared_examples/features/archive_download_buttons_shared_examples.rb' - 'spec/support/shared_examples/features/board_sidebar_labels_examples.rb' + - 'spec/support/shared_examples/features/packages_shared_examples.rb' - 'spec/support/shared_examples/features/project_features_apply_to_issuables_shared_examples.rb' - 'spec/support/shared_examples/features/sidebar/sidebar_due_date_shared_examples.rb' - 'spec/support/shared_examples/features/sidebar/sidebar_labels_shared_examples.rb' @@ -3049,6 +3017,7 @@ RSpec/ContextWording: - 'spec/support/shared_examples/policies/project_policy_shared_examples.rb' - 'spec/support/shared_examples/policies/resource_access_token_shared_examples.rb' - 'spec/support/shared_examples/quick_actions/commit/tag_quick_action_shared_examples.rb' + - 'spec/support/shared_examples/quick_actions/issuable/close_quick_action_shared_examples.rb' - 'spec/support/shared_examples/quick_actions/issue/clone_quick_action_shared_examples.rb' - 'spec/support/shared_examples/quick_actions/issue/create_merge_request_quick_action_shared_examples.rb' - 'spec/support/shared_examples/quick_actions/issue/move_quick_action_shared_examples.rb' @@ -3068,7 +3037,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/requests/api/multiple_and_scoped_issue_boards_shared_examples.rb' - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - 'spec/support/shared_examples/requests/api/npm_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/nuget_endpoints_shared_examples.rb' - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' @@ -3093,7 +3061,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/services/metrics/dashboard_shared_examples.rb' - 'spec/support/shared_examples/services/notification_service_shared_examples.rb' - 'spec/support/shared_examples/services/packages_shared_examples.rb' - - 'spec/support/shared_examples/services/projects/update_repository_storage_service_shared_examples.rb' - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' - 'spec/support/shared_examples/services/schedule_bulk_repository_shard_moves_shared_examples.rb' - 'spec/support/shared_examples/services/security/ci_configuration/create_service_shared_examples.rb' @@ -3119,7 +3086,6 @@ RSpec/ContextWording: - 'spec/tasks/gitlab/lfs/migrate_rake_spec.rb' - 'spec/tasks/gitlab/packages/migrate_rake_spec.rb' - 'spec/tasks/gitlab/storage_rake_spec.rb' - - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' @@ -3213,7 +3179,6 @@ RSpec/ContextWording: - 'spec/workers/integrations/create_external_cross_reference_worker_spec.rb' - 'spec/workers/issues/placement_worker_spec.rb' - 'spec/workers/merge_requests/delete_source_branch_worker_spec.rb' - - 'spec/workers/metrics/dashboard/prune_old_annotations_worker_spec.rb' - 'spec/workers/packages/composer/cache_update_worker_spec.rb' - 'spec/workers/packages/go/sync_packages_worker_spec.rb' - 'spec/workers/packages/maven/metadata/sync_worker_spec.rb' diff --git a/.rubocop_todo/rspec/described_class.yml b/.rubocop_todo/rspec/described_class.yml index 67f7c365248..5868749048a 100644 --- a/.rubocop_todo/rspec/described_class.yml +++ b/.rubocop_todo/rspec/described_class.yml @@ -2,189 +2,10 @@ # Cop supports --autocorrect. RSpec/DescribedClass: Exclude: - - 'ee/spec/models/concerns/elastic/merge_request_spec.rb' - - 'ee/spec/models/concerns/elastic/note_spec.rb' - - 'ee/spec/models/concerns/elastic/project_spec.rb' - - 'ee/spec/models/concerns/elastic/repository_spec.rb' - - 'ee/spec/models/dast_scanner_profile_spec.rb' - - 'ee/spec/models/dast_site_profile_spec.rb' - - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - - 'ee/spec/models/ee/ci/pending_build_spec.rb' - - 'ee/spec/models/ee/ci/runner_spec.rb' - - 'ee/spec/models/ee/gpg_key_spec.rb' - - 'ee/spec/models/ee/group_spec.rb' - - 'ee/spec/models/ee/project_spec.rb' - - 'ee/spec/models/ee/vulnerability_spec.rb' - - 'ee/spec/models/epic_issue_spec.rb' - - 'ee/spec/models/epic_spec.rb' - - 'ee/spec/models/geo/container_repository_registry_spec.rb' - - 'ee/spec/models/geo/design_registry_spec.rb' - - 'ee/spec/models/geo/package_file_registry_spec.rb' - - 'ee/spec/models/geo/project_registry_spec.rb' - - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - - 'ee/spec/models/issuable_metric_image_spec.rb' - - 'ee/spec/models/issue_spec.rb' - - 'ee/spec/models/iteration_spec.rb' - - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/project_import_state_spec.rb' - - 'ee/spec/models/release_highlight_spec.rb' - - 'ee/spec/models/requirements_management/test_report_spec.rb' - - 'ee/spec/models/resource_weight_event_spec.rb' - - 'ee/spec/models/uploads/local_spec.rb' - - 'ee/spec/models/vulnerabilities/flag_spec.rb' - - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/ee/resource_events/synthetic_weight_notes_builder_service_spec.rb' - - 'ee/spec/services/ee/users/reject_service_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - - 'ee/spec/services/users/captcha_challenge_service_spec.rb' - - 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb' - - 'ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb' - - 'ee/spec/workers/geo/verification_state_backfill_worker_spec.rb' - 'qa/spec/service/docker_run/base_spec.rb' - 'qa/spec/support/loglinking_spec.rb' - 'qa/spec/support/page_error_checker_spec.rb' - - 'spec/config/settings_spec.rb' - - 'spec/controllers/repositories/git_http_controller_spec.rb' - - 'spec/experiments/application_experiment_spec.rb' - - 'spec/experiments/concerns/project_commit_count_spec.rb' - - 'spec/frontend/fixtures/timezones.rb' - - 'spec/graphql/gitlab_schema_spec.rb' - - 'spec/graphql/graphql_triggers_spec.rb' - - 'spec/graphql/types/global_id_type_spec.rb' - - 'spec/initializers/google_api_client_spec.rb' - - 'spec/lib/api/entities/project_spec.rb' - - 'spec/lib/api/helpers_spec.rb' - 'spec/lib/feature_spec.rb' - - 'spec/lib/gitlab/asciidoc/html5_converter_spec.rb' - - 'spec/lib/gitlab/buffered_io_spec.rb' - - 'spec/lib/gitlab/checks/snippet_check_spec.rb' - - 'spec/lib/gitlab/ci/tags/bulk_insert_spec.rb' - 'spec/lib/gitlab/ci/variables/collection/item_spec.rb' - - 'spec/lib/gitlab/ci/variables/collection/sort_spec.rb' - - 'spec/lib/gitlab/ci/variables/collection_spec.rb' - - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - - 'spec/lib/gitlab/config/entry/composable_array_spec.rb' - - 'spec/lib/gitlab/config/entry/composable_hash_spec.rb' - - 'spec/lib/gitlab/current_settings_spec.rb' - - 'spec/lib/gitlab/database/background_migration/health_status_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/primary_host_spec.rb' - - 'spec/lib/gitlab/database/migrations/lock_retry_mixin_spec.rb' - - 'spec/lib/gitlab/database/reindexing_spec.rb' - - 'spec/lib/gitlab/database/similarity_score_spec.rb' - - 'spec/lib/gitlab/database_spec.rb' - - 'spec/lib/gitlab/email/handler_spec.rb' - - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' - - 'spec/lib/gitlab/encrypted_configuration_spec.rb' - - 'spec/lib/gitlab/error_tracking/logger_spec.rb' - - 'spec/lib/gitlab/git/blame_spec.rb' - - 'spec/lib/gitlab/git/blob_spec.rb' - - 'spec/lib/gitlab/git/commit_spec.rb' - - 'spec/lib/gitlab/git/compare_spec.rb' - - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/git/tree_spec.rb' - - 'spec/lib/gitlab/git_access_snippet_spec.rb' - - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' - - 'spec/lib/gitlab/import_formatter_spec.rb' - - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb' - - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' - - 'spec/lib/gitlab/relative_positioning/range_spec.rb' - - 'spec/lib/gitlab/runtime_spec.rb' - - 'spec/lib/gitlab/seeder_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/client_spec.rb' - - 'spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb' - - 'spec/lib/gitlab/utils/measuring_spec.rb' - - 'spec/lib/gitlab/webpack/file_loader_spec.rb' - - 'spec/lib/gitlab/webpack/manifest_spec.rb' - - 'spec/lib/gitlab/x509/commit_spec.rb' - - 'spec/lib/gitlab/x509/signature_spec.rb' - - 'spec/lib/service_ping/devops_report_spec.rb' - - 'spec/lib/sidebars/panel_spec.rb' - - 'spec/models/active_session_spec.rb' - - 'spec/models/alert_management/alert_spec.rb' - - 'spec/models/application_record_spec.rb' - - 'spec/models/application_setting_spec.rb' - - 'spec/models/chat_name_spec.rb' - - 'spec/models/ci/build_runner_session_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/group_variable_spec.rb' - - 'spec/models/ci/job_artifact_spec.rb' - - 'spec/models/ci/pipeline_artifact_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/ci/processable_spec.rb' - - 'spec/models/ci/ref_spec.rb' - - 'spec/models/ci/variable_spec.rb' - - 'spec/models/ci_platform_metric_spec.rb' - - 'spec/models/clusters/cluster_spec.rb' - - 'spec/models/commit_spec.rb' - - 'spec/models/commit_status_spec.rb' - - 'spec/models/concerns/counter_attribute_spec.rb' - - 'spec/models/concerns/has_user_type_spec.rb' - - 'spec/models/concerns/integrations/enable_ssl_verification_spec.rb' - - 'spec/models/concerns/integrations/reset_secret_fields_spec.rb' - - 'spec/models/concerns/resolvable_note_spec.rb' - - 'spec/models/concerns/token_authenticatable_spec.rb' - - 'spec/models/customer_relations/contact_spec.rb' - - 'spec/models/customer_relations/organization_spec.rb' - - 'spec/models/dependency_proxy/manifest_spec.rb' - - 'spec/models/deployment_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/import_failure_spec.rb' - - 'spec/models/integration_spec.rb' - - 'spec/models/internal_id_spec.rb' - - 'spec/models/issue_assignee_spec.rb' - - 'spec/models/issue_spec.rb' - - 'spec/models/label_link_spec.rb' - - 'spec/models/lfs_objects_project_spec.rb' - - 'spec/models/loose_foreign_keys/deleted_record_spec.rb' - - 'spec/models/member_spec.rb' - - 'spec/models/merge_request_assignee_spec.rb' - - 'spec/models/merge_request_diff_commit_spec.rb' - - 'spec/models/merge_request_diff_file_spec.rb' - - 'spec/models/merge_request_spec.rb' - - 'spec/models/milestone_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/models/oauth_access_token_spec.rb' - - 'spec/models/packages/dependency_spec.rb' - - 'spec/models/packages/maven/metadatum_spec.rb' - - 'spec/models/packages/package_spec.rb' - - 'spec/models/pages_deployment_spec.rb' - - 'spec/models/pages_domain_spec.rb' - - 'spec/models/performance_monitoring/prometheus_dashboard_spec.rb' - - 'spec/models/performance_monitoring/prometheus_metric_spec.rb' - - 'spec/models/performance_monitoring/prometheus_panel_group_spec.rb' - - 'spec/models/performance_monitoring/prometheus_panel_spec.rb' - - 'spec/models/postgresql/detached_partition_spec.rb' - - 'spec/models/preloaders/user_max_access_level_in_projects_preloader_spec.rb' - - 'spec/models/project_spec.rb' - - 'spec/models/projects/topic_spec.rb' - - 'spec/models/release_highlight_spec.rb' - - 'spec/models/release_spec.rb' - - 'spec/models/route_spec.rb' - - 'spec/models/todo_spec.rb' - - 'spec/models/u2f_registration_spec.rb' - - 'spec/models/user_custom_attribute_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/models/users/merge_request_interaction_spec.rb' - - 'spec/models/users_statistics_spec.rb' - - 'spec/models/wiki_directory_spec.rb' - - 'spec/models/work_items/type_spec.rb' - - 'spec/serializers/context_commits_diff_entity_spec.rb' - - 'spec/services/alert_management/alerts/todo/create_service_spec.rb' - - 'spec/services/auth/dependency_proxy_authentication_service_spec.rb' - - 'spec/services/ci/register_job_service_spec.rb' - - 'spec/services/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' - - 'spec/services/issuable/process_assignees_spec.rb' - - 'spec/services/merge_requests/update_service_spec.rb' - - 'spec/services/notification_service_spec.rb' - - 'spec/services/resource_events/synthetic_label_notes_builder_service_spec.rb' - - 'spec/services/snippets/update_service_spec.rb' - - 'spec/services/user_project_access_changed_service_spec.rb' - - 'spec/services/webauthn/authenticate_service_spec.rb' - - 'spec/services/webauthn/register_service_spec.rb' - - 'spec/support_specs/helpers/graphql_helpers_spec.rb' - - 'spec/validators/html_safety_validator_spec.rb' - - 'spec/workers/bulk_imports/entity_worker_spec.rb' - - 'spec/workers/jira_connect/retry_request_worker_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index abcd80f9b58..02d1427c384 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -44,7 +44,6 @@ RSpec/ExpectChange: - 'ee/spec/models/group_wiki_spec.rb' - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb' - 'ee/spec/models/member_spec.rb' - - 'ee/spec/models/product_analytics/jitsu_authentication_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/push_rule_spec.rb' - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 4b588f265c9..b0369d5180d 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -13,7 +13,6 @@ RSpec/ExpectInHook: - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - 'ee/spec/features/signup_spec.rb' - - 'ee/spec/features/trial_registrations/company_information_spec.rb' - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' @@ -40,7 +39,6 @@ RSpec/ExpectInHook: - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb' - - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/build_type_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/distribution_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/lucene_version_metric_spec.rb' @@ -232,7 +230,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' - 'spec/lib/gitlab/github_import/user_finder_spec.rb' - 'spec/lib/gitlab/gpg_spec.rb' - - 'spec/lib/gitlab/graphql/generic_tracing_spec.rb' - 'spec/lib/gitlab/health_checks/gitaly_check_spec.rb' - 'spec/lib/gitlab/health_checks/probes/collection_spec.rb' - 'spec/lib/gitlab/health_checks/puma_check_spec.rb' @@ -368,7 +365,6 @@ RSpec/ExpectInHook: - 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb' - 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' - - 'spec/services/clusters/integrations/prometheus_health_check_service_spec.rb' - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' - 'spec/services/dependency_proxy/image_ttl_group_policies/update_service_spec.rb' @@ -470,7 +466,6 @@ RSpec/ExpectInHook: - 'spec/tasks/gitlab/praefect_rake_spec.rb' - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tooling/danger/feature_flag_spec.rb' - - 'spec/tooling/rspec_flaky/listener_spec.rb' - 'spec/uploaders/file_mover_spec.rb' - 'spec/uploaders/gitlab_uploader_spec.rb' - 'spec/uploaders/object_storage_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml new file mode 100644 index 00000000000..39aed947a48 --- /dev/null +++ b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml @@ -0,0 +1,46 @@ +--- +RSpec/FactoryBot/ExcessiveCreateList: + Details: grace period + Exclude: + - 'ee/spec/controllers/groups/hooks_controller_spec.rb' + - 'ee/spec/features/search/elastic/global_search_spec.rb' + - 'ee/spec/models/audit_events/external_audit_event_destination_spec.rb' + - 'ee/spec/models/audit_events/instance_external_audit_event_destination_spec.rb' + - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/package_metadata/advisory_spec.rb' + - 'ee/spec/models/package_metadata/checkpoint_spec.rb' + - 'ee/spec/requests/projects/merge_requests_controller_spec.rb' + - 'ee/spec/services/ci/llm/generate_config_service_spec.rb' + - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' + - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' + - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' + - 'spec/controllers/admin/clusters_controller_spec.rb' + - 'spec/controllers/autocomplete_controller_spec.rb' + - 'spec/controllers/explore/projects_controller_spec.rb' + - 'spec/controllers/groups/clusters_controller_spec.rb' + - 'spec/controllers/projects/clusters_controller_spec.rb' + - 'spec/controllers/projects/feature_flags_controller_spec.rb' + - 'spec/controllers/projects/hooks_controller_spec.rb' + - 'spec/docs_screenshots/container_registry_docs.rb' + - 'spec/features/boards/boards_spec.rb' + - 'spec/features/issues/csv_spec.rb' + - 'spec/features/issues/user_edits_issue_spec.rb' + - 'spec/features/issues/user_scrolls_to_deeplinked_note_spec.rb' + - 'spec/features/projects/container_registry_spec.rb' + - 'spec/features/projects/work_items/work_item_spec.rb' + - 'spec/features/users/overview_spec.rb' + - 'spec/frontend/fixtures/timelogs.rb' + - 'spec/helpers/issuables_helper_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' + - 'spec/lib/gitlab/database/consistency_checker_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/requests/api/graphql/mutations/packages/destroy_files_spec.rb' + - 'spec/requests/api/project_packages_spec.rb' + - 'spec/services/database/consistency_check_service_spec.rb' + - 'spec/services/groups/transfer_service_spec.rb' + - 'spec/services/notification_service_spec.rb' + - 'spec/services/pages/migrate_from_legacy_storage_service_spec.rb' + - 'spec/services/todo_service_spec.rb' + - 'spec/support/shared_examples/services/notification_service_shared_examples.rb' + - 'spec/workers/ssh_keys/expired_notification_worker_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index 1f90a4c3ba5..0a559874217 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -63,7 +63,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/fork_targets_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' - - 'ee/spec/finders/ee/namespaces/projects_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' - 'ee/spec/finders/ee/user_recent_events_finder_spec.rb' - 'ee/spec/finders/ee/work_items/work_items_finder_spec.rb' @@ -155,7 +154,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/ee/types/merge_request_type_spec.rb' - 'ee/spec/graphql/ee/types/milestone_type_spec.rb' - 'ee/spec/graphql/ee/types/mutation_type_spec.rb' - - 'ee/spec/graphql/ee/types/namespace_type_spec.rb' - 'ee/spec/graphql/ee/types/notes/noteable_interface_spec.rb' - 'ee/spec/graphql/ee/types/projects/branch_rule_type_spec.rb' - 'ee/spec/graphql/ee/types/projects/service_type_enum_spec.rb' @@ -723,8 +721,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/elastic/latest/issue_config_spec.rb' - 'ee/spec/lib/elastic/latest/merge_request_config_spec.rb' - 'ee/spec/lib/elastic/latest/note_config_spec.rb' - - 'ee/spec/lib/elastic/latest/project_wiki_class_proxy_spec.rb' - - 'ee/spec/lib/elastic/latest/project_wiki_instance_proxy_spec.rb' - 'ee/spec/lib/elastic/latest/routing_spec.rb' - 'ee/spec/lib/elastic/latest/snippet_instance_proxy_spec.rb' - 'ee/spec/lib/elastic/latest/user_config_spec.rb' @@ -926,7 +922,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/status_page/usage_data_counters/incident_counter_spec.rb' - 'ee/spec/lib/gitlab/status_page_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/client_spec.rb' - - 'ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb' - 'ee/spec/lib/gitlab/template/custom_templates_spec.rb' - 'ee/spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'ee/spec/lib/gitlab/tracking/standard_context_spec.rb' @@ -949,8 +944,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_projects_with_assigned_security_policy_project_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_projects_with_external_status_checks_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_saml_group_links_metric_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_slack_app_installations_gbp_metric_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_slack_app_installations_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_with_applied_scan_result_policies_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_users_associating_group_milestones_to_releases_metric_spec.rb' @@ -1192,7 +1185,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/path_lock_spec.rb' - 'ee/spec/models/plan_spec.rb' - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' - - 'ee/spec/models/product_analytics/jitsu_authentication_spec.rb' - 'ee/spec/models/productivity_analytics_spec.rb' - 'ee/spec/models/project_alias_spec.rb' - 'ee/spec/models/project_ci_cd_setting_spec.rb' @@ -1364,7 +1356,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/serializers/licenses_list_serializer_spec.rb' - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb' - 'ee/spec/serializers/member_user_entity_spec.rb' - - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb' - 'ee/spec/serializers/merge_request_sidebar_basic_entity_spec.rb' - 'ee/spec/serializers/metrics_report_metric_entity_spec.rb' - 'ee/spec/serializers/metrics_reports_comparer_entity_spec.rb' @@ -1719,7 +1710,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/profiles/preferences_controller_spec.rb' - 'spec/controllers/profiles/webauthn_registrations_controller_spec.rb' - 'spec/controllers/profiles_controller_spec.rb' - - 'spec/controllers/projects/alert_management_controller_spec.rb' - 'spec/controllers/projects/alerting/notifications_controller_spec.rb' - 'spec/controllers/projects/analytics/cycle_analytics/stages_controller_spec.rb' - 'spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' @@ -1749,7 +1739,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/find_file_controller_spec.rb' - 'spec/controllers/projects/graphs_controller_spec.rb' - 'spec/controllers/projects/import/jira_controller_spec.rb' - - 'spec/controllers/projects/incidents_controller_spec.rb' - 'spec/controllers/projects/issue_links_controller_spec.rb' - 'spec/controllers/projects/mattermosts_controller_spec.rb' - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' @@ -1773,7 +1762,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/releases/evidences_controller_spec.rb' - 'spec/controllers/projects/releases_controller_spec.rb' - 'spec/controllers/projects/security/configuration_controller_spec.rb' - - 'spec/controllers/projects/service_desk_controller_spec.rb' - 'spec/controllers/projects/service_ping_controller_spec.rb' - 'spec/controllers/projects/settings/integration_hook_logs_controller_spec.rb' - 'spec/controllers/projects/settings/merge_requests_controller_spec.rb' @@ -1809,8 +1797,6 @@ RSpec/MissingFeatureCategory: - 'spec/dependencies/omniauth_saml_spec.rb' - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' - - 'spec/experiments/concerns/project_commit_count_spec.rb' - - 'spec/experiments/force_company_trial_experiment_spec.rb' - 'spec/experiments/in_product_guidance_environments_webide_experiment_spec.rb' - 'spec/experiments/ios_specific_templates_experiment_spec.rb' - 'spec/features/admin/dashboard_spec.rb' @@ -3062,7 +3048,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/ansi2json/parser_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/result_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/style_spec.rb' - - 'spec/lib/gitlab/ci/artifact_file_reader_spec.rb' - 'spec/lib/gitlab/ci/artifacts/logger_spec.rb' - 'spec/lib/gitlab/ci/artifacts/metrics_spec.rb' - 'spec/lib/gitlab/ci/badge/coverage/metadata_spec.rb' @@ -3759,7 +3744,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/graphql/batch_key_spec.rb' - 'spec/lib/gitlab/graphql/calls_gitaly/field_extension_spec.rb' - 'spec/lib/gitlab/graphql/copy_field_description_spec.rb' - - 'spec/lib/gitlab/graphql/generic_tracing_spec.rb' - 'spec/lib/gitlab/graphql/known_operations_spec.rb' - 'spec/lib/gitlab/graphql/lazy_spec.rb' - 'spec/lib/gitlab/graphql/limit/field_call_count_spec.rb' @@ -4414,7 +4398,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/utils/safe_inline_hash_spec.rb' - 'spec/lib/gitlab/utils/sanitize_node_link_spec.rb' - 'spec/lib/gitlab/utils/usage_data_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/uuid_spec.rb' - 'spec/lib/gitlab/verify/job_artifacts_spec.rb' - 'spec/lib/gitlab/verify/lfs_objects_spec.rb' @@ -4789,7 +4772,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/event_collection_spec.rb' - 'spec/models/exported_protected_branch_spec.rb' - 'spec/models/external_issue_spec.rb' - - 'spec/models/external_pull_request_spec.rb' - 'spec/models/fork_network_member_spec.rb' - 'spec/models/fork_network_spec.rb' - 'spec/models/generic_commit_status_spec.rb' @@ -5009,7 +4991,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/projects/project_topic_spec.rb' - 'spec/models/projects/repository_storage_move_spec.rb' - 'spec/models/projects/topic_spec.rb' - - 'spec/models/projects/triggered_hooks_spec.rb' - 'spec/models/projects/wiki_repository_spec.rb' - 'spec/models/prometheus_alert_event_spec.rb' - 'spec/models/prometheus_alert_spec.rb' @@ -5288,7 +5269,6 @@ RSpec/MissingFeatureCategory: - 'spec/rubocop/cop/graphql/descriptions_spec.rb' - 'spec/rubocop/cop/graphql/enum_names_spec.rb' - 'spec/rubocop/cop/graphql/enum_values_spec.rb' - - 'spec/rubocop/cop/graphql/gid_expected_type_spec.rb' - 'spec/rubocop/cop/graphql/graphql_name_position_spec.rb' - 'spec/rubocop/cop/graphql/id_type_spec.rb' - 'spec/rubocop/cop/graphql/json_type_spec.rb' @@ -5369,9 +5349,7 @@ RSpec/MissingFeatureCategory: - 'spec/rubocop/cop/usage_data/instrumentation_superclass_spec.rb' - 'spec/rubocop/cop/usage_data/large_table_spec.rb' - 'spec/rubocop/cop/user_admin_spec.rb' - - 'spec/rubocop/cop_todo_spec.rb' - 'spec/rubocop/formatter/graceful_formatter_spec.rb' - - 'spec/rubocop/formatter/todo_formatter_spec.rb' - 'spec/rubocop/migration_helpers_spec.rb' - 'spec/rubocop/qa_helpers_spec.rb' - 'spec/rubocop/todo_dir_spec.rb' @@ -5584,7 +5562,6 @@ RSpec/MissingFeatureCategory: - 'spec/support_specs/helpers/stub_method_calls_spec.rb' - 'spec/support_specs/matchers/be_sorted_spec.rb' - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - - 'spec/support_specs/time_travel_spec.rb' - 'spec/tasks/admin_mode_spec.rb' - 'spec/tasks/config_lint_rake_spec.rb' - 'spec/tasks/dev_rake_spec.rb' @@ -5638,12 +5615,6 @@ RSpec/MissingFeatureCategory: - 'spec/tooling/lib/tooling/test_map_generator_spec.rb' - 'spec/tooling/lib/tooling/test_map_packer_spec.rb' - 'spec/tooling/merge_request_spec.rb' - - 'spec/tooling/rspec_flaky/config_spec.rb' - - 'spec/tooling/rspec_flaky/example_spec.rb' - - 'spec/tooling/rspec_flaky/flaky_example_spec.rb' - - 'spec/tooling/rspec_flaky/flaky_examples_collection_spec.rb' - - 'spec/tooling/rspec_flaky/listener_spec.rb' - - 'spec/tooling/rspec_flaky/report_spec.rb' - 'spec/uploaders/attachment_uploader_spec.rb' - 'spec/uploaders/avatar_uploader_spec.rb' - 'spec/uploaders/ci/pipeline_artifact_uploader_spec.rb' @@ -5747,7 +5718,6 @@ RSpec/MissingFeatureCategory: - 'spec/views/layouts/nav/sidebar/_profile.html.haml_spec.rb' - 'spec/views/layouts/profile.html.haml_spec.rb' - 'spec/views/layouts/signup_onboarding.html.haml_spec.rb' - - 'spec/views/layouts/simple_registration.html.haml_spec.rb' - 'spec/views/layouts/terms.html.haml_spec.rb' - 'spec/views/notify/approved_merge_request_email.html.haml_spec.rb' - 'spec/views/notify/autodevops_disabled_email.text.erb_spec.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 20e4112da62..0f0a6f5a95a 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -91,7 +91,6 @@ RSpec/ReturnFromStub: - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' - 'spec/controllers/projects/merge_requests_controller_spec.rb' - - 'spec/controllers/projects/service_desk_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/features/groups/clusters/user_spec.rb' - 'spec/features/groups/container_registry_spec.rb' @@ -101,7 +100,6 @@ RSpec/ReturnFromStub: - 'spec/features/projects/container_registry_spec.rb' - 'spec/features/projects/environments/environment_spec.rb' - 'spec/features/projects/pages/user_edits_lets_encrypt_settings_spec.rb' - - 'spec/features/projects/settings/service_desk_setting_spec.rb' - 'spec/finders/events_finder_spec.rb' - 'spec/finders/projects/groups_finder_spec.rb' - 'spec/finders/snippets_finder_spec.rb' diff --git a/.rubocop_todo/rspec/useless_dynamic_definition.yml b/.rubocop_todo/rspec/useless_dynamic_definition.yml new file mode 100644 index 00000000000..b3dabf433a0 --- /dev/null +++ b/.rubocop_todo/rspec/useless_dynamic_definition.yml @@ -0,0 +1,12 @@ +--- +RSpec/UselessDynamicDefinition: + Details: grace period + Exclude: + - 'ee/spec/factories/ci/builds.rb' + - 'ee/spec/factories/ci/job_artifacts.rb' + - 'ee/spec/factories/ci/pipelines.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb' + - 'ee/spec/support/shared_examples/lib/gitlab/elastic/search_results_shared_examples.rb' + - 'spec/models/ci/resource_group_spec.rb' + - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' + - 'spec/support/helpers/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 9b0432f6546..0d66bf5604b 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -73,7 +73,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb' - 'ee/spec/lib/gitlab/middleware/ip_restrictor_spec.rb' - 'ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb' - - 'ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb' - 'ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb' - 'ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb' - 'ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb' @@ -261,7 +260,6 @@ RSpec/VerifiedDoubles: - 'spec/controllers/projects/snippets_controller_spec.rb' - 'spec/controllers/sessions_controller_spec.rb' - 'spec/dependencies/omniauth_saml_spec.rb' - - 'spec/experiments/concerns/project_commit_count_spec.rb' - 'spec/factories/ci/job_artifacts.rb' - 'spec/features/admin/admin_system_info_spec.rb' - 'spec/features/clusters/create_agent_spec.rb' @@ -580,7 +578,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb' - 'spec/lib/gitlab/graphql/authorize/object_authorization_spec.rb' - 'spec/lib/gitlab/graphql/batch_key_spec.rb' - - 'spec/lib/gitlab/graphql/generic_tracing_spec.rb' - 'spec/lib/gitlab/graphql/lazy_spec.rb' - 'spec/lib/gitlab/graphql/loaders/issuable_loader_spec.rb' - 'spec/lib/gitlab/graphql/present/field_extension_spec.rb' @@ -986,8 +983,6 @@ RSpec/VerifiedDoubles: - 'spec/tooling/danger/project_helper_spec.rb' - 'spec/tooling/lib/tooling/helm3_client_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' - - 'spec/tooling/rspec_flaky/example_spec.rb' - - 'spec/tooling/rspec_flaky/listener_spec.rb' - 'spec/uploaders/file_uploader_spec.rb' - 'spec/uploaders/object_storage_spec.rb' - 'spec/uploaders/personal_file_uploader_spec.rb' diff --git a/.rubocop_todo/search/namespaced_class.yml b/.rubocop_todo/search/namespaced_class.yml index ba2dbafb3c7..53dae651959 100644 --- a/.rubocop_todo/search/namespaced_class.yml +++ b/.rubocop_todo/search/namespaced_class.yml @@ -26,6 +26,7 @@ Search/NamespacedClass: - 'ee/app/models/concerns/elastic/projects_search.rb' - 'ee/app/models/concerns/elastic/repositories_search.rb' - 'ee/app/models/concerns/elastic/snippets_search.rb' + - 'ee/app/models/concerns/elastic/update_associated_epics_on_date_change.rb' - 'ee/app/models/concerns/elastic/wiki_repositories_search.rb' - 'ee/app/models/concerns/elasticsearch_indexed_container.rb' - 'ee/app/models/concerns/zoekt/searchable_repository.rb' @@ -80,6 +81,7 @@ Search/NamespacedClass: - 'ee/lib/api/elasticsearch_indexed_namespaces.rb' - 'ee/lib/ee/api/helpers/search_helpers.rb' - 'ee/lib/ee/gitlab/group_search_results.rb' + - 'ee/lib/ee/gitlab/search/found_wiki_page.rb' - 'ee/lib/ee/gitlab/search/parsed_query.rb' - 'ee/lib/ee/gitlab/search_context.rb' - 'ee/lib/ee/gitlab/search_results.rb' @@ -93,6 +95,9 @@ Search/NamespacedClass: - 'ee/lib/elastic/latest/config.rb' - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - 'ee/lib/elastic/latest/document_should_be_deleted_from_index_error.rb' + - 'ee/lib/elastic/latest/epic_class_proxy.rb' + - 'ee/lib/elastic/latest/epic_config.rb' + - 'ee/lib/elastic/latest/epic_instance_proxy.rb' - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/elastic/latest/git_instance_proxy.rb' - 'ee/lib/elastic/latest/issue_class_proxy.rb' @@ -108,8 +113,6 @@ Search/NamespacedClass: - 'ee/lib/elastic/latest/note_instance_proxy.rb' - 'ee/lib/elastic/latest/project_class_proxy.rb' - 'ee/lib/elastic/latest/project_instance_proxy.rb' - - 'ee/lib/elastic/latest/project_wiki_class_proxy.rb' - - 'ee/lib/elastic/latest/project_wiki_instance_proxy.rb' - 'ee/lib/elastic/latest/query_context.rb' - 'ee/lib/elastic/latest/repository_class_proxy.rb' - 'ee/lib/elastic/latest/repository_instance_proxy.rb' @@ -123,6 +126,7 @@ Search/NamespacedClass: - 'ee/lib/elastic/latest/user_config.rb' - 'ee/lib/elastic/latest/user_instance_proxy.rb' - 'ee/lib/elastic/latest/wiki_config.rb' + - 'ee/lib/elastic/latest/project_config.rb' - 'ee/lib/elastic/metrics_update_service.rb' - 'ee/lib/elastic/migration.rb' - 'ee/lib/elastic/multi_version_class_proxy.rb' @@ -132,6 +136,8 @@ Search/NamespacedClass: - 'ee/lib/elastic/v12p1/application_class_proxy.rb' - 'ee/lib/elastic/v12p1/application_instance_proxy.rb' - 'ee/lib/elastic/v12p1/config.rb' + - 'ee/lib/elastic/v12p1/epic_class_proxy.rb' + - 'ee/lib/elastic/v12p1/epic_instance_proxy.rb' - 'ee/lib/elastic/v12p1/issue_class_proxy.rb' - 'ee/lib/elastic/v12p1/issue_instance_proxy.rb' - 'ee/lib/elastic/v12p1/merge_request_class_proxy.rb' @@ -142,8 +148,6 @@ Search/NamespacedClass: - 'ee/lib/elastic/v12p1/note_instance_proxy.rb' - 'ee/lib/elastic/v12p1/project_class_proxy.rb' - 'ee/lib/elastic/v12p1/project_instance_proxy.rb' - - 'ee/lib/elastic/v12p1/project_wiki_class_proxy.rb' - - 'ee/lib/elastic/v12p1/project_wiki_instance_proxy.rb' - 'ee/lib/elastic/v12p1/repository_class_proxy.rb' - 'ee/lib/elastic/v12p1/repository_instance_proxy.rb' - 'ee/lib/elastic/v12p1/routing.rb' diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml deleted file mode 100644 index 554dc64c39c..00000000000 --- a/.rubocop_todo/style/bare_percent_literals.yml +++ /dev/null @@ -1,87 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/BarePercentLiterals: - Exclude: - - 'ee/spec/features/projects/environments/environments_spec.rb' - - 'ee/spec/helpers/subscriptions_helper_spec.rb' - - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - - 'ee/spec/lib/gitlab/status_page/filter/image_filter_spec.rb' - - 'ee/spec/requests/api/ci/jobs_spec.rb' - - 'ee/spec/services/geo/container_repository_sync_spec.rb' - - 'qa/qa/ee/page/dashboard/projects.rb' - - 'qa/qa/ee/page/group/settings/general.rb' - - 'qa/qa/ee/page/project/issue/show.rb' - - 'qa/qa/ee/page/project/job/show.rb' - - 'qa/qa/ee/page/project/packages/index.rb' - - 'qa/qa/ee/page/project/pipeline/show.rb' - - 'qa/qa/ee/page/project/show.rb' - - 'qa/qa/ee/page/project/snippet/index.rb' - - 'qa/qa/ee/page/project/wiki/show.rb' - - 'qa/qa/page/element.rb' - - 'qa/qa/page/file/form.rb' - - 'qa/qa/page/project/web_ide/edit.rb' - - 'qa/qa/resource/events/project.rb' - - 'qa/qa/resource/personal_access_token_cache.rb' - - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - - 'qa/spec/runtime/feature_spec.rb' - - 'spec/controllers/import/fogbugz_controller_spec.rb' - - 'spec/controllers/projects/artifacts_controller_spec.rb' - - 'spec/controllers/projects/design_management/designs/raw_images_controller_spec.rb' - - 'spec/controllers/projects/design_management/designs/resized_image_controller_spec.rb' - - 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb' - - 'spec/features/projects/artifacts/user_downloads_artifacts_spec.rb' - - 'spec/features/projects/badges/coverage_spec.rb' - - 'spec/features/projects/badges/pipeline_badge_spec.rb' - - 'spec/features/projects/issuable_templates_spec.rb' - - 'spec/features/projects/jobs_spec.rb' - - 'spec/features/projects/pipelines/pipeline_spec.rb' - - 'spec/features/projects/pipelines/pipelines_spec.rb' - - 'spec/features/uploads/user_uploads_avatar_to_group_spec.rb' - - 'spec/features/uploads/user_uploads_avatar_to_profile_spec.rb' - - 'spec/graphql/resolvers/echo_resolver_spec.rb' - - 'spec/helpers/markup_helper_spec.rb' - - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - - 'spec/lib/banzai/filter/external_link_filter_spec.rb' - - 'spec/lib/banzai/filter/image_link_filter_spec.rb' - - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/milestone_reference_filter_spec.rb' - - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - - 'spec/lib/banzai/reference_parser/issue_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' - - 'spec/lib/gitlab/diff/highlight_spec.rb' - - 'spec/lib/gitlab/error_tracking/stack_trace_highlight_decorator_spec.rb' - - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb' - - 'spec/lib/gitlab/highlight_spec.rb' - - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' - - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' - - 'spec/lib/gitlab/reference_extractor_spec.rb' - - 'spec/lib/gitlab/url_sanitizer_spec.rb' - - 'spec/mailers/emails/releases_spec.rb' - - 'spec/mailers/emails/service_desk_spec.rb' - - 'spec/models/deployment_spec.rb' - - 'spec/models/incident_management/timeline_event_spec.rb' - - 'spec/models/integrations/drone_ci_spec.rb' - - 'spec/models/integrations/teamcity_spec.rb' - - 'spec/models/project_label_spec.rb' - - 'spec/presenters/snippet_blob_presenter_spec.rb' - - 'spec/requests/api/ci/job_artifacts_spec.rb' - - 'spec/requests/api/deployments_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/destroy_spec.rb' - - 'spec/requests/api/graphql/project/incident_management/timeline_events_spec.rb' - - 'spec/requests/projects/packages/package_files_controller_spec.rb' - - 'spec/rubocop/cop/gitlab/mark_used_feature_flags_spec.rb' - - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb' - - 'spec/support/banzai/reference_filter_shared_examples.rb' - - 'spec/support/helpers/graphql_helpers.rb' - - 'spec/support/shared_examples/controllers/repository_lfs_file_load_shared_examples.rb' - - 'spec/support/shared_examples/features/resolving_discussions_in_issues_shared_examples.rb' - - 'spec/support/shared_examples/graphql/label_fields.rb' - - 'spec/support/shared_examples/lib/banzai/filters/sanitization_filter_shared_examples.rb' - - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - - 'spec/views/layouts/_head.html.haml_spec.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 184e0d926d5..723a3adf412 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -7,12 +7,10 @@ Style/EmptyMethod: - 'app/controllers/admin/deploy_keys_controller.rb' - 'app/controllers/admin/identities_controller.rb' - 'app/controllers/admin/labels_controller.rb' - - 'app/controllers/admin/runners_controller.rb' - 'app/controllers/admin/topics_controller.rb' - 'app/controllers/admin/usage_trends_controller.rb' - 'app/controllers/concerns/boards_actions.rb' - 'app/controllers/groups/milestones_controller.rb' - - 'app/controllers/groups/runners_controller.rb' - 'app/controllers/groups/settings/applications_controller.rb' - 'app/controllers/groups/settings/ci_cd_controller.rb' - 'app/controllers/groups/settings/packages_and_registries_controller.rb' @@ -40,7 +38,6 @@ Style/EmptyMethod: - 'app/controllers/projects/mattermosts_controller.rb' - 'app/controllers/projects/pages_domains_controller.rb' - 'app/controllers/projects/pipeline_schedules_controller.rb' - - 'app/controllers/projects/runners_controller.rb' - 'app/controllers/projects/settings/integrations_controller.rb' - 'app/controllers/projects/settings/packages_and_registries_controller.rb' - 'app/controllers/projects/terraform_controller.rb' @@ -94,7 +91,6 @@ Style/EmptyMethod: - 'ee/app/controllers/projects/security/dast_scanner_profiles_controller.rb' - 'ee/app/controllers/projects/security/dast_site_profiles_controller.rb' - 'ee/app/controllers/projects/security/sast_configuration_controller.rb' - - 'ee/app/controllers/subscriptions/groups_controller.rb' - 'ee/app/models/ee/epic.rb' - 'ee/app/services/feature_flag_issues/destroy_service.rb' - 'ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 9d202dcd7fb..a45c6b39c25 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -170,7 +170,6 @@ Style/FormatString: - 'ee/app/controllers/groups/saml_group_links_controller.rb' - 'ee/app/controllers/groups/sso_controller.rb' - 'ee/app/controllers/projects/requirements_management/requirements_controller.rb' - - 'ee/app/controllers/subscriptions/groups_controller.rb' - 'ee/app/helpers/admin/emails_helper.rb' - 'ee/app/helpers/billing_plans_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' @@ -237,7 +236,6 @@ Style/FormatString: - 'ee/lib/gitlab/licenses/submit_license_usage_data_banner.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - 'ee/lib/gitlab/vulnerabilities/container_scanning_vulnerability.rb' - - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 8613e240d9c..64568649287 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -105,7 +105,6 @@ Style/GuardClause: - 'app/models/diff_viewer/base.rb' - 'app/models/environment.rb' - 'app/models/error_tracking/project_error_tracking_setting.rb' - - 'app/models/external_pull_request.rb' - 'app/models/generic_commit_status.rb' - 'app/models/grafana_integration.rb' - 'app/models/integrations/base_issue_tracker.rb' @@ -373,7 +372,6 @@ Style/GuardClause: - 'ee/app/services/iterations/delete_service.rb' - 'ee/app/services/merge_trains/check_status_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - - 'ee/app/services/namespaces/storage/email_notification_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/override_uuids_service.rb' - 'ee/app/services/timebox_report_service.rb' @@ -641,5 +639,3 @@ Style/GuardClause: - 'tooling/lib/tooling/helm3_client.rb' - 'tooling/lib/tooling/image.rb' - 'tooling/lib/tooling/kubernetes_client.rb' - - 'tooling/rspec_flaky/flaky_example.rb' - - 'tooling/rspec_flaky/listener.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 2ca9b22f0ad..a1f516a8abe 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -155,7 +155,6 @@ Style/IfUnlessModifier: - 'app/models/diff_viewer/base.rb' - 'app/models/environment.rb' - 'app/models/error_tracking/project_error_tracking_setting.rb' - - 'app/models/external_pull_request.rb' - 'app/models/generic_commit_status.rb' - 'app/models/grafana_integration.rb' - 'app/models/group.rb' @@ -1075,5 +1074,3 @@ Style/IfUnlessModifier: - 'tooling/lib/tooling/find_codeowners.rb' - 'tooling/lib/tooling/image.rb' - 'tooling/lib/tooling/test_map_packer.rb' - - 'tooling/rspec_flaky/flaky_example.rb' - - 'tooling/rspec_flaky/flaky_examples_collection.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 2e03bbf4557..bb29652fe96 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -843,7 +843,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/log_limited_array_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/webpack/graphql_known_operations_spec.rb' - 'spec/lib/gitlab/wiki_pages/front_matter_parser_spec.rb' - 'spec/lib/object_storage/config_spec.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml index c2ff275db69..0877c752827 100644 --- a/.rubocop_todo/style/redundant_freeze.yml +++ b/.rubocop_todo/style/redundant_freeze.yml @@ -212,24 +212,3 @@ Style/RedundantFreeze: - 'lib/gitlab/zoom_link_extractor.rb' - 'lib/sbom/package_url/argument_validator.rb' - 'lib/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences.rake' - - 'qa/qa/support/parallel_pipeline_jobs.rb' - - 'qa/qa/tools/ci/qa_changes.rb' - - 'rubocop/cop/gitlab/doc_url.rb' - - 'rubocop/cop/gitlab/finder_with_find_by.rb' - - 'rubocop/cop/inject_enterprise_edition_module.rb' - - 'rubocop/cop/project_path_helper.rb' - - 'rubocop/cop/qa/selector_usage.rb' - - 'scripts/lint-docs-blueprints.rb' - - 'scripts/qa/testcases-check' - - 'scripts/validate_migration_timestamps' - - 'spec/contracts/provider/helpers/contract_source_helper.rb' - - 'spec/initializers/secret_token_spec.rb' - - 'spec/support/helpers/next_found_instance_of.rb' - - 'spec/support/helpers/require_migration.rb' - - 'spec/support/matchers/exceed_query_limit.rb' - - 'tooling/danger/config_files.rb' - - 'tooling/danger/customer_success.rb' - - 'tooling/danger/datateam.rb' - - 'tooling/danger/stable_branch.rb' - - 'tooling/lib/tooling/kubernetes_client.rb' - - 'tooling/lib/tooling/mappings/view_to_js_mappings.rb' diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml index a618632f552..27cd954f506 100644 --- a/.rubocop_todo/style/redundant_interpolation.yml +++ b/.rubocop_todo/style/redundant_interpolation.yml @@ -35,4 +35,3 @@ Style/RedundantInterpolation: - 'qa/qa/tools/generate_perf_testdata.rb' - 'scripts/perf/gc/print_gc_stats.rb' - 'scripts/qa/testcases-check' - - 'tooling/rspec_flaky/flaky_example.rb' diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml new file mode 100644 index 00000000000..540dcfa3ca7 --- /dev/null +++ b/.rubocop_todo/style/redundant_parentheses.yml @@ -0,0 +1,9 @@ +--- +# Cop supports --autocorrect. +Style/RedundantParentheses: + Details: grace period + Exclude: + - 'spec/graphql/types/ci/job_kind_enum_spec.rb' + - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' + - 'spec/requests/verifies_with_email_spec.rb' + - 'spec/services/projects/create_service_spec.rb' diff --git a/.rubocop_todo/style/sole_nested_conditional.yml b/.rubocop_todo/style/sole_nested_conditional.yml index 65cac595cde..975da41a69a 100644 --- a/.rubocop_todo/style/sole_nested_conditional.yml +++ b/.rubocop_todo/style/sole_nested_conditional.yml @@ -8,7 +8,6 @@ Style/SoleNestedConditional: - 'app/controllers/projects/blob_controller.rb' - 'app/helpers/nav_helper.rb' - 'app/models/concerns/cache_markdown_field.rb' - - 'app/models/external_pull_request.rb' - 'app/models/issue.rb' - 'app/models/network/graph.rb' - 'app/models/packages/package.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 4e3b17fe4c0..a83c0f4d943 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -54,7 +54,6 @@ Style/StringConcatenation: - 'ee/lib/gitlab/elastic/search_results.rb' - 'ee/lib/gitlab/geo/git_ssh_proxy.rb' - 'ee/lib/omni_auth/strategies/kerberos.rb' - - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/lib/tasks/gitlab/license.rake' - 'ee/spec/features/boards/boards_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' @@ -212,7 +211,6 @@ Style/StringConcatenation: - 'spec/lib/gitlab/themes_spec.rb' - 'spec/lib/gitlab/throttle_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/visibility_level_spec.rb' - 'spec/lib/gitlab/wiki_pages/front_matter_parser_spec.rb' - 'spec/lib/gitlab/workhorse_spec.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index ceb6a922270..30a649cb4fa 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -18,7 +18,6 @@ Style/StringLiteralsInInterpolation: - 'ee/app/models/license.rb' - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/lib/ee/api/helpers/issues_helpers.rb' - - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' - 'ee/spec/lib/gitlab/expiring_subscription_message_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index 0e4602f9f31..67229a8b704 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -241,4 +241,3 @@ Style/SymbolProc: - 'spec/views/layouts/_published_experiments.html.haml_spec.rb' - 'spec/workers/snippets/schedule_bulk_repository_shard_moves_worker_spec.rb' - 'tooling/lib/tooling/test_map_generator.rb' - - 'tooling/rspec_flaky/flaky_examples_collection.rb' |