diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-20 12:40:42 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-20 12:40:42 +0300 |
| commit | ee664acb356f8123f4f6b00b73c1e1cf0866c7fb (patch) | |
| tree | f8479f94a28f66654c6a4f6fb99bad6b4e86a40e /.rubocop_todo | |
| parent | 62f7d5c5b69180e82ae8196b7b429eeffc8e7b4f (diff) | |
Add latest changes from gitlab-org/gitlab@15-5-stable-eev15.5.0-rc42
Diffstat (limited to '.rubocop_todo')
70 files changed, 1252 insertions, 875 deletions
diff --git a/.rubocop_todo/cop/static_translation_definition.yml b/.rubocop_todo/cop/static_translation_definition.yml index 22f5070d07c..ecbee866a6c 100644 --- a/.rubocop_todo/cop/static_translation_definition.yml +++ b/.rubocop_todo/cop/static_translation_definition.yml @@ -1,20 +1,6 @@ --- Cop/StaticTranslationDefinition: Exclude: - - 'app/models/application_setting.rb' - 'app/models/diff_viewer/image.rb' - 'app/models/diff_viewer/rich.rb' - 'app/models/diff_viewer/simple.rb' - - 'app/models/group_group_link.rb' - - 'app/models/jira_import_state.rb' - - 'app/models/member.rb' - - 'app/models/project.rb' - - 'app/models/project_group_link.rb' - - 'app/models/user.rb' - - 'app/models/users/banned_user.rb' - - 'ee/app/models/allowed_email_domain.rb' - - 'ee/app/models/dast/site_profile_secret_variable.rb' - - 'ee/app/models/group_merge_request_approval_setting.rb' - - 'ee/app/models/incident_management/escalation_policy.rb' - - 'ee/app/models/incident_management/escalation_rule.rb' - - 'ee/app/models/vulnerabilities/read.rb' diff --git a/.rubocop_todo/gitlab/no_code_coverage_comment.yml b/.rubocop_todo/gitlab/no_code_coverage_comment.yml new file mode 100644 index 00000000000..0dcee5f32ee --- /dev/null +++ b/.rubocop_todo/gitlab/no_code_coverage_comment.yml @@ -0,0 +1,19 @@ +--- +Gitlab/NoCodeCoverageComment: + Details: grace period + Exclude: + - 'app/models/integration.rb' + - 'app/services/ci/job_artifacts/destroy_batch_service.rb' + - 'app/workers/database/batched_background_migration/single_database_worker.rb' + - 'config/initializers/net_http_response_patch.rb' + - 'ee/app/models/concerns/geo/replicable_model.rb' + - 'ee/lib/gitlab/geo/replicator.rb' + - 'lib/gitlab/auth/o_auth/session.rb' + - 'lib/gitlab/cleanup/personal_access_tokens.rb' + - 'lib/gitlab/cycle_analytics/summary/defaults.rb' + - 'lib/gitlab/database/background_migration/health_status/signals.rb' + - 'lib/gitlab/seeder.rb' + - 'lib/gitlab/webpack/dev_server_middleware.rb' + - 'lib/tasks/dev.rake' + - 'lib/tasks/gems.rake' + - 'lib/tasks/gitlab/db.rake' diff --git a/.rubocop_todo/gitlab/service_response.yml b/.rubocop_todo/gitlab/service_response.yml new file mode 100644 index 00000000000..ccf934e09b3 --- /dev/null +++ b/.rubocop_todo/gitlab/service_response.yml @@ -0,0 +1,84 @@ +--- +Gitlab/ServiceResponse: + Details: grace period + Exclude: + - 'app/services/alert_management/metric_images/upload_service.rb' + - 'app/services/analytics/cycle_analytics/stages/base_service.rb' + - 'app/services/boards/lists/base_update_service.rb' + - 'app/services/branches/delete_service.rb' + - 'app/services/bulk_imports/create_service.rb' + - 'app/services/bulk_imports/export_service.rb' + - 'app/services/ci/build_cancel_service.rb' + - 'app/services/ci/build_erase_service.rb' + - 'app/services/ci/build_unschedule_service.rb' + - 'app/services/ci/prometheus_metrics/observe_histograms_service.rb' + - 'app/services/ci/retry_pipeline_service.rb' + - 'app/services/ci/runners/assign_runner_service.rb' + - 'app/services/ci/runners/register_runner_service.rb' + - 'app/services/ci/runners/set_runner_associated_projects_service.rb' + - 'app/services/concerns/alert_management/responses.rb' + - 'app/services/concerns/services/return_service_responses.rb' + - 'app/services/container_expiration_policies/update_service.rb' + - 'app/services/dependency_proxy/group_settings/update_service.rb' + - 'app/services/dependency_proxy/image_ttl_group_policies/update_service.rb' + - 'app/services/groups/update_statistics_service.rb' + - 'app/services/incident_management/pager_duty/create_incident_issue_service.rb' + - 'app/services/incident_management/pager_duty/process_webhook_service.rb' + - 'app/services/issuable/bulk_update_service.rb' + - 'app/services/jira_import/start_import_service.rb' + - 'app/services/namespaces/package_settings/update_service.rb' + - 'app/services/packages/debian/create_distribution_service.rb' + - 'app/services/packages/mark_package_for_destruction_service.rb' + - 'app/services/packages/rubygems/dependency_resolver_service.rb' + - 'app/services/snippets/base_service.rb' + - 'app/services/snippets/bulk_destroy_service.rb' + - 'app/services/snippets/destroy_service.rb' + - 'app/services/snippets/repository_validation_service.rb' + - 'app/services/snippets/update_statistics_service.rb' + - 'app/services/timelogs/base_service.rb' + - 'app/services/work_items/create_and_link_service.rb' + - 'app/services/work_items/create_from_task_service.rb' + - 'app/services/work_items/delete_task_service.rb' + - 'ee/app/services/analytics/cycle_analytics/value_streams/create_service.rb' + - 'ee/app/services/app_sec/dast/profiles/destroy_service.rb' + - 'ee/app/services/app_sec/dast/scanner_profiles/destroy_service.rb' + - 'ee/app/services/app_sec/dast/scanner_profiles/update_service.rb' + - 'ee/app/services/app_sec/dast/site_profiles/destroy_service.rb' + - 'ee/app/services/ee/analytics/cycle_analytics/stages/base_service.rb' + - 'ee/app/services/ee/ci/retry_pipeline_service.rb' + - 'ee/app/services/external_status_checks/create_service.rb' + - 'ee/app/services/external_status_checks/destroy_service.rb' + - 'ee/app/services/external_status_checks/dispatch_service.rb' + - 'ee/app/services/external_status_checks/update_service.rb' + - 'ee/app/services/gitlab_subscriptions/create_trial_or_lead_service.rb' + - 'ee/app/services/group_saml/saml_group_links/create_service.rb' + - 'ee/app/services/iterations/cadences/create_iterations_in_advance_service.rb' + - 'ee/app/services/iterations/cadences/create_service.rb' + - 'ee/app/services/iterations/cadences/destroy_service.rb' + - 'ee/app/services/iterations/cadences/update_service.rb' + - 'ee/app/services/iterations/create_service.rb' + - 'ee/app/services/iterations/delete_service.rb' + - 'ee/app/services/iterations/roll_over_issues_service.rb' + - 'ee/app/services/iterations/update_service.rb' + - 'ee/app/services/security/findings/dismiss_service.rb' + - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' + - 'ee/app/services/vulnerability_issue_links/create_service.rb' + - 'ee/app/services/vulnerability_issue_links/delete_service.rb' + - 'ee/spec/graphql/mutations/security/finding/dismiss_spec.rb' + - 'spec/controllers/boards/issues_controller_spec.rb' + - 'spec/controllers/import/bulk_imports_controller_spec.rb' + - 'spec/controllers/import/fogbugz_controller_spec.rb' + - 'spec/controllers/projects/alerting/notifications_controller_spec.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/controllers/projects/prometheus/alerts_controller_spec.rb' + - 'spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb' + - 'spec/requests/api/ci/pipelines_spec.rb' + - 'spec/requests/api/ci/runner/runners_post_spec.rb' + - 'spec/requests/api/group_export_spec.rb' + - 'spec/requests/api/issues/issues_spec.rb' + - 'spec/requests/api/project_export_spec.rb' + - 'spec/requests/api/project_import_spec.rb' + - 'spec/requests/projects/incident_management/pagerduty_incidents_spec.rb' + - 'spec/services/bulk_imports/export_service_spec.rb' + - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index bd4cd386153..195f3fee98e 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -854,7 +854,6 @@ Layout/ArgumentAlignment: - 'spec/rubocop/cop/rspec/be_success_matcher_spec.rb' - 'spec/serializers/feature_flag_entity_spec.rb' - 'spec/serializers/feature_flag_serializer_spec.rb' - - 'spec/serializers/pipeline_serializer_spec.rb' - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'spec/services/award_emojis/destroy_service_spec.rb' - 'spec/services/bulk_update_integration_service_spec.rb' diff --git a/.rubocop_todo/layout/closing_parenthesis_indentation.yml b/.rubocop_todo/layout/closing_parenthesis_indentation.yml new file mode 100644 index 00000000000..79397e92312 --- /dev/null +++ b/.rubocop_todo/layout/closing_parenthesis_indentation.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Layout/ClosingParenthesisIndentation: + Exclude: + - 'app/presenters/project_presenter.rb' + - 'spec/requests/api/internal/base_spec.rb' diff --git a/.rubocop_todo/layout/empty_line_between_defs.yml b/.rubocop_todo/layout/empty_line_between_defs.yml new file mode 100644 index 00000000000..ba69fc4c51b --- /dev/null +++ b/.rubocop_todo/layout/empty_line_between_defs.yml @@ -0,0 +1,8 @@ +--- +# Cop supports --auto-correct. +Layout/EmptyLineBetweenDefs: + Exclude: + - 'db/post_migrate/20220202105733_delete_service_template_records.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' + - 'lib/gitlab/import_export/remote_stream_upload.rb' + - 'lib/gitlab/redis/multi_store.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index 5207d493044..cbe806fc16f 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -1,203 +1,14 @@ --- # Cop supports --auto-correct. Layout/FirstArrayElementIndentation: + Details: grace period Exclude: - - 'lib/gitlab/email/message/in_product_marketing/trial.rb' - - 'lib/gitlab/email/message/in_product_marketing/verify.rb' - - 'lib/gitlab/import_export/base/relation_factory.rb' - - 'lib/gitlab/import_export/json/streaming_serializer.rb' - - 'lib/gitlab/kroki.rb' - - 'lib/gitlab/object_hierarchy.rb' - - 'lib/gitlab/pagination/keyset/simple_order_builder.rb' - - 'lib/gitlab/project_authorizations.rb' - - 'lib/gitlab/usage_data.rb' - - 'lib/system_check/app/authorized_keys_permission_check.rb' - - 'qa/qa/resource/protected_branch.rb' - - 'qa/qa/specs/features/api/1_manage/group_access_token_spec.rb' - - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/automatic_failover_and_recovery_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/changing_repository_storage_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/gitaly_mtls_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_dataloss_spec.rb' - - 'qa/qa/specs/features/api/3_create/repository/commit_to_templated_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/2_plan/issue/custom_issue_template_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/merge_request/cherry_pick/cherry_pick_commit_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_via_template_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/branch_with_unusual_name_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_new_directory_in_web_ide_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/helm_registry_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_project_level_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven_gradle_repository_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/elasticsearch_api_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/main_index/blob_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/nightly_elasticsearch_test_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_with_protected_branch_and_squashed_commits_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' - - 'spec/controllers/concerns/send_file_upload_spec.rb' - - 'spec/graphql/types/packages/tag_type_spec.rb' - - 'spec/helpers/application_settings_helper_spec.rb' - - 'spec/helpers/commits_helper_spec.rb' - - 'spec/helpers/issuables_description_templates_helper_spec.rb' - - 'spec/helpers/listbox_helper_spec.rb' - - 'spec/helpers/users_helper_spec.rb' - - 'spec/lib/api/helpers/merge_requests_helpers_spec.rb' - - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' - - 'spec/lib/csv_builders/stream_spec.rb' - - 'spec/lib/expand_variables_spec.rb' - - 'spec/lib/gitlab/analytics/usage_trends/workers_argument_builder_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_integrations_type_new_spec.rb' - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/ci/ansi2json_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/product/parallel_spec.rb' - - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' - - 'spec/lib/gitlab/ci/config/external/file/project_spec.rb' - - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' - - 'spec/lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - - 'spec/lib/gitlab/ci/reports/codequality_reports_comparer_spec.rb' - - 'spec/lib/gitlab/ci/reports/codequality_reports_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder/group_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder/project_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder_spec.rb' - - 'spec/lib/gitlab/ci/variables/collection/sort_spec.rb' - - 'spec/lib/gitlab/ci/yaml_processor/result_spec.rb' - - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - - 'spec/lib/gitlab/conflict/file_spec.rb' - - 'spec/lib/gitlab/database/each_database_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sticking_spec.rb' - - 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb' - - 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb' - - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - - 'spec/lib/gitlab/database/partitioning/time_partition_spec.rb' - - 'spec/lib/gitlab/database/partitioning_spec.rb' - - 'spec/lib/gitlab/database/similarity_score_spec.rb' - - 'spec/lib/gitlab/diff/char_diff_spec.rb' - - 'spec/lib/gitlab/diff/file_collection_sorter_spec.rb' - - 'spec/lib/gitlab/error_tracking/stack_trace_highlight_decorator_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/gitaly_client/blob_service_spec.rb' - - 'spec/lib/gitlab/github_import/importer/diff_notes_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb' - - 'spec/lib/gitlab/github_import/importer/lfs_objects_importer_spec.rb' - - 'spec/lib/gitlab/github_import/importer/notes_importer_spec.rb' - - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' - - 'spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb' - - 'spec/lib/gitlab/hook_data/release_builder_spec.rb' - - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - - 'spec/lib/gitlab/kubernetes/rollout_instances_spec.rb' - - 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/column_order_definition_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/strategies/order_values_loader_strategy_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' - - 'spec/lib/gitlab/project_transfer_spec.rb' - - 'spec/lib/gitlab/prometheus_client_spec.rb' - - 'spec/lib/gitlab/push_options_spec.rb' - - 'spec/lib/gitlab/rack_attack/request_spec.rb' - - 'spec/lib/gitlab/search/abuse_detection_spec.rb' - 'spec/lib/gitlab/search/found_blob_spec.rb' - - 'spec/lib/gitlab/serializer/ci/variables_spec.rb' - - 'spec/lib/gitlab/sidekiq_config_spec.rb' - - 'spec/lib/gitlab/ssh_public_key_spec.rb' - - 'spec/lib/gitlab/usage_data/topology_spec.rb' - - 'spec/lib/gitlab/usage_data_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - - 'spec/lib/gitlab/webpack/manifest_spec.rb' - - 'spec/lib/google_api/cloud_platform/client_spec.rb' - - 'spec/lib/peek/views/bullet_detailed_spec.rb' - - 'spec/lib/system_check/incoming_email_check_spec.rb' - - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - - 'spec/migrations/add_premium_and_ultimate_plan_limits_spec.rb' - - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb' - - 'spec/migrations/slice_merge_request_diff_commit_migrations_spec.rb' - - 'spec/models/analytics/cycle_analytics/project_stage_spec.rb' - - 'spec/models/application_setting_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/build_trace_spec.rb' - - 'spec/models/ci/daily_build_group_report_result_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci/runner_version_spec.rb' - - 'spec/models/ci/unit_test_spec.rb' - - 'spec/models/clusters/applications/cert_manager_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/commit_collection_spec.rb' - - 'spec/models/compare_spec.rb' - - 'spec/models/concerns/id_in_ordered_spec.rb' - - 'spec/models/concerns/noteable_spec.rb' - - 'spec/models/diff_note_spec.rb' - - 'spec/models/discussion_spec.rb' - - 'spec/models/group_group_link_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/integration_spec.rb' - - 'spec/models/integrations/chat_message/issue_message_spec.rb' - - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/label_note_spec.rb' - - 'spec/models/merge_request/cleanup_schedule_spec.rb' - - 'spec/models/merge_request_diff_spec.rb' - - 'spec/models/merge_request_spec.rb' - - 'spec/models/operations/feature_flags/strategy_spec.rb' - - 'spec/models/project_group_link_spec.rb' - 'spec/models/repository_spec.rb' - - 'spec/models/user_preference_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/models/wiki_directory_spec.rb' - - 'spec/policies/concerns/crud_policy_helpers_spec.rb' - - 'spec/presenters/ci/build_runner_presenter_spec.rb' - - 'spec/requests/api/ci/jobs_spec.rb' - - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - - 'spec/requests/api/ci/runners_spec.rb' - - 'spec/requests/api/deploy_tokens_spec.rb' - - 'spec/requests/api/graphql/ci/config_spec.rb' - - 'spec/requests/api/graphql/ci/jobs_spec.rb' - - 'spec/requests/api/graphql/mutations/uploads/delete_spec.rb' - - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' - - 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb' - - 'spec/requests/api/graphql/project/milestones_spec.rb' - - 'spec/requests/api/graphql/usage_trends_measurements_spec.rb' - - 'spec/requests/api/graphql/work_item_spec.rb' - - 'spec/requests/api/issues/post_projects_issues_spec.rb' - - 'spec/requests/api/issues/put_projects_issues_spec.rb' - - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/task_completion_status_spec.rb' - - 'spec/requests/projects/ci/promeheus_metrics/histograms_controller_spec.rb' - - 'spec/requests/projects/issues_controller_spec.rb' - - 'spec/requests/projects/merge_requests_controller_spec.rb' - - 'spec/serializers/build_trace_entity_spec.rb' - - 'spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb' - - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' - - 'spec/services/award_emojis/copy_service_spec.rb' - - 'spec/services/bulk_update_integration_service_spec.rb' - - 'spec/services/ci/compare_test_reports_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/rules_spec.rb' - - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - - 'spec/services/design_management/move_designs_service_spec.rb' - - 'spec/services/git/tag_hooks_service_spec.rb' - - 'spec/services/google_cloud/setup_cloudsql_instance_service_spec.rb' - - 'spec/services/import/gitlab_projects/create_project_service_spec.rb' - - 'spec/services/jira_connect/sync_service_spec.rb' - - 'spec/services/merge_requests/link_lfs_objects_service_spec.rb' - - 'spec/services/merge_requests/refresh_service_spec.rb' - - 'spec/services/repositories/changelog_service_spec.rb' - - 'spec/services/resource_events/synthetic_milestone_notes_builder_service_spec.rb' - 'spec/services/security/merge_reports_service_spec.rb' - - 'spec/services/users/destroy_service_spec.rb' - 'spec/simplecov_env.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - 'spec/support/capybara.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 94ad3fde252..50cd90019b6 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -308,7 +308,6 @@ Layout/FirstHashElementIndentation: - 'lib/gitlab/asciidoc/include_processor.rb' - 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb' - 'lib/gitlab/ci/config/entry/processable.rb' - - 'lib/gitlab/config_checker/external_database_checker.rb' - 'lib/gitlab/database/query_analyzers/gitlab_schemas_metrics.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - 'lib/gitlab/github_import/importer/diff_note_importer.rb' @@ -471,7 +470,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - 'spec/lib/gitlab/ci/reports/terraform_reports_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - - 'spec/lib/gitlab/config_checker/external_database_checker_spec.rb' - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' - 'spec/lib/gitlab/data_builder/build_spec.rb' - 'spec/lib/gitlab/data_builder/issuable_spec.rb' @@ -633,7 +631,6 @@ Layout/FirstHashElementIndentation: - 'spec/support_specs/graphql/arguments_spec.rb' - 'spec/support_specs/graphql/field_selection_spec.rb' - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' - 'spec/views/projects/issues/_issue.html.haml_spec.rb' diff --git a/.rubocop_todo/layout/leading_comment_space.yml b/.rubocop_todo/layout/leading_comment_space.yml new file mode 100644 index 00000000000..fda1d4ff30b --- /dev/null +++ b/.rubocop_todo/layout/leading_comment_space.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Layout/LeadingCommentSpace: + Exclude: + - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' + - 'lib/uploaded_file.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 01c83d7ac5d..fe9c0593f7d 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -9,13 +9,11 @@ Layout/LineLength: - 'app/controllers/admin/impersonation_tokens_controller.rb' - 'app/controllers/admin/keys_controller.rb' - 'app/controllers/admin/projects_controller.rb' - - 'app/controllers/admin/runners_controller.rb' - 'app/controllers/admin/sessions_controller.rb' - 'app/controllers/admin/topics_controller.rb' - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/boards/lists_controller.rb' - - 'app/controllers/clusters/clusters_controller.rb' - 'app/controllers/concerns/access_tokens_actions.rb' - 'app/controllers/concerns/analytics/cycle_analytics/stage_actions.rb' - 'app/controllers/concerns/clientside_preview_csp.rb' @@ -27,7 +25,6 @@ Layout/LineLength: - 'app/controllers/concerns/membership_actions.rb' - 'app/controllers/concerns/metrics_dashboard.rb' - 'app/controllers/concerns/notes_actions.rb' - - 'app/controllers/concerns/one_trust_csp.rb' - 'app/controllers/concerns/product_analytics_tracking.rb' - 'app/controllers/concerns/routable_actions.rb' - 'app/controllers/concerns/send_file_upload.rb' @@ -42,7 +39,6 @@ Layout/LineLength: - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' - 'app/controllers/groups/email_campaigns_controller.rb' - 'app/controllers/groups/group_members_controller.rb' - - 'app/controllers/groups/runners_controller.rb' - 'app/controllers/groups/settings/applications_controller.rb' - 'app/controllers/groups/settings/ci_cd_controller.rb' - 'app/controllers/groups/settings/integrations_controller.rb' @@ -59,7 +55,6 @@ Layout/LineLength: - 'app/controllers/import/gitlab_groups_controller.rb' - 'app/controllers/import/gitlab_projects_controller.rb' - 'app/controllers/invites_controller.rb' - - 'app/controllers/jira_connect/application_controller.rb' - 'app/controllers/jira_connect/events_controller.rb' - 'app/controllers/jira_connect/subscriptions_controller.rb' - 'app/controllers/jwt_controller.rb' @@ -84,7 +79,6 @@ Layout/LineLength: - 'app/controllers/projects/forks_controller.rb' - 'app/controllers/projects/google_cloud/gcp_regions_controller.rb' - 'app/controllers/projects/imports_controller.rb' - - 'app/controllers/projects/integrations/shimos_controller.rb' - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/jobs_controller.rb' - 'app/controllers/projects/labels_controller.rb' @@ -97,12 +91,10 @@ Layout/LineLength: - 'app/controllers/projects/notes_controller.rb' - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' - 'app/controllers/projects/pipeline_schedules_controller.rb' - - 'app/controllers/projects/pipelines/tests_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' - 'app/controllers/projects/prometheus/metrics_controller.rb' - 'app/controllers/projects/raw_controller.rb' - 'app/controllers/projects/settings/ci_cd_controller.rb' - - 'app/controllers/projects/settings/operations_controller.rb' - 'app/controllers/projects/settings/repository_controller.rb' - 'app/controllers/projects/templates_controller.rb' - 'app/controllers/projects/tree_controller.rb' @@ -139,7 +131,6 @@ Layout/LineLength: - 'app/finders/security/security_jobs_finder.rb' - 'app/finders/todos_finder.rb' - 'app/finders/user_group_notification_settings_finder.rb' - - 'app/finders/user_recent_events_finder.rb' - 'app/graphql/batch_loaders/merge_request_diff_summary_batch_loader.rb' - 'app/graphql/mutations/alert_management/http_integration/create.rb' - 'app/graphql/mutations/alert_management/http_integration/http_integration_base.rb' @@ -162,7 +153,6 @@ Layout/LineLength: - 'app/graphql/mutations/merge_requests/set_labels.rb' - 'app/graphql/mutations/merge_requests/set_locked.rb' - 'app/graphql/mutations/merge_requests/set_milestone.rb' - - 'app/graphql/mutations/merge_requests/toggle_attention_requested.rb' - 'app/graphql/mutations/metrics/dashboard/annotations/create.rb' - 'app/graphql/mutations/namespace/package_settings/update.rb' - 'app/graphql/mutations/notes/create/note.rb' @@ -175,32 +165,20 @@ Layout/LineLength: - 'app/graphql/mutations/snippets/update.rb' - 'app/graphql/mutations/todos/create.rb' - 'app/graphql/mutations/todos/mark_all_done.rb' - - 'app/graphql/mutations/work_items/create.rb' - - 'app/graphql/mutations/work_items/create_from_task.rb' - - 'app/graphql/mutations/work_items/delete.rb' - - 'app/graphql/mutations/work_items/update.rb' - - 'app/graphql/resolvers/ci/job_token_scope_resolver.rb' - - 'app/graphql/resolvers/ci/runner_jobs_resolver.rb' - - 'app/graphql/resolvers/ci/runner_status_resolver.rb' - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/container_repository_tags_resolver.rb' - - 'app/graphql/resolvers/group_packages_resolver.rb' - - 'app/graphql/resolvers/package_details_resolver.rb' - - 'app/graphql/resolvers/project_jobs_resolver.rb' - 'app/graphql/resolvers/project_merge_requests_resolver.rb' - 'app/graphql/resolvers/projects_resolver.rb' - 'app/graphql/resolvers/user_discussions_count_resolver.rb' - 'app/graphql/types/admin/sidekiq_queues/delete_jobs_response_type.rb' - 'app/graphql/types/alert_management/prometheus_integration_type.rb' - 'app/graphql/types/alert_management/status_enum.rb' - - 'app/graphql/types/base_field.rb' - 'app/graphql/types/boards/board_issuable_input_base_type.rb' - 'app/graphql/types/ci/job_artifact_file_type_enum.rb' - 'app/graphql/types/ci/job_type.rb' - 'app/graphql/types/ci/pipeline_config_source_enum.rb' - 'app/graphql/types/ci/pipeline_type.rb' - - 'app/graphql/types/ci/runner_membership_filter_enum.rb' - 'app/graphql/types/ci/runner_setup_type.rb' - 'app/graphql/types/ci/runner_status_enum.rb' - 'app/graphql/types/ci/runner_type.rb' @@ -234,7 +212,6 @@ Layout/LineLength: - 'app/graphql/types/packages/nuget/dependency_link_metadatum_type.rb' - 'app/graphql/types/packages/package_dependency_link_type.rb' - 'app/graphql/types/packages/package_details_type.rb' - - 'app/graphql/types/packages/package_type.rb' - 'app/graphql/types/packages/package_type_enum.rb' - 'app/graphql/types/packages/pypi/metadatum_type.rb' - 'app/graphql/types/project_type.rb' @@ -272,7 +249,6 @@ Layout/LineLength: - 'app/helpers/ide_helper.rb' - 'app/helpers/import_helper.rb' - 'app/helpers/in_product_marketing_helper.rb' - - 'app/helpers/integrations_helper.rb' - 'app/helpers/invite_members_helper.rb' - 'app/helpers/issuables_helper.rb' - 'app/helpers/jira_connect_helper.rb' @@ -305,7 +281,6 @@ Layout/LineLength: - 'app/helpers/tags_helper.rb' - 'app/helpers/timeboxes_helper.rb' - 'app/helpers/tree_helper.rb' - - 'app/helpers/users/callouts_helper.rb' - 'app/helpers/users_helper.rb' - 'app/helpers/version_check_helper.rb' - 'app/helpers/visibility_level_helper.rb' @@ -328,15 +303,12 @@ Layout/LineLength: - 'app/models/application_setting_implementation.rb' - 'app/models/award_emoji.rb' - 'app/models/blob_viewer/base.rb' - - 'app/models/broadcast_message.rb' - 'app/models/bulk_imports/entity.rb' - 'app/models/ci/build.rb' - 'app/models/ci/job_artifact.rb' - - 'app/models/ci/namespace_mirror.rb' - 'app/models/ci/pipeline.rb' - 'app/models/ci/pipeline_artifact.rb' - 'app/models/ci/runner.rb' - - 'app/models/ci/secure_file.rb' - 'app/models/ci/unit_test.rb' - 'app/models/clusters/agent.rb' - 'app/models/clusters/applications/cert_manager.rb' @@ -365,9 +337,7 @@ Layout/LineLength: - 'app/models/concerns/ignorable_columns.rb' - 'app/models/concerns/iid_routes.rb' - 'app/models/concerns/integrations/has_data_fields.rb' - - 'app/models/concerns/integrations/has_issue_tracker_fields.rb' - 'app/models/concerns/issuable.rb' - - 'app/models/concerns/limitable.rb' - 'app/models/concerns/mentionable/reference_regexes.rb' - 'app/models/concerns/milestoneable.rb' - 'app/models/concerns/noteable.rb' @@ -433,7 +403,6 @@ Layout/LineLength: - 'app/models/integrations/jira.rb' - 'app/models/integrations/mattermost.rb' - 'app/models/integrations/microsoft_teams.rb' - - 'app/models/integrations/mock_ci.rb' - 'app/models/integrations/pipelines_email.rb' - 'app/models/integrations/pivotaltracker.rb' - 'app/models/integrations/prometheus.rb' @@ -459,7 +428,6 @@ Layout/LineLength: - 'app/models/merge_request.rb' - 'app/models/merge_request_assignee.rb' - 'app/models/merge_request_diff.rb' - - 'app/models/merge_request_reviewer.rb' - 'app/models/merge_requests_closing_issues.rb' - 'app/models/metrics/dashboard/annotation.rb' - 'app/models/milestone.rb' @@ -495,9 +463,7 @@ Layout/LineLength: - 'app/models/repository.rb' - 'app/models/serverless/domain.rb' - 'app/models/service_desk_setting.rb' - - 'app/models/snippet.rb' - 'app/models/suggestion.rb' - - 'app/models/terraform/state.rb' - 'app/models/todo.rb' - 'app/models/upload.rb' - 'app/models/user.rb' @@ -519,7 +485,6 @@ Layout/LineLength: - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/packages/composer/packages_presenter.rb' - 'app/presenters/packages/conan/package_presenter.rb' - - 'app/presenters/pages_domain_presenter.rb' - 'app/presenters/project_clusterable_presenter.rb' - 'app/presenters/project_presenter.rb' - 'app/presenters/snippet_blob_presenter.rb' @@ -536,25 +501,18 @@ Layout/LineLength: - 'app/serializers/merge_request_poll_cached_widget_entity.rb' - 'app/serializers/merge_request_poll_widget_entity.rb' - 'app/serializers/merge_request_sidebar_extras_entity.rb' - - 'app/serializers/merge_request_user_entity.rb' - 'app/serializers/merge_request_widget_entity.rb' - 'app/serializers/note_entity.rb' - 'app/serializers/project_note_entity.rb' - - 'app/serializers/prometheus_alert_entity.rb' - 'app/services/application_settings/update_service.rb' - 'app/services/auth/container_registry_authentication_service.rb' - - 'app/services/auto_merge/base_service.rb' - 'app/services/auto_merge/merge_when_pipeline_succeeds_service.rb' - 'app/services/boards/base_items_list_service.rb' - - 'app/services/boards/destroy_service.rb' - 'app/services/boards/issues/create_service.rb' - 'app/services/boards/issues/move_service.rb' - 'app/services/boards/lists/base_create_service.rb' - 'app/services/branches/delete_service.rb' - - 'app/services/bulk_create_integration_service.rb' - - 'app/services/bulk_imports/file_decompression_service.rb' - 'app/services/bulk_imports/uploads_export_service.rb' - - 'app/services/bulk_update_integration_service.rb' - 'app/services/ci/create_pipeline_service.rb' - 'app/services/ci/drop_pipeline_service.rb' - 'app/services/ci/generate_coverage_reports_service.rb' @@ -606,11 +564,8 @@ Layout/LineLength: - 'app/services/git/process_ref_changes_service.rb' - 'app/services/google_cloud/create_service_accounts_service.rb' - 'app/services/google_cloud/generate_pipeline_service.rb' - - 'app/services/google_cloud/service_accounts_service.rb' - 'app/services/groups/create_service.rb' - 'app/services/groups/destroy_service.rb' - - 'app/services/groups/import_export/import_service.rb' - - 'app/services/groups/open_issues_count_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/groups/update_service.rb' - 'app/services/import/bitbucket_server_service.rb' @@ -640,7 +595,6 @@ Layout/LineLength: - 'app/services/lfs/unlock_file_service.rb' - 'app/services/loose_foreign_keys/batch_cleaner_service.rb' - 'app/services/loose_foreign_keys/cleaner_service.rb' - - 'app/services/members/approve_access_request_service.rb' - 'app/services/members/destroy_service.rb' - 'app/services/members/invitation_reminder_email_service.rb' - 'app/services/members/update_service.rb' @@ -649,10 +603,8 @@ Layout/LineLength: - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' - 'app/services/merge_requests/create_from_issue_service.rb' - - 'app/services/merge_requests/create_pipeline_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/merge_service.rb' - - 'app/services/merge_requests/mergeability/run_checks_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' - 'app/services/merge_requests/push_options_handler_service.rb' - 'app/services/merge_requests/refresh_service.rb' @@ -665,7 +617,6 @@ Layout/LineLength: - 'app/services/milestones/destroy_service.rb' - 'app/services/namespace_settings/update_service.rb' - 'app/services/notes/build_service.rb' - - 'app/services/notes/copy_service.rb' - 'app/services/notes/quick_actions_service.rb' - 'app/services/notes/resolve_service.rb' - 'app/services/notification_recipients/builder/default.rb' @@ -687,7 +638,6 @@ Layout/LineLength: - 'app/services/packages/npm/create_package_service.rb' - 'app/services/packages/nuget/search_service.rb' - 'app/services/packages/nuget/update_package_from_metadata_service.rb' - - 'app/services/packages/rubygems/dependency_resolver_service.rb' - 'app/services/pages/migrate_from_legacy_storage_service.rb' - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - 'app/services/personal_access_tokens/create_service.rb' @@ -718,7 +668,6 @@ Layout/LineLength: - 'app/services/repository_archive_clean_up_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - 'app/services/resource_access_tokens/revoke_service.rb' - - 'app/services/resource_events/change_labels_service.rb' - 'app/services/search/global_service.rb' - 'app/services/search_service.rb' - 'app/services/security/ci_configuration/container_scanning_create_service.rb' @@ -727,7 +676,6 @@ Layout/LineLength: - 'app/services/security/ci_configuration/sast_iac_create_service.rb' - 'app/services/security/ci_configuration/sast_parser_service.rb' - 'app/services/security/ci_configuration/secret_detection_create_service.rb' - - 'app/services/service_ping/submit_service.rb' - 'app/services/snippets/count_service.rb' - 'app/services/snippets/create_service.rb' - 'app/services/spam/spam_action_service.rb' @@ -790,7 +738,6 @@ Layout/LineLength: - 'config/application.rb' - 'config/initializers/00_rails_disable_joins.rb' - 'config/initializers/01_secret_token.rb' - - 'config/initializers/0_marginalia.rb' - 'config/initializers/1_settings.rb' - 'config/initializers/5_backend.rb' - 'config/initializers/7_prometheus_metrics.rb' @@ -798,9 +745,7 @@ Layout/LineLength: - 'config/initializers/active_record_force_reconnects.rb' - 'config/initializers/active_record_keyset_pagination.rb' - 'config/initializers/active_record_schema_versions.rb' - - 'config/initializers/active_record_transaction_observer.rb' - 'config/initializers/carrierwave_patch.rb' - - 'config/initializers/content_security_policy.rb' - 'config/initializers/deprecations.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/direct_upload_support.rb' @@ -812,10 +757,8 @@ Layout/LineLength: - 'config/initializers/pages_storage_check.rb' - 'config/initializers/rails_host_authorization.rb' - 'config/initializers/session_store.rb' - - 'config/initializers/sidekiq.rb' - 'config/initializers/validate_database_config.rb' - 'config/initializers/validate_puma.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'config/initializers/zz_metrics.rb' - 'config/object_store_settings.rb' - 'config/routes.rb' @@ -828,7 +771,6 @@ Layout/LineLength: - 'config/routes/uploads.rb' - 'config/routes/user.rb' - 'config/settings.rb' - - 'danger/ce_ee_vue_templates/Dangerfile' - 'danger/ci_config/Dangerfile' - 'danger/documentation/Dangerfile' - 'danger/feature_flag/Dangerfile' @@ -1122,35 +1064,28 @@ Layout/LineLength: - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' - 'ee/app/controllers/concerns/ee/issuable_collections.rb' - 'ee/app/controllers/concerns/group_invite_members.rb' - - 'ee/app/controllers/concerns/insights_actions.rb' - - 'ee/app/controllers/ee/admin/dev_ops_report_controller.rb' - 'ee/app/controllers/ee/admin/users_controller.rb' - 'ee/app/controllers/ee/application_controller.rb' - 'ee/app/controllers/ee/groups/group_members_controller.rb' - 'ee/app/controllers/ee/groups_controller.rb' - 'ee/app/controllers/ee/projects/deploy_tokens_controller.rb' - - 'ee/app/controllers/ee/projects/pipelines_controller.rb' - 'ee/app/controllers/ee/projects/settings/operations_controller.rb' - 'ee/app/controllers/ee/projects/settings/repository_controller.rb' - 'ee/app/controllers/ee/projects_controller.rb' - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' - 'ee/app/controllers/ee/repositories/git_http_controller.rb' - 'ee/app/controllers/ee/repositories/lfs_api_controller.rb' - - 'ee/app/controllers/ee/sessions_controller.rb' - 'ee/app/controllers/groups/analytics/cycle_analytics/stages_controller.rb' - 'ee/app/controllers/groups/analytics/cycle_analytics/summary_controller.rb' - 'ee/app/controllers/groups/analytics/cycle_analytics/value_streams_controller.rb' - - 'ee/app/controllers/groups/analytics/cycle_analytics_controller.rb' - 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb' - 'ee/app/controllers/groups/hooks_controller.rb' - 'ee/app/controllers/groups/ldap_settings_controller.rb' - 'ee/app/controllers/groups/omniauth_callbacks_controller.rb' - 'ee/app/controllers/groups/saml_group_links_controller.rb' - 'ee/app/controllers/groups/sso_controller.rb' - - 'ee/app/controllers/groups/usage_quotas_controller.rb' - 'ee/app/controllers/oauth/geo_auth_controller.rb' - 'ee/app/controllers/operations_controller.rb' - - 'ee/app/controllers/profiles/usage_quotas_controller.rb' - 'ee/app/controllers/projects/audit_events_controller.rb' - 'ee/app/controllers/projects/insights_controller.rb' - 'ee/app/controllers/projects/integrations/zentao/issues_controller.rb' @@ -1160,7 +1095,6 @@ Layout/LineLength: - 'ee/app/controllers/projects/security/policies_controller.rb' - 'ee/app/controllers/projects/security/vulnerabilities/notes_controller.rb' - 'ee/app/controllers/subscriptions_controller.rb' - - 'ee/app/controllers/trial_registrations_controller.rb' - 'ee/app/controllers/trials_controller.rb' - 'ee/app/enums/vulnerabilities/dismissal_reason_enum.rb' - 'ee/app/finders/compliance_management/merge_requests/compliance_violations_finder.rb' @@ -1169,12 +1103,10 @@ Layout/LineLength: - 'ee/app/finders/merge_requests/by_approvers_finder.rb' - 'ee/app/finders/projects/integrations/jira/by_ids_finder.rb' - 'ee/app/finders/projects/integrations/jira/issues_finder.rb' - - 'ee/app/finders/security/findings_finder.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - 'ee/app/graphql/ee/mutations/boards/lists/create.rb' - 'ee/app/graphql/ee/mutations/ci/runner/update.rb' - - 'ee/app/graphql/ee/mutations/issues/create.rb' - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - 'ee/app/graphql/mutations/analytics/devops_adoption/enabled_namespaces/bulk_enable.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' @@ -1194,7 +1126,6 @@ Layout/LineLength: - 'ee/app/graphql/mutations/incident_management/oncall_rotation/create.rb' - 'ee/app/graphql/mutations/incident_management/oncall_rotation/update.rb' - 'ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb' - - 'ee/app/graphql/mutations/iterations/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/security/training_provider_update.rb' - 'ee/app/graphql/mutations/security_policy/assign_security_policy_project.rb' @@ -1209,13 +1140,11 @@ Layout/LineLength: - 'ee/app/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver.rb' - 'ee/app/graphql/resolvers/concerns/resolves_orchestration_policy.rb' - 'ee/app/graphql/resolvers/dora_metrics_resolver.rb' - - 'ee/app/graphql/resolvers/epics_resolver.rb' - 'ee/app/graphql/resolvers/external_issue_resolver.rb' - 'ee/app/graphql/resolvers/incident_management/oncall_rotations_resolver.rb' - 'ee/app/graphql/resolvers/incident_management/oncall_schedule_resolver.rb' - 'ee/app/graphql/resolvers/iterations/cadences_resolver.rb' - 'ee/app/graphql/resolvers/iterations_resolver.rb' - - 'ee/app/graphql/resolvers/network_policy_resolver.rb' - 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb' - 'ee/app/graphql/resolvers/security_report_summary_resolver.rb' - 'ee/app/graphql/resolvers/timebox_report_resolver.rb' @@ -1246,8 +1175,6 @@ Layout/LineLength: - 'ee/app/graphql/types/instance_security_dashboard_type.rb' - 'ee/app/graphql/types/iteration_sort_enum.rb' - 'ee/app/graphql/types/iteration_type.rb' - - 'ee/app/graphql/types/merge_requests/approval_state_type.rb' - - 'ee/app/graphql/types/network_policy_type.rb' - 'ee/app/graphql/types/scanned_resource_type.rb' - 'ee/app/graphql/types/security/training_url_request_status_enum.rb' - 'ee/app/graphql/types/security_orchestration/orchestration_policy_type.rb' @@ -1256,7 +1183,6 @@ Layout/LineLength: - 'ee/app/graphql/types/vulnerability/external_issue_link_external_tracker_enum.rb' - 'ee/app/graphql/types/vulnerability_confidence_enum.rb' - 'ee/app/graphql/types/vulnerability_detail_type.rb' - - 'ee/app/graphql/types/vulnerability_request_type.rb' - 'ee/app/graphql/types/vulnerability_type.rb' - 'ee/app/helpers/admin/emails_helper.rb' - 'ee/app/helpers/admin/ip_restriction_helper.rb' @@ -1264,7 +1190,6 @@ Layout/LineLength: - 'ee/app/helpers/analytics/code_review_helper.rb' - 'ee/app/helpers/billing_plans_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' - - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/button_helper.rb' - 'ee/app/helpers/ee/environments_helper.rb' - 'ee/app/helpers/ee/feature_flags_helper.rb' @@ -1279,7 +1204,6 @@ Layout/LineLength: - 'ee/app/helpers/ee/lock_helper.rb' - 'ee/app/helpers/ee/merge_requests_helper.rb' - 'ee/app/helpers/ee/mirror_helper.rb' - - 'ee/app/helpers/ee/nav/top_nav_helper.rb' - 'ee/app/helpers/ee/notes_helper.rb' - 'ee/app/helpers/ee/personal_access_tokens_helper.rb' - 'ee/app/helpers/ee/profiles_helper.rb' @@ -1300,11 +1224,9 @@ Layout/LineLength: - 'ee/app/helpers/projects/security/dast_profiles_helper.rb' - 'ee/app/helpers/projects/security/discover_helper.rb' - 'ee/app/helpers/push_rules_helper.rb' - - 'ee/app/helpers/security_helper.rb' - 'ee/app/helpers/trial_status_widget_helper.rb' - 'ee/app/helpers/vulnerabilities_helper.rb' - 'ee/app/mailers/ee/emails/profile.rb' - - 'ee/app/mailers/ee/emails/projects.rb' - 'ee/app/mailers/ee/preview/notify_preview.rb' - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' - 'ee/app/models/analytics/cycle_analytics/group_stage.rb' @@ -1346,7 +1268,6 @@ Layout/LineLength: - 'ee/app/models/ee/key.rb' - 'ee/app/models/ee/lfs_object.rb' - 'ee/app/models/ee/list.rb' - - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/merge_request/metrics.rb' - 'ee/app/models/ee/merge_request_diff.rb' - 'ee/app/models/ee/milestone_release.rb' @@ -1455,7 +1376,6 @@ Layout/LineLength: - 'ee/app/services/ee/auth/container_registry_authentication_service.rb' - 'ee/app/services/ee/boards/base_service.rb' - 'ee/app/services/ee/ci/job_artifacts/destroy_batch_service.rb' - - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/services/ee/ci/register_job_service.rb' - 'ee/app/services/ee/ci/retry_pipeline_service.rb' - 'ee/app/services/ee/groups/autocomplete_service.rb' @@ -1469,11 +1389,8 @@ Layout/LineLength: - 'ee/app/services/ee/issuable/common_system_notes_service.rb' - 'ee/app/services/ee/issues/base_service.rb' - 'ee/app/services/ee/issues/clone_service.rb' - - 'ee/app/services/ee/issues/move_service.rb' - - 'ee/app/services/ee/merge_requests/base_service.rb' - 'ee/app/services/ee/merge_requests/merge_base_service.rb' - 'ee/app/services/ee/merge_requests/refresh_service.rb' - - 'ee/app/services/ee/notification_service.rb' - 'ee/app/services/ee/personal_access_tokens/create_service.rb' - 'ee/app/services/ee/personal_access_tokens/revoke_service.rb' - 'ee/app/services/ee/projects/create_from_template_service.rb' @@ -1482,13 +1399,11 @@ Layout/LineLength: - 'ee/app/services/ee/projects/deploy_tokens/destroy_service.rb' - 'ee/app/services/ee/projects/gitlab_projects_import_service.rb' - 'ee/app/services/ee/projects/group_links/create_service.rb' - - 'ee/app/services/ee/projects/transfer_service.rb' - 'ee/app/services/ee/projects/update_service.rb' - 'ee/app/services/ee/protected_branches/api_service.rb' - 'ee/app/services/ee/protected_branches/create_service.rb' - 'ee/app/services/ee/protected_branches/update_service.rb' - 'ee/app/services/ee/resource_access_tokens/create_service.rb' - - 'ee/app/services/ee/resource_events/change_labels_service.rb' - 'ee/app/services/ee/system_note_service.rb' - 'ee/app/services/ee/users/update_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' @@ -1496,7 +1411,6 @@ Layout/LineLength: - 'ee/app/services/epics/issue_promote_service.rb' - 'ee/app/services/epics/update_service.rb' - 'ee/app/services/external_status_checks/create_service.rb' - - 'ee/app/services/external_status_checks/dispatch_service.rb' - 'ee/app/services/geo/blob_upload_service.rb' - 'ee/app/services/geo/event_service.rb' - 'ee/app/services/geo/file_registry_removal_service.rb' @@ -1536,7 +1450,6 @@ Layout/LineLength: - 'ee/app/services/projects/licenses/create_policy_service.rb' - 'ee/app/services/projects/mark_for_deletion_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - - 'ee/app/services/requirements_management/update_requirement_service.rb' - 'ee/app/services/resource_events/change_weight_service.rb' - 'ee/app/services/security/auto_fix_service.rb' - 'ee/app/services/security/dependency_list_service.rb' @@ -1554,7 +1467,6 @@ Layout/LineLength: - 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb' - 'ee/app/services/security/security_orchestration_policies/process_policy_service.rb' - 'ee/app/services/security/security_orchestration_policies/project_create_service.rb' - - 'ee/app/services/security/security_orchestration_policies/rule_schedule_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - 'ee/app/services/security/store_scan_service.rb' - 'ee/app/services/security/track_scan_service.rb' @@ -1563,7 +1475,6 @@ Layout/LineLength: - 'ee/app/services/system_notes/escalations_service.rb' - 'ee/app/services/timebox_report_service.rb' - 'ee/app/services/vulnerabilities/base_service.rb' - - 'ee/app/services/vulnerabilities/confirm_service.rb' - 'ee/app/services/vulnerabilities/dismiss_service.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/resolve_service.rb' @@ -1626,11 +1537,6 @@ Layout/LineLength: - 'ee/db/geo/migrate/20211124000002_add_indexes_to_lfs_object_registry.rb' - 'ee/db/geo/migrate/20211207162157_add_indexes_to_pages_deployment_registry.rb' - 'ee/db/geo/post_migrate/20220202101354_migrate_job_artifact_registry.rb' - - 'ee/elastic/migrate/20210302104500_migrate_notes_to_separate_index.rb' - - 'ee/elastic/migrate/20210421140400_add_new_data_to_merge_requests_documents.rb' - - 'ee/elastic/migrate/20210429154500_migrate_merge_requests_to_separate_index.rb' - - 'ee/elastic/migrate/20210510113500_delete_merge_requests_from_original_index.rb' - - 'ee/elastic/migrate/20210510143200_delete_notes_from_original_index.rb' - 'ee/lib/analytics/devops_adoption/snapshot_calculator.rb' - 'ee/lib/analytics/productivity_analytics_request_params.rb' - 'ee/lib/api/analytics/code_review_analytics.rb' @@ -1645,9 +1551,7 @@ Layout/LineLength: - 'ee/lib/api/group_push_rule.rb' - 'ee/lib/api/group_repository_storage_moves.rb' - 'ee/lib/api/helpers/project_approval_rules_helpers.rb' - - 'ee/lib/api/iterations.rb' - 'ee/lib/api/license.rb' - - 'ee/lib/api/managed_licenses.rb' - 'ee/lib/api/merge_request_approval_rules.rb' - 'ee/lib/api/merge_request_approval_settings.rb' - 'ee/lib/api/project_approval_rules.rb' @@ -1688,7 +1592,6 @@ Layout/LineLength: - 'ee/lib/ee/api/namespaces.rb' - 'ee/lib/ee/api/protected_branches.rb' - 'ee/lib/ee/audit/project_changes_auditor.rb' - - 'ee/lib/ee/audit/protected_branches_changes_auditor.rb' - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/data_collector.rb' @@ -1703,13 +1606,10 @@ Layout/LineLength: - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_namespace_statistics.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_status_column_of_security_scans.rb' - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - - 'ee/lib/ee/gitlab/checks/diff_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/ee/gitlab/ci/config_ee.rb' @@ -1719,7 +1619,6 @@ Layout/LineLength: - 'ee/lib/ee/gitlab/ci/reports/security/reports.rb' - 'ee/lib/ee/gitlab/ci/status/build/manual.rb' - 'ee/lib/ee/gitlab/git_access.rb' - - 'ee/lib/ee/gitlab/graphql/pagination/keyset/order_info.rb' - 'ee/lib/ee/gitlab/import_export/after_export_strategies/custom_template_export_import_strategy.rb' - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' - 'ee/lib/ee/gitlab/project_template.rb' @@ -1741,7 +1640,6 @@ Layout/LineLength: - 'ee/lib/elastic/latest/git_instance_proxy.rb' - 'ee/lib/elastic/latest/issue_class_proxy.rb' - 'ee/lib/elastic/latest/issue_instance_proxy.rb' - - 'ee/lib/elastic/latest/merge_request_class_proxy.rb' - 'ee/lib/elastic/latest/note_class_proxy.rb' - 'ee/lib/elastic/latest/project_class_proxy.rb' - 'ee/lib/elastic/latest/repository_class_proxy.rb' @@ -1758,7 +1656,6 @@ Layout/LineLength: - 'ee/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_removed.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/base_time.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/group/deployment_frequency.rb' - - 'ee/lib/gitlab/analytics/cycle_analytics/summary/lead_time.rb' - 'ee/lib/gitlab/auth/group_saml/response_check.rb' - 'ee/lib/gitlab/auth/group_saml/session_enforcer.rb' - 'ee/lib/gitlab/auth/group_saml/user.rb' @@ -1843,7 +1740,6 @@ Layout/LineLength: - 'ee/spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - 'ee/spec/controllers/projects/dependencies_controller_spec.rb' - - 'ee/spec/controllers/projects/insights_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' - 'ee/spec/controllers/projects/issues_controller_spec.rb' @@ -1862,12 +1758,6 @@ Layout/LineLength: - 'ee/spec/controllers/registrations/welcome_controller_spec.rb' - 'ee/spec/controllers/subscriptions/groups_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - - 'ee/spec/controllers/trials_controller_spec.rb' - - 'ee/spec/elastic/migrate/20210201104800_migrate_notes_to_separate_index_spec.rb' - - 'ee/spec/elastic/migrate/20210421140400_add_new_data_to_merge_requests_documents_spec.rb' - - 'ee/spec/elastic/migrate/20210429154500_migrate_merge_requests_to_separate_index_spec.rb' - - 'ee/spec/elastic/migrate/20210510113500_delete_merge_requests_from_original_index_spec.rb' - - 'ee/spec/elastic/migrate/20210510143200_delete_notes_from_original_index_spec.rb' - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/factories/ci/builds.rb' - 'ee/spec/factories/ci/job_artifacts.rb' @@ -1879,7 +1769,6 @@ Layout/LineLength: - 'ee/spec/factories/geo/container_repository_registry.rb' - 'ee/spec/factories/iterations.rb' - 'ee/spec/factories/namespaces.rb' - - 'ee/spec/factories/requirements_management/requirements.rb' - 'ee/spec/factories/vulnerabilities/exports.rb' - 'ee/spec/factories/vulnerabilities/findings.rb' - 'ee/spec/features/admin/admin_audit_logs_spec.rb' @@ -1898,7 +1787,6 @@ Layout/LineLength: - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/burnup_charts_spec.rb' - - 'ee/spec/features/ci_shared_runner_warnings_spec.rb' - 'ee/spec/features/dashboards/operations_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_spec.rb' - 'ee/spec/features/epics/epic_issues_spec.rb' @@ -1935,7 +1823,6 @@ Layout/LineLength: - 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb' - 'ee/spec/features/issues/form_spec.rb' - 'ee/spec/features/issues/issue_sidebar_spec.rb' - - 'ee/spec/features/issues/user_sees_empty_state_spec.rb' - 'ee/spec/features/labels_hierarchy_spec.rb' - 'ee/spec/features/merge_request/user_approves_spec.rb' - 'ee/spec/features/merge_request/user_approves_with_password_spec.rb' @@ -1950,7 +1837,6 @@ Layout/LineLength: - 'ee/spec/features/merge_trains/user_adds_to_merge_train_when_pipeline_succeeds_spec.rb' - 'ee/spec/features/pending_group_memberships_spec.rb' - 'ee/spec/features/projects/audit_events_spec.rb' - - 'ee/spec/features/projects/custom_projects_template_spec.rb' - 'ee/spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' - 'ee/spec/features/projects/feature_flags/user_updates_feature_flag_spec.rb' - 'ee/spec/features/projects/integrations/prometheus_custom_metrics_spec.rb' @@ -1983,7 +1869,6 @@ Layout/LineLength: - 'ee/spec/finders/analytics/devops_adoption/enabled_namespaces_finder_spec.rb' - 'ee/spec/finders/analytics/devops_adoption/snapshots_finder_spec.rb' - 'ee/spec/finders/audit_event_finder_spec.rb' - - 'ee/spec/finders/billed_users_finder_spec.rb' - 'ee/spec/finders/boards/users_finder_spec.rb' - 'ee/spec/finders/compliance_management/merge_requests/compliance_violations_finder_spec.rb' - 'ee/spec/finders/custom_project_templates_finder_spec.rb' @@ -1992,7 +1877,7 @@ Layout/LineLength: - 'ee/spec/finders/ee/group_members_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - - 'ee/spec/finders/geo/container_repository_registry_finder_spec.rb' + - 'ee/spec/finders/geo/container_repository_legacy_registry_finder_spec.rb' - 'ee/spec/finders/geo/project_registry_finder_spec.rb' - 'ee/spec/finders/geo/project_registry_status_finder_spec.rb' - 'ee/spec/finders/group_projects_finder_spec.rb' @@ -2034,14 +1919,12 @@ Layout/LineLength: - 'ee/spec/graphql/ee/types/board_type_spec.rb' - 'ee/spec/graphql/ee/types/issue_sort_enum_spec.rb' - 'ee/spec/graphql/ee/types/merge_request_type_spec.rb' - - 'ee/spec/graphql/ee/types/mutation_type_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - 'ee/spec/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb' - 'ee/spec/graphql/mutations/dast/profiles/run_spec.rb' - 'ee/spec/graphql/mutations/dast_on_demand_scans/create_spec.rb' - - 'ee/spec/graphql/mutations/dast_scanner_profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_scanner_profiles/update_spec.rb' - 'ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb' - 'ee/spec/graphql/mutations/dast_site_profiles/update_spec.rb' @@ -2079,7 +1962,6 @@ Layout/LineLength: - 'ee/spec/graphql/resolvers/iterations/cadences_resolver_spec.rb' - 'ee/spec/graphql/resolvers/iterations_resolver_spec.rb' - 'ee/spec/graphql/resolvers/network_policy_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - 'ee/spec/graphql/resolvers/pipeline_security_report_findings_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/test_reports_resolver_spec.rb' @@ -2092,7 +1974,6 @@ Layout/LineLength: - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - 'ee/spec/graphql/types/alert_management/payload_alert_field_name_enum_spec.rb' - - 'ee/spec/graphql/types/asset_type_spec.rb' - 'ee/spec/graphql/types/ci/minutes/namespace_monthly_usage_type_spec.rb' - 'ee/spec/graphql/types/dast/profile_schedule_type_spec.rb' - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' @@ -2100,20 +1981,14 @@ Layout/LineLength: - 'ee/spec/graphql/types/epic_sort_enum_spec.rb' - 'ee/spec/graphql/types/incident_management/escalation_rule_input_type_spec.rb' - 'ee/spec/graphql/types/issue_type_spec.rb' - - 'ee/spec/graphql/types/network_policy_type_spec.rb' - 'ee/spec/graphql/types/permission_types/vulnerability_spec.rb' - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' - 'ee/spec/graphql/types/project_type_spec.rb' - 'ee/spec/graphql/types/security_scanner_type_enum_spec.rb' - 'ee/spec/graphql/types/vulnerability_details/file_location_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_evidence_source_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_evidence_supporting_message_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_evidence_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_report_type_enum_spec.rb' - - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_sort_enum_spec.rb' - 'ee/spec/graphql/types/vulnerability_type_spec.rb' - 'ee/spec/helpers/admin/emails_helper_spec.rb' - 'ee/spec/helpers/analytics/code_review_helper_spec.rb' @@ -2128,7 +2003,6 @@ Layout/LineLength: - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/settings_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/issuables_helper_spec.rb' @@ -2139,7 +2013,6 @@ Layout/LineLength: - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/helpers/ee/version_check_helper_spec.rb' @@ -2157,9 +2030,7 @@ Layout/LineLength: - 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' - 'ee/spec/helpers/push_rules_helper_spec.rb' - - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - 'ee/spec/helpers/search_helper_spec.rb' - - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' @@ -2177,7 +2048,6 @@ Layout/LineLength: - 'ee/spec/lib/bulk_imports/projects/pipelines/push_rule_pipeline_spec.rb' - 'ee/spec/lib/compliance_management/merge_request_approval_settings/resolver_spec.rb' - 'ee/spec/lib/container_registry/client_spec.rb' - - 'ee/spec/lib/ee/api/entities/billable_member_spec.rb' - 'ee/spec/lib/ee/api/entities/deployment_extended_spec.rb' - 'ee/spec/lib/ee/api/entities/vulnerability_export_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' @@ -2232,7 +2102,6 @@ Layout/LineLength: - 'ee/spec/lib/ee/sidebars/projects/menus/security_compliance_menu_spec.rb' - 'ee/spec/lib/elastic/latest/config_shared_examples.rb' - 'ee/spec/lib/elastic/latest/custom_language_analyzers_spec.rb' - - 'ee/spec/lib/elastic/latest/git_class_proxy_spec.rb' - 'ee/spec/lib/elastic/multi_version_class_proxy_spec.rb' - 'ee/spec/lib/elastic/multi_version_instance_proxy_spec.rb' - 'ee/spec/lib/gem_extensions/elasticsearch/model/adapter/active_record/records_spec.rb' @@ -2290,7 +2159,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/data_builder/vulnerability_spec.rb' - 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb' - - 'ee/spec/lib/gitlab/elastic/client_spec.rb' - 'ee/spec/lib/gitlab/elastic/group_search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb' - 'ee/spec/lib/gitlab/elastic/project_search_results_spec.rb' @@ -2299,7 +2167,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - 'ee/spec/lib/gitlab/email/message/account_validation_spec.rb' - 'ee/spec/lib/gitlab/expiring_subscription_message_spec.rb' - - 'ee/spec/lib/gitlab/geo/cron_manager_spec.rb' - 'ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb' - 'ee/spec/lib/gitlab/geo/geo_tasks_spec.rb' - 'ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb' @@ -2320,7 +2187,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerabilities/lazy_user_notes_count_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - - 'ee/spec/lib/gitlab/graphql/pagination/keyset/order_info_spec.rb' - 'ee/spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'ee/spec/lib/gitlab/import_export/group/group_and_descendants_repo_restorer_spec.rb' - 'ee/spec/lib/gitlab/insights/finders/issuable_finder_spec.rb' @@ -2396,7 +2262,6 @@ Layout/LineLength: - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' - 'ee/spec/models/ci/pipeline_spec.rb' - - 'ee/spec/models/ci/subscriptions/project_spec.rb' - 'ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb' - 'ee/spec/models/concerns/ee/issuable_spec.rb' - 'ee/spec/models/concerns/ee/noteable_spec.rb' @@ -2428,7 +2293,6 @@ Layout/LineLength: - 'ee/spec/models/ee/audit_event_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'ee/spec/models/ee/ci/pipeline_artifact_spec.rb' - - 'ee/spec/models/ee/ci/runner_spec.rb' - 'ee/spec/models/ee/group_spec.rb' - 'ee/spec/models/ee/incident_management/project_incident_management_setting_spec.rb' - 'ee/spec/models/ee/integrations/jira_spec.rb' @@ -2453,7 +2317,6 @@ Layout/LineLength: - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/geo/container_repository_registry_spec.rb' - 'ee/spec/models/geo/event_log_spec.rb' - - 'ee/spec/models/geo/job_artifact_registry_spec.rb' - 'ee/spec/models/geo/package_file_registry_spec.rb' - 'ee/spec/models/geo/project_registry_spec.rb' - 'ee/spec/models/geo/secondary_usage_data_spec.rb' @@ -2470,7 +2333,6 @@ Layout/LineLength: - 'ee/spec/models/incident_management/oncall_shift_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' - 'ee/spec/models/integrations/chat_message/vulnerability_message_spec.rb' - - 'ee/spec/models/integrations/github_spec.rb' - 'ee/spec/models/issuable_sla_spec.rb' - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/license_spec.rb' @@ -2523,15 +2385,12 @@ Layout/LineLength: - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/ci/build_runner_presenter_spec.rb' - 'ee/spec/presenters/ci/pipeline_presenter_spec.rb' - - 'ee/spec/presenters/ee/issue_presenter_spec.rb' - 'ee/spec/presenters/epic_issue_presenter_spec.rb' - 'ee/spec/presenters/epic_presenter_spec.rb' - 'ee/spec/presenters/group_member_presenter_spec.rb' - 'ee/spec/presenters/merge_request_presenter_spec.rb' - 'ee/spec/presenters/security/scan_presenter_spec.rb' - - 'ee/spec/presenters/vulnerabilities/finding_presenter_spec.rb' - 'ee/spec/presenters/vulnerability_presenter_spec.rb' - - 'ee/spec/replicators/geo/upload_replicator_spec.rb' - 'ee/spec/requests/admin/credentials_controller_spec.rb' - 'ee/spec/requests/admin/geo/replicables_controller_spec.rb' - 'ee/spec/requests/admin/user_permission_exports_controller_spec.rb' @@ -2587,7 +2446,6 @@ Layout/LineLength: - 'ee/spec/requests/api/graphql/mutations/epic_tree/reorder_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/add_issue_spec.rb' - 'ee/spec/requests/api/graphql/mutations/issues/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/issues/set_weight_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/update_spec.rb' @@ -2687,8 +2545,6 @@ Layout/LineLength: - 'ee/spec/serializers/environment_entity_spec.rb' - 'ee/spec/serializers/epic_entity_spec.rb' - 'ee/spec/serializers/fork_namespace_entity_spec.rb' - - 'ee/spec/serializers/integrations/jira_serializers/issue_detail_entity_spec.rb' - - 'ee/spec/serializers/integrations/jira_serializers/issue_entity_spec.rb' - 'ee/spec/serializers/member_entity_spec.rb' - 'ee/spec/serializers/project_mirror_entity_spec.rb' - 'ee/spec/serializers/security/license_policy_entity_spec.rb' @@ -2729,7 +2585,6 @@ Layout/LineLength: - 'ee/spec/services/approval_rules/create_service_spec.rb' - 'ee/spec/services/approval_rules/finalize_service_spec.rb' - 'ee/spec/services/approval_rules/params_filtering_service_spec.rb' - - 'ee/spec/services/arkose/user_verification_service_spec.rb' - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/register_runner_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/release_associate_milestone_audit_event_service_spec.rb' @@ -2768,7 +2623,6 @@ Layout/LineLength: - 'ee/spec/services/ee/groups/import_export/export_service_spec.rb' - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - - 'ee/spec/services/ee/issuable/destroy_service_spec.rb' - 'ee/spec/services/ee/issue_links/create_service_spec.rb' - 'ee/spec/services/ee/issues/clone_service_spec.rb' - 'ee/spec/services/ee/issues/create_from_vulnerability_data_service_spec.rb' @@ -2861,7 +2715,6 @@ Layout/LineLength: - 'ee/spec/services/projects/alerting/notify_service_spec.rb' - 'ee/spec/services/projects/cleanup_service_spec.rb' - 'ee/spec/services/projects/gitlab_projects_import_service_spec.rb' - - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - 'ee/spec/services/projects/import_export/export_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' @@ -2870,7 +2723,6 @@ Layout/LineLength: - 'ee/spec/services/projects/update_service_spec.rb' - 'ee/spec/services/quick_actions/interpret_service_spec.rb' - 'ee/spec/services/requirements_management/export_csv_service_spec.rb' - - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb' - 'ee/spec/services/resource_events/change_weight_service_spec.rb' - 'ee/spec/services/search/global_service_spec.rb' - 'ee/spec/services/search/group_service_spec.rb' @@ -2887,7 +2739,6 @@ Layout/LineLength: - 'ee/spec/services/security/ingestion/tasks/ingest_findings_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_remediations_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerability_flags_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerability_statistics_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' @@ -2917,13 +2768,11 @@ Layout/LineLength: - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/user_permissions/export_service_spec.rb' - - 'ee/spec/services/vulnerabilities/destroy_dismissal_feedback_service_spec.rb' - 'ee/spec/services/vulnerabilities/dismiss_service_spec.rb' - 'ee/spec/services/vulnerabilities/finding_dismiss_service_spec.rb' - 'ee/spec/services/vulnerabilities/historical_statistics/adjustment_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'ee/spec/services/vulnerabilities/revert_to_detected_service_spec.rb' - - 'ee/spec/services/vulnerabilities/starboard_vulnerability_resolve_service_spec.rb' - 'ee/spec/services/vulnerabilities/statistics/adjustment_service_spec.rb' - 'ee/spec/services/vulnerabilities/update_service_spec.rb' - 'ee/spec/services/vulnerability_exports/create_service_spec.rb' @@ -2954,7 +2803,6 @@ Layout/LineLength: - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/projects/license_scanning_report_comparison_shared_examples.rb' - 'ee/spec/support/shared_examples/features/epics_filtered_search_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/over_free_user_limit_shared_examples.rb' - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - 'ee/spec/support/shared_examples/features/sidebar_shared_examples.rb' - 'ee/spec/support/shared_examples/finders/geo/file_registry_finder_shared_examples.rb' @@ -2978,8 +2826,6 @@ Layout/LineLength: - 'ee/spec/support/shared_examples/quick_actions/merge_request/unassign_reviewer_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_recovery_shared_examples.rb' - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/boards/base_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/build_execute_shared_examples.rb' @@ -2987,10 +2833,8 @@ Layout/LineLength: - 'ee/spec/support/shared_examples/services/dast_on_demand_scans_shared_examples.rb' - 'ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/group_saml/saml_provider/base_service_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/issue_epic_shared_examples.rb' - 'ee/spec/support/shared_examples/services/scoped_label_shared_examples.rb' - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/sync_issue_and_requirement_state_shared_examples.rb' - 'ee/spec/support/shared_examples/services/vulnerabilities/calls_vulnerability_statistics_utility_services_in_order.rb' - 'ee/spec/support/shared_examples/views/subscription_shared_examples.rb' - 'ee/spec/tasks/geo/git_rake_spec.rb' @@ -3017,13 +2861,10 @@ Layout/LineLength: - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/project_access_tokens/_project_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/promotions/_promotion_link_project.html.haml_spec.rb' - - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - - 'ee/spec/views/trial_registrations/new.html.haml_spec.rb' - 'ee/spec/workers/active_user_count_threshold_worker_spec.rb' - 'ee/spec/workers/adjourned_group_deletion_worker_spec.rb' - 'ee/spec/workers/adjourned_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/analytics/cycle_analytics/consistency_worker_spec.rb' - - 'ee/spec/workers/analytics/cycle_analytics/incremental_worker_spec.rb' - 'ee/spec/workers/analytics/devops_adoption/create_all_snapshots_worker_spec.rb' - 'ee/spec/workers/analytics/devops_adoption/create_snapshot_worker_spec.rb' - 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb' @@ -3062,8 +2903,6 @@ Layout/LineLength: - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/refresh_license_compliance_checks_worker_spec.rb' - 'ee/spec/workers/repository_import_worker_spec.rb' - - 'ee/spec/workers/scan_security_report_secrets_worker_spec.rb' - - 'ee/spec/workers/security/create_orchestration_policy_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' @@ -3117,7 +2956,6 @@ Layout/LineLength: - 'lib/api/generic_packages.rb' - 'lib/api/go_proxy.rb' - 'lib/api/group_clusters.rb' - - 'lib/api/group_container_repositories.rb' - 'lib/api/group_import.rb' - 'lib/api/group_labels.rb' - 'lib/api/group_packages.rb' @@ -3132,7 +2970,6 @@ Layout/LineLength: - 'lib/api/helpers/file_upload_helpers.rb' - 'lib/api/helpers/groups_helpers.rb' - 'lib/api/helpers/integrations_helpers.rb' - - 'lib/api/helpers/internal_helpers.rb' - 'lib/api/helpers/label_helpers.rb' - 'lib/api/helpers/members_helpers.rb' - 'lib/api/helpers/merge_requests_helpers.rb' @@ -3229,7 +3066,6 @@ Layout/LineLength: - 'lib/container_registry/base_client.rb' - 'lib/declarative_enum.rb' - 'lib/error_tracking/collector/payload_validator.rb' - - 'lib/error_tracking/sentry_client/issue.rb' - 'lib/feature.rb' - 'lib/feature/definition.rb' - 'lib/file_size_validator.rb' @@ -3266,7 +3102,6 @@ Layout/LineLength: - 'lib/gitlab/background_migration/backfill_snippet_repositories.rb' - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/copy_column_using_background_migration_job.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' @@ -3286,7 +3121,6 @@ Layout/LineLength: - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/batch_pop_queueing.rb' - 'lib/gitlab/bitbucket_import/importer.rb' @@ -3342,8 +3176,6 @@ Layout/LineLength: - 'lib/gitlab/composer/version_index.rb' - 'lib/gitlab/config/entry/configurable.rb' - 'lib/gitlab/config/entry/validators.rb' - - 'lib/gitlab/config_checker/external_database_checker.rb' - - 'lib/gitlab/config_checker/puma_rugged_checker.rb' - 'lib/gitlab/conflict/file.rb' - 'lib/gitlab/conflict/file_collection.rb' - 'lib/gitlab/content_security_policy/config_loader.rb' @@ -3351,7 +3183,6 @@ Layout/LineLength: - 'lib/gitlab/current_settings.rb' - 'lib/gitlab/cycle_analytics/summary/deploy.rb' - 'lib/gitlab/cycle_analytics/summary/deployment_frequency.rb' - - 'lib/gitlab/data_builder/push.rb' - 'lib/gitlab/database.rb' - 'lib/gitlab/database/as_with_materialized.rb' - 'lib/gitlab/database/async_indexes/migration_helpers.rb' @@ -3362,7 +3193,6 @@ Layout/LineLength: - 'lib/gitlab/database/batch_counter.rb' - 'lib/gitlab/database/count/reltuples_count_strategy.rb' - 'lib/gitlab/database/gitlab_schema.rb' - - 'lib/gitlab/database/load_balancing/configuration.rb' - 'lib/gitlab/database/load_balancing/host.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/database/migration_helpers/cascading_namespace_settings.rb' @@ -3370,11 +3200,9 @@ Layout/LineLength: - 'lib/gitlab/database/migrations/background_migration_helpers.rb' - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb' - 'lib/gitlab/database/migrations/runner.rb' - - 'lib/gitlab/database/migrations/test_background_runner.rb' - 'lib/gitlab/database/partitioning/detached_partition_dropper.rb' - 'lib/gitlab/database/partitioning/partition_monitoring.rb' - 'lib/gitlab/database/partitioning/replace_table.rb' - - 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb' - 'lib/gitlab/database/partitioning/time_partition.rb' - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' @@ -3385,7 +3213,6 @@ Layout/LineLength: - 'lib/gitlab/database/postgres_partition.rb' - 'lib/gitlab/database/postgres_partitioned_table.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb' - 'lib/gitlab/database/reflection.rb' - 'lib/gitlab/database/reindexing.rb' - 'lib/gitlab/database/reindexing/coordinator.rb' @@ -3406,13 +3233,11 @@ Layout/LineLength: - 'lib/gitlab/diff/formatters/base_formatter.rb' - 'lib/gitlab/diff/highlight_cache.rb' - 'lib/gitlab/diff/parser.rb' - - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - 'lib/gitlab/email/failure_handler.rb' - 'lib/gitlab/email/handler/create_issue_handler.rb' - 'lib/gitlab/email/handler/create_merge_request_handler.rb' - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/in_product_marketing/create.rb' - - 'lib/gitlab/email/message/in_product_marketing/experience.rb' - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - 'lib/gitlab/email/message/in_product_marketing/team.rb' - 'lib/gitlab/email/message/in_product_marketing/trial.rb' @@ -3444,7 +3269,6 @@ Layout/LineLength: - 'lib/gitlab/git_access.rb' - 'lib/gitlab/git_access_project.rb' - 'lib/gitlab/git_access_snippet.rb' - - 'lib/gitlab/git_access_wiki.rb' - 'lib/gitlab/gitaly_client.rb' - 'lib/gitlab/gitaly_client/blob_service.rb' - 'lib/gitlab/gitaly_client/call.rb' @@ -3469,8 +3293,6 @@ Layout/LineLength: - 'lib/gitlab/gpg/invalid_gpg_signature_updater.rb' - 'lib/gitlab/grape_logging/formatters/lograge_with_timestamp.rb' - 'lib/gitlab/grape_logging/loggers/client_env_logger.rb' - - 'lib/gitlab/graphql/pagination/keyset/generic_keyset_pagination.rb' - - 'lib/gitlab/graphql/pagination/keyset/query_builder.rb' - 'lib/gitlab/graphql/timeout.rb' - 'lib/gitlab/group_search_results.rb' - 'lib/gitlab/hashed_storage/migrator.rb' @@ -3518,10 +3340,8 @@ Layout/LineLength: - 'lib/gitlab/metrics/dashboard/stages/custom_metrics_details_inserter.rb' - 'lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter.rb' - 'lib/gitlab/metrics/dashboard/stages/variable_endpoint_inserter.rb' - - 'lib/gitlab/metrics/dashboard/url.rb' - 'lib/gitlab/metrics/dashboard/validator.rb' - 'lib/gitlab/metrics/dashboard/validator/errors.rb' - - 'lib/gitlab/metrics/rails_slis.rb' - 'lib/gitlab/metrics/samplers/action_cable_sampler.rb' - 'lib/gitlab/metrics/samplers/puma_sampler.rb' - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' @@ -3574,7 +3394,6 @@ Layout/LineLength: - 'lib/gitlab/sidekiq_daemon/monitor.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb' - - 'lib/gitlab/sidekiq_middleware/memory_killer.rb' - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' - 'lib/gitlab/sidekiq_middleware/size_limiter/compressor.rb' - 'lib/gitlab/sidekiq_versioning.rb' @@ -3590,7 +3409,6 @@ Layout/LineLength: - 'lib/gitlab/usage/metrics/aggregates/aggregate.rb' - 'lib/gitlab/usage/metrics/aggregates/sources/calculations/intersection.rb' - 'lib/gitlab/usage/metrics/aggregates/sources/postgres_hll.rb' - - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' - 'lib/gitlab/usage/metrics/name_suggestion.rb' - 'lib/gitlab/usage/metrics/names_suggestions/generator.rb' - 'lib/gitlab/usage/service_ping_report.rb' @@ -3618,12 +3436,8 @@ Layout/LineLength: - 'lib/security/ci_configuration/base_build_action.rb' - 'lib/security/ci_configuration/sast_build_action.rb' - 'lib/sidebars/groups/menus/packages_registries_menu.rb' - - 'lib/sidebars/groups/menus/settings_menu.rb' - 'lib/sidebars/menu_item.rb' - - 'lib/sidebars/projects/menus/infrastructure_menu.rb' - - 'lib/sidebars/projects/menus/packages_registries_menu.rb' - 'lib/sidebars/projects/menus/repository_menu.rb' - - 'lib/sidebars/projects/panel.rb' - 'lib/system_check/app/orphaned_group_members_check.rb' - 'lib/system_check/app/redis_version_check.rb' - 'lib/system_check/incoming_email/mail_room_enabled_check.rb' @@ -3640,7 +3454,6 @@ Layout/LineLength: - 'lib/tasks/gitlab/info.rake' - 'lib/tasks/gitlab/packages/events.rake' - 'lib/tasks/gitlab/packages/migrate.rake' - - 'lib/tasks/gitlab/pages.rake' - 'lib/tasks/gitlab/seed/group_seed.rake' - 'lib/tasks/gitlab/shell.rake' - 'lib/tasks/gitlab/sidekiq.rake' @@ -3669,8 +3482,6 @@ Layout/LineLength: - 'qa/qa/git/repository.rb' - 'qa/qa/page/base.rb' - 'qa/qa/page/component/ci_badge_link.rb' - - 'qa/qa/page/component/design_management.rb' - - 'qa/qa/page/component/invite_members_modal.rb' - 'qa/qa/page/component/issuable/sidebar.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/dashboard/snippet/index.rb' @@ -3679,14 +3490,12 @@ Layout/LineLength: - 'qa/qa/page/group/settings/package_registries.rb' - 'qa/qa/page/merge_request/new.rb' - 'qa/qa/page/project/import/repo_by_url.rb' - - 'qa/qa/page/project/issue/index.rb' - 'qa/qa/page/project/registry/show.rb' - 'qa/qa/page/project/settings/protected_branches.rb' - 'qa/qa/page/project/web_ide/edit.rb' - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/file.rb' - 'qa/qa/resource/members.rb' - - 'qa/qa/resource/project.rb' - 'qa/qa/resource/protected_branch.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/repository/push.rb' @@ -3699,28 +3508,19 @@ Layout/LineLength: - 'qa/qa/resource/wiki/group_page.rb' - 'qa/qa/runtime/api/repository_storage_moves.rb' - 'qa/qa/runtime/application_settings.rb' - - 'qa/qa/runtime/browser.rb' - 'qa/qa/runtime/env.rb' - 'qa/qa/runtime/feature.rb' - 'qa/qa/runtime/fixtures.rb' - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/runtime/search.rb' - 'qa/qa/scenario/bootable.rb' - - 'qa/qa/scenario/template.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/service/cluster_provider/k3s.rb' - - 'qa/qa/service/kubernetes_cluster.rb' - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/rate_limits_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - 'qa/qa/specs/features/api/1_manage/users_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/changing_repository_storage_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_connectivity_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_dataloss_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_replication_queue_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_repo_sync_spec.rb' - 'qa/qa/specs/features/api/3_create/integrations/webhook_events_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_labels_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_mwps_spec.rb' @@ -3732,7 +3532,6 @@ Layout/LineLength: - 'qa/qa/specs/features/api/4_verify/cancel_pipeline_when_block_user_spec.rb' - 'qa/qa/specs/features/api/5_package/container_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/group/create_group_with_mattermost_team_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_recovery_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' @@ -3741,15 +3540,12 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/1_manage/login/maintain_log_in_mixed_env_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb' - - 'qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/custom_issue_template_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/export_as_csv_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb' @@ -3758,8 +3554,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/2_plan/issue/real_time_assignee_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/related_issues/related_issues_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/transient/comment_on_discussion_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/add_design_content_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/modify_design_content_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/jira/jira_basic_integration_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_via_template_spec.rb' @@ -3783,7 +3577,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_lfs_over_http_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_over_http_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb' @@ -3817,7 +3610,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/mr_event_rule_pipeline_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pass_dotenv_variables_to_downstream_via_bridge_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_branch_switcher_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/run_pipeline_with_manual_jobs_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/trigger_matrix_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/update_ci_file_with_pipeline_editor_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/runner/register_runner_spec.rb' @@ -3836,20 +3628,10 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/rubygems_registry_spec.rb' - - 'qa/qa/specs/features/browser_ui/6_release/pages/pages_pipeline_spec.rb' - - 'qa/qa/specs/features/browser_ui/7_configure/kubernetes/kubernetes_integration_spec.rb' - - 'qa/qa/specs/features/ee/api/12_geo/geo_nodes_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/api/2_plan/epics_milestone_dates_spec.rb' - 'qa/qa/specs/features/ee/api/3_create/wiki/group_wiki_repository_storage_move_spec.rb' - 'qa/qa/specs/features/ee/api/7_configure/kubernetes/kubernetes_agent_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/elasticsearch_api_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/issues_index/issue_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/main_index/blob_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/merge_request_index/merge_request_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/notes_index/note_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/nightly_elasticsearch_test_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/10_protect/policies_list_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb' @@ -3858,24 +3640,9 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/upgrade_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/user_registration_billing_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/attachment_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/database_delete_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_ci_job_log_artifacts_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_maven_package_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_npm_registry_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_project_snippets_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/ssh_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_ssh_push_to_secondary_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/create_merge_request_with_secure_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/merge_request_license_widget_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/vulnerability_management_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' @@ -3884,12 +3651,10 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/custom_email/custom_email_spec.rb' @@ -3903,7 +3668,6 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/sum_of_issues_weights_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/issues_analytics/issues_analytics_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/issues_weight/issue_weight_visualization_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/2_plan/iterations/assign_group_iteration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/iterations/create_group_iteration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/four_assignees_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb' @@ -3924,32 +3688,21 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/transient/merge_trains_transient_bug_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/5_package/dependency_proxy_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - - 'qa/qa/specs/runner.rb' - 'qa/qa/support/loglinking.rb' - - 'qa/qa/support/page_error_checker.rb' - 'qa/qa/support/run.rb' - 'qa/qa/support/ssh.rb' - - 'qa/qa/support/wait_for_requests.rb' - 'qa/qa/tools/delete_projects.rb' - 'qa/qa/tools/delete_subgroups.rb' - 'qa/qa/tools/delete_test_ssh_keys.rb' - 'qa/qa/tools/delete_test_users.rb' - 'qa/qa/tools/generate_perf_testdata.rb' - 'qa/qa/tools/initialize_gitlab_auth.rb' - - 'qa/qa/tools/revoke_all_personal_access_tokens.rb' - - 'qa/qa/tools/test_resources_handler.rb' - - 'qa/qa/vendor/jenkins/page/configure_job.rb' - - 'qa/qa/vendor/jenkins/page/login.rb' - 'qa/spec/git/repository_spec.rb' - - 'qa/spec/page/logging_spec.rb' - 'qa/spec/resource/api_fabricator_spec.rb' - 'qa/spec/runtime/env_spec.rb' - 'qa/spec/runtime/feature_spec.rb' - - 'qa/spec/scenario/template_spec.rb' - - 'qa/spec/spec_helper.rb' - 'qa/spec/specs/helpers/context_selector_spec.rb' - 'qa/spec/specs/helpers/quarantine_spec.rb' - 'qa/spec/specs/runner_spec.rb' @@ -3970,10 +3723,8 @@ Layout/LineLength: - 'rubocop/cop/migration/safer_boolean_column.rb' - 'rubocop/cop/migration/versioned_migration_class.rb' - 'rubocop/cop/migration/with_lock_retries_disallowed_method.rb' - - 'rubocop/cop/performance/ar_exists_and_present_blank.rb' - 'rubocop/cop/qa/selector_usage.rb' - 'rubocop/cop/rspec/top_level_describe_path.rb' - - 'rubocop/cop/static_translation_definition.rb' - 'rubocop/cop/usage_data/large_table.rb' - 'scripts/api/cancel_pipeline.rb' - 'scripts/api/download_job_artifact.rb' @@ -3995,9 +3746,7 @@ Layout/LineLength: - 'sidekiq_cluster/cli.rb' - 'sidekiq_cluster/sidekiq_cluster.rb' - 'spec/benchmarks/banzai_benchmark.rb' - - 'spec/commands/metrics_server/metrics_server_spec.rb' - 'spec/commands/sidekiq_cluster/cli_spec.rb' - - 'spec/components/pajamas/alert_component_spec.rb' - 'spec/config/metrics/aggregates/aggregated_metrics_spec.rb' - 'spec/config/settings_spec.rb' - 'spec/controllers/admin/application_settings_controller_spec.rb' @@ -4027,7 +3776,6 @@ Layout/LineLength: - 'spec/controllers/groups/milestones_controller_spec.rb' - 'spec/controllers/groups/releases_controller_spec.rb' - 'spec/controllers/groups/settings/applications_controller_spec.rb' - - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - 'spec/controllers/groups/settings/integrations_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/import/available_namespaces_controller_spec.rb' @@ -4037,12 +3785,9 @@ Layout/LineLength: - 'spec/controllers/import/fogbugz_controller_spec.rb' - 'spec/controllers/import/gitea_controller_spec.rb' - 'spec/controllers/import/github_controller_spec.rb' - - 'spec/controllers/import/gitlab_controller_spec.rb' - 'spec/controllers/invites_controller_spec.rb' - - 'spec/controllers/jira_connect/app_descriptor_controller_spec.rb' - 'spec/controllers/jira_connect/events_controller_spec.rb' - 'spec/controllers/jira_connect/subscriptions_controller_spec.rb' - - 'spec/controllers/metrics_controller_spec.rb' - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/passwords_controller_spec.rb' - 'spec/controllers/profiles/accounts_controller_spec.rb' @@ -4106,7 +3851,6 @@ Layout/LineLength: - 'spec/controllers/uploads_controller_spec.rb' - 'spec/db/schema_spec.rb' - 'spec/deprecation_toolkit_env.rb' - - 'spec/experiments/application_experiment_spec.rb' - 'spec/experiments/concerns/project_commit_count_spec.rb' - 'spec/experiments/require_verification_for_namespace_creation_experiment_spec.rb' - 'spec/factories/ci/builds.rb' @@ -4135,7 +3879,6 @@ Layout/LineLength: - 'spec/features/admin/admin_sees_project_statistics_spec.rb' - 'spec/features/admin/admin_settings_spec.rb' - 'spec/features/admin/admin_users_spec.rb' - - 'spec/features/admin/users/user_spec.rb' - 'spec/features/alert_management/user_filters_alerts_by_status_spec.rb' - 'spec/features/alert_management/user_updates_alert_status_spec.rb' - 'spec/features/alert_management_spec.rb' @@ -4150,7 +3893,6 @@ Layout/LineLength: - 'spec/features/boards/user_visits_board_spec.rb' - 'spec/features/calendar_spec.rb' - 'spec/features/callouts/registration_enabled_spec.rb' - - 'spec/features/clusters/cluster_detail_page_spec.rb' - 'spec/features/commits_spec.rb' - 'spec/features/contextual_sidebar_spec.rb' - 'spec/features/cycle_analytics_spec.rb' @@ -4176,7 +3918,6 @@ Layout/LineLength: - 'spec/features/groups/milestones_sorting_spec.rb' - 'spec/features/groups/packages_spec.rb' - 'spec/features/groups/settings/access_tokens_spec.rb' - - 'spec/features/groups/settings/group_badges_spec.rb' - 'spec/features/groups/settings/repository_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/ide/static_object_external_storage_csp_spec.rb' @@ -4191,7 +3932,6 @@ Layout/LineLength: - 'spec/features/issues/csv_spec.rb' - 'spec/features/issues/filtered_search/filter_issues_spec.rb' - 'spec/features/issues/filtered_search/recent_searches_spec.rb' - - 'spec/features/issues/filtered_search/visual_tokens_spec.rb' - 'spec/features/issues/form_spec.rb' - 'spec/features/issues/gfm_autocomplete_spec.rb' - 'spec/features/issues/issue_detail_spec.rb' @@ -4206,7 +3946,6 @@ Layout/LineLength: - 'spec/features/issues/user_sees_empty_state_spec.rb' - 'spec/features/issues/user_sees_live_update_spec.rb' - 'spec/features/issues/user_views_issue_spec.rb' - - 'spec/features/jira_connect/subscriptions_spec.rb' - 'spec/features/labels_hierarchy_spec.rb' - 'spec/features/markdown/copy_as_gfm_spec.rb' - 'spec/features/markdown/gitlab_flavored_markdown_spec.rb' @@ -4247,7 +3986,6 @@ Layout/LineLength: - 'spec/features/merge_request/user_squashes_merge_request_spec.rb' - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' - 'spec/features/merge_request/user_toggles_whitespace_changes_spec.rb' - - 'spec/features/merge_request/user_views_user_status_on_merge_request_spec.rb' - 'spec/features/merge_requests/filters_generic_behavior_spec.rb' - 'spec/features/merge_requests/user_exports_as_csv_spec.rb' - 'spec/features/merge_requests/user_filters_by_approvals_spec.rb' @@ -4314,7 +4052,6 @@ Layout/LineLength: - 'spec/features/projects/releases/user_views_edit_release_spec.rb' - 'spec/features/projects/releases/user_views_releases_spec.rb' - 'spec/features/projects/settings/access_tokens_spec.rb' - - 'spec/features/projects/settings/project_badges_spec.rb' - 'spec/features/projects/settings/project_settings_spec.rb' - 'spec/features/projects/settings/registry_settings_spec.rb' - 'spec/features/projects/settings/service_desk_setting_spec.rb' @@ -4325,12 +4062,9 @@ Layout/LineLength: - 'spec/features/projects/show/schema_markup_spec.rb' - 'spec/features/projects/show/user_sees_deletion_failure_message_spec.rb' - 'spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb' - - 'spec/features/projects/tags/user_edits_tags_spec.rb' - 'spec/features/projects/terraform_spec.rb' - 'spec/features/projects/tree/upload_file_spec.rb' - - 'spec/features/projects/view_on_env_spec.rb' - 'spec/features/projects_spec.rb' - - 'spec/features/runners_spec.rb' - 'spec/features/search/user_searches_for_comments_spec.rb' - 'spec/features/search/user_searches_for_merge_requests_spec.rb' - 'spec/features/search/user_searches_for_projects_spec.rb' @@ -4344,19 +4078,16 @@ Layout/LineLength: - 'spec/features/snippets/spam_snippets_spec.rb' - 'spec/features/snippets/user_edits_snippet_spec.rb' - 'spec/features/task_lists_spec.rb' - - 'spec/features/topic_show_spec.rb' - 'spec/features/unsubscribe_links_spec.rb' - 'spec/features/user_sorts_things_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/features/users/overview_spec.rb' - - 'spec/features/users/show_spec.rb' - 'spec/features/users/signup_spec.rb' - 'spec/features/users/user_browses_projects_on_user_page_spec.rb' - 'spec/features/webauthn_spec.rb' - 'spec/finders/access_requests_finder_spec.rb' - 'spec/finders/admin/projects_finder_spec.rb' - 'spec/finders/alert_management/alerts_finder_spec.rb' - - 'spec/finders/applications_finder_spec.rb' - 'spec/finders/autocomplete/users_finder_spec.rb' - 'spec/finders/award_emojis_finder_spec.rb' - 'spec/finders/branches_finder_spec.rb' @@ -4377,8 +4108,6 @@ Layout/LineLength: - 'spec/finders/group_projects_finder_spec.rb' - 'spec/finders/groups/user_groups_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - - 'spec/finders/issues_finder_spec.rb' - - 'spec/finders/keys_finder_spec.rb' - 'spec/finders/labels_finder_spec.rb' - 'spec/finders/members_finder_spec.rb' - 'spec/finders/merge_requests/by_approvals_finder_spec.rb' @@ -4388,7 +4117,6 @@ Layout/LineLength: - 'spec/finders/milestones_finder_spec.rb' - 'spec/finders/namespaces/projects_finder_spec.rb' - 'spec/finders/notes_finder_spec.rb' - - 'spec/finders/packages/build_infos_finder_spec.rb' - 'spec/finders/packages/go/version_finder_spec.rb' - 'spec/finders/packages/group_packages_finder_spec.rb' - 'spec/finders/packages/maven/package_finder_spec.rb' @@ -4411,8 +4139,6 @@ Layout/LineLength: - 'spec/finders/user_recent_events_finder_spec.rb' - 'spec/finders/users_finder_spec.rb' - 'spec/frontend/fixtures/api_deploy_keys.rb' - - 'spec/frontend/fixtures/blob.rb' - - 'spec/frontend/fixtures/deploy_keys.rb' - 'spec/frontend/fixtures/freeze_period.rb' - 'spec/frontend/fixtures/issues.rb' - 'spec/frontend/fixtures/jobs.rb' @@ -4421,7 +4147,6 @@ Layout/LineLength: - 'spec/frontend/fixtures/pipeline_schedules.rb' - 'spec/frontend/fixtures/projects.rb' - 'spec/frontend/fixtures/snippet.rb' - - 'spec/graphql/features/feature_flag_spec.rb' - 'spec/graphql/gitlab_schema_spec.rb' - 'spec/graphql/mutations/boards/issues/issue_move_list_spec.rb' - 'spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb' @@ -4430,10 +4155,7 @@ Layout/LineLength: - 'spec/graphql/mutations/clusters/agents/create_spec.rb' - 'spec/graphql/mutations/commits/create_spec.rb' - 'spec/graphql/mutations/container_expiration_policies/update_spec.rb' - - 'spec/graphql/mutations/custom_emoji/create_spec.rb' - 'spec/graphql/mutations/customer_relations/contacts/create_spec.rb' - - 'spec/graphql/mutations/customer_relations/contacts/update_spec.rb' - - 'spec/graphql/mutations/customer_relations/organizations/create_spec.rb' - 'spec/graphql/mutations/customer_relations/organizations/update_spec.rb' - 'spec/graphql/mutations/discussions/toggle_resolve_spec.rb' - 'spec/graphql/mutations/groups/update_spec.rb' @@ -4448,7 +4170,6 @@ Layout/LineLength: - 'spec/graphql/mutations/releases/update_spec.rb' - 'spec/graphql/mutations/saved_replies/create_spec.rb' - 'spec/graphql/mutations/saved_replies/update_spec.rb' - - 'spec/graphql/mutations/security/ci_configuration/base_security_analyzer_spec.rb' - 'spec/graphql/mutations/security/ci_configuration/configure_sast_spec.rb' - 'spec/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver_spec.rb' - 'spec/graphql/resolvers/alert_management/alert_resolver_spec.rb' @@ -4487,15 +4208,12 @@ Layout/LineLength: - 'spec/graphql/types/base_field_spec.rb' - 'spec/graphql/types/commit_type_spec.rb' - 'spec/graphql/types/container_expiration_policy_type_spec.rb' - - 'spec/graphql/types/container_repository_details_type_spec.rb' - - 'spec/graphql/types/container_repository_type_spec.rb' - 'spec/graphql/types/environment_type_spec.rb' - 'spec/graphql/types/global_id_type_spec.rb' - 'spec/graphql/types/group_type_spec.rb' - 'spec/graphql/types/issue_sort_enum_spec.rb' - 'spec/graphql/types/issue_type_spec.rb' - 'spec/graphql/types/merge_request_type_spec.rb' - - 'spec/graphql/types/mutation_type_spec.rb' - 'spec/graphql/types/packages/helm/metadata_type_spec.rb' - 'spec/graphql/types/packages/package_dependency_type_enum_spec.rb' - 'spec/graphql/types/packages/package_group_sort_enum_spec.rb' @@ -4554,7 +4272,6 @@ Layout/LineLength: - 'spec/helpers/projects/security/configuration_helper_spec.rb' - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/registrations_helper_spec.rb' - - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/sidebars_helper_spec.rb' - 'spec/helpers/sidekiq_helper_spec.rb' @@ -4574,7 +4291,6 @@ Layout/LineLength: - 'spec/helpers/wiki_page_version_helper_spec.rb' - 'spec/initializers/00_rails_disable_joins_spec.rb' - 'spec/initializers/6_validations_spec.rb' - - 'spec/initializers/carrierwave_patch_spec.rb' - 'spec/initializers/direct_upload_support_spec.rb' - 'spec/initializers/global_id_spec.rb' - 'spec/initializers/lograge_spec.rb' @@ -4583,7 +4299,6 @@ Layout/LineLength: - 'spec/initializers/secret_token_spec.rb' - 'spec/initializers/session_store_spec.rb' - 'spec/initializers/settings_spec.rb' - - 'spec/initializers/trusted_proxies_spec.rb' - 'spec/lib/api/entities/ci/pipeline_spec.rb' - 'spec/lib/api/entities/project_import_status_spec.rb' - 'spec/lib/api/entities/projects/repository_storage_move_spec.rb' @@ -4599,7 +4314,6 @@ Layout/LineLength: - 'spec/lib/api/helpers/rate_limiter_spec.rb' - 'spec/lib/api/helpers_spec.rb' - 'spec/lib/atlassian/jira_connect/client_spec.rb' - - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - 'spec/lib/atlassian/jira_issue_key_extractor_spec.rb' - 'spec/lib/backup/files_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' @@ -4609,7 +4323,6 @@ Layout/LineLength: - 'spec/lib/banzai/filter/ascii_doc_post_processing_filter_spec.rb' - 'spec/lib/banzai/filter/ascii_doc_sanitization_filter_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb' - - 'spec/lib/banzai/filter/custom_emoji_filter_spec.rb' - 'spec/lib/banzai/filter/external_link_filter_spec.rb' - 'spec/lib/banzai/filter/gollum_tags_filter_spec.rb' - 'spec/lib/banzai/filter/image_link_filter_spec.rb' @@ -4658,7 +4371,6 @@ Layout/LineLength: - 'spec/lib/bulk_imports/projects/pipelines/external_pull_requests_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/snippets_pipeline_spec.rb' - 'spec/lib/bulk_imports/users_mapper_spec.rb' @@ -4668,7 +4380,6 @@ Layout/LineLength: - 'spec/lib/csv_builder_spec.rb' - 'spec/lib/declarative_enum_spec.rb' - 'spec/lib/error_tracking/sentry_client/issue_link_spec.rb' - - 'spec/lib/error_tracking/sentry_client/issue_spec.rb' - 'spec/lib/error_tracking/sentry_client/pagination_parser_spec.rb' - 'spec/lib/error_tracking/sentry_client/projects_spec.rb' - 'spec/lib/event_filter_spec.rb' @@ -4709,7 +4420,6 @@ Layout/LineLength: - 'spec/lib/gitlab/background_migration/backfill_member_namespace_for_group_members_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_work_item_type_id_for_issues_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' @@ -4746,7 +4456,6 @@ Layout/LineLength: - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' - 'spec/lib/gitlab/chat/output_spec.rb' - 'spec/lib/gitlab/checks/branch_check_spec.rb' - - 'spec/lib/gitlab/checks/changes_access_spec.rb' - 'spec/lib/gitlab/checks/diff_check_spec.rb' - 'spec/lib/gitlab/checks/push_check_spec.rb' - 'spec/lib/gitlab/checks/snippet_check_spec.rb' @@ -4792,11 +4501,9 @@ Layout/LineLength: - 'spec/lib/gitlab/ci/pipeline_object_hierarchy_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_mr_diff_spec.rb' - 'spec/lib/gitlab/ci/reports/security/flag_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/link_spec.rb' - 'spec/lib/gitlab/ci/reports/security/reports_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - - 'spec/lib/gitlab/ci/runner_releases_spec.rb' - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb' - 'spec/lib/gitlab/ci/status/build/manual_spec.rb' @@ -4815,7 +4522,6 @@ Layout/LineLength: - 'spec/lib/gitlab/code_navigation_path_spec.rb' - 'spec/lib/gitlab/composer/cache_spec.rb' - 'spec/lib/gitlab/composer/version_index_spec.rb' - - 'spec/lib/gitlab/config_checker/external_database_checker_spec.rb' - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/consul/internal_spec.rb' @@ -4835,7 +4541,6 @@ Layout/LineLength: - 'spec/lib/gitlab/database/load_balancing/configuration_spec.rb' - 'spec/lib/gitlab/database/load_balancing/host_list_spec.rb' - 'spec/lib/gitlab/database/load_balancing/service_discovery_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' - 'spec/lib/gitlab/database/load_balancing/sidekiq_client_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/srv_resolver_spec.rb' @@ -4885,7 +4590,6 @@ Layout/LineLength: - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' - 'spec/lib/gitlab/diff/highlight_spec.rb' - 'spec/lib/gitlab/diff/inline_diff_marker_spec.rb' - - 'spec/lib/gitlab/diff/position_tracer/image_strategy_spec.rb' - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/lib/gitlab/diff/suggestion_spec.rb' - 'spec/lib/gitlab/email/failure_handler_spec.rb' @@ -4941,20 +4645,13 @@ Layout/LineLength: - 'spec/lib/gitlab/github_import/importer/lfs_object_importer_spec.rb' - 'spec/lib/gitlab/github_import/object_counter_spec.rb' - 'spec/lib/gitlab/github_import/user_finder_spec.rb' - - 'spec/lib/gitlab/github_import_spec.rb' - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' - - 'spec/lib/gitlab/global_id/deprecations_spec.rb' - 'spec/lib/gitlab/gpg/commit_spec.rb' - 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb' - 'spec/lib/gitlab/graphql/loaders/batch_lfs_oid_loader_spec.rb' - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' - 'spec/lib/gitlab/graphql/pagination/connections_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/conditions/null_condition_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/connection_generic_keyset_spec.rb' - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/order_info_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/query_builder_spec.rb' - 'spec/lib/gitlab/graphql/present/field_extension_spec.rb' - 'spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb' - 'spec/lib/gitlab/graphs/commits_spec.rb' @@ -4998,7 +4695,6 @@ Layout/LineLength: - 'spec/lib/gitlab/import_sources_spec.rb' - 'spec/lib/gitlab/incoming_email_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_interceptor_spec.rb' - - 'spec/lib/gitlab/internal_post_receive/response_spec.rb' - 'spec/lib/gitlab/issuable_metadata_spec.rb' - 'spec/lib/gitlab/issues/rebalancing/state_spec.rb' - 'spec/lib/gitlab/jira/dvcs_spec.rb' @@ -5057,7 +4753,6 @@ Layout/LineLength: - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' - 'spec/lib/gitlab/pagination/keyset/paginator_spec.rb' - - 'spec/lib/gitlab/pagination/offset_header_builder_spec.rb' - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/performance_bar/redis_adapter_when_peek_enabled_spec.rb' @@ -5065,7 +4760,6 @@ Layout/LineLength: - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - - 'spec/lib/gitlab/project_template_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' @@ -5120,7 +4814,6 @@ Layout/LineLength: - 'spec/lib/gitlab/usage/metrics/instrumentations/count_users_creating_issues_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_hll_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/constraints_spec.rb' @@ -5182,7 +4875,6 @@ Layout/LineLength: - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20210421163509_schedule_update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - 'spec/migrations/20210423160427_schedule_drop_invalid_vulnerabilities_spec.rb' - 'spec/migrations/20210511142748_schedule_drop_invalid_vulnerabilities2_spec.rb' - 'spec/migrations/20210514063252_schedule_cleanup_orphaned_lfs_objects_projects_spec.rb' @@ -5196,7 +4888,6 @@ Layout/LineLength: - 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb' - 'spec/migrations/20210907211557_finalize_ci_builds_bigint_conversion_spec.rb' - 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb' - - 'spec/migrations/20210918201050_remove_old_pending_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb' - 'spec/migrations/20211110151350_schedule_drop_invalid_security_findings_spec.rb' @@ -5216,7 +4907,6 @@ Layout/LineLength: - 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb' - 'spec/migrations/active_record/schema_spec.rb' - 'spec/migrations/add_upvotes_count_index_to_issues_spec.rb' - - 'spec/migrations/associate_existing_dast_builds_with_variables_spec.rb' - 'spec/migrations/backfill_all_project_namespaces_spec.rb' - 'spec/migrations/backfill_cadence_id_for_boards_scoped_to_iteration_spec.rb' - 'spec/migrations/backfill_clusters_integration_prometheus_enabled_spec.rb' @@ -5228,24 +4918,19 @@ Layout/LineLength: - 'spec/migrations/cleanup_move_container_registry_enabled_to_project_feature_spec.rb' - 'spec/migrations/confirm_support_bot_user_spec.rb' - 'spec/migrations/delete_security_findings_without_uuid_spec.rb' - - 'spec/migrations/disable_job_token_scope_when_unused_spec.rb' - 'spec/migrations/finalize_project_namespaces_backfill_spec.rb' - 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb' - 'spec/migrations/fix_batched_migrations_old_format_job_arguments_spec.rb' - - 'spec/migrations/populate_audit_event_streaming_verification_token_spec.rb' - 'spec/migrations/populate_dismissal_information_for_vulnerabilities_spec.rb' - 'spec/migrations/re_schedule_latest_pipeline_id_population_with_all_security_related_artifact_types_spec.rb' - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb' - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb' - 'spec/migrations/remove_duplicate_dast_site_tokens_spec.rb' - - 'spec/migrations/remove_duplicate_dast_site_tokens_with_same_token_spec.rb' - 'spec/migrations/remove_not_null_contraint_on_title_from_sprints_spec.rb' - 'spec/migrations/rename_services_to_integrations_spec.rb' - 'spec/migrations/replace_external_wiki_triggers_spec.rb' - 'spec/migrations/reset_severity_levels_to_new_default_spec.rb' - 'spec/migrations/schedule_add_primary_email_to_emails_if_user_confirmed_spec.rb' - - 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb' - - 'spec/migrations/schedule_populate_status_column_of_security_scans_spec.rb' - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb' - 'spec/migrations/schedule_update_timelogs_project_id_spec.rb' @@ -5262,15 +4947,12 @@ Layout/LineLength: - 'spec/models/audit_event_spec.rb' - 'spec/models/authentication_event_spec.rb' - 'spec/models/award_emoji_spec.rb' - - 'spec/models/badge_spec.rb' - - 'spec/models/badges/project_badge_spec.rb' - 'spec/models/blob_viewer/go_mod_spec.rb' - 'spec/models/blob_viewer/metrics_dashboard_yml_spec.rb' - 'spec/models/broadcast_message_spec.rb' - 'spec/models/bulk_import_spec.rb' - 'spec/models/bulk_imports/entity_spec.rb' - 'spec/models/bulk_imports/file_transfer/project_config_spec.rb' - - 'spec/models/ci/artifact_blob_spec.rb' - 'spec/models/ci/build_runner_session_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/build_trace_chunk_spec.rb' @@ -5324,7 +5006,6 @@ Layout/LineLength: - 'spec/models/concerns/token_authenticatable_spec.rb' - 'spec/models/concerns/token_authenticatable_strategies/encryption_helper_spec.rb' - 'spec/models/concerns/x509_serial_number_attribute_spec.rb' - - 'spec/models/container_registry/event_spec.rb' - 'spec/models/container_repository_spec.rb' - 'spec/models/context_commits_diff_spec.rb' - 'spec/models/customer_relations/issue_contact_spec.rb' @@ -5361,9 +5042,7 @@ Layout/LineLength: - 'spec/models/integrations/discord_spec.rb' - 'spec/models/integrations/drone_ci_spec.rb' - 'spec/models/integrations/emails_on_push_spec.rb' - - 'spec/models/integrations/jenkins_spec.rb' - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/integrations/jira_tracker_data_spec.rb' - 'spec/models/integrations/packagist_spec.rb' - 'spec/models/integrations/prometheus_spec.rb' - 'spec/models/integrations/slack_spec.rb' @@ -5444,7 +5123,6 @@ Layout/LineLength: - 'spec/models/snippet_spec.rb' - 'spec/models/state_note_spec.rb' - 'spec/models/suggestion_spec.rb' - - 'spec/models/terraform/state_spec.rb' - 'spec/models/timelog_spec.rb' - 'spec/models/todo_spec.rb' - 'spec/models/upload_spec.rb' @@ -5469,7 +5147,6 @@ Layout/LineLength: - 'spec/presenters/clusters/cluster_presenter_spec.rb' - 'spec/presenters/commit_status_presenter_spec.rb' - 'spec/presenters/gitlab/blame_presenter_spec.rb' - - 'spec/presenters/issue_presenter_spec.rb' - 'spec/presenters/merge_request_presenter_spec.rb' - 'spec/presenters/packages/composer/packages_presenter_spec.rb' - 'spec/presenters/packages/conan/package_presenter_spec.rb' @@ -5483,7 +5160,6 @@ Layout/LineLength: - 'spec/presenters/prometheus_alert_presenter_spec.rb' - 'spec/presenters/service_hook_presenter_spec.rb' - 'spec/presenters/snippet_blob_presenter_spec.rb' - - 'spec/presenters/tree_entry_presenter_spec.rb' - 'spec/rack_servers/puma_spec.rb' - 'spec/requests/admin/background_migrations_controller_spec.rb' - 'spec/requests/api/access_requests_spec.rb' @@ -5580,7 +5256,6 @@ Layout/LineLength: - 'spec/requests/api/graphql/project/jobs_spec.rb' - 'spec/requests/api/graphql/project/milestones_spec.rb' - 'spec/requests/api/graphql/project/pipeline_spec.rb' - - 'spec/requests/api/graphql/project/project_members_spec.rb' - 'spec/requests/api/graphql/project/project_statistics_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - 'spec/requests/api/graphql/usage_trends_measurements_spec.rb' @@ -5613,7 +5288,6 @@ Layout/LineLength: - 'spec/requests/api/keys_spec.rb' - 'spec/requests/api/labels_spec.rb' - 'spec/requests/api/lint_spec.rb' - - 'spec/requests/api/markdown_spec.rb' - 'spec/requests/api/maven_packages_spec.rb' - 'spec/requests/api/members_spec.rb' - 'spec/requests/api/merge_request_diffs_spec.rb' @@ -5635,7 +5309,6 @@ Layout/LineLength: - 'spec/requests/api/project_debian_distributions_spec.rb' - 'spec/requests/api/project_events_spec.rb' - 'spec/requests/api/project_export_spec.rb' - - 'spec/requests/api/project_hooks_spec.rb' - 'spec/requests/api/project_import_spec.rb' - 'spec/requests/api/project_milestones_spec.rb' - 'spec/requests/api/project_packages_spec.rb' @@ -5647,7 +5320,6 @@ Layout/LineLength: - 'spec/requests/api/release/links_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/repositories_spec.rb' - - 'spec/requests/api/resource_state_events_spec.rb' - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/search_spec.rb' - 'spec/requests/api/settings_spec.rb' @@ -5666,8 +5338,6 @@ Layout/LineLength: - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' - 'spec/requests/ide_controller_spec.rb' - - 'spec/requests/jira_connect/installations_controller_spec.rb' - - 'spec/requests/jira_connect/users_controller_spec.rb' - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' - 'spec/requests/oauth/tokens_controller_spec.rb' @@ -5688,7 +5358,6 @@ Layout/LineLength: - 'spec/requests/projects/merge_requests_spec.rb' - 'spec/requests/projects/metrics/dashboards/builder_spec.rb' - 'spec/requests/projects/noteable_notes_spec.rb' - - 'spec/requests/projects/releases_controller_spec.rb' - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' - 'spec/requests/projects/tags_controller_spec.rb' - 'spec/requests/projects_controller_spec.rb' @@ -5702,7 +5371,6 @@ Layout/LineLength: - 'spec/routing/project_routing_spec.rb' - 'spec/routing/projects/security/configuration_controller_routing_spec.rb' - 'spec/routing/routing_spec.rb' - - 'spec/routing/uploads_routing_spec.rb' - 'spec/rubocop/cop/gitlab/mark_used_feature_flags_spec.rb' - 'spec/rubocop/cop/lint/last_keyword_argument_spec.rb' - 'spec/rubocop/cop/migration/safer_boolean_column_spec.rb' @@ -5710,10 +5378,7 @@ Layout/LineLength: - 'spec/rubocop/cop/performance/readlines_each_spec.rb' - 'spec/rubocop/cop/rspec/env_assignment_spec.rb' - 'spec/rubocop/cop/rspec/expect_gitlab_tracking_spec.rb' - - 'spec/rubocop/cop/scalability/file_uploads_spec.rb' - - 'spec/scripts/changed-feature-flags_spec.rb' - 'spec/scripts/failed_tests_spec.rb' - - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/accessibility_error_entity_spec.rb' - 'spec/serializers/accessibility_reports_comparer_entity_spec.rb' - 'spec/serializers/analytics/cycle_analytics/stage_entity_spec.rb' @@ -5779,7 +5444,6 @@ Layout/LineLength: - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' - 'spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb' - - 'spec/services/ci/retry_job_service_spec.rb' - 'spec/services/ci/runners/register_runner_service_spec.rb' - 'spec/services/ci/test_failure_history_service_spec.rb' - 'spec/services/ci/unlock_artifacts_service_spec.rb' @@ -5804,7 +5468,6 @@ Layout/LineLength: - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - 'spec/services/container_expiration_policies/update_service_spec.rb' - 'spec/services/customer_relations/contacts/create_service_spec.rb' - - 'spec/services/customer_relations/contacts/update_service_spec.rb' - 'spec/services/customer_relations/organizations/create_service_spec.rb' - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' - 'spec/services/deployments/link_merge_requests_service_spec.rb' @@ -5812,7 +5475,6 @@ Layout/LineLength: - 'spec/services/design_management/copy_design_collection/copy_service_spec.rb' - 'spec/services/design_management/delete_designs_service_spec.rb' - 'spec/services/design_management/design_user_notes_count_service_spec.rb' - - 'spec/services/design_management/save_designs_service_spec.rb' - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' - 'spec/services/discussions/resolve_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' @@ -5833,7 +5495,6 @@ Layout/LineLength: - 'spec/services/groups/autocomplete_service_spec.rb' - 'spec/services/groups/create_service_spec.rb' - 'spec/services/groups/group_links/destroy_service_spec.rb' - - 'spec/services/groups/open_issues_count_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' - 'spec/services/groups/update_shared_runners_service_spec.rb' @@ -5871,7 +5532,6 @@ Layout/LineLength: - 'spec/services/jira_import/cloud_users_mapper_service_spec.rb' - 'spec/services/jira_import/server_users_mapper_service_spec.rb' - 'spec/services/jira_import/start_import_service_spec.rb' - - 'spec/services/jira_import/users_importer_spec.rb' - 'spec/services/labels/available_labels_service_spec.rb' - 'spec/services/labels/promote_service_spec.rb' - 'spec/services/labels/transfer_service_spec.rb' @@ -5889,7 +5549,6 @@ Layout/LineLength: - 'spec/services/merge_requests/assign_issues_service_spec.rb' - 'spec/services/merge_requests/base_service_spec.rb' - 'spec/services/merge_requests/build_service_spec.rb' - - 'spec/services/merge_requests/bulk_remove_attention_requested_service_spec.rb' - 'spec/services/merge_requests/cleanup_refs_service_spec.rb' - 'spec/services/merge_requests/conflicts/list_service_spec.rb' - 'spec/services/merge_requests/create_from_issue_service_spec.rb' @@ -5901,8 +5560,6 @@ Layout/LineLength: - 'spec/services/merge_requests/link_lfs_objects_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' - 'spec/services/merge_requests/merge_to_ref_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_broken_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_discussions_status_service_spec.rb' - 'spec/services/merge_requests/mergeability/run_checks_service_spec.rb' - 'spec/services/merge_requests/mergeability_check_service_spec.rb' - 'spec/services/merge_requests/push_options_handler_service_spec.rb' @@ -5910,7 +5567,6 @@ Layout/LineLength: - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/merge_requests/request_review_service_spec.rb' - 'spec/services/merge_requests/squash_service_spec.rb' - - 'spec/services/merge_requests/toggle_attention_requested_service_spec.rb' - 'spec/services/merge_requests/update_service_spec.rb' - 'spec/services/metrics/dashboard/annotations/create_service_spec.rb' - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' @@ -5984,7 +5640,6 @@ Layout/LineLength: - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_import_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb' - - 'spec/services/projects/open_issues_count_service_spec.rb' - 'spec/services/projects/operations/update_service_spec.rb' - 'spec/services/projects/overwrite_project_service_spec.rb' - 'spec/services/projects/transfer_service_spec.rb' @@ -5994,7 +5649,6 @@ Layout/LineLength: - 'spec/services/projects/update_service_spec.rb' - 'spec/services/protected_branches/create_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/repository_archive_clean_up_service_spec.rb' - 'spec/services/resource_access_tokens/create_service_spec.rb' - 'spec/services/resource_access_tokens/revoke_service_spec.rb' @@ -6006,7 +5660,6 @@ Layout/LineLength: - 'spec/services/search_service_spec.rb' - 'spec/services/security/ci_configuration/sast_create_service_spec.rb' - 'spec/services/security/merge_reports_service_spec.rb' - - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - 'spec/services/snippets/create_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' - 'spec/services/snippets/update_service_spec.rb' @@ -6034,7 +5687,6 @@ Layout/LineLength: - 'spec/services/web_hooks/log_execution_service_spec.rb' - 'spec/services/work_items/create_and_link_service_spec.rb' - 'spec/services/work_items/create_from_task_service_spec.rb' - - 'spec/services/work_items/create_service_spec.rb' - 'spec/services/work_items/task_list_reference_replacement_service_spec.rb' - 'spec/services/work_items/update_service_spec.rb' - 'spec/services/x509_certificate_revoke_service_spec.rb' @@ -6058,7 +5710,6 @@ Layout/LineLength: - 'spec/support/helpers/feature_flag_helpers.rb' - 'spec/support/helpers/filtered_search_helpers.rb' - 'spec/support/helpers/git_http_helpers.rb' - - 'spec/support/helpers/global_id_deprecation_helpers.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' - 'spec/support/helpers/kubernetes_helpers.rb' @@ -6111,7 +5762,6 @@ Layout/LineLength: - 'spec/support/shared_examples/controllers/set_sort_order_from_user_preference_shared_examples.rb' - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - 'spec/support/shared_examples/features/2fa_shared_examples.rb' - - 'spec/support/shared_examples/features/archive_download_buttons_shared_examples.rb' - 'spec/support/shared_examples/features/container_registry_shared_examples.rb' - 'spec/support/shared_examples/features/discussion_comments_shared_example.rb' - 'spec/support/shared_examples/features/editable_merge_request_shared_examples.rb' @@ -6235,7 +5885,6 @@ Layout/LineLength: - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' - 'spec/support/shared_examples/services/resource_events/change_milestone_service_shared_examples.rb' - 'spec/support/shared_examples/services/security/ci_configuration/create_service_shared_examples.rb' - - 'spec/support/shared_examples/snippet_blob_shared_examples.rb' - 'spec/support/shared_examples/uploaders/gitlab_uploader_shared_examples.rb' - 'spec/support/shared_examples/uploaders/upload_type_shared_examples.rb' - 'spec/support/shared_examples/views/registration_features_prompt_shared_examples.rb' @@ -6251,7 +5900,6 @@ Layout/LineLength: - 'spec/tasks/dev_rake_spec.rb' - 'spec/tasks/gitlab/artifacts/check_rake_spec.rb' - 'spec/tasks/gitlab/background_migrations_rake_spec.rb' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/tasks/gitlab/external_diffs_rake_spec.rb' @@ -6267,7 +5915,6 @@ Layout/LineLength: - 'spec/tasks/gitlab/storage_rake_spec.rb' - 'spec/tasks/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/update_templates_rake_spec.rb' - 'spec/tasks/gitlab/uploads/check_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' - 'spec/tasks/migrate/schema_check_rake_spec.rb' @@ -6306,13 +5953,10 @@ Layout/LineLength: - 'spec/views/layouts/_head.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - - 'spec/views/notify/change_in_merge_request_draft_status_email.html.haml_spec.rb' - - 'spec/views/notify/change_in_merge_request_draft_status_email.text.erb_spec.rb' - 'spec/views/notify/push_to_merge_request_email.text.haml_spec.rb' - 'spec/views/profiles/keys/_form.html.haml_spec.rb' - 'spec/views/projects/artifacts/_artifact.html.haml_spec.rb' - 'spec/views/projects/commits/_commit.html.haml_spec.rb' - - 'spec/views/projects/edit.html.haml_spec.rb' - 'spec/views/projects/imports/new.html.haml_spec.rb' - 'spec/views/projects/jobs/_build.html.haml_spec.rb' - 'spec/views/projects/jobs/_generic_commit_status.html.haml_spec.rb' @@ -6356,8 +6000,6 @@ Layout/LineLength: - 'spec/workers/container_registry/migration/guard_worker_spec.rb' - 'spec/workers/container_registry/migration/observer_worker_spec.rb' - 'spec/workers/create_pipeline_worker_spec.rb' - - 'spec/workers/database/batched_background_migration/ci_database_worker_spec.rb' - - 'spec/workers/database/batched_background_migration_worker_spec.rb' - 'spec/workers/dependency_proxy/image_ttl_group_policy_worker_spec.rb' - 'spec/workers/deployments/hooks_worker_spec.rb' - 'spec/workers/deployments/update_environment_worker_spec.rb' @@ -6380,8 +6022,6 @@ Layout/LineLength: - 'spec/workers/jira_connect/sync_project_worker_spec.rb' - 'spec/workers/loose_foreign_keys/cleanup_worker_spec.rb' - 'spec/workers/members_destroyer/unassign_issuables_worker_spec.rb' - - 'spec/workers/merge_requests/create_pipeline_worker_spec.rb' - - 'spec/workers/merge_requests/update_head_pipeline_worker_spec.rb' - 'spec/workers/new_issue_worker_spec.rb' - 'spec/workers/new_merge_request_worker_spec.rb' - 'spec/workers/packages/cleanup_package_file_worker_spec.rb' @@ -6394,7 +6034,6 @@ Layout/LineLength: - 'spec/workers/personal_access_tokens/expiring_worker_spec.rb' - 'spec/workers/post_receive_spec.rb' - 'spec/workers/projects/post_creation_worker_spec.rb' - - 'spec/workers/projects/refresh_build_artifacts_size_statistics_worker_spec.rb' - 'spec/workers/propagate_integration_inherit_descendant_worker_spec.rb' - 'spec/workers/remove_expired_members_worker_spec.rb' - 'spec/workers/repository_check/dispatch_worker_spec.rb' diff --git a/.rubocop_todo/layout/space_around_operators.yml b/.rubocop_todo/layout/space_around_operators.yml new file mode 100644 index 00000000000..9f6c0145723 --- /dev/null +++ b/.rubocop_todo/layout/space_around_operators.yml @@ -0,0 +1,5 @@ +--- +# Cop supports --auto-correct. +Layout/SpaceAroundOperators: + Exclude: + - 'lib/gitlab/utils/strong_memoize.rb' diff --git a/.rubocop_todo/layout/space_before_block_braces.yml b/.rubocop_todo/layout/space_before_block_braces.yml new file mode 100644 index 00000000000..3be90947fee --- /dev/null +++ b/.rubocop_todo/layout/space_before_block_braces.yml @@ -0,0 +1,5 @@ +--- +# Cop supports --auto-correct. +Layout/SpaceBeforeBlockBraces: + Exclude: + - 'app/helpers/colors_helper.rb' diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml new file mode 100644 index 00000000000..c775ad94e46 --- /dev/null +++ b/.rubocop_todo/layout/space_inside_block_braces.yml @@ -0,0 +1,5 @@ +--- +# Cop supports --auto-correct. +Layout/SpaceInsideBlockBraces: + Exclude: + - 'spec/requests/api/groups_spec.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index 301568f0ec4..805a9791409 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -418,7 +418,6 @@ Layout/SpaceInsideParens: - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/releases_shared_examples.rb' - 'spec/support/shared_examples/serializers/environment_serializer_shared_examples.rb' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/validators/devise_email_validator_spec.rb' - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' diff --git a/.rubocop_todo/layout/trailing_whitespace.yml b/.rubocop_todo/layout/trailing_whitespace.yml new file mode 100644 index 00000000000..d9c88c989e0 --- /dev/null +++ b/.rubocop_todo/layout/trailing_whitespace.yml @@ -0,0 +1,16 @@ +--- +# Cop supports --auto-correct. +Layout/TrailingWhitespace: + Details: grace period + Exclude: + - 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb' + - 'db/migrate/20210611100359_rebuild_index_for_cadence_iterations_automation.rb' + - 'db/migrate/20220913082728_drop_index_cadence_create_iterations_automation.rb' + - 'db/post_migrate/20220816163444_update_start_date_for_iterations_cadences.rb' + - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' + - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' + - 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb' + - 'qa/qa/specs/features/browser_ui/7_configure/auto_devops/create_project_with_auto_devops_spec.rb' + - 'spec/lib/banzai/filter/front_matter_filter_spec.rb' + - 'spec/services/suggestions/apply_service_spec.rb' + - 'spec/support/helpers/x509_helpers.rb' diff --git a/.rubocop_todo/lint/binary_operator_with_identical_operands.yml b/.rubocop_todo/lint/binary_operator_with_identical_operands.yml deleted file mode 100644 index 90c3a76d3b1..00000000000 --- a/.rubocop_todo/lint/binary_operator_with_identical_operands.yml +++ /dev/null @@ -1,15 +0,0 @@ ---- -Lint/BinaryOperatorWithIdenticalOperands: - Exclude: - - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - - 'spec/helpers/visibility_level_helper_spec.rb' - - 'spec/lib/gitlab/conan_token_spec.rb' - - 'spec/lib/gitlab/git/conflict/parser_spec.rb' - - 'spec/lib/gitlab/graphql/lazy_spec.rb' - - 'spec/models/ci/build_trace_chunk_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/concerns/where_composite_spec.rb' - - 'spec/models/metrics/dashboard/annotation_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/ssh_host_key_spec.rb' - - 'spec/tooling/danger/sidekiq_queues_spec.rb' diff --git a/.rubocop_todo/lint/duplicate_case_condition.yml b/.rubocop_todo/lint/duplicate_case_condition.yml new file mode 100644 index 00000000000..d7e1eac2e03 --- /dev/null +++ b/.rubocop_todo/lint/duplicate_case_condition.yml @@ -0,0 +1,4 @@ +--- +Lint/DuplicateCaseCondition: + Exclude: + - 'app/helpers/icons_helper.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index e4925aa2cfd..b0b5697536e 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -1,18 +1,25 @@ --- # Cop supports --auto-correct. Lint/RedundantCopDisableDirective: - # This cop can only be enabled after enabling all cops which are currently - # disabled. Otherwise we'll see RuboCop complaining depending on - # REVEAL_RUBOCOP_TODO environment variable. + # Used to be enabled in "grace period" and is now disabled due to too many + # silenced offenses. + # See https://gitlab.com/gitlab-org/gitlab/-/issues/376133 Enabled: false Exclude: + - 'app/controllers/concerns/enforces_two_factor_authentication.rb' + - 'app/controllers/concerns/web_hooks/hook_log_actions.rb' + - 'app/controllers/groups/autocomplete_sources_controller.rb' + - 'app/controllers/groups/labels_controller.rb' + - 'app/controllers/projects/merge_requests/diffs_controller.rb' - 'app/finders/autocomplete/acts_as_taggable_on/tags_finder.rb' - 'app/finders/autocomplete/move_to_project_finder.rb' - 'app/finders/autocomplete/routes_finder.rb' - 'app/finders/autocomplete/users_finder.rb' - 'app/finders/ci/daily_build_group_report_results_finder.rb' + - 'app/finders/ci/runner_jobs_finder.rb' - 'app/finders/groups_finder.rb' - 'app/finders/users_finder.rb' + - 'app/graphql/gitlab_schema.rb' - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' - 'app/graphql/resolvers/project_milestones_resolver.rb' - 'app/graphql/types/base_enum.rb' @@ -20,13 +27,17 @@ Lint/RedundantCopDisableDirective: - 'app/graphql/types/packages/helm/dependency_type.rb' - 'app/graphql/types/projects/service_type_enum.rb' - 'app/helpers/diff_helper.rb' + - 'app/helpers/lazy_image_tag_helper.rb' - 'app/helpers/search_helper.rb' + - 'app/models/clusters/cluster.rb' - 'app/models/concerns/cascading_namespace_setting_attribute.rb' - 'app/models/concerns/from_except.rb' - 'app/models/concerns/from_intersect.rb' - 'app/models/concerns/from_union.rb' + - 'app/models/project_statistics.rb' - 'app/models/user.rb' - 'app/presenters/dev_ops_report/metric_presenter.rb' + - 'app/presenters/packages/nuget/search_results_presenter.rb' - 'app/serializers/diffs_entity.rb' - 'app/serializers/fork_namespace_entity.rb' - 'app/services/ci/job_artifacts/destroy_batch_service.rb' @@ -35,25 +46,35 @@ Lint/RedundantCopDisableDirective: - 'app/services/database/consistency_check_service.rb' - 'app/services/issues/export_csv_service.rb' - 'app/services/labels/transfer_service.rb' + - 'app/services/members/create_service.rb' + - 'app/services/members/creator_service.rb' + - 'app/services/members/projects/creator_service.rb' + - 'app/services/members/standard_member_builder.rb' - 'app/services/projects/auto_devops/disable_service.rb' - 'app/services/projects/open_issues_count_service.rb' - 'app/services/spam/spam_action_service.rb' - 'app/services/users/migrate_to_ghost_user_service.rb' - - 'app/services/web_hooks/destroy_service.rb' + - 'app/services/web_hook_service.rb' + - 'app/uploaders/object_storage/cdn/google_ip_cache.rb' - 'app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb' + - 'app/workers/build_hooks_worker.rb' - 'app/workers/bulk_imports/entity_worker.rb' - - 'app/workers/container_expiration_policy_worker.rb' + - 'app/workers/ci/track_failed_build_worker.rb' + - 'app/workers/container_registry/migration/enqueuer_worker.rb' - 'app/workers/create_note_diff_file_worker.rb' - 'app/workers/import_issues_csv_worker.rb' - 'app/workers/incident_management/process_alert_worker_v2.rb' - 'app/workers/merge_worker.rb' - 'app/workers/remove_unaccepted_member_invites_worker.rb' - 'config/initializers/warden.rb' - - 'config/initializers/wikicloth_redos_patch.rb' + - 'config/initializers/wikicloth_ruby_3_patch.rb' - 'config/routes/api.rb' - 'db/migrate/20210303193544_add_concurrent_fields_to_bulk_imports_trackers.rb' - 'db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb' - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' + - 'db/migrate/20220316022505_create_namespace_details.rb' + - 'db/migrate/20220421141342_add_allowed_plans_to_ci_runners.rb' + - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - 'db/post_migrate/20210610042700_remove_clusters_applications_fluentd_table.rb' - 'db/post_migrate/20210708011426_finalize_ci_builds_metadata_bigint_conversion.rb' - 'db/post_migrate/20210730104800_schedule_extract_project_topics_into_separate_table.rb' @@ -62,8 +83,12 @@ Lint/RedundantCopDisableDirective: - 'db/post_migrate/20211028100303_tmp_index_for_delete_issue_merge_request_taggings_records.rb' - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' + - 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb' + - 'db/post_migrate/20220902204048_move_security_findings_table_to_gitlab_partitions_dynamic_schema.rb' - 'ee/app/controllers/ee/groups/group_members_controller.rb' + - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' - 'ee/app/controllers/groups/todos_controller.rb' + - 'ee/app/experiments/cart_abandonment_modal_experiment.rb' - 'ee/app/finders/geo/file_registry_finder.rb' - 'ee/app/finders/geo/project_registry_finder.rb' - 'ee/app/finders/geo/registry_finder.rb' @@ -72,13 +97,16 @@ Lint/RedundantCopDisableDirective: - 'ee/app/graphql/types/ci/minutes/namespace_monthly_usage_type.rb' - 'ee/app/graphql/types/incident_management/oncall_rotation_active_period_input_type.rb' - 'ee/app/graphql/types/scan_type.rb' + - 'ee/app/graphql/types/vulnerability_request_type.rb' - 'ee/app/helpers/ee/boards_helper.rb' - - 'ee/app/helpers/ee/namespaces_helper.rb' - 'ee/app/helpers/projects/on_demand_scans_helper.rb' + - 'ee/app/models/dast/branch.rb' - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/geo/event_log.rb' + - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' - 'ee/app/services/analytics/cycle_analytics/data_loader_service.rb' - 'ee/app/services/ee/boards/issues/list_service.rb' + - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/services/ee/search_service.rb' - 'ee/app/services/ee/users/migrate_to_ghost_user_service.rb' - 'ee/app/services/geo/repository_base_sync_service.rb' @@ -92,20 +120,30 @@ Lint/RedundantCopDisableDirective: - 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb' - 'ee/lib/analytics/merge_request_metrics_calculator.rb' - 'ee/lib/api/audit_events.rb' + - 'ee/lib/api/scim.rb' - 'ee/lib/ee/api/entities/analytics/code_review/merge_request.rb' - - 'ee/lib/ee/api/settings.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' + - 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb' - 'ee/lib/ee/gitlab/usage_data.rb' + - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb' + - 'ee/lib/gitlab/elastic/bool_expr.rb' + - 'ee/lib/gitlab/spdx/license.rb' + - 'ee/lib/gitlab/status_page/storage/object.rb' + - 'ee/spec/features/boards/user_visits_board_spec.rb' + - 'ee/spec/features/groups/settings/domain_verification_spec.rb' - 'ee/spec/helpers/ee/releases_helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb' - 'ee/spec/lib/elastic/latest/project_instance_proxy_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' - 'ee/spec/support/shared_examples/models/elasticsearch_indexed_container_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' - 'lib/api/api.rb' - 'lib/api/ci/variables.rb' - - 'lib/api/entities/environment.rb' - 'lib/api/entities/issuable_time_stats.rb' - 'lib/api/helpers.rb' - 'lib/bulk_imports/common/transformers/user_reference_transformer.rb' @@ -115,24 +153,32 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'lib/gitlab/analytics/cycle_analytics/base_query_builder.rb' - 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb' + - 'lib/gitlab/application_context.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' + - 'lib/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' + - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/fix_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' + - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' + - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/bitbucket_import/importer.rb' + - 'lib/gitlab/buffered_io.rb' - 'lib/gitlab/cache/request_cache.rb' - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' + - 'lib/gitlab/ci/pipeline/chain/command.rb' - 'lib/gitlab/ci/pipeline/duration.rb' - 'lib/gitlab/ci/reports/accessibility_reports.rb' - - 'lib/gitlab/ci/reports/test_reports.rb' + - 'lib/gitlab/ci/reports/test_report.rb' - 'lib/gitlab/ci/reports/test_reports_comparer.rb' - 'lib/gitlab/ci/reports/test_suite.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' + - 'lib/gitlab/cleanup/personal_access_tokens.rb' - 'lib/gitlab/composer/cache.rb' - 'lib/gitlab/database/consistency_checker.rb' - 'lib/gitlab/database/migration.rb' + - 'lib/gitlab/database/migrations/observation.rb' - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb' - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/file_collection/merge_request_diff_batch.rb' @@ -140,52 +186,95 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/encrypted_ldap_command.rb' - 'lib/gitlab/encrypted_smtp_command.rb' + - 'lib/gitlab/git/commit.rb' - 'lib/gitlab/git/patches/collection.rb' - 'lib/gitlab/github_import/user_finder.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' + - 'lib/gitlab/health_checks/metric.rb' + - 'lib/gitlab/health_checks/probes/status.rb' + - 'lib/gitlab/health_checks/result.rb' - 'lib/gitlab/legacy_github_import/user_formatter.rb' + - 'lib/gitlab/middleware/release_env.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/pagination/keyset/pager.rb' - 'lib/gitlab/performance_bar/redis_adapter_when_peek_enabled.rb' - 'lib/gitlab/profiler.rb' - 'lib/gitlab/project_search_results.rb' - 'lib/gitlab/redis/hll.rb' + - 'lib/gitlab/search/sort_options.rb' - 'lib/gitlab/slash_commands/issue_search.rb' + - 'lib/gitlab/slash_commands/result.rb' + - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric.rb' - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data_queries.rb' - 'lib/gitlab/utils/usage_data.rb' + - 'lib/gitlab/x509/signature.rb' - 'lib/tasks/gitlab/cleanup.rake' + - 'qa/tasks/ci.rake' + - 'scripts/lib/glfm/render_static_html.rb' - 'scripts/security-harness' - 'sidekiq_cluster/cli.rb' - 'sidekiq_cluster/sidekiq_cluster.rb' + - 'spec/components/previews/pajamas/banner_component_preview.rb' + - 'spec/fixtures/packages/rubygems/package.gemspec' - 'spec/frontend/fixtures/merge_requests.rb' + - 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/delete_spec.rb' + - 'spec/graphql/mutations/commits/create_spec.rb' + - 'spec/graphql/resolvers/base_resolver_spec.rb' - 'spec/helpers/releases_helper_spec.rb' + - 'spec/initializers/memory_watchdog_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_issue_work_item_type_batching_strategy_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' + - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb' + - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' + - 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb' + - 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb' - 'spec/lib/gitlab/git/tree_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_saver_spec.rb' - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' + - 'spec/lib/gitlab/rack_attack/request_spec.rb' - 'spec/lib/gitlab/shard_health_cache_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' + - 'spec/lib/initializer_connections_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' + - 'spec/migrations/20220725150127_update_jira_tracker_data_deployment_type_based_on_url_spec.rb' + - 'spec/migrations/reschedule_backfill_imported_issue_search_data_spec.rb' - 'spec/models/ci/build_trace_chunk_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/namespace/package_setting_spec.rb' - 'spec/models/namespace_spec.rb' + - 'spec/models/project_feature_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' + - 'spec/presenters/packages/pypi/simple_index_presenter_spec.rb' + - 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb' - 'spec/requests/api/alert_management_alerts_spec.rb' + - 'spec/requests/api/graphql/ci/config_spec.rb' - 'spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb' - 'spec/services/alert_management/metric_images/upload_service_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' + - 'spec/services/projects/update_statistics_service_spec.rb' + - 'spec/services/spam/spam_verdict_service_spec.rb' + - 'spec/services/topics/merge_service_spec.rb' + - 'spec/support/forgery_protection.rb' - 'spec/support/helpers/snowplow_helpers.rb' - 'spec/support/helpers/wait_for_requests.rb' + - 'spec/support/shared_examples/lib/gitlab/local_and_remote_storage_migration_shared_examples.rb' - 'spec/support/shared_examples/models/boards/listable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb' - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' + - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' - 'spec/uploaders/packages/composer/cache_uploader_spec.rb' - 'tooling/danger/product_intelligence.rb' - 'tooling/lib/tooling/helm3_client.rb' diff --git a/.rubocop_todo/metrics/abc_size.yml b/.rubocop_todo/metrics/abc_size.yml index 747ef3823f5..f5646151592 100644 --- a/.rubocop_todo/metrics/abc_size.yml +++ b/.rubocop_todo/metrics/abc_size.yml @@ -12,3 +12,4 @@ Metrics/AbcSize: - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' - 'qa/qa/resource/repository/push.rb' + - 'ee/db/seeds/awesome_co/**/*.rb' diff --git a/.rubocop_todo/metrics/parameter_lists.yml b/.rubocop_todo/metrics/parameter_lists.yml new file mode 100644 index 00000000000..14cd46d31fb --- /dev/null +++ b/.rubocop_todo/metrics/parameter_lists.yml @@ -0,0 +1,9 @@ +--- +Metrics/ParameterLists: + Exclude: + - 'app/helpers/avatars_helper.rb' + - 'app/helpers/blob_helper.rb' + - 'app/models/packages/sem_ver.rb' + - 'app/models/repository.rb' + - 'lib/gitlab/git/tree.rb' + - 'lib/gitlab/version_info.rb' diff --git a/.rubocop_todo/performance/bind_call.yml b/.rubocop_todo/performance/bind_call.yml new file mode 100644 index 00000000000..5adb519793d --- /dev/null +++ b/.rubocop_todo/performance/bind_call.yml @@ -0,0 +1,10 @@ +--- +# Cop supports --auto-correct. +Performance/BindCall: + Exclude: + - 'app/services/metrics/dashboard/grafana_metric_embed_service.rb' + - 'ee/spec/features/issues/form_spec.rb' + - 'lib/gitlab/patch/prependable.rb' + - 'spec/features/issues/form_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/support/patches/rspec_mocks_prepended_methods.rb' diff --git a/.rubocop_todo/performance/redundant_block_call.yml b/.rubocop_todo/performance/redundant_block_call.yml new file mode 100644 index 00000000000..89a67e3fd30 --- /dev/null +++ b/.rubocop_todo/performance/redundant_block_call.yml @@ -0,0 +1,12 @@ +--- +# Cop supports --auto-correct. +Performance/RedundantBlockCall: + Exclude: + - 'ee/app/models/gitlab_subscription.rb' + - 'ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb' + - 'lib/gitlab/auth/ldap/access.rb' + - 'lib/gitlab/auth/ldap/adapter.rb' + - 'lib/gitlab/database/bulk_update.rb' + - 'lib/gitlab/http.rb' + - 'lib/gitlab/safe_request_store.rb' + - 'lib/gitlab/timeless.rb' diff --git a/.rubocop_todo/rails/active_record_callbacks_order.yml b/.rubocop_todo/rails/active_record_callbacks_order.yml index 9585a720c6a..11ffff36e8d 100644 --- a/.rubocop_todo/rails/active_record_callbacks_order.yml +++ b/.rubocop_todo/rails/active_record_callbacks_order.yml @@ -1,12 +1,9 @@ --- # Cop supports --auto-correct. Rails/ActiveRecordCallbacksOrder: - # Offense count: 30 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/models/award_emoji.rb' - - 'app/models/ci/job_artifact.rb' - 'app/models/gpg_key.rb' - 'app/models/group.rb' - 'app/models/issue.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index 467073eb2db..24a08fa5ee2 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -1,10 +1,7 @@ --- Rails/FilePath: - # Offense count: 212 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - - 'app/controllers/clusters/clusters_controller.rb' - 'app/controllers/help_controller.rb' - 'app/helpers/startupjs_helper.rb' - 'app/models/clusters/applications/cert_manager.rb' @@ -29,6 +26,7 @@ Rails/FilePath: - 'ee/db/fixtures/development/21_dast_profiles.rb' - 'ee/db/fixtures/development/32_compliance_report_violations.rb' - 'ee/lib/ee/feature/definition.rb' + - 'ee/lib/ee/gitlab/audit/type/definition.rb' - 'ee/lib/ee/gitlab/usage/metric_definition.rb' - 'ee/lib/gitlab/geo/health_check.rb' - 'ee/lib/tasks/gitlab/seed/metrics.rake' @@ -48,6 +46,8 @@ Rails/FilePath: - 'lib/api/api.rb' - 'lib/error_tracking/collector/payload_validator.rb' - 'lib/feature/definition.rb' + - 'lib/gitlab/audit/type/definition.rb' + - 'lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator.rb' - 'lib/gitlab/ci/reports/codequality_reports.rb' - 'lib/gitlab/database/migrations/runner.rb' - 'lib/gitlab/favicon.rb' @@ -69,14 +69,17 @@ Rails/FilePath: - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' - 'lib/system_check/app/uploads_directory_exists_check.rb' - 'lib/system_check/incoming_email/imap_authentication_check.rb' + - 'lib/tasks/gitlab/db.rake' - 'lib/tasks/gitlab/metrics_exporter.rake' + - 'lib/tasks/gitlab/usage_data.rake' - 'lib/tasks/tanuki_emoji.rake' - 'metrics_server/metrics_server.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' - 'spec/config/object_store_settings_spec.rb' - - 'spec/controllers/help_controller_spec.rb' + - 'spec/db/development/add_security_training_providers_spec.rb' - 'spec/db/development/create_base_work_item_types_spec.rb' - 'spec/db/development/import_common_metrics_spec.rb' + - 'spec/db/production/add_security_training_providers_spec.rb' - 'spec/db/production/create_base_work_item_types_spec.rb' - 'spec/db/production/import_common_metrics_spec.rb' - 'spec/db/schema_spec.rb' @@ -100,7 +103,6 @@ Rails/FilePath: - 'spec/features/projects/settings/repository_settings_spec.rb' - 'spec/features/projects/settings/user_changes_avatar_spec.rb' - 'spec/features/projects/snippets/create_snippet_spec.rb' - - 'spec/features/projects/tags/user_edits_tags_spec.rb' - 'spec/features/projects/tree/upload_file_spec.rb' - 'spec/features/snippets/user_creates_snippet_spec.rb' - 'spec/features/snippets/user_edits_snippet_spec.rb' @@ -127,10 +129,12 @@ Rails/FilePath: - 'spec/models/clusters/applications/cert_manager_spec.rb' - 'spec/models/release_highlight_spec.rb' - 'spec/requests/api/internal/mail_room_spec.rb' + - 'spec/requests/api/usage_data_queries_spec.rb' - 'spec/serializers/review_app_setup_entity_spec.rb' - 'spec/services/clusters/aws/fetch_credentials_service_spec.rb' - 'spec/services/clusters/aws/provision_service_spec.rb' - 'spec/services/metrics/sample_metrics_service_spec.rb' + - 'spec/support/helpers/doc_url_helper.rb' - 'spec/support/helpers/test_env.rb' - 'spec/support/helpers/upload_helpers.rb' - 'spec/support/shared_examples/features/project_upload_files_shared_examples.rb' @@ -139,3 +143,4 @@ Rails/FilePath: - 'spec/support/shared_examples/models/wiki_shared_examples.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/tasks/gitlab/generate_sample_prometheus_data_spec.rb' + - 'spec/tasks/gitlab/usage_data_rake_spec.rb' diff --git a/.rubocop_todo/rails/helper_instance_variable.yml b/.rubocop_todo/rails/helper_instance_variable.yml index f43ca39f47c..8f9197c9223 100644 --- a/.rubocop_todo/rails/helper_instance_variable.yml +++ b/.rubocop_todo/rails/helper_instance_variable.yml @@ -1,8 +1,6 @@ --- Rails/HelperInstanceVariable: - # Offense count: 671 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/helpers/admin/user_actions_helper.rb' - 'app/helpers/application_helper.rb' @@ -29,7 +27,6 @@ Rails/HelperInstanceVariable: - 'app/helpers/icons_helper.rb' - 'app/helpers/ide_helper.rb' - 'app/helpers/import_helper.rb' - - 'app/helpers/integrations_helper.rb' - 'app/helpers/issuables_description_templates_helper.rb' - 'app/helpers/issuables_helper.rb' - 'app/helpers/issues_helper.rb' @@ -40,6 +37,7 @@ Rails/HelperInstanceVariable: - 'app/helpers/nav_helper.rb' - 'app/helpers/notes_helper.rb' - 'app/helpers/operations_helper.rb' + - 'app/helpers/packages_helper.rb' - 'app/helpers/page_layout_helper.rb' - 'app/helpers/projects_helper.rb' - 'app/helpers/releases_helper.rb' @@ -59,11 +57,13 @@ Rails/HelperInstanceVariable: - 'app/helpers/webpack_helper.rb' - 'app/helpers/wiki_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' + - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/boards_helper.rb' - 'ee/app/helpers/ee/feature_flags_helper.rb' - 'ee/app/helpers/ee/form_helper.rb' - 'ee/app/helpers/ee/graph_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' + - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/integrations_helper.rb' - 'ee/app/helpers/ee/kerberos_helper.rb' @@ -77,7 +77,8 @@ Rails/HelperInstanceVariable: - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/search_helper.rb' - 'ee/app/helpers/ee/selects_helper.rb' + - 'ee/app/helpers/ee/sorting_helper.rb' - 'ee/app/helpers/ee/subscribable_banner_helper.rb' - 'ee/app/helpers/ee/wiki_helper.rb' - 'ee/app/helpers/path_locks_helper.rb' - - 'ee/app/helpers/projects/security/discover_helper.rb' + - 'ee/app/helpers/seat_count_alert_helper.rb' diff --git a/.rubocop_todo/rails/http_status.yml b/.rubocop_todo/rails/http_status.yml new file mode 100644 index 00000000000..1a8ece49304 --- /dev/null +++ b/.rubocop_todo/rails/http_status.yml @@ -0,0 +1,9 @@ +--- +# Cop supports --auto-correct. +Rails/HttpStatus: + Exclude: + - 'app/controllers/concerns/invisible_captcha_on_signup.rb' + - 'app/controllers/projects/runner_projects_controller.rb' + - 'app/controllers/projects/service_ping_controller.rb' + - 'app/controllers/repositories/lfs_storage_controller.rb' + - 'ee/app/controllers/trials_controller.rb' diff --git a/.rubocop_todo/rails/index_with.yml b/.rubocop_todo/rails/index_with.yml index d8ccbd97f7c..91a75e198f5 100644 --- a/.rubocop_todo/rails/index_with.yml +++ b/.rubocop_todo/rails/index_with.yml @@ -1,29 +1,30 @@ --- # Cop supports --auto-correct. Rails/IndexWith: - # Offense count: 54 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/helpers/ci/jobs_helper.rb' - 'app/models/ci/build_trace_chunk.rb' - 'app/models/ci/processable.rb' - 'app/models/concerns/cached_commit.rb' + - 'app/models/customer_relations/organization.rb' - 'app/models/environment.rb' - 'app/services/concerns/rate_limited_service.rb' + - 'app/services/packages/rpm/parse_package_service.rb' - 'db/post_migrate/20210731132939_backfill_stage_event_hash.rb' + - 'ee/app/models/concerns/identity_verifiable.rb' - 'ee/app/models/vulnerabilities/projects_grade.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' - 'ee/lib/gitlab/custom_file_templates.rb' - 'ee/lib/gitlab/insights/reducers/count_per_label_reducer.rb' - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/sca/license_compliance_spec.rb' - 'ee/spec/views/admin/dashboard/index.html.haml_spec.rb' - 'lib/api/entities/project_integration.rb' - 'lib/api/helpers/packages/conan/api_helpers.rb' - 'lib/banzai/filter/repository_link_filter.rb' + - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/reports/security/finding.rb' @@ -32,10 +33,12 @@ Rails/IndexWith: - 'lib/gitlab/database/count/exact_count_strategy.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/database/obsolete_ignored_columns.rb' + - 'lib/gitlab/database/tables_sorted_by_foreign_keys.rb' - 'lib/gitlab/issuable_metadata.rb' - 'lib/gitlab/template/base_template.rb' - 'lib/gitlab/usage_data.rb' - 'lib/google_api/cloud_platform/client.rb' + - 'lib/tasks/gitlab/db.rake' - 'qa/qa/resource/reusable.rb' - 'scripts/trigger-build.rb' - 'spec/lib/gitlab/api_authentication/sent_through_builder_spec.rb' diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml index 98d116c3319..262804739bd 100644 --- a/.rubocop_todo/rails/inverse_of.yml +++ b/.rubocop_todo/rails/inverse_of.yml @@ -1,8 +1,6 @@ --- Rails/InverseOf: - # Offense count: 210 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/models/alert_management/alert.rb' - 'app/models/alert_management/alert_assignee.rb' @@ -12,7 +10,6 @@ Rails/InverseOf: - 'app/models/board.rb' - 'app/models/bulk_imports/entity.rb' - 'app/models/bulk_imports/tracker.rb' - - 'app/models/chat_name.rb' - 'app/models/ci/bridge.rb' - 'app/models/ci/build.rb' - 'app/models/ci/build_pending_state.rb' @@ -25,7 +22,6 @@ Rails/InverseOf: - 'app/models/ci/runner.rb' - 'app/models/ci/runner_namespace.rb' - 'app/models/ci/sources/pipeline.rb' - - 'app/models/ci/stage.rb' - 'app/models/ci/trigger_request.rb' - 'app/models/ci/unit_test_failure.rb' - 'app/models/clusters/applications/runner.rb' @@ -38,7 +34,6 @@ Rails/InverseOf: - 'app/models/concerns/analytics/cycle_analytics/stage.rb' - 'app/models/concerns/awardable.rb' - 'app/models/concerns/commit_signature.rb' - - 'app/models/concerns/merge_request_reviewer_state.rb' - 'app/models/concerns/with_uploads.rb' - 'app/models/custom_emoji.rb' - 'app/models/customer_relations/contact.rb' @@ -51,7 +46,7 @@ Rails/InverseOf: - 'app/models/group.rb' - 'app/models/group/crm_settings.rb' - 'app/models/group_group_link.rb' - - 'app/models/hooks/service_hook.rb' + - 'app/models/group_label.rb' - 'app/models/incident_management/timeline_event.rb' - 'app/models/integrations/base_slash_commands.rb' - 'app/models/issue.rb' @@ -66,11 +61,15 @@ Rails/InverseOf: - 'app/models/packages/composer/cache_file.rb' - 'app/models/packages/maven/metadatum.rb' - 'app/models/project.rb' + - 'app/models/project_label.rb' - 'app/models/resource_state_event.rb' - 'app/models/serverless/domain_cluster.rb' - 'app/models/terraform/state_version.rb' + - 'app/models/time_tracking/timelog_category.rb' - 'app/models/todo.rb' - 'app/models/user.rb' + - 'app/models/users/phone_number_validation.rb' + - 'app/models/work_item.rb' - 'app/models/x509_certificate.rb' - 'ee/app/models/allowed_email_domain.rb' - 'ee/app/models/analytics/cycle_analytics/group_stage.rb' @@ -78,12 +77,14 @@ Rails/InverseOf: - 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb' - 'ee/app/models/analytics/devops_adoption/snapshot.rb' - 'ee/app/models/audit_events/external_audit_event_destination.rb' + - 'ee/app/models/audit_events/streaming/header.rb' - 'ee/app/models/ci/sources/project.rb' - 'ee/app/models/compliance_management/compliance_framework/project_settings.rb' - 'ee/app/models/concerns/incident_management/base_pending_escalation.rb' - 'ee/app/models/dast/profile_schedule.rb' - 'ee/app/models/ee/ci/build.rb' - 'ee/app/models/ee/ci/pipeline.rb' + - 'ee/app/models/ee/clusters/agent.rb' - 'ee/app/models/ee/epic.rb' - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/iteration.rb' @@ -105,9 +106,9 @@ Rails/InverseOf: - 'ee/app/models/integrations/gitlab_slack_application.rb' - 'ee/app/models/requirements_management/requirement.rb' - 'ee/app/models/requirements_management/test_report.rb' + - 'ee/app/models/sbom/vulnerable_component_version.rb' - 'ee/app/models/security/orchestration_policy_configuration.rb' - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' - - 'ee/app/models/slack_integration.rb' - 'ee/app/models/software_license_policy.rb' - 'ee/app/models/user_permission_export_upload.rb' - 'ee/app/models/vulnerabilities/feedback.rb' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index 7e394849670..22af6131b33 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -1,9 +1,7 @@ --- # Cop supports --auto-correct. Rails/RedundantForeignKey: - # Offense count: 90 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/models/alert_management/metric_image.rb' - 'app/models/ci/build.rb' @@ -23,9 +21,11 @@ Rails/RedundantForeignKey: - 'app/models/commit_signatures/x509_commit_signature.rb' - 'app/models/concerns/analytics/cycle_analytics/stage.rb' - 'app/models/concerns/commit_signature.rb' + - 'app/models/concerns/integrations/base_data_fields.rb' - 'app/models/group.rb' - 'app/models/group_group_link.rb' - - 'app/models/integrations/zentao_tracker_data.rb' + - 'app/models/incident_management/timeline_event.rb' + - 'app/models/issue.rb' - 'app/models/member.rb' - 'app/models/merge_request.rb' - 'app/models/merge_request/metrics.rb' @@ -35,9 +35,13 @@ Rails/RedundantForeignKey: - 'app/models/project.rb' - 'app/models/resource_state_event.rb' - 'app/models/review.rb' + - 'app/models/time_tracking/timelog_category.rb' - 'app/models/user.rb' + - 'app/models/users/phone_number_validation.rb' + - 'app/models/work_item.rb' - 'app/models/x509_certificate.rb' - 'ee/app/models/allowed_email_domain.rb' + - 'ee/app/models/audit_events/streaming/header.rb' - 'ee/app/models/boards/epic_board.rb' - 'ee/app/models/boards/epic_list_user_preference.rb' - 'ee/app/models/ci/sources/project.rb' diff --git a/.rubocop_todo/rails/skips_model_validations.yml b/.rubocop_todo/rails/skips_model_validations.yml index 8ef895ed562..f5aa7411c89 100644 --- a/.rubocop_todo/rails/skips_model_validations.yml +++ b/.rubocop_todo/rails/skips_model_validations.yml @@ -252,7 +252,6 @@ Rails/SkipsModelValidations: - 'ee/spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb' - 'ee/spec/controllers/groups/ldaps_controller_spec.rb' - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' - - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/factories/import_states.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index 8931b337ce1..f1e7d519a8f 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -19,7 +19,6 @@ Rails/TimeZone: - ee/spec/lib/gitlab/auth/ldap/access_spec.rb - ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb - ee/spec/lib/gitlab/auth/smartcard/session_spec.rb - - ee/spec/lib/gitlab/ci/pipeline/chain/limit/job_activity_spec.rb - ee/spec/lib/gitlab/elastic/client_spec.rb - ee/spec/lib/gitlab/geo/base_request_spec.rb - ee/spec/lib/gitlab/geo/log_cursor/events/cache_invalidation_event_spec.rb diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index e7855e84b28..5ee00cb0e24 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -13,7 +13,6 @@ RSpec/AnyInstanceOf: - ee/spec/controllers/projects/path_locks_controller_spec.rb - ee/spec/controllers/projects_controller_spec.rb - ee/spec/controllers/subscriptions_controller_spec.rb - - ee/spec/controllers/trials_controller_spec.rb - ee/spec/features/admin/admin_audit_logs_spec.rb - ee/spec/features/admin/admin_reset_pipeline_minutes_spec.rb - ee/spec/features/admin/admin_users_spec.rb diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/rspec/capybara/visibility_matcher.yml index e236be2593e..f9e8c982903 100644 --- a/.rubocop_todo/capybara/visibility_matcher.yml +++ b/.rubocop_todo/rspec/capybara/visibility_matcher.yml @@ -1,5 +1,5 @@ --- -Capybara/VisibilityMatcher: +RSpec/Capybara/VisibilityMatcher: Exclude: - 'ee/spec/features/boards/sidebar_spec.rb' - 'ee/spec/features/epics/epic_show_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 97480a0e0ba..79dfd85281c 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -70,7 +70,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/security/vulnerabilities_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/controllers/trial_registrations_controller_spec.rb' - - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/controllers/users_controller_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/elastic/migrate/20220512150000_pause_indexing_for_unsupported_es_versions_spec.rb' @@ -2542,7 +2541,6 @@ RSpec/ContextWording: - 'spec/policies/terraform/state_version_policy_spec.rb' - 'spec/policies/user_policy_spec.rb' - 'spec/presenters/blob_presenter_spec.rb' - - 'spec/presenters/blobs/unfold_presenter_spec.rb' - 'spec/presenters/ci/build_presenter_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' - 'spec/presenters/clusters/cluster_presenter_spec.rb' @@ -3372,7 +3370,6 @@ RSpec/ContextWording: - 'spec/tasks/cache/clear/redis_spec.rb' - 'spec/tasks/dev_rake_spec.rb' - 'spec/tasks/gettext_rake_spec.rb' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/db/lock_writes_rake_spec.rb' - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' diff --git a/.rubocop_todo/rspec/described_class.yml b/.rubocop_todo/rspec/described_class.yml index 8304704985b..516eda12675 100644 --- a/.rubocop_todo/rspec/described_class.yml +++ b/.rubocop_todo/rspec/described_class.yml @@ -69,7 +69,6 @@ RSpec/DescribedClass: - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - 'ee/spec/services/users/captcha_challenge_service_spec.rb' - - 'ee/spec/services/vulnerabilities/create_from_security_finding_service_spec.rb' - 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - 'ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index f8962515874..626ed1390ce 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -1,11 +1,13 @@ --- # Cop supports --auto-correct. RSpec/ExpectChange: + Details: grace period Exclude: - 'ee/spec/controllers/admin/applications_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' - 'ee/spec/controllers/ee/omniauth_callbacks_controller_spec.rb' - 'ee/spec/controllers/ee/registrations_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/cycle_analytics/value_streams_controller_spec.rb' - 'ee/spec/controllers/groups/epic_issues_controller_spec.rb' - 'ee/spec/controllers/groups/epics/notes_controller_spec.rb' - 'ee/spec/controllers/groups/epics_controller_spec.rb' @@ -21,19 +23,25 @@ RSpec/ExpectChange: - 'ee/spec/controllers/projects/protected_environments_controller_spec.rb' - 'ee/spec/controllers/projects/repositories_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerabilities/notes_controller_spec.rb' + - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/elastic/migrate/20220512150000_pause_indexing_for_unsupported_es_versions_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/projects_spec.rb' - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/graphql/ee/mutations/ci/runner/update_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' + - 'ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb' + - 'ee/spec/graphql/mutations/dast/profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_scanner_profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_site_validations/revoke_spec.rb' + - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' + - 'ee/spec/graphql/types/dast_site_profile_type_spec.rb' - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' - 'ee/spec/lib/audit/changes_spec.rb' - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' @@ -53,12 +61,14 @@ RSpec/ExpectChange: - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' + - 'ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_batch_spec.rb' - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/repo_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/issuable/clone/copy_resource_events_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/deprovision_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/distinct_stage_loader_spec.rb' - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/identity_linker_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' @@ -66,13 +76,17 @@ RSpec/ExpectChange: - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' + - 'ee/spec/lib/gitlab/cache_spec.rb' + - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' - 'ee/spec/migrations/20220411173544_cleanup_orphans_approval_project_rules_spec.rb' - 'ee/spec/models/ci/bridge_spec.rb' - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' + - 'ee/spec/models/concerns/geo/eventable_spec.rb' - 'ee/spec/models/concerns/geo/replicable_model_spec.rb' - 'ee/spec/models/concerns/geo/verification_state_spec.rb' + - 'ee/spec/models/container_registry/event_spec.rb' - 'ee/spec/models/dast/profile_schedule_spec.rb' - 'ee/spec/models/dast_site_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' @@ -85,15 +99,20 @@ RSpec/ExpectChange: - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/geo/project_registry_spec.rb' - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' + - 'ee/spec/models/project_member_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/repository_spec.rb' + - 'ee/spec/models/requirements_management/requirement_spec.rb' + - 'ee/spec/models/requirements_management/test_report_spec.rb' - 'ee/spec/models/status_page/published_incident_spec.rb' - 'ee/spec/models/vulnerabilities/export_spec.rb' + - 'ee/spec/models/vulnerabilities/read_spec.rb' - 'ee/spec/models/vulnerabilities/statistic_spec.rb' + - 'ee/spec/replicators/geo/pipeline_replicator_spec.rb' - 'ee/spec/requests/api/ci/pipelines_spec.rb' + - 'ee/spec/requests/api/deployments_spec.rb' - 'ee/spec/requests/api/epic_issues_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' @@ -101,8 +120,12 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/epics/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/dast/profiles/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/dast/profiles/delete_spec.rb' - 'ee/spec/requests/api/graphql/mutations/dast_scanner_profiles/delete_spec.rb' - 'ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb' - 'ee/spec/requests/api/graphql/mutations/dast_site_tokens/create_spec.rb' @@ -110,6 +133,8 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/graphql/mutations/dast_site_validations/revoke_spec.rb' - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/update_requirement_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security_policy/create_security_policy_project_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'ee/spec/requests/api/group_push_rule_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' @@ -121,19 +146,30 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/projects_spec.rb' - 'ee/spec/requests/api/releases_spec.rb' - 'ee/spec/requests/api/repositories_spec.rb' + - 'ee/spec/requests/api/status_checks_spec.rb' - 'ee/spec/requests/api/todos_spec.rb' - 'ee/spec/requests/api/users_spec.rb' - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' + - 'ee/spec/requests/groups/epics/related_epic_links_controller_spec.rb' - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' + - 'ee/spec/services/analytics/cycle_analytics/stages/list_service_spec.rb' + - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/bulk_find_or_create_service_spec.rb' + - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/profiles/destroy_service_spec.rb' + - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/destroy_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_profiles/audit/update_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_profiles/destroy_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_tokens/find_or_create_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/find_or_create_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/revoke_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/runner_service_spec.rb' + - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb' - 'ee/spec/services/application_settings/update_service_spec.rb' - 'ee/spec/services/approval_rules/finalize_service_spec.rb' - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb' @@ -144,18 +180,27 @@ RSpec/ExpectChange: - 'ee/spec/services/audit_events/streaming/headers/update_service_spec.rb' - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' + - 'ee/spec/services/boards/epic_user_preferences/update_service_spec.rb' - 'ee/spec/services/boards/epics/create_service_spec.rb' - 'ee/spec/services/boards/epics/move_service_spec.rb' + - 'ee/spec/services/boards/epics/position_create_service_spec.rb' - 'ee/spec/services/ci/destroy_pipeline_service_spec.rb' - 'ee/spec/services/ci/external_pull_requests/process_github_event_service_spec.rb' + - 'ee/spec/services/ci/minutes/update_build_minutes_service_spec.rb' + - 'ee/spec/services/ci/pipeline_trigger_service_spec.rb' - 'ee/spec/services/ci/process_build_service_spec.rb' + - 'ee/spec/services/ci/retry_job_service_spec.rb' + - 'ee/spec/services/ci/runners/stale_group_runners_prune_service_spec.rb' - 'ee/spec/services/ci/subscribe_bridge_service_spec.rb' + - 'ee/spec/services/ci/trigger_downstream_subscription_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/destroy_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' - 'ee/spec/services/deploy_keys/create_service_spec.rb' - 'ee/spec/services/deployments/approval_service_spec.rb' - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' + - 'ee/spec/services/ee/ci/job_artifacts/destroy_all_expired_service_spec.rb' + - 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb' - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' @@ -168,6 +213,7 @@ RSpec/ExpectChange: - 'ee/spec/services/ee/members/destroy_service_spec.rb' - 'ee/spec/services/ee/members/invite_service_spec.rb' - 'ee/spec/services/ee/members/update_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - 'ee/spec/services/ee/notes/quick_actions_service_spec.rb' - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb' @@ -179,6 +225,7 @@ RSpec/ExpectChange: - 'ee/spec/services/ee/users/reject_service_spec.rb' - 'ee/spec/services/ee/users/update_service_spec.rb' - 'ee/spec/services/elastic/indexing_control_service_spec.rb' + - 'ee/spec/services/elastic/process_initial_bookkeeping_service_spec.rb' - 'ee/spec/services/emails/create_service_spec.rb' - 'ee/spec/services/emails/destroy_service_spec.rb' - 'ee/spec/services/epic_issues/create_service_spec.rb' @@ -193,16 +240,21 @@ RSpec/ExpectChange: - 'ee/spec/services/geo/blob_download_service_spec.rb' - 'ee/spec/services/geo/metrics_update_service_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' + - 'ee/spec/services/geo/prune_event_log_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' + - 'ee/spec/services/geo/repository_registry_removal_service_spec.rb' - 'ee/spec/services/geo/repository_sync_service_spec.rb' - 'ee/spec/services/group_saml/group_managed_accounts/transfer_membership_service_spec.rb' - 'ee/spec/services/group_saml/identity/destroy_service_spec.rb' - 'ee/spec/services/group_saml/sign_up_service_spec.rb' + - 'ee/spec/services/groups/destroy_service_spec.rb' - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb' - 'ee/spec/services/groups/restore_service_spec.rb' - 'ee/spec/services/groups/sync_service_spec.rb' + - 'ee/spec/services/incident_management/issuable_resource_links/create_service_spec.rb' - 'ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb' - 'ee/spec/services/incident_management/pending_escalations/create_service_spec.rb' + - 'ee/spec/services/iterations/cadences/create_service_spec.rb' - 'ee/spec/services/iterations/update_service_spec.rb' - 'ee/spec/services/keys/create_service_spec.rb' - 'ee/spec/services/lfs/lock_file_service_spec.rb' @@ -210,56 +262,101 @@ RSpec/ExpectChange: - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - - 'ee/spec/services/namespaces/free_user_cap/update_prevent_sharing_outside_hierarchy_service_spec.rb' + - 'ee/spec/services/projects/destroy_service_spec.rb' - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' + - 'ee/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' + - 'ee/spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - 'ee/spec/services/projects/import_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' - 'ee/spec/services/projects/transfer_service_spec.rb' - 'ee/spec/services/projects/update_service_spec.rb' - 'ee/spec/services/protected_environments/destroy_service_spec.rb' + - 'ee/spec/services/protected_environments/update_service_spec.rb' - 'ee/spec/services/push_rules/create_or_update_service_spec.rb' - - 'ee/spec/services/requirements_management/create_requirement_service_spec.rb' + - 'ee/spec/services/requirements_management/process_test_reports_service_spec.rb' - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' - 'ee/spec/services/resource_access_tokens/revoke_service_spec.rb' - 'ee/spec/services/resource_events/change_weight_service_spec.rb' - 'ee/spec/services/security/ingestion/finding_map_spec.rb' - 'ee/spec/services/security/ingestion/ingest_report_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_finding_evidence_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_finding_identifiers_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_finding_links_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_finding_signatures_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_findings_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_remediations_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities/mark_resolved_as_detected_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - 'ee/spec/services/security/override_uuids_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb' + - 'ee/spec/services/security/store_findings_metadata_service_spec.rb' - 'ee/spec/services/security/store_scan_service_spec.rb' - 'ee/spec/services/start_pull_mirroring_service_spec.rb' + - 'ee/spec/services/status_page/mark_for_publication_service_spec.rb' - 'ee/spec/services/system_notes/epics_service_spec.rb' - 'ee/spec/services/system_notes/merge_train_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/todos/destroy/confidential_epic_service_spec.rb' + - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/services/users_ops_dashboard_projects/destroy_service_spec.rb' + - 'ee/spec/services/vulnerabilities/confirm_service_spec.rb' + - 'ee/spec/services/vulnerabilities/destroy_dismissal_feedback_service_spec.rb' + - 'ee/spec/services/vulnerabilities/historical_statistics/adjustment_service_spec.rb' + - 'ee/spec/services/vulnerabilities/historical_statistics/deletion_service_spec.rb' + - 'ee/spec/services/vulnerabilities/resolve_service_spec.rb' + - 'ee/spec/services/vulnerabilities/revert_to_detected_service_spec.rb' + - 'ee/spec/services/vulnerabilities/security_finding/create_issue_service_spec.rb' + - 'ee/spec/services/vulnerabilities/starboard_vulnerability_create_service_spec.rb' + - 'ee/spec/services/vulnerabilities/statistics/adjustment_service_spec.rb' - 'ee/spec/services/vulnerabilities/statistics/update_service_spec.rb' + - 'ee/spec/services/vulnerability_exports/create_service_spec.rb' - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' + - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' + - 'ee/spec/services/vulnerability_external_issue_links/destroy_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/destroy_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/create_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/delete_service_spec.rb' - 'ee/spec/support/shared_contexts/audit_event_not_licensed_shared_context.rb' - 'ee/spec/support/shared_examples/graphql/mutations/update_health_status_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/concerns/blob_replicator_strategy_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/replicable_model_with_separate_table_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/concerns/repository_replicator_strategy_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' - 'ee/spec/support/shared_examples/services/group_saml/saml_provider/base_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/update_issuable_health_status_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/vulnerabilities/removes_dismissal_feedback_from_associated_findings_shared_example.rb' - 'ee/spec/tasks/geo/git_rake_spec.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' + - 'ee/spec/workers/app_sec/dast/scanner_profiles_builds/consistency_worker_spec.rb' + - 'ee/spec/workers/app_sec/dast/scans/consistency_worker_spec.rb' + - 'ee/spec/workers/app_sec/dast/site_profiles_builds/consistency_worker_spec.rb' + - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb' + - 'ee/spec/workers/ci/upstream_projects_subscriptions_cleanup_worker_spec.rb' - 'ee/spec/workers/ee/projects/inactive_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker_spec.rb' + - 'ee/spec/workers/geo/create_repository_updated_event_worker_spec.rb' + - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' - 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb' + - 'ee/spec/workers/incident_management/oncall_rotations/persist_shifts_job_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' + - 'ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb' + - 'spec/controllers/admin/applications_controller_spec.rb' + - 'spec/controllers/admin/clusters_controller_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/admin/spam_logs_controller_spec.rb' + - 'spec/controllers/admin/topics_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' + - 'spec/controllers/groups/clusters_controller_spec.rb' - 'spec/controllers/groups/runners_controller_spec.rb' + - 'spec/controllers/groups/settings/applications_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/import/bitbucket_controller_spec.rb' - 'spec/controllers/import/gitlab_controller_spec.rb' @@ -268,38 +365,71 @@ RSpec/ExpectChange: - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/profiles/gpg_keys_controller_spec.rb' - 'spec/controllers/profiles/keys_controller_spec.rb' + - 'spec/controllers/projects/artifacts_controller_spec.rb' + - 'spec/controllers/projects/clusters_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' + - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' - 'spec/controllers/projects/merge_requests_controller_spec.rb' - 'spec/controllers/projects/mirrors_controller_spec.rb' - 'spec/controllers/projects/notes_controller_spec.rb' - 'spec/controllers/projects/pages_domains_controller_spec.rb' + - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' + - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/controllers/projects/raw_controller_spec.rb' - 'spec/controllers/projects/runners_controller_spec.rb' + - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - 'spec/controllers/sessions_controller_spec.rb' - 'spec/controllers/snippets/notes_controller_spec.rb' - 'spec/controllers/uploads_controller_spec.rb' + - 'spec/controllers/users/callouts_controller_spec.rb' - 'spec/features/admin/users/users_spec.rb' - 'spec/features/file_uploads/attachment_spec.rb' + - 'spec/features/file_uploads/ci_artifact_spec.rb' - 'spec/features/file_uploads/git_lfs_spec.rb' + - 'spec/features/file_uploads/graphql_add_design_spec.rb' - 'spec/features/file_uploads/group_import_spec.rb' + - 'spec/features/file_uploads/maven_package_spec.rb' + - 'spec/features/file_uploads/nuget_package_spec.rb' - 'spec/features/file_uploads/project_import_spec.rb' + - 'spec/features/file_uploads/rubygem_package_spec.rb' - 'spec/features/groups/import_export/import_file_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/invites_spec.rb' + - 'spec/features/projects/environments/environment_spec.rb' + - 'spec/features/projects/environments/environments_spec.rb' - 'spec/features/projects/import_export/import_file_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' + - 'spec/features/projects/pipelines/pipelines_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/users/signup_spec.rb' + - 'spec/finders/environments/environments_by_deployments_finder_spec.rb' + - 'spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb' + - 'spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb' + - 'spec/graphql/mutations/ci/runner/bulk_delete_spec.rb' + - 'spec/graphql/mutations/ci/runner/delete_spec.rb' + - 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/delete_spec.rb' + - 'spec/graphql/mutations/container_repositories/destroy_spec.rb' + - 'spec/graphql/mutations/container_repositories/destroy_tags_spec.rb' + - 'spec/graphql/mutations/dependency_proxy/image_ttl_group_policy/update_spec.rb' - 'spec/graphql/mutations/issues/set_severity_spec.rb' - 'spec/graphql/mutations/releases/delete_spec.rb' - 'spec/graphql/mutations/timelogs/delete_spec.rb' + - 'spec/helpers/markup_helper_spec.rb' + - 'spec/helpers/projects_helper_spec.rb' - 'spec/initializers/active_record_locking_spec.rb' - 'spec/lib/api/helpers_spec.rb' + - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' - 'spec/lib/declarative_enum_spec.rb' + - 'spec/lib/gitaly/server_spec.rb' - 'spec/lib/gitlab/auth/ldap/access_spec.rb' - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - 'spec/lib/gitlab/auth/o_auth/identity_linker_spec.rb' @@ -315,16 +445,21 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' + - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/line_spec.rb' - 'spec/lib/gitlab/ci/config/external/context_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/create_deployments_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/ensure_environments_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/ensure_resource_groups_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/seed/processable/resource_group_spec.rb' - 'spec/lib/gitlab/ci/reports/security/report_spec.rb' - 'spec/lib/gitlab/ci/status/factory_spec.rb' + - 'spec/lib/gitlab/ci/trace/archive_spec.rb' - 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb' + - 'spec/lib/gitlab/composer/cache_spec.rb' - 'spec/lib/gitlab/config/entry/validatable_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' - 'spec/lib/gitlab/database/async_indexes/index_creator_spec.rb' @@ -333,12 +468,20 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/observers/query_log_spec.rb' - 'spec/lib/gitlab/database/migrations/observers/query_statistics_spec.rb' - 'spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb' + - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' + - 'spec/lib/gitlab/database/partitioning_spec.rb' - 'spec/lib/gitlab/database/reindexing/reindex_action_spec.rb' - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' + - 'spec/lib/gitlab/git/commit_spec.rb' + - 'spec/lib/gitlab/git/tag_spec.rb' - 'spec/lib/gitlab/git_access_project_spec.rb' - 'spec/lib/gitlab/github_import/importer/events/changed_assignee_spec.rb' - 'spec/lib/gitlab/github_import/importer/events/renamed_spec.rb' @@ -360,6 +503,7 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/process_supervisor_spec.rb' - 'spec/lib/gitlab/query_limiting_spec.rb' - 'spec/lib/gitlab/reference_counter_spec.rb' + - 'spec/lib/gitlab/seeders/ci/daily_build_group_report_result_spec.rb' - 'spec/lib/gitlab/slash_commands/issue_move_spec.rb' - 'spec/lib/gitlab/word_diff/positions_counter_spec.rb' - 'spec/migrations/20210805192450_update_trial_plans_ci_daily_pipeline_schedule_triggers_spec.rb' @@ -371,11 +515,14 @@ RSpec/ExpectChange: - 'spec/migrations/20220202105733_delete_service_template_records_spec.rb' - 'spec/migrations/20220222192525_remove_null_releases_spec.rb' - 'spec/migrations/20220629184402_unset_escalation_policies_for_alert_incidents_spec.rb' + - 'spec/migrations/add_new_trail_plans_spec.rb' + - 'spec/migrations/add_open_source_plan_spec.rb' - 'spec/migrations/backfill_cycle_analytics_aggregations_spec.rb' - 'spec/migrations/bulk_insert_cluster_enabled_grants_spec.rb' - 'spec/migrations/cleanup_after_add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - 'spec/migrations/cleanup_after_fixing_regression_with_new_users_emails_spec.rb' + - 'spec/migrations/delete_security_findings_without_uuid_spec.rb' - 'spec/migrations/populate_audit_event_streaming_verification_token_spec.rb' - 'spec/migrations/remove_records_without_group_from_webhooks_table_spec.rb' - 'spec/migrations/remove_wiki_notes_spec.rb' @@ -389,11 +536,14 @@ RSpec/ExpectChange: - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/deleted_object_spec.rb' - 'spec/models/ci/namespace_mirror_spec.rb' + - 'spec/models/ci/pipeline_artifact_spec.rb' - 'spec/models/ci/pipeline_schedule_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci/processable_spec.rb' - 'spec/models/ci/project_mirror_spec.rb' - 'spec/models/ci/ref_spec.rb' - 'spec/models/ci/runner_spec.rb' + - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/commit_status_spec.rb' - 'spec/models/concerns/atomic_internal_id_spec.rb' @@ -410,6 +560,7 @@ RSpec/ExpectChange: - 'spec/models/container_repository_spec.rb' - 'spec/models/customer_relations/issue_contact_spec.rb' - 'spec/models/design_management/version_spec.rb' + - 'spec/models/error_tracking/project_error_tracking_setting_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/experiment_spec.rb' - 'spec/models/group_spec.rb' @@ -423,6 +574,7 @@ RSpec/ExpectChange: - 'spec/models/member_spec.rb' - 'spec/models/merge_request_spec.rb' - 'spec/models/packages/package_file_spec.rb' + - 'spec/models/packages/package_spec.rb' - 'spec/models/pages_domain_spec.rb' - 'spec/models/plan_spec.rb' - 'spec/models/project_auto_devops_spec.rb' @@ -437,6 +589,7 @@ RSpec/ExpectChange: - 'spec/models/route_spec.rb' - 'spec/models/sent_notification_spec.rb' - 'spec/models/snippet_spec.rb' + - 'spec/models/terraform/state_spec.rb' - 'spec/models/upload_spec.rb' - 'spec/models/user_interacted_project_spec.rb' - 'spec/models/user_spec.rb' @@ -444,18 +597,33 @@ RSpec/ExpectChange: - 'spec/models/x509_certificate_spec.rb' - 'spec/models/x509_issuer_spec.rb' - 'spec/requests/abuse_reports_controller_spec.rb' + - 'spec/requests/api/admin/ci/variables_spec.rb' + - 'spec/requests/api/applications_spec.rb' - 'spec/requests/api/broadcast_messages_spec.rb' + - 'spec/requests/api/ci/pipeline_schedules_spec.rb' - 'spec/requests/api/ci/pipelines_spec.rb' - 'spec/requests/api/ci/runner/jobs_trace_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' - 'spec/requests/api/deploy_keys_spec.rb' - 'spec/requests/api/deploy_tokens_spec.rb' + - 'spec/requests/api/error_tracking/collector_spec.rb' + - 'spec/requests/api/feature_flags_spec.rb' + - 'spec/requests/api/freeze_periods_spec.rb' + - 'spec/requests/api/generic_packages_spec.rb' - 'spec/requests/api/graphql/mutations/award_emojis/add_spec.rb' - 'spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb' - 'spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb' - 'spec/requests/api/graphql/mutations/boards/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' + - 'spec/requests/api/graphql/mutations/clusters/agents/create_spec.rb' + - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' + - 'spec/requests/api/graphql/mutations/container_repository/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/container_repository/destroy_tags_spec.rb' - 'spec/requests/api/graphql/mutations/labels/create_spec.rb' + - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb' + - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb' - 'spec/requests/api/graphql/mutations/notes/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/packages/cleanup/policy/update_spec.rb' - 'spec/requests/api/graphql/mutations/releases/delete_spec.rb' - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' - 'spec/requests/api/graphql/mutations/snippets/destroy_spec.rb' @@ -463,21 +631,35 @@ RSpec/ExpectChange: - 'spec/requests/api/group_import_spec.rb' - 'spec/requests/api/groups_spec.rb' - 'spec/requests/api/internal/base_spec.rb' + - 'spec/requests/api/maven_packages_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/notes_spec.rb' + - 'spec/requests/api/npm_project_packages_spec.rb' - 'spec/requests/api/project_snippets_spec.rb' - 'spec/requests/api/projects_spec.rb' + - 'spec/requests/api/pypi_packages_spec.rb' + - 'spec/requests/api/release/links_spec.rb' - 'spec/requests/api/releases_spec.rb' + - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/snippets_spec.rb' + - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' + - 'spec/requests/api/terraform/state_spec.rb' + - 'spec/requests/api/terraform/state_version_spec.rb' - 'spec/requests/api/users_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/import/gitlab_groups_controller_spec.rb' + - 'spec/requests/oauth_tokens_spec.rb' - 'spec/requests/product_analytics/collector_app_spec.rb' - 'spec/requests/projects/issue_links_controller_spec.rb' + - 'spec/requests/projects/merge_requests_discussions_spec.rb' - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' + - 'spec/requests/users/group_callouts_spec.rb' + - 'spec/requests/users/namespace_callouts_spec.rb' + - 'spec/requests/users/project_callouts_spec.rb' - 'spec/services/alert_management/alerts/todo/create_service_spec.rb' - 'spec/services/alert_management/alerts/update_service_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' + - 'spec/services/applications/create_service_spec.rb' - 'spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb' - 'spec/services/authorized_project_update/project_recalculate_service_spec.rb' - 'spec/services/award_emojis/add_service_spec.rb' @@ -486,18 +668,39 @@ RSpec/ExpectChange: - 'spec/services/award_emojis/toggle_service_spec.rb' - 'spec/services/bulk_imports/create_service_spec.rb' - 'spec/services/bulk_imports/relation_export_service_spec.rb' + - 'spec/services/ci/build_report_result_service_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/ci/daily_build_group_report_result_service_spec.rb' + - 'spec/services/ci/delete_objects_service_spec.rb' - 'spec/services/ci/destroy_pipeline_service_spec.rb' + - 'spec/services/ci/ensure_stage_service_spec.rb' + - 'spec/services/ci/job_artifacts/create_service_spec.rb' - 'spec/services/ci/job_artifacts/delete_service_spec.rb' + - 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb' + - 'spec/services/ci/job_artifacts/destroy_associations_service_spec.rb' + - 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb' - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' + - 'spec/services/ci/job_token_scope/add_project_service_spec.rb' + - 'spec/services/ci/job_token_scope/remove_project_service_spec.rb' + - 'spec/services/ci/pipeline_artifacts/coverage_report_service_spec.rb' + - 'spec/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service_spec.rb' + - 'spec/services/ci/pipeline_artifacts/destroy_all_expired_service_spec.rb' + - 'spec/services/ci/pipeline_trigger_service_spec.rb' - 'spec/services/ci/play_build_service_spec.rb' - 'spec/services/ci/process_build_service_spec.rb' - 'spec/services/ci/retry_job_service_spec.rb' - 'spec/services/ci/retry_pipeline_service_spec.rb' - 'spec/services/ci/run_scheduled_build_service_spec.rb' + - 'spec/services/ci/runners/bulk_delete_runners_service_spec.rb' + - 'spec/services/ci/runners/unregister_runner_service_spec.rb' - 'spec/services/ci/update_build_queue_service_spec.rb' - 'spec/services/ci/update_build_state_service_spec.rb' + - 'spec/services/ci/update_instance_variables_service_spec.rb' + - 'spec/services/clusters/agent_tokens/create_service_spec.rb' + - 'spec/services/clusters/agents/create_service_spec.rb' + - 'spec/services/clusters/agents/delete_service_spec.rb' + - 'spec/services/clusters/create_service_spec.rb' - 'spec/services/clusters/destroy_service_spec.rb' - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - 'spec/services/deployments/create_for_build_service_spec.rb' @@ -509,17 +712,21 @@ RSpec/ExpectChange: - 'spec/services/draft_notes/destroy_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' - 'spec/services/emails/create_service_spec.rb' + - 'spec/services/error_tracking/collect_error_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/event_create_service_spec.rb' - 'spec/services/feature_flags/create_service_spec.rb' - 'spec/services/feature_flags/destroy_service_spec.rb' - 'spec/services/feature_flags/update_service_spec.rb' + - 'spec/services/git/branch_push_service_spec.rb' - 'spec/services/git/process_ref_changes_service_spec.rb' + - 'spec/services/git/tag_hooks_service_spec.rb' - 'spec/services/groups/create_service_spec.rb' - 'spec/services/groups/import_export/import_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' - 'spec/services/groups/update_statistics_service_spec.rb' + - 'spec/services/incident_management/timeline_events/create_service_spec.rb' - 'spec/services/incident_management/timeline_events/update_service_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issues/close_service_spec.rb' @@ -533,6 +740,7 @@ RSpec/ExpectChange: - 'spec/services/lfs/lock_file_service_spec.rb' - 'spec/services/merge_requests/add_spent_time_service_spec.rb' - 'spec/services/merge_requests/close_service_spec.rb' + - 'spec/services/merge_requests/create_pipeline_service_spec.rb' - 'spec/services/merge_requests/create_service_spec.rb' - 'spec/services/merge_requests/ff_merge_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' @@ -544,24 +752,48 @@ RSpec/ExpectChange: - 'spec/services/merge_requests/update_service_spec.rb' - 'spec/services/milestones/destroy_service_spec.rb' - 'spec/services/namespace_settings/update_service_spec.rb' + - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'spec/services/notes/create_service_spec.rb' - 'spec/services/notes/destroy_service_spec.rb' - 'spec/services/notes/quick_actions_service_spec.rb' - 'spec/services/packages/cleanup/update_policy_service_spec.rb' + - 'spec/services/packages/composer/create_package_service_spec.rb' + - 'spec/services/packages/create_dependency_service_spec.rb' + - 'spec/services/packages/create_event_service_spec.rb' + - 'spec/services/packages/create_temporary_package_service_spec.rb' + - 'spec/services/packages/debian/find_or_create_package_service_spec.rb' + - 'spec/services/packages/debian/process_changes_service_spec.rb' + - 'spec/services/packages/generic/create_package_file_service_spec.rb' + - 'spec/services/packages/go/create_package_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/mark_package_for_destruction_service_spec.rb' + - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' + - 'spec/services/packages/npm/create_package_service_spec.rb' + - 'spec/services/packages/npm/create_tag_service_spec.rb' + - 'spec/services/packages/nuget/create_dependency_service_spec.rb' + - 'spec/services/packages/nuget/sync_metadatum_service_spec.rb' + - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' + - 'spec/services/packages/pypi/create_package_service_spec.rb' + - 'spec/services/packages/remove_tag_service_spec.rb' + - 'spec/services/packages/rubygems/create_dependencies_service_spec.rb' + - 'spec/services/packages/rubygems/metadata_extraction_service_spec.rb' + - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - 'spec/services/packages/update_package_file_service_spec.rb' + - 'spec/services/packages/update_tags_service_spec.rb' - 'spec/services/pages/delete_service_spec.rb' - 'spec/services/pages/destroy_deployments_service_spec.rb' - 'spec/services/pages_domains/retry_acme_order_service_spec.rb' - 'spec/services/personal_access_tokens/last_used_service_spec.rb' - 'spec/services/projects/auto_devops/disable_service_spec.rb' + - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/fetch_statistics_increment_service_spec.rb' - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - 'spec/services/projects/hashed_storage/rollback_service_spec.rb' + - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - 'spec/services/projects/record_target_platforms_service_spec.rb' + - 'spec/services/projects/transfer_service_spec.rb' - 'spec/services/projects/update_pages_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' @@ -594,14 +826,17 @@ RSpec/ExpectChange: - 'spec/services/users/update_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - 'spec/services/work_items/parent_links/create_service_spec.rb' + - 'spec/support/services/clusters/create_service_shared.rb' - 'spec/support/services/deploy_token_shared_examples.rb' - 'spec/support/services/issuable_import_csv_service_shared_examples.rb' - 'spec/support/shared_contexts/email_shared_context.rb' + - 'spec/support/shared_examples/controllers/clusters_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/variables_shared_examples.rb' - 'spec/support/shared_examples/graphql/mutations/boards_create_shared_examples.rb' - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - 'spec/support/shared_examples/incident_management/issuable_escalation_statuses/build_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/loose_foreign_keys/have_loose_foreign_key.rb' - 'spec/support/shared_examples/models/commit_signature_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/bulk_insert_safe_shared_examples.rb' @@ -610,17 +845,29 @@ RSpec/ExpectChange: - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/limitable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/repository_storage_movable_shared_examples.rb' + - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' - 'spec/support/shared_examples/models/member_shared_examples.rb' - 'spec/support/shared_examples/models/packages/debian/component_file_shared_example.rb' - 'spec/support/shared_examples/models/with_uploads_shared_examples.rb' - 'spec/support/shared_examples/requests/access_tokens_controller_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/mutations/destroy_list_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/read_only_instance_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/helm_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/npm_packages_tags_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/terraform/modules/v1/packages_shared_examples.rb' - 'spec/support/shared_examples/services/common_system_notes_shared_examples.rb' - 'spec/support/shared_examples/services/container_expiration_policy_shared_examples.rb' - 'spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb' + - 'spec/support/shared_examples/services/dependency_proxy_ttl_policies_shared_examples.rb' - 'spec/support/shared_examples/services/issuable_links/create_links_shared_examples.rb' - 'spec/support/shared_examples/services/merge_request_shared_examples.rb' + - 'spec/support/shared_examples/services/namespace_package_settings_shared_examples.rb' + - 'spec/support/shared_examples/services/packages_shared_examples.rb' - 'spec/support/shared_examples/services/rate_limited_service_shared_examples.rb' - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' - 'spec/support/shared_examples/services/updating_mentions_shared_examples.rb' @@ -633,14 +880,26 @@ RSpec/ExpectChange: - 'spec/tooling/rspec_flaky/listener_spec.rb' - 'spec/uploaders/file_uploader_spec.rb' - 'spec/uploaders/records_uploads_spec.rb' + - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - 'spec/workers/destroy_pages_deployments_worker_spec.rb' - 'spec/workers/environments/auto_delete_cron_worker_spec.rb' - 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb' - 'spec/workers/gitlab_service_ping_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' + - 'spec/workers/namespaces/root_statistics_worker_spec.rb' + - 'spec/workers/namespaces/schedule_aggregation_worker_spec.rb' - 'spec/workers/new_issue_worker_spec.rb' - 'spec/workers/new_merge_request_worker_spec.rb' + - 'spec/workers/packages/cleanup_package_file_worker_spec.rb' + - 'spec/workers/packages/composer/cache_cleanup_worker_spec.rb' + - 'spec/workers/packages/composer/cache_update_worker_spec.rb' + - 'spec/workers/packages/debian/process_changes_worker_spec.rb' + - 'spec/workers/packages/go/sync_packages_worker_spec.rb' + - 'spec/workers/packages/helm/extraction_worker_spec.rb' + - 'spec/workers/packages/maven/metadata/sync_worker_spec.rb' + - 'spec/workers/packages/nuget/extraction_worker_spec.rb' + - 'spec/workers/packages/rubygems/extraction_worker_spec.rb' - 'spec/workers/pages_domain_removal_cron_worker_spec.rb' - 'spec/workers/projects/post_creation_worker_spec.rb' - 'spec/workers/prune_old_events_worker_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 1551f2dc637..70b4105fc89 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -7,7 +7,6 @@ RSpec/ExpectInHook: - 'ee/spec/controllers/projects/boards_controller_spec.rb' - 'ee/spec/controllers/projects/settings/slacks_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' @@ -19,7 +18,6 @@ RSpec/ExpectInHook: - 'ee/spec/features/registrations/trial_during_signup_flow_spec.rb' - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' - - 'ee/spec/features/trials/capture_lead_spec.rb' - 'ee/spec/features/trials/select_namespace_spec.rb' - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml new file mode 100644 index 00000000000..2da0040f8ed --- /dev/null +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -0,0 +1,211 @@ +--- +RSpec/FactoryBot/AvoidCreate: + Details: grace period + Exclude: + - 'ee/spec/serializers/analytics/cycle_analytics/stage_entity_spec.rb' + - 'ee/spec/serializers/analytics/cycle_analytics/value_stream_errors_serializer_spec.rb' + - 'ee/spec/serializers/audit_event_entity_spec.rb' + - 'ee/spec/serializers/audit_event_serializer_spec.rb' + - 'ee/spec/serializers/blocking_merge_request_entity_spec.rb' + - 'ee/spec/serializers/clusters/deployment_entity_spec.rb' + - 'ee/spec/serializers/clusters/environment_entity_spec.rb' + - 'ee/spec/serializers/clusters/environment_serializer_spec.rb' + - 'ee/spec/serializers/dashboard_environment_entity_spec.rb' + - 'ee/spec/serializers/dashboard_environments_project_entity_spec.rb' + - 'ee/spec/serializers/dashboard_environments_serializer_spec.rb' + - 'ee/spec/serializers/dashboard_operations_project_entity_spec.rb' + - 'ee/spec/serializers/dependency_entity_spec.rb' + - 'ee/spec/serializers/dependency_list_serializer_spec.rb' + - 'ee/spec/serializers/ee/blob_entity_spec.rb' + - 'ee/spec/serializers/ee/build_details_entity_spec.rb' + - 'ee/spec/serializers/ee/ci/job_entity_spec.rb' + - 'ee/spec/serializers/ee/deployment_entity_spec.rb' + - 'ee/spec/serializers/ee/environment_serializer_spec.rb' + - 'ee/spec/serializers/ee/group_child_entity_spec.rb' + - 'ee/spec/serializers/ee/issue_board_entity_spec.rb' + - 'ee/spec/serializers/ee/issue_entity_spec.rb' + - 'ee/spec/serializers/ee/issue_sidebar_basic_entity_spec.rb' + - 'ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb' + - 'ee/spec/serializers/ee/merge_request_poll_cached_widget_entity_spec.rb' + - 'ee/spec/serializers/ee/note_entity_spec.rb' + - 'ee/spec/serializers/ee/user_serializer_spec.rb' + - 'ee/spec/serializers/environment_entity_spec.rb' + - 'ee/spec/serializers/epic_entity_spec.rb' + - 'ee/spec/serializers/epic_note_entity_spec.rb' + - 'ee/spec/serializers/epics/related_epic_entity_spec.rb' + - 'ee/spec/serializers/fork_namespace_entity_spec.rb' + - 'ee/spec/serializers/geo_project_registry_entity_spec.rb' + - 'ee/spec/serializers/incident_management/escalation_policy_entity_spec.rb' + - 'ee/spec/serializers/incident_management/oncall_schedule_entity_spec.rb' + - 'ee/spec/serializers/integrations/field_entity_spec.rb' + - 'ee/spec/serializers/integrations/jira_serializers/issue_detail_entity_spec.rb' + - 'ee/spec/serializers/integrations/jira_serializers/issue_entity_spec.rb' + - 'ee/spec/serializers/integrations/jira_serializers/issue_serializer_spec.rb' + - 'ee/spec/serializers/integrations/zentao_serializers/issue_entity_spec.rb' + - 'ee/spec/serializers/issuable_sidebar_extras_entity_spec.rb' + - 'ee/spec/serializers/issue_serializer_spec.rb' + - 'ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb' + - 'ee/spec/serializers/license_compliance/collapsed_comparer_entity_spec.rb' + - 'ee/spec/serializers/license_compliance/comparer_entity_spec.rb' + - 'ee/spec/serializers/licenses_list_entity_spec.rb' + - 'ee/spec/serializers/licenses_list_serializer_spec.rb' + - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb' + - 'ee/spec/serializers/member_entity_spec.rb' + - 'ee/spec/serializers/member_user_entity_spec.rb' + - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb' + - 'ee/spec/serializers/merge_request_sidebar_basic_entity_spec.rb' + - 'ee/spec/serializers/merge_request_widget_entity_spec.rb' + - 'ee/spec/serializers/pipeline_serializer_spec.rb' + - 'ee/spec/serializers/productivity_analytics_merge_request_entity_spec.rb' + - 'ee/spec/serializers/project_mirror_entity_spec.rb' + - 'ee/spec/serializers/scim_oauth_access_token_entity_spec.rb' + - 'ee/spec/serializers/security/vulnerability_report_data_entity_spec.rb' + - 'ee/spec/serializers/status_page/incident_comment_entity_spec.rb' + - 'ee/spec/serializers/status_page/incident_entity_spec.rb' + - 'ee/spec/serializers/status_page/incident_serializer_spec.rb' + - 'ee/spec/serializers/vulnerabilities/feedback_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/finding_reports_comparer_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/finding_serializer_spec.rb' + - 'ee/spec/serializers/vulnerabilities/identifier_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/request_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/response_entity_spec.rb' + - 'ee/spec/serializers/vulnerabilities/scanner_entity_spec.rb' + - 'ee/spec/serializers/vulnerability_entity_spec.rb' + - 'ee/spec/serializers/vulnerability_note_entity_spec.rb' + - 'spec/serializers/access_token_entity_base_spec.rb' + - 'spec/serializers/analytics_build_entity_spec.rb' + - 'spec/serializers/analytics_build_serializer_spec.rb' + - 'spec/serializers/analytics_issue_entity_spec.rb' + - 'spec/serializers/analytics_issue_serializer_spec.rb' + - 'spec/serializers/analytics_merge_request_serializer_spec.rb' + - 'spec/serializers/analytics_summary_serializer_spec.rb' + - 'spec/serializers/base_discussion_entity_spec.rb' + - 'spec/serializers/blob_entity_spec.rb' + - 'spec/serializers/build_action_entity_spec.rb' + - 'spec/serializers/build_artifact_entity_spec.rb' + - 'spec/serializers/build_details_entity_spec.rb' + - 'spec/serializers/ci/dag_job_entity_spec.rb' + - 'spec/serializers/ci/dag_job_group_entity_spec.rb' + - 'spec/serializers/ci/dag_pipeline_entity_spec.rb' + - 'spec/serializers/ci/dag_pipeline_serializer_spec.rb' + - 'spec/serializers/ci/dag_stage_entity_spec.rb' + - 'spec/serializers/ci/downloadable_artifact_entity_spec.rb' + - 'spec/serializers/ci/downloadable_artifact_serializer_spec.rb' + - 'spec/serializers/ci/group_variable_entity_spec.rb' + - 'spec/serializers/ci/job_entity_spec.rb' + - 'spec/serializers/ci/job_serializer_spec.rb' + - 'spec/serializers/ci/lint/result_serializer_spec.rb' + - 'spec/serializers/ci/pipeline_entity_spec.rb' + - 'spec/serializers/ci/trigger_entity_spec.rb' + - 'spec/serializers/ci/variable_entity_spec.rb' + - 'spec/serializers/cluster_application_entity_spec.rb' + - 'spec/serializers/cluster_entity_spec.rb' + - 'spec/serializers/cluster_serializer_spec.rb' + - 'spec/serializers/clusters/kubernetes_error_entity_spec.rb' + - 'spec/serializers/commit_entity_spec.rb' + - 'spec/serializers/container_repositories_serializer_spec.rb' + - 'spec/serializers/container_repository_entity_spec.rb' + - 'spec/serializers/container_tag_entity_spec.rb' + - 'spec/serializers/context_commits_diff_entity_spec.rb' + - 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb' + - 'spec/serializers/deploy_keys/deploy_key_entity_spec.rb' + - 'spec/serializers/deployment_cluster_entity_spec.rb' + - 'spec/serializers/deployment_entity_spec.rb' + - 'spec/serializers/deployment_serializer_spec.rb' + - 'spec/serializers/diff_file_base_entity_spec.rb' + - 'spec/serializers/diff_file_entity_spec.rb' + - 'spec/serializers/diff_file_metadata_entity_spec.rb' + - 'spec/serializers/diff_viewer_entity_spec.rb' + - 'spec/serializers/diffs_entity_spec.rb' + - 'spec/serializers/diffs_metadata_entity_spec.rb' + - 'spec/serializers/discussion_diff_file_entity_spec.rb' + - 'spec/serializers/discussion_entity_spec.rb' + - 'spec/serializers/environment_entity_spec.rb' + - 'spec/serializers/environment_serializer_spec.rb' + - 'spec/serializers/environment_status_entity_spec.rb' + - 'spec/serializers/evidences/evidence_entity_spec.rb' + - 'spec/serializers/evidences/release_entity_spec.rb' + - 'spec/serializers/feature_flag_entity_spec.rb' + - 'spec/serializers/feature_flag_serializer_spec.rb' + - 'spec/serializers/feature_flag_summary_entity_spec.rb' + - 'spec/serializers/feature_flag_summary_serializer_spec.rb' + - 'spec/serializers/feature_flags_client_serializer_spec.rb' + - 'spec/serializers/fork_namespace_entity_spec.rb' + - 'spec/serializers/group_access_token_entity_spec.rb' + - 'spec/serializers/group_access_token_serializer_spec.rb' + - 'spec/serializers/group_child_entity_spec.rb' + - 'spec/serializers/group_child_serializer_spec.rb' + - 'spec/serializers/group_deploy_key_entity_spec.rb' + - 'spec/serializers/group_link/group_group_link_entity_spec.rb' + - 'spec/serializers/group_link/project_group_link_entity_spec.rb' + - 'spec/serializers/group_link/project_group_link_serializer_spec.rb' + - 'spec/serializers/impersonation_access_token_entity_spec.rb' + - 'spec/serializers/impersonation_access_token_serializer_spec.rb' + - 'spec/serializers/import/manifest_provider_repo_entity_spec.rb' + - 'spec/serializers/integrations/event_entity_spec.rb' + - 'spec/serializers/integrations/field_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/artifact_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/repository_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/tag_entity_spec.rb' + - 'spec/serializers/integrations/project_entity_spec.rb' + - 'spec/serializers/issuable_sidebar_extras_entity_spec.rb' + - 'spec/serializers/issue_board_entity_spec.rb' + - 'spec/serializers/issue_entity_spec.rb' + - 'spec/serializers/issue_serializer_spec.rb' + - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' + - 'spec/serializers/jira_connect/app_data_serializer_spec.rb' + - 'spec/serializers/jira_connect/group_entity_spec.rb' + - 'spec/serializers/jira_connect/subscription_entity_spec.rb' + - 'spec/serializers/job_artifact_report_entity_spec.rb' + - 'spec/serializers/label_serializer_spec.rb' + - 'spec/serializers/lfs_file_lock_entity_spec.rb' + - 'spec/serializers/linked_project_issue_entity_spec.rb' + - 'spec/serializers/member_entity_spec.rb' + - 'spec/serializers/member_serializer_spec.rb' + - 'spec/serializers/member_user_entity_spec.rb' + - 'spec/serializers/merge_request_current_user_entity_spec.rb' + - 'spec/serializers/merge_request_diff_entity_spec.rb' + - 'spec/serializers/merge_request_for_pipeline_entity_spec.rb' + - 'spec/serializers/merge_request_metrics_helper_spec.rb' + - 'spec/serializers/merge_request_poll_cached_widget_entity_spec.rb' + - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' + - 'spec/serializers/merge_request_serializer_spec.rb' + - 'spec/serializers/merge_request_sidebar_basic_entity_spec.rb' + - 'spec/serializers/merge_request_sidebar_extras_entity_spec.rb' + - 'spec/serializers/merge_request_user_entity_spec.rb' + - 'spec/serializers/merge_request_widget_commit_entity_spec.rb' + - 'spec/serializers/merge_request_widget_entity_spec.rb' + - 'spec/serializers/merge_requests/pipeline_entity_spec.rb' + - 'spec/serializers/namespace_basic_entity_spec.rb' + - 'spec/serializers/note_entity_spec.rb' + - 'spec/serializers/paginated_diff_entity_spec.rb' + - 'spec/serializers/personal_access_token_entity_spec.rb' + - 'spec/serializers/personal_access_token_serializer_spec.rb' + - 'spec/serializers/pipeline_details_entity_spec.rb' + - 'spec/serializers/pipeline_serializer_spec.rb' + - 'spec/serializers/project_access_token_entity_spec.rb' + - 'spec/serializers/project_access_token_serializer_spec.rb' + - 'spec/serializers/project_import_entity_spec.rb' + - 'spec/serializers/project_mirror_entity_spec.rb' + - 'spec/serializers/project_note_entity_spec.rb' + - 'spec/serializers/project_serializer_spec.rb' + - 'spec/serializers/prometheus_alert_entity_spec.rb' + - 'spec/serializers/release_serializer_spec.rb' + - 'spec/serializers/remote_mirror_entity_spec.rb' + - 'spec/serializers/review_app_setup_entity_spec.rb' + - 'spec/serializers/runner_entity_spec.rb' + - 'spec/serializers/serverless/domain_entity_spec.rb' + - 'spec/serializers/stage_entity_spec.rb' + - 'spec/serializers/stage_serializer_spec.rb' + - 'spec/serializers/suggestion_entity_spec.rb' + - 'spec/serializers/test_case_entity_spec.rb' + - 'spec/serializers/test_report_entity_spec.rb' + - 'spec/serializers/test_report_summary_entity_spec.rb' + - 'spec/serializers/test_suite_entity_spec.rb' + - 'spec/serializers/test_suite_summary_entity_spec.rb' + - 'spec/serializers/trigger_variable_entity_spec.rb' + - 'spec/serializers/user_entity_spec.rb' + - 'spec/serializers/user_serializer_spec.rb' + - 'spec/serializers/web_ide_terminal_entity_spec.rb' + - 'spec/serializers/web_ide_terminal_serializer_spec.rb' diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml new file mode 100644 index 00000000000..3cf0e969c34 --- /dev/null +++ b/.rubocop_todo/rspec/file_path.yml @@ -0,0 +1,67 @@ +--- +RSpec/FilePath: + Details: grace period + Exclude: + - 'ee/spec/frontend/fixtures/analytics/charts.rb' + - 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb' + - 'ee/spec/frontend/fixtures/analytics/metrics.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_code_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_issue_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_plan_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_review_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_staging_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_test_stage.rb' + - 'ee/spec/frontend/fixtures/dora/metrics.rb' + - 'ee/spec/models/merge_request/blocking_spec.rb' + - 'ee/spec/requests/api/ci/runner/jobs_put_spec.rb' + - 'ee/spec/requests/api/ci/runner/jobs_trace_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/cross_needs_artifacts_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/limit_active_jobs_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/needs_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/runnable_builds_spec.rb' + - 'spec/benchmarks/banzai_benchmark.rb' + - 'spec/docs_screenshots/container_registry_docs.rb' + - 'spec/docs_screenshots/wiki_docs.rb' + - 'spec/lib/error_tracking/sentry_client/event_spec.rb' + - 'spec/lib/gitlab/import_export/import_export_equivalence_spec.rb' + - 'spec/lib/gitlab/import_export/import_export_spec.rb' + - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' + - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' + - 'spec/requests/api/ci/runner/jobs_put_spec.rb' + - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/ci/runner/jobs_trace_spec.rb' + - 'spec/requests/api/ci/runner/runners_delete_spec.rb' + - 'spec/requests/api/ci/runner/runners_post_spec.rb' + - 'spec/requests/api/ci/runner/runners_reset_spec.rb' + - 'spec/requests/api/ci/runner/runners_verify_post_spec.rb' + - 'spec/requests/api/issues/get_group_issues_spec.rb' + - 'spec/requests/api/issues/get_project_issues_spec.rb' + - 'spec/requests/api/issues/issues_spec.rb' + - 'spec/requests/api/issues/post_projects_issues_spec.rb' + - 'spec/requests/api/issues/put_projects_issues_spec.rb' + - 'spec/requests/api/pages/pages_spec.rb' + - 'spec/services/ci/create_pipeline_service/artifacts_spec.rb' + - 'spec/services/ci/create_pipeline_service/cache_spec.rb' + - 'spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb' + - 'spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb' + - 'spec/services/ci/create_pipeline_service/custom_config_content_spec.rb' + - 'spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb' + - 'spec/services/ci/create_pipeline_service/dry_run_spec.rb' + - 'spec/services/ci/create_pipeline_service/environment_spec.rb' + - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' + - 'spec/services/ci/create_pipeline_service/include_spec.rb' + - 'spec/services/ci/create_pipeline_service/limit_active_jobs_spec.rb' + - 'spec/services/ci/create_pipeline_service/logger_spec.rb' + - 'spec/services/ci/create_pipeline_service/merge_requests_spec.rb' + - 'spec/services/ci/create_pipeline_service/needs_spec.rb' + - 'spec/services/ci/create_pipeline_service/parallel_spec.rb' + - 'spec/services/ci/create_pipeline_service/parameter_content_spec.rb' + - 'spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb' + - 'spec/services/ci/create_pipeline_service/partitioning_spec.rb' + - 'spec/services/ci/create_pipeline_service/pre_post_stages_spec.rb' + - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' + - 'spec/services/ci/create_pipeline_service/rules_spec.rb' + - 'spec/services/ci/create_pipeline_service/tags_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index df62a8b0f87..2cc146a0625 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -171,7 +171,6 @@ RSpec/InstanceVariable: - spec/requests/openid_connect_spec.rb - spec/requests/projects/issues/discussions_spec.rb - spec/rubocop/cop/migration/update_column_in_batches_spec.rb - - spec/serializers/pipeline_serializer_spec.rb - spec/services/ci/create_pipeline_service/logger_spec.rb - spec/services/ci/process_sync_events_service_spec.rb - spec/services/labels/update_service_spec.rb diff --git a/.rubocop_todo/rspec/let_before_examples.yml b/.rubocop_todo/rspec/let_before_examples.yml new file mode 100644 index 00000000000..f84df4bdb5f --- /dev/null +++ b/.rubocop_todo/rspec/let_before_examples.yml @@ -0,0 +1,17 @@ +--- +# Cop supports --auto-correct. +RSpec/LetBeforeExamples: + Exclude: + - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' + - 'ee/spec/models/resource_weight_event_spec.rb' + - 'ee/spec/models/vulnerabilities/feedback_spec.rb' + - 'ee/spec/requests/api/internal/kubernetes_spec.rb' + - 'ee/spec/requests/api/scim_spec.rb' + - 'spec/graphql/types/ci/detailed_status_type_spec.rb' + - 'spec/graphql/types/merge_request_type_spec.rb' + - 'spec/graphql/types/snippets/blob_type_spec.rb' + - 'spec/models/ci/job_token/project_scope_link_spec.rb' + - 'spec/models/ci/runner_version_spec.rb' + - 'spec/models/group_deploy_key_spec.rb' + - 'spec/models/snippet_repository_spec.rb' + - 'spec/requests/api/issue_links_spec.rb' diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml index 8330d768794..218ec3bb478 100644 --- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml +++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml @@ -1,9 +1,39 @@ --- RSpec/MultipleMemoizedHelpers: + Details: grace period Exclude: - - spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb - - spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb - - spec/requests/api/ci/runner/jobs_artifacts_spec.rb - - ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb - - ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb - - ee/spec/services/ee/boards/issues/move_service_spec.rb + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' + - 'ee/spec/finders/epics_finder_spec.rb' + - 'ee/spec/finders/incident_management/oncall_users_finder_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' + - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' + - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' + - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' + - 'ee/spec/services/ee/boards/issues/move_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' + - 'spec/features/boards/boards_spec.rb' + - 'spec/finders/ci/runners_finder_spec.rb' + - 'spec/finders/labels_finder_spec.rb' + - 'spec/finders/user_recent_events_finder_spec.rb' + - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' + - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' + - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb' + - 'spec/models/event_spec.rb' + - 'spec/models/milestone_spec.rb' + - 'spec/models/packages/package_file_spec.rb' + - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' + - 'spec/requests/api/issues/get_group_issues_spec.rb' + - 'spec/requests/api/issues/get_project_issues_spec.rb' + - 'spec/requests/api/issues/issues_spec.rb' + - 'spec/requests/api/issues/put_projects_issues_spec.rb' + - 'spec/requests/api/maven_packages_spec.rb' + - 'spec/services/boards/issues/list_service_spec.rb' + - 'spec/services/labels/promote_service_spec.rb' + - 'spec/services/merge_requests/push_options_handler_service_spec.rb' + - 'spec/services/packages/cleanup/execute_policy_service_spec.rb' + - 'spec/services/todo_service_spec.rb' + - 'spec/services/todos/allowed_target_filter_service_spec.rb' + - 'spec/services/todos/destroy/entity_leave_service_spec.rb' + - 'spec/support/shared_contexts/policies/project_policy_shared_context.rb' + - 'spec/support/shared_contexts/requests/api/debian_repository_shared_context.rb' diff --git a/.rubocop_todo/rspec/overwriting_setup.yml b/.rubocop_todo/rspec/overwriting_setup.yml new file mode 100644 index 00000000000..630f08eb72f --- /dev/null +++ b/.rubocop_todo/rspec/overwriting_setup.yml @@ -0,0 +1,17 @@ +--- +RSpec/OverwritingSetup: + Exclude: + - 'ee/spec/features/groups/analytics/ci_cd_analytics_spec.rb' + - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb' + - 'ee/spec/models/ee/iteration_spec.rb' + - 'ee/spec/requests/api/namespaces_spec.rb' + - 'ee/spec/services/epics/descendant_count_service_spec.rb' + - 'spec/finders/packages/helm/packages_finder_spec.rb' + - 'spec/finders/packages/npm/package_finder_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' + - 'spec/models/packages/package_file_spec.rb' + - 'spec/models/todo_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/policies/ci/build_policy_spec.rb' + - 'spec/services/packages/nuget/search_service_spec.rb' + - 'spec/services/projects/container_repository/gitlab/cleanup_tags_service_spec.rb' diff --git a/.rubocop_todo/rspec/predicate_matcher.yml b/.rubocop_todo/rspec/predicate_matcher.yml index f3cfe93191d..5847080dcde 100644 --- a/.rubocop_todo/rspec/predicate_matcher.yml +++ b/.rubocop_todo/rspec/predicate_matcher.yml @@ -99,8 +99,6 @@ RSpec/PredicateMatcher: - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' - 'ee/spec/services/milestones/promote_service_spec.rb' - 'ee/spec/services/protected_environments/create_service_spec.rb' - - 'ee/spec/services/vulnerabilities/create_from_security_finding_service_spec.rb' - - 'ee/spec/services/vulnerabilities/findings/create_from_security_finding_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - 'ee/spec/support/shared_examples/graphql/mutations/dast_on_demand_scans_shared_examples.rb' @@ -414,7 +412,6 @@ RSpec/PredicateMatcher: - 'spec/requests/api/users_spec.rb' - 'spec/requests/git_http_spec.rb' - 'spec/requests/lfs_http_spec.rb' - - 'spec/serializers/pipeline_serializer_spec.rb' - 'spec/services/branches/create_service_spec.rb' - 'spec/services/ci/create_pipeline_service/needs_spec.rb' - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' @@ -499,7 +496,6 @@ RSpec/PredicateMatcher: - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/uploaders/object_storage_spec.rb' - 'spec/validators/any_field_validator_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 93f373b0a9e..61f1a09589f 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -1,123 +1,144 @@ --- # Cop supports --auto-correct. RSpec/ScatteredLet: + Details: grace period Exclude: + - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/groups/group_roadmap_spec.rb' - - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb' + - 'ee/spec/features/milestones/user_views_milestone_spec.rb' + - 'ee/spec/finders/analytics/devops_adoption/enabled_namespaces_finder_spec.rb' + - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' + - 'ee/spec/finders/issues_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - - 'ee/spec/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' + - 'ee/spec/frontend/fixtures/runner.rb' + - 'ee/spec/graphql/ee/types/clusters/agent_type_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - - 'ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/accept_spec.rb' - 'ee/spec/graphql/mutations/releases/update_spec.rb' + - 'ee/spec/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' + - 'ee/spec/graphql/types/asset_type_spec.rb' - 'ee/spec/graphql/types/boards/board_epic_type_spec.rb' - 'ee/spec/graphql/types/instance_security_dashboard_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_evidence_source_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_evidence_supporting_message_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_evidence_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' + - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - - 'ee/spec/helpers/trial_status_widget_helper_spec.rb' + - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' + - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/config_spec.rb' - - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' + - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - - 'ee/spec/lib/gitlab/ci/parsers/security/formatters/dependency_list_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/code_owners/loader_spec.rb' - 'ee/spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb' - 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb' - 'ee/spec/lib/gitlab/insights/reducers/count_per_label_reducer_spec.rb' - 'ee/spec/lib/gitlab/insights/reducers/label_count_per_period_reducer_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/approval_project_rules_with_user_metric_spec.rb' - 'ee/spec/lib/gitlab/usage_data_metrics_spec.rb' - - 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb' - 'ee/spec/models/approval_wrapped_any_approver_rule_spec.rb' - - 'ee/spec/models/approvals/scan_finding_wrapped_rule_set_spec.rb' - - 'ee/spec/models/ci/minutes/notification_spec.rb' - - 'ee/spec/models/ci/pipeline_spec.rb' + - 'ee/spec/models/dast_site_validation_spec.rb' - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - - 'ee/spec/models/label_note_spec.rb' - - 'ee/spec/models/sca/license_compliance_spec.rb' - - 'ee/spec/policies/merge_request_policy_spec.rb' + - 'ee/spec/models/ee/iteration_spec.rb' + - 'ee/spec/models/ee/user_spec.rb' + - 'ee/spec/models/epic_spec.rb' + - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' + - 'ee/spec/models/vulnerabilities/historical_statistic_spec.rb' + - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - 'ee/spec/requests/api/graphql/compliance_management/merge_requests/compliance_violations_spec.rb' - 'ee/spec/requests/api/graphql/group/ci_cd_settings_spec.rb' - 'ee/spec/requests/api/graphql/group/epic/notes_spec.rb' - - 'ee/spec/requests/api/graphql/group_query_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' + - 'ee/spec/requests/api/graphql/instance_security_dashboard_spec.rb' - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/update_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/security_policy/commit_scan_execution_policy_spec.rb' - - 'ee/spec/requests/api/graphql/project/alert_management/http_integrations_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/projects/set_compliance_framework_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security/finding/create_issue_spec.rb' - 'ee/spec/requests/api/graphql/project/dast_profile_schedule_spec.rb' + - 'ee/spec/requests/api/graphql/project/environments_spec.rb' - 'ee/spec/requests/api/graphql/project/pipeline/dast_profile_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/security_report_finding_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' - 'ee/spec/requests/api/graphql/project/pipelines/dast_profile_spec.rb' - - 'ee/spec/requests/api/internal/base_spec.rb' - - 'ee/spec/requests/api/projects_spec.rb' + - 'ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb' + - 'ee/spec/requests/api/graphql/project/requirements_management/test_reports_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/details_spec.rb' + - 'ee/spec/requests/api/group_boards_spec.rb' + - 'ee/spec/requests/api/project_push_rule_spec.rb' - 'ee/spec/requests/api/settings_spec.rb' - 'ee/spec/requests/api/vulnerability_findings_spec.rb' - - 'ee/spec/requests/git_http_geo_spec.rb' - - 'ee/spec/serializers/license_compliance/collapsed_comparer_entity_spec.rb' - - 'ee/spec/serializers/status_page/incident_serializer_spec.rb' + - 'ee/spec/services/analytics/devops_adoption/snapshots/calculate_and_save_service_spec.rb' - 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/update_service_spec.rb' - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/arkose/user_verification_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' + - 'ee/spec/services/boards/epics/move_service_spec.rb' + - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' + - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' + - 'ee/spec/services/concerns/epics/related_epic_links/usage_data_helper_spec.rb' - 'ee/spec/services/ee/issue_links/create_service_spec.rb' + - 'ee/spec/services/ee/issues/create_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/base_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_reviewers_service_spec.rb' - 'ee/spec/services/epic_issues/create_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/activate_service_spec.rb' + - 'ee/spec/services/geo/metrics_update_service_spec.rb' - 'ee/spec/services/group_saml/saml_provider/create_service_spec.rb' - 'ee/spec/services/group_saml/saml_provider/update_service_spec.rb' - 'ee/spec/services/groups/memberships/export_service_spec.rb' - 'ee/spec/services/incident_management/escalation_policies/create_service_spec.rb' - 'ee/spec/services/incident_management/oncall_rotations/remove_participant_service_spec.rb' - - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - - 'ee/spec/services/projects/destroy_service_spec.rb' - - 'ee/spec/services/projects/prometheus/alerts/notify_service_spec.rb' - - 'ee/spec/services/quality_management/test_cases/create_service_spec.rb' - - 'ee/spec/services/quick_actions/interpret_service_spec.rb' - - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb' - - 'ee/spec/services/search/group_service_spec.rb' - - 'ee/spec/services/search/project_service_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - - 'ee/spec/services/todo_service_spec.rb' - - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' + - 'ee/spec/services/members/activate_service_spec.rb' + - 'ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb' + - 'ee/spec/services/sbom/ingestion/occurrence_map_spec.rb' + - 'ee/spec/services/security/report_summary_service_spec.rb' + - 'ee/spec/services/vulnerabilities/security_finding/create_issue_service_spec.rb' - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - - 'ee/spec/workers/compliance_management/merge_requests/compliance_violations_worker_spec.rb' - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - - 'spec/controllers/projects/artifacts_controller_spec.rb' + - 'spec/controllers/concerns/metrics_dashboard_spec.rb' + - 'spec/controllers/import/bitbucket_server_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - 'spec/controllers/projects/environments_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - - 'spec/controllers/projects/releases/evidences_controller_spec.rb' - - 'spec/controllers/projects/releases_controller_spec.rb' - - 'spec/finders/ci/daily_build_group_report_results_finder_spec.rb' + - 'spec/controllers/projects/jobs_controller_spec.rb' + - 'spec/features/boards/user_visits_board_spec.rb' + - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' + - 'spec/features/issues/user_filters_issues_spec.rb' - 'spec/finders/concerns/finder_with_cross_project_access_spec.rb' - - 'spec/finders/concerns/finder_with_group_hierarchy_spec.rb' - - 'spec/finders/events_finder_spec.rb' - 'spec/finders/group_projects_finder_spec.rb' + - 'spec/finders/groups/user_groups_finder_spec.rb' - 'spec/finders/license_template_finder_spec.rb' - - 'spec/frontend/fixtures/pipelines.rb' - - 'spec/graphql/resolvers/commit_pipelines_resolver_spec.rb' + - 'spec/finders/projects/groups_finder_spec.rb' + - 'spec/frontend/fixtures/jobs.rb' + - 'spec/graphql/resolvers/clusters/agents_resolver_spec.rb' + - 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb' + - 'spec/graphql/resolvers/concerns/resolves_project_spec.rb' - 'spec/graphql/resolvers/design_management/version_in_collection_resolver_spec.rb' - - 'spec/graphql/resolvers/design_management/versions_resolver_spec.rb' + - 'spec/graphql/resolvers/group_milestones_resolver_spec.rb' + - 'spec/graphql/resolvers/users/groups_resolver_spec.rb' + - 'spec/graphql/types/base_object_spec.rb' - 'spec/graphql/types/ci/job_token_scope_type_spec.rb' + - 'spec/graphql/types/environment_type_spec.rb' + - 'spec/graphql/types/merge_request_type_spec.rb' + - 'spec/graphql/types/project_type_spec.rb' + - 'spec/graphql/types/terraform/state_version_type_spec.rb' + - 'spec/graphql/types/user_type_spec.rb' + - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/merge_requests_helper_spec.rb' + - 'spec/lib/atlassian/jira_connect/jwt/asymmetric_spec.rb' - 'spec/lib/banzai/filter/references/project_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/upload_link_filter_spec.rb' - 'spec/lib/banzai/reference_parser/alert_parser_spec.rb' - 'spec/lib/banzai/reference_parser/commit_parser_spec.rb' - 'spec/lib/banzai/reference_parser/commit_range_parser_spec.rb' + - 'spec/lib/banzai/reference_parser/design_parser_spec.rb' - 'spec/lib/banzai/reference_parser/external_issue_parser_spec.rb' - 'spec/lib/banzai/reference_parser/label_parser_spec.rb' - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' @@ -125,32 +146,29 @@ RSpec/ScatteredLet: - 'spec/lib/banzai/reference_parser/project_parser_spec.rb' - 'spec/lib/banzai/reference_parser/snippet_parser_spec.rb' - 'spec/lib/banzai/reference_parser/user_parser_spec.rb' + - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' - 'spec/lib/bulk_imports/pipeline/runner_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb' - 'spec/lib/gitlab/asciidoc/include_processor_spec.rb' - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' - - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' + - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' + - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/status/stage/factory_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder/group_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder/project_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb' - - 'spec/lib/gitlab/database/background_migration/batched_migration_wrapper_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - 'spec/lib/gitlab/database/migrations/test_batched_background_runner_spec.rb' - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database/postgresql_adapter/empty_query_ping_spec.rb' - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' - 'spec/lib/gitlab/diff/file_collection/merge_request_diff_batch_spec.rb' @@ -160,41 +178,43 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/lib/gitlab/diff/suggestion_diff_spec.rb' - 'spec/lib/gitlab/diff/suggestion_spec.rb' - - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/error_tracking/processor/context_payload_processor_spec.rb' - - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/git/blame_spec.rb' - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git_access_spec.rb' - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_events_importer_spec.rb' - - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' - 'spec/lib/gitlab/import_export/group/relation_tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/project/export_task_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_tree_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb' - 'spec/lib/gitlab/jira_import/issue_serializer_spec.rb' - 'spec/lib/gitlab/lets_encrypt/client_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/stages/grafana_formatter_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/external_http_spec.rb' - 'spec/lib/gitlab/middleware/memory_report_spec.rb' - - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' - 'spec/lib/gitlab/pagination/keyset/page_spec.rb' - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/patch/database_config_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' + - 'spec/lib/gitlab/relative_positioning/item_context_spec.rb' + - 'spec/lib/gitlab/relative_positioning/mover_spec.rb' - 'spec/lib/gitlab/serializer/pagination_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/extra_done_log_metadata_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/validator_spec.rb' - - 'spec/lib/gitlab/spamcheck/client_spec.rb' - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb' - 'spec/lib/gitlab/usage_data_metrics_spec.rb' + - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/measuring_spec.rb' - 'spec/lib/gitlab/zentao/client_spec.rb' - 'spec/lib/peek/views/external_http_spec.rb' - 'spec/mailers/emails/in_product_marketing_spec.rb' - - 'spec/migrations/20210421163509_schedule_update_jira_tracker_data_deployment_type_based_on_url_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/mailers/previews_spec.rb' - 'spec/migrations/20220329175119_remove_leftover_ci_job_artifact_deletions_spec.rb' - - 'spec/models/application_record_spec.rb' + - 'spec/models/ci/bridge_spec.rb' - 'spec/models/ci/build_dependencies_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/concerns/issuable_spec.rb' @@ -203,68 +223,61 @@ RSpec/ScatteredLet: - 'spec/models/deploy_keys_project_spec.rb' - 'spec/models/design_management/design_at_version_spec.rb' - 'spec/models/diff_note_spec.rb' - - 'spec/models/environment_spec.rb' - 'spec/models/integration_spec.rb' - - 'spec/models/merge_request_diff_spec.rb' - 'spec/models/merge_request_spec.rb' - - 'spec/models/milestone_spec.rb' - 'spec/models/push_event_spec.rb' + - 'spec/models/snippet_repository_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - 'spec/models/user_spec.rb' - 'spec/models/users/credit_card_validation_spec.rb' - 'spec/models/wiki_page_spec.rb' - - 'spec/policies/ci/build_policy_spec.rb' - - 'spec/policies/design_management/design_policy_spec.rb' - 'spec/policies/group_member_policy_spec.rb' - 'spec/requests/admin/background_migrations_controller_spec.rb' + - 'spec/requests/api/ci/jobs_spec.rb' - 'spec/requests/api/ci/pipeline_schedules_spec.rb' - - 'spec/requests/api/ci/pipelines_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' - - 'spec/requests/api/graphql/ci/groups_spec.rb' - - 'spec/requests/api/graphql/ci/pipelines_spec.rb' + - 'spec/requests/api/graphql/ci/runners_spec.rb' + - 'spec/requests/api/graphql/group/work_item_types_spec.rb' + - 'spec/requests/api/graphql/milestone_spec.rb' - 'spec/requests/api/graphql/mutations/boards/create_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/delete_task_spec.rb' - 'spec/requests/api/graphql/namespace/projects_spec.rb' + - 'spec/requests/api/graphql/project/deployment_spec.rb' + - 'spec/requests/api/graphql/project/environments_spec.rb' - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' - 'spec/requests/api/graphql/project/issue/design_collection/versions_spec.rb' - 'spec/requests/api/graphql/project/issue_spec.rb' + - 'spec/requests/api/graphql/project/jira_projects_spec.rb' + - 'spec/requests/api/graphql/project/merge_request/diff_notes_spec.rb' - 'spec/requests/api/graphql/project/milestones_spec.rb' - - 'spec/requests/api/graphql/project/pipeline_spec.rb' - - 'spec/requests/api/graphql/project/release_spec.rb' - - 'spec/requests/api/graphql/user/starred_projects_query_spec.rb' + - 'spec/requests/api/graphql/project/work_item_types_spec.rb' + - 'spec/requests/api/graphql/todo_query_spec.rb' + - 'spec/requests/api/group_boards_spec.rb' - 'spec/requests/api/issues/get_group_issues_spec.rb' - - 'spec/requests/api/issues/get_project_issues_spec.rb' - - 'spec/requests/api/issues/post_projects_issues_spec.rb' - - 'spec/requests/api/issues/put_projects_issues_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/notes_spec.rb' - 'spec/requests/api/project_clusters_spec.rb' - - 'spec/requests/api/project_export_spec.rb' - - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/jira_routing_spec.rb' - - 'spec/requests/projects/releases_controller_spec.rb' - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/build_details_entity_spec.rb' - 'spec/serializers/ci/job_entity_spec.rb' - 'spec/serializers/merge_requests/pipeline_entity_spec.rb' - - 'spec/services/ci/change_variable_service_spec.rb' - - 'spec/services/ci/change_variables_service_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' + - 'spec/services/ci/create_pipeline_service/include_spec.rb' - 'spec/services/ci/create_pipeline_service/logger_spec.rb' + - 'spec/services/ci/create_pipeline_service/rules_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/destroy_pipeline_service_spec.rb' - - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - - 'spec/services/ci/pipeline_bridge_status_service_spec.rb' - - 'spec/services/commits/cherry_pick_service_spec.rb' - 'spec/services/design_management/delete_designs_service_spec.rb' - 'spec/services/design_management/save_designs_service_spec.rb' - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' - 'spec/services/events/destroy_service_spec.rb' - 'spec/services/git/base_hooks_service_spec.rb' - - 'spec/services/groups/group_links/update_service_spec.rb' - - 'spec/services/jira_import/cloud_users_mapper_service_spec.rb' - - 'spec/services/jira_import/server_users_mapper_service_spec.rb' - - 'spec/services/lfs/push_service_spec.rb' + - 'spec/services/issues/create_service_spec.rb' + - 'spec/services/merge_requests/mergeability/logger_spec.rb' + - 'spec/services/merge_requests/update_assignees_service_spec.rb' + - 'spec/services/merge_requests/update_reviewers_service_spec.rb' - 'spec/services/metrics/dashboard/custom_metric_embed_service_spec.rb' - 'spec/services/metrics/dashboard/dynamic_embed_service_spec.rb' - 'spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb' @@ -272,19 +285,18 @@ RSpec/ScatteredLet: - 'spec/services/notification_service_spec.rb' - 'spec/services/packages/composer/create_package_service_spec.rb' - 'spec/services/packages/conan/create_package_file_service_spec.rb' + - 'spec/services/packages/debian/create_distribution_service_spec.rb' - 'spec/services/packages/debian/create_package_file_service_spec.rb' - 'spec/services/packages/debian/generate_distribution_key_service_spec.rb' - 'spec/services/packages/debian/update_distribution_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - 'spec/services/snippets/create_service_spec.rb' - - 'spec/services/spam/spam_verdict_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/system_notes/merge_requests_service_spec.rb' + - 'spec/services/system_notes/time_tracking_service_spec.rb' - 'spec/services/todo_service_spec.rb' - - 'spec/services/web_hook_service_spec.rb' - - 'spec/services/work_items/update_service_spec.rb' - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb' - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb' - - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' + - 'spec/workers/environments/auto_stop_worker_spec.rb' - 'spec/workers/packages/debian/generate_distribution_worker_spec.rb' diff --git a/.rubocop_todo/rspec/variable_definition.yml b/.rubocop_todo/rspec/variable_definition.yml new file mode 100644 index 00000000000..797fa763ba1 --- /dev/null +++ b/.rubocop_todo/rspec/variable_definition.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +RSpec/VariableDefinition: + Exclude: + - 'spec/lib/gitlab/usage_data_spec.rb' + - 'spec/presenters/packages/npm/package_presenter_spec.rb' diff --git a/.rubocop_todo/rspec/variable_name.yml b/.rubocop_todo/rspec/variable_name.yml new file mode 100644 index 00000000000..8858fbd9eb7 --- /dev/null +++ b/.rubocop_todo/rspec/variable_name.yml @@ -0,0 +1,4 @@ +--- +RSpec/VariableName: + Exclude: + - 'spec/models/user_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index a225dbf21ae..c9f405a8283 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -67,7 +67,6 @@ RSpec/VerifiedDoubles: - ee/spec/lib/gitlab/authority_analyzer_spec.rb - ee/spec/lib/gitlab/cache_spec.rb - ee/spec/lib/gitlab/ci/pipeline/chain/limit/activity_spec.rb - - ee/spec/lib/gitlab/ci/pipeline/chain/limit/job_activity_spec.rb - ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb - ee/spec/lib/gitlab/code_owners/groups_loader_spec.rb - ee/spec/lib/gitlab/code_owners/users_loader_spec.rb diff --git a/.rubocop_todo/style/accessor_grouping.yml b/.rubocop_todo/style/accessor_grouping.yml index 821e3398301..a2ba217dbcc 100644 --- a/.rubocop_todo/style/accessor_grouping.yml +++ b/.rubocop_todo/style/accessor_grouping.yml @@ -1,9 +1,7 @@ --- # Cop supports --auto-correct. Style/AccessorGrouping: - # Offense count: 254 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/finders/template_finder.rb' - 'app/models/commit.rb' @@ -23,7 +21,6 @@ Style/AccessorGrouping: - 'app/models/project.rb' - 'app/services/deployments/update_environment_service.rb' - 'app/services/issues/clone_service.rb' - - 'app/services/merge_requests/bulk_remove_attention_requested_service.rb' - 'app/services/note_summary.rb' - 'app/services/notification_recipients/builder/default.rb' - 'app/services/task_list_toggle_service.rb' @@ -38,6 +35,7 @@ Style/AccessorGrouping: - 'ee/lib/gitlab/ci/reports/security/locations/dast.rb' - 'ee/lib/gitlab/ci/reports/security/locations/dependency_scanning.rb' - 'lib/feature/definition.rb' + - 'lib/gitlab/audit/type/definition.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/ci/config/external/context.rb' - 'lib/gitlab/ci/reports/security/finding.rb' @@ -65,7 +63,6 @@ Style/AccessorGrouping: - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/suggestions/file_suggestion.rb' - 'lib/gitlab/tracking/event_definition.rb' - - 'lib/gitlab/tree_summary.rb' - 'lib/gitlab/usage/metric_definition.rb' - 'lib/gitlab/usage/metrics/instrumentations/base_metric.rb' - 'lib/gitlab/usage/service_ping/instrumented_payload.rb' diff --git a/.rubocop_todo/style/case_like_if.yml b/.rubocop_todo/style/case_like_if.yml index 119ca3d800f..61f2e6bc238 100644 --- a/.rubocop_todo/style/case_like_if.yml +++ b/.rubocop_todo/style/case_like_if.yml @@ -1,9 +1,7 @@ --- # Cop supports --auto-correct. Style/CaseLikeIf: - # Offense count: 60 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/groups/dependency_proxy/application_controller.rb' @@ -13,6 +11,7 @@ Style/CaseLikeIf: - 'app/helpers/broadcast_messages_helper.rb' - 'app/helpers/issues_helper.rb' - 'app/helpers/routing/pseudonymization_helper.rb' + - 'app/helpers/todos_helper.rb' - 'app/models/integrations/jira.rb' - 'app/models/members/member_task.rb' - 'app/models/namespace.rb' @@ -21,8 +20,11 @@ Style/CaseLikeIf: - 'app/services/google_cloud/generate_pipeline_service.rb' - 'app/services/issuable/bulk_update_service.rb' - 'app/services/todo_service.rb' + - 'app/services/user_project_access_changed_service.rb' - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' - 'ee/app/finders/ee/notes_finder.rb' + - 'ee/app/finders/security/scan_execution_policies_finder.rb' + - 'ee/app/finders/security/training_providers/secure_code_warrior_url_finder.rb' - 'ee/app/helpers/ee/branches_helper.rb' - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/merge_request_approval_settings/update_service.rb' @@ -43,18 +45,18 @@ Style/CaseLikeIf: - 'lib/gitlab/utils/strong_memoize.rb' - 'qa/qa/git/repository.rb' - 'qa/qa/scenario/bootable.rb' - - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - 'spec/features/boards/user_adds_lists_to_board_spec.rb' - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - 'spec/models/concerns/sha_attribute_spec.rb' - 'spec/models/preloaders/labels_preloader_spec.rb' + - 'spec/requests/api/personal_access_tokens_spec.rb' - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' + - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - 'spec/services/resource_events/change_state_service_spec.rb' - 'spec/support/helpers/filter_spec_helper.rb' - - 'spec/support/matchers/abort_matcher.rb' - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index 2674902c7ee..bff827ba5d3 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -521,6 +521,7 @@ Style/ClassAndModuleChildren: - 'ee/db/fixtures/development/21_dast_profiles.rb' - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb' - 'ee/db/fixtures/development/32_compliance_report_violations.rb' + - 'ee/db/fixtures/development/35_merge_request_predictions.rb' - 'ee/db/fixtures/development/90_productivity_analytics.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/base_query_builder.rb' diff --git a/.rubocop_todo/style/conditional_assignment.yml b/.rubocop_todo/style/conditional_assignment.yml new file mode 100644 index 00000000000..c9bbaaeb175 --- /dev/null +++ b/.rubocop_todo/style/conditional_assignment.yml @@ -0,0 +1,5 @@ +--- +# Cop supports --auto-correct. +Style/ConditionalAssignment: + Exclude: + - 'app/helpers/icons_helper.rb' diff --git a/.rubocop_todo/style/each_for_simple_loop.yml b/.rubocop_todo/style/each_for_simple_loop.yml new file mode 100644 index 00000000000..5d495f890d2 --- /dev/null +++ b/.rubocop_todo/style/each_for_simple_loop.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Style/EachForSimpleLoop: + Exclude: + - 'ee/spec/lib/gitlab/insights/reducers/count_per_period_reducer_spec.rb' + - 'spec/services/members/invitation_reminder_email_service_spec.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 3e6a1efec70..7fbec98ead5 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -1,16 +1,12 @@ --- # Cop supports --auto-correct. Style/EmptyMethod: - # Offense count: 240 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/controllers/admin/application_settings/appearances_controller.rb' - 'app/controllers/admin/applications_controller.rb' - 'app/controllers/admin/broadcast_messages_controller.rb' - 'app/controllers/admin/deploy_keys_controller.rb' - - 'app/controllers/admin/hook_logs_controller.rb' - - 'app/controllers/admin/hooks_controller.rb' - 'app/controllers/admin/identities_controller.rb' - 'app/controllers/admin/labels_controller.rb' - 'app/controllers/admin/runners_controller.rb' @@ -35,13 +31,11 @@ Style/EmptyMethod: - 'app/controllers/projects/alert_management_controller.rb' - 'app/controllers/projects/ci/lints_controller.rb' - 'app/controllers/projects/ci/pipeline_editor_controller.rb' - - 'app/controllers/projects/ci/secure_files_controller.rb' - 'app/controllers/projects/confluences_controller.rb' - 'app/controllers/projects/deploy_keys_controller.rb' - 'app/controllers/projects/environments_controller.rb' - 'app/controllers/projects/feature_flags_controller.rb' - 'app/controllers/projects/feature_flags_user_lists_controller.rb' - - 'app/controllers/projects/hook_logs_controller.rb' - 'app/controllers/projects/import/jira_controller.rb' - 'app/controllers/projects/imports_controller.rb' - 'app/controllers/projects/incidents_controller.rb' @@ -55,30 +49,32 @@ Style/EmptyMethod: - 'app/controllers/projects/runners_controller.rb' - 'app/controllers/projects/settings/integrations_controller.rb' - 'app/controllers/projects/settings/packages_and_registries_controller.rb' - - 'app/controllers/projects/tags/releases_controller.rb' - 'app/controllers/projects/terraform_controller.rb' - 'app/controllers/projects/triggers_controller.rb' + - 'app/controllers/pwa_controller.rb' - 'app/controllers/registrations/welcome_controller.rb' - 'app/controllers/search_controller.rb' + - 'app/experiments/security_actions_continuous_onboarding_experiment.rb' - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' - 'app/helpers/subscribable_banner_helper.rb' - 'app/helpers/users/callouts_helper.rb' - 'app/models/ci/bridge.rb' + - 'app/models/ci/job_artifact.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/concerns/reactive_caching.rb' - 'app/models/concerns/relative_positioning.rb' - 'app/models/hooks/web_hook.rb' - 'app/models/integrations/hangouts_chat.rb' - 'app/models/integrations/microsoft_teams.rb' + - 'app/models/integrations/pumble.rb' - 'app/models/integrations/unify_circuit.rb' - 'app/models/integrations/webex_teams.rb' - 'app/models/wiki.rb' - 'app/services/auto_merge/base_service.rb' - 'app/services/award_emojis/destroy_service.rb' + - 'app/services/groups/transfer_service.rb' - 'app/services/issuable_base_service.rb' - - 'app/services/issues/reopen_service.rb' - 'app/services/projects/transfer_service.rb' - - 'app/workers/authorized_projects_worker.rb' - 'app/workers/namespaces/root_statistics_worker.rb' - 'db/migrate/20210420012444_change_web_hook_events_default.rb' - 'db/migrate/20210507191949_add_remove_on_issue_close_to_labels.rb' @@ -92,6 +88,7 @@ Style/EmptyMethod: - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' - 'db/post_migrate/20220412143552_consume_remaining_encrypt_integration_property_jobs.rb' - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' + - 'db/post_migrate/20220524074947_finalize_backfill_null_note_discussion_ids.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/designs_controller.rb' - 'ee/app/controllers/admin/geo/settings_controller.rb' @@ -101,9 +98,8 @@ Style/EmptyMethod: - 'ee/app/controllers/groups/analytics/devops_adoption_controller.rb' - 'ee/app/controllers/groups/compliance_frameworks_controller.rb' - 'ee/app/controllers/groups/feature_discovery_moments_controller.rb' - - 'ee/app/controllers/groups/hooks_controller.rb' - 'ee/app/controllers/groups/ldap_group_links_controller.rb' - - 'ee/app/controllers/groups/push_rules_controller.rb' + - 'ee/app/controllers/groups/settings/reporting_controller.rb' - 'ee/app/controllers/projects/analytics/code_reviews_controller.rb' - 'ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb' - 'ee/app/controllers/projects/incident_management/escalation_policies_controller.rb' @@ -122,8 +118,10 @@ Style/EmptyMethod: - 'ee/app/controllers/subscriptions/groups_controller.rb' - 'ee/app/controllers/trial_registrations_controller.rb' - 'ee/app/controllers/trials_controller.rb' + - 'ee/app/controllers/users/identity_verification_controller.rb' - 'ee/app/experiments/cart_abandonment_modal_experiment.rb' - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/geo/group_wiki_repository_registry.rb' - 'ee/app/services/feature_flag_issues/destroy_service.rb' - 'ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb' - 'lib/api/helpers/packages/conan/api_helpers.rb' @@ -135,6 +133,8 @@ Style/EmptyMethod: - 'lib/gitlab/alert_management/payload/base.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' + - 'lib/gitlab/background_migration/delete_approval_rules_with_vulnerability.rb' + - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' @@ -142,6 +142,7 @@ Style/EmptyMethod: - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' + - 'lib/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/ci/config/entry/need.rb' @@ -150,10 +151,10 @@ Style/EmptyMethod: - 'lib/gitlab/ci/pipeline/chain/validate/after_config.rb' - 'lib/gitlab/config/entry/node.rb' - 'lib/gitlab/config/entry/simplifiable.rb' - - 'lib/gitlab/email/message/in_product_marketing/experience.rb' - 'lib/gitlab/empty_search_results.rb' - 'lib/gitlab/git_access.rb' - 'lib/gitlab/import_export/json/ndjson_writer.rb' + - 'lib/gitlab/mailgun/webhook_processors/base.rb' - 'lib/gitlab/null_request_store.rb' - 'lib/gitlab/usage_data_non_sql_metrics.rb' - 'lib/mattermost/session.rb' @@ -162,7 +163,6 @@ Style/EmptyMethod: - 'qa/qa/resource/job.rb' - 'qa/qa/resource/package.rb' - 'qa/qa/resource/registry_repository.rb' - - 'qa/qa/resource/runner.rb' - 'qa/qa/service/cluster_provider/k3d.rb' - 'qa/qa/service/cluster_provider/k3s.rb' - 'qa/qa/service/cluster_provider/minikube.rb' @@ -173,7 +173,6 @@ Style/EmptyMethod: - 'spec/lib/gitlab/database/load_balancing/sidekiq_client_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - 'spec/lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin_spec.rb' - 'spec/lib/gitlab/database/postgresql_database_tasks/load_schema_versions_mixin_spec.rb' @@ -192,4 +191,5 @@ Style/EmptyMethod: - 'spec/lib/gitlab/utils/delegator_override/validator_spec.rb' - 'spec/lib/gitlab/utils/delegator_override_spec.rb' - 'spec/lib/gitlab/utils/override_spec.rb' + - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' - 'spec/workers/concerns/waitable_worker_spec.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index 63b7b5d387d..346be201322 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -1,11 +1,10 @@ --- # Cop supports --auto-correct. Style/ExplicitBlockArgument: - # Offense count: 143 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/controllers/admin/background_migrations_controller.rb' + - 'app/controllers/admin/batched_jobs_controller.rb' - 'app/controllers/application_controller.rb' - 'app/models/application_record.rb' - 'app/models/broadcast_message.rb' @@ -14,13 +13,14 @@ Style/ExplicitBlockArgument: - 'app/models/ci/build_trace_chunks/redis_trace_chunks.rb' - 'app/models/concerns/counter_attribute.rb' - 'app/models/merge_request.rb' + - 'app/models/merge_request_diff.rb' - 'app/models/snippet_repository.rb' - 'app/services/import_export_clean_up_service.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/workers/concerns/each_shard_worker.rb' - - 'db/migrate/20210629031900_associate_existing_dast_builds_with_variables.rb' - 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb' - 'ee/app/services/group_saml/identity/destroy_service.rb' + - 'ee/app/services/security/security_orchestration_policies/base_merge_requests_service.rb' - 'ee/lib/ee/backup/repositories.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/gitlab/audit/events/preloader.rb' @@ -44,6 +44,7 @@ Style/ExplicitBlockArgument: - 'lib/gitlab/ci/variables/collection.rb' - 'lib/gitlab/cleanup/remote_uploads.rb' - 'lib/gitlab/database/dynamic_model_helpers.rb' + - 'lib/gitlab/database/lock_writes_manager.rb' - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - 'lib/gitlab/git/changes.rb' - 'lib/gitlab/gitaly_client/list_blobs_adapter.rb' @@ -58,16 +59,20 @@ Style/ExplicitBlockArgument: - 'lib/gitlab/import_export/project/base_task.rb' - 'lib/gitlab/import_export/project/export_task.rb' - 'lib/gitlab/import_export/project/import_task.rb' + - 'lib/gitlab/import_export/remote_stream_upload.rb' + - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' - 'lib/gitlab/metrics/dashboard/cache.rb' - 'lib/gitlab/metrics/dashboard/stages/base_stage.rb' - 'lib/gitlab/profiler.rb' - 'lib/gitlab/redis/wrapper.rb' - 'lib/gitlab/reference_counter.rb' - 'lib/gitlab/seeder.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/sidekiq_middleware/monitor.rb' - 'lib/gitlab/sidekiq_middleware/query_analyzer.rb' - 'lib/gitlab/sidekiq_middleware/request_store_middleware.rb' - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' + - 'lib/gitlab/sidekiq_status.rb' - 'lib/gitlab/utils/measuring.rb' - 'lib/tasks/config_lint.rake' - 'qa/qa/ee/page/insights/show.rb' @@ -87,7 +92,6 @@ Style/ExplicitBlockArgument: - 'qa/qa/resource/events/base.rb' - 'qa/qa/runtime/api/repository_storage_moves.rb' - 'qa/qa/runtime/search.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb' - 'rubocop/code_reuse_helpers.rb' - 'spec/features/merge_request/user_sees_wip_help_message_spec.rb' - 'spec/features/projects/features_visibility_spec.rb' @@ -99,9 +103,10 @@ Style/ExplicitBlockArgument: - 'spec/models/repository_spec.rb' - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/todo_service_spec.rb' + - 'spec/support/database/gitlab_schemas_validate_connection.rb' - 'spec/support/helpers/feature_flag_helpers.rb' + - 'spec/support/helpers/features/runners_helpers.rb' - 'spec/support/helpers/features/top_nav_spec_helpers.rb' - - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/helpers/modal_helpers.rb' - 'spec/support/helpers/next_found_instance_of.rb' - 'spec/support/helpers/usage_data_helpers.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 66c368a7a52..4da3c32416c 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -142,6 +142,7 @@ Style/FormatString: - 'app/presenters/ci/pipeline_presenter.rb' - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/project_presenter.rb' + - 'app/presenters/key_presenter.rb' - 'app/serializers/build_details_entity.rb' - 'app/services/alert_management/alerts/update_service.rb' - 'app/services/boards/lists/base_create_service.rb' @@ -265,7 +266,6 @@ Style/FormatString: - 'ee/app/services/vulnerabilities/destroy_dismissal_feedback_service.rb' - 'ee/app/services/vulnerabilities/dismiss_service.rb' - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' - - 'ee/app/services/vulnerabilities/findings/create_from_security_finding_service.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' - 'ee/app/services/vulnerability_external_issue_links/create_service.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index b07c29ca1df..a4ae491b902 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -378,6 +378,7 @@ Style/GuardClause: - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/preloaders/environments/protected_environment_preloader.rb' - 'ee/app/models/protected_environment.rb' + - 'ee/app/models/protected_environments/deploy_access_level.rb' - 'ee/app/models/sbom/occurrence.rb' - 'ee/app/models/users_security_dashboard_project.rb' - 'ee/app/models/vulnerabilities/feedback.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index cc21860d462..8e295c68623 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -34,7 +34,6 @@ Style/IfUnlessModifier: - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - - 'app/controllers/jwt_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' - 'app/controllers/profiles/emails_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' @@ -47,7 +46,6 @@ Style/IfUnlessModifier: - 'app/controllers/projects/deploy_keys_controller.rb' - 'app/controllers/projects/design_management/designs_controller.rb' - 'app/controllers/projects/imports_controller.rb' - - 'app/controllers/projects/integrations/shimos_controller.rb' - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/merge_requests/diffs_controller.rb' - 'app/controllers/projects/merge_requests_controller.rb' @@ -94,13 +92,9 @@ Style/IfUnlessModifier: - 'app/graphql/mutations/release_asset_links/update.rb' - 'app/graphql/mutations/todos/mark_all_done.rb' - 'app/graphql/resolvers/blobs_resolver.rb' - - 'app/graphql/resolvers/ci/runner_jobs_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - - 'app/graphql/resolvers/group_packages_resolver.rb' - - 'app/graphql/resolvers/package_details_resolver.rb' - - 'app/graphql/resolvers/project_jobs_resolver.rb' - 'app/graphql/resolvers/project_pipeline_resolver.rb' - 'app/graphql/resolvers/timelog_resolver.rb' - 'app/graphql/types/ci/job_type.rb' @@ -133,7 +127,6 @@ Style/IfUnlessModifier: - 'app/helpers/selects_helper.rb' - 'app/helpers/snippets_helper.rb' - 'app/helpers/sorting_helper.rb' - - 'app/helpers/storage_helper.rb' - 'app/helpers/submodule_helper.rb' - 'app/helpers/tab_helper.rb' - 'app/helpers/timeboxes_helper.rb' @@ -168,7 +161,6 @@ Style/IfUnlessModifier: - 'app/models/concerns/bulk_users_by_email_load.rb' - 'app/models/concerns/cache_markdown_field.rb' - 'app/models/concerns/ci/artifactable.rb' - - 'app/models/concerns/counter_attribute.rb' - 'app/models/concerns/deprecated_assignee.rb' - 'app/models/concerns/group_descendant.rb' - 'app/models/concerns/has_wiki_page_meta_attributes.rb' @@ -272,7 +264,6 @@ Style/IfUnlessModifier: - 'app/services/ci/job_token_scope/remove_project_service.rb' - 'app/services/ci/parse_dotenv_artifact_service.rb' - 'app/services/ci/pipeline_processing/atomic_processing_service.rb' - - 'app/services/ci/pipelines/add_job_service.rb' - 'app/services/ci/register_job_service.rb' - 'app/services/ci/retry_job_service.rb' - 'app/services/ci/run_scheduled_build_service.rb' @@ -322,14 +313,11 @@ Style/IfUnlessModifier: - 'app/services/merge_requests/add_context_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' - - 'app/services/merge_requests/handle_assignees_change_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' - 'app/services/merge_requests/push_options_handler_service.rb' - 'app/services/merge_requests/refresh_service.rb' - - 'app/services/merge_requests/request_attention_service.rb' - 'app/services/merge_requests/squash_service.rb' - - 'app/services/merge_requests/toggle_attention_requested_service.rb' - 'app/services/merge_requests/update_service.rb' - 'app/services/metrics/dashboard/clone_dashboard_service.rb' - 'app/services/metrics/dashboard/update_dashboard_service.rb' @@ -354,7 +342,6 @@ Style/IfUnlessModifier: - 'app/services/packages/maven/find_or_create_package_service.rb' - 'app/services/packages/nuget/update_package_from_metadata_service.rb' - 'app/services/packages/pypi/create_package_service.rb' - - 'app/services/packages/rubygems/dependency_resolver_service.rb' - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/projects/container_repository/gitlab/delete_tags_service.rb' @@ -375,7 +362,6 @@ Style/IfUnlessModifier: - 'app/services/projects/update_repository_storage_service.rb' - 'app/services/protected_branches/cache_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - - 'app/services/resource_events/change_labels_service.rb' - 'app/services/snippets/create_service.rb' - 'app/services/snippets/destroy_service.rb' - 'app/services/snippets/repository_validation_service.rb' @@ -422,8 +408,6 @@ Style/IfUnlessModifier: - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' - 'app/workers/issues/rebalancing_worker.rb' - 'app/workers/merge_request_mergeability_check_worker.rb' - - 'app/workers/object_storage/migrate_uploads_worker.rb' - - 'app/workers/process_commit_worker.rb' - 'app/workers/projects/import_export/relation_export_worker.rb' - 'app/workers/remove_expired_members_worker.rb' - 'app/workers/repository_fork_worker.rb' @@ -450,8 +434,6 @@ Style/IfUnlessModifier: - 'config/initializers/sidekiq.rb' - 'config/initializers/stackprof.rb' - 'config/initializers/validate_database_config.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - - 'config/initializers/zz_metrics.rb' - 'config/initializers_before_autoloader/002_sidekiq.rb' - 'config/routes.rb' - 'danger/database/Dangerfile' @@ -603,6 +585,7 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/protected_branches/create_service.rb' - 'ee/app/services/ee/todo_service.rb' - 'ee/app/services/ee/users/update_service.rb' + - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/elastic/indexing_control_service.rb' - 'ee/app/services/elastic/process_bookkeeping_service.rb' - 'ee/app/services/epics/base_service.rb' @@ -652,7 +635,6 @@ Style/IfUnlessModifier: - 'ee/app/services/vulnerability_feedback/create_service.rb' - 'ee/app/services/vulnerability_feedback/destroy_service.rb' - 'ee/app/services/vulnerability_feedback_module/update_service.rb' - - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/validators/host_validator.rb' - 'ee/app/validators/password/complexity_validator.rb' - 'ee/app/workers/app_sec/dast/profile_schedule_worker.rb' @@ -889,7 +871,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/ci/config/normalizer.rb' - 'lib/gitlab/ci/parsers/coverage/sax_document.rb' - 'lib/gitlab/ci/parsers/security/common.rb' - - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb' - 'lib/gitlab/ci/pipeline/chain/populate.rb' - 'lib/gitlab/ci/pipeline/chain/seed.rb' - 'lib/gitlab/ci/pipeline/chain/validate/abilities.rb' @@ -991,7 +972,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/import_export/project/relation_factory.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' - 'lib/gitlab/instrumentation/rate_limiting_gates.rb' - - 'lib/gitlab/instrumentation/redis_interceptor.rb' - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' - 'lib/gitlab/legacy_github_import/client.rb' @@ -1034,7 +1014,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/search/params.rb' - 'lib/gitlab/search_context.rb' - 'lib/gitlab/search_results.rb' - - 'lib/gitlab/shell.rb' - 'lib/gitlab/sidekiq_config.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' - 'lib/gitlab/sidekiq_config/worker_router.rb' @@ -1063,7 +1042,6 @@ Style/IfUnlessModifier: - 'lib/sidebars/projects/menus/packages_registries_menu.rb' - 'lib/sidebars/projects/menus/security_compliance_menu.rb' - 'lib/sidebars/projects/menus/settings_menu.rb' - - 'lib/sidebars/projects/panel.rb' - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' - 'lib/system_check/init_helpers.rb' - 'lib/tasks/cleanup.rake' @@ -1078,7 +1056,6 @@ Style/IfUnlessModifier: - 'lib/tasks/gitlab/snippets.rake' - 'lib/tasks/gitlab/storage.rake' - 'lib/tasks/gitlab/update_templates.rake' - - 'qa/qa/ee/page/merge_request/show.rb' - 'qa/qa/ee/resource/settings/elasticsearch.rb' - 'qa/qa/flow/sign_up.rb' - 'qa/qa/page/component/select2.rb' @@ -1099,21 +1076,10 @@ Style/IfUnlessModifier: - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/scenario/bootable.rb' - 'qa/qa/service/praefect_manager.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/elasticsearch_api_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/commit_index/commit_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/issues_index/issue_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/main_index/blob_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/merge_request_index/merge_request_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/notes_index/note_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/nightly_elasticsearch_test_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_maven_package_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - 'qa/qa/support/loglinking.rb' @@ -1123,7 +1089,6 @@ Style/IfUnlessModifier: - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' - - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'rubocop/cop/gitlab/policy_rule_boolean.rb' - 'rubocop/cop/ignored_columns.rb' @@ -1131,8 +1096,6 @@ Style/IfUnlessModifier: - 'rubocop/cop/migration/add_reference.rb' - 'rubocop/cop/migration/remove_column.rb' - 'rubocop/cop/migration/sidekiq_queue_migrate.rb' - - 'rubocop/cop/performance/ar_exists_and_present_blank.rb' - - 'rubocop/cop/rspec/web_mock_enable.rb' - 'rubocop/routes_under_scope.rb' - 'scripts/pipeline_test_report_builder.rb' - 'scripts/review_apps/automated_cleanup.rb' @@ -1187,6 +1150,7 @@ Style/IfUnlessModifier: - 'spec/requests/api/integrations_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/import_routing_spec.rb' + - 'spec/rubocop_spec_helper.rb' - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - 'spec/services/clusters/applications/create_service_spec.rb' @@ -1197,7 +1161,6 @@ Style/IfUnlessModifier: - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' - 'spec/services/packages/maven/metadata/append_package_file_service_spec.rb' - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' - 'spec/services/projects/create_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/capybara.rb' @@ -1213,7 +1176,6 @@ Style/IfUnlessModifier: - 'spec/support/helpers/lets_encrypt_helpers.rb' - 'spec/support/helpers/live_debugger.rb' - 'spec/support/helpers/modal_helpers.rb' - - 'spec/support/helpers/seed_helper.rb' - 'spec/support/helpers/stub_gitlab_calls.rb' - 'spec/support/helpers/stubbed_feature.rb' - 'spec/support/helpers/test_env.rb' diff --git a/.rubocop_todo/style/keyword_parameters_order.yml b/.rubocop_todo/style/keyword_parameters_order.yml index 0bb499cebb0..3521f295cc1 100644 --- a/.rubocop_todo/style/keyword_parameters_order.yml +++ b/.rubocop_todo/style/keyword_parameters_order.yml @@ -1,10 +1,9 @@ --- # Cop supports --auto-correct. Style/KeywordParametersOrder: - # Offense count: 110 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: + - 'app/controllers/concerns/product_analytics_tracking.rb' - 'app/finders/group_descendants_finder.rb' - 'app/finders/merge_request_target_project_finder.rb' - 'app/graphql/resolvers/package_pipelines_resolver.rb' @@ -30,20 +29,23 @@ Style/KeywordParametersOrder: - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/create_service.rb' - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service.rb' - 'ee/app/services/audit_events/user_impersonation_group_audit_event_service.rb' - - 'ee/app/services/members/activate_service.rb' - 'ee/lib/gitlab/elastic/helper.rb' + - 'ee/lib/gitlab/insights/executors/dora_executor.rb' + - 'ee/lib/gitlab/insights/executors/issuable_executor.rb' - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/requests/api/deployments_spec.rb' + - 'lib/gitlab/background_migration/batched_migration_job.rb' - 'lib/gitlab/checks/timed_logger.rb' - 'lib/gitlab/ci/reports/security/finding.rb' + - 'lib/gitlab/cleanup/personal_access_tokens.rb' - 'lib/gitlab/database/partitioning/monthly_strategy.rb' - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/diff/diff_refs.rb' - 'lib/gitlab/email/smime/signer.rb' - - 'lib/gitlab/error_tracking.rb' - 'lib/gitlab/exclusive_lease.rb' - 'lib/gitlab/import_export/import_failure_service.rb' - 'lib/gitlab/merge_requests/mergeability/results_store.rb' + - 'lib/gitlab/usage_data_counters/editor_unique_counter.rb' - 'lib/microsoft_teams/notifier.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' @@ -64,9 +66,12 @@ Style/KeywordParametersOrder: - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - 'spec/migrations/confirm_support_bot_user_spec.rb' - 'spec/services/service_ping/submit_service_ping_service_spec.rb' + - 'spec/support/helpers/doc_url_helper.rb' - 'spec/support/helpers/smime_helper.rb' - 'spec/support/helpers/workhorse_helpers.rb' + - 'spec/support/shared_examples/projects/container_repository/cleanup_tags_service_shared_examples.rb' - 'spec/support/shared_examples/services/container_expiration_policy_shared_examples.rb' - 'spec/support/shared_examples/services/dependency_proxy_ttl_policies_shared_examples.rb' - 'spec/support/shared_examples/services/namespace_package_settings_shared_examples.rb' + - 'spec/tasks/gitlab/usage_data_rake_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index ea0b028d11c..5de15180438 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -1,21 +1,22 @@ --- # Cop supports --auto-correct. Style/NumericLiteralPrefix: - # Offense count: 148 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/models/container_repository.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'config/initializers/01_secret_token.rb' - 'config/initializers/1_settings.rb' - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb' + - 'ee/spec/models/ci/minutes/usage_spec.rb' - 'ee/spec/models/ee/group_spec.rb' - 'ee/spec/models/gitlab/seat_link_data_spec.rb' - 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb' @@ -27,18 +28,17 @@ Style/NumericLiteralPrefix: - 'lib/gitlab/jwt_authenticatable.rb' - 'lib/system_check/app/uploads_path_permission_check.rb' - 'lib/system_check/app/uploads_path_tmp_permission_check.rb' + - 'lib/tasks/gitlab/backup.rake' - 'lib/tasks/tanuki_emoji.rake' - 'metrics_server/metrics_server.rb' - 'qa/qa/support/ssh.rb' - 'qa/spec/support/ssh_spec.rb' - 'scripts/security-harness' + - 'spec/finders/personal_access_tokens_finder_spec.rb' - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - - 'spec/lib/gitlab/encoding_helper_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/git/tree_spec.rb' - 'spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/conflict_files_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/diff_spec.rb' @@ -65,11 +65,11 @@ Style/NumericLiteralPrefix: - 'spec/lib/gitlab/puma_logging/json_formatter_spec.rb' - 'spec/lib/gitlab/relative_positioning/range_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' + - 'spec/migrations/20220506154054_create_sync_namespace_details_trigger_spec.rb' + - 'spec/migrations/20220524184149_create_sync_project_namespace_details_trigger_spec.rb' - 'spec/models/issue_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/support/helpers/repo_helpers.rb' - - 'spec/support/helpers/test_env.rb' + - 'spec/models/personal_access_token_spec.rb' + - 'spec/requests/api/personal_access_tokens_spec.rb' - 'spec/support/import_export/export_file_helper.rb' - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' - - 'spec/tasks/gitlab/backup_rake_spec.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 9989ae3f8b3..472a722ed22 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -592,7 +592,6 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/search/abuse_detection.rb' - 'lib/gitlab/search_context.rb' - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - - 'lib/gitlab/sidekiq_middleware/memory_killer.rb' - 'lib/gitlab/slash_commands/presenters/base.rb' - 'lib/gitlab/ssh_public_key.rb' - 'lib/gitlab/task_helpers.rb' @@ -1155,7 +1154,6 @@ Style/PercentLiteralDelimiters: - 'spec/support/helpers/login_helpers.rb' - 'spec/support/helpers/prometheus_helpers.rb' - 'spec/support/helpers/repo_helpers.rb' - - 'spec/support/helpers/seed_helper.rb' - 'spec/support/helpers/seed_repo.rb' - 'spec/support/helpers/test_env.rb' - 'spec/support/helpers/usage_data_helpers.rb' @@ -1192,7 +1190,6 @@ Style/PercentLiteralDelimiters: - 'spec/support_specs/graphql/arguments_spec.rb' - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/tasks/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/uploads/migrate_rake_spec.rb' diff --git a/.rubocop_todo/style/redundant_begin.yml b/.rubocop_todo/style/redundant_begin.yml new file mode 100644 index 00000000000..e96cdb26b08 --- /dev/null +++ b/.rubocop_todo/style/redundant_begin.yml @@ -0,0 +1,57 @@ +--- +# Cop supports --auto-correct. +Style/RedundantBegin: + Details: grace period + Exclude: + - 'app/controllers/concerns/membership_actions.rb' + - 'app/controllers/concerns/metrics_dashboard.rb' + - 'app/controllers/concerns/renders_ldap_servers.rb' + - 'app/helpers/auth_helper.rb' + - 'app/models/event.rb' + - 'app/models/integrations/asana.rb' + - 'app/models/integrations/jira.rb' + - 'app/models/user.rb' + - 'app/services/ci/register_job_service.rb' + - 'app/services/design_management/generate_image_versions_service.rb' + - 'app/services/error_tracking/list_projects_service.rb' + - 'app/services/issue_links/create_service.rb' + - 'app/services/merge_requests/assign_issues_service.rb' + - 'app/services/projects/batch_forks_count_service.rb' + - 'app/services/projects/batch_open_issues_count_service.rb' + - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' + - 'app/services/users/update_highest_member_role_service.rb' + - 'ee/app/controllers/groups/sso_controller.rb' + - 'ee/app/finders/security/findings_finder.rb' + - 'ee/app/services/epics/epic_links/create_service.rb' + - 'ee/app/services/epics/related_epic_links/create_service.rb' + - 'ee/app/services/geo/container_repository_sync_service.rb' + - 'ee/app/validators/ee/json_schema_validator.rb' + - 'ee/lib/ee/api/helpers/award_emoji.rb' + - 'ee/lib/gem_extensions/elasticsearch/model/adapter/multiple/records.rb' + - 'ee/lib/gitlab/ci/parsers/security/dast.rb' + - 'ee/lib/omni_auth/strategies/group_saml.rb' + - 'ee/lib/system_check/geo/authorized_keys_check.rb' + - 'lib/api/helpers/award_emoji.rb' + - 'lib/api/time_tracking_endpoints.rb' + - 'lib/atlassian/jira_connect/serializers/build_entity.rb' + - 'lib/backup/manager.rb' + - 'lib/banzai/pipeline/wiki_pipeline.rb' + - 'lib/gem_extensions/active_record/association.rb' + - 'lib/gitlab.rb' + - 'lib/gitlab/changes_list.rb' + - 'lib/gitlab/color.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/database/schema_cache_with_renamed_table.rb' + - 'lib/gitlab/favicon.rb' + - 'lib/gitlab/import_export/base/relation_factory.rb' + - 'lib/gitlab/import_export/members_mapper.rb' + - 'lib/gitlab/import_export/project/tree_saver.rb' + - 'lib/gitlab/instrumentation/redis_interceptor.rb' + - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' + - 'lib/gitlab/phabricator_import/project_creator.rb' + - 'lib/gitlab/project_search_results.rb' + - 'lib/gitlab/shell.rb' + - 'lib/gitlab/usage/metrics/aggregates/sources/calculations/intersection.rb' + - 'lib/sidebars/menu.rb' + - 'qa/qa/resource/api_fabricator.rb' + - 'qa/qa/runtime/api/client.rb' diff --git a/.rubocop_todo/style/redundant_condition.yml b/.rubocop_todo/style/redundant_condition.yml new file mode 100644 index 00000000000..86be40f7ffa --- /dev/null +++ b/.rubocop_todo/style/redundant_condition.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Style/RedundantCondition: + Exclude: + - 'ee/app/models/license.rb' + - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml new file mode 100644 index 00000000000..1ca658776b8 --- /dev/null +++ b/.rubocop_todo/style/redundant_parentheses.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Style/RedundantParentheses: + Exclude: + - 'lib/gitlab/database/tables_truncate.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/utilization/billing_seats_usage_data_spec.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index 860183426e9..3ffd27d26ae 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -1,9 +1,7 @@ --- # Cop supports --auto-correct. Style/SingleArgumentDig: - # Offense count: 150 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/graphql/resolvers/namespace_projects_resolver.rb' - 'app/models/ci/build.rb' @@ -22,6 +20,7 @@ Style/SingleArgumentDig: - 'ee/app/workers/concerns/elastic/migration_helper.rb' - 'ee/lib/gitlab/ci/parsers/security/dependency_list.rb' - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/graphql/mutations/vulnerabilities/create_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb' @@ -35,10 +34,11 @@ Style/SingleArgumentDig: - 'ee/spec/requests/api/graphql/project/dast_site_profiles_spec.rb' - 'ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb' - 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb' + - 'ee/spec/services/vulnerabilities/findings/find_or_create_from_security_finding_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' + - 'lib/gitlab/auth/o_auth/auth_hash.rb' - 'lib/gitlab/ci/badge/coverage/template.rb' - - 'lib/gitlab/ci/badge/pipeline/template.rb' - - 'lib/gitlab/ci/badge/release/template.rb' + - 'lib/gitlab/ci/badge/template.rb' - 'lib/gitlab/ci/lint.rb' - 'lib/gitlab/ci/parsers/accessibility/pa11y.rb' - 'lib/gitlab/ci/parsers/security/common.rb' @@ -51,11 +51,13 @@ Style/SingleArgumentDig: - 'lib/gitlab/database/transaction/observer.rb' - 'lib/gitlab/serverless/service.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' + - 'qa/qa/vendor/mail_hog/api.rb' - 'spec/controllers/graphql_controller_spec.rb' - 'spec/graphql/types/release_links_type_spec.rb' - 'spec/helpers/projects_helper_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/graphql/ci/instance_variables_spec.rb' - 'spec/requests/api/graphql/container_repository/container_repository_details_spec.rb' - 'spec/requests/api/graphql/project/container_repositories_spec.rb' - 'spec/requests/api/graphql/project/jira_import_spec.rb' diff --git a/.rubocop_todo/style/sole_nested_conditional.yml b/.rubocop_todo/style/sole_nested_conditional.yml index 620d66a272c..535b8d20765 100644 --- a/.rubocop_todo/style/sole_nested_conditional.yml +++ b/.rubocop_todo/style/sole_nested_conditional.yml @@ -1,8 +1,7 @@ --- +# Cop supports --auto-correct. Style/SoleNestedConditional: - # Offense count: 64 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/ldap/omniauth_callbacks_controller.rb' @@ -17,7 +16,6 @@ Style/SoleNestedConditional: - 'app/models/network/graph.rb' - 'app/models/packages/package.rb' - 'app/models/protected_branch.rb' - - 'app/services/ci/register_job_service.rb' - 'app/services/concerns/update_visibility_level.rb' - 'app/services/incident_management/incidents/create_service.rb' - 'app/services/merge_requests/update_service.rb' @@ -27,9 +25,11 @@ Style/SoleNestedConditional: - 'app/services/projects/create_service.rb' - 'app/services/projects/hashed_storage/migration_service.rb' - 'app/services/projects/hashed_storage/rollback_service.rb' + - 'app/workers/merge_requests/delete_source_branch_worker.rb' - 'ee/app/finders/ee/snippets_finder.rb' - 'ee/app/services/ee/issue_links/create_service.rb' - 'ee/app/services/ee/lfs/unlock_file_service.rb' + - 'ee/app/services/ee/merge_requests/create_pipeline_service.rb' - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/geo/framework_repository_sync_service.rb' - 'ee/app/services/geo/repository_base_sync_service.rb' @@ -43,6 +43,7 @@ Style/SoleNestedConditional: - 'lib/api/ci/helpers/runner.rb' - 'lib/api/deploy_keys.rb' - 'lib/api/helpers/label_helpers.rb' + - 'lib/api/maven_packages.rb' - 'lib/api/users.rb' - 'lib/banzai/filter/ascii_doc_sanitization_filter.rb' - 'lib/banzai/filter/base_sanitization_filter.rb' @@ -52,7 +53,9 @@ Style/SoleNestedConditional: - 'lib/gitlab/config/entry/configurable.rb' - 'lib/gitlab/config/entry/validators.rb' - 'lib/gitlab/database/each_database.rb' + - 'lib/gitlab/database/load_balancing/load_balancer.rb' - 'lib/gitlab/email/handler/reply_processing.rb' + - 'lib/gitlab/patch/database_config.rb' - 'lib/gitlab/user_access.rb' - 'lib/gitlab/utils.rb' - 'lib/gitlab/x509/signature.rb' @@ -60,5 +63,5 @@ Style/SoleNestedConditional: - 'lib/mattermost/session.rb' - 'lib/object_storage/direct_upload.rb' - 'qa/qa/flow/login.rb' - - 'qa/qa/support/page_error_checker.rb' + - 'qa/qa/page/project/web_ide/edit.rb' - 'spec/spec_helper.rb' diff --git a/.rubocop_todo/style/special_global_vars.yml b/.rubocop_todo/style/special_global_vars.yml new file mode 100644 index 00000000000..df688872d71 --- /dev/null +++ b/.rubocop_todo/style/special_global_vars.yml @@ -0,0 +1,4 @@ +--- +# Cop supports --auto-correct. +Style/SpecialGlobalVars: + Details: grace period diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 315ce3701a8..ec15edbc206 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -263,9 +263,9 @@ Style/StringConcatenation: - 'spec/models/custom_emoji_spec.rb' - 'spec/models/grafana_integration_spec.rb' - 'spec/models/integrations/campfire_spec.rb' + - 'spec/models/integrations/datadog_spec.rb' - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - 'spec/models/integrations/chat_message/push_message_spec.rb' - - 'spec/models/integrations/datadog_spec.rb' - 'spec/models/integrations/jenkins_spec.rb' - 'spec/models/merge_request_diff_spec.rb' - 'spec/models/merge_request_spec.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index cded81afa7f..fc90e1ce6a6 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -1,9 +1,7 @@ --- # Cop supports --auto-correct. Style/StringLiteralsInInterpolation: - # Offense count: 119 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/graphql/mutations/base_mutation.rb' - 'app/helpers/colors_helper.rb' @@ -23,11 +21,16 @@ Style/StringLiteralsInInterpolation: - 'ee/app/helpers/ee/merge_requests_helper.rb' - 'ee/app/models/license.rb' - 'ee/app/services/epics/tree_reorder_service.rb' + - 'ee/lib/ee/api/helpers/issues_helpers.rb' - 'ee/lib/gitlab/elastic/helper.rb' + - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/spec/features/admin/admin_settings_spec.rb' + - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' + - 'ee/spec/lib/gitlab/expiring_subscription_message_spec.rb' - 'lib/api/helpers/snippets_helpers.rb' - 'lib/api/validations/validators/check_assignees_count.rb' - 'lib/banzai/filter/references/abstract_reference_filter.rb' + - 'lib/banzai/filter/syntax_highlight_filter.rb' - 'lib/generators/gitlab/usage_metric_definition_generator.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/ci/config/entry/job.rb' @@ -36,6 +39,7 @@ Style/StringLiteralsInInterpolation: - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - 'lib/gitlab/doctor/secrets.rb' - 'lib/gitlab/endpoint_attributes/config.rb' + - 'lib/gitlab/gitaly_client/ref_service.rb' - 'lib/gitlab/graphql/queries.rb' - 'lib/gitlab/quick_actions/extractor.rb' - 'lib/gitlab/sanitizers/exif.rb' @@ -43,13 +47,11 @@ Style/StringLiteralsInInterpolation: - 'lib/gitlab/tracking/destinations/snowplow.rb' - 'lib/tasks/gitlab/info.rake' - 'lib/tasks/gitlab/sidekiq.rake' - - 'lib/tasks/gitlab/tw/codeowners.rake' - 'qa/qa/ee/page/component/secure_report.rb' - 'qa/qa/ee/page/group/secure/show.rb' - 'qa/qa/resource/events/base.rb' - 'qa/qa/service/cluster_provider/base.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - - 'qa/qa/service/docker_run/gitlab_runner.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/tools/generate_perf_testdata.rb' - 'rubocop/cop/migration/prevent_index_creation.rb' @@ -59,9 +61,12 @@ Style/StringLiteralsInInterpolation: - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' + - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' + - 'spec/lib/gitlab/gitaly_client/ref_service_spec.rb' - 'spec/lib/object_storage/direct_upload_spec.rb' - 'spec/models/serverless/domain_spec.rb' - 'spec/requests/api/keys_spec.rb' - 'spec/support/database/prevent_cross_joins.rb' + - 'spec/views/notify/import_issues_csv_email.html.haml_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index bfb3867b127..d373788dbc6 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -70,8 +70,6 @@ Style/SymbolProc: - 'app/services/clusters/agents/delete_expired_events_service.rb' - 'app/services/feature_flags/update_service.rb' - 'app/services/merge_requests/base_service.rb' - - 'app/services/merge_requests/bulk_remove_attention_requested_service.rb' - - 'app/services/merge_requests/reopen_service.rb' - 'app/services/notes/destroy_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - 'app/services/resource_events/synthetic_label_notes_builder_service.rb' @@ -87,7 +85,6 @@ Style/SymbolProc: - 'config/initializers/01_active_record_database_tasks_configuration_flag.rb' - 'config/initializers/doorkeeper_openid_connect.rb' - 'config/initializers/mail_encoding_patch.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'config/settings.rb' - 'db/migrate/20210318134427_delete_security_findings_without_uuid.rb' - 'db/migrate/20210503105845_add_project_value_stream_id_to_project_stages.rb' @@ -136,7 +133,6 @@ Style/SymbolProc: - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/document_reference_spec.rb' - - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/services/groups/participants_service_spec.rb' - 'ee/spec/support/helpers/subscription_portal_helpers.rb' - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' @@ -205,17 +201,13 @@ Style/SymbolProc: - 'qa/qa/specs/features/browser_ui/3_create/web_ide/review_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/custom_variable_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/online_garbage_collection_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/attachment_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/rename_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_status_on_operation_dashboard_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' + - 'rubocop/cop/gitlab/namespaced_class.rb' - 'scripts/qa/testcases-check' - 'scripts/static-analysis' - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' @@ -245,7 +237,6 @@ Style/SymbolProc: - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/loose_foreign_key_helpers_spec.rb' - 'spec/lib/gitlab/git/commit_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb' - 'spec/lib/gitlab/graphql/lazy_spec.rb' - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' @@ -272,7 +263,6 @@ Style/SymbolProc: - 'spec/services/merge_requests/conflicts/list_service_spec.rb' - 'spec/services/notification_recipients/builder/default_spec.rb' - 'spec/services/packages/go/create_package_service_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/generate-seed-repo-rb' - 'spec/support/helpers/filter_spec_helper.rb' |