diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-08-18 11:17:02 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-08-18 11:17:02 +0300 |
| commit | b39512ed755239198a9c294b6a45e65c05900235 (patch) | |
| tree | d234a3efade1de67c46b9e5a38ce813627726aa7 /.rubocop_todo | |
| parent | d31474cf3b17ece37939d20082b07f6657cc79a9 (diff) | |
Add latest changes from gitlab-org/gitlab@15-3-stable-eev15.3.0-rc42
Diffstat (limited to '.rubocop_todo')
49 files changed, 1062 insertions, 2313 deletions
diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/capybara/visibility_matcher.yml index 90d71fe2d3a..e236be2593e 100644 --- a/.rubocop_todo/capybara/visibility_matcher.yml +++ b/.rubocop_todo/capybara/visibility_matcher.yml @@ -1,24 +1,23 @@ --- Capybara/VisibilityMatcher: - # Offense count: 213 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/features/boards/sidebar_spec.rb' - 'ee/spec/features/epics/epic_show_spec.rb' - 'ee/spec/features/epics/todo_spec.rb' + - 'ee/spec/features/epics/update_epic_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' - 'ee/spec/features/groups/issues_spec.rb' - 'ee/spec/features/groups/saml_enforcement_spec.rb' + - 'ee/spec/features/groups/settings/protected_environments_spec.rb' - 'ee/spec/features/issues/related_issues_spec.rb' - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - - 'ee/spec/features/projects/path_locks_spec.rb' - 'ee/spec/features/projects/quality/test_case_show_spec.rb' - 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb' - 'ee/spec/features/projects/settings/ee/repository_mirrors_settings_spec.rb' - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/registrations/welcome_spec.rb' + - 'ee/spec/support/helpers/billing_plans_helpers.rb' + - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/views/issuable_bulk_dropdown_shared_examples.rb' - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' @@ -26,13 +25,6 @@ Capybara/VisibilityMatcher: - 'spec/features/dashboard/merge_requests_spec.rb' - 'spec/features/dashboard/todos/todos_spec.rb' - 'spec/features/groups/group_settings_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_assignee_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_author_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_emoji_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_hint_spec.rb' - - 'spec/features/issues/filtered_search/recent_searches_spec.rb' - - 'spec/features/issues/filtered_search/search_bar_spec.rb' - - 'spec/features/issues/filtered_search/visual_tokens_spec.rb' - 'spec/features/issues/service_desk_spec.rb' - 'spec/features/issues/todo_spec.rb' - 'spec/features/issues/user_creates_branch_and_merge_request_spec.rb' @@ -48,17 +40,19 @@ Capybara/VisibilityMatcher: - 'spec/features/projects/blobs/user_follows_pipeline_suggest_nudge_spec.rb' - 'spec/features/projects/ci/lint_spec.rb' - 'spec/features/projects/commit/comments/user_adds_comment_spec.rb' + - 'spec/features/projects/commits/multi_view_diff_spec.rb' - 'spec/features/projects/commits/user_browses_commits_spec.rb' - 'spec/features/projects/integrations/user_activates_jira_spec.rb' - 'spec/features/projects/issues/design_management/user_views_designs_with_svg_xss_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/network_graph_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/settings/lfs_settings_spec.rb' - 'spec/features/projects/settings/packages_settings_spec.rb' + - 'spec/features/projects/settings/repository_settings_spec.rb' - 'spec/features/projects/settings/visibility_settings_spec.rb' - 'spec/features/projects/show/user_manages_notifications_spec.rb' - - 'spec/features/projects/tags/user_edits_tags_spec.rb' - 'spec/features/projects/user_changes_project_visibility_spec.rb' - 'spec/features/projects/user_sees_user_popover_spec.rb' - 'spec/features/search/user_searches_for_commits_spec.rb' @@ -66,6 +60,7 @@ Capybara/VisibilityMatcher: - 'spec/features/task_lists_spec.rb' - 'spec/features/u2f_spec.rb' - 'spec/features/uploads/user_uploads_file_to_note_spec.rb' + - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/overview_spec.rb' - 'spec/features/users/user_browses_projects_on_user_page_spec.rb' - 'spec/features/webauthn_spec.rb' diff --git a/.rubocop_todo/database/multiple_databases.yml b/.rubocop_todo/database/multiple_databases.yml index 1d0085e1ba6..07d8ce12fa8 100644 --- a/.rubocop_todo/database/multiple_databases.yml +++ b/.rubocop_todo/database/multiple_databases.yml @@ -6,12 +6,10 @@ Database/MultipleDatabases: - 'db/post_migrate/20210811122206_update_external_project_bots.rb' - 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb' - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - - 'lib/backup/manager.rb' - 'lib/gitlab/background_migration/backfill_projects_with_coverage.rb' - 'lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans.rb' - 'spec/db/schema_spec.rb' - 'spec/initializers/database_config_spec.rb' - - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' @@ -24,5 +22,4 @@ Database/MultipleDatabases: - 'spec/support/helpers/migrations_helpers.rb' - 'spec/support/helpers/query_recorder.rb' - 'spec/support/helpers/usage_data_helpers.rb' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' diff --git a/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml b/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml new file mode 100644 index 00000000000..06651a0f60a --- /dev/null +++ b/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml @@ -0,0 +1,29 @@ +--- +Gitlab/DeprecateTrackRedisHLLEvent: + Exclude: + - 'app/controllers/admin/dev_ops_report_controller.rb' + - 'app/controllers/admin/usage_trends_controller.rb' + - 'app/controllers/concerns/snippets_actions.rb' + - 'app/controllers/concerns/wiki_actions.rb' + - 'app/controllers/projects/blob_controller.rb' + - 'app/controllers/projects/cycle_analytics_controller.rb' + - 'app/controllers/projects/graphs_controller.rb' + - 'app/controllers/projects/pipelines_controller.rb' + - 'ee/app/controllers/admin/audit_logs_controller.rb' + - 'ee/app/controllers/admin/credentials_controller.rb' + - 'ee/app/controllers/ee/admin/dev_ops_report_controller.rb' + - 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb' + - 'ee/app/controllers/groups/analytics/devops_adoption_controller.rb' + - 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb' + - 'ee/app/controllers/groups/audit_events_controller.rb' + - 'ee/app/controllers/groups/contribution_analytics_controller.rb' + - 'ee/app/controllers/groups/epic_boards_controller.rb' + - 'ee/app/controllers/groups/insights_controller.rb' + - 'ee/app/controllers/groups/issues_analytics_controller.rb' + - 'ee/app/controllers/groups/security/compliance_dashboards_controller.rb' + - 'ee/app/controllers/projects/analytics/code_reviews_controller.rb' + - 'ee/app/controllers/projects/analytics/issues_analytics_controller.rb' + - 'ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb' + - 'ee/app/controllers/projects/insights_controller.rb' + - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' + - 'spec/controllers/concerns/redis_tracking_spec.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index ac5edc05265..ef87efb666a 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -402,12 +402,14 @@ Gitlab/NamespacedClass: - 'app/policies/project_policy.rb' - 'app/policies/project_snippet_policy.rb' - 'app/policies/project_statistics_policy.rb' + - 'app/policies/project_hook_policy.rb' - 'app/policies/prometheus_alert_policy.rb' - 'app/policies/protected_branch_policy.rb' - 'app/policies/release_policy.rb' - 'app/policies/repository_policy.rb' - 'app/policies/resource_label_event_policy.rb' - 'app/policies/suggestion_policy.rb' + - 'app/policies/system_hook_policy.rb' - 'app/policies/timebox_policy.rb' - 'app/policies/timelog_policy.rb' - 'app/policies/todo_policy.rb' @@ -968,6 +970,7 @@ Gitlab/NamespacedClass: - 'ee/app/policies/push_rule_policy.rb' - 'ee/app/policies/saml_provider_policy.rb' - 'ee/app/policies/vulnerability_policy.rb' + - 'ee/app/policies/group_hook_policy.rb' - 'ee/app/presenters/approval_rule_presenter.rb' - 'ee/app/presenters/audit_event_presenter.rb' - 'ee/app/presenters/epic_issue_presenter.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index e3bbf9dc25a..84e367e0514 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Layout/FirstArrayElementIndentation: - # Offense count: 1133 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/abuse_reports_controller.rb' - 'app/controllers/admin/application_settings_controller.rb' @@ -22,10 +19,12 @@ Layout/FirstArrayElementIndentation: - 'app/helpers/search_helper.rb' - 'app/models/ci/job_token/scope.rb' - 'app/models/container_repository.rb' + - 'app/models/customer_relations/contact.rb' + - 'app/models/customer_relations/organization.rb' - 'app/models/group.rb' - 'app/models/integration.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/internal_id.rb' + - 'app/models/issue.rb' - 'app/models/member.rb' - 'app/models/merge_request.rb' - 'app/models/namespace.rb' @@ -40,6 +39,7 @@ Layout/FirstArrayElementIndentation: - 'app/workers/ssh_keys/expired_notification_worker.rb' - 'config/initializers/postgres_partitioning.rb' - 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb' + - 'ee/app/controllers/groups/settings/reporting_controller.rb' - 'ee/app/controllers/projects/vulnerability_feedback_controller.rb' - 'ee/app/finders/autocomplete/project_invited_groups_finder.rb' - 'ee/app/finders/geo/project_registry_finder.rb' @@ -47,14 +47,19 @@ Layout/FirstArrayElementIndentation: - 'ee/app/graphql/mutations/vulnerabilities/create.rb' - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/trial_helper.rb' + - 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb' - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/project.rb' - 'ee/app/models/ee/user.rb' + - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/protected_environment.rb' + - 'ee/app/models/vulnerabilities/read.rb' - 'ee/app/serializers/dashboard_environments_serializer.rb' - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - 'ee/app/services/vulnerabilities/create_service_base.rb' - 'ee/lib/ee/api/helpers/award_emoji.rb' - 'ee/lib/ee/gitlab/geo_git_access.rb' + - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' - 'ee/lib/gitlab/elastic/helper.rb' - 'ee/lib/gitlab/sitemaps/url_extractor.rb' - 'ee/lib/tasks/gitlab/seed/metrics.rake' @@ -65,14 +70,17 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' - 'ee/spec/features/admin/admin_dev_ops_reports_spec.rb' - 'ee/spec/features/boards/boards_licensed_features_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' - 'ee/spec/features/groups/group_roadmap_spec.rb' - 'ee/spec/finders/billed_users_finder_spec.rb' - 'ee/spec/finders/merge_requests/by_approvers_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/finders/security/scan_execution_policies_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/search.rb' - 'ee/spec/graphql/mutations/incident_management/escalation_policy/create_spec.rb' - 'ee/spec/graphql/resolvers/dora_metrics_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' - 'ee/spec/graphql/resolvers/timebox_report_resolver_spec.rb' - 'ee/spec/graphql/types/ci/pipeline_type_spec.rb' - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' @@ -89,6 +97,7 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/epic_node_spec.rb' + - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_ci_builds_metric_spec.rb' @@ -104,6 +113,7 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/ee/release_spec.rb' - 'ee/spec/models/group_wiki_repository_spec.rb' + - 'ee/spec/models/namespace_setting_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/requirements_management/test_report_spec.rb' - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' @@ -123,6 +133,7 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/requests/api/graphql/project/alert_management/payload_fields_spec.rb' - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policy/rules_spec.rb' - 'ee/spec/requests/api/graphql/project/merge_requests_spec.rb' + - 'ee/spec/requests/api/internal/kubernetes_spec.rb' - 'ee/spec/requests/api/ldap_group_links_spec.rb' - 'ee/spec/requests/api/members_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' @@ -130,16 +141,16 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/services/gitlab_subscriptions/fetch_purchase_eligible_namespaces_service_spec.rb' - 'ee/spec/services/groups/seat_usage_export_service_spec.rb' - 'ee/spec/services/iterations/cadences/create_iterations_in_advance_service_spec.rb' - - 'ee/spec/services/iterations/cadences/create_service_spec.rb' - 'ee/spec/services/protected_environments/base_service_spec.rb' - 'ee/spec/services/search_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/hooks_execution_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/process_scan_result_policy_service_spec.rb' - 'ee/spec/services/security/store_findings_metadata_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/services/user_permissions/export_service_spec.rb' - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - 'ee/spec/workers/geo/scheduler/scheduler_worker_spec.rb' - - 'lib/gitlab/background_migration/fix_merge_request_diff_commit_users.rb' + - 'lib/event_filter.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/email/message/in_product_marketing/team.rb' - 'lib/gitlab/email/message/in_product_marketing/trial.rb' @@ -153,25 +164,27 @@ Layout/FirstArrayElementIndentation: - 'lib/gitlab/usage_data.rb' - 'lib/system_check/app/authorized_keys_permission_check.rb' - 'qa/qa/resource/protected_branch.rb' + - 'qa/qa/specs/features/api/1_manage/group_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' + - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/automatic_failover_and_recovery_spec.rb' + - 'qa/qa/specs/features/api/3_create/gitaly/changing_repository_storage_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/gitaly_mtls_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/praefect_dataloss_spec.rb' + - 'qa/qa/specs/features/api/3_create/repository/commit_to_templated_project_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/custom_issue_template_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/cherry_pick/cherry_pick_commit_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_via_template_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/branch_with_unusual_name_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/snippet/copy_snippet_file_contents_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_new_directory_in_web_ide_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/helm_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven_gradle_repository_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' @@ -189,12 +202,14 @@ Layout/FirstArrayElementIndentation: - 'spec/controllers/projects/pipelines_controller_spec.rb' - 'spec/deprecation_toolkit_env.rb' - 'spec/features/clusters/create_agent_spec.rb' - - 'spec/features/issues/filtered_search/filter_issues_spec.rb' - - 'spec/features/issues/filtered_search/visual_tokens_spec.rb' + - 'spec/finders/bulk_imports/entities_finder_spec.rb' - 'spec/finders/ci/daily_build_group_report_results_finder_spec.rb' - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' + - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' + - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_transfer_finder_spec.rb' - 'spec/frontend/fixtures/search.rb' - 'spec/graphql/mutations/commits/create_spec.rb' + - 'spec/graphql/mutations/environments/canary_ingress/update_spec.rb' - 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb' - 'spec/graphql/types/ci/runner_architecture_type_spec.rb' - 'spec/graphql/types/ci/runner_platform_type_spec.rb' @@ -217,8 +232,10 @@ Layout/FirstArrayElementIndentation: - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/ci/ansi2json_spec.rb' - 'spec/lib/gitlab/ci/config/entry/product/parallel_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/root_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/project_spec.rb' - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' + - 'spec/lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_spec.rb' @@ -241,9 +258,13 @@ Layout/FirstArrayElementIndentation: - 'spec/lib/gitlab/diff/char_diff_spec.rb' - 'spec/lib/gitlab/diff/file_collection_sorter_spec.rb' - 'spec/lib/gitlab/error_tracking/stack_trace_highlight_decorator_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/gitaly_client/blob_service_spec.rb' + - 'spec/lib/gitlab/github_import/importer/diff_notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/lfs_objects_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/notes_importer_spec.rb' - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' - - 'spec/lib/gitlab/gitlab_import/importer_spec.rb' - 'spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb' - 'spec/lib/gitlab/hook_data/release_builder_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' @@ -263,13 +284,16 @@ Layout/FirstArrayElementIndentation: - 'spec/lib/gitlab/search/abuse_detection_spec.rb' - 'spec/lib/gitlab/search/found_blob_spec.rb' - 'spec/lib/gitlab/serializer/ci/variables_spec.rb' + - 'spec/lib/gitlab/sidekiq_config_spec.rb' - 'spec/lib/gitlab/ssh_public_key_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/webpack/manifest_spec.rb' + - 'spec/lib/google_api/cloud_platform/client_spec.rb' - 'spec/lib/peek/views/bullet_detailed_spec.rb' - 'spec/lib/system_check/incoming_email_check_spec.rb' + - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - 'spec/migrations/add_premium_and_ultimate_plan_limits_spec.rb' - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb' - 'spec/migrations/slice_merge_request_diff_commit_migrations_spec.rb' @@ -279,6 +303,7 @@ Layout/FirstArrayElementIndentation: - 'spec/models/ci/build_trace_spec.rb' - 'spec/models/ci/daily_build_group_report_result_spec.rb' - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/runner_version_spec.rb' - 'spec/models/ci/unit_test_spec.rb' - 'spec/models/clusters/applications/cert_manager_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' @@ -293,6 +318,7 @@ Layout/FirstArrayElementIndentation: - 'spec/models/integration_spec.rb' - 'spec/models/integrations/chat_message/issue_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' + - 'spec/models/integrations/jira_spec.rb' - 'spec/models/label_note_spec.rb' - 'spec/models/merge_request/cleanup_schedule_spec.rb' - 'spec/models/merge_request_diff_spec.rb' @@ -300,6 +326,8 @@ Layout/FirstArrayElementIndentation: - 'spec/models/operations/feature_flags/strategy_spec.rb' - 'spec/models/project_group_link_spec.rb' - 'spec/models/repository_spec.rb' + - 'spec/models/user_preference_spec.rb' + - 'spec/models/user_spec.rb' - 'spec/models/wiki_directory_spec.rb' - 'spec/policies/concerns/crud_policy_helpers_spec.rb' - 'spec/presenters/ci/build_runner_presenter_spec.rb' @@ -309,24 +337,30 @@ Layout/FirstArrayElementIndentation: - 'spec/requests/api/deploy_tokens_spec.rb' - 'spec/requests/api/graphql/ci/config_spec.rb' - 'spec/requests/api/graphql/ci/jobs_spec.rb' + - 'spec/requests/api/graphql/mutations/uploads/delete_spec.rb' - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' - 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb' - 'spec/requests/api/graphql/project/milestones_spec.rb' - 'spec/requests/api/graphql/usage_trends_measurements_spec.rb' + - 'spec/requests/api/graphql/work_item_spec.rb' - 'spec/requests/api/issues/post_projects_issues_spec.rb' - 'spec/requests/api/issues/put_projects_issues_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/task_completion_status_spec.rb' - 'spec/requests/projects/ci/promeheus_metrics/histograms_controller_spec.rb' - 'spec/requests/projects/issues_controller_spec.rb' + - 'spec/requests/projects/merge_requests_controller_spec.rb' - 'spec/serializers/build_trace_entity_spec.rb' - 'spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb' - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' - 'spec/services/award_emojis/copy_service_spec.rb' + - 'spec/services/bulk_update_integration_service_spec.rb' - 'spec/services/ci/compare_test_reports_service_spec.rb' + - 'spec/services/ci/create_pipeline_service/rules_spec.rb' - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - 'spec/services/design_management/move_designs_service_spec.rb' - 'spec/services/git/tag_hooks_service_spec.rb' + - 'spec/services/google_cloud/setup_cloudsql_instance_service_spec.rb' - 'spec/services/import/gitlab_projects/create_project_service_spec.rb' - 'spec/services/jira_connect/sync_service_spec.rb' - 'spec/services/merge_requests/link_lfs_objects_service_spec.rb' @@ -338,9 +372,9 @@ Layout/FirstArrayElementIndentation: - 'spec/simplecov_env.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - 'spec/support/capybara.rb' + - 'spec/support/helpers/project_template_test_helper.rb' - 'spec/support/helpers/test_env.rb' - 'spec/support/helpers/usage_data_helpers.rb' - - 'spec/support/matchers/background_migrations_matchers.rb' - 'spec/support/matchers/exceed_query_limit.rb' - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb' - 'spec/support/prometheus/additional_metrics_shared_examples.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 22d66dcb8c1..94ad3fde252 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -1,10 +1,9 @@ --- # Cop supports --auto-correct. Layout/FirstHashElementIndentation: - # Offense count: 1995 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'app/components/diffs/stats_component.rb' + - 'app/controllers/admin/ci/variables_controller.rb' - 'app/controllers/admin/system_info_controller.rb' - 'app/controllers/boards/issues_controller.rb' - 'app/controllers/concerns/issuable_actions.rb' @@ -13,7 +12,6 @@ Layout/FirstHashElementIndentation: - 'app/controllers/concerns/sourcegraph_decorator.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - 'app/controllers/projects/badges_controller.rb' - - 'app/controllers/projects/merge_requests_controller.rb' - 'app/controllers/repositories/lfs_locks_api_controller.rb' - 'app/experiments/concerns/project_commit_count.rb' - 'app/graphql/mutations/clusters/agent_tokens/create.rb' @@ -26,12 +24,12 @@ Layout/FirstHashElementIndentation: - 'app/helpers/breadcrumbs_helper.rb' - 'app/helpers/broadcast_messages_helper.rb' - 'app/helpers/commits_helper.rb' - - 'app/helpers/diff_helper.rb' - 'app/helpers/environments_helper.rb' - 'app/helpers/icons_helper.rb' - 'app/helpers/keyset_helper.rb' - 'app/helpers/listbox_helper.rb' - 'app/helpers/page_layout_helper.rb' + - 'app/helpers/projects/project_members_helper.rb' - 'app/helpers/search_helper.rb' - 'app/helpers/sorting_helper.rb' - 'app/helpers/ssh_keys_helper.rb' @@ -45,6 +43,7 @@ Layout/FirstHashElementIndentation: - 'app/models/ci/build_metadata.rb' - 'app/models/ci/runner.rb' - 'app/models/clusters/applications/crossplane.rb' + - 'app/models/clusters/platforms/kubernetes.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/concerns/featurable.rb' - 'app/models/concerns/has_wiki_page_slug_attributes.rb' @@ -65,14 +64,27 @@ Layout/FirstHashElementIndentation: - 'app/serializers/cluster_serializer.rb' - 'app/serializers/detailed_status_entity.rb' - 'app/services/award_emojis/base_service.rb' + - 'app/services/ci/runners/reconcile_existing_runner_versions_service.rb' - 'app/services/google_cloud/create_service_accounts_service.rb' - 'app/services/members/create_service.rb' - 'app/services/notification_service.rb' - 'app/services/packages/composer/create_package_service.rb' + - 'app/services/pages/delete_service.rb' + - 'app/services/projects/after_rename_service.rb' + - 'app/services/projects/create_service.rb' + - 'app/services/projects/destroy_service.rb' + - 'app/services/projects/transfer_service.rb' + - 'app/services/projects/update_pages_service.rb' + - 'app/services/projects/update_service.rb' - 'app/services/resource_events/change_milestone_service.rb' - 'app/services/spam/ham_service.rb' + - 'app/services/timelogs/base_service.rb' - 'app/validators/addressable_url_validator.rb' - 'app/workers/concerns/cluster_cleanup_methods.rb' + - 'ee/app/components/namespaces/free_user_cap/alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/personal_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/personal_preview_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/preview_alert_component.rb' - 'ee/app/controllers/groups/analytics/tasks_by_type_controller.rb' - 'ee/app/graphql/mutations/boards/epic_lists/destroy.rb' - 'ee/app/graphql/mutations/boards/epics/create.rb' @@ -81,9 +93,12 @@ Layout/FirstHashElementIndentation: - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_compliance_framework.rb' - 'ee/app/graphql/mutations/security_policy/commit_scan_execution_policy.rb' + - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/ci/jobs_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' + - 'ee/app/helpers/ee/members_helper.rb' + - 'ee/app/helpers/ee/namespaces_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/sidebars_helper.rb' - 'ee/app/helpers/ee/tree_helper.rb' @@ -96,19 +111,22 @@ Layout/FirstHashElementIndentation: - 'ee/app/serializers/ee/environment_serializer.rb' - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - 'ee/app/services/app_sec/dast/site_profiles/update_service.rb' + - 'ee/app/services/audit_events/build_service.rb' - 'ee/app/services/ee/auth/container_registry_authentication_service.rb' - 'ee/app/services/ee/ci/register_job_service.rb' - 'ee/app/services/ee/issues/export_csv_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/gitlab_subscriptions/plan_upgrade_service.rb' + - 'ee/app/services/incident_management/issuable_resource_links/base_service.rb' - 'ee/app/services/jira/requests/issues/list_service.rb' - - 'ee/app/services/projects/slack_application_install_service.rb' - 'ee/app/services/security/token_revocation_service.rb' - 'ee/app/services/timebox_report_service.rb' - 'ee/app/workers/elastic_delete_project_worker.rb' - 'ee/app/workers/groups/create_event_worker.rb' - 'ee/lib/api/epic_links.rb' + - 'ee/lib/ee/api/geo.rb' - 'ee/lib/ee/container_registry/client.rb' + - 'ee/lib/ee/gitlab/application_rate_limiter.rb' - 'ee/lib/ee/gitlab/ci/parsers.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/elastic/latest/application_class_proxy.rb' @@ -122,20 +140,23 @@ Layout/FirstHashElementIndentation: - 'ee/spec/controllers/boards/users_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/variables_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' - 'ee/spec/controllers/groups/issues_controller_spec.rb' - 'ee/spec/controllers/projects/boards_controller_spec.rb' - 'ee/spec/controllers/projects/feature_flag_issues_controller_spec.rb' - 'ee/spec/controllers/projects/imports_controller_spec.rb' + - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - 'ee/spec/controllers/projects/licenses_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - 'ee/spec/controllers/security/projects_controller_spec.rb' - - 'ee/spec/elastic/migrate/20210421140400_add_new_data_to_merge_requests_documents_spec.rb' - - 'ee/spec/elastic/migrate/20210623081800_add_upvotes_to_issues_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/factories/dependencies.rb' - 'ee/spec/factories/licenses.rb' + - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' + - 'ee/spec/finders/security/scan_execution_policies_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' - 'ee/spec/frontend/fixtures/search.rb' @@ -143,9 +164,14 @@ Layout/FirstHashElementIndentation: - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/access_tokens_helper_spec.rb' + - 'ee/spec/helpers/ee/groups_helper_spec.rb' + - 'ee/spec/helpers/ee/invite_members_helper_spec.rb' - 'ee/spec/helpers/ee/labels_helper_spec.rb' + - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/sast_configuration_helper_spec.rb' + - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - 'ee/spec/helpers/groups/sso_helper_spec.rb' - 'ee/spec/helpers/nav/new_dropdown_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' @@ -154,17 +180,19 @@ Layout/FirstHashElementIndentation: - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/trial_registrations/reassurances_helper_spec.rb' - 'ee/spec/lib/container_registry/client_spec.rb' - - 'ee/spec/lib/ee/audit/project_changes_auditor_spec.rb' + - 'ee/spec/lib/ee/backup/repositories_spec.rb' - 'ee/spec/lib/ee/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/bridge_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' + - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb' - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/membership_updater_spec.rb' + - 'ee/spec/lib/gitlab/auth/saml/membership_updater_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb' - 'ee/spec/lib/gitlab/ci/config/entry/job_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' @@ -173,9 +201,11 @@ Layout/FirstHashElementIndentation: - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'ee/spec/lib/gitlab/contribution_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' - 'ee/spec/lib/gitlab/web_ide/config/entry/schemas_spec.rb' + - 'ee/spec/lib/system_check/app/search_check_spec.rb' - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/project_stage_spec.rb' @@ -186,25 +216,28 @@ Layout/FirstHashElementIndentation: - 'ee/spec/models/security/finding_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - 'ee/spec/requests/api/experiments_spec.rb' + - 'ee/spec/requests/api/geo_spec.rb' - 'ee/spec/requests/api/graphql/app_sec/fuzzing/api/ci_configuration_type_spec.rb' - 'ee/spec/requests/api/graphql/app_sec/fuzzing/coverage/corpus_type_spec.rb' - 'ee/spec/requests/api/graphql/ci/minutes/usage_spec.rb' - - 'ee/spec/requests/api/graphql/merge_requests/approval_state_spec.rb' - 'ee/spec/requests/api/graphql/milestone_spec.rb' - 'ee/spec/requests/api/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/gitlab_subscriptions/activate_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/issues/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/timelogs/create_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb' - 'ee/spec/requests/api/members_spec.rb' - 'ee/spec/requests/api/merge_requests_spec.rb' - 'ee/spec/requests/groups/group_members_controller_spec.rb' + - 'ee/spec/requests/groups/usage_quotas_spec.rb' - 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb' - 'ee/spec/requests/projects/mirrors_controller_spec.rb' - 'ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb' - 'ee/spec/serializers/license_entity_spec.rb' - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb' + - 'ee/spec/serializers/security/vulnerability_report_data_entity_spec.rb' + - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/data_loader_service_spec.rb' - 'ee/spec/services/app_sec/dast/profile_schedules/audit/update_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/audit/update_service_spec.rb' @@ -220,19 +253,29 @@ Layout/FirstHashElementIndentation: - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb' - 'ee/spec/services/approval_rules/create_service_spec.rb' - 'ee/spec/services/approval_rules/update_service_spec.rb' + - 'ee/spec/services/arkose/user_verification_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - 'ee/spec/services/ci/create_pipeline_service_spec.rb' + - 'ee/spec/services/ci/runners/stale_group_runners_prune_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/create_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb' - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - 'ee/spec/services/ee/post_receive_service_spec.rb' + - 'ee/spec/services/external_status_checks/create_service_spec.rb' - 'ee/spec/services/geo/node_status_request_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/check_future_renewal_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/create_trial_or_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/reconciliations/check_seat_usage_alerts_eligibility_service_spec.rb' - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/destroy_service_spec.rb' - 'ee/spec/services/iterations/create_service_spec.rb' + - 'ee/spec/services/namespaces/free_user_cap/deactivate_members_over_limit_service_spec.rb' + - 'ee/spec/services/namespaces/free_user_cap/remove_group_group_links_outside_hierarchy_service_spec.rb' - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' @@ -242,9 +285,16 @@ Layout/FirstHashElementIndentation: - 'ee/spec/services/security/token_revocation_service_spec.rb' - 'ee/spec/services/security/track_scan_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' + - 'ee/spec/services/users/abuse/excessive_projects_download_ban_service_spec.rb' + - 'ee/spec/services/users/abuse/git_abuse/namespace_throttle_service_spec.rb' - 'ee/spec/support/helpers/ee/login_helpers.rb' - 'ee/spec/support/shared_contexts/fixtures/analytics_shared_context.rb' - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' + - 'ee/spec/support/shared_examples/controllers/namespace_storage_limit_alert_shared_examples.rb' + - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' + - 'ee/spec/workers/analytics/cycle_analytics/consistency_worker_spec.rb' + - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb' + - 'ee/spec/workers/gitlab_subscriptions/notify_seats_exceeded_worker_spec.rb' - 'lib/api/admin/instance_clusters.rb' - 'lib/api/group_clusters.rb' - 'lib/api/project_clusters.rb' @@ -264,6 +314,7 @@ Layout/FirstHashElementIndentation: - 'lib/gitlab/github_import/importer/diff_note_importer.rb' - 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb' - 'lib/gitlab/gitlab_import/client.rb' + - 'lib/gitlab/graphql/query_analyzers/ast/logger_analyzer.rb' - 'lib/gitlab/hook_data/issue_builder.rb' - 'lib/gitlab/hook_data/release_builder.rb' - 'lib/gitlab/kubernetes.rb' @@ -279,10 +330,9 @@ Layout/FirstHashElementIndentation: - 'qa/qa/ee/resource/board/board_list/project/assignee_board_list.rb' - 'qa/qa/ee/resource/board/board_list/project/milestone_board_list.rb' - 'qa/qa/resource/snippet.rb' + - 'qa/qa/specs/features/api/3_create/repository/commit_to_templated_project_spec.rb' - 'qa/qa/specs/features/api/5_package/container_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/snippet/copy_snippet_file_contents_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_fork_in_web_ide_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_omnibus_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb' @@ -294,8 +344,11 @@ Layout/FirstHashElementIndentation: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' + - 'spec/components/diffs/stats_component_spec.rb' + - 'spec/components/pajamas/component_spec.rb' - 'spec/config/object_store_settings_spec.rb' - 'spec/config/smime_signature_settings_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' @@ -319,7 +372,6 @@ Layout/FirstHashElementIndentation: - 'spec/controllers/projects/environments_controller_spec.rb' - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/grafana_api_controller_spec.rb' - - 'spec/controllers/projects/group_links_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' @@ -336,27 +388,31 @@ Layout/FirstHashElementIndentation: - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/factories/ci/builds.rb' - - 'spec/factories/container_repositories.rb' - 'spec/factories/packages/debian/file_metadatum.rb' - 'spec/features/gitlab_experiments_spec.rb' - 'spec/frontend/fixtures/autocomplete_sources.rb' - 'spec/frontend/fixtures/blob.rb' + - 'spec/frontend/fixtures/jobs.rb' - 'spec/frontend/fixtures/runner.rb' - 'spec/graphql/mutations/release_asset_links/create_spec.rb' - 'spec/graphql/resolvers/concerns/caching_array_resolver_spec.rb' + - 'spec/graphql/resolvers/crm/organizations_resolver_spec.rb' - 'spec/graphql/types/ci/detailed_status_type_spec.rb' + - 'spec/helpers/access_tokens_helper_spec.rb' + - 'spec/helpers/admin/application_settings/settings_helper_spec.rb' - 'spec/helpers/admin/deploy_key_helper_spec.rb' - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/ci/builds_helper_spec.rb' - 'spec/helpers/ci/jobs_helper_spec.rb' - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' - - 'spec/helpers/ci/runners_helper_spec.rb' - 'spec/helpers/deploy_tokens_helper_spec.rb' - 'spec/helpers/groups/settings_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' - 'spec/helpers/issuables_helper_spec.rb' - 'spec/helpers/namespaces_helper_spec.rb' - 'spec/helpers/page_layout_helper_spec.rb' - 'spec/helpers/projects/cluster_agents_helper_spec.rb' + - 'spec/helpers/projects/pipeline_helper_spec.rb' - 'spec/helpers/releases_helper_spec.rb' - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' @@ -367,14 +423,18 @@ Layout/FirstHashElementIndentation: - 'spec/lib/api/entities/design_management/design_spec.rb' - 'spec/lib/api/entities/merge_request_approvals_spec.rb' - 'spec/lib/api/entities/personal_access_token_spec.rb' + - 'spec/lib/api/entities/personal_access_token_with_details_spec.rb' - 'spec/lib/atlassian/jira_connect/client_spec.rb' - 'spec/lib/backup/database_spec.rb' + - 'spec/lib/backup/repositories_spec.rb' - 'spec/lib/banzai/filter/audio_link_filter_spec.rb' - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - 'spec/lib/banzai/filter/video_link_filter_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/milestones_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/pipelines/project_entities_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' + - 'spec/lib/bulk_imports/groups/stage_spec.rb' + - 'spec/lib/bulk_imports/groups/transformers/group_attributes_transformer_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/container_expiration_policy_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - 'spec/lib/container_registry/client_spec.rb' @@ -402,9 +462,11 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/ci/config/yaml/tags/resolver_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' + - 'spec/lib/gitlab/ci/parsers/sbom/source/dependency_scanning_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build/cache_spec.rb' + - 'spec/lib/gitlab/ci/reports/coverage_report_spec.rb' - 'spec/lib/gitlab/ci/reports/security/identifier_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - 'spec/lib/gitlab/ci/reports/terraform_reports_spec.rb' @@ -412,11 +474,15 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/config_checker/external_database_checker_spec.rb' - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' - 'spec/lib/gitlab/data_builder/build_spec.rb' + - 'spec/lib/gitlab/data_builder/issuable_spec.rb' - 'spec/lib/gitlab/data_builder/pipeline_spec.rb' - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/diff/position_spec.rb' + - 'spec/lib/gitlab/error_tracking/error_repository/open_api_strategy_spec.rb' + - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - 'spec/lib/gitlab/experimentation_spec.rb' - 'spec/lib/gitlab/git/conflict/file_spec.rb' @@ -428,6 +494,7 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/github_import/logger_spec.rb' - 'spec/lib/gitlab/github_import/object_counter_spec.rb' - 'spec/lib/gitlab/gpg_spec.rb' + - 'spec/lib/gitlab/graphql/query_analyzers/ast/logger_analyzer_spec.rb' - 'spec/lib/gitlab/graphql/tracers/logger_tracer_spec.rb' - 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb' - 'spec/lib/gitlab/http_spec.rb' @@ -439,6 +506,7 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/kubernetes/rollout_instances_spec.rb' - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb' + - 'spec/lib/gitlab/memory/watchdog_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb' - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb' @@ -448,7 +516,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/push_options_spec.rb' - 'spec/lib/gitlab/submodule_links_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' - - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/web_ide/config/entry/global_spec.rb' - 'spec/lib/mattermost/team_spec.rb' @@ -456,11 +523,13 @@ Layout/FirstHashElementIndentation: - 'spec/lib/peek/views/memory_spec.rb' - 'spec/mailers/emails/merge_requests_spec.rb' - 'spec/models/active_session_spec.rb' + - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci_platform_metric_spec.rb' - 'spec/models/clusters/applications/prometheus_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/gpg_key_spec.rb' + - 'spec/models/instance_configuration_spec.rb' - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/chat_message/deployment_message_spec.rb' - 'spec/models/integrations/chat_message/issue_message_spec.rb' @@ -480,12 +549,14 @@ Layout/FirstHashElementIndentation: - 'spec/requests/api/feature_flags_spec.rb' - 'spec/requests/api/feature_flags_user_lists_spec.rb' - 'spec/requests/api/graphql/ci/config_spec.rb' + - 'spec/requests/api/graphql/ci/group_variables_spec.rb' + - 'spec/requests/api/graphql/ci/instance_variables_spec.rb' + - 'spec/requests/api/graphql/ci/project_variables_spec.rb' - 'spec/requests/api/graphql/group/milestones_spec.rb' - 'spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb' + - 'spec/requests/api/graphql/mutations/timelogs/create_spec.rb' - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - - 'spec/requests/api/graphql/project/terraform/state_spec.rb' - - 'spec/requests/api/graphql/project/terraform/states_spec.rb' - 'spec/requests/api/graphql/project_query_spec.rb' - 'spec/requests/api/internal/base_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' @@ -503,19 +574,29 @@ Layout/FirstHashElementIndentation: - 'spec/requests/jira_connect/installations_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' - 'spec/serializers/blob_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/artifact_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/repository_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/tag_entity_spec.rb' + - 'spec/services/bulk_imports/create_pipeline_trackers_service_spec.rb' - 'spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb' - 'spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - 'spec/services/ci/play_manual_stage_service_spec.rb' + - 'spec/services/ci/runners/reconcile_existing_runner_versions_service_spec.rb' - 'spec/services/clusters/agents/create_service_spec.rb' - 'spec/services/clusters/applications/check_ingress_ip_address_service_spec.rb' - 'spec/services/clusters/aws/authorize_role_service_spec.rb' - 'spec/services/clusters/update_service_spec.rb' - 'spec/services/commits/tag_service_spec.rb' + - 'spec/services/database/consistency_check_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' + - 'spec/services/google_cloud/create_cloudsql_instance_service_spec.rb' + - 'spec/services/import/fogbugz_service_spec.rb' - 'spec/services/import/github_service_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' + - 'spec/services/markdown_content_rewriter_service_spec.rb' + - 'spec/services/merge_requests/build_service_spec.rb' - 'spec/services/merge_requests/create_service_spec.rb' - 'spec/services/merge_requests/get_urls_service_spec.rb' - 'spec/services/merge_requests/refresh_service_spec.rb' @@ -528,6 +609,7 @@ Layout/FirstHashElementIndentation: - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - 'spec/services/projects/operations/update_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' + - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - 'spec/services/snippets/count_service_spec.rb' - 'spec/sidekiq_cluster/sidekiq_cluster_spec.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' @@ -541,6 +623,9 @@ Layout/FirstHashElementIndentation: - 'spec/support/shared_contexts/fixtures/analytics_shared_context.rb' - 'spec/support/shared_contexts/lib/container_registry/client_shared_context.rb' - 'spec/support/shared_examples/graphql/spam_protection_shared_examples.rb' + - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/repositories_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb' - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' @@ -551,4 +636,6 @@ Layout/FirstHashElementIndentation: - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' + - 'spec/views/projects/issues/_issue.html.haml_spec.rb' + - 'spec/workers/ci/runners/reconcile_existing_runner_versions_cron_worker_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml index d6772537f47..4a98bcea706 100644 --- a/.rubocop_todo/layout/hash_alignment.yml +++ b/.rubocop_todo/layout/hash_alignment.yml @@ -1,378 +1,26 @@ --- # Cop supports --auto-correct. Layout/HashAlignment: - # Offense count: 3804 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - - 'app/controllers/admin/ci/variables_controller.rb' - - 'app/controllers/admin/system_info_controller.rb' - - 'app/controllers/oauth/token_info_controller.rb' - - 'app/controllers/projects/feature_flags_controller.rb' - - 'app/controllers/repositories/git_http_client_controller.rb' - - 'app/controllers/repositories/lfs_api_controller.rb' - - 'app/controllers/repositories/lfs_locks_api_controller.rb' - - 'app/controllers/uploads_controller.rb' - - 'app/graphql/mutations/award_emojis/toggle.rb' - - 'app/graphql/mutations/ci/runner/update.rb' - - 'app/graphql/mutations/design_management/move.rb' - - 'app/graphql/mutations/issues/set_severity.rb' - - 'app/graphql/mutations/security/ci_configuration/base_security_analyzer.rb' - - 'app/graphql/resolvers/ci/template_resolver.rb' - - 'app/graphql/resolvers/projects_resolver.rb' - - 'app/graphql/resolvers/users_resolver.rb' - - 'app/graphql/types/access_level_type.rb' - - 'app/graphql/types/admin/analytics/usage_trends/measurement_type.rb' - - 'app/graphql/types/board_list_type.rb' - - 'app/graphql/types/board_type.rb' - - 'app/graphql/types/ci/analytics_type.rb' - - 'app/graphql/types/ci/application_setting_type.rb' - - 'app/graphql/types/ci/build_need_type.rb' - - 'app/graphql/types/ci/ci_cd_setting_type.rb' - - 'app/graphql/types/ci/config/config_type.rb' - - 'app/graphql/types/ci/config/group_type.rb' - - 'app/graphql/types/ci/config/job_restriction_type.rb' - - 'app/graphql/types/ci/config/job_type.rb' - - 'app/graphql/types/ci/config/need_type.rb' - - 'app/graphql/types/ci/config/stage_type.rb' - - 'app/graphql/types/ci/detailed_status_type.rb' - - 'app/graphql/types/ci/group_type.rb' - - 'app/graphql/types/ci/job_artifact_type.rb' - - 'app/graphql/types/ci/job_token_scope_type.rb' - - 'app/graphql/types/ci/job_type.rb' - - 'app/graphql/types/ci/pipeline_message_type.rb' - - 'app/graphql/types/ci/pipeline_type.rb' - - 'app/graphql/types/ci/recent_failures_type.rb' - - 'app/graphql/types/ci/runner_architecture_type.rb' - - 'app/graphql/types/ci/runner_platform_type.rb' - - 'app/graphql/types/ci/runner_setup_type.rb' - - 'app/graphql/types/ci/runner_type.rb' - - 'app/graphql/types/ci/runner_web_url_edge.rb' - - 'app/graphql/types/ci/stage_type.rb' - - 'app/graphql/types/ci/status_action_type.rb' - - 'app/graphql/types/ci/template_type.rb' - - 'app/graphql/types/ci/test_case_type.rb' - - 'app/graphql/types/ci/test_report_summary_type.rb' - - 'app/graphql/types/ci/test_report_total_type.rb' - - 'app/graphql/types/ci/test_suite_summary_type.rb' - - 'app/graphql/types/ci/test_suite_type.rb' - - 'app/graphql/types/ci_configuration/sast/analyzers_entity_input_type.rb' - - 'app/graphql/types/ci_configuration/sast/analyzers_entity_type.rb' - - 'app/graphql/types/ci_configuration/sast/entity_input_type.rb' - - 'app/graphql/types/ci_configuration/sast/entity_type.rb' - - 'app/graphql/types/ci_configuration/sast/options_entity_type.rb' - - 'app/graphql/types/ci_configuration/sast/type.rb' - - 'app/graphql/types/commit_action_type.rb' - - 'app/graphql/types/commit_type.rb' - - 'app/graphql/types/countable_connection_type.rb' - - 'app/graphql/types/design_management/design_collection_type.rb' - - 'app/graphql/types/design_management/design_fields.rb' - - 'app/graphql/types/design_management/version_type.rb' - - 'app/graphql/types/diff_paths_input_type.rb' - - 'app/graphql/types/diff_refs_type.rb' - - 'app/graphql/types/diff_stats_summary_type.rb' - - 'app/graphql/types/diff_stats_type.rb' - - 'app/graphql/types/environment_type.rb' - - 'app/graphql/types/evidence_type.rb' - - 'app/graphql/types/grafana_integration_type.rb' - - 'app/graphql/types/group_invitation_type.rb' - - 'app/graphql/types/group_member_type.rb' - - 'app/graphql/types/group_type.rb' - - 'app/graphql/types/invitation_interface.rb' - - 'app/graphql/types/issue_type.rb' - - 'app/graphql/types/jira_import_type.rb' - - 'app/graphql/types/jira_user_type.rb' - - 'app/graphql/types/label_type.rb' - - 'app/graphql/types/member_interface.rb' - - 'app/graphql/types/merge_request_connection_type.rb' - - 'app/graphql/types/merge_request_type.rb' - - 'app/graphql/types/metadata/kas_type.rb' - - 'app/graphql/types/metadata_type.rb' - - 'app/graphql/types/metrics/dashboard_type.rb' - - 'app/graphql/types/metrics/dashboards/annotation_type.rb' - - 'app/graphql/types/milestone_stats_type.rb' - - 'app/graphql/types/milestone_type.rb' - - 'app/graphql/types/namespace_type.rb' - - 'app/graphql/types/notes/diff_image_position_input_type.rb' - - 'app/graphql/types/notes/diff_position_base_input_type.rb' - - 'app/graphql/types/notes/diff_position_input_type.rb' - - 'app/graphql/types/notes/diff_position_type.rb' - - 'app/graphql/types/notes/discussion_type.rb' - - 'app/graphql/types/notes/note_type.rb' - - 'app/graphql/types/packages/package_details_type.rb' - - 'app/graphql/types/packages/package_file_type.rb' - - 'app/graphql/types/packages/package_type.rb' - - 'app/graphql/types/project_invitation_type.rb' - - 'app/graphql/types/project_member_type.rb' - - 'app/graphql/types/project_statistics_type.rb' - - 'app/graphql/types/project_type.rb' - - 'app/graphql/types/projects/service_type.rb' - - 'app/graphql/types/projects/services/jira_project_type.rb' - - 'app/graphql/types/projects/topic_type.rb' - - 'app/graphql/types/prometheus_alert_type.rb' - - 'app/graphql/types/release_asset_link_type.rb' - - 'app/graphql/types/release_assets_type.rb' - - 'app/graphql/types/release_links_type.rb' - - 'app/graphql/types/release_source_type.rb' - - 'app/graphql/types/release_type.rb' - - 'app/graphql/types/repository/blob_type.rb' - - 'app/graphql/types/repository_type.rb' - - 'app/graphql/types/resolvable_interface.rb' - - 'app/graphql/types/snippet_type.rb' - - 'app/graphql/types/snippets/blob_connection_type.rb' - - 'app/graphql/types/snippets/blob_type.rb' - - 'app/graphql/types/subscription_type.rb' - - 'app/graphql/types/task_completion_status.rb' - - 'app/graphql/types/tree/blob_type.rb' - - 'app/graphql/types/tree/entry_type.rb' - - 'app/graphql/types/tree/submodule_type.rb' - - 'app/graphql/types/tree/tree_entry_type.rb' - - 'app/graphql/types/tree/tree_type.rb' - - 'app/graphql/types/user_callout_type.rb' - - 'app/graphql/types/user_interface.rb' - - 'app/graphql/types/user_status_type.rb' - - 'app/graphql/types/work_item_type.rb' - - 'app/graphql/types/work_items/type_type.rb' - - 'app/helpers/avatars_helper.rb' - - 'app/helpers/blob_helper.rb' - - 'app/helpers/commits_helper.rb' - - 'app/helpers/environments_helper.rb' - - 'app/helpers/events_helper.rb' - - 'app/helpers/markup_helper.rb' - - 'app/helpers/preferences_helper.rb' - - 'app/helpers/projects_helper.rb' - - 'app/helpers/sorting_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/helpers/wiki_helper.rb' - - 'app/mailers/abuse_report_mailer.rb' - - 'app/mailers/emails/projects.rb' - - 'app/models/bulk_imports/configuration.rb' - - 'app/models/ci/bridge.rb' - - 'app/models/ci/build_trace_metadata.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/compare.rb' - - 'app/models/concerns/ci/has_status.rb' - - 'app/models/concerns/enums/data_visualization_palette.rb' - - 'app/models/concerns/featurable.rb' - - 'app/models/concerns/issuable.rb' - - 'app/models/concerns/triggerable_hooks.rb' - - 'app/models/container_repository.rb' - - 'app/models/design_management/design.rb' - - 'app/models/design_management/design_action.rb' - - 'app/models/event.rb' - - 'app/models/grafana_integration.rb' - - 'app/models/group.rb' - - 'app/models/hooks/web_hook.rb' - - 'app/models/integrations/emails_on_push.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/issuable_severity.rb' - - 'app/models/jira_connect_installation.rb' - - 'app/models/loose_foreign_keys/deleted_record.rb' - - 'app/models/merge_request.rb' - - 'app/models/merge_request_diff.rb' - - 'app/models/pages_domain.rb' - - 'app/models/project.rb' - - 'app/models/prometheus_alert.rb' - - 'app/models/serverless/domain_cluster.rb' - - 'app/models/snippet.rb' - - 'app/models/terraform/state.rb' - - 'app/models/user.rb' - - 'app/models/user_status.rb' - - 'app/models/wiki.rb' - - 'app/models/work_items/type.rb' - - 'app/presenters/analytics/cycle_analytics/stage_presenter.rb' - - 'app/presenters/project_presenter.rb' - - 'app/serializers/rollout_status_entity.rb' - - 'app/services/chat_names/authorize_user_service.rb' - - 'app/services/ci/archive_trace_service.rb' - - 'app/services/ci/job_artifacts/destroy_batch_service.rb' - - 'app/services/ci/list_config_variables_service.rb' - - 'app/services/ci/parse_dotenv_artifact_service.rb' - - 'app/services/ci/stuck_builds/drop_helpers.rb' - - 'app/services/groups/import_export/import_service.rb' - - 'app/services/issuable/import_csv/base_service.rb' - - 'app/services/issues/export_csv_service.rb' - - 'app/services/jira/requests/base.rb' - - 'app/services/merge_requests/mergeability_check_service.rb' - - 'app/services/merge_requests/push_options_handler_service.rb' - - 'app/services/merge_requests/toggle_attention_requested_service.rb' - - 'app/services/packages/conan/create_package_file_service.rb' - - 'app/services/packages/create_package_file_service.rb' - - 'app/services/packages/debian/create_package_file_service.rb' - - 'app/services/packages/npm/create_package_service.rb' - - 'app/services/projects/fork_service.rb' - - 'app/services/projects/lfs_pointers/lfs_download_service.rb' - - 'app/services/projects/update_remote_mirror_service.rb' - - 'app/uploaders/file_uploader.rb' - - 'app/workers/emails_on_push_worker.rb' - - 'app/workers/x509_issuer_crl_check_worker.rb' - - 'config/initializers/1_settings.rb' - - 'config/initializers/default_url_options.rb' - - 'config/initializers/rest-client-hostname_override.rb' - - 'config/routes/profile.rb' - - 'config/routes/project.rb' - - 'config/routes/unmatched_project.rb' - - 'config/routes/uploads.rb' - - 'db/migrate/20210601080039_group_protected_environments_add_index_and_constraint.rb' - - 'db/migrate/20210804150320_create_base_work_item_types.rb' - - 'db/migrate/20210831203408_upsert_base_work_item_types.rb' - - 'db/migrate/20210901065504_add_index_on_name_and_id_to_public_groups.rb' - - 'db/post_migrate/20210311120156_backfill_push_event_payload_event_id_for_bigint_conversion.rb' - - 'db/post_migrate/20210622045705_finalize_events_bigint_conversion.rb' - - 'db/post_migrate/20210701141346_finalize_ci_builds_stage_id_bigint_conversion.rb' - - 'db/post_migrate/20210707210916_finalize_ci_stages_bigint_conversion.rb' - - 'db/post_migrate/20210708011426_finalize_ci_builds_metadata_bigint_conversion.rb' - - 'db/post_migrate/20210802043253_finalize_push_event_payloads_bigint_conversion_3.rb' - - 'db/post_migrate/20210804151444_prepare_indexes_for_ci_job_artifact_bigint_conversion.rb' - - 'db/post_migrate/20210804153307_prepare_indexes_for_tagging_bigint_conversion.rb' - - 'db/post_migrate/20210804154407_prepare_indexes_for_ci_stage_bigint_conversion.rb' - - 'db/post_migrate/20210817024335_prepare_indexes_for_events_bigint_conversion.rb' - - 'db/post_migrate/20210824174615_prepare_ci_builds_metadata_and_ci_build_async_indexes.rb' - - 'ee/app/controllers/ee/search_controller.rb' - - 'ee/app/controllers/projects/integrations/zentao/issues_controller.rb' - - 'ee/app/graphql/ee/types/board_list_type.rb' - - 'ee/app/graphql/ee/types/board_type.rb' - - 'ee/app/graphql/ee/types/ci/runner_type.rb' - - 'ee/app/graphql/ee/types/group_type.rb' - - 'ee/app/graphql/ee/types/issue_type.rb' - - 'ee/app/graphql/ee/types/merge_request_type.rb' - - 'ee/app/graphql/ee/types/project_type.rb' - - 'ee/app/graphql/ee/types/repository/blob_type.rb' - - 'ee/app/graphql/mutations/iterations/cadences/create.rb' - - 'ee/app/graphql/mutations/iterations/cadences/destroy.rb' - - 'ee/app/graphql/mutations/iterations/cadences/update.rb' - - 'ee/app/graphql/mutations/iterations/delete.rb' - - 'ee/app/graphql/mutations/projects/set_locked.rb' - - 'ee/app/graphql/resolvers/iterations/cadences_resolver.rb' - - 'ee/app/graphql/resolvers/vulnerabilities_count_per_day_resolver.rb' - - 'ee/app/graphql/types/admin/cloud_licenses/current_license_type.rb' - - 'ee/app/graphql/types/admin/cloud_licenses/license_type.rb' - - 'ee/app/graphql/types/admin/cloud_licenses/subscription_future_entry_type.rb' - - 'ee/app/graphql/types/analytics/devops_adoption/enabled_namespace_type.rb' - - 'ee/app/graphql/types/analytics/devops_adoption/snapshot_type.rb' - - 'ee/app/graphql/types/app_sec/fuzzing/api/ci_configuration_type.rb' - - 'ee/app/graphql/types/app_sec/fuzzing/api/scan_profile_type.rb' - - 'ee/app/graphql/types/app_sec/fuzzing/coverage/corpus_type.rb' - - 'ee/app/graphql/types/boards/board_epic_type.rb' - - 'ee/app/graphql/types/boards/epic_board_type.rb' - - 'ee/app/graphql/types/boards/epic_list_metadata_type.rb' - - 'ee/app/graphql/types/boards/epic_list_type.rb' - - 'ee/app/graphql/types/boards/epic_user_preferences_type.rb' - - 'ee/app/graphql/types/burnup_chart_daily_totals_type.rb' - - 'ee/app/graphql/types/ci/code_coverage_activity_type.rb' - - 'ee/app/graphql/types/ci/code_coverage_summary_type.rb' - - 'ee/app/graphql/types/ci/code_quality_degradation_type.rb' - - 'ee/app/graphql/types/ci/minutes/namespace_monthly_usage_type.rb' - - 'ee/app/graphql/types/ci/minutes/project_monthly_usage_type.rb' - - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_type.rb' - - 'ee/app/graphql/types/dast/profile_branch_type.rb' - - 'ee/app/graphql/types/dast/profile_schedule_type.rb' - - 'ee/app/graphql/types/dast/profile_type.rb' - - 'ee/app/graphql/types/dast_scanner_profile_type.rb' - - 'ee/app/graphql/types/dast_site_profile_type.rb' - - 'ee/app/graphql/types/dast_site_validation_type.rb' - - 'ee/app/graphql/types/dora_metric_type.rb' - - 'ee/app/graphql/types/dora_type.rb' - - 'ee/app/graphql/types/epic_descendant_weight_sum_type.rb' - - 'ee/app/graphql/types/epic_issue_type.rb' - - 'ee/app/graphql/types/epic_type.rb' - - 'ee/app/graphql/types/external_issue_type.rb' - - 'ee/app/graphql/types/group_release_stats_type.rb' - - 'ee/app/graphql/types/instance_security_dashboard_type.rb' - - 'ee/app/graphql/types/iteration_type.rb' - - 'ee/app/graphql/types/iterations/cadence_type.rb' - - 'ee/app/graphql/types/merge_requests/approval_state_type.rb' - - 'ee/app/graphql/types/metric_image_type.rb' - - 'ee/app/graphql/types/path_lock_type.rb' - - 'ee/app/graphql/types/requirements_management/requirement_type.rb' - - 'ee/app/graphql/types/requirements_management/test_report_type.rb' - - 'ee/app/graphql/types/security/training_type.rb' - - 'ee/app/graphql/types/security/training_url_type.rb' - - 'ee/app/graphql/types/security_report_summary_type.rb' - - 'ee/app/graphql/types/security_scanners.rb' - - 'ee/app/graphql/types/time_report_stats_type.rb' - - 'ee/app/graphql/types/timebox_metrics_type.rb' - - 'ee/app/graphql/types/timebox_report_interface.rb' - - 'ee/app/graphql/types/timebox_report_type.rb' - - 'ee/app/graphql/types/vulnerabilities/asset_type.rb' - - 'ee/app/graphql/types/vulnerabilities/link_type.rb' - - 'ee/app/graphql/types/vulnerabilities_count_by_day_type.rb' - - 'ee/app/graphql/types/vulnerability/external_issue_link_type.rb' - - 'ee/app/graphql/types/vulnerability/issue_link_type.rb' - - 'ee/app/graphql/types/vulnerability_details/base_type.rb' - - 'ee/app/graphql/types/vulnerability_details/boolean_type.rb' - - 'ee/app/graphql/types/vulnerability_details/code_type.rb' - - 'ee/app/graphql/types/vulnerability_details/commit_type.rb' - - 'ee/app/graphql/types/vulnerability_details/diff_type.rb' - - 'ee/app/graphql/types/vulnerability_details/file_location_type.rb' - - 'ee/app/graphql/types/vulnerability_details/int_type.rb' - - 'ee/app/graphql/types/vulnerability_details/list_type.rb' - - 'ee/app/graphql/types/vulnerability_details/markdown_type.rb' - - 'ee/app/graphql/types/vulnerability_details/module_location_type.rb' - - 'ee/app/graphql/types/vulnerability_details/table_type.rb' - - 'ee/app/graphql/types/vulnerability_details/text_type.rb' - - 'ee/app/graphql/types/vulnerability_details/url_type.rb' - - 'ee/app/graphql/types/vulnerability_evidence_source_type.rb' - - 'ee/app/graphql/types/vulnerability_evidence_supporting_message_type.rb' - - 'ee/app/graphql/types/vulnerability_evidence_type.rb' - - 'ee/app/graphql/types/vulnerability_identifier_type.rb' - - 'ee/app/graphql/types/vulnerability_location/cluster_image_scanning_type.rb' - - 'ee/app/graphql/types/vulnerability_location/container_scanning_type.rb' - - 'ee/app/graphql/types/vulnerability_location/coverage_fuzzing_type.rb' - - 'ee/app/graphql/types/vulnerability_location/dast_type.rb' - - 'ee/app/graphql/types/vulnerability_location/dependency_scanning_type.rb' - - 'ee/app/graphql/types/vulnerability_location/generic_type.rb' - - 'ee/app/graphql/types/vulnerability_location/sast_type.rb' - - 'ee/app/graphql/types/vulnerability_location/secret_detection_type.rb' - - 'ee/app/graphql/types/vulnerability_request_response_header_type.rb' - - 'ee/app/graphql/types/vulnerability_request_type.rb' - - 'ee/app/graphql/types/vulnerability_response_type.rb' - - 'ee/app/graphql/types/vulnerability_scanner_type.rb' - - 'ee/app/graphql/types/vulnerability_severities_count_type.rb' - - 'ee/app/graphql/types/vulnerability_type.rb' - - 'ee/app/graphql/types/vulnerable_dependency_type.rb' - - 'ee/app/graphql/types/vulnerable_kubernetes_resource_type.rb' - - 'ee/app/graphql/types/vulnerable_package_type.rb' - - 'ee/app/graphql/types/vulnerable_projects_by_grade_type.rb' - - 'ee/app/helpers/ee/feature_flags_helper.rb' - - 'ee/app/helpers/ee/sorting_helper.rb' - - 'ee/app/models/allowed_email_domain.rb' - - 'ee/app/models/ci/minutes/usage.rb' - - 'ee/app/models/ee/application_setting.rb' - - 'ee/app/models/elastic/reindexing_task.rb' - - 'ee/app/models/gitlab_subscriptions/features.rb' - - 'ee/app/models/gitlab_subscriptions/upcoming_reconciliation.rb' - - 'ee/app/models/historical_data.rb' - - 'ee/app/models/incident_management/escalation_rule.rb' - - 'ee/app/models/incident_management/oncall_rotation.rb' - - 'ee/app/models/scim_identity.rb' - - 'ee/app/models/status_page/project_setting.rb' - - 'ee/app/serializers/ee/evidences/release_entity.rb' - - 'ee/app/services/ci/external_pull_requests/process_github_event_service.rb' - - 'ee/app/services/ci_cd/setup_project.rb' - - 'ee/app/services/ee/issues/base_service.rb' - - 'ee/app/services/elastic/cluster_reindexing_service.rb' - - 'ee/app/services/elastic/process_bookkeeping_service.rb' - - 'ee/app/services/epics/issue_promote_service.rb' - - 'ee/app/services/external_status_checks/create_service.rb' - - 'ee/app/services/groups/memberships/export_service.rb' - - 'ee/app/services/projects/setup_ci_cd.rb' - - 'ee/app/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service.rb' - - 'ee/config/routes/project.rb' - - 'ee/config/routes/uploads.rb' - 'ee/lib/api/iterations.rb' - 'ee/lib/api/merge_trains.rb' + - 'ee/lib/api/related_epic_links.rb' - 'ee/lib/api/vulnerability_exports.rb' - 'ee/lib/api/vulnerability_findings.rb' + - 'ee/lib/ee/api/helpers/groups_helpers.rb' - 'ee/lib/ee/api/helpers/issues_helpers.rb' - 'ee/lib/ee/api/helpers/protected_branches_helpers.rb' - 'ee/lib/ee/api/merge_requests.rb' - - 'ee/lib/ee/audit/project_changes_auditor.rb' + - 'ee/lib/ee/audit/project_setting_changes_auditor.rb' + - 'ee/lib/ee/audit/protected_branches_changes_auditor.rb' - 'ee/lib/ee/banzai/filter/references/epic_reference_filter.rb' - 'ee/lib/ee/banzai/filter/references/vulnerability_reference_filter.rb' + - 'ee/lib/ee/gitlab/application_rate_limiter.rb' - 'ee/lib/ee/gitlab/ci/pipeline/chain/validate/after_config.rb' - 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb' + - 'ee/lib/ee/gitlab/tracking.rb' - 'ee/lib/ee/gitlab/usage_data.rb' + - 'ee/lib/elastic/latest/commit_config.rb' - 'ee/lib/elastic/latest/config.rb' - 'ee/lib/elastic/latest/merge_request_config.rb' - 'ee/lib/gem_extensions/elasticsearch/model/indexing/instance_methods.rb' @@ -387,7 +35,9 @@ Layout/HashAlignment: - 'ee/spec/controllers/projects/settings/operations_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/factories/dependencies.rb' + - 'ee/spec/factories/projects.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' + - 'ee/spec/features/groups/settings/protected_environments_spec.rb' - 'ee/spec/features/projects/environments/environments_spec.rb' - 'ee/spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' - 'ee/spec/features/projects/feature_flags/user_updates_feature_flag_spec.rb' @@ -395,13 +45,21 @@ Layout/HashAlignment: - 'ee/spec/finders/merge_requests_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/graphql/ee/mutations/ci/runner/update_spec.rb' + - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/vulnerabilities/issue_links_resolver_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/config_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/need_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb' + - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' @@ -410,77 +68,48 @@ Layout/HashAlignment: - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/elastic/client_spec.rb' - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb' + - 'ee/spec/lib/gitlab/insights/loader_spec.rb' - 'ee/spec/lib/gitlab/template/custom_templates_spec.rb' - 'ee/spec/models/application_setting_spec.rb' - 'ee/spec/models/approval_merge_request_rule_spec.rb' - 'ee/spec/models/member_spec.rb' + - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' + - 'ee/spec/models/protected_environments/approval_summary_spec.rb' - 'ee/spec/models/vulnerabilities/statistic_spec.rb' + - 'ee/spec/requests/api/deployments_spec.rb' - 'ee/spec/requests/api/graphql/app_sec/fuzzing/coverage/corpus_type_spec.rb' - 'ee/spec/requests/api/graphql/group/epics_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/api/issues_spec.rb' + - 'ee/spec/requests/api/protected_environments_spec.rb' - 'ee/spec/requests/api/templates_spec.rb' + - 'ee/spec/requests/ee/projects/environments_controller_spec.rb' - 'ee/spec/requests/ee/projects/service_desk_controller_spec.rb' - 'ee/spec/requests/projects/security/dast_site_profiles_controller_spec.rb' - 'ee/spec/requests/rack_attack_global_spec.rb' - 'ee/spec/serializers/integrations/zentao_serializers/issue_entity_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' + - 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb' + - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' + - 'ee/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/cross_needs_artifacts_spec.rb' - 'ee/spec/services/ci/process_pipeline_service_spec.rb' - 'ee/spec/services/ci/retry_pipeline_service_spec.rb' - 'ee/spec/services/ci/subscribe_bridge_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' - 'ee/spec/services/merge_trains/check_status_service_spec.rb' - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' - 'ee/spec/services/status_page/unpublish_details_service_spec.rb' + - 'ee/spec/services/vulnerabilities/create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/findings/create_from_security_finding_service_spec.rb' + - 'ee/spec/support/shared_examples/services/audit_event_logging_shared_examples.rb' - 'ee/spec/support/shared_examples/status_page/publish_shared_examples.rb' - 'ee/spec/support/shared_examples/status_page/reference_links_examples.rb' - 'ee/spec/workers/scan_security_report_secrets_worker_spec.rb' - - 'lib/api/applications.rb' - - 'lib/api/broadcast_messages.rb' - - 'lib/api/bulk_imports.rb' - - 'lib/api/ci/job_artifacts.rb' - - 'lib/api/ci/jobs.rb' - - 'lib/api/ci/pipelines.rb' - - 'lib/api/ci/runner.rb' - - 'lib/api/ci/runners.rb' - - 'lib/api/concerns/packages/debian_distribution_endpoints.rb' - - 'lib/api/debian_project_packages.rb' - - 'lib/api/deploy_tokens.rb' - - 'lib/api/entities/project.rb' - - 'lib/api/feature_flags.rb' - - 'lib/api/group_labels.rb' - - 'lib/api/group_packages.rb' - - 'lib/api/groups.rb' - - 'lib/api/helm_packages.rb' - - 'lib/api/helpers/groups_helpers.rb' - - 'lib/api/helpers/merge_requests_helpers.rb' - - 'lib/api/helpers/snippets_helpers.rb' - - 'lib/api/issue_links.rb' - - 'lib/api/issues.rb' - - 'lib/api/labels.rb' - - 'lib/api/maven_packages.rb' - - 'lib/api/members.rb' - - 'lib/api/merge_requests.rb' - - 'lib/api/metrics/dashboard/annotations.rb' - - 'lib/api/metrics/user_starred_dashboards.rb' - - 'lib/api/milestone_responses.rb' - - 'lib/api/notes.rb' - - 'lib/api/pages_domains.rb' - - 'lib/api/project_packages.rb' - - 'lib/api/project_templates.rb' - - 'lib/api/projects.rb' - - 'lib/api/protected_branches.rb' - - 'lib/api/releases.rb' - - 'lib/api/rubygem_packages.rb' - - 'lib/api/sidekiq_metrics.rb' - - 'lib/api/users.rb' - - 'lib/backup/gitaly_backup.rb' - - 'lib/banzai/filter/references/abstract_reference_filter.rb' - - 'lib/banzai/reference_redactor.rb' - 'lib/gitlab/abuse.rb' - 'lib/gitlab/access.rb' - 'lib/gitlab/application_rate_limiter.rb' @@ -488,6 +117,7 @@ Layout/HashAlignment: - 'lib/gitlab/auth/o_auth/auth_hash.rb' - 'lib/gitlab/auth/o_auth/provider.rb' - 'lib/gitlab/auth/o_auth/user.rb' + - 'lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/ci/ansi2html.rb' @@ -496,7 +126,7 @@ Layout/HashAlignment: - 'lib/gitlab/ci/jwt_v2.rb' - 'lib/gitlab/ci/pipeline/chain/validate/external.rb' - 'lib/gitlab/ci/reports/security/scanner.rb' - - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb' + - 'lib/gitlab/database/background_migration/health_status.rb' - 'lib/gitlab/database/reflection.rb' - 'lib/gitlab/diff/file_collection/compare.rb' - 'lib/gitlab/email/attachment_uploader.rb' @@ -514,6 +144,7 @@ Layout/HashAlignment: - 'lib/gitlab/import_export/members_mapper.rb' - 'lib/gitlab/import_export/project/import_task.rb' - 'lib/gitlab/import_export/shared.rb' + - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' - 'lib/gitlab/kubernetes.rb' - 'lib/gitlab/marginalia/comment.rb' - 'lib/gitlab/metrics/dashboard/stages/grafana_formatter.rb' @@ -533,46 +164,56 @@ Layout/HashAlignment: - 'lib/tasks/gitlab/import_export/export.rake' - 'lib/tasks/gitlab/import_export/import.rake' - 'lib/tasks/tanuki_emoji.rake' - - 'qa/qa/specs/features/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - - 'qa/qa/support/loglinking.rb' - - 'qa/spec/support/loglinking_spec.rb' - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' - 'spec/controllers/concerns/redis_tracking_spec.rb' + - 'spec/controllers/import/bitbucket_controller_spec.rb' - 'spec/controllers/oauth/token_info_controller_spec.rb' - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/grafana_api_controller_spec.rb' - - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/merge_requests_controller_spec.rb' + - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' - 'spec/controllers/projects/registry/tags_controller_spec.rb' - 'spec/controllers/projects/service_desk_controller_spec.rb' - - 'spec/controllers/search_controller_spec.rb' + - 'spec/db/migration_spec.rb' - 'spec/factories/ci/builds.rb' - - 'spec/factories/ci/stages.rb' + - 'spec/factories/environments.rb' - 'spec/factories/groups.rb' - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' - - 'spec/features/groups/issues_spec.rb' + - 'spec/features/dashboard/todos/todos_sorting_spec.rb' + - 'spec/features/jira_oauth_provider_authorize_spec.rb' + - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb' - 'spec/features/profiles/active_sessions_spec.rb' - 'spec/features/projects/badges/coverage_spec.rb' + - 'spec/features/projects/environments/environment_spec.rb' - 'spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' - 'spec/features/projects/feature_flags/user_updates_feature_flag_spec.rb' - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' - 'spec/features/projects/milestones/milestones_sorting_spec.rb' - 'spec/features/projects/new_project_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/pipelines/pipelines_spec.rb' - 'spec/features/snippets/user_creates_snippet_spec.rb' + - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - 'spec/finders/group_descendants_finder_spec.rb' - 'spec/finders/group_members_finder_spec.rb' - 'spec/finders/template_finder_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' + - 'spec/graphql/resolvers/board_lists_resolver_spec.rb' - 'spec/graphql/resolvers/ci/config_resolver_spec.rb' + - 'spec/graphql/resolvers/ci/group_runners_resolver_spec.rb' + - 'spec/graphql/resolvers/ci/jobs_resolver_spec.rb' + - 'spec/graphql/resolvers/ci/runners_resolver_spec.rb' + - 'spec/graphql/resolvers/container_repositories_resolver_spec.rb' + - 'spec/graphql/resolvers/container_repository_tags_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/versions_resolver_spec.rb' + - 'spec/graphql/resolvers/work_items_resolver_spec.rb' + - 'spec/helpers/ci/builds_helper_spec.rb' - 'spec/helpers/sorting_helper_spec.rb' - 'spec/helpers/storage_helper_spec.rb' - 'spec/helpers/wiki_helper_spec.rb' @@ -585,6 +226,8 @@ Layout/HashAlignment: - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - 'spec/lib/gitlab/auth/o_auth/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - 'spec/lib/gitlab/ci/config/entry/port_spec.rb' @@ -594,6 +237,7 @@ Layout/HashAlignment: - 'spec/lib/gitlab/ci/pipeline/seed/deployment_spec.rb' - 'spec/lib/gitlab/ci/variables/builder_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' + - 'spec/lib/gitlab/data_builder/issuable_spec.rb' - 'spec/lib/gitlab/data_builder/note_spec.rb' - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' @@ -615,6 +259,8 @@ Layout/HashAlignment: - 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb' - 'spec/lib/gitlab/import_sources_spec.rb' - 'spec/lib/gitlab/instrumentation_helper_spec.rb' + - 'spec/lib/gitlab/jira/middleware_spec.rb' + - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator/errors_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator_spec.rb' @@ -625,9 +271,12 @@ Layout/HashAlignment: - 'spec/lib/gitlab/metrics/web_transaction_spec.rb' - 'spec/lib/gitlab/omniauth_initializer_spec.rb' - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' + - 'spec/lib/gitlab/sidekiq_death_handler_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - 'spec/lib/gitlab/slug/environment_spec.rb' - 'spec/lib/gitlab/tracking_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' + - 'spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/note_counter_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils_spec.rb' @@ -641,8 +290,11 @@ Layout/HashAlignment: - 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/processable_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' + - 'spec/models/commit_status_spec.rb' - 'spec/models/container_registry/event_spec.rb' + - 'spec/models/deployment_spec.rb' - 'spec/models/design_management/version_spec.rb' - 'spec/models/group_spec.rb' - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' @@ -651,7 +303,6 @@ Layout/HashAlignment: - 'spec/models/namespace_spec.rb' - 'spec/models/operations/feature_flag_spec.rb' - 'spec/models/pages_domain_spec.rb' - - 'spec/models/project_spec.rb' - 'spec/models/remote_mirror_spec.rb' - 'spec/models/repository_spec.rb' - 'spec/models/user_spec.rb' @@ -662,9 +313,12 @@ Layout/HashAlignment: - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - 'spec/requests/api/feature_flags_spec.rb' - 'spec/requests/api/graphql/ci/config_spec.rb' + - 'spec/requests/api/graphql/ci/group_variables_spec.rb' + - 'spec/requests/api/graphql/ci/instance_variables_spec.rb' + - 'spec/requests/api/graphql/ci/project_variables_spec.rb' - 'spec/requests/api/graphql/ci/runner_spec.rb' + - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/requests/api/graphql/mutations/releases/update_spec.rb' - - 'spec/requests/api/graphql/packages/conan_spec.rb' - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' - 'spec/requests/api/graphql/project/terraform/state_spec.rb' - 'spec/requests/api/graphql/project/terraform/states_spec.rb' @@ -672,21 +326,29 @@ Layout/HashAlignment: - 'spec/requests/api/groups_spec.rb' - 'spec/requests/api/internal/base_spec.rb' - 'spec/requests/api/issues/get_group_issues_spec.rb' + - 'spec/requests/api/projects_spec.rb' - 'spec/requests/api/suggestions_spec.rb' - 'spec/requests/api/unleash_spec.rb' - 'spec/requests/git_http_spec.rb' + - 'spec/requests/oauth_tokens_spec.rb' - 'spec/requests/openid_connect_spec.rb' + - 'spec/requests/projects/environments_controller_spec.rb' - 'spec/requests/projects/merge_requests_discussions_spec.rb' - 'spec/routing/project_routing_spec.rb' - 'spec/serializers/ci/lint/job_entity_spec.rb' - 'spec/serializers/container_repository_entity_spec.rb' + - 'spec/serializers/deployment_entity_spec.rb' + - 'spec/serializers/environment_serializer_spec.rb' - 'spec/serializers/merge_request_metrics_helper_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - 'spec/services/ci/create_pipeline_service/tags_spec.rb' - 'spec/services/ci/job_artifacts/create_service_spec.rb' + - 'spec/services/ci/retry_job_service_spec.rb' - 'spec/services/deployments/link_merge_requests_service_spec.rb' - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' + - 'spec/services/environments/stop_service_spec.rb' + - 'spec/services/event_create_service_spec.rb' - 'spec/services/groups/import_export/import_service_spec.rb' - 'spec/services/issuable/bulk_update_service_spec.rb' - 'spec/services/issues/create_service_spec.rb' @@ -698,7 +360,9 @@ Layout/HashAlignment: - 'spec/services/notes/destroy_service_spec.rb' - 'spec/services/packages/debian/parse_debian822_service_spec.rb' - 'spec/services/projects/destroy_service_spec.rb' + - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' + - 'spec/services/work_items/widgets/description_service/update_service_spec.rb' - 'spec/support/helpers/create_environments_helpers.rb' - 'spec/support/helpers/kubernetes_helpers.rb' - 'spec/support/helpers/migrations_helpers/work_item_types_helper.rb' @@ -710,6 +374,8 @@ Layout/HashAlignment: - 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb' - 'spec/support/shared_contexts/design_management_shared_contexts.rb' - 'spec/support/shared_contexts/finders/merge_requests_finder_shared_contexts.rb' + - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' + - 'spec/support/shared_examples/graphql/members_shared_examples.rb' - 'spec/support/shared_examples/lib/banzai/filters/sanitization_filter_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/database/background_migration_job_shared_examples.rb' - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 7d2674c34f8..80c0f986552 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -801,7 +801,6 @@ Layout/LineLength: - 'config/initializers/active_record_transaction_observer.rb' - 'config/initializers/carrierwave_patch.rb' - 'config/initializers/content_security_policy.rb' - - 'config/initializers/database_query_analyzers.rb' - 'config/initializers/deprecations.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/direct_upload_support.rb' @@ -1138,7 +1137,6 @@ Layout/LineLength: - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' - 'ee/app/controllers/ee/repositories/git_http_controller.rb' - 'ee/app/controllers/ee/repositories/lfs_api_controller.rb' - - 'ee/app/controllers/ee/search_controller.rb' - 'ee/app/controllers/ee/sessions_controller.rb' - 'ee/app/controllers/groups/analytics/cycle_analytics/stages_controller.rb' - 'ee/app/controllers/groups/analytics/cycle_analytics/summary_controller.rb' @@ -1181,11 +1179,6 @@ Layout/LineLength: - 'ee/app/graphql/ee/mutations/ci/runner/update.rb' - 'ee/app/graphql/ee/mutations/issues/create.rb' - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - - 'ee/app/graphql/ee/types/deprecated_mutations.rb' - - 'ee/app/graphql/ee/types/group_type.rb' - - 'ee/app/graphql/ee/types/merge_request_type.rb' - - 'ee/app/graphql/ee/types/project_type.rb' - - 'ee/app/graphql/ee/types/query_type.rb' - 'ee/app/graphql/mutations/analytics/devops_adoption/enabled_namespaces/bulk_enable.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/update.rb' @@ -1361,7 +1354,6 @@ Layout/LineLength: - 'ee/app/models/ee/merge_request_diff.rb' - 'ee/app/models/ee/milestone_release.rb' - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/namespace/root_storage_size.rb' - 'ee/app/models/ee/packages/package_file.rb' - 'ee/app/models/ee/pages_deployment.rb' - 'ee/app/models/ee/project.rb' @@ -2451,9 +2443,7 @@ Layout/LineLength: - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/models/ee/lfs_object_spec.rb' - 'ee/spec/models/ee/merge_request_diff_spec.rb' - - 'ee/spec/models/ee/namespace/root_storage_size_spec.rb' - 'ee/spec/models/ee/namespace/root_storage_statistics_spec.rb' - - 'ee/spec/models/ee/namespace_limit_spec.rb' - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/ee/namespace_statistics_spec.rb' - 'ee/spec/models/ee/preloaders/group_policy_preloader_spec.rb' @@ -4441,7 +4431,6 @@ Layout/LineLength: - 'spec/frontend/fixtures/merge_requests_diffs.rb' - 'spec/frontend/fixtures/pipeline_schedules.rb' - 'spec/frontend/fixtures/projects.rb' - - 'spec/frontend/fixtures/runner.rb' - 'spec/frontend/fixtures/snippet.rb' - 'spec/graphql/features/feature_flag_spec.rb' - 'spec/graphql/gitlab_schema_spec.rb' @@ -4623,7 +4612,6 @@ Layout/LineLength: - 'spec/lib/atlassian/jira_connect/client_spec.rb' - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - 'spec/lib/atlassian/jira_issue_key_extractor_spec.rb' - - 'spec/lib/backup/database_spec.rb' - 'spec/lib/backup/files_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - 'spec/lib/backup/manager_spec.rb' @@ -4749,7 +4737,6 @@ Layout/LineLength: - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb' - 'spec/lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature_spec.rb' - - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/populate_container_repository_migration_plan_spec.rb' - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' @@ -4858,7 +4845,6 @@ Layout/LineLength: - 'spec/lib/gitlab/database/batch_count_spec.rb' - 'spec/lib/gitlab/database/load_balancing/configuration_spec.rb' - 'spec/lib/gitlab/database/load_balancing/host_list_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/load_balancing/service_discovery_spec.rb' - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' - 'spec/lib/gitlab/database/load_balancing/sidekiq_client_middleware_spec.rb' @@ -6026,7 +6012,6 @@ Layout/LineLength: - 'spec/services/repository_archive_clean_up_service_spec.rb' - 'spec/services/resource_access_tokens/create_service_spec.rb' - 'spec/services/resource_access_tokens/revoke_service_spec.rb' - - 'spec/services/resource_events/change_labels_service_spec.rb' - 'spec/services/resource_events/change_state_service_spec.rb' - 'spec/services/resource_events/synthetic_milestone_notes_builder_service_spec.rb' - 'spec/services/search/global_service_spec.rb' diff --git a/.rubocop_todo/layout/multiline_operation_indentation.yml b/.rubocop_todo/layout/multiline_operation_indentation.yml index 51ecf97d318..cdfa560ef2e 100644 --- a/.rubocop_todo/layout/multiline_operation_indentation.yml +++ b/.rubocop_todo/layout/multiline_operation_indentation.yml @@ -1,77 +1,90 @@ --- # Cop supports --auto-correct. Layout/MultilineOperationIndentation: - # Offense count: 252 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'app/components/pajamas/concerns/checkbox_radio_label_with_help_text.rb' - 'app/controllers/projects/application_controller.rb' - 'app/controllers/repositories/git_http_client_controller.rb' - 'app/controllers/sent_notifications_controller.rb' - 'app/graphql/types/ci/stage_type.rb' - - 'app/helpers/application_settings_helper.rb' - 'app/helpers/auth_helper.rb' - 'app/helpers/issuables_helper.rb' - 'app/helpers/mirror_helper.rb' - 'app/helpers/packages_helper.rb' - 'app/helpers/projects_helper.rb' - - 'app/helpers/storage_helper.rb' - 'app/helpers/visibility_level_helper.rb' - 'app/helpers/whats_new_helper.rb' - 'app/models/concerns/admin_changed_password_notifier.rb' - 'app/models/integrations/prometheus.rb' + - 'app/models/merge_request_diff_file.rb' - 'app/models/namespaces/traversal/linear_scopes.rb' - 'app/models/packages/conan/metadatum.rb' - 'app/models/packages/sem_ver.rb' - 'app/models/project.rb' - 'app/models/project_statistics.rb' - 'app/models/user.rb' + - 'app/models/work_items/parent_link.rb' + - 'app/policies/project_policy.rb' + - 'app/serializers/deploy_keys/deploy_key_entity.rb' - 'app/services/ci/create_downstream_pipeline_service.rb' - 'app/services/ci/create_pipeline_service.rb' - 'app/services/git/branch_hooks_service.rb' - - 'app/services/groups/group_links/create_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/issues/update_service.rb' - 'app/services/labels/promote_service.rb' - 'app/services/labels/transfer_service.rb' + - 'app/services/members/approve_access_request_service.rb' - 'app/services/projects/container_repository/cleanup_tags_service.rb' - 'app/services/webauthn/authenticate_service.rb' - 'app/validators/feature_flag_strategies_validator.rb' - 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb' + - 'app/workers/container_registry/migration/guard_worker.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'danger/utility_css/Dangerfile' + - 'ee/app/controllers/ee/admin/application_settings_controller.rb' + - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' - 'ee/app/controllers/smartcard_controller.rb' - 'ee/app/graphql/resolvers/boards/epic_lists_resolver.rb' - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/boards_helper.rb' + - 'ee/app/helpers/ee/groups/group_members_helper.rb' + - 'ee/app/helpers/ee/groups/reporting_helper.rb' + - 'ee/app/helpers/ee/projects/project_members_helper.rb' - 'ee/app/helpers/groups/security_features_helper.rb' - 'ee/app/helpers/groups/sso_helper.rb' + - 'ee/app/models/approval_project_rule.rb' + - 'ee/app/models/concerns/ee/issuable.rb' - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/namespace/root_storage_size.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/ee/user.rb' - 'ee/app/models/vulnerabilities/finding_signature.rb' - 'ee/app/policies/ee/base_policy.rb' + - 'ee/app/policies/ee/merge_request_policy.rb' - 'ee/app/services/analytics/cycle_analytics/value_streams/update_service.rb' - 'ee/app/services/ee/merge_requests/build_service.rb' - 'ee/app/services/ee/projects/operations/update_service.rb' + - 'ee/app/workers/elastic/project_transfer_worker.rb' - 'ee/lib/ee/api/entities/group.rb' + - 'ee/lib/ee/api/geo.rb' - 'ee/lib/ee/api/helpers.rb' + - 'ee/lib/ee/api/settings.rb' + - 'ee/lib/ee/gitlab/git_access_project.rb' - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' - 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb' - 'ee/lib/ee/sidebars/projects/menus/ci_cd_menu.rb' - 'ee/lib/ee/sidebars/projects/menus/issues_menu.rb' - - 'ee/lib/elastic/latest/issue_class_proxy.rb' + - 'ee/lib/gitlab/incident_management.rb' - 'ee/lib/sidebars/groups/menus/analytics_menu.rb' - 'ee/lib/sidebars/groups/menus/security_compliance_menu.rb' - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' - 'lib/api/maven_packages.rb' - 'lib/api/users.rb' - 'lib/api/validations/validators/array_none_any.rb' + - 'lib/gitlab/auth/o_auth/user.rb' - 'lib/gitlab/ci/reports/security/finding_key.rb' - 'lib/gitlab/database/load_balancing/connection_proxy.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/form_builders/gitlab_ui_form_builder.rb' + - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb' - 'lib/gitlab/git_access.rb' - 'lib/gitlab/gl_repository/repo_type.rb' - 'lib/gitlab/jwt_token.rb' @@ -82,6 +95,8 @@ Layout/MultilineOperationIndentation: - 'lib/gitlab/pagination/cursor_based_keyset.rb' - 'lib/gitlab/quick_actions/issue_and_merge_request_actions.rb' - 'lib/gitlab/rack_attack/request.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' + - 'lib/gitlab/sidekiq_status.rb' - 'lib/gitlab/x509/signature.rb' - 'lib/gitlab_edition.rb' - 'lib/kramdown/converter/commonmark.rb' @@ -90,12 +105,12 @@ Layout/MultilineOperationIndentation: - 'lib/sidebars/projects/menus/deployments_menu.rb' - 'lib/sidebars/projects/menus/hidden_menu.rb' - 'lib/sidebars/projects/menus/monitor_menu.rb' - - 'lib/sidebars/projects/menus/settings_menu.rb' - 'qa/qa/ee/page/group/roadmap.rb' - 'qa/qa/page/component/snippet.rb' - 'qa/qa/runtime/api/repository_storage_moves.rb' - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - 'rubocop/migration_helpers.rb' + - 'spec/controllers/graphql_controller_spec.rb' - 'spec/frontend/fixtures/tabs.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' diff --git a/.rubocop_todo/layout/space_around_method_call_operator.yml b/.rubocop_todo/layout/space_around_method_call_operator.yml deleted file mode 100644 index bc174a43d77..00000000000 --- a/.rubocop_todo/layout/space_around_method_call_operator.yml +++ /dev/null @@ -1,32 +0,0 @@ ---- -# Cop supports --auto-correct. -Layout/SpaceAroundMethodCallOperator: - # Offense count: 35 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'app/helpers/badges_helper.rb' - - 'app/services/google_cloud/create_service_accounts_service.rb' - - 'app/services/google_cloud/enable_cloud_run_service.rb' - - 'app/services/google_cloud/generate_pipeline_service.rb' - - 'ee/spec/lib/gitlab/ci/config/entry/dast_configuration_spec.rb' - - 'ee/spec/migrations/geo/set_resync_flag_for_retried_projects_spec.rb' - - 'ee/spec/models/approval_project_rule_spec.rb' - - 'ee/spec/models/integrations/github/status_message_spec.rb' - - 'ee/spec/services/ee/boards/issues/move_service_spec.rb' - - 'ee/spec/services/ee/issues/create_service_spec.rb' - - 'ee/spec/services/geo/repository_base_sync_service_spec.rb' - - 'ee/spec/services/requirements_management/create_requirement_service_spec.rb' - - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb' - - 'spec/graphql/types/base_field_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' - - 'spec/lib/gitlab/database/shared_model_spec.rb' - - 'spec/lib/gitlab/diff/highlight_spec.rb' - - 'spec/lib/gitlab/spamcheck/client_spec.rb' - - 'spec/migrations/20220128155251_remove_dangling_running_builds_spec.rb' - - 'spec/models/integrations/chat_message/issue_message_spec.rb' - - 'spec/models/milestone_spec.rb' - - 'spec/presenters/alert_management/alert_presenter_spec.rb' - - 'spec/requests/api/graphql/custom_emoji_query_spec.rb' - - 'spec/tasks/gitlab/db_rake_spec.rb' - - 'spec/workers/concerns/limited_capacity/job_tracker_spec.rb' diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml index c084147eb58..4fdc308eaa5 100644 --- a/.rubocop_todo/layout/space_inside_block_braces.yml +++ b/.rubocop_todo/layout/space_inside_block_braces.yml @@ -1,295 +1,12 @@ --- # Cop supports --auto-correct. Layout/SpaceInsideBlockBraces: - # Offense count: 1508 - # Temporarily disabled due to too many offenses - Enabled: false - EnforcedStyle: space Exclude: - - 'app/controllers/groups/boards_controller.rb' - - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/projects/boards_controller.rb' - - 'app/experiments/security_reports_mr_widget_prompt_experiment.rb' - - 'app/experiments/video_tutorials_continuous_onboarding_experiment.rb' - - 'app/helpers/favicon_helper.rb' - - 'app/helpers/time_zone_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/models/authentication_event.rb' - - 'app/models/bulk_imports/entity.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/concerns/cache_markdown_field.rb' - - 'app/models/concerns/featurable.rb' - - 'app/models/integrations/bamboo.rb' - - 'app/models/integrations/buildkite.rb' - - 'app/models/integrations/teamcity.rb' - - 'app/models/network/graph.rb' - - 'app/models/operations/feature_flag.rb' - - 'app/models/packages/package.rb' - - 'app/models/preloaders/labels_preloader.rb' - - 'app/models/project.rb' - - 'app/models/release.rb' - - 'app/models/release_highlight.rb' - - 'app/services/authorized_project_update/project_recalculate_service.rb' - - 'app/services/notification_service.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - - 'db/post_migrate/20210707210916_finalize_ci_stages_bigint_conversion.rb' - - 'db/post_migrate/20210802043253_finalize_push_event_payloads_bigint_conversion_3.rb' - - 'ee/app/finders/security/training_providers/base_url_finder.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb' - - 'ee/app/helpers/ee/dashboard_helper.rb' - - 'ee/app/models/approvals/scan_finding_wrapped_rule_set.rb' - - 'ee/app/models/compliance_management/framework.rb' - - 'ee/app/models/dora/daily_metrics.rb' - - 'ee/app/models/ee/application_setting.rb' - - 'ee/app/models/ee/member.rb' - - 'ee/app/models/vulnerabilities/identifier.rb' - - 'ee/app/serializers/vulnerabilities/finding_entity.rb' - - 'ee/app/services/elastic/cluster_reindexing_service.rb' - - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - - 'ee/lib/ee/gitlab/auth/ldap/group.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - - 'ee/lib/gitlab/auth/smartcard/san_extension.rb' - - 'ee/lib/world.rb' - - 'ee/spec/controllers/autocomplete_controller_spec.rb' - - 'ee/spec/controllers/countries_controller_spec.rb' - - 'ee/spec/controllers/groups/epics_controller_spec.rb' - - 'ee/spec/controllers/projects/issues_controller_spec.rb' - - 'ee/spec/controllers/projects/pipelines_controller_spec.rb' - - 'ee/spec/controllers/subscriptions_controller_spec.rb' - - 'ee/spec/elastic_integration/global_search_spec.rb' - - 'ee/spec/factories/dast/profiles_pipelines.rb' - - 'ee/spec/factories/licenses.rb' - - 'ee/spec/features/billings/billing_plans_spec.rb' - - 'ee/spec/features/boards/board_filters_spec.rb' - - 'ee/spec/features/boards/scoped_issue_board_spec.rb' - - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' - - 'ee/spec/features/epics/todo_spec.rb' - - 'ee/spec/features/google_analytics_datalayer_spec.rb' - - 'ee/spec/features/groups/issues_spec.rb' - - 'ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb' - - 'ee/spec/features/issues/form_spec.rb' - - 'ee/spec/features/issues/issue_sidebar_spec.rb' - - 'ee/spec/features/issues/user_edits_issue_spec.rb' - - 'ee/spec/features/merge_request/user_edits_multiple_reviewers_mr_spec.rb' - - 'ee/spec/features/merge_request/user_sees_closing_issues_message_spec.rb' - - 'ee/spec/features/merge_requests/user_resets_approvers_spec.rb' - - 'ee/spec/features/merge_requests/user_views_all_merge_requests_spec.rb' - - 'ee/spec/features/projects/integrations/user_activates_github_spec.rb' - - 'ee/spec/features/projects/push_rules_spec.rb' - - 'ee/spec/features/projects/security/dast_scanner_profiles_spec.rb' - - 'ee/spec/features/projects/security/dast_site_profiles_spec.rb' - - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/finders/billed_users_finder_spec.rb' - - 'ee/spec/finders/clusters/environments_finder_spec.rb' - - 'ee/spec/finders/dast/profiles_finder_spec.rb' - - 'ee/spec/finders/ee/namespaces/projects_finder_spec.rb' - - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - - 'ee/spec/finders/security/training_providers/kontra_url_finder_spec.rb' - - 'ee/spec/finders/security/vulnerabilities_finder_spec.rb' - - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - - 'ee/spec/finders/status_page/incidents_finder_spec.rb' - - 'ee/spec/frontend/fixtures/epic.rb' - - 'ee/spec/frontend/fixtures/projects.rb' - - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' - - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - - 'ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - - 'ee/spec/graphql/mutations/dast_site_validations/revoke_spec.rb' - - 'ee/spec/graphql/mutations/incident_management/escalation_policy/create_spec.rb' - - 'ee/spec/graphql/mutations/releases/update_spec.rb' - - 'ee/spec/graphql/mutations/vulnerabilities/destroy_external_issue_link_spec.rb' - - 'ee/spec/graphql/resolvers/iterations_resolver_spec.rb' - - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' - - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - - 'ee/spec/helpers/ee/trial_helper_spec.rb' - - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' - - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' - - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/migrate_job_artifact_registry_to_ssf_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/reports/security/reports_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb' - - 'ee/spec/lib/ee/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' - - 'ee/spec/lib/ee/sidebars/groups/menus/issues_menu_spec.rb' - - 'ee/spec/lib/ee/sidebars/groups/menus/settings_menu_spec.rb' - - 'ee/spec/lib/ee/sidebars/projects/menus/ci_cd_menu_spec.rb' - - 'ee/spec/lib/ee/sidebars/projects/menus/issues_menu_spec.rb' - - 'ee/spec/lib/ee/sidebars/projects/menus/repository_menu_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/gma_membership_enforcer_spec.rb' - - 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb' - - 'ee/spec/lib/gitlab/ci/parsers/security/container_scanning_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/license_scanning/dependency_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/security/finding_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_renamed_event_spec.rb' - - 'ee/spec/lib/gitlab/git_access_spec.rb' - - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - - 'ee/spec/lib/gitlab/ip_address_state_spec.rb' - - 'ee/spec/lib/gitlab/search_context/builder_spec.rb' - - 'ee/spec/lib/gitlab/status_page/filter/image_filter_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/approval_project_rules_with_user_metric_spec.rb' - - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' - - 'ee/spec/migrations/geo/migrate_job_artifact_registry_spec.rb' - - 'ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb' - - 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb' - - 'ee/spec/models/approval_project_rule_spec.rb' - - 'ee/spec/models/approval_state_spec.rb' - - 'ee/spec/models/approvals/scan_finding_wrapped_rule_set_spec.rb' - - 'ee/spec/models/ci/minutes/limit_spec.rb' - - 'ee/spec/models/compliance_management/framework_spec.rb' - - 'ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb' - - 'ee/spec/models/concerns/elastic/issue_spec.rb' - - 'ee/spec/models/dast/profile_schedule_spec.rb' - - 'ee/spec/models/ee/audit_event_spec.rb' - - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - - 'ee/spec/models/ee/iteration_spec.rb' - - 'ee/spec/models/ee/namespace/root_storage_size_spec.rb' - - 'ee/spec/models/ee/namespace_limit_spec.rb' - - 'ee/spec/models/environment_spec.rb' - - 'ee/spec/models/epic_spec.rb' - - 'ee/spec/models/gitlab/seat_link_data_spec.rb' - - 'ee/spec/models/gitlab_subscription_spec.rb' - - 'ee/spec/models/member_spec.rb' - - 'ee/spec/models/milestone_release_spec.rb' - - 'ee/spec/models/project_member_spec.rb' - - 'ee/spec/models/protected_environment_spec.rb' - - 'ee/spec/models/push_rule_spec.rb' - - 'ee/spec/models/requirements_management/test_report_spec.rb' - - 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb' - - 'ee/spec/models/vulnerabilities/feedback_spec.rb' - - 'ee/spec/models/vulnerabilities/finding_spec.rb' - - 'ee/spec/presenters/epic_issue_presenter_spec.rb' - - 'ee/spec/requests/api/analytics/code_review_analytics_spec.rb' - - 'ee/spec/requests/api/analytics/group_activity_analytics_spec.rb' - - 'ee/spec/requests/api/ci/minutes_spec.rb' - - 'ee/spec/requests/api/epic_links_spec.rb' - - 'ee/spec/requests/api/graphql/boards/board_lists_query_spec.rb' - - 'ee/spec/requests/api/graphql/group/epic/epic_aggregate_query_spec.rb' - - 'ee/spec/requests/api/graphql/group/epic/epic_issues_spec.rb' - - 'ee/spec/requests/api/graphql/group_query_spec.rb' - - 'ee/spec/requests/api/graphql/iteration_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/dast_site_validations/revoke_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/epic_tree/reorder_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/update_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/releases/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb' - - 'ee/spec/requests/api/graphql/project/dast_profiles_spec.rb' - - 'ee/spec/requests/api/graphql/project/dast_site_validations_spec.rb' - - 'ee/spec/requests/api/graphql/project/issues_spec.rb' - - 'ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb' - - 'ee/spec/requests/api/group_variables_spec.rb' - - 'ee/spec/requests/api/internal/base_spec.rb' - - 'ee/spec/requests/api/managed_licenses_spec.rb' - - 'ee/spec/requests/api/members_spec.rb' - - 'ee/spec/requests/api/projects_spec.rb' - - 'ee/spec/requests/api/protected_branches_spec.rb' - - 'ee/spec/requests/api/releases_spec.rb' - - 'ee/spec/requests/groups/contribution_analytics_spec.rb' - - 'ee/spec/requests/lfs_http_spec.rb' - - 'ee/spec/requests/projects/security/policies_controller_spec.rb' - - 'ee/spec/serializers/member_user_entity_spec.rb' - - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb' - - 'ee/spec/serializers/vulnerabilities/finding_reports_comparer_entity_spec.rb' - - 'ee/spec/services/audit_events/register_runner_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/unregister_runner_audit_event_service_spec.rb' - - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' - - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - - 'ee/spec/services/ci/runners/register_runner_service_spec.rb' - - 'ee/spec/services/ee/design_management/delete_designs_service_spec.rb' - - 'ee/spec/services/ee/design_management/save_designs_service_spec.rb' - - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' - - 'ee/spec/services/ee/notes/quick_actions_service_spec.rb' - - 'ee/spec/services/ee/notification_service_spec.rb' - - 'ee/spec/services/ee/vulnerability_feedback_module/update_service_spec.rb' - - 'ee/spec/services/epic_issues/create_service_spec.rb' - - 'ee/spec/services/epics/create_service_spec.rb' - - 'ee/spec/services/epics/descendant_count_service_spec.rb' - - 'ee/spec/services/epics/transfer_service_spec.rb' - - 'ee/spec/services/geo/container_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/hashed_storage_attachments_event_store_spec.rb' - - 'ee/spec/services/geo/repository_sync_service_spec.rb' - - 'ee/spec/services/geo/wiki_sync_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/activate_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb' - - 'ee/spec/services/group_saml/sign_up_service_spec.rb' - - 'ee/spec/services/groups/epics_count_service_spec.rb' - - 'ee/spec/services/groups/memberships/export_service_spec.rb' - - 'ee/spec/services/iterations/cadences/create_iterations_in_advance_service_spec.rb' - - 'ee/spec/services/merge_trains/check_status_service_spec.rb' - - 'ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb' - - 'ee/spec/services/projects/destroy_service_spec.rb' - - 'ee/spec/services/projects/update_mirror_service_spec.rb' - - 'ee/spec/services/quick_actions/interpret_service_spec.rb' - - 'ee/spec/services/requirements_management/create_requirement_service_spec.rb' - - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb' - - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' - - 'ee/spec/services/search/group_service_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_findings_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/policy_commit_service_spec.rb' - - 'ee/spec/services/sitemap/create_service_spec.rb' - - 'ee/spec/services/software_license_policies/update_service_spec.rb' - - 'ee/spec/services/status_page/publish_attachments_service_spec.rb' - - 'ee/spec/services/system_notes/epics_service_spec.rb' - - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' - - 'ee/spec/services/vulnerability_feedback/destroy_service_spec.rb' - - 'ee/spec/support/shared_examples/features/ultimate_trial_callout_shared_examples.rb' - - 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/boards/base_service_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' - - 'ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/_expiry_date.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/ssh_keys/_ssh_key.html.haml_spec.rb' - - 'ee/spec/workers/adjourned_project_deletion_worker_spec.rb' - - 'ee/spec/workers/adjourned_projects_deletion_cron_worker_spec.rb' - - 'ee/spec/workers/security/create_orchestration_policy_worker_spec.rb' - - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb' - - 'lib/api/commits.rb' - - 'lib/api/helpers/merge_requests_helpers.rb' - - 'lib/backup/manager.rb' - - 'lib/banzai/filter/references/label_reference_filter.rb' - - 'lib/banzai/filter/references/milestone_reference_filter.rb' - - 'lib/bitbucket/representation/base.rb' - - 'lib/bitbucket_server/representation/base.rb' - - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - - 'lib/gitlab/contributions_calendar.rb' - - 'lib/gitlab/database/migrations/test_background_runner.rb' - - 'lib/gitlab/database/postgres_hll/buckets.rb' - - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - - 'lib/gitlab/issues/rebalancing/state.rb' - - 'lib/gitlab/profiler.rb' - - 'lib/kramdown/converter/commonmark.rb' - - 'lib/release_highlights/validator/entry.rb' - - 'lib/security/ci_configuration/sast_build_action.rb' - - 'lib/tasks/gitlab/db.rake' - - 'lib/tasks/gitlab/info.rake' - - 'lib/tasks/gitlab/praefect.rake' - - 'lib/tasks/gitlab/shell.rake' - - 'lib/tasks/gitlab/tw/codeowners.rake' - - 'qa/qa/service/praefect_manager.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' - - 'qa/qa/specs/features/browser_ui/2_plan/issue/custom_issue_template_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_via_template_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_npm_registry_spec.rb' - - 'qa/spec/scenario/test/integration/mattermost_spec.rb' - - 'qa/spec/support/page_error_checker_spec.rb' - - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - 'spec/config/settings_spec.rb' - 'spec/controllers/admin/application_settings_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/groups/labels_controller_spec.rb' - 'spec/controllers/groups/releases_controller_spec.rb' - - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - 'spec/controllers/import/manifest_controller_spec.rb' - 'spec/controllers/projects/blame_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' @@ -315,38 +32,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/factories/packages/packages.rb' - 'spec/factories/prometheus_alert.rb' - 'spec/factories/prometheus_metrics.rb' - - 'spec/features/admin/admin_mode/login_spec.rb' - - 'spec/features/admin/users/users_spec.rb' - - 'spec/features/boards/board_filters_spec.rb' - - 'spec/features/boards/reload_boards_on_browser_back_spec.rb' - - 'spec/features/dashboard/archived_projects_spec.rb' - - 'spec/features/error_tracking/user_filters_errors_by_status_spec.rb' - - 'spec/features/groups/issues_spec.rb' - - 'spec/features/groups_spec.rb' - - 'spec/features/issuables/user_sees_sidebar_spec.rb' - - 'spec/features/issues/gfm_autocomplete_spec.rb' - - 'spec/features/issues/todo_spec.rb' - - 'spec/features/issues/user_bulk_edits_issues_spec.rb' - - 'spec/features/issues/user_interacts_with_awards_spec.rb' - - 'spec/features/issues/user_uses_quick_actions_spec.rb' - - 'spec/features/merge_request/user_approves_spec.rb' - - 'spec/features/merge_request/user_customizes_merge_commit_message_spec.rb' - - 'spec/features/merge_request/user_edits_assignees_sidebar_spec.rb' - - 'spec/features/merge_request/user_sees_closing_issues_message_spec.rb' - - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb' - - 'spec/features/merge_request/user_sees_diff_spec.rb' - - 'spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb' - - 'spec/features/merge_request/user_sees_versions_spec.rb' - - 'spec/features/merge_request/user_uses_quick_actions_spec.rb' - - 'spec/features/profiles/user_edit_profile_spec.rb' - - 'spec/features/projects/cluster_agents_spec.rb' - - 'spec/features/projects/commits/user_browses_commits_spec.rb' - - 'spec/features/projects/environments/environment_spec.rb' - - 'spec/features/projects/files/user_browses_files_spec.rb' - - 'spec/features/projects/pipelines/pipelines_spec.rb' - - 'spec/features/projects/settings/service_desk_setting_spec.rb' - - 'spec/features/projects/tree/tree_show_spec.rb' - - 'spec/features/users/login_spec.rb' - 'spec/finders/ci/jobs_finder_spec.rb' - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/concerns/packages/finder_helper_spec.rb' @@ -376,18 +61,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/frontend/fixtures/raw.rb' - 'spec/frontend/fixtures/snippet.rb' - 'spec/frontend/fixtures/todos.rb' - - 'spec/graphql/mutations/merge_requests/set_labels_spec.rb' - - 'spec/graphql/mutations/releases/create_spec.rb' - - 'spec/graphql/mutations/releases/delete_spec.rb' - - 'spec/graphql/mutations/releases/update_spec.rb' - - 'spec/graphql/resolvers/ci/runner_jobs_resolver_spec.rb' - - 'spec/graphql/resolvers/group_members/notification_email_resolver_spec.rb' - - 'spec/graphql/resolvers/project_jobs_resolver_spec.rb' - - 'spec/graphql/resolvers/projects/grafana_integration_resolver_spec.rb' - - 'spec/graphql/resolvers/projects_resolver_spec.rb' - - 'spec/graphql/types/ci/job_token_scope_type_spec.rb' - - 'spec/graphql/types/issue_type_spec.rb' - - 'spec/graphql/types/user_type_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/gitlab_script_tag_helper_spec.rb' @@ -398,139 +71,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/helpers/wiki_page_version_helper_spec.rb' - 'spec/initializers/carrierwave_patch_spec.rb' - 'spec/initializers/trusted_proxies_spec.rb' - - 'spec/lib/api/entities/ci/job_request/image_spec.rb' - - 'spec/lib/api/entities/ci/job_request/port_spec.rb' - - 'spec/lib/api/helpers_spec.rb' - - 'spec/lib/banzai/cross_project_reference_spec.rb' - - 'spec/lib/banzai/filter/broadcast_message_placeholders_filter_spec.rb' - - 'spec/lib/banzai/filter/commit_trailers_filter_spec.rb' - - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - - 'spec/lib/banzai/renderer_spec.rb' - - 'spec/lib/bitbucket_server/connection_spec.rb' - - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' - - 'spec/lib/bulk_imports/common/pipelines/uploads_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb' - - 'spec/lib/feature/definition_spec.rb' - - 'spec/lib/feature_spec.rb' - - 'spec/lib/gitlab/application_context_spec.rb' - - 'spec/lib/gitlab/asciidoc_spec.rb' - - 'spec/lib/gitlab/audit/ci_runner_token_author_spec.rb' - - 'spec/lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans_spec.rb' - - 'spec/lib/gitlab/batch_pop_queueing_spec.rb' - - 'spec/lib/gitlab/chat_name_token_spec.rb' - - 'spec/lib/gitlab/ci/ansi2html_spec.rb' - - 'spec/lib/gitlab/ci/ansi2json_spec.rb' - - 'spec/lib/gitlab/ci/build/prerequisite/kubernetes_namespace_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/release_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/tags_spec.rb' - - 'spec/lib/gitlab/ci/config/external/file/base_spec.rb' - - 'spec/lib/gitlab/ci/config/external/file/local_spec.rb' - - 'spec/lib/gitlab/ci/config/external/file/remote_spec.rb' - - 'spec/lib/gitlab/ci/config/normalizer_spec.rb' - - 'spec/lib/gitlab/ci/cron_parser_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/create_deployments_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/seed_block_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/seed_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/quota/deployments_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/reports_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb' - - 'spec/lib/gitlab/ci/status/build/canceled_spec.rb' - - 'spec/lib/gitlab/ci/status/build/created_spec.rb' - - 'spec/lib/gitlab/ci/status/build/manual_spec.rb' - - 'spec/lib/gitlab/ci/status/build/pending_spec.rb' - - 'spec/lib/gitlab/ci/status/build/skipped_spec.rb' - - 'spec/lib/gitlab/ci/status/processable/waiting_for_resource_spec.rb' - - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb' - - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - - 'spec/lib/gitlab/composer/cache_spec.rb' - - 'spec/lib/gitlab/data_builder/build_spec.rb' - - 'spec/lib/gitlab/data_builder/pipeline_spec.rb' - - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/migrations/lock_retry_mixin_spec.rb' - - 'spec/lib/gitlab/database/migrations/runner_spec.rb' - - 'spec/lib/gitlab/database/partitioning_spec.rb' - - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' - - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' - - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - - 'spec/lib/gitlab/database_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/create_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/experience_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/verify_spec.rb' - - 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb' - - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' - - 'spec/lib/gitlab/file_markdown_link_builder_spec.rb' - - 'spec/lib/gitlab/git/blob_spec.rb' - - 'spec/lib/gitlab/git/commit_spec.rb' - - 'spec/lib/gitlab/git/diff_collection_spec.rb' - - 'spec/lib/gitlab/git/raw_diff_change_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' - - 'spec/lib/gitlab/gitaly_client/commit_service_spec.rb' - - 'spec/lib/gitlab/github_import/client_spec.rb' - - 'spec/lib/gitlab/github_import/importer/pull_requests_importer_spec.rb' - - 'spec/lib/gitlab/gpg_spec.rb' - - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/connection_generic_keyset_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb' - - 'spec/lib/gitlab/graphs/commits_spec.rb' - - 'spec/lib/gitlab/highlight_spec.rb' - - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb' - - 'spec/lib/gitlab/import_export/json/ndjson_writer_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/version_checker_spec.rb' - - 'spec/lib/gitlab/jira/dvcs_spec.rb' - - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - - 'spec/lib/gitlab/metrics/background_transaction_spec.rb' - - 'spec/lib/gitlab/metrics/web_transaction_spec.rb' - - 'spec/lib/gitlab/middleware/compressed_json_spec.rb' - - 'spec/lib/gitlab/middleware/sidekiq_web_static_spec.rb' - - 'spec/lib/gitlab/otp_key_rotator_spec.rb' - - 'spec/lib/gitlab/pagination/keyset_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/prometheus_client_spec.rb' - - 'spec/lib/gitlab/quick_actions/command_definition_spec.rb' - - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' - - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' - - 'spec/lib/gitlab/rack_attack/user_allowlist_spec.rb' - - 'spec/lib/gitlab/redis/hll_spec.rb' - - 'spec/lib/gitlab/reference_counter_spec.rb' - - 'spec/lib/gitlab/regex_spec.rb' - - 'spec/lib/gitlab/search/abuse_detection_spec.rb' - - 'spec/lib/gitlab/search_context/builder_spec.rb' - - 'spec/lib/gitlab/session_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' - - 'spec/lib/gitlab/spamcheck/client_spec.rb' - - 'spec/lib/gitlab/suggestions/file_suggestion_spec.rb' - - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - - 'spec/lib/gitlab/utils/sanitize_node_link_spec.rb' - - 'spec/lib/gitlab/utils/usage_data_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - - 'spec/lib/gitlab/verify/uploads_spec.rb' - - 'spec/lib/gitlab/version_info_spec.rb' - - 'spec/lib/json_web_token/rsa_token_spec.rb' - - 'spec/lib/marginalia_spec.rb' - - 'spec/lib/mattermost/session_spec.rb' - - 'spec/lib/microsoft_teams/notifier_spec.rb' - - 'spec/lib/sidebars/groups/menus/group_information_menu_spec.rb' - - 'spec/lib/sidebars/menu_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb' - 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb' @@ -538,54 +78,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/migrations/reset_job_token_scope_enabled_again_spec.rb' - 'spec/migrations/reset_job_token_scope_enabled_spec.rb' - 'spec/migrations/reset_severity_levels_to_new_default_spec.rb' - - 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb' - - 'spec/models/active_session_spec.rb' - - 'spec/models/aws/role_spec.rb' - - 'spec/models/ci/build_dependencies_spec.rb' - - 'spec/models/ci/build_runner_session_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/daily_build_group_report_result_spec.rb' - - 'spec/models/ci/job_artifact_spec.rb' - - 'spec/models/ci/pipeline_schedule_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/ci/runner_spec.rb' - - 'spec/models/clusters/cluster_spec.rb' - - 'spec/models/commit_status_spec.rb' - - 'spec/models/concerns/chronic_duration_attribute_spec.rb' - - 'spec/models/concerns/counter_attribute_spec.rb' - - 'spec/models/concerns/nullify_if_blank_spec.rb' - - 'spec/models/concerns/reactive_caching_spec.rb' - - 'spec/models/concerns/token_authenticatable_spec.rb' - - 'spec/models/container_expiration_policy_spec.rb' - - 'spec/models/container_repository_spec.rb' - - 'spec/models/environment_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/hooks/web_hook_log_spec.rb' - - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - - 'spec/models/issue_spec.rb' - - 'spec/models/jira_import_state_spec.rb' - - 'spec/models/merge_request_spec.rb' - - 'spec/models/namespace/root_storage_statistics_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/models/note_spec.rb' - - 'spec/models/onboarding_progress_spec.rb' - - 'spec/models/packages/conan/metadatum_spec.rb' - - 'spec/models/packages/package_file_spec.rb' - - 'spec/models/packages/package_spec.rb' - - 'spec/models/postgresql/replication_slot_spec.rb' - - 'spec/models/preloaders/labels_preloader_spec.rb' - - 'spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb' - - 'spec/models/project_spec.rb' - - 'spec/models/release_spec.rb' - - 'spec/models/releases/link_spec.rb' - - 'spec/models/remote_mirror_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/snippet_input_action_collection_spec.rb' - - 'spec/models/snippet_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/models/users/calloutable_spec.rb' - - 'spec/models/wiki_page/meta_spec.rb' - 'spec/policies/clusters/agent_policy_spec.rb' - 'spec/policies/group_member_policy_spec.rb' - 'spec/policies/issue_policy_spec.rb' @@ -596,121 +88,11 @@ Layout/SpaceInsideBlockBraces: - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - 'spec/presenters/project_presenter_spec.rb' - - 'spec/requests/api/branches_spec.rb' - - 'spec/requests/api/ci/jobs_spec.rb' - - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - - 'spec/requests/api/ci/runner/jobs_trace_spec.rb' - - 'spec/requests/api/ci/secure_files_spec.rb' - - 'spec/requests/api/ci/triggers_spec.rb' - - 'spec/requests/api/ci/variables_spec.rb' - - 'spec/requests/api/commits_spec.rb' - - 'spec/requests/api/conan_instance_packages_spec.rb' - - 'spec/requests/api/conan_project_packages_spec.rb' - - 'spec/requests/api/dependency_proxy_spec.rb' - - 'spec/requests/api/go_proxy_spec.rb' - - 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb' - - 'spec/requests/api/graphql/boards/board_lists_query_spec.rb' - - 'spec/requests/api/graphql/group/dependency_proxy_manifests_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/add_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb' - - 'spec/requests/api/graphql/mutations/releases/create_spec.rb' - - 'spec/requests/api/graphql/mutations/releases/update_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' - - 'spec/requests/api/graphql/namespace/root_storage_statistics_spec.rb' - - 'spec/requests/api/graphql/packages/conan_spec.rb' - - 'spec/requests/api/graphql/packages/helm_spec.rb' - - 'spec/requests/api/graphql/packages/package_spec.rb' - - 'spec/requests/api/graphql/project/base_service_spec.rb' - - 'spec/requests/api/graphql/project/jira_import_spec.rb' - - 'spec/requests/api/group_variables_spec.rb' - - 'spec/requests/api/groups_spec.rb' - - 'spec/requests/api/helpers_spec.rb' - - 'spec/requests/api/internal/base_spec.rb' - - 'spec/requests/api/markdown_spec.rb' - - 'spec/requests/api/maven_packages_spec.rb' - - 'spec/requests/api/metrics/dashboard/annotations_spec.rb' - - 'spec/requests/api/notes_spec.rb' - - 'spec/requests/api/npm_project_packages_spec.rb' - - 'spec/requests/api/nuget_group_packages_spec.rb' - - 'spec/requests/api/pages/pages_spec.rb' - - 'spec/requests/api/pages_domains_spec.rb' - - 'spec/requests/api/personal_access_tokens_spec.rb' - - 'spec/requests/api/project_hooks_spec.rb' - - 'spec/requests/api/project_templates_spec.rb' - - 'spec/requests/api/projects_spec.rb' - - 'spec/requests/api/pypi_packages_spec.rb' - - 'spec/requests/api/release/links_spec.rb' - - 'spec/requests/api/releases_spec.rb' - - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/unleash_spec.rb' - - 'spec/requests/git_http_spec.rb' - - 'spec/requests/groups/milestones_controller_spec.rb' - - 'spec/requests/lfs_http_spec.rb' - - 'spec/requests/oauth/tokens_controller_spec.rb' - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' - 'spec/serializers/cluster_entity_spec.rb' - 'spec/serializers/import/provider_repo_serializer_spec.rb' - - 'spec/services/auto_merge/base_service_spec.rb' - - 'spec/services/auto_merge_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' - - 'spec/services/ci/parse_dotenv_artifact_service_spec.rb' - - 'spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb' - - 'spec/services/ci/process_build_service_spec.rb' - - 'spec/services/ci/runners/register_runner_service_spec.rb' - - 'spec/services/ci/runners/update_runner_service_spec.rb' - - 'spec/services/ci/stuck_builds/drop_pending_service_spec.rb' - - 'spec/services/ci/stuck_builds/drop_scheduled_service_spec.rb' - - 'spec/services/clusters/integrations/create_service_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - - 'spec/services/deployments/create_for_build_service_spec.rb' - - 'spec/services/git/branch_push_service_spec.rb' - - 'spec/services/groups/destroy_service_spec.rb' - - 'spec/services/groups/merge_requests_count_service_spec.rb' - - 'spec/services/groups/update_service_spec.rb' - - 'spec/services/groups/update_statistics_service_spec.rb' - - 'spec/services/import/validate_remote_git_endpoint_service_spec.rb' - - 'spec/services/issues/referenced_merge_requests_service_spec.rb' - - 'spec/services/jira_import/start_import_service_spec.rb' - - 'spec/services/lfs/push_service_spec.rb' - - 'spec/services/members/invite_service_spec.rb' - - 'spec/services/merge_requests/push_options_handler_service_spec.rb' - - 'spec/services/merge_requests/refresh_service_spec.rb' - - 'spec/services/merge_requests/update_service_spec.rb' - - 'spec/services/milestones/transfer_service_spec.rb' - - 'spec/services/notes/copy_service_spec.rb' - - 'spec/services/notification_service_spec.rb' - - 'spec/services/packages/composer/create_package_service_spec.rb' - - 'spec/services/packages/create_dependency_service_spec.rb' - - 'spec/services/packages/debian/extract_deb_metadata_service_spec.rb' - - 'spec/services/packages/debian/parse_debian822_service_spec.rb' - - 'spec/services/packages/debian/sign_distribution_service_spec.rb' - - 'spec/services/packages/helm/process_file_service_spec.rb' - - 'spec/services/packages/npm/create_package_service_spec.rb' - - 'spec/services/packages/rubygems/dependency_resolver_service_spec.rb' - - 'spec/services/pages/delete_service_spec.rb' - - 'spec/services/projects/container_repository/third_party/delete_tags_service_spec.rb' - - 'spec/services/projects/enable_deploy_key_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb' - - 'spec/services/projects/participants_service_spec.rb' - - 'spec/services/projects/update_statistics_service_spec.rb' - - 'spec/services/quick_actions/interpret_service_spec.rb' - - 'spec/services/releases/destroy_service_spec.rb' - - 'spec/services/releases/update_service_spec.rb' - - 'spec/services/resource_access_tokens/create_service_spec.rb' - - 'spec/services/search/group_service_spec.rb' - - 'spec/services/snippets/update_service_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' - - 'spec/services/system_notes/merge_requests_service_spec.rb' - - 'spec/services/terraform/remote_state_handler_spec.rb' - - 'spec/services/todo_service_spec.rb' - - 'spec/services/todos/destroy/design_service_spec.rb' - - 'spec/services/todos/destroy/entity_leave_service_spec.rb' - - 'spec/services/web_hook_service_spec.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' - 'spec/support/redis/redis_shared_examples.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_contexts/graphql/requests/packages_shared_context.rb' - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb' - 'spec/support/shared_contexts/requests/api/conan_packages_shared_context.rb' @@ -728,7 +110,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/support/shared_examples/models/label_note_shared_examples.rb' - 'spec/support/shared_examples/models/packages/debian/distribution_shared_examples.rb' - 'spec/support/shared_examples/models/project_latest_successful_build_for_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/group_and_project_boards_query_shared_examples.rb' - 'spec/support/shared_examples/requests/api/issues/merge_requests_count_shared_examples.rb' - 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb' - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 4c1c8430204..87ac47deaf5 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -1,8 +1,5 @@ --- Lint/MissingCopEnableDirective: - # Offense count: 199 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/admin/users_controller.rb' - 'app/controllers/projects/forks_controller.rb' @@ -20,14 +17,19 @@ Lint/MissingCopEnableDirective: - 'app/graphql/types/ci/build_need_type.rb' - 'app/graphql/types/ci/config/config_type.rb' - 'app/graphql/types/ci/config/group_type.rb' + - 'app/graphql/types/ci/config/include_type.rb' - 'app/graphql/types/ci/config/job_restriction_type.rb' - 'app/graphql/types/ci/config/job_type.rb' - 'app/graphql/types/ci/config/need_type.rb' - 'app/graphql/types/ci/config/stage_type.rb' - 'app/graphql/types/ci/group_type.rb' + - 'app/graphql/types/ci/group_variable_type.rb' + - 'app/graphql/types/ci/instance_variable_type.rb' - 'app/graphql/types/ci/job_artifact_type.rb' - 'app/graphql/types/ci/job_type.rb' + - 'app/graphql/types/ci/manual_variable_type.rb' - 'app/graphql/types/ci/pipeline_message_type.rb' + - 'app/graphql/types/ci/project_variable_type.rb' - 'app/graphql/types/ci/runner_architecture_type.rb' - 'app/graphql/types/ci/runner_platform_type.rb' - 'app/graphql/types/ci/runner_setup_type.rb' @@ -41,6 +43,7 @@ Lint/MissingCopEnableDirective: - 'app/graphql/types/countable_connection_type.rb' - 'app/graphql/types/design_management_type.rb' - 'app/graphql/types/issue_connection_type.rb' + - 'app/graphql/types/limited_countable_connection_type.rb' - 'app/graphql/types/merge_request_connection_type.rb' - 'app/graphql/types/packages/composer/json_type.rb' - 'app/graphql/types/packages/helm/dependency_type.rb' @@ -71,6 +74,7 @@ Lint/MissingCopEnableDirective: - 'db/migrate/20210818061156_remove_project_profile_compound_index_from_dast_profile_schedules.rb' - 'db/migrate/20210818115613_add_index_project_id_on_dast_profile_schedule.rb' - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' + - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - 'db/post_migrate/20210825182303_remove_duplicate_dast_site_tokens_with_same_token.rb' - 'ee/app/controllers/ee/admin/dashboard_controller.rb' - 'ee/app/controllers/ee/admin/groups_controller.rb' @@ -90,6 +94,7 @@ Lint/MissingCopEnableDirective: - 'ee/app/graphql/types/ci/minutes/project_monthly_usage_type.rb' - 'ee/app/graphql/types/compliance_management/compliance_framework_type.rb' - 'ee/app/graphql/types/dast/profile_cadence_type.rb' + - 'ee/app/graphql/types/geo/ci_secure_file_registry_type.rb' - 'ee/app/graphql/types/geo/group_wiki_repository_registry_type.rb' - 'ee/app/graphql/types/geo/job_artifact_registry_type.rb' - 'ee/app/graphql/types/geo/lfs_object_registry_type.rb' @@ -107,6 +112,7 @@ Lint/MissingCopEnableDirective: - 'ee/app/graphql/types/security_report_summary_type.rb' - 'ee/app/graphql/types/security_scanners.rb' - 'ee/app/graphql/types/time_report_stats_type.rb' + - 'ee/app/graphql/types/timebox_error_type.rb' - 'ee/app/graphql/types/timebox_metrics_type.rb' - 'ee/app/graphql/types/timebox_report_type.rb' - 'ee/app/graphql/types/vulnerabilities_count_by_day_type.rb' @@ -135,20 +141,29 @@ Lint/MissingCopEnableDirective: - 'ee/app/graphql/types/vulnerable_dependency_type.rb' - 'ee/app/graphql/types/vulnerable_kubernetes_resource_type.rb' - 'ee/app/graphql/types/vulnerable_package_type.rb' + - 'ee/app/services/ee/ci/queue/build_queue_service.rb' + - 'ee/app/workers/ci/runners/stale_group_runners_prune_cron_worker.rb' - 'ee/app/workers/groups/export_memberships_worker.rb' - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/lib/api/ldap_group_links.rb' - 'ee/lib/api/scim.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' + - 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/gitlab/spdx/license.rb' + - 'ee/spec/controllers/projects/legacy_pipelines_controller_spec.rb' + - 'ee/spec/helpers/groups/security_features_helper_spec.rb' + - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' + - 'lib/gitlab/audit/null_author.rb' - 'lib/gitlab/auth/ldap/dn.rb' + - 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - - 'lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans.rb' + - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' @@ -161,11 +176,13 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' + - 'lib/gitlab/background_migration/purge_stale_security_scans.rb' - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' + - 'lib/gitlab/buffered_io.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' - 'lib/gitlab/data_builder/push.rb' - 'lib/gitlab/database/load_balancing/connection_proxy.rb' @@ -174,7 +191,6 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/diff_note_importer.rb' - 'lib/gitlab/gon_helper.rb' - - 'lib/gitlab/graphql/pagination/keyset/generic_keyset_pagination.rb' - 'lib/gitlab/graphql/pagination/keyset/last_items.rb' - 'lib/gitlab/graphql/standard_graphql_error.rb' - 'lib/gitlab/metrics/methods.rb' @@ -184,10 +200,13 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/testing/request_blocker_middleware.rb' - 'lib/gitlab/testing/request_inspector_middleware.rb' - 'lib/gitlab/testing/robots_blocker_middleware.rb' + - 'lib/unnested_in_filters/dsl.rb' + - 'lib/unnested_in_filters/rewriter.rb' - 'qa/qa/scenario/test/integration/registry_with_cdn.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' + - 'spec/lib/initializer_connections_spec.rb' - 'spec/support/capybara.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/google_api/cloud_platform_helpers.rb' - - 'tooling/danger/product_intelligence.rb'
\ No newline at end of file + - 'tooling/danger/product_intelligence.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index c1d058240a4..29276e529af 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -1,8 +1,5 @@ --- Naming/HeredocDelimiterNaming: - # Offense count: 388 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/models/ci/build_trace_chunks/redis_base.rb' - 'app/models/concerns/counter_attribute.rb' @@ -31,6 +28,7 @@ Naming/HeredocDelimiterNaming: - 'ee/spec/services/security/security_orchestration_policies/policy_commit_service_spec.rb' - 'ee/spec/support/helpers/ee/ldap_helpers.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' + - 'lib/api/metadata.rb' - 'lib/api/version.rb' - 'lib/backup/helper.rb' - 'lib/feature/shared.rb' @@ -46,14 +44,14 @@ Naming/HeredocDelimiterNaming: - 'lib/tasks/gitlab/docs/compile_deprecations.rake' - 'lib/tasks/gitlab/password.rake' - 'qa/qa/scenario/test/sanity/selectors.rb' - - 'qa/qa/service/docker_run/gitlab_runner.rb' - - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/testing/view_code_coverage_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - 'rubocop/cop/database/multiple_databases.rb' + - 'rubocop/cop/database/rescue_query_canceled.rb' + - 'rubocop/cop/database/rescue_statement_timeout.rb' - 'rubocop/cop/default_scope.rb' - 'rubocop/cop/file_decompression.rb' - 'rubocop/cop/gitlab/httparty.rb' @@ -61,6 +59,7 @@ Naming/HeredocDelimiterNaming: - 'rubocop/cop/gitlab/module_with_instance_variables.rb' - 'rubocop/cop/gitlab/predicate_memoization.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/db/docs_spec.rb' - 'spec/deprecation_toolkit_env.rb' - 'spec/factories/packages/debian/distribution.rb' - 'spec/factories/packages/debian/file_metadatum.rb' @@ -68,6 +67,7 @@ Naming/HeredocDelimiterNaming: - 'spec/features/task_lists_spec.rb' - 'spec/helpers/markup_helper_spec.rb' - 'spec/initializers/100_patch_omniauth_oauth2_spec.rb' + - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/rack_multipart_patch_spec.rb' - 'spec/initializers/secret_token_spec.rb' - 'spec/initializers/validate_database_config_spec.rb' @@ -82,6 +82,7 @@ Naming/HeredocDelimiterNaming: - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/cluster/mixins/puma_cluster_spec.rb' - 'spec/lib/gitlab/conflict/file_collection_spec.rb' + - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/diff/pair_selector_spec.rb' - 'spec/lib/gitlab/diff/parser_spec.rb' @@ -131,10 +132,10 @@ Naming/HeredocDelimiterNaming: - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' - 'spec/services/task_list_toggle_service_spec.rb' - - 'spec/support/helpers/seed_helper.rb' - 'spec/support/helpers/stub_object_storage.rb' - 'spec/support/shared_examples/helm_commands_shared_examples.rb' - 'spec/support/shared_examples/models/taskable_shared_examples.rb' - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' - 'spec/support/test_reports/test_reports_helper.rb' + - 'spec/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences_rake_spec.rb' - 'spec/workers/post_receive_spec.rb' diff --git a/.rubocop_todo/naming/rescued_exceptions_variable_name.yml b/.rubocop_todo/naming/rescued_exceptions_variable_name.yml deleted file mode 100644 index b557ca8f06e..00000000000 --- a/.rubocop_todo/naming/rescued_exceptions_variable_name.yml +++ /dev/null @@ -1,216 +0,0 @@ ---- -# Cop supports --auto-correct. -Naming/RescuedExceptionsVariableName: - # Offense count: 269 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'app/controllers/admin/projects_controller.rb' - - 'app/controllers/projects/google_cloud/deployments_controller.rb' - - 'app/controllers/projects/google_cloud/service_accounts_controller.rb' - - 'app/controllers/projects/merge_requests/drafts_controller.rb' - - 'app/controllers/projects/milestones_controller.rb' - - 'app/controllers/projects/mirrors_controller.rb' - - 'app/controllers/projects/repositories_controller.rb' - - 'app/controllers/projects_controller.rb' - - 'app/finders/repositories/changelog_tag_finder.rb' - - 'app/graphql/mutations/issues/move.rb' - - 'app/graphql/resolvers/ci/config_resolver.rb' - - 'app/graphql/resolvers/environments_resolver.rb' - - 'app/helpers/application_helper.rb' - - 'app/models/application_setting.rb' - - 'app/models/blob_viewer/metrics_dashboard_yml.rb' - - 'app/models/ci/build.rb' - - 'app/models/ci/deleted_object.rb' - - 'app/models/concerns/prometheus_adapter.rb' - - 'app/models/concerns/repository_storage_movable.rb' - - 'app/models/concerns/x509_serial_number_attribute.rb' - - 'app/models/integrations/base_issue_tracker.rb' - - 'app/models/integrations/discord.rb' - - 'app/models/integrations/jenkins.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/integrations/packagist.rb' - - 'app/models/integrations/pipelines_email.rb' - - 'app/models/integrations/prometheus.rb' - - 'app/models/performance_monitoring/prometheus_dashboard.rb' - - 'app/models/personal_access_token.rb' - - 'app/models/project.rb' - - 'app/models/repository.rb' - - 'app/models/snippet_repository.rb' - - 'app/models/u2f_registration.rb' - - 'app/models/wiki.rb' - - 'app/services/branches/delete_service.rb' - - 'app/services/branches/validate_new_service.rb' - - 'app/services/ci/job_artifacts/create_service.rb' - - 'app/services/ci/parse_dotenv_artifact_service.rb' - - 'app/services/ci/register_job_service.rb' - - 'app/services/ci/stuck_builds/drop_helpers.rb' - - 'app/services/clusters/applications/prometheus_update_service.rb' - - 'app/services/commits/change_service.rb' - - 'app/services/commits/create_service.rb' - - 'app/services/dependency_proxy/head_manifest_service.rb' - - 'app/services/dependency_proxy/request_token_service.rb' - - 'app/services/design_management/copy_design_collection/copy_service.rb' - - 'app/services/git/base_hooks_service.rb' - - 'app/services/grafana/proxy_service.rb' - - 'app/services/groups/update_shared_runners_service.rb' - - 'app/services/issues/relative_position_rebalancing_service.rb' - - 'app/services/jira/requests/base.rb' - - 'app/services/jira_import/start_import_service.rb' - - 'app/services/jira_import/users_importer.rb' - - 'app/services/lfs/lock_file_service.rb' - - 'app/services/lfs/locks_finder_service.rb' - - 'app/services/lfs/push_service.rb' - - 'app/services/lfs/unlock_file_service.rb' - - 'app/services/merge_requests/merge_to_ref_service.rb' - - 'app/services/merge_requests/mergeability_check_service.rb' - - 'app/services/metrics/dashboard/base_service.rb' - - 'app/services/metrics/dashboard/panel_preview_service.rb' - - 'app/services/projects/cleanup_service.rb' - - 'app/services/projects/destroy_service.rb' - - 'app/services/projects/hashed_storage/base_repository_service.rb' - - 'app/services/projects/transfer_service.rb' - - 'app/services/prometheus/proxy_service.rb' - - 'app/services/resource_access_tokens/revoke_service.rb' - - 'app/services/tags/create_service.rb' - - 'app/services/tags/destroy_service.rb' - - 'app/services/users/validate_manual_otp_service.rb' - - 'app/services/users/validate_push_otp_service.rb' - - 'app/services/verify_pages_domain_service.rb' - - 'app/validators/js_regex_validator.rb' - - 'app/workers/concerns/limited_capacity/worker.rb' - - 'app/workers/gitlab/jira_import/import_issue_worker.rb' - - 'app/workers/issuable_export_csv_worker.rb' - - 'app/workers/namespaces/root_statistics_worker.rb' - - 'app/workers/namespaces/schedule_aggregation_worker.rb' - - 'app/workers/packages/go/sync_packages_worker.rb' - - 'app/workers/project_destroy_worker.rb' - - 'app/workers/projects/git_garbage_collect_worker.rb' - - 'app/workers/remove_expired_members_worker.rb' - - 'app/workers/users/create_statistics_worker.rb' - - 'config/initializers/rspec_profiling.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - - 'db/post_migrate/20210606143426_add_index_for_container_registry_access_level.rb' - - 'db/post_migrate/20211206162601_cleanup_after_add_primary_email_to_emails_if_user_confirmed.rb' - - 'db/post_migrate/20220318111729_cleanup_after_fixing_issue_when_admin_changed_primary_email.rb' - - 'db/post_migrate/20220504083836_cleanup_after_fixing_regression_with_new_users_emails.rb' - - 'ee/app/finders/projects/integrations/jira/by_ids_finder.rb' - - 'ee/app/graphql/mutations/issues/promote_to_epic.rb' - - 'ee/app/graphql/mutations/issues/set_epic.rb' - - 'ee/app/helpers/ee/kerberos_spnego_helper.rb' - - 'ee/app/models/concerns/geo/replicable_model.rb' - - 'ee/app/models/integrations/github.rb' - - 'ee/app/services/app_sec/dast/profiles/create_service.rb' - - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - - 'ee/app/services/app_sec/dast/scans/create_service.rb' - - 'ee/app/services/app_sec/dast/site_validations/find_or_create_service.rb' - - 'ee/app/services/app_sec/dast/site_validations/revoke_service.rb' - - 'ee/app/services/app_sec/fuzzing/coverage/corpuses/create_service.rb' - - 'ee/app/services/arkose/user_verification_service.rb' - - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' - - 'ee/app/services/elastic/process_bookkeeping_service.rb' - - 'ee/app/services/geo/file_registry_removal_service.rb' - - 'ee/app/services/geo/framework_repository_sync_service.rb' - - 'ee/app/services/geo/move_repository_service.rb' - - 'ee/app/services/geo/repository_base_sync_service.rb' - - 'ee/app/services/incident_management/oncall_rotations/create_service.rb' - - 'ee/app/services/incident_management/oncall_rotations/edit_service.rb' - - 'ee/app/services/projects/licenses/create_policy_service.rb' - - 'ee/app/services/projects/licenses/update_policy_service.rb' - - 'ee/app/services/security/ingestion/ingest_report_service.rb' - - 'ee/app/services/security/orchestration/assign_service.rb' - - 'ee/app/services/security/store_grouped_scans_service.rb' - - 'ee/app/services/security/store_scan_service.rb' - - 'ee/app/services/security/token_revocation_service.rb' - - 'ee/app/services/software_license_policies/create_service.rb' - - 'ee/app/services/software_license_policies/update_service.rb' - - 'ee/app/workers/adjourned_project_deletion_worker.rb' - - 'ee/app/workers/geo/file_removal_worker.rb' - - 'ee/app/workers/geo/repositories_clean_up_worker.rb' - - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' - - 'ee/app/workers/refresh_license_compliance_checks_worker.rb' - - 'ee/app/workers/repository_update_mirror_worker.rb' - - 'ee/app/workers/sync_seat_link_request_worker.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/elastic/instance_proxy_util.rb' - - 'ee/lib/gitlab/audit/auditor.rb' - - 'ee/lib/gitlab/auth/smartcard/base.rb' - - 'ee/lib/gitlab/ci/parsers/license_compliance/license_scanning.rb' - - 'ee/lib/gitlab/elastic/bulk_indexer.rb' - - 'ee/lib/gitlab/spdx/catalogue_gateway.rb' - - 'ee/lib/tasks/gitlab/seed/metrics.rake' - - 'lib/api/environments.rb' - - 'lib/api/helpers.rb' - - 'lib/api/helpers/label_helpers.rb' - - 'lib/api/issues.rb' - - 'lib/api/project_milestones.rb' - - 'lib/api/projects.rb' - - 'lib/api/repositories.rb' - - 'lib/api/v3/github.rb' - - 'lib/gitaly/server.rb' - - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp.rb' - - 'lib/gitlab/auth/otp/strategies/forti_authenticator/push_otp.rb' - - 'lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/ci/config/external/file/artifact.rb' - - 'lib/gitlab/ci/pipeline/chain/config/process.rb' - - 'lib/gitlab/ci/pipeline/chain/validate/external.rb' - - 'lib/gitlab/ci/reports/codequality_reports.rb' - - 'lib/gitlab/database/background_migration/batched_job.rb' - - 'lib/gitlab/database/background_migration/batched_migration_wrapper.rb' - - 'lib/gitlab/database/batch_counter.rb' - - 'lib/gitlab/database/load_balancing/load_balancer.rb' - - 'lib/gitlab/database/load_balancing/service_discovery.rb' - - 'lib/gitlab/database/reindexing/grafana_notifier.rb' - - 'lib/gitlab/git/keep_around.rb' - - 'lib/gitlab/gitaly_client/call.rb' - - 'lib/gitlab/gitaly_client/commit_service.rb' - - 'lib/gitlab/gitaly_client/operation_service.rb' - - 'lib/gitlab/gitaly_client/ref_service.rb' - - 'lib/gitlab/gitaly_client/repository_service.rb' - - 'lib/gitlab/hashed_storage/migrator.rb' - - 'lib/gitlab/health_checks/base_abstract_check.rb' - - 'lib/gitlab/import_export/merge_request_parser.rb' - - 'lib/gitlab/instrumentation/redis_interceptor.rb' - - 'lib/gitlab/issuables_count_for_state.rb' - - 'lib/gitlab/jira_import/issues_importer.rb' - - 'lib/gitlab/json.rb' - - 'lib/gitlab/jwt_token.rb' - - 'lib/gitlab/kubernetes/namespace.rb' - - 'lib/gitlab/metrics/dashboard/stages/panel_ids_inserter.rb' - - 'lib/gitlab/metrics/rack_middleware.rb' - - 'lib/gitlab/middleware/handle_ip_spoof_attack_error.rb' - - 'lib/gitlab/prometheus/queries/validate_query.rb' - - 'lib/gitlab/prometheus_client.rb' - - 'lib/gitlab/sanitizers/exif.rb' - - 'lib/gitlab/sidekiq_logging/structured_logger.rb' - - 'lib/gitlab/tcp_checker.rb' - - 'lib/gitlab/template_parser/parser.rb' - - 'lib/gitlab/tracking.rb' - - 'lib/gitlab/url_blocker.rb' - - 'lib/gitlab/usage/metrics/aggregates/aggregate.rb' - - 'lib/gitlab/usage_data.rb' - - 'lib/gitlab/utils/usage_data.rb' - - 'lib/gitlab/verify/batch_verifier.rb' - - 'lib/gitlab/wiki_pages/front_matter_parser.rb' - - 'lib/microsoft_teams/notifier.rb' - - 'lib/system_check/incoming_email/imap_authentication_check.rb' - - 'lib/tasks/gitlab/db/validate_config.rake' - - 'lib/tasks/gitlab/setup.rake' - - 'lib/tasks/gitlab/storage.rake' - - 'lib/tasks/lint.rake' - - 'qa/qa/resource/user_gpg.rb' - - 'scripts/review_apps/automated_cleanup.rb' - - 'scripts/trigger-build.rb' - - 'spec/commands/metrics_server/metrics_server_spec.rb' - - 'spec/db/docs_spec.rb' - - 'spec/lib/bulk_imports/network_error_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - - 'spec/lib/gitlab/error_tracking_spec.rb' - - 'spec/lib/gitlab/sanitizers/exception_message_spec.rb' - - 'spec/support/capybara.rb' - - 'spec/support/helpers/capybara_helpers.rb' - - 'tooling/lib/tooling/helm3_client.rb' - - 'tooling/lib/tooling/kubernetes_client.rb' diff --git a/.rubocop_todo/performance/block_given_with_explicit_block.yml b/.rubocop_todo/performance/block_given_with_explicit_block.yml deleted file mode 100644 index b919dbd19e6..00000000000 --- a/.rubocop_todo/performance/block_given_with_explicit_block.yml +++ /dev/null @@ -1,43 +0,0 @@ ---- -# Cop supports --auto-correct. -Performance/BlockGivenWithExplicitBlock: - Exclude: - - 'app/controllers/concerns/redis_tracking.rb' - - 'app/helpers/badges_helper.rb' - - 'app/helpers/instance_configuration_helper.rb' - - 'app/helpers/labels_helper.rb' - - 'app/helpers/tab_helper.rb' - - 'app/services/base_count_service.rb' - - 'app/services/error_tracking/base_service.rb' - - 'app/services/users/update_service.rb' - - 'ee/lib/elastic/latest/query_context.rb' - - 'ee/lib/gitlab/geo.rb' - - 'lib/bulk_imports/clients/http.rb' - - 'lib/gitlab/batch_pop_queueing.rb' - - 'lib/gitlab/cache/request_cache.rb' - - 'lib/gitlab/ci/trace/chunked_io.rb' - - 'lib/gitlab/database/bulk_update.rb' - - 'lib/gitlab/database/with_lock_retries.rb' - - 'lib/gitlab/github_import/client.rb' - - 'lib/gitlab/legacy_github_import/client.rb' - - 'lib/gitlab/metrics/methods/metric_options.rb' - - 'lib/gitlab/null_request_store.rb' - - 'lib/gitlab/quick_actions/dsl.rb' - - 'lib/gitlab/redis/multi_store.rb' - - 'lib/gitlab/safe_request_loader.rb' - - 'lib/gitlab/search/query.rb' - - 'lib/gitlab/string_placeholder_replacer.rb' - - 'lib/gitlab/terraform/state_migration_helper.rb' - - 'lib/gitlab/usage/metrics/instrumentations/base_metric.rb' - - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' - - 'lib/gitlab/usage/metrics/instrumentations/numbers_metric.rb' - - 'lib/gitlab/usage_data_queries.rb' - - 'lib/gitlab/utils/usage_data.rb' - - 'qa/qa/page/view.rb' - - 'spec/lib/api/helpers/authentication_spec.rb' - - 'spec/lib/gitlab/slash_commands/deploy_spec.rb' - - 'spec/support/helpers/graphql_helpers.rb' - - 'spec/support/helpers/query_recorder.rb' - - 'spec/support/helpers/stub_method_calls.rb' - - 'tooling/lib/tooling/helm3_client.rb' - - 'tooling/lib/tooling/test_map_packer.rb' diff --git a/.rubocop_todo/performance/constant_regexp.yml b/.rubocop_todo/performance/constant_regexp.yml deleted file mode 100644 index 23d03ced8d7..00000000000 --- a/.rubocop_todo/performance/constant_regexp.yml +++ /dev/null @@ -1,30 +0,0 @@ ---- -# Cop supports --auto-correct. -Performance/ConstantRegexp: - Exclude: - - 'app/models/commit.rb' - - 'app/models/commit_range.rb' - - 'app/models/custom_emoji.rb' - - 'app/models/gpg_key.rb' - - 'app/models/merge_request.rb' - - 'app/models/packages/package.rb' - - 'app/models/project.rb' - - 'app/models/wiki.rb' - - 'ee/app/models/ee/epic.rb' - - 'lib/banzai/filter/custom_emoji_filter.rb' - - 'lib/gitlab/cleanup/project_uploads.rb' - - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - - 'lib/gitlab/dependency_linker/base_linker.rb' - - 'lib/gitlab/dependency_linker/composer_json_linker.rb' - - 'lib/gitlab/dependency_linker/godeps_json_linker.rb' - - 'lib/gitlab/dependency_linker/podspec_linker.rb' - - 'lib/gitlab/git.rb' - - 'lib/gitlab/job_waiter.rb' - - 'lib/gitlab/metrics/dashboard/url.rb' - - 'lib/gitlab/path_regex.rb' - - 'lib/gitlab/regex.rb' - - 'scripts/perf/query_limiting_report.rb' - - 'scripts/validate_migration_schema' - - 'spec/features/users/email_verification_on_login_spec.rb' - - 'spec/models/concerns/token_authenticatable_spec.rb' - - 'spec/services/notes/copy_service_spec.rb' diff --git a/.rubocop_todo/rails/pick.yml b/.rubocop_todo/rails/pick.yml deleted file mode 100644 index 95ed3e61cb5..00000000000 --- a/.rubocop_todo/rails/pick.yml +++ /dev/null @@ -1,43 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/Pick: - # Offense count: 42 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'app/models/ci/pipeline.rb' - - 'app/models/merge_request.rb' - - 'app/models/merge_request/metrics.rb' - - 'app/models/merge_request_diff.rb' - - 'db/post_migrate/20210825193652_backfill_cadence_id_for_boards_scoped_to_iteration.rb' - - 'db/post_migrate/20220213103859_remove_integrations_type.rb' - - 'db/post_migrate/20220412143552_consume_remaining_encrypt_integration_property_jobs.rb' - - 'ee/app/models/concerns/epic_tree_sorting.rb' - - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/geo/project_registry.rb' - - 'ee/lib/analytics/merge_request_metrics_calculator.rb' - - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_status_column_of_security_scans.rb' - - 'ee/spec/finders/security/findings_finder_spec.rb' - - 'lib/gitlab/background_migration/backfill_ci_namespace_mirrors.rb' - - 'lib/gitlab/background_migration/backfill_ci_project_mirrors.rb' - - 'lib/gitlab/background_migration/backfill_integrations_type_new.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' - - 'lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - - 'lib/gitlab/background_migration/populate_vulnerability_reads.rb' - - 'lib/gitlab/background_migration/update_timelogs_null_spent_at.rb' - - 'lib/gitlab/database/dynamic_model_helpers.rb' - - 'lib/gitlab/database/migrations/background_migration_helpers.rb' - - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb' - - 'lib/gitlab/github_import/user_finder.rb' - - 'lib/gitlab/relative_positioning/item_context.rb' - - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - - 'spec/requests/projects/cycle_analytics_events_spec.rb' diff --git a/.rubocop_todo/rails/rake_environment.yml b/.rubocop_todo/rails/rake_environment.yml deleted file mode 100644 index d248db022ce..00000000000 --- a/.rubocop_todo/rails/rake_environment.yml +++ /dev/null @@ -1,25 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/RakeEnvironment: - # Offense count: 31 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'ee/lib/tasks/gitlab/elastic/test.rake' - - 'lib/tasks/config_lint.rake' - - 'lib/tasks/dev.rake' - - 'lib/tasks/gettext.rake' - - 'lib/tasks/gitlab/assets.rake' - - 'lib/tasks/gitlab/db.rake' - - 'lib/tasks/gitlab/docs/compile_deprecations.rake' - - 'lib/tasks/gitlab/docs/redirect.rake' - - 'lib/tasks/gitlab/helpers.rake' - - 'lib/tasks/gitlab/sidekiq.rake' - - 'lib/tasks/gitlab/tw/codeowners.rake' - - 'lib/tasks/gitlab/update_templates.rake' - - 'lib/tasks/lint.rake' - - 'lib/tasks/migrate/setup_postgresql.rake' - - 'lib/tasks/setup.rake' - - 'lib/tasks/test.rake' - - 'lib/tasks/yarn.rake' - - 'qa/qa/fixtures/auto_devops_rack/Rakefile' diff --git a/.rubocop_todo/rails/skips_model_validations.yml b/.rubocop_todo/rails/skips_model_validations.yml index 5c573a484f6..8ef895ed562 100644 --- a/.rubocop_todo/rails/skips_model_validations.yml +++ b/.rubocop_todo/rails/skips_model_validations.yml @@ -299,7 +299,6 @@ Rails/SkipsModelValidations: - 'ee/spec/models/ee/groups/feature_setting_spec.rb' - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - - 'ee/spec/models/ee/namespace_limit_spec.rb' - 'ee/spec/models/ee/vulnerability_spec.rb' - 'ee/spec/models/geo_node_spec.rb' - 'ee/spec/models/geo_node_status_spec.rb' diff --git a/.rubocop_todo/rspec/be.yml b/.rubocop_todo/rspec/be.yml new file mode 100644 index 00000000000..dad8a7d730b --- /dev/null +++ b/.rubocop_todo/rspec/be.yml @@ -0,0 +1,22 @@ +--- +RSpec/Be: + Exclude: + - 'ee/spec/services/groups/transfer_service_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' + - 'spec/lib/gitlab/lets_encrypt/client_spec.rb' + - 'spec/lib/gitlab/search_context/builder_spec.rb' + - 'spec/migrations/20220503035221_add_gitlab_schema_to_batched_background_migrations_spec.rb' + - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/identity_spec.rb' + - 'spec/models/snippet_repository_spec.rb' + - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' + - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' + - 'spec/requests/api/pages_domains_spec.rb' + - 'spec/services/pages/delete_service_spec.rb' + - 'spec/services/pages/destroy_deployments_service_spec.rb' + - 'spec/services/pages/migrate_from_legacy_storage_service_spec.rb' + - 'spec/services/projects/update_pages_service_spec.rb' + - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' + - 'spec/uploaders/file_uploader_spec.rb' + - 'spec/uploaders/namespace_file_uploader_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 724aa420d89..163533621a6 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -1,9 +1,7 @@ --- RSpec/ContextWording: - # Offense count: 18360 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'ee/spec/components/namespaces/free_user_cap/personal_usage_quota_limitations_alert_component_spec.rb' - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - 'ee/spec/controllers/admin/audit_logs_controller_spec.rb' - 'ee/spec/controllers/admin/dev_ops_report_controller_spec.rb' @@ -15,19 +13,15 @@ RSpec/ContextWording: - 'ee/spec/controllers/autocomplete_controller_spec.rb' - 'ee/spec/controllers/boards/lists_controller_spec.rb' - 'ee/spec/controllers/dashboard_controller_spec.rb' - - 'ee/spec/controllers/ee/dashboard/projects_controller_spec.rb' - 'ee/spec/controllers/ee/groups/variables_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' - - 'ee/spec/controllers/ee/profiles/preferences_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' - 'ee/spec/controllers/ee/registrations_controller_spec.rb' - 'ee/spec/controllers/ee/root_controller_spec.rb' - 'ee/spec/controllers/ee/search_controller_spec.rb' - 'ee/spec/controllers/ee/sent_notifications_controller_spec.rb' - - 'ee/spec/controllers/ee/sessions_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/cycle_analytics_controller_spec.rb' - - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' - 'ee/spec/controllers/groups/billings_controller_spec.rb' - 'ee/spec/controllers/groups/boards_controller_spec.rb' @@ -42,21 +36,15 @@ RSpec/ContextWording: - 'ee/spec/controllers/groups/push_rules_controller_spec.rb' - 'ee/spec/controllers/groups/saml_providers_controller_spec.rb' - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' - - 'ee/spec/controllers/groups/security/compliance_dashboards_controller_spec.rb' - - 'ee/spec/controllers/groups/security/dashboard_controller_spec.rb' - 'ee/spec/controllers/groups/security/merge_commit_reports_controller_spec.rb' - - 'ee/spec/controllers/groups/security/vulnerabilities_controller_spec.rb' - 'ee/spec/controllers/groups/sso_controller_spec.rb' - 'ee/spec/controllers/ldap/omniauth_callbacks_controller_spec.rb' - 'ee/spec/controllers/oauth/applications_controller_spec.rb' - 'ee/spec/controllers/oauth/geo_auth_controller_spec.rb' - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/controllers/profiles_controller_spec.rb' - - 'ee/spec/controllers/projects/approver_groups_controller_spec.rb' - - 'ee/spec/controllers/projects/approvers_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - 'ee/spec/controllers/projects/boards_controller_spec.rb' - - 'ee/spec/controllers/projects/branches_controller_spec.rb' - 'ee/spec/controllers/projects/environments_controller_spec.rb' - 'ee/spec/controllers/projects/imports_controller_spec.rb' - 'ee/spec/controllers/projects/incident_management/escalation_policies_controller_spec.rb' @@ -76,29 +64,27 @@ RSpec/ContextWording: - 'ee/spec/controllers/projects/settings/repository_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/registrations/company_controller_spec.rb' - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/registrations/welcome_controller_spec.rb' - 'ee/spec/controllers/repositories/git_http_controller_spec.rb' - 'ee/spec/controllers/security/dashboard_controller_spec.rb' - - 'ee/spec/controllers/security/projects_controller_spec.rb' - 'ee/spec/controllers/security/vulnerabilities_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/controllers/trial_registrations_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/controllers/users_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/elastic/migrate/20220512150000_pause_indexing_for_unsupported_es_versions_spec.rb' + - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' + - 'ee/spec/elastic/migrate/20220713103500_delete_commits_from_original_index_spec.rb' - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/elastic_integration/global_search_spec.rb' - 'ee/spec/features/admin/admin_audit_logs_spec.rb' - 'ee/spec/features/admin/admin_credentials_inventory_spec.rb' - - 'ee/spec/features/admin/admin_dashboard_spec.rb' - 'ee/spec/features/admin/admin_dev_ops_reports_spec.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/admin/geo/admin_geo_nodes_spec.rb' - - 'ee/spec/features/admin/geo/admin_geo_sidebar_spec.rb' - - 'ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb' - 'ee/spec/features/admin/licenses/admin_adds_license_spec.rb' - - 'ee/spec/features/admin/licenses/show_user_count_threshold_spec.rb' - 'ee/spec/features/analytics/code_analytics_spec.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/features/boards/boards_licensed_features_spec.rb' @@ -109,9 +95,8 @@ RSpec/ContextWording: - 'ee/spec/features/boards/swimlanes/epics_swimlanes_drag_drop_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_labels_spec.rb' - - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_spec.rb' - - 'ee/spec/features/boards/user_visits_board_spec.rb' + - 'ee/spec/features/dashboards/todos_spec.rb' - 'ee/spec/features/discussion_comments/epic_quick_actions_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_spec.rb' @@ -120,25 +105,19 @@ RSpec/ContextWording: - 'ee/spec/features/epics/epic_issues_spec.rb' - 'ee/spec/features/epics/epics_list_spec.rb' - 'ee/spec/features/epics/gfm_autocomplete_spec.rb' - - 'ee/spec/features/epics/issue_promotion_spec.rb' - 'ee/spec/features/epics/referencing_epics_spec.rb' - 'ee/spec/features/epics/update_epic_spec.rb' - - 'ee/spec/features/epics/user_uses_quick_actions_spec.rb' - 'ee/spec/features/geo_node_spec.rb' - - 'ee/spec/features/google_analytics_datalayer_spec.rb' - - 'ee/spec/features/groups/active_tabs_spec.rb' + - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb' - 'ee/spec/features/groups/audit_events_spec.rb' - - 'ee/spec/features/groups/group_overview_spec.rb' - 'ee/spec/features/groups/group_roadmap_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/groups/groups_security_credentials_spec.rb' - 'ee/spec/features/groups/issues_spec.rb' - 'ee/spec/features/groups/iteration_spec.rb' - - 'ee/spec/features/groups/iterations/iterations_list_spec.rb' - - 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb' - 'ee/spec/features/groups/iterations/user_edits_iteration_spec.rb' - 'ee/spec/features/groups/ldap_group_links_spec.rb' - 'ee/spec/features/groups/members/manage_groups_spec.rb' @@ -148,13 +127,11 @@ RSpec/ContextWording: - 'ee/spec/features/groups/saml_providers_spec.rb' - 'ee/spec/features/groups/seat_usage/seat_usage_spec.rb' - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - - 'ee/spec/features/groups/settings/user_searches_in_settings_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - 'ee/spec/features/groups/usage_quotas_spec.rb' - - 'ee/spec/features/groups/wiki/user_views_wiki_empty_spec.rb' - 'ee/spec/features/groups_spec.rb' + - 'ee/spec/features/ide/user_commits_changes_spec.rb' - 'ee/spec/features/ide/user_opens_ide_spec.rb' - - 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb' - 'ee/spec/features/issues/epic_in_issue_sidebar_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb' - 'ee/spec/features/issues/form_spec.rb' @@ -180,20 +157,19 @@ RSpec/ContextWording: - 'ee/spec/features/merge_requests/user_filters_by_approvers_spec.rb' - 'ee/spec/features/oncall_schedules/user_creates_schedule_spec.rb' - 'ee/spec/features/profiles/account_spec.rb' + - 'ee/spec/features/profiles/usage_quotas_spec.rb' - 'ee/spec/features/projects/active_tabs_spec.rb' - 'ee/spec/features/projects/audit_events_spec.rb' - 'ee/spec/features/projects/custom_projects_template_spec.rb' - - 'ee/spec/features/projects/issues/user_creates_issue_spec.rb' - - 'ee/spec/features/projects/iterations/iteration_cadences_list_spec.rb' - - 'ee/spec/features/projects/iterations/iterations_list_spec.rb' - 'ee/spec/features/projects/iterations/user_views_iteration_spec.rb' - 'ee/spec/features/projects/jobs_spec.rb' - 'ee/spec/features/projects/kerberos_clone_instructions_spec.rb' - - 'ee/spec/features/projects/members/invite_group_and_members_spec.rb' + - 'ee/spec/features/projects/members/manage_groups_spec.rb' - 'ee/spec/features/projects/members/member_leaves_project_spec.rb' - 'ee/spec/features/projects/milestones/milestone_spec.rb' - 'ee/spec/features/projects/new_project_from_template_spec.rb' - 'ee/spec/features/projects/new_project_spec.rb' + - 'ee/spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - 'ee/spec/features/projects/push_rules_spec.rb' - 'ee/spec/features/projects/quality/test_case_create_spec.rb' @@ -206,25 +182,18 @@ RSpec/ContextWording: - 'ee/spec/features/projects/settings/merge_requests_settings_spec.rb' - 'ee/spec/features/projects/settings/protected_environments_spec.rb' - 'ee/spec/features/projects/settings/push_rules_settings_spec.rb' - - 'ee/spec/features/projects/settings/user_manages_members_spec.rb' - - 'ee/spec/features/projects/show_project_spec.rb' - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/protected_branches_spec.rb' - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/features/registrations/welcome_spec.rb' - 'ee/spec/features/search/elastic/global_search_spec.rb' - - 'ee/spec/features/search/elastic/snippet_search_spec.rb' - - 'ee/spec/features/security/project/snippet/internal_access_spec.rb' - - 'ee/spec/features/security/project/snippet/public_access_spec.rb' - 'ee/spec/features/signup_spec.rb' - - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' - 'ee/spec/features/trials/select_namespace_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/features/users/signup_spec.rb' + - 'ee/spec/finders/approval_rules/group_finder_spec.rb' - 'ee/spec/finders/audit_event_finder_spec.rb' - - 'ee/spec/finders/autocomplete/vulnerabilities_autocomplete_finder_spec.rb' - - 'ee/spec/finders/billed_users_finder_spec.rb' - 'ee/spec/finders/clusters/environments_finder_spec.rb' - 'ee/spec/finders/compliance_management/merge_requests/compliance_violations_finder_spec.rb' - 'ee/spec/finders/custom_project_templates_finder_spec.rb' @@ -234,6 +203,7 @@ RSpec/ContextWording: - 'ee/spec/finders/dast_site_validations_finder_spec.rb' - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/ee/clusters/agent_authorizations_finder_spec.rb' + - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' - 'ee/spec/finders/ee/namespaces/projects_finder_spec.rb' - 'ee/spec/finders/ee/projects_finder_spec.rb' @@ -260,7 +230,6 @@ RSpec/ContextWording: - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - 'ee/spec/finders/snippets_finder_spec.rb' - 'ee/spec/finders/software_license_policies_finder_spec.rb' - - 'ee/spec/finders/status_page/incidents_finder_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' @@ -269,11 +238,12 @@ RSpec/ContextWording: - 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' - 'ee/spec/graphql/ee/types/projects/service_type_enum_spec.rb' + - 'ee/spec/graphql/mutations/audit_events/streaming/headers/create_spec.rb' + - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/destroy_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/update_spec.rb' - - 'ee/spec/graphql/mutations/boards/epic_lists/update_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/create_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' @@ -294,12 +264,11 @@ RSpec/ContextWording: - 'ee/spec/graphql/mutations/security_policy/assign_security_policy_project_spec.rb' - 'ee/spec/graphql/mutations/security_policy/commit_scan_execution_policy_spec.rb' - 'ee/spec/graphql/mutations/security_policy/create_security_policy_project_spec.rb' - - 'ee/spec/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' - - 'ee/spec/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb' - 'ee/spec/graphql/resolvers/admin/cloud_licenses/subscription_future_entries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver_spec.rb' - 'ee/spec/graphql/resolvers/boards/board_list_epics_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/dora_metrics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/oncall_schedule_resolver_spec.rb' - 'ee/spec/graphql/resolvers/instance_security_dashboard/projects_resolver_spec.rb' @@ -308,7 +277,6 @@ RSpec/ContextWording: - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb' - 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' - 'ee/spec/graphql/types/global_id_type_spec.rb' - 'ee/spec/graphql/types/incident_management/escalation_rule_input_type_spec.rb' - 'ee/spec/graphql/types/issue_type_spec.rb' @@ -320,42 +288,32 @@ RSpec/ContextWording: - 'ee/spec/helpers/application_helper_spec.rb' - 'ee/spec/helpers/boards_helper_spec.rb' - 'ee/spec/helpers/compliance_management/compliance_framework/group_settings_helper_spec.rb' - - 'ee/spec/helpers/ee/application_settings_helper_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - - 'ee/spec/helpers/ee/dashboard_helper_spec.rb' - 'ee/spec/helpers/ee/environments_helper_spec.rb' - - 'ee/spec/helpers/ee/events_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' + - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/issuables_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' - - 'ee/spec/helpers/ee/learn_gitlab_helper_spec.rb' - 'ee/spec/helpers/ee/lock_helper_spec.rb' - - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/operations_helper_spec.rb' - 'ee/spec/helpers/ee/personal_access_tokens_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb' - - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - - 'ee/spec/helpers/ee/system_note_helper_spec.rb' - - 'ee/spec/helpers/ee/version_check_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/groups/security_features_helper_spec.rb' - 'ee/spec/helpers/license_helper_spec.rb' - 'ee/spec/helpers/license_monitoring_helper_spec.rb' - - 'ee/spec/helpers/notes_helper_spec.rb' - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' + - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - 'ee/spec/initializers/1_settings_spec.rb' - - 'ee/spec/initializers/database_config_spec.rb' - 'ee/spec/initializers/session_store_spec.rb' - - 'ee/spec/lib/analytics/devops_adoption/snapshot_calculator_spec.rb' - - 'ee/spec/lib/analytics/refresh_comments_data_spec.rb' - 'ee/spec/lib/audit/details_spec.rb' - 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb' - 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb' @@ -370,10 +328,10 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb' - 'ee/spec/lib/ee/api/helpers/variables_helpers_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' + - 'ee/spec/lib/ee/backup/repositories_spec.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/groups_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' @@ -382,9 +340,7 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/needs_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/job_activity_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/templates/templates_spec.rb' - 'ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_batch_spec.rb' @@ -395,7 +351,6 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/gon_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/group_search_results_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/group_member_builder_spec.rb' - - 'ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_saver_spec.rb' @@ -403,24 +358,18 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/ip_restriction/enforcer_spec.rb' + - 'ee/spec/lib/ee/gitlab/issuable/clone/copy_resource_events_service_spec.rb' - 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb' - - 'ee/spec/lib/ee/gitlab/metrics/samplers/database_sampler_spec.rb' - - 'ee/spec/lib/ee/gitlab/omniauth_initializer_spec.rb' - - 'ee/spec/lib/ee/gitlab/prometheus/metric_group_spec.rb' - 'ee/spec/lib/ee/gitlab/repo_path_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - 'ee/spec/lib/ee/gitlab/usage/service_ping/payload_keys_processor_spec.rb' - - 'ee/spec/lib/ee/gitlab/usage/service_ping_report_spec.rb' - - 'ee/spec/lib/ee/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' + - 'ee/spec/lib/ee/service_ping/build_payload_spec.rb' - 'ee/spec/lib/elastic/multi_version_class_proxy_spec.rb' - 'ee/spec/lib/elastic/multi_version_instance_proxy_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/lead_time_for_changes_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/lead_time_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/gma_membership_enforcer_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/group_lookup_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/identity_linker_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/sso_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/token_actor_spec.rb' @@ -432,18 +381,12 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - - 'ee/spec/lib/gitlab/cache_spec.rb' - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/runners_availability_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/create_cross_database_associations_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/dependency_list/dependency_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Jobs/browser_performance_testing_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_testing_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/api_security_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/api_security_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb' @@ -454,6 +397,7 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/license_scanning_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/sast_iac_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_iac_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/secret_detection_gitlab_ci_yaml_spec.rb' @@ -487,53 +431,38 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - 'ee/spec/lib/gitlab/geo/signed_data_spec.rb' - - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/git_access_wiki_spec.rb' - 'ee/spec/lib/gitlab/gl_repository/identifier_spec.rb' - 'ee/spec/lib/gitlab/gl_repository/repo_type_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/epic_node_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerabilities/lazy_user_notes_count_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - - 'ee/spec/lib/gitlab/import_export/group/group_and_descendants_repo_restorer_spec.rb' - - 'ee/spec/lib/gitlab/import_export/group/group_and_descendants_repo_saver_spec.rb' - 'ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb' - 'ee/spec/lib/gitlab/import_export/project/object_builder_spec.rb' - 'ee/spec/lib/gitlab/insights/finders/issuable_finder_spec.rb' - 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb' - 'ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' - 'ee/spec/lib/gitlab/pagination_delegate_spec.rb' - - 'ee/spec/lib/gitlab/patch/database_config_spec.rb' - - 'ee/spec/lib/gitlab/reference_extractor_spec.rb' - 'ee/spec/lib/gitlab/search/aggregation_parser_spec.rb' - - 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/url_extractor_spec.rb' - 'ee/spec/lib/gitlab/slash_commands/presenters/issue_show_spec.rb' - 'ee/spec/lib/gitlab/status_page/filter/image_filter_spec.rb' - 'ee/spec/lib/gitlab/status_page/storage/s3_client_spec.rb' - - 'ee/spec/lib/gitlab/status_page/storage/s3_multipart_upload_spec.rb' - 'ee/spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'ee/spec/lib/gitlab/tracking/standard_context_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/build_type_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/distribution_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/lucene_version_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/version_metric_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/approval_project_rules_with_user_metric_spec.rb' - 'ee/spec/lib/gitlab/usage_data_counters/epic_activity_unique_counter_spec.rb' - 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb' - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' - - 'ee/spec/lib/system_check/app/search_check_spec.rb' - 'ee/spec/lib/system_check/geo/authorized_keys_check_spec.rb' - 'ee/spec/lib/system_check/geo/http_connection_check_spec.rb' - 'ee/spec/lib/system_check/rake_task/geo_task_spec.rb' - 'ee/spec/mailers/ee/emails/issues_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/migrations/schedule_requirements_migration_spec.rb' - - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - 'ee/spec/models/alert_management/alert_payload_field_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/group_stage_spec.rb' @@ -542,21 +471,18 @@ RSpec/ContextWording: - 'ee/spec/models/approval_merge_request_rule_spec.rb' - 'ee/spec/models/approval_project_rule_spec.rb' - 'ee/spec/models/approval_state_spec.rb' + - 'ee/spec/models/audit_events/external_audit_event_destination_spec.rb' - 'ee/spec/models/board_spec.rb' - 'ee/spec/models/boards/epic_board_position_spec.rb' - - 'ee/spec/models/broadcast_message_spec.rb' - 'ee/spec/models/ci/build_spec.rb' - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' - - 'ee/spec/models/ci/pipeline_spec.rb' - 'ee/spec/models/ci/sources/project_spec.rb' - 'ee/spec/models/ci/subscriptions/project_spec.rb' - - 'ee/spec/models/compliance_management/framework_spec.rb' - 'ee/spec/models/concerns/approval_rule_like_spec.rb' - 'ee/spec/models/concerns/approver_migrate_hook_spec.rb' - 'ee/spec/models/concerns/deprecated_approvals_before_merge_spec.rb' - 'ee/spec/models/concerns/ee/issuable_spec.rb' - - 'ee/spec/models/concerns/ee/milestoneable_spec.rb' - 'ee/spec/models/concerns/ee/participable_spec.rb' - 'ee/spec/models/concerns/elastic/issue_spec.rb' - 'ee/spec/models/concerns/elastic/note_spec.rb' @@ -571,38 +497,27 @@ RSpec/ContextWording: - 'ee/spec/models/dast_site_profile_spec.rb' - 'ee/spec/models/dast_site_validation_spec.rb' - 'ee/spec/models/deployment_spec.rb' - - 'ee/spec/models/dora/change_failure_rate_metric_spec.rb' - - 'ee/spec/models/dora/time_to_restore_service_metric_spec.rb' - 'ee/spec/models/ee/audit_event_spec.rb' - 'ee/spec/models/ee/award_emoji_spec.rb' - - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - - 'ee/spec/models/ee/ci/runner_spec.rb' + - 'ee/spec/models/ee/event_collection_spec.rb' - 'ee/spec/models/ee/event_spec.rb' + - 'ee/spec/models/ee/group_group_link_spec.rb' - 'ee/spec/models/ee/group_spec.rb' - 'ee/spec/models/ee/incident_management/project_incident_management_setting_spec.rb' - - 'ee/spec/models/ee/integrations/jira_spec.rb' - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - - 'ee/spec/models/ee/key_spec.rb' - - 'ee/spec/models/ee/merge_request_diff_spec.rb' - - 'ee/spec/models/ee/namespace/root_storage_size_spec.rb' - 'ee/spec/models/ee/namespace_ci_cd_setting_spec.rb' - - 'ee/spec/models/ee/namespace_limit_spec.rb' - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/ee/notification_setting_spec.rb' - 'ee/spec/models/ee/personal_access_token_spec.rb' - 'ee/spec/models/ee/project_group_link_spec.rb' - 'ee/spec/models/ee/protected_branch_spec.rb' - - 'ee/spec/models/ee/protected_ref_spec.rb' - - 'ee/spec/models/ee/service_desk_setting_spec.rb' - 'ee/spec/models/ee/user_spec.rb' - - 'ee/spec/models/environment_spec.rb' - 'ee/spec/models/epic_issue_spec.rb' - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/geo/container_repository_registry_spec.rb' - 'ee/spec/models/geo/design_registry_spec.rb' - - 'ee/spec/models/geo/job_artifact_registry_spec.rb' - 'ee/spec/models/geo/project_registry_spec.rb' - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - 'ee/spec/models/geo_node_spec.rb' @@ -611,13 +526,10 @@ RSpec/ContextWording: - 'ee/spec/models/gitlab_subscriptions/features_spec.rb' - 'ee/spec/models/group_member_spec.rb' - 'ee/spec/models/group_wiki_repository_spec.rb' - - 'ee/spec/models/group_wiki_spec.rb' - 'ee/spec/models/incident_management/escalation_rule_spec.rb' - 'ee/spec/models/incident_management/oncall_rotation_spec.rb' - - 'ee/spec/models/incident_management/oncall_shift_spec.rb' - 'ee/spec/models/incident_management/pending_escalations/alert_spec.rb' - 'ee/spec/models/incident_management/pending_escalations/issue_spec.rb' - - 'ee/spec/models/integrations/github/remote_project_spec.rb' - 'ee/spec/models/integrations/github_spec.rb' - 'ee/spec/models/ip_restriction_spec.rb' - 'ee/spec/models/issuable_metric_image_spec.rb' @@ -633,7 +545,6 @@ RSpec/ContextWording: - 'ee/spec/models/note_spec.rb' - 'ee/spec/models/packages/package_file_spec.rb' - 'ee/spec/models/path_lock_spec.rb' - - 'ee/spec/models/productivity_analytics_spec.rb' - 'ee/spec/models/project_import_data_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/project_member_spec.rb' @@ -643,19 +554,13 @@ RSpec/ContextWording: - 'ee/spec/models/protected_environments/approval_summary_spec.rb' - 'ee/spec/models/push_rule_spec.rb' - 'ee/spec/models/release_highlight_spec.rb' - - 'ee/spec/models/remote_mirror_spec.rb' - - 'ee/spec/models/repository_spec.rb' - - 'ee/spec/models/requirements_management/requirement_spec.rb' - 'ee/spec/models/requirements_management/test_report_spec.rb' - 'ee/spec/models/saml_group_link_spec.rb' - 'ee/spec/models/saml_provider_spec.rb' - 'ee/spec/models/status_page/project_setting_spec.rb' - - 'ee/spec/models/uploads/local_spec.rb' - - 'ee/spec/models/vulnerabilities/export_spec.rb' - 'ee/spec/models/vulnerabilities/feedback_spec.rb' - 'ee/spec/models/vulnerabilities/finding_pipeline_spec.rb' - 'ee/spec/models/vulnerabilities/finding_spec.rb' - - 'ee/spec/models/vulnerabilities/read_spec.rb' - 'ee/spec/models/vulnerabilities/statistic_spec.rb' - 'ee/spec/policies/app_sec/fuzzing/coverage/corpus_policy_spec.rb' - 'ee/spec/policies/compliance_management/framework_policy_spec.rb' @@ -669,12 +574,10 @@ RSpec/ContextWording: - 'ee/spec/policies/incident_management/oncall_shift_policy_spec.rb' - 'ee/spec/policies/issuable_policy_spec.rb' - 'ee/spec/policies/merge_request_policy_spec.rb' - - 'ee/spec/policies/note_policy_spec.rb' - 'ee/spec/policies/project_policy_spec.rb' - 'ee/spec/policies/project_snippet_policy_spec.rb' - 'ee/spec/policies/protected_branch_policy_spec.rb' - 'ee/spec/policies/saml_provider_policy_spec.rb' - - 'ee/spec/policies/user_policy_spec.rb' - 'ee/spec/presenters/approval_rule_presenter_spec.rb' - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/ci/build_runner_presenter_spec.rb' @@ -686,18 +589,16 @@ RSpec/ContextWording: - 'ee/spec/requests/admin/geo/replicables_controller_spec.rb' - 'ee/spec/requests/api/analytics/group_activity_analytics_spec.rb' - 'ee/spec/requests/api/audit_events_spec.rb' - - 'ee/spec/requests/api/award_emoji_spec.rb' - 'ee/spec/requests/api/boards_spec.rb' - 'ee/spec/requests/api/ci/jobs_spec.rb' - 'ee/spec/requests/api/ci/pipelines_spec.rb' - 'ee/spec/requests/api/ci/runner_spec.rb' - - 'ee/spec/requests/api/ci/triggers_spec.rb' - 'ee/spec/requests/api/commits_spec.rb' - 'ee/spec/requests/api/deployments_spec.rb' + - 'ee/spec/requests/api/dora/metrics_spec.rb' - 'ee/spec/requests/api/epic_issues_spec.rb' - 'ee/spec/requests/api/epic_links_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' - - 'ee/spec/requests/api/experiments_spec.rb' - 'ee/spec/requests/api/geo_nodes_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' - 'ee/spec/requests/api/graphql/boards/epic_boards_query_spec.rb' @@ -720,15 +621,14 @@ RSpec/ContextWording: - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/epics/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/incident_management/escalation_policy/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/incident_management/issuable_resource_link/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/issues/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/security_policy/assign_security_policy_project_spec.rb' - 'ee/spec/requests/api/graphql/mutations/security_policy/commit_scan_execution_policy_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/security_policy/create_security_policy_project_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb' - 'ee/spec/requests/api/graphql/project/code_coverage_summary_spec.rb' - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policies_spec.rb' - 'ee/spec/requests/api/graphql/project/incident_management/oncall_participants_spec.rb' @@ -739,7 +639,6 @@ RSpec/ContextWording: - 'ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb' - 'ee/spec/requests/api/graphql/vulnerabilities/sort_spec.rb' - 'ee/spec/requests/api/group_clusters_spec.rb' - - 'ee/spec/requests/api/group_hooks_spec.rb' - 'ee/spec/requests/api/group_push_rule_spec.rb' - 'ee/spec/requests/api/group_variables_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' @@ -753,7 +652,6 @@ RSpec/ContextWording: - 'ee/spec/requests/api/members_spec.rb' - 'ee/spec/requests/api/merge_request_approval_rules_spec.rb' - 'ee/spec/requests/api/merge_request_approval_settings_spec.rb' - - 'ee/spec/requests/api/merge_request_approvals_spec.rb' - 'ee/spec/requests/api/merge_requests_spec.rb' - 'ee/spec/requests/api/namespaces_spec.rb' - 'ee/spec/requests/api/project_aliases_spec.rb' @@ -773,19 +671,13 @@ RSpec/ContextWording: - 'ee/spec/requests/api/status_checks_spec.rb' - 'ee/spec/requests/api/users_spec.rb' - 'ee/spec/requests/api/v3/github_spec.rb' - - 'ee/spec/requests/api/visual_review_discussions_spec.rb' - - 'ee/spec/requests/api/vulnerabilities_spec.rb' - - 'ee/spec/requests/api/vulnerability_exports_spec.rb' - 'ee/spec/requests/api/vulnerability_findings_spec.rb' - 'ee/spec/requests/git_http_geo_spec.rb' - - 'ee/spec/requests/groups/group_members_controller_spec.rb' - 'ee/spec/requests/groups/roadmap_controller_spec.rb' - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' - - 'ee/spec/requests/groups/usage_quotas_spec.rb' + - 'ee/spec/requests/groups/settings/reporting_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - 'ee/spec/requests/jwt_controller_spec.rb' - - 'ee/spec/requests/lfs_http_spec.rb' - - 'ee/spec/requests/projects/analytics/code_reviews_controller_spec.rb' - 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb' - 'ee/spec/requests/projects/requirements_management/requirements_controller_spec.rb' - 'ee/spec/requests/projects/security/corpus_management_controller_spec.rb' @@ -796,7 +688,6 @@ RSpec/ContextWording: - 'ee/spec/requests/projects/security/scanned_resources_controller_spec.rb' - 'ee/spec/requests/rack_attack_spec.rb' - 'ee/spec/requests/repositories/git_http_controller_spec.rb' - - 'ee/spec/requests/search_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/routing/user_routing_spec.rb' - 'ee/spec/serializers/analytics/cycle_analytics/value_stream_errors_serializer_spec.rb' @@ -804,25 +695,19 @@ RSpec/ContextWording: - 'ee/spec/serializers/board_serializer_spec.rb' - 'ee/spec/serializers/clusters/environment_entity_spec.rb' - 'ee/spec/serializers/dashboard_operations_project_entity_spec.rb' - - 'ee/spec/serializers/ee/blob_entity_spec.rb' - 'ee/spec/serializers/ee/group_child_entity_spec.rb' - - 'ee/spec/serializers/ee/issue_sidebar_basic_entity_spec.rb' - 'ee/spec/serializers/ee/issue_sidebar_extras_entity_spec.rb' - 'ee/spec/serializers/ee/merge_request_poll_cached_widget_entity_spec.rb' - 'ee/spec/serializers/ee/user_serializer_spec.rb' - 'ee/spec/serializers/environment_entity_spec.rb' - - 'ee/spec/serializers/epic_note_entity_spec.rb' - 'ee/spec/serializers/issue_serializer_spec.rb' - 'ee/spec/serializers/member_entity_spec.rb' - 'ee/spec/serializers/member_user_entity_spec.rb' - 'ee/spec/serializers/merge_request_widget_entity_spec.rb' - 'ee/spec/serializers/project_mirror_entity_spec.rb' - 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb' - - 'ee/spec/services/alert_management/process_prometheus_alert_service_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/stages/delete_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' - - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/create_service_spec.rb' - 'ee/spec/services/app_sec/dast/builds/associate_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - 'ee/spec/services/application_settings/update_service_spec.rb' @@ -833,29 +718,20 @@ RSpec/ContextWording: - 'ee/spec/services/approval_rules/update_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - 'ee/spec/services/audit_events/export_csv_service_spec.rb' - - 'ee/spec/services/audit_events/register_runner_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/runners_token_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/unregister_runner_audit_event_service_spec.rb' - - 'ee/spec/services/award_emojis/add_service_spec.rb' - 'ee/spec/services/boards/create_service_spec.rb' - 'ee/spec/services/boards/epic_boards/create_service_spec.rb' - 'ee/spec/services/boards/epics/move_service_spec.rb' - - 'ee/spec/services/boards/epics/position_create_service_spec.rb' - 'ee/spec/services/boards/lists/update_service_spec.rb' - 'ee/spec/services/ci/copy_cross_database_associations_service_spec.rb' - 'ee/spec/services/ci/create_pipeline_service_spec.rb' - - 'ee/spec/services/ci/minutes/update_build_minutes_service_spec.rb' - 'ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb' - - 'ee/spec/services/ci/process_build_service_spec.rb' + - 'ee/spec/services/ci/pipeline_trigger_service_spec.rb' - 'ee/spec/services/ci/register_job_service_spec.rb' - 'ee/spec/services/ci/retry_job_service_spec.rb' - - 'ee/spec/services/ci/runners/unregister_runner_service_spec.rb' - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' - 'ee/spec/services/ci_cd/setup_project_spec.rb' - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' - - 'ee/spec/services/compliance_management/merge_requests/create_compliance_violations_service_spec.rb' - - 'ee/spec/services/dashboard/projects/list_service_spec.rb' - 'ee/spec/services/deployments/approval_service_spec.rb' - 'ee/spec/services/dora/aggregate_metrics_service_spec.rb' - 'ee/spec/services/ee/alert_management/alerts/update_service_spec.rb' @@ -871,16 +747,16 @@ RSpec/ContextWording: - 'ee/spec/services/ee/integrations/test/project_service_spec.rb' - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' - - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/clone_service_spec.rb' - 'ee/spec/services/ee/issues/close_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/issues/move_service_spec.rb' - 'ee/spec/services/ee/issues/reopen_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' - - 'ee/spec/services/ee/labels/create_service_spec.rb' + - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - 'ee/spec/services/ee/members/create_service_spec.rb' - 'ee/spec/services/ee/members/destroy_service_spec.rb' + - 'ee/spec/services/ee/members/import_project_team_service_spec.rb' - 'ee/spec/services/ee/members/invite_service_spec.rb' - 'ee/spec/services/ee/merge_requests/base_service_spec.rb' - 'ee/spec/services/ee/merge_requests/create_service_spec.rb' @@ -888,16 +764,13 @@ RSpec/ContextWording: - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - - 'ee/spec/services/ee/namespace_settings/update_service_spec.rb' - 'ee/spec/services/ee/notes/create_service_spec.rb' - 'ee/spec/services/ee/notes/post_process_service_spec.rb' - 'ee/spec/services/ee/notes/quick_actions_service_spec.rb' - - 'ee/spec/services/ee/notes/update_service_spec.rb' - 'ee/spec/services/ee/notification_service_spec.rb' - 'ee/spec/services/ee/personal_access_tokens/revoke_service_spec.rb' - 'ee/spec/services/ee/preview_markdown_service_spec.rb' - 'ee/spec/services/ee/protected_branches/create_service_spec.rb' - - 'ee/spec/services/ee/quick_actions/target_service_spec.rb' - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb' - 'ee/spec/services/ee/users/build_service_spec.rb' - 'ee/spec/services/ee/users/create_service_spec.rb' @@ -915,7 +788,6 @@ RSpec/ContextWording: - 'ee/spec/services/epic_issues/update_service_spec.rb' - 'ee/spec/services/epics/create_service_spec.rb' - 'ee/spec/services/epics/epic_links/list_service_spec.rb' - - 'ee/spec/services/epics/issue_promote_service_spec.rb' - 'ee/spec/services/epics/related_epic_links/create_service_spec.rb' - 'ee/spec/services/epics/related_epic_links/destroy_service_spec.rb' - 'ee/spec/services/epics/update_dates_service_spec.rb' @@ -936,13 +808,13 @@ RSpec/ContextWording: - 'ee/spec/services/geo/repository_created_event_store_spec.rb' - 'ee/spec/services/geo/repository_sync_service_spec.rb' - 'ee/spec/services/geo/repository_verification_reset_spec.rb' - - 'ee/spec/services/geo/repository_verification_secondary_service_spec.rb' - 'ee/spec/services/geo/wiki_sync_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/activate_awaiting_users_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/extend_reactivate_trial_service_spec.rb' - - 'ee/spec/services/group_saml/group_managed_accounts/clean_up_members_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' - 'ee/spec/services/group_saml/group_managed_accounts/transfer_membership_service_spec.rb' - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/destroy_service_spec.rb' @@ -975,10 +847,9 @@ RSpec/ContextWording: - 'ee/spec/services/merge_requests/approval_service_spec.rb' - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' + - 'ee/spec/services/merge_requests/reload_merge_head_diff_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - 'ee/spec/services/milestones/update_service_spec.rb' - - 'ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - - 'ee/spec/services/namespaces/storage/email_notification_service_spec.rb' - 'ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb' - 'ee/spec/services/personal_access_tokens/rotation_verifier_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' @@ -988,7 +859,7 @@ RSpec/ContextWording: - 'ee/spec/services/projects/gitlab_projects_import_service_spec.rb' - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' - - 'ee/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' + - 'ee/spec/services/projects/group_links/update_service_spec.rb' - 'ee/spec/services/projects/import_export/export_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/operations/update_service_spec.rb' @@ -1011,13 +882,12 @@ RSpec/ContextWording: - 'ee/spec/services/search/snippet_service_spec.rb' - 'ee/spec/services/search_service_spec.rb' - 'ee/spec/services/security/dependency_list_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities/create_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' - - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - - 'ee/spec/services/security/orchestration/unassign_service_spec.rb' - 'ee/spec/services/security/report_summary_service_spec.rb' - 'ee/spec/services/security/scanned_resources_counting_service_spec.rb' - 'ee/spec/services/security/scanned_resources_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/policy_commit_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/process_policy_service_spec.rb' - 'ee/spec/services/security/store_grouped_scans_service_spec.rb' @@ -1027,16 +897,12 @@ RSpec/ContextWording: - 'ee/spec/services/software_license_policies/update_service_spec.rb' - 'ee/spec/services/status_page/publish_attachments_service_spec.rb' - 'ee/spec/services/status_page/publish_details_service_spec.rb' - - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' - 'ee/spec/services/system_notes/epics_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/services/user_permissions/export_service_spec.rb' - - 'ee/spec/services/vulnerabilities/create_service_spec.rb' - - 'ee/spec/services/vulnerabilities/historical_statistics/deletion_service_spec.rb' - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' - 'ee/spec/support/features/manual_quarterly_co_term_banner_examples.rb' - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' - 'ee/spec/support/shared_contexts/audit_event_not_licensed_shared_context.rb' @@ -1046,25 +912,22 @@ RSpec/ContextWording: - 'ee/spec/support/shared_contexts/gitlab_team_member_shared_context.rb' - 'ee/spec/support/shared_contexts/graphql/resolvers/security_orchestration/resolves_orchestration_policy_shared_contexts.rb' - 'ee/spec/support/shared_contexts/lib/gitlab/insights/reducers/reducers_shared_contexts.rb' + - 'ee/spec/support/shared_contexts/lib/gitlab/insights/serializers/serializers_shared_context.rb' - 'ee/spec/support/shared_contexts/push_rules_checks_shared_context.rb' - 'ee/spec/support/shared_contexts/requests/api/members_shared_contexts.rb' - 'ee/spec/support/shared_contexts/status_page/status_page_enabled_context.rb' - 'ee/spec/support/shared_contexts/status_page/status_page_list_objects.rb' - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/analytics/issues_analytics/shared_issues_analytics_examples.rb' - 'ee/spec/support/shared_examples/controllers/boards_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/registrations/groups_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/security/application_controller_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/credentials_inventory_shared_examples.rb' - 'ee/spec/support/shared_examples/features/insights_shared_examples.rb' + - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - 'ee/spec/support/shared_examples/features/sidebar_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/ultimate_trial_callout_shared_examples.rb' - 'ee/spec/support/shared_examples/graphql/mutations/epics/permission_check_shared_examples.rb' - - 'ee/spec/support/shared_examples/graphql/mutations/update_health_status_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/git_access_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/middleware/allowlisted_admin_geo_requests_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/middleware/maintenance_mode_gitlab_ee_instance_shared_examples.rb' @@ -1076,18 +939,13 @@ RSpec/ContextWording: - 'ee/spec/support/shared_examples/models/concerns/replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/repository_replicator_strategy_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - - 'ee/spec/support/shared_examples/models/geo_batcher_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_framework_registry_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' - 'ee/spec/support/shared_examples/models/member_shared_examples.rb' - 'ee/spec/support/shared_examples/models/mentionable_shared_examples.rb' - 'ee/spec/support/shared_examples/models/protected_environments/authorizable_examples.rb' - 'ee/spec/support/shared_examples/quick_actions/issue/status_page_quick_actions_shared_examples.rb' - - 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/credentials_inventory_shared_examples.rb' - - 'ee/spec/support/shared_examples/requests/security/security_dashboard_json_endpoint_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_recovery_shared_examples.rb' - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/boards/base_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/merge_merge_requests_shared_examples.rb' @@ -1095,66 +953,56 @@ RSpec/ContextWording: - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - 'ee/spec/support/shared_examples/services/search_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/update_issuable_health_status_shared_examples.rb' - - 'ee/spec/support/shared_examples/views/registration_features_prompt_settings_link_shared_examples.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'ee/spec/tasks/gitlab/license_rake_spec.rb' - - 'ee/spec/tasks/gitlab/uploads/migrate_rake_spec.rb' - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' - 'ee/spec/views/admin/users/show.html.haml_spec.rb' - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' - 'ee/spec/views/groups/edit.html.haml_spec.rb' - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_new_dropdown.haml_spec.rb' + - 'ee/spec/views/layouts/header/_read_only_banner.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_admin.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_push_rules_link.html.haml_spec.rb' - 'ee/spec/views/profiles/preferences/show.html.haml_spec.rb' - 'ee/spec/views/projects/edit.html.haml_spec.rb' - - 'ee/spec/views/projects/issues/show.html.haml_spec.rb' - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/registrations/groups/new.html.haml_spec.rb' - - 'ee/spec/views/registrations/projects/new.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/search/_category.html.haml_spec.rb' - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' - 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/_expiry_date.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/gpg_keys/_gpg_key.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/project_access_tokens/_project_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/ssh_keys/_ssh_key.html.haml_spec.rb' - 'ee/spec/views/shared/issuable/_sidebar.html.haml_spec.rb' - - 'ee/spec/views/shared/labels/_create_label_help_text.html.haml_spec.rb' - - 'ee/spec/views/shared/promotions/_promotion_link_project.html.haml_spec.rb' - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/workers/active_user_count_threshold_worker_spec.rb' - 'ee/spec/workers/adjourned_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/admin_emails_worker_spec.rb' - - 'ee/spec/workers/analytics/code_review_metrics_worker_spec.rb' - 'ee/spec/workers/audit_events/audit_event_streaming_worker_spec.rb' - 'ee/spec/workers/ci/minutes/refresh_cached_data_worker_spec.rb' - 'ee/spec/workers/ci/minutes/update_project_and_namespace_usage_worker_spec.rb' - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb' - 'ee/spec/workers/ci/upstream_projects_subscriptions_cleanup_worker_spec.rb' - - 'ee/spec/workers/compliance_management/merge_requests/compliance_violations_worker_spec.rb' - 'ee/spec/workers/ee/repository_check/batch_worker_spec.rb' - 'ee/spec/workers/ee/repository_check/single_repository_worker_spec.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - 'ee/spec/workers/elastic_association_indexer_worker_spec.rb' - 'ee/spec/workers/elastic_index_bulk_cron_worker_spec.rb' - 'ee/spec/workers/elastic_indexing_control_worker_spec.rb' - - 'ee/spec/workers/geo/create_repository_updated_event_worker_spec.rb' - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' - 'ee/spec/workers/geo/repository_sync_worker_spec.rb' - 'ee/spec/workers/geo/repository_verification/primary/shard_worker_spec.rb' - 'ee/spec/workers/geo/repository_verification/secondary/shard_worker_spec.rb' - 'ee/spec/workers/geo/verification_timeout_worker_spec.rb' + - 'ee/spec/workers/group_saml_group_sync_worker_spec.rb' - 'ee/spec/workers/incident_management/apply_incident_sla_exceeded_label_worker_spec.rb' - 'ee/spec/workers/incident_management/oncall_rotations/persist_shifts_job_spec.rb' - - 'ee/spec/workers/iterations/cadences/schedule_create_iterations_worker_spec.rb' - - 'ee/spec/workers/iterations_update_status_worker_spec.rb' - 'ee/spec/workers/merge_request_reset_approvals_worker_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/personal_access_tokens/groups/policy_worker_spec.rb' @@ -1163,12 +1011,8 @@ RSpec/ContextWording: - 'ee/spec/workers/project_import_schedule_worker_spec.rb' - 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb' - 'ee/spec/workers/security/track_secure_scans_worker_spec.rb' - - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/automatic_failover_and_recovery_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/backend_node_recovery_spec.rb' @@ -1179,19 +1023,16 @@ RSpec/ContextWording: - 'qa/qa/specs/features/api/3_create/gitaly/praefect_replication_queue_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/praefect_repo_sync_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/milestone/assign_milestone_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/add_design_content_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/archive_design_content_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/modify_design_content_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/batch_suggestion_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/custom_commit_suggestion_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/file/create_file_via_web_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/file/delete_file_via_web_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/file/edit_file_via_web_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/server_hooks_custom_error_message_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/wiki/content_editor_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_content_creation_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_content_manipulation_spec.rb' @@ -1200,11 +1041,13 @@ RSpec/ContextWording: - 'qa/qa/specs/features/browser_ui/3_create/wiki/project_based_page_deletion_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/mr_event_rule_pipeline_spec.rb' + - 'qa/qa/specs/features/browser_ui/4_verify/testing/endpoint_coverage_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/7_configure/kubernetes/kubernetes_integration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_tier_group_namespace_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_spec.rb' @@ -1215,18 +1058,14 @@ RSpec/ContextWording: - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_ssh_push_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_2_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/insights/default_insights_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/epic/epics_management_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_root_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_subgroup_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/wiki/create_group_wiki_page_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' @@ -1235,7 +1074,6 @@ RSpec/ContextWording: - 'qa/spec/service/docker_run/gitlab_runner_spec.rb' - 'qa/spec/service/docker_run/k3s_spec.rb' - 'qa/spec/specs/helpers/context_selector_spec.rb' - - 'qa/spec/specs/helpers/feature_flag_spec.rb' - 'qa/spec/specs/helpers/quarantine_spec.rb' - 'qa/spec/specs/runner_spec.rb' - 'qa/spec/support/loglinking_spec.rb' @@ -1245,29 +1083,26 @@ RSpec/ContextWording: - 'spec/commands/sidekiq_cluster/cli_spec.rb' - 'spec/components/diffs/overflow_warning_component_spec.rb' - 'spec/components/pajamas/alert_component_spec.rb' + - 'spec/components/pajamas/banner_component_spec.rb' + - 'spec/components/pajamas/button_component_spec.rb' + - 'spec/components/pajamas/card_component_spec.rb' + - 'spec/components/pajamas/spinner_component_spec.rb' - 'spec/config/object_store_settings_spec.rb' - 'spec/controllers/admin/application_settings_controller_spec.rb' - - 'spec/controllers/admin/clusters_controller_spec.rb' - - 'spec/controllers/admin/dev_ops_report_controller_spec.rb' - - 'spec/controllers/admin/impersonations_controller_spec.rb' - 'spec/controllers/admin/instance_review_controller_spec.rb' - 'spec/controllers/admin/integrations_controller_spec.rb' - 'spec/controllers/admin/runner_projects_controller_spec.rb' - 'spec/controllers/admin/sessions_controller_spec.rb' - - 'spec/controllers/admin/topics_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - - 'spec/controllers/boards/issues_controller_spec.rb' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/controllers/concerns/enforces_admin_authentication_spec.rb' - - 'spec/controllers/concerns/graceful_timeout_handling_spec.rb' - 'spec/controllers/concerns/group_tree_spec.rb' - 'spec/controllers/concerns/import_url_params_spec.rb' - 'spec/controllers/concerns/issuable_collections_spec.rb' - 'spec/controllers/concerns/metrics_dashboard_spec.rb' - 'spec/controllers/concerns/renders_commits_spec.rb' - - 'spec/controllers/concerns/send_file_upload_spec.rb' - 'spec/controllers/confirmations_controller_spec.rb' - 'spec/controllers/dashboard/milestones_controller_spec.rb' - 'spec/controllers/dashboard/projects_controller_spec.rb' @@ -1290,7 +1125,6 @@ RSpec/ContextWording: - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - 'spec/controllers/groups/settings/integrations_controller_spec.rb' - 'spec/controllers/groups/settings/repository_controller_spec.rb' - - 'spec/controllers/groups/uploads_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/help_controller_spec.rb' - 'spec/controllers/import/bitbucket_controller_spec.rb' @@ -1308,8 +1142,7 @@ RSpec/ContextWording: - 'spec/controllers/passwords_controller_spec.rb' - 'spec/controllers/profiles/emails_controller_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' - - 'spec/controllers/profiles/preferences_controller_spec.rb' - - 'spec/controllers/profiles/two_factor_auths_controller_spec.rb' + - 'spec/controllers/profiles/personal_access_tokens_controller_spec.rb' - 'spec/controllers/projects/alerting/notifications_controller_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/badges_controller_spec.rb' @@ -1328,11 +1161,9 @@ RSpec/ContextWording: - 'spec/controllers/projects/discussions_controller_spec.rb' - 'spec/controllers/projects/environments_controller_spec.rb' - 'spec/controllers/projects/feature_flags_clients_controller_spec.rb' - - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/find_file_controller_spec.rb' - 'spec/controllers/projects/forks_controller_spec.rb' - 'spec/controllers/projects/import/jira_controller_spec.rb' - - 'spec/controllers/projects/incidents_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/labels_controller_spec.rb' @@ -1358,7 +1189,6 @@ RSpec/ContextWording: - 'spec/controllers/projects/prometheus/metrics_controller_spec.rb' - 'spec/controllers/projects/raw_controller_spec.rb' - 'spec/controllers/projects/releases_controller_spec.rb' - - 'spec/controllers/projects/repositories_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects/settings/operations_controller_spec.rb' - 'spec/controllers/projects/settings/repository_controller_spec.rb' @@ -1367,44 +1197,36 @@ RSpec/ContextWording: - 'spec/controllers/projects/tags_controller_spec.rb' - 'spec/controllers/projects/todos_controller_spec.rb' - 'spec/controllers/projects/tree_controller_spec.rb' - - 'spec/controllers/projects/uploads_controller_spec.rb' - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/controllers/registrations/welcome_controller_spec.rb' - 'spec/controllers/registrations_controller_spec.rb' - - 'spec/controllers/repositories/git_http_controller_spec.rb' - 'spec/controllers/root_controller_spec.rb' - 'spec/controllers/search_controller_spec.rb' - - 'spec/controllers/sent_notifications_controller_spec.rb' - 'spec/controllers/sessions_controller_spec.rb' - 'spec/controllers/snippets/notes_controller_spec.rb' - 'spec/controllers/snippets_controller_spec.rb' - 'spec/controllers/uploads_controller_spec.rb' - 'spec/controllers/users/terms_controller_spec.rb' - - 'spec/db/docs_spec.rb' - 'spec/db/production/settings_spec.rb' - 'spec/db/schema_spec.rb' - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' - 'spec/experiments/application_experiment_spec.rb' - 'spec/experiments/ios_specific_templates_experiment_spec.rb' - - 'spec/features/admin/admin_abuse_reports_spec.rb' - 'spec/features/admin/admin_appearance_spec.rb' - 'spec/features/admin/admin_disables_git_access_protocol_spec.rb' + - 'spec/features/admin/admin_hook_logs_spec.rb' - 'spec/features/admin/admin_hooks_spec.rb' - 'spec/features/admin/admin_jobs_spec.rb' - 'spec/features/admin/admin_mode/login_spec.rb' - - 'spec/features/admin/admin_mode/logout_spec.rb' - - 'spec/features/admin/admin_mode/workers_spec.rb' - 'spec/features/admin/admin_mode_spec.rb' - - 'spec/features/admin/admin_search_settings_spec.rb' - 'spec/features/admin/admin_settings_spec.rb' - 'spec/features/admin/dashboard_spec.rb' - 'spec/features/admin/users/user_spec.rb' - 'spec/features/admin/users/users_spec.rb' - 'spec/features/atom/dashboard_issues_spec.rb' - 'spec/features/atom/dashboard_spec.rb' - - 'spec/features/atom/issues_spec.rb' - 'spec/features/atom/merge_requests_spec.rb' - 'spec/features/atom/users_spec.rb' - 'spec/features/boards/boards_spec.rb' @@ -1417,12 +1239,9 @@ RSpec/ContextWording: - 'spec/features/boards/sidebar_labels_spec.rb' - 'spec/features/boards/user_visits_board_spec.rb' - 'spec/features/calendar_spec.rb' - - 'spec/features/clusters/cluster_detail_page_spec.rb' - 'spec/features/clusters/cluster_health_dashboard_spec.rb' - 'spec/features/commits_spec.rb' - - 'spec/features/cycle_analytics_spec.rb' - 'spec/features/dashboard/activity_spec.rb' - - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' - 'spec/features/dashboard/groups_list_spec.rb' - 'spec/features/dashboard/issues_filter_spec.rb' - 'spec/features/dashboard/label_filter_spec.rb' @@ -1436,7 +1255,6 @@ RSpec/ContextWording: - 'spec/features/dashboard/user_filters_projects_spec.rb' - 'spec/features/expand_collapse_diffs_spec.rb' - 'spec/features/file_uploads/multipart_invalid_uploads_spec.rb' - - 'spec/features/frequently_visited_projects_and_groups_spec.rb' - 'spec/features/groups/board_sidebar_spec.rb' - 'spec/features/groups/board_spec.rb' - 'spec/features/groups/clusters/user_spec.rb' @@ -1450,11 +1268,8 @@ RSpec/ContextWording: - 'spec/features/groups/merge_requests_spec.rb' - 'spec/features/groups/milestone_spec.rb' - 'spec/features/groups/packages_spec.rb' - - 'spec/features/groups/settings/ci_cd_spec.rb' - 'spec/features/groups/settings/group_badges_spec.rb' - - 'spec/features/groups/settings/packages_and_registries_spec.rb' - 'spec/features/groups/settings/repository_spec.rb' - - 'spec/features/groups/settings/user_searches_in_settings_spec.rb' - 'spec/features/groups/share_lock_spec.rb' - 'spec/features/groups/show_spec.rb' - 'spec/features/groups/user_sees_package_sidebar_spec.rb' @@ -1492,8 +1307,6 @@ RSpec/ContextWording: - 'spec/features/issues/user_creates_issue_spec.rb' - 'spec/features/issues/user_edits_issue_spec.rb' - 'spec/features/issues/user_interacts_with_awards_spec.rb' - - 'spec/features/issues/user_scrolls_to_deeplinked_note_spec.rb' - - 'spec/features/issues/user_sorts_issue_comments_spec.rb' - 'spec/features/issues/user_toggles_subscription_spec.rb' - 'spec/features/issues/user_uses_quick_actions_spec.rb' - 'spec/features/issues/user_views_issues_spec.rb' @@ -1504,14 +1317,15 @@ RSpec/ContextWording: - 'spec/features/markdown/metrics_spec.rb' - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/close_reopen_report_toggle_spec.rb' + - 'spec/features/merge_request/merge_request_discussion_lock_spec.rb' - 'spec/features/merge_request/user_accepts_merge_request_spec.rb' - 'spec/features/merge_request/user_assigns_themselves_spec.rb' - - 'spec/features/merge_request/user_comments_on_diff_spec.rb' - 'spec/features/merge_request/user_creates_image_diff_notes_spec.rb' - 'spec/features/merge_request/user_creates_merge_request_spec.rb' - 'spec/features/merge_request/user_creates_mr_spec.rb' - 'spec/features/merge_request/user_edits_mr_spec.rb' - 'spec/features/merge_request/user_interacts_with_batched_mr_diffs_spec.rb' + - 'spec/features/merge_request/user_manages_subscription_spec.rb' - 'spec/features/merge_request/user_merges_merge_request_spec.rb' - 'spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb' - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb' @@ -1522,15 +1336,11 @@ RSpec/ContextWording: - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/merge_request/user_sees_cherry_pick_modal_spec.rb' - 'spec/features/merge_request/user_sees_closing_issues_message_spec.rb' - - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb' - - 'spec/features/merge_request/user_sees_diff_spec.rb' - 'spec/features/merge_request/user_sees_discussions_spec.rb' - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' - - 'spec/features/merge_request/user_sees_mini_pipeline_graph_spec.rb' - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' - 'spec/features/merge_request/user_uses_quick_actions_spec.rb' - 'spec/features/merge_request/user_views_open_merge_request_spec.rb' - - 'spec/features/merge_request/user_views_user_status_on_merge_request_spec.rb' - 'spec/features/merge_requests/filters_generic_behavior_spec.rb' - 'spec/features/merge_requests/user_exports_as_csv_spec.rb' - 'spec/features/merge_requests/user_filters_by_approvals_spec.rb' @@ -1539,7 +1349,6 @@ RSpec/ContextWording: - 'spec/features/merge_requests/user_filters_by_target_branch_spec.rb' - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' - 'spec/features/merge_requests/user_mass_updates_spec.rb' - - 'spec/features/merge_requests/user_sees_empty_state_spec.rb' - 'spec/features/milestones/user_views_milestone_spec.rb' - 'spec/features/monitor_sidebar_link_spec.rb' - 'spec/features/nav/top_nav_responsive_spec.rb' @@ -1550,7 +1359,6 @@ RSpec/ContextWording: - 'spec/features/profiles/keys_spec.rb' - 'spec/features/profiles/password_spec.rb' - 'spec/features/profiles/user_edit_profile_spec.rb' - - 'spec/features/profiles/user_search_settings_spec.rb' - 'spec/features/projects/active_tabs_spec.rb' - 'spec/features/projects/activity/user_sees_design_activity_spec.rb' - 'spec/features/projects/artifacts/file_spec.rb' @@ -1565,6 +1373,7 @@ RSpec/ContextWording: - 'spec/features/projects/commits/multi_view_diff_spec.rb' - 'spec/features/projects/commits/user_browses_commits_spec.rb' - 'spec/features/projects/compare_spec.rb' + - 'spec/features/projects/deploy_keys_spec.rb' - 'spec/features/projects/diffs/diff_show_spec.rb' - 'spec/features/projects/environments/environment_spec.rb' - 'spec/features/projects/environments/environments_spec.rb' @@ -1575,6 +1384,7 @@ RSpec/ContextWording: - 'spec/features/projects/files/user_creates_directory_spec.rb' - 'spec/features/projects/fork_spec.rb' - 'spec/features/projects/graph_spec.rb' + - 'spec/features/projects/hook_logs/user_reads_log_spec.rb' - 'spec/features/projects/import_export/export_file_spec.rb' - 'spec/features/projects/infrastructure_registry_spec.rb' - 'spec/features/projects/integrations/disable_triggers_spec.rb' @@ -1582,15 +1392,12 @@ RSpec/ContextWording: - 'spec/features/projects/issuable_templates_spec.rb' - 'spec/features/projects/issues/design_management/user_links_to_designs_in_issue_spec.rb' - 'spec/features/projects/issues/design_management/user_views_designs_spec.rb' - - 'spec/features/projects/issues/email_participants_spec.rb' + - 'spec/features/projects/jobs/user_browses_job_spec.rb' - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/labels/search_labels_spec.rb' - - 'spec/features/projects/labels/update_prioritization_spec.rb' - - 'spec/features/projects/labels/user_creates_labels_spec.rb' - 'spec/features/projects/members/group_members_spec.rb' - 'spec/features/projects/members/groups_with_access_list_spec.rb' - - 'spec/features/projects/members/manage_groups_spec.rb' - 'spec/features/projects/members/manage_members_spec.rb' - 'spec/features/projects/members/tabs_spec.rb' - 'spec/features/projects/members/user_requests_access_spec.rb' @@ -1601,21 +1408,20 @@ RSpec/ContextWording: - 'spec/features/projects/packages_spec.rb' - 'spec/features/projects/pages/user_edits_settings_spec.rb' - 'spec/features/projects/pipeline_schedules_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/pipelines/pipelines_spec.rb' - 'spec/features/projects/releases/user_views_releases_spec.rb' + - 'spec/features/projects/settings/branch_rules_settings_spec.rb' - 'spec/features/projects/settings/lfs_settings_spec.rb' - 'spec/features/projects/settings/packages_settings_spec.rb' - - 'spec/features/projects/settings/pipelines_settings_spec.rb' - 'spec/features/projects/settings/project_badges_spec.rb' - 'spec/features/projects/settings/project_settings_spec.rb' - - 'spec/features/projects/settings/registry_settings_spec.rb' - 'spec/features/projects/settings/repository_settings_spec.rb' + - 'spec/features/projects/settings/secure_files_spec.rb' - 'spec/features/projects/settings/service_desk_setting_spec.rb' - 'spec/features/projects/settings/user_interacts_with_deploy_keys_spec.rb' - - 'spec/features/projects/settings/user_renames_a_project_spec.rb' - - 'spec/features/projects/settings/user_searches_in_settings_spec.rb' - - 'spec/features/projects/settings/user_transfers_a_project_spec.rb' - 'spec/features/projects/settings/visibility_settings_spec.rb' - 'spec/features/projects/settings/webhooks_settings_spec.rb' - 'spec/features/projects/show/user_manages_notifications_spec.rb' @@ -1625,34 +1431,25 @@ RSpec/ContextWording: - 'spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb' - 'spec/features/projects/snippets/user_views_snippets_spec.rb' - 'spec/features/projects/sourcegraph_csp_spec.rb' - - 'spec/features/projects/tags/user_edits_tags_spec.rb' - 'spec/features/projects/tags/user_views_tags_spec.rb' - 'spec/features/projects/tree/tree_show_spec.rb' - - 'spec/features/projects/user_creates_project_spec.rb' - - 'spec/features/projects/user_sees_sidebar_spec.rb' - 'spec/features/projects/user_sorts_projects_spec.rb' - 'spec/features/projects/user_uses_shortcuts_spec.rb' - - 'spec/features/projects/view_on_env_spec.rb' - - 'spec/features/projects/wiki/user_views_wiki_empty_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/protected_branches_spec.rb' - 'spec/features/reportable_note/commit_spec.rb' - 'spec/features/reportable_note/merge_request_spec.rb' - 'spec/features/runners_spec.rb' - 'spec/features/search/user_searches_for_code_spec.rb' - - 'spec/features/search/user_uses_header_search_field_spec.rb' - - 'spec/features/security/project/snippet/internal_access_spec.rb' - - 'spec/features/security/project/snippet/public_access_spec.rb' - 'spec/features/signed_commits_spec.rb' - 'spec/features/snippets/explore_spec.rb' - 'spec/features/tags/developer_creates_tag_spec.rb' - 'spec/features/tags/developer_deletes_tag_spec.rb' - - 'spec/features/tags/developer_updates_tag_spec.rb' + - 'spec/features/tags/maintainer_deletes_protected_tag_spec.rb' - 'spec/features/uploads/user_uploads_file_to_note_spec.rb' - 'spec/features/user_can_display_performance_bar_spec.rb' - 'spec/features/user_opens_link_to_comment_spec.rb' - 'spec/features/users/login_spec.rb' - - 'spec/features/users/logout_spec.rb' - 'spec/features/users/overview_spec.rb' - 'spec/features/users/show_spec.rb' - 'spec/features/users/snippets_spec.rb' @@ -1664,14 +1461,12 @@ RSpec/ContextWording: - 'spec/finders/applications_finder_spec.rb' - 'spec/finders/autocomplete/acts_as_taggable_on/tags_finder_spec.rb' - 'spec/finders/autocomplete/move_to_project_finder_spec.rb' - - 'spec/finders/autocomplete/routes_finder_spec.rb' - 'spec/finders/autocomplete/users_finder_spec.rb' - 'spec/finders/branches_finder_spec.rb' - 'spec/finders/ci/commit_statuses_finder_spec.rb' - 'spec/finders/ci/jobs_finder_spec.rb' - 'spec/finders/ci/pipelines_finder_spec.rb' - 'spec/finders/ci/runners_finder_spec.rb' - - 'spec/finders/ci/variables_finder_spec.rb' - 'spec/finders/cluster_ancestors_finder_spec.rb' - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' - 'spec/finders/clusters/agents_finder_spec.rb' @@ -1679,7 +1474,6 @@ RSpec/ContextWording: - 'spec/finders/contributed_projects_finder_spec.rb' - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' - 'spec/finders/deployments_finder_spec.rb' - - 'spec/finders/design_management/designs_finder_spec.rb' - 'spec/finders/environments/environment_names_finder_spec.rb' - 'spec/finders/environments/environments_by_deployments_finder_spec.rb' - 'spec/finders/environments/environments_finder_spec.rb' @@ -1690,7 +1484,6 @@ RSpec/ContextWording: - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_transfer_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - - 'spec/finders/issues_finder_spec.rb' - 'spec/finders/joined_groups_finder_spec.rb' - 'spec/finders/keys_finder_spec.rb' - 'spec/finders/labels_finder_spec.rb' @@ -1703,8 +1496,6 @@ RSpec/ContextWording: - 'spec/finders/metrics/users_starred_dashboards_finder_spec.rb' - 'spec/finders/milestones_finder_spec.rb' - 'spec/finders/notes_finder_spec.rb' - - 'spec/finders/packages/conan/package_finder_spec.rb' - - 'spec/finders/packages/go/version_finder_spec.rb' - 'spec/finders/packages/group_packages_finder_spec.rb' - 'spec/finders/packages/helm/packages_finder_spec.rb' - 'spec/finders/packages/maven/package_finder_spec.rb' @@ -1738,7 +1529,6 @@ RSpec/ContextWording: - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - 'spec/graphql/features/feature_flag_spec.rb' - - 'spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb' - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' - 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb' - 'spec/graphql/mutations/alert_management/http_integration/destroy_spec.rb' @@ -1748,14 +1538,12 @@ RSpec/ContextWording: - 'spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb' - 'spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb' - 'spec/graphql/mutations/alert_management/update_alert_status_spec.rb' - - 'spec/graphql/mutations/boards/lists/update_spec.rb' - 'spec/graphql/mutations/clusters/agent_tokens/revoke_spec.rb' - 'spec/graphql/mutations/clusters/agents/create_spec.rb' - 'spec/graphql/mutations/custom_emoji/destroy_spec.rb' - 'spec/graphql/mutations/design_management/delete_spec.rb' - 'spec/graphql/mutations/design_management/move_spec.rb' - 'spec/graphql/mutations/groups/update_spec.rb' - - 'spec/graphql/mutations/issues/set_severity_spec.rb' - 'spec/graphql/mutations/merge_requests/update_spec.rb' - 'spec/graphql/mutations/release_asset_links/update_spec.rb' - 'spec/graphql/mutations/releases/delete_spec.rb' @@ -1780,7 +1568,6 @@ RSpec/ContextWording: - 'spec/graphql/resolvers/design_management/design_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/designs_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/version/design_at_version_resolver_spec.rb' - - 'spec/graphql/resolvers/design_management/version/designs_at_version_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/version_in_collection_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/version_resolver_spec.rb' - 'spec/graphql/resolvers/design_management/versions_resolver_spec.rb' @@ -1793,7 +1580,6 @@ RSpec/ContextWording: - 'spec/graphql/resolvers/kas/agent_configurations_resolver_spec.rb' - 'spec/graphql/resolvers/kas/agent_connections_resolver_spec.rb' - 'spec/graphql/resolvers/last_commit_resolver_spec.rb' - - 'spec/graphql/resolvers/metrics/dashboard_resolver_spec.rb' - 'spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb' - 'spec/graphql/resolvers/namespace_projects_resolver_spec.rb' - 'spec/graphql/resolvers/project_merge_requests_resolver_spec.rb' @@ -1802,16 +1588,13 @@ RSpec/ContextWording: - 'spec/graphql/resolvers/snippets/blobs_resolver_spec.rb' - 'spec/graphql/resolvers/snippets_resolver_spec.rb' - 'spec/graphql/resolvers/terraform/states_resolver_spec.rb' - - 'spec/graphql/resolvers/timelog_resolver_spec.rb' - 'spec/graphql/resolvers/user_resolver_spec.rb' - 'spec/graphql/resolvers/users/group_count_resolver_spec.rb' - 'spec/graphql/resolvers/users/participants_resolver_spec.rb' - 'spec/graphql/subscriptions/issuable_updated_spec.rb' - 'spec/graphql/types/base_field_spec.rb' - 'spec/graphql/types/global_id_type_spec.rb' - - 'spec/graphql/types/invitation_interface_spec.rb' - 'spec/graphql/types/issue_type_spec.rb' - - 'spec/graphql/types/member_interface_spec.rb' - 'spec/graphql/types/range_input_type_spec.rb' - 'spec/graphql/types/release_links_type_spec.rb' - 'spec/graphql/types/user_type_spec.rb' @@ -1826,13 +1609,12 @@ RSpec/ContextWording: - 'spec/helpers/award_emoji_helper_spec.rb' - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/boards_helper_spec.rb' - - 'spec/helpers/ci/runners_helper_spec.rb' + - 'spec/helpers/ci/secure_files_helper_spec.rb' - 'spec/helpers/clusters_helper_spec.rb' - 'spec/helpers/colors_helper_spec.rb' - 'spec/helpers/commits_helper_spec.rb' - 'spec/helpers/diff_helper_spec.rb' - 'spec/helpers/emails_helper_spec.rb' - - 'spec/helpers/environment_helper_spec.rb' - 'spec/helpers/environments_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/git_helper_spec.rb' @@ -1842,7 +1624,6 @@ RSpec/ContextWording: - 'spec/helpers/ide_helper_spec.rb' - 'spec/helpers/integrations_helper_spec.rb' - 'spec/helpers/invite_members_helper_spec.rb' - - 'spec/helpers/issues_helper_spec.rb' - 'spec/helpers/jira_connect_helper_spec.rb' - 'spec/helpers/labels_helper_spec.rb' - 'spec/helpers/listbox_helper_spec.rb' @@ -1853,34 +1634,32 @@ RSpec/ContextWording: - 'spec/helpers/notes_helper_spec.rb' - 'spec/helpers/operations_helper_spec.rb' - 'spec/helpers/projects/cluster_agents_helper_spec.rb' + - 'spec/helpers/projects/project_members_helper_spec.rb' - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/releases_helper_spec.rb' - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - - 'spec/helpers/snippets_helper_spec.rb' - 'spec/helpers/sorting_helper_spec.rb' - 'spec/helpers/storage_helper_spec.rb' - 'spec/helpers/submodule_helper_spec.rb' - 'spec/helpers/timeboxes_helper_spec.rb' - - 'spec/helpers/timeboxes_routing_helper_spec.rb' - 'spec/helpers/todos_helper_spec.rb' - 'spec/helpers/tree_helper_spec.rb' - - 'spec/helpers/users/group_callouts_helper_spec.rb' + - 'spec/helpers/users/callouts_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - 'spec/helpers/visibility_level_helper_spec.rb' + - 'spec/helpers/web_hooks/web_hooks_helper_spec.rb' - 'spec/helpers/whats_new_helper_spec.rb' - 'spec/helpers/wiki_helper_spec.rb' - 'spec/initializers/00_rails_disable_joins_spec.rb' - - 'spec/initializers/0_log_deprecations_spec.rb' + - 'spec/initializers/1_acts_as_taggable_spec.rb' - 'spec/initializers/carrierwave_patch_spec.rb' - - 'spec/initializers/lograge_spec.rb' + - 'spec/initializers/enumerator_next_patch_spec.rb' - 'spec/initializers/mail_encoding_patch_spec.rb' - - 'spec/initializers/net_http_patch_spec.rb' - 'spec/initializers/rack_multipart_patch_spec.rb' - 'spec/initializers/secret_token_spec.rb' - 'spec/initializers/settings_spec.rb' - 'spec/initializers/validate_database_config_spec.rb' - - 'spec/initializers/validate_puma_spec.rb' - 'spec/lib/api/entities/application_setting_spec.rb' - 'spec/lib/api/entities/basic_project_details_spec.rb' - 'spec/lib/api/entities/clusters/agent_authorization_spec.rb' @@ -1911,14 +1690,12 @@ RSpec/ContextWording: - 'spec/lib/atlassian/jira_connect/serializers/deployment_entity_spec.rb' - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - 'spec/lib/atlassian/jira_connect_spec.rb' - - 'spec/lib/backup/files_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/backup/repositories_spec.rb' - 'spec/lib/banzai/color_parser_spec.rb' - 'spec/lib/banzai/filter/absolute_link_filter_spec.rb' - 'spec/lib/banzai/filter/asset_proxy_filter_spec.rb' - - 'spec/lib/banzai/filter/audio_link_filter_spec.rb' - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_placeholders_filter_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb' @@ -1927,7 +1704,6 @@ RSpec/ContextWording: - 'spec/lib/banzai/filter/front_matter_filter_spec.rb' - 'spec/lib/banzai/filter/gollum_tags_filter_spec.rb' - 'spec/lib/banzai/filter/inline_metrics_redactor_filter_spec.rb' - - 'spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb' - 'spec/lib/banzai/filter/markdown_filter_spec.rb' - 'spec/lib/banzai/filter/reference_redactor_filter_spec.rb' - 'spec/lib/banzai/filter/references/abstract_reference_filter_spec.rb' @@ -1949,12 +1725,10 @@ RSpec/ContextWording: - 'spec/lib/banzai/filter/table_of_contents_filter_spec.rb' - 'spec/lib/banzai/filter/table_of_contents_tag_filter_spec.rb' - 'spec/lib/banzai/filter/upload_link_filter_spec.rb' - - 'spec/lib/banzai/filter/video_link_filter_spec.rb' - 'spec/lib/banzai/filter/wiki_link_filter_spec.rb' - 'spec/lib/banzai/pipeline/broadcast_message_pipeline_spec.rb' - 'spec/lib/banzai/pipeline_spec.rb' - 'spec/lib/banzai/reference_parser/alert_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - 'spec/lib/banzai/reference_parser/commit_range_parser_spec.rb' - 'spec/lib/banzai/reference_parser/design_parser_spec.rb' - 'spec/lib/banzai/reference_parser/feature_flag_parser_spec.rb' @@ -1984,7 +1758,6 @@ RSpec/ContextWording: - 'spec/lib/constraints/group_url_constrainer_spec.rb' - 'spec/lib/constraints/project_url_constrainer_spec.rb' - 'spec/lib/constraints/user_url_constrainer_spec.rb' - - 'spec/lib/container_registry/blob_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/container_registry/migration_spec.rb' - 'spec/lib/container_registry/registry_spec.rb' @@ -1999,11 +1772,7 @@ RSpec/ContextWording: - 'spec/lib/feature/definition_spec.rb' - 'spec/lib/feature_spec.rb' - 'spec/lib/generators/gitlab/snowplow_event_definition_generator_spec.rb' - - 'spec/lib/generators/gitlab/usage_metric_generator_spec.rb' - - 'spec/lib/gitlab/alert_management/alert_status_counts_spec.rb' - 'spec/lib/gitlab/alert_management/fingerprint_spec.rb' - - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' - - 'spec/lib/gitlab/alert_management/payload_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/average_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/sorting_spec.rb' @@ -2011,19 +1780,13 @@ RSpec/ContextWording: - 'spec/lib/gitlab/asciidoc_spec.rb' - 'spec/lib/gitlab/asset_proxy_spec.rb' - 'spec/lib/gitlab/auth/atlassian/identity_linker_spec.rb' - - 'spec/lib/gitlab/auth/atlassian/user_spec.rb' - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - 'spec/lib/gitlab/auth/current_user_mode_spec.rb' - - 'spec/lib/gitlab/auth/key_status_checker_spec.rb' - - 'spec/lib/gitlab/auth/ldap/access_spec.rb' - 'spec/lib/gitlab/auth/ldap/adapter_spec.rb' - - 'spec/lib/gitlab/auth/ldap/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/ldap/dn_spec.rb' - - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - 'spec/lib/gitlab/auth/o_auth/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/o_auth/identity_linker_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/provider_spec.rb' - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/forti_authenticator/push_otp_spec.rb' @@ -2038,16 +1801,12 @@ RSpec/ContextWording: - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_with_corrected_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/bare_repository_import/repository_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' @@ -2056,17 +1815,14 @@ RSpec/ContextWording: - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' - 'spec/lib/gitlab/cache/helpers_spec.rb' - 'spec/lib/gitlab/chat/responder_spec.rb' - - 'spec/lib/gitlab/chat_name_token_spec.rb' - 'spec/lib/gitlab/checks/branch_check_spec.rb' - 'spec/lib/gitlab/checks/lfs_integrity_spec.rb' - - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' - 'spec/lib/gitlab/checks/push_file_count_check_spec.rb' - 'spec/lib/gitlab/checks/snippet_check_spec.rb' - 'spec/lib/gitlab/checks/tag_check_spec.rb' - 'spec/lib/gitlab/ci/ansi2html_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/style_spec.rb' - 'spec/lib/gitlab/ci/ansi2json_spec.rb' - - 'spec/lib/gitlab/ci/badge/coverage/report_spec.rb' - 'spec/lib/gitlab/ci/badge/pipeline/status_spec.rb' - 'spec/lib/gitlab/ci/badge/release/template_spec.rb' - 'spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb' @@ -2074,13 +1830,13 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/build/prerequisite/factory_spec.rb' - 'spec/lib/gitlab/ci/build/prerequisite/kubernetes_namespace_spec.rb' - 'spec/lib/gitlab/ci/build/releaser_spec.rb' + - 'spec/lib/gitlab/ci/build/rules/rule/clause/changes_spec.rb' - 'spec/lib/gitlab/ci/build/rules/rule/clause/exists_spec.rb' - 'spec/lib/gitlab/ci/build/rules_spec.rb' - 'spec/lib/gitlab/ci/charts_spec.rb' - 'spec/lib/gitlab/ci/config/entry/default_spec.rb' - 'spec/lib/gitlab/ci/config/entry/environment_spec.rb' - 'spec/lib/gitlab/ci/config/entry/include/rules/rule_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/include_spec.rb' - 'spec/lib/gitlab/ci/config/entry/inherit/default_spec.rb' - 'spec/lib/gitlab/ci/config/entry/inherit/variables_spec.rb' - 'spec/lib/gitlab/ci/config/entry/job_spec.rb' @@ -2089,8 +1845,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/config/entry/port_spec.rb' - 'spec/lib/gitlab/ci/config/entry/ports_spec.rb' - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/release_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/reports_spec.rb' - 'spec/lib/gitlab/ci/config/entry/retry_spec.rb' - 'spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb' - 'spec/lib/gitlab/ci/config/entry/trigger/forward_spec.rb' @@ -2100,9 +1854,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/jwt_spec.rb' - 'spec/lib/gitlab/ci/lint_spec.rb' - 'spec/lib/gitlab/ci/matching/runner_matcher_spec.rb' - - 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/create_spec.rb' @@ -2113,27 +1865,23 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/pipeline/expression/parser_spec.rb' - 'spec/lib/gitlab/ci/pipeline/quota/deployments_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb' - 'spec/lib/gitlab/ci/pipeline_object_hierarchy_spec.rb' - 'spec/lib/gitlab/ci/reports/reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/security/aggregated_report_spec.rb' - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/test_suite_comparer_spec.rb' - 'spec/lib/gitlab/ci/runner_instructions_spec.rb' + - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb' - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' - 'spec/lib/gitlab/ci/status/composite_spec.rb' - 'spec/lib/gitlab/ci/status/factory_spec.rb' - - 'spec/lib/gitlab/ci/status/stage/play_manual_spec.rb' - 'spec/lib/gitlab/ci/templates/5_minute_production_app_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/Jobs/build_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/code_quality_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/Jobs/deploy_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_latest_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/test_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' - - 'spec/lib/gitlab/ci/templates/npm_spec.rb' - 'spec/lib/gitlab/ci/templates/templates_spec.rb' - 'spec/lib/gitlab/ci/templates/terraform_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/terraform_latest_gitlab_ci_yaml_spec.rb' @@ -2156,16 +1904,15 @@ RSpec/ContextWording: - 'spec/lib/gitlab/config/entry/composable_array_spec.rb' - 'spec/lib/gitlab/config/entry/composable_hash_spec.rb' - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' - - 'spec/lib/gitlab/console_spec.rb' - 'spec/lib/gitlab/consul/internal_spec.rb' - 'spec/lib/gitlab/content_security_policy/config_loader_spec.rb' - - 'spec/lib/gitlab/current_settings_spec.rb' - 'spec/lib/gitlab/cycle_analytics/permissions_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' - 'spec/lib/gitlab/data_builder/build_spec.rb' - 'spec/lib/gitlab/data_builder/issuable_spec.rb' - 'spec/lib/gitlab/data_builder/pipeline_spec.rb' - 'spec/lib/gitlab/database/background_migration/batch_optimizer_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - 'spec/lib/gitlab/database/batch_count_spec.rb' - 'spec/lib/gitlab/database/bulk_update_spec.rb' @@ -2173,7 +1920,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/database/count/tablesample_count_strategy_spec.rb' - 'spec/lib/gitlab/database/count_spec.rb' - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' @@ -2200,9 +1946,9 @@ RSpec/ContextWording: - 'spec/lib/gitlab/database/postgres_hll/batch_distinct_counter_spec.rb' - 'spec/lib/gitlab/database/query_analyzer_spec.rb' - 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_metrics_spec.rb' + - 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection_spec.rb' - 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb' - 'spec/lib/gitlab/database/query_analyzers/restrict_allowed_schemas_spec.rb' - - 'spec/lib/gitlab/database/reflection_spec.rb' - 'spec/lib/gitlab/database/reindexing/coordinator_spec.rb' - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' - 'spec/lib/gitlab/database/reindexing/reindex_action_spec.rb' @@ -2223,6 +1969,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/diff/lines_unfolder_spec.rb' - 'spec/lib/gitlab/diff/position_spec.rb' - 'spec/lib/gitlab/diff/position_tracer_spec.rb' + - 'spec/lib/gitlab/diff/rendered/notebook/diff_file_helper_spec.rb' - 'spec/lib/gitlab/diff/rendered/notebook/diff_file_spec.rb' - 'spec/lib/gitlab/diff/suggestions_parser_spec.rb' - 'spec/lib/gitlab/email/failure_handler_spec.rb' @@ -2234,18 +1981,17 @@ RSpec/ContextWording: - 'spec/lib/gitlab/email/handler_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/experience_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/team_short_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/team_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/trial_short_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/trial_spec.rb' - 'spec/lib/gitlab/email/message/repository_push_spec.rb' + - 'spec/lib/gitlab/email/reply_parser_spec.rb' - 'spec/lib/gitlab/encoding_helper_spec.rb' - 'spec/lib/gitlab/error_tracking/context_payload_generator_spec.rb' - 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb' - 'spec/lib/gitlab/error_tracking_spec.rb' - - 'spec/lib/gitlab/exceptions_app_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - 'spec/lib/gitlab/experimentation_spec.rb' @@ -2266,7 +2012,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/git/cross_repo_comparer_spec.rb' - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - - 'spec/lib/gitlab/git/keep_around_spec.rb' - 'spec/lib/gitlab/git/merge_base_spec.rb' - 'spec/lib/gitlab/git/raw_diff_change_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' @@ -2284,6 +2029,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/releases_importer_spec.rb' - 'spec/lib/gitlab/github_import/representation/diff_note_spec.rb' + - 'spec/lib/gitlab/github_import/representation/issue_event_spec.rb' - 'spec/lib/gitlab/github_import/representation/issue_spec.rb' - 'spec/lib/gitlab/github_import/representation/note_spec.rb' - 'spec/lib/gitlab/github_import/representation/pull_request_spec.rb' @@ -2296,18 +2042,16 @@ RSpec/ContextWording: - 'spec/lib/gitlab/graphql/loaders/issuable_loader_spec.rb' - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' - 'spec/lib/gitlab/graphql/pagination/externally_paginated_array_connection_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/order_info_spec.rb' - 'spec/lib/gitlab/graphql/queries_spec.rb' - 'spec/lib/gitlab/graphql_logger_spec.rb' + - 'spec/lib/gitlab/harbor/client_spec.rb' + - 'spec/lib/gitlab/harbor/query_spec.rb' - 'spec/lib/gitlab/health_checks/gitaly_check_spec.rb' - 'spec/lib/gitlab/health_checks/middleware_spec.rb' - - 'spec/lib/gitlab/health_checks/puma_check_spec.rb' - 'spec/lib/gitlab/health_checks/simple_check_shared.rb' - 'spec/lib/gitlab/highlight_spec.rb' - 'spec/lib/gitlab/hook_data/group_builder_spec.rb' - 'spec/lib/gitlab/hook_data/group_member_builder_spec.rb' - - 'spec/lib/gitlab/hook_data/issue_builder_spec.rb' - 'spec/lib/gitlab/hook_data/key_builder_spec.rb' - 'spec/lib/gitlab/hook_data/project_builder_spec.rb' - 'spec/lib/gitlab/hook_data/project_member_builder_spec.rb' @@ -2315,10 +2059,10 @@ RSpec/ContextWording: - 'spec/lib/gitlab/hook_data/user_builder_spec.rb' - 'spec/lib/gitlab/hotlinking_detector_spec.rb' - 'spec/lib/gitlab/http_spec.rb' - - 'spec/lib/gitlab/i18n/po_linter_spec.rb' - 'spec/lib/gitlab/import/merge_request_creator_spec.rb' - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' + - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' - 'spec/lib/gitlab/import_export/file_importer_spec.rb' - 'spec/lib/gitlab/import_export/group/legacy_tree_restorer_spec.rb' @@ -2345,9 +2089,10 @@ RSpec/ContextWording: - 'spec/lib/gitlab/incoming_email_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_base_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_cluster_validator_spec.rb' + - 'spec/lib/gitlab/instrumentation_helper_spec.rb' - 'spec/lib/gitlab/internal_post_receive/response_spec.rb' + - 'spec/lib/gitlab/issuable/clone/attributes_rewriter_spec.rb' - 'spec/lib/gitlab/issuable_metadata_spec.rb' - - 'spec/lib/gitlab/issuable_sorter_spec.rb' - 'spec/lib/gitlab/issuables_count_for_state_spec.rb' - 'spec/lib/gitlab/issues/rebalancing/state_spec.rb' - 'spec/lib/gitlab/jira/dvcs_spec.rb' @@ -2359,28 +2104,23 @@ RSpec/ContextWording: - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/lfs_token_spec.rb' - - 'spec/lib/gitlab/logger_spec.rb' - 'spec/lib/gitlab/lograge/custom_options_spec.rb' - 'spec/lib/gitlab/mail_room/authenticator_spec.rb' - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' - 'spec/lib/gitlab/manifest_import/manifest_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' + - 'spec/lib/gitlab/memory/reports_daemon_spec.rb' + - 'spec/lib/gitlab/memory/watchdog_spec.rb' - 'spec/lib/gitlab/merge_requests/commit_message_generator_spec.rb' - - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/cache_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/finder_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importer_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/stages/url_validator_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/transformers/yml/v1/prometheus_metrics_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/url_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator/errors_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator/post_schema_validator_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/validator_spec.rb' @@ -2388,7 +2128,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/metrics/method_call_spec.rb' - 'spec/lib/gitlab/metrics/methods_spec.rb' - 'spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb' - - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' - 'spec/lib/gitlab/metrics/samplers/threads_sampler_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/rack_attack_spec.rb' @@ -2396,9 +2135,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/middleware/basic_health_check_spec.rb' - 'spec/lib/gitlab/middleware/compressed_json_spec.rb' - 'spec/lib/gitlab/middleware/go_spec.rb' - - 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb' - 'spec/lib/gitlab/middleware/multipart_spec.rb' - - 'spec/lib/gitlab/middleware/rack_multipart_tempfile_factory_spec.rb' - 'spec/lib/gitlab/middleware/request_context_spec.rb' - 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb' - 'spec/lib/gitlab/namespaced_session_store_spec.rb' @@ -2410,22 +2147,18 @@ RSpec/ContextWording: - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' - 'spec/lib/gitlab/pagination/keyset/pager_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/paginator_spec.rb' - 'spec/lib/gitlab/pagination/keyset/simple_order_builder_spec.rb' - 'spec/lib/gitlab/pagination/offset_header_builder_spec.rb' - - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/performance_bar_spec.rb' - 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/process_supervisor_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/project_authorizations_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - 'spec/lib/gitlab/prometheus/adapter_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/additional_metrics_environment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' @@ -2438,7 +2171,8 @@ RSpec/ContextWording: - 'spec/lib/gitlab/rack_attack_spec.rb' - 'spec/lib/gitlab/reactive_cache_set_cache_spec.rb' - 'spec/lib/gitlab/redis/boolean_spec.rb' - - 'spec/lib/gitlab/redis/hll_spec.rb' + - 'spec/lib/gitlab/redis/duplicate_jobs_spec.rb' + - 'spec/lib/gitlab/regex_requires_app_spec.rb' - 'spec/lib/gitlab/regex_spec.rb' - 'spec/lib/gitlab/relative_positioning/item_context_spec.rb' - 'spec/lib/gitlab/relative_positioning/mover_spec.rb' @@ -2452,12 +2186,12 @@ RSpec/ContextWording: - 'spec/lib/gitlab/runtime_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/gitlab/sanitizers/svg_spec.rb' - - 'spec/lib/gitlab/search/params_spec.rb' - 'spec/lib/gitlab/search/sort_options_spec.rb' - 'spec/lib/gitlab/search_context/controller_concern_spec.rb' - 'spec/lib/gitlab/search_results_spec.rb' + - 'spec/lib/gitlab/service_desk_email_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/monitor_spec.rb' + - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/client_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/server_spec.rb' @@ -2467,12 +2201,12 @@ RSpec/ContextWording: - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/compressor_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/validator_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/worker_context/client_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb' - 'spec/lib/gitlab/sidekiq_signals_spec.rb' - 'spec/lib/gitlab/slash_commands/command_spec.rb' - - 'spec/lib/gitlab/slash_commands/deploy_spec.rb' - 'spec/lib/gitlab/slash_commands/issue_close_spec.rb' - 'spec/lib/gitlab/slash_commands/issue_new_spec.rb' - 'spec/lib/gitlab/slash_commands/issue_search_spec.rb' @@ -2480,9 +2214,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/slash_commands/presenters/issue_close_spec.rb' - 'spec/lib/gitlab/slash_commands/presenters/issue_show_spec.rb' - 'spec/lib/gitlab/slash_commands/run_spec.rb' - - 'spec/lib/gitlab/sourcegraph_spec.rb' - 'spec/lib/gitlab/spamcheck/client_spec.rb' - - 'spec/lib/gitlab/sql/pattern_spec.rb' - 'spec/lib/gitlab/ssh_public_key_spec.rb' - 'spec/lib/gitlab/submodule_links_spec.rb' - 'spec/lib/gitlab/subscription_portal_spec.rb' @@ -2493,30 +2225,26 @@ RSpec/ContextWording: - 'spec/lib/gitlab/tracking/incident_management_spec.rb' - 'spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'spec/lib/gitlab/tracking/standard_context_spec.rb' + - 'spec/lib/gitlab/tracking_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/gitlab/untrusted_regexp/ruby_syntax_spec.rb' - 'spec/lib/gitlab/untrusted_regexp_spec.rb' - 'spec/lib/gitlab/url_blocker_spec.rb' - - 'spec/lib/gitlab/url_builder_spec.rb' - 'spec/lib/gitlab/url_sanitizer_spec.rb' - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - 'spec/lib/gitlab/usage/metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/aggregate_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/count_users_creating_issues_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_hll_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/snowplow_configured_to_gitlab_collector_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/snowplow_enabled_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - 'spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb' - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' - 'spec/lib/gitlab/usage_data_counters/ci_template_unique_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/editor_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' + - 'spec/lib/gitlab/usage_data_counters/ipynb_diff_activity_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/quick_action_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/search_counter_spec.rb' @@ -2527,8 +2255,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' - 'spec/lib/gitlab/utils/usage_data_spec.rb' - 'spec/lib/gitlab/utils_spec.rb' - - 'spec/lib/gitlab/uuid_spec.rb' - - 'spec/lib/gitlab/version_info_spec.rb' - 'spec/lib/gitlab/view/presenter/base_spec.rb' - 'spec/lib/gitlab/visibility_level_checker_spec.rb' - 'spec/lib/gitlab/visibility_level_spec.rb' @@ -2545,14 +2271,11 @@ RSpec/ContextWording: - 'spec/lib/json_web_token/token_spec.rb' - 'spec/lib/kramdown/parser/atlassian_document_format_spec.rb' - 'spec/lib/mattermost/client_spec.rb' - - 'spec/lib/mattermost/command_spec.rb' - 'spec/lib/mattermost/session_spec.rb' - - 'spec/lib/mattermost/team_spec.rb' - 'spec/lib/object_storage/direct_upload_spec.rb' - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - 'spec/lib/peek/views/bullet_detailed_spec.rb' - 'spec/lib/product_analytics/event_params_spec.rb' - - 'spec/lib/prometheus/pid_provider_spec.rb' - 'spec/lib/safe_zip/entry_spec.rb' - 'spec/lib/security/ci_configuration/container_scanning_build_action_spec.rb' - 'spec/lib/security/ci_configuration/sast_build_action_spec.rb' @@ -2571,19 +2294,15 @@ RSpec/ContextWording: - 'spec/lib/system_check/orphans/repository_check_spec.rb' - 'spec/lib/uploaded_file_spec.rb' - 'spec/lib/version_check_spec.rb' + - 'spec/mailers/devise_mailer_spec.rb' - 'spec/mailers/emails/profile_spec.rb' - 'spec/mailers/emails/projects_spec.rb' - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/metrics_server/metrics_server_spec.rb' - 'spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb' - - 'spec/migrations/20220426185933_backfill_deployments_finished_at_spec.rb' - - 'spec/migrations/backfill_cadence_id_for_boards_scoped_to_iteration_spec.rb' - 'spec/migrations/finalize_traversal_ids_background_migrations_spec.rb' - - 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb' - 'spec/migrations/rename_services_to_integrations_spec.rb' - - 'spec/migrations/schedule_security_setting_creation_spec.rb' - 'spec/models/ability_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/alert_management/alert_spec.rb' @@ -2600,11 +2319,9 @@ RSpec/ContextWording: - 'spec/models/badges/project_badge_spec.rb' - 'spec/models/blob_spec.rb' - 'spec/models/blob_viewer/package_json_spec.rb' - - 'spec/models/board_spec.rb' - 'spec/models/bulk_imports/entity_spec.rb' - 'spec/models/ci/artifact_blob_spec.rb' - 'spec/models/ci/bridge_spec.rb' - - 'spec/models/ci/build_dependencies_spec.rb' - 'spec/models/ci/build_metadata_spec.rb' - 'spec/models/ci/build_runner_session_spec.rb' - 'spec/models/ci/build_spec.rb' @@ -2620,7 +2337,6 @@ RSpec/ContextWording: - 'spec/models/ci/processable_spec.rb' - 'spec/models/ci/project_mirror_spec.rb' - 'spec/models/ci/ref_spec.rb' - - 'spec/models/ci/resource_spec.rb' - 'spec/models/ci/runner_project_spec.rb' - 'spec/models/ci/runner_spec.rb' - 'spec/models/ci/running_build_spec.rb' @@ -2643,7 +2359,6 @@ RSpec/ContextWording: - 'spec/models/clusters/kubernetes_namespace_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' - 'spec/models/clusters/providers/aws_spec.rb' - - 'spec/models/commit_signatures/x509_commit_signature_spec.rb' - 'spec/models/commit_spec.rb' - 'spec/models/commit_status_spec.rb' - 'spec/models/compare_spec.rb' @@ -2651,18 +2366,15 @@ RSpec/ContextWording: - 'spec/models/concerns/awardable_spec.rb' - 'spec/models/concerns/bulk_insert_safe_spec.rb' - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - - 'spec/models/concerns/cache_markdown_field_spec.rb' - 'spec/models/concerns/cacheable_attributes_spec.rb' - - 'spec/models/concerns/cascading_namespace_setting_attribute_spec.rb' - 'spec/models/concerns/ci/artifactable_spec.rb' - 'spec/models/concerns/ci/has_ref_spec.rb' - 'spec/models/concerns/ci/has_status_spec.rb' - - 'spec/models/concerns/cron_schedulable_spec.rb' - 'spec/models/concerns/cross_database_modification_spec.rb' - 'spec/models/concerns/deployment_platform_spec.rb' - - 'spec/models/concerns/group_descendant_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/concerns/loose_index_scan_spec.rb' - 'spec/models/concerns/mentionable_spec.rb' - 'spec/models/concerns/milestoneable_spec.rb' - 'spec/models/concerns/noteable_spec.rb' @@ -2671,20 +2383,16 @@ RSpec/ContextWording: - 'spec/models/concerns/protected_ref_access_spec.rb' - 'spec/models/concerns/reactive_caching_spec.rb' - 'spec/models/concerns/resolvable_note_spec.rb' - - 'spec/models/concerns/routable_spec.rb' - - 'spec/models/concerns/schedulable_spec.rb' - 'spec/models/concerns/sensitive_serializable_hash_spec.rb' - - 'spec/models/concerns/spammable_spec.rb' - 'spec/models/concerns/token_authenticatable_spec.rb' - 'spec/models/concerns/triggerable_hooks_spec.rb' - 'spec/models/concerns/usage_statistics_spec.rb' - 'spec/models/container_expiration_policy_spec.rb' - 'spec/models/container_repository_spec.rb' - - 'spec/models/customer_relations/issue_contact_spec.rb' - 'spec/models/dependency_proxy/manifest_spec.rb' - 'spec/models/dependency_proxy/registry_spec.rb' - - 'spec/models/deploy_key_spec.rb' - 'spec/models/deploy_token_spec.rb' + - 'spec/models/deployment_cluster_spec.rb' - 'spec/models/deployment_metrics_spec.rb' - 'spec/models/deployment_spec.rb' - 'spec/models/design_management/action_spec.rb' @@ -2697,25 +2405,21 @@ RSpec/ContextWording: - 'spec/models/diff_note_spec.rb' - 'spec/models/environment_spec.rb' - 'spec/models/environment_status_spec.rb' - - 'spec/models/error_tracking/error_event_spec.rb' - 'spec/models/error_tracking/error_spec.rb' - 'spec/models/event_collection_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/experiment_spec.rb' - - 'spec/models/external_issue_spec.rb' - 'spec/models/external_pull_request_spec.rb' - - 'spec/models/fork_network_spec.rb' - 'spec/models/gpg_key_spec.rb' - 'spec/models/grafana_integration_spec.rb' - - 'spec/models/group_deploy_token_spec.rb' - 'spec/models/group_label_spec.rb' - 'spec/models/group_spec.rb' - 'spec/models/hooks/active_hook_filter_spec.rb' + - 'spec/models/hooks/project_hook_spec.rb' - 'spec/models/hooks/system_hook_spec.rb' - 'spec/models/identity_spec.rb' - 'spec/models/import_export_upload_spec.rb' - 'spec/models/import_failure_spec.rb' - - 'spec/models/incident_management/timeline_event_spec.rb' - 'spec/models/integration_spec.rb' - 'spec/models/integrations/asana_spec.rb' - 'spec/models/integrations/bamboo_spec.rb' @@ -2791,45 +2495,36 @@ RSpec/ContextWording: - 'spec/models/project_metrics_setting_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/project_team_spec.rb' - - 'spec/models/projects/repository_storage_move_spec.rb' - 'spec/models/prometheus_alert_event_spec.rb' - - 'spec/models/protectable_dropdown_spec.rb' - 'spec/models/protected_branch_spec.rb' - 'spec/models/raw_usage_data_spec.rb' - 'spec/models/release_highlight_spec.rb' - 'spec/models/release_spec.rb' - - 'spec/models/releases/link_spec.rb' - 'spec/models/remote_mirror_spec.rb' - 'spec/models/repository_spec.rb' - 'spec/models/resource_label_event_spec.rb' - 'spec/models/resource_state_event_spec.rb' - 'spec/models/route_spec.rb' - - 'spec/models/sent_notification_spec.rb' - 'spec/models/sentry_issue_spec.rb' - 'spec/models/snippet_input_action_spec.rb' - 'spec/models/snippet_repository_spec.rb' - 'spec/models/snippet_spec.rb' - 'spec/models/spam_log_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - - 'spec/models/suggestion_spec.rb' - 'spec/models/terraform/state_spec.rb' - 'spec/models/terraform/state_version_spec.rb' - - 'spec/models/todo_spec.rb' - 'spec/models/upload_spec.rb' - 'spec/models/uploads/fog_spec.rb' - 'spec/models/uploads/local_spec.rb' - - 'spec/models/user_interacted_project_spec.rb' - 'spec/models/user_preference_spec.rb' - 'spec/models/user_spec.rb' - 'spec/models/users/in_product_marketing_email_spec.rb' - 'spec/models/wiki_page/meta_spec.rb' - 'spec/models/wiki_page/slug_spec.rb' - 'spec/models/wiki_page_spec.rb' + - 'spec/models/work_item_spec.rb' - 'spec/models/x509_certificate_spec.rb' - - 'spec/models/zoom_meeting_spec.rb' - - 'spec/policies/application_setting/term_policy_spec.rb' - 'spec/policies/application_setting_policy_spec.rb' - - 'spec/policies/base_policy_spec.rb' - 'spec/policies/board_policy_spec.rb' - 'spec/policies/ci/build_policy_spec.rb' - 'spec/policies/clusters/agents/activity_event_policy_spec.rb' @@ -2837,18 +2532,13 @@ RSpec/ContextWording: - 'spec/policies/custom_emoji_policy_spec.rb' - 'spec/policies/deploy_key_policy_spec.rb' - 'spec/policies/deploy_keys_project_policy_spec.rb' - - 'spec/policies/design_management/design_policy_spec.rb' - 'spec/policies/global_policy_spec.rb' - 'spec/policies/group_member_policy_spec.rb' - 'spec/policies/group_policy_spec.rb' - - 'spec/policies/instance_metadata_policy_spec.rb' - 'spec/policies/issuable_policy_spec.rb' - 'spec/policies/issue_policy_spec.rb' - - 'spec/policies/merge_request_policy_spec.rb' - 'spec/policies/metrics/dashboard/annotation_policy_spec.rb' - - 'spec/policies/namespaces/project_namespace_policy_spec.rb' - 'spec/policies/namespaces/user_namespace_policy_spec.rb' - - 'spec/policies/note_policy_spec.rb' - 'spec/policies/personal_access_token_policy_spec.rb' - 'spec/policies/personal_snippet_policy_spec.rb' - 'spec/policies/project_policy_spec.rb' @@ -2863,12 +2553,9 @@ RSpec/ContextWording: - 'spec/presenters/clusters/cluster_presenter_spec.rb' - 'spec/presenters/commit_status_presenter_spec.rb' - 'spec/presenters/gitlab/blame_presenter_spec.rb' - - 'spec/presenters/group_member_presenter_spec.rb' - 'spec/presenters/merge_request_presenter_spec.rb' - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/npm/package_presenter_spec.rb' - - 'spec/presenters/packages/nuget/service_index_presenter_spec.rb' - - 'spec/presenters/project_member_presenter_spec.rb' - 'spec/presenters/project_presenter_spec.rb' - 'spec/presenters/projects/import_export/project_export_presenter_spec.rb' - 'spec/presenters/projects/security/configuration_presenter_spec.rb' @@ -2888,10 +2575,8 @@ RSpec/ContextWording: - 'spec/requests/api/appearance_spec.rb' - 'spec/requests/api/applications_spec.rb' - 'spec/requests/api/avatar_spec.rb' - - 'spec/requests/api/award_emoji_spec.rb' - 'spec/requests/api/badges_spec.rb' - 'spec/requests/api/branches_spec.rb' - - 'spec/requests/api/broadcast_messages_spec.rb' - 'spec/requests/api/bulk_imports_spec.rb' - 'spec/requests/api/ci/job_artifacts_spec.rb' - 'spec/requests/api/ci/jobs_spec.rb' @@ -2919,10 +2604,8 @@ RSpec/ContextWording: - 'spec/requests/api/environments_spec.rb' - 'spec/requests/api/error_tracking/collector_spec.rb' - 'spec/requests/api/error_tracking/project_settings_spec.rb' - - 'spec/requests/api/events_spec.rb' - 'spec/requests/api/files_spec.rb' - 'spec/requests/api/generic_packages_spec.rb' - - 'spec/requests/api/go_proxy_spec.rb' - 'spec/requests/api/graphql/ci/runner_spec.rb' - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/requests/api/graphql/container_repository/container_repository_details_spec.rb' @@ -2933,6 +2616,7 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/group/group_members_spec.rb' - 'spec/requests/api/graphql/group/issues_spec.rb' - 'spec/requests/api/graphql/group/milestones_spec.rb' + - 'spec/requests/api/graphql/issue/issue_spec.rb' - 'spec/requests/api/graphql/metadata_query_spec.rb' - 'spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb' - 'spec/requests/api/graphql/metrics/dashboard_query_spec.rb' @@ -2942,7 +2626,6 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/mutations/branches/create_spec.rb' - 'spec/requests/api/graphql/mutations/ci/runners_registration_token/reset_spec.rb' - 'spec/requests/api/graphql/mutations/commits/create_spec.rb' - - 'spec/requests/api/graphql/mutations/container_expiration_policy/update_spec.rb' - 'spec/requests/api/graphql/mutations/custom_emoji/destroy_spec.rb' - 'spec/requests/api/graphql/mutations/design_management/delete_spec.rb' - 'spec/requests/api/graphql/mutations/design_management/move_spec.rb' @@ -2951,9 +2634,7 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/mutations/issues/update_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/create_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/request_attention_spec.rb' - - 'spec/requests/api/graphql/mutations/namespace/package_settings/update_spec.rb' - 'spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb' - - 'spec/requests/api/graphql/mutations/notes/create/note_spec.rb' - 'spec/requests/api/graphql/mutations/releases/create_spec.rb' - 'spec/requests/api/graphql/mutations/releases/delete_spec.rb' - 'spec/requests/api/graphql/mutations/releases/update_spec.rb' @@ -2963,10 +2644,11 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/mutations/work_items/create_spec.rb' - 'spec/requests/api/graphql/mutations/work_items/delete_task_spec.rb' - 'spec/requests/api/graphql/mutations/work_items/update_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/update_task_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/update_widgets_spec.rb' - 'spec/requests/api/graphql/namespace_query_spec.rb' - 'spec/requests/api/graphql/packages/maven_spec.rb' - 'spec/requests/api/graphql/packages/package_spec.rb' - - 'spec/requests/api/graphql/project/alert_management/alert/notes_spec.rb' - 'spec/requests/api/graphql/project/alert_management/alerts_spec.rb' - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' - 'spec/requests/api/graphql/project/container_repositories_spec.rb' @@ -2981,7 +2663,6 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/project/pipeline_spec.rb' - 'spec/requests/api/graphql/project/project_members_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - - 'spec/requests/api/graphql/project/repository_spec.rb' - 'spec/requests/api/graphql/project/terraform/state_spec.rb' - 'spec/requests/api/graphql/project/terraform/states_spec.rb' - 'spec/requests/api/graphql/project_query_spec.rb' @@ -2990,7 +2671,6 @@ RSpec/ContextWording: - 'spec/requests/api/graphql/user_query_spec.rb' - 'spec/requests/api/graphql/users_spec.rb' - 'spec/requests/api/graphql_spec.rb' - - 'spec/requests/api/group_avatar_spec.rb' - 'spec/requests/api/group_clusters_spec.rb' - 'spec/requests/api/group_labels_spec.rb' - 'spec/requests/api/group_packages_spec.rb' @@ -2998,6 +2678,7 @@ RSpec/ContextWording: - 'spec/requests/api/groups_spec.rb' - 'spec/requests/api/helm_packages_spec.rb' - 'spec/requests/api/helpers_spec.rb' + - 'spec/requests/api/integrations/jira_connect/subscriptions_spec.rb' - 'spec/requests/api/integrations_spec.rb' - 'spec/requests/api/internal/base_spec.rb' - 'spec/requests/api/internal/container_registry/migration_spec.rb' @@ -3005,6 +2686,7 @@ RSpec/ContextWording: - 'spec/requests/api/internal/lfs_spec.rb' - 'spec/requests/api/internal/mail_room_spec.rb' - 'spec/requests/api/internal/pages_spec.rb' + - 'spec/requests/api/internal/workhorse_spec.rb' - 'spec/requests/api/invitations_spec.rb' - 'spec/requests/api/issue_links_spec.rb' - 'spec/requests/api/issues/get_group_issues_spec.rb' @@ -3013,11 +2695,9 @@ RSpec/ContextWording: - 'spec/requests/api/issues/post_projects_issues_spec.rb' - 'spec/requests/api/issues/put_projects_issues_spec.rb' - 'spec/requests/api/keys_spec.rb' - - 'spec/requests/api/labels_spec.rb' - 'spec/requests/api/lint_spec.rb' - 'spec/requests/api/maven_packages_spec.rb' - 'spec/requests/api/members_spec.rb' - - 'spec/requests/api/merge_request_approvals_spec.rb' - 'spec/requests/api/merge_request_diffs_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/metrics/user_starred_dashboards_spec.rb' @@ -3034,8 +2714,6 @@ RSpec/ContextWording: - 'spec/requests/api/project_container_repositories_spec.rb' - 'spec/requests/api/project_events_spec.rb' - 'spec/requests/api/project_export_spec.rb' - - 'spec/requests/api/project_hooks_spec.rb' - - 'spec/requests/api/project_import_spec.rb' - 'spec/requests/api/project_packages_spec.rb' - 'spec/requests/api/project_snippets_spec.rb' - 'spec/requests/api/projects_spec.rb' @@ -3046,6 +2724,7 @@ RSpec/ContextWording: - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/search_spec.rb' - 'spec/requests/api/settings_spec.rb' + - 'spec/requests/api/snippets_spec.rb' - 'spec/requests/api/tags_spec.rb' - 'spec/requests/api/task_completion_status_spec.rb' - 'spec/requests/api/templates_spec.rb' @@ -3053,7 +2732,6 @@ RSpec/ContextWording: - 'spec/requests/api/terraform/state_spec.rb' - 'spec/requests/api/terraform/state_version_spec.rb' - 'spec/requests/api/todos_spec.rb' - - 'spec/requests/api/topics_spec.rb' - 'spec/requests/api/usage_data_spec.rb' - 'spec/requests/api/user_counts_spec.rb' - 'spec/requests/api/users_preferences_spec.rb' @@ -3066,31 +2744,32 @@ RSpec/ContextWording: - 'spec/requests/groups/clusters/integrations_controller_spec.rb' - 'spec/requests/groups/crm/contacts_controller_spec.rb' - 'spec/requests/groups/crm/organizations_controller_spec.rb' - - 'spec/requests/groups/email_campaigns_controller_spec.rb' - 'spec/requests/groups/milestones_controller_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' - 'spec/requests/health_controller_spec.rb' - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jira_connect/installations_controller_spec.rb' + - 'spec/requests/jira_connect/oauth_application_ids_controller_spec.rb' - 'spec/requests/jira_routing_spec.rb' - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' + - 'spec/requests/mailgun/webhooks_controller_spec.rb' - 'spec/requests/oauth_tokens_spec.rb' - 'spec/requests/openid_connect_spec.rb' - 'spec/requests/product_analytics/collector_app_attack_spec.rb' - 'spec/requests/product_analytics/collector_app_spec.rb' - 'spec/requests/projects/clusters/integrations_controller_spec.rb' - 'spec/requests/projects/commits_controller_spec.rb' + - 'spec/requests/projects/google_cloud/configuration_controller_spec.rb' + - 'spec/requests/projects/google_cloud/databases_controller_spec.rb' - 'spec/requests/projects/google_cloud/deployments_controller_spec.rb' - 'spec/requests/projects/google_cloud/gcp_regions_controller_spec.rb' - 'spec/requests/projects/google_cloud/service_accounts_controller_spec.rb' - - 'spec/requests/projects/google_cloud_controller_spec.rb' - 'spec/requests/projects/issues/discussions_spec.rb' - 'spec/requests/projects/issues_controller_spec.rb' - 'spec/requests/projects/merge_requests_controller_spec.rb' - 'spec/requests/projects/merge_requests_discussions_spec.rb' - - 'spec/requests/projects/merge_requests_spec.rb' - 'spec/requests/projects/metrics/dashboards/builder_spec.rb' - 'spec/requests/projects/releases_controller_spec.rb' - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' @@ -3098,13 +2777,11 @@ RSpec/ContextWording: - 'spec/requests/projects/usage_quotas_spec.rb' - 'spec/requests/projects_controller_spec.rb' - 'spec/requests/rack_attack_global_spec.rb' - - 'spec/requests/search_controller_spec.rb' - 'spec/requests/sessions_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/git_http_routing_spec.rb' - 'spec/routing/group_routing_spec.rb' - 'spec/routing/project_routing_spec.rb' - - 'spec/rubocop/cop/gitlab/avoid_feature_category_not_owned_spec.rb' - 'spec/rubocop/cop/gitlab/change_timezone_spec.rb' - 'spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb' - 'spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb' @@ -3116,7 +2793,6 @@ RSpec/ContextWording: - 'spec/rubocop/cop/graphql/old_types_spec.rb' - 'spec/rubocop/cop/lint/last_keyword_argument_spec.rb' - 'spec/rubocop/cop/migration/add_index_spec.rb' - - 'spec/rubocop/cop/migration/add_limit_to_text_columns_spec.rb' - 'spec/rubocop/cop/migration/background_migration_record_spec.rb' - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' - 'spec/rubocop/cop/migration/migration_record_spec.rb' @@ -3127,45 +2803,31 @@ RSpec/ContextWording: - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/rubocop/cop/migration/versioned_migration_class_spec.rb' - 'spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb' - - 'spec/rubocop/cop/performance/readlines_each_spec.rb' - 'spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb' - 'spec/rubocop/cop/qa/element_with_pattern_spec.rb' - 'spec/rubocop/cop/qa/selector_usage_spec.rb' - 'spec/rubocop/cop/rspec/factory_bot/inline_association_spec.rb' - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - - 'spec/serializers/blob_entity_spec.rb' - 'spec/serializers/board_serializer_spec.rb' - - 'spec/serializers/ci/job_serializer_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - 'spec/serializers/cluster_application_entity_spec.rb' - - 'spec/serializers/cluster_entity_spec.rb' - - 'spec/serializers/context_commits_diff_entity_spec.rb' + - 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb' - 'spec/serializers/diff_file_base_entity_spec.rb' - 'spec/serializers/diff_file_entity_spec.rb' - - 'spec/serializers/diff_file_metadata_entity_spec.rb' - 'spec/serializers/diffs_entity_spec.rb' - - 'spec/serializers/diffs_metadata_entity_spec.rb' - 'spec/serializers/environment_entity_spec.rb' - 'spec/serializers/environment_serializer_spec.rb' - 'spec/serializers/group_child_entity_spec.rb' - - 'spec/serializers/group_child_serializer_spec.rb' - 'spec/serializers/group_link/group_group_link_entity_spec.rb' - - 'spec/serializers/integrations/project_entity_spec.rb' - 'spec/serializers/issue_serializer_spec.rb' - - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' - 'spec/serializers/member_entity_spec.rb' - 'spec/serializers/member_serializer_spec.rb' - - 'spec/serializers/merge_request_current_user_entity_spec.rb' - 'spec/serializers/merge_request_diff_entity_spec.rb' - - 'spec/serializers/merge_request_for_pipeline_entity_spec.rb' - 'spec/serializers/merge_request_serializer_spec.rb' - 'spec/serializers/merge_request_user_entity_spec.rb' - - 'spec/serializers/merge_request_widget_commit_entity_spec.rb' - - 'spec/serializers/merge_request_widget_entity_spec.rb' - 'spec/serializers/paginated_diff_entity_spec.rb' - 'spec/serializers/pipeline_details_entity_spec.rb' - - 'spec/serializers/stage_entity_spec.rb' - 'spec/serializers/user_serializer_spec.rb' - 'spec/services/access_token_validation_service_spec.rb' - 'spec/services/alert_management/alerts/update_service_spec.rb' @@ -3178,7 +2840,6 @@ RSpec/ContextWording: - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'spec/services/boards/issues/list_service_spec.rb' - 'spec/services/boards/issues/move_service_spec.rb' - - 'spec/services/boards/lists/update_service_spec.rb' - 'spec/services/branches/delete_merged_service_spec.rb' - 'spec/services/branches/validate_new_service_spec.rb' - 'spec/services/bulk_create_integration_service_spec.rb' @@ -3186,7 +2847,6 @@ RSpec/ContextWording: - 'spec/services/ci/after_requeue_job_service_spec.rb' - 'spec/services/ci/append_build_trace_service_spec.rb' - 'spec/services/ci/archive_trace_service_spec.rb' - - 'spec/services/ci/build_report_result_service_spec.rb' - 'spec/services/ci/compare_test_reports_service_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service/cache_spec.rb' @@ -3209,14 +2869,11 @@ RSpec/ContextWording: - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - 'spec/services/ci/pipelines/add_job_service_spec.rb' - - 'spec/services/ci/play_build_service_spec.rb' - 'spec/services/ci/prepare_build_service_spec.rb' - - 'spec/services/ci/process_sync_events_service_spec.rb' - 'spec/services/ci/prometheus_metrics/observe_histograms_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' - 'spec/services/ci/retry_job_service_spec.rb' - - 'spec/services/ci/stuck_builds/drop_pending_service_spec.rb' - - 'spec/services/ci/stuck_builds/drop_scheduled_service_spec.rb' + - 'spec/services/ci/runners/reconcile_existing_runner_versions_service_spec.rb' - 'spec/services/ci/update_build_queue_service_spec.rb' - 'spec/services/ci/update_pending_build_service_spec.rb' - 'spec/services/clusters/agent_tokens/track_usage_service_spec.rb' @@ -3253,18 +2910,16 @@ RSpec/ContextWording: - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' - 'spec/services/dependency_proxy/head_manifest_service_spec.rb' - 'spec/services/dependency_proxy/request_token_service_spec.rb' - - 'spec/services/deployments/older_deployments_drop_service_spec.rb' - 'spec/services/deployments/update_environment_service_spec.rb' - 'spec/services/design_management/delete_designs_service_spec.rb' - 'spec/services/design_management/generate_image_versions_service_spec.rb' - 'spec/services/design_management/move_designs_service_spec.rb' - 'spec/services/discussions/capture_diff_note_position_service_spec.rb' - - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' - - 'spec/services/discussions/resolve_service_spec.rb' - 'spec/services/draft_notes/create_service_spec.rb' - 'spec/services/draft_notes/destroy_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' + - 'spec/services/environments/stop_service_spec.rb' - 'spec/services/error_tracking/collect_error_service_spec.rb' - 'spec/services/error_tracking/list_issues_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' @@ -3295,12 +2950,13 @@ RSpec/ContextWording: - 'spec/services/ide/schemas_config_service_spec.rb' - 'spec/services/ide/terminal_config_service_spec.rb' - 'spec/services/import/bitbucket_server_service_spec.rb' + - 'spec/services/import/fogbugz_service_spec.rb' - 'spec/services/import/github_service_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' - 'spec/services/incident_management/incidents/create_service_spec.rb' - 'spec/services/incident_management/issuable_escalation_statuses/create_service_spec.rb' - - 'spec/services/integrations/propagate_service_spec.rb' + - 'spec/services/incident_management/timeline_events/destroy_service_spec.rb' - 'spec/services/integrations/test/project_service_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issue_links/list_service_spec.rb' @@ -3317,17 +2973,17 @@ RSpec/ContextWording: - 'spec/services/issues/set_crm_contacts_service_spec.rb' - 'spec/services/issues/update_service_spec.rb' - 'spec/services/issues/zoom_link_service_spec.rb' - - 'spec/services/jira_connect_installations/destroy_service_spec.rb' - 'spec/services/jira_connect_subscriptions/create_service_spec.rb' - 'spec/services/keys/create_service_spec.rb' - 'spec/services/keys/expiry_notification_service_spec.rb' - - 'spec/services/labels/create_service_spec.rb' - - 'spec/services/lfs/file_transformer_spec.rb' - 'spec/services/lfs/locks_finder_service_spec.rb' - 'spec/services/lfs/push_service_spec.rb' - 'spec/services/lfs/unlock_file_service_spec.rb' - 'spec/services/members/approve_access_request_service_spec.rb' - 'spec/services/members/destroy_service_spec.rb' + - 'spec/services/members/groups/creator_service_spec.rb' + - 'spec/services/members/projects/creator_service_spec.rb' + - 'spec/services/members/update_service_spec.rb' - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb' - 'spec/services/merge_requests/after_create_service_spec.rb' - 'spec/services/merge_requests/approval_service_spec.rb' @@ -3351,7 +3007,6 @@ RSpec/ContextWording: - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/merge_requests/reload_diffs_service_spec.rb' - 'spec/services/merge_requests/reopen_service_spec.rb' - - 'spec/services/merge_requests/retarget_chain_service_spec.rb' - 'spec/services/merge_requests/squash_service_spec.rb' - 'spec/services/merge_requests/toggle_attention_requested_service_spec.rb' - 'spec/services/merge_requests/update_assignees_service_spec.rb' @@ -3379,7 +3034,6 @@ RSpec/ContextWording: - 'spec/services/milestones/promote_service_spec.rb' - 'spec/services/milestones/update_service_spec.rb' - 'spec/services/namespace_settings/update_service_spec.rb' - - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'spec/services/note_summary_spec.rb' - 'spec/services/notes/build_service_spec.rb' - 'spec/services/notes/copy_service_spec.rb' @@ -3388,12 +3042,11 @@ RSpec/ContextWording: - 'spec/services/notes/quick_actions_service_spec.rb' - 'spec/services/notes/update_service_spec.rb' - 'spec/services/notification_recipients/builder/default_spec.rb' - - 'spec/services/notification_recipients/builder/new_note_spec.rb' - 'spec/services/notification_service_spec.rb' + - 'spec/services/packages/cleanup/execute_policy_service_spec.rb' - 'spec/services/packages/composer/create_package_service_spec.rb' - 'spec/services/packages/conan/create_package_file_service_spec.rb' - 'spec/services/packages/conan/create_package_service_spec.rb' - - 'spec/services/packages/create_event_service_spec.rb' - 'spec/services/packages/create_package_file_service_spec.rb' - 'spec/services/packages/debian/create_distribution_service_spec.rb' - 'spec/services/packages/debian/create_package_file_service_spec.rb' @@ -3404,18 +3057,15 @@ RSpec/ContextWording: - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/maven/create_package_service_spec.rb' - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' - - 'spec/services/packages/maven/metadata/create_plugins_xml_service_spec.rb' - 'spec/services/packages/maven/metadata/create_versions_xml_service_spec.rb' - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - 'spec/services/packages/npm/create_package_service_spec.rb' - - 'spec/services/packages/npm/create_tag_service_spec.rb' - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' - 'spec/services/packages/nuget/search_service_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/packages/rubygems/dependency_resolver_service_spec.rb' - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - - 'spec/services/packages/update_tags_service_spec.rb' - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/personal_access_tokens/create_service_spec.rb' - 'spec/services/personal_access_tokens/revoke_service_spec.rb' @@ -3450,7 +3100,6 @@ RSpec/ContextWording: - 'spec/services/projects/record_target_platforms_service_spec.rb' - 'spec/services/projects/transfer_service_spec.rb' - 'spec/services/projects/unlink_fork_service_spec.rb' - - 'spec/services/projects/update_pages_service_spec.rb' - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_repository_storage_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' @@ -3458,10 +3107,8 @@ RSpec/ContextWording: - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb' - 'spec/services/protected_tags/create_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' - - 'spec/services/quick_actions/target_service_spec.rb' - 'spec/services/releases/create_service_spec.rb' - 'spec/services/releases/update_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/resource_access_tokens/create_service_spec.rb' - 'spec/services/search/global_service_spec.rb' - 'spec/services/search/group_service_spec.rb' @@ -3480,18 +3127,18 @@ RSpec/ContextWording: - 'spec/services/submodules/update_service_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' - - 'spec/services/system_notes/commit_service_spec.rb' - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/system_notes/issuables_service_spec.rb' - 'spec/services/system_notes/merge_requests_service_spec.rb' - 'spec/services/tasks_to_be_done/base_service_spec.rb' - 'spec/services/terraform/remote_state_handler_spec.rb' + - 'spec/services/terraform/states/destroy_service_spec.rb' + - 'spec/services/terraform/states/trigger_destroy_service_spec.rb' - 'spec/services/test_hooks/project_service_spec.rb' - 'spec/services/test_hooks/system_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/services/todos/destroy/entity_leave_service_spec.rb' - 'spec/services/two_factor/destroy_service_spec.rb' - - 'spec/services/upload_service_spec.rb' - 'spec/services/user_preferences/update_service_spec.rb' - 'spec/services/users/activity_service_spec.rb' - 'spec/services/users/approve_service_spec.rb' @@ -3514,10 +3161,9 @@ RSpec/ContextWording: - 'spec/services/wiki_pages/event_create_service_spec.rb' - 'spec/services/wikis/create_attachment_service_spec.rb' - 'spec/services/work_items/create_service_spec.rb' - - 'spec/services/x509_certificate_revoke_service_spec.rb' + - 'spec/services/work_items/parent_links/create_service_spec.rb' - 'spec/support/banzai/reference_filter_shared_examples.rb' - 'spec/support/prometheus/additional_metrics_shared_examples.rb' - - 'spec/support/redis/redis_new_instance_shared_examples.rb' - 'spec/support/redis/redis_shared_examples.rb' - 'spec/support/services/clusters/create_service_shared.rb' - 'spec/support/services/deploy_token_shared_examples.rb' @@ -3546,6 +3192,7 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/finders/merge_requests_finder_shared_contexts.rb' - 'spec/support/shared_contexts/finders/packages/npm/package_finder_shared_context.rb' - 'spec/support/shared_contexts/finders/users_finder_shared_contexts.rb' + - 'spec/support/shared_contexts/finders/work_items_finder_shared_contexts.rb' - 'spec/support/shared_contexts/fixtures/analytics_shared_context.rb' - 'spec/support/shared_contexts/graphql/requests/packages_shared_context.rb' - 'spec/support/shared_contexts/graphql/resolvers/runners_resolver_shared_context.rb' @@ -3569,6 +3216,7 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/policies/group_policy_shared_context.rb' - 'spec/support/shared_contexts/policies/project_policy_shared_context.rb' - 'spec/support/shared_contexts/policies/project_policy_table_shared_context.rb' + - 'spec/support/shared_contexts/project_features_shared_context.rb' - 'spec/support/shared_contexts/prometheus/alert_shared_context.rb' - 'spec/support/shared_contexts/rack_attack_shared_context.rb' - 'spec/support/shared_contexts/read_ci_configuration_shared_context.rb' @@ -3592,18 +3240,13 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/unique_ip_check_shared_context.rb' - 'spec/support/shared_contexts/upload_type_check_shared_context.rb' - 'spec/support/shared_contexts/url_shared_context.rb' - - 'spec/support/shared_examples/banzai/filters/inline_embeds_shared_examples.rb' - 'spec/support/shared_examples/banzai/filters/inline_metrics_redactor_shared_examples.rb' - 'spec/support/shared_examples/boards/multiple_issue_boards_shared_examples.rb' - 'spec/support/shared_examples/controllers/clusters_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/hotlink_interceptor_shared_examples.rb' - 'spec/support/shared_examples/controllers/issuables_list_metadata_shared_examples.rb' - - 'spec/support/shared_examples/controllers/milestone_tabs_shared_examples.rb' - - 'spec/support/shared_examples/controllers/repository_lfs_file_load_shared_examples.rb' - 'spec/support/shared_examples/controllers/snippet_blob_shared_examples.rb' - - 'spec/support/shared_examples/controllers/uploads_actions_shared_examples.rb' - - 'spec/support/shared_examples/controllers/variables_shared_examples.rb' - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - 'spec/support/shared_examples/csp.rb' - 'spec/support/shared_examples/features/access_tokens_shared_examples.rb' @@ -3622,6 +3265,7 @@ RSpec/ContextWording: - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_views_wiki_pages_shared_examples.rb' - 'spec/support/shared_examples/finders/assignees_filter_shared_examples.rb' + - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' - 'spec/support/shared_examples/finders/packages/debian/distributions_finder_shared_examples.rb' - 'spec/support/shared_examples/finders/packages_shared_examples.rb' - 'spec/support/shared_examples/finders/snippet_visibility_shared_examples.rb' @@ -3632,14 +3276,13 @@ RSpec/ContextWording: - 'spec/support/shared_examples/graphql/notes_on_noteables_shared_examples.rb' - 'spec/support/shared_examples/graphql/resolvers/packages_resolvers_shared_examples.rb' - 'spec/support/shared_examples/graphql/resolves_issuable_shared_examples.rb' - - 'spec/support/shared_examples/graphql/spam_protection_shared_examples.rb' + - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb' - 'spec/support/shared_examples/helm_commands_shared_examples.rb' - 'spec/support/shared_examples/helpers/issuable_description_templates_shared_examples.rb' - 'spec/support/shared_examples/lib/api/internal_base_shared_examples.rb' - 'spec/support/shared_examples/lib/cache_helpers_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/config/inheritable_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/import_export/relation_factory_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/database/reestablished_connection_stack_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/middleware/multipart_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_instance_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/search_confidential_filter_shared_examples.rb' @@ -3649,7 +3292,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/lib/gitlab/sidekiq_middleware/strategy_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/chat_integration_shared_examples.rb' - - 'spec/support/shared_examples/models/cluster_application_helm_cert_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_status_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_version_shared_examples.rb' - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' @@ -3657,7 +3299,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/models/concerns/composite_id_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/integrations/slack_mattermost_notifier_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/issuable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/repository_storage_movable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/timebox_shared_examples.rb' - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' @@ -3680,7 +3321,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/debian_common_shared_examples.rb' - 'spec/support/shared_examples/requests/api/debian_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/mutations/boards/update_list_shared_examples.rb' @@ -3688,6 +3328,7 @@ RSpec/ContextWording: - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/read_only_instance_shared_examples.rb' - 'spec/support/shared_examples/requests/api/helm_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - 'spec/support/shared_examples/requests/api/issues_shared_examples.rb' - 'spec/support/shared_examples/requests/api/multiple_and_scoped_issue_boards_shared_examples.rb' - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' @@ -3696,17 +3337,12 @@ RSpec/ContextWording: - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/read_user_shared_examples.rb' - 'spec/support/shared_examples/requests/api/repositories_shared_context.rb' - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/status_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/terraform/modules/v1/packages_shared_examples.rb' - 'spec/support/shared_examples/requests/clusters/certificate_based_clusters_feature_flag_shared_examples.rb' - 'spec/support/shared_examples/requests/lfs_http_shared_examples.rb' - 'spec/support/shared_examples/requests/releases_shared_examples.rb' - 'spec/support/shared_examples/routing/git_http_routing_shared_examples.rb' - - 'spec/support/shared_examples/sends_git_audit_streaming_event_shared_examples.rb' - 'spec/support/shared_examples/serializers/diff_file_entity_shared_examples.rb' - 'spec/support/shared_examples/serializers/note_entity_shared_examples.rb' - 'spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' @@ -3726,42 +3362,36 @@ RSpec/ContextWording: - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' - 'spec/support/shared_examples/services/schedule_bulk_repository_shard_moves_shared_examples.rb' - 'spec/support/shared_examples/services/security/ci_configuration/create_service_shared_examples.rb' - - 'spec/support/shared_examples/services/updating_mentions_shared_examples.rb' - 'spec/support/shared_examples/services/wiki_pages/create_service_shared_examples.rb' - 'spec/support/shared_examples/services/wiki_pages/update_service_shared_examples.rb' - 'spec/support/shared_examples/services/wikis/create_attachment_service_shared_examples.rb' - - 'spec/support/shared_examples/snippet_blob_shared_examples.rb' - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - 'spec/support/shared_examples/validators/url_validator_shared_examples.rb' - 'spec/support/shared_examples/views/pipeline_status_changes_email.rb' + - 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb' - 'spec/support/shared_examples/workers/concerns/git_garbage_collect_methods_shared_examples.rb' - 'spec/support/shared_examples/workers/project_export_shared_examples.rb' - - 'spec/support_specs/database/multiple_databases_spec.rb' - 'spec/support_specs/helpers/migrations_helpers_spec.rb' - 'spec/support_specs/helpers/stub_feature_flags_spec.rb' + - 'spec/support_specs/helpers/stub_method_calls_spec.rb' - 'spec/tasks/cache/clear/redis_spec.rb' - 'spec/tasks/dev_rake_spec.rb' - 'spec/tasks/gettext_rake_spec.rb' - - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb' - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' + - 'spec/tasks/gitlab/db/lock_writes_rake_spec.rb' - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/tasks/gitlab/dependency_proxy/migrate_rake_spec.rb' - 'spec/tasks/gitlab/gitaly_rake_spec.rb' - 'spec/tasks/gitlab/lfs/migrate_rake_spec.rb' - 'spec/tasks/gitlab/packages/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/pages_rake_spec.rb' - 'spec/tasks/gitlab/storage_rake_spec.rb' - 'spec/tasks/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/uploads/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/user_management_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' - - 'spec/tooling/danger/feature_flag_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' - 'spec/tooling/lib/tooling/parallel_rspec_runner_spec.rb' - - 'spec/tooling/rspec_flaky/listener_spec.rb' - 'spec/uploaders/attachment_uploader_spec.rb' - 'spec/uploaders/avatar_uploader_spec.rb' - 'spec/uploaders/content_type_whitelist_spec.rb' @@ -3782,7 +3412,6 @@ RSpec/ContextWording: - 'spec/uploaders/packages/package_file_uploader_spec.rb' - 'spec/uploaders/personal_file_uploader_spec.rb' - 'spec/uploaders/terraform/state_uploader_spec.rb' - - 'spec/uploaders/workers/object_storage/background_move_worker_spec.rb' - 'spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb' - 'spec/validators/addressable_url_validator_spec.rb' - 'spec/validators/array_members_validator_spec.rb' @@ -3804,7 +3433,6 @@ RSpec/ContextWording: - 'spec/views/layouts/_header_search.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - 'spec/views/layouts/header/_new_dropdown.haml_spec.rb' - - 'spec/views/layouts/nav/sidebar/_admin.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/notify/changed_milestone_email.html.haml_spec.rb' - 'spec/views/profiles/keys/_key.html.haml_spec.rb' @@ -3817,15 +3445,13 @@ RSpec/ContextWording: - 'spec/views/projects/hooks/edit.html.haml_spec.rb' - 'spec/views/projects/hooks/index.html.haml_spec.rb' - 'spec/views/projects/pipeline_schedules/_pipeline_schedule.html.haml_spec.rb' + - 'spec/views/projects/settings/integrations/edit.html.haml_spec.rb' - 'spec/views/projects/settings/operations/show.html.haml_spec.rb' - 'spec/views/projects/tags/index.html.haml_spec.rb' - - 'spec/views/projects/tree/show.html.haml_spec.rb' - 'spec/views/search/_results.html.haml_spec.rb' - 'spec/views/search/show.html.haml_spec.rb' - - 'spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'spec/views/shared/issuable/_sidebar.html.haml_spec.rb' - 'spec/views/shared/milestones/_issuable.html.haml_spec.rb' - - 'spec/views/shared/projects/_list.html.haml_spec.rb' - 'spec/views/shared/snippets/_snippet.html.haml_spec.rb' - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' - 'spec/workers/admin_email_worker_spec.rb' @@ -3834,12 +3460,12 @@ RSpec/ContextWording: - 'spec/workers/authorized_project_update/project_recalculate_per_user_worker_spec.rb' - 'spec/workers/authorized_project_update/project_recalculate_worker_spec.rb' - 'spec/workers/authorized_project_update/user_refresh_over_user_range_worker_spec.rb' - - 'spec/workers/bulk_imports/entity_worker_spec.rb' - 'spec/workers/ci/build_prepare_worker_spec.rb' - 'spec/workers/cleanup_container_repository_worker_spec.rb' - 'spec/workers/cluster_update_app_worker_spec.rb' - 'spec/workers/clusters/agents/delete_expired_events_worker_spec.rb' - 'spec/workers/concerns/application_worker_spec.rb' + - 'spec/workers/concerns/waitable_worker_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - 'spec/workers/container_expiration_policy_worker_spec.rb' - 'spec/workers/container_registry/migration/enqueuer_worker_spec.rb' @@ -3852,6 +3478,7 @@ RSpec/ContextWording: - 'spec/workers/deployments/update_environment_worker_spec.rb' - 'spec/workers/design_management/new_version_worker_spec.rb' - 'spec/workers/every_sidekiq_worker_spec.rb' + - 'spec/workers/gitlab_service_ping_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - 'spec/workers/integrations/create_external_cross_reference_worker_spec.rb' @@ -3868,11 +3495,11 @@ RSpec/ContextWording: - 'spec/workers/project_export_worker_spec.rb' - 'spec/workers/projects/git_garbage_collect_worker_spec.rb' - 'spec/workers/projects/post_creation_worker_spec.rb' - - 'spec/workers/projects/refresh_build_artifacts_size_statistics_worker_spec.rb' - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' - 'spec/workers/remove_expired_group_links_worker_spec.rb' - 'spec/workers/remove_expired_members_worker_spec.rb' - 'spec/workers/remove_unaccepted_member_invites_worker_spec.rb' - 'spec/workers/repository_fork_worker_spec.rb' - 'spec/workers/stuck_merge_jobs_worker_spec.rb' + - 'spec/workers/terraform/states/destroy_worker_spec.rb' - 'spec/workers/x509_issuer_crl_check_worker_spec.rb' diff --git a/.rubocop_todo/rspec/empty_line_after_hook.yml b/.rubocop_todo/rspec/empty_line_after_hook.yml new file mode 100644 index 00000000000..4b1c4299b20 --- /dev/null +++ b/.rubocop_todo/rspec/empty_line_after_hook.yml @@ -0,0 +1,60 @@ +--- +# Cop supports --auto-correct. +RSpec/EmptyLineAfterHook: + Exclude: + - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' + - 'ee/spec/controllers/projects/push_rules_controller_spec.rb' + - 'ee/spec/features/groups/usage_quotas_spec.rb' + - 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb' + - 'ee/spec/features/profiles/usage_quotas_spec.rb' + - 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb' + - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' + - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' + - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' + - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' + - 'ee/spec/lib/gitlab/proxy_spec.rb' + - 'ee/spec/lib/gitlab/vulnerabilities/container_scanning_vulnerability_spec.rb' + - 'ee/spec/models/ee/key_spec.rb' + - 'ee/spec/models/project_spec.rb' + - 'ee/spec/requests/api/users_spec.rb' + - 'ee/spec/requests/search_controller_spec.rb' + - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' + - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' + - 'ee/spec/services/ee/two_factor/destroy_service_spec.rb' + - 'ee/spec/services/external_status_checks/update_service_spec.rb' + - 'ee/spec/services/group_saml/saml_group_links/destroy_service_spec.rb' + - 'ee/spec/services/groups/memberships/export_service_spec.rb' + - 'ee/spec/services/merge_requests/approval_service_spec.rb' + - 'ee/spec/support/shared_examples/policies/protected_environments_shared_examples.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' + - 'qa/spec/specs/helpers/quarantine_spec.rb' + - 'qa/spec/support/page_error_checker_spec.rb' + - 'spec/controllers/admin/spam_logs_controller_spec.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/features/admin/admin_mode/login_spec.rb' + - 'spec/features/calendar_spec.rb' + - 'spec/features/projects/blobs/user_views_pipeline_editor_button_spec.rb' + - 'spec/features/users/overview_spec.rb' + - 'spec/lib/gitlab/auth/ldap/person_spec.rb' + - 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb' + - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' + - 'spec/mailers/emails/pages_domains_spec.rb' + - 'spec/models/application_record_spec.rb' + - 'spec/models/integrations/chat_message/merge_message_spec.rb' + - 'spec/models/integrations/microsoft_teams_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb' + - 'spec/requests/api/issues/issues_spec.rb' + - 'spec/requests/api/pages/internal_access_spec.rb' + - 'spec/requests/api/pages/private_access_spec.rb' + - 'spec/requests/api/pages/public_access_spec.rb' + - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' + - 'spec/services/merge_requests/execute_approval_hooks_service_spec.rb' + - 'spec/services/notes/create_service_spec.rb' + - 'spec/services/notes/quick_actions_service_spec.rb' + - 'spec/services/projects/fork_service_spec.rb' + - 'spec/support/redis/redis_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/milestones_shared_examples.rb' + - 'spec/support/shared_examples/sends_git_audit_streaming_event_shared_examples.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index b08830bd5a3..03066626883 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. RSpec/ExpectChange: - # Offense count: 1707 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/admin/applications_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' @@ -28,8 +25,10 @@ RSpec/ExpectChange: - 'ee/spec/controllers/registrations/groups_controller_spec.rb' - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/projects_spec.rb' + - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/graphql/ee/mutations/ci/runner/update_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' @@ -38,9 +37,9 @@ RSpec/ExpectChange: - 'ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_site_validations/revoke_spec.rb' - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' - - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' - 'ee/spec/lib/audit/changes_spec.rb' - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' + - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/push_rule_pipeline_spec.rb' @@ -52,14 +51,17 @@ RSpec/ExpectChange: - 'ee/spec/lib/ee/audit/project_setting_changes_auditor_spec.rb' - 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/create_security_setting_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/repo_restorer_spec.rb' + - 'ee/spec/lib/ee/gitlab/issuable/clone/copy_resource_events_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/deprovision_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' + - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/identity_linker_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' - 'ee/spec/lib/gitlab/auth/o_auth/user_spec.rb' @@ -75,6 +77,7 @@ RSpec/ExpectChange: - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - 'ee/spec/models/dast/profile_schedule_spec.rb' - 'ee/spec/models/dast_site_spec.rb' + - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'ee/spec/models/ee/event_spec.rb' - 'ee/spec/models/ee/lfs_object_spec.rb' - 'ee/spec/models/ee/merge_request_diff_spec.rb' @@ -96,6 +99,7 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/epic_issues_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' + - 'ee/spec/requests/api/graphql/audit_events/streaming/headers/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' @@ -108,6 +112,7 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/graphql/mutations/dast_site_validations/revoke_spec.rb' - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/update_requirement_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'ee/spec/requests/api/group_push_rule_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' - 'ee/spec/requests/api/invitations_spec.rb' @@ -121,6 +126,7 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/todos_spec.rb' - 'ee/spec/requests/api/users_spec.rb' - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' + - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb' @@ -135,6 +141,9 @@ RSpec/ExpectChange: - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb' - 'ee/spec/services/approval_rules/update_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/create_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/destroy_service_spec.rb' + - 'ee/spec/services/audit_events/streaming/headers/update_service_spec.rb' - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - 'ee/spec/services/boards/epics/create_service_spec.rb' @@ -146,14 +155,17 @@ RSpec/ExpectChange: - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/destroy_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' + - 'ee/spec/services/deploy_keys/create_service_spec.rb' - 'ee/spec/services/deployments/approval_service_spec.rb' - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' + - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' + - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - 'ee/spec/services/ee/members/create_service_spec.rb' - 'ee/spec/services/ee/members/destroy_service_spec.rb' - 'ee/spec/services/ee/members/invite_service_spec.rb' @@ -163,6 +175,7 @@ RSpec/ExpectChange: - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/projects/deploy_tokens/destroy_service_spec.rb' - 'ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb' + - 'ee/spec/services/ee/two_factor/destroy_service_spec.rb' - 'ee/spec/services/ee/users/approve_service_spec.rb' - 'ee/spec/services/ee/users/block_service_spec.rb' - 'ee/spec/services/ee/users/reject_service_spec.rb' @@ -196,8 +209,12 @@ RSpec/ExpectChange: - 'ee/spec/services/keys/create_service_spec.rb' - 'ee/spec/services/lfs/lock_file_service_spec.rb' - 'ee/spec/services/lfs/unlock_file_service_spec.rb' + - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' + - 'ee/spec/services/namespaces/free_user_cap/update_prevent_sharing_outside_hierarchy_service_spec.rb' + - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb' + - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/import_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' @@ -215,6 +232,7 @@ RSpec/ExpectChange: - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - 'ee/spec/services/security/override_uuids_service_spec.rb' + - 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb' - 'ee/spec/services/security/store_scan_service_spec.rb' - 'ee/spec/services/start_pull_mirroring_service_spec.rb' - 'ee/spec/services/system_notes/epics_service_spec.rb' @@ -235,16 +253,15 @@ RSpec/ExpectChange: - 'ee/spec/support/shared_examples/services/update_issuable_health_status_shared_examples.rb' - 'ee/spec/tasks/geo/git_rake_spec.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' + - 'ee/spec/workers/ee/projects/inactive_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker_spec.rb' - 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'spec/controllers/admin/clusters_controller_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/admin/spam_logs_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/controllers/groups/clusters_controller_spec.rb' - 'spec/controllers/groups/runners_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/import/bitbucket_controller_spec.rb' @@ -254,7 +271,6 @@ RSpec/ExpectChange: - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/profiles/gpg_keys_controller_spec.rb' - 'spec/controllers/profiles/keys_controller_spec.rb' - - 'spec/controllers/projects/clusters_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' @@ -277,7 +293,6 @@ RSpec/ExpectChange: - 'spec/features/groups/import_export/import_file_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/invites_spec.rb' - - 'spec/features/profiles/personal_access_tokens_spec.rb' - 'spec/features/projects/import_export/import_file_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/users/signup_spec.rb' @@ -294,11 +309,13 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/auth/saml/identity_linker_spec.rb' - 'spec/lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_projects_with_coverage_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' + - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' @@ -314,6 +331,7 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/config/entry/validatable_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' - 'spec/lib/gitlab/database/async_indexes/index_creator_spec.rb' + - 'spec/lib/gitlab/database/async_indexes/index_destructor_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' @@ -325,6 +343,8 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' - 'spec/lib/gitlab/git_access_project_spec.rb' + - 'spec/lib/gitlab/github_import/importer/events/changed_assignee_spec.rb' + - 'spec/lib/gitlab/github_import/importer/events/renamed_spec.rb' - 'spec/lib/gitlab/github_import/importer/releases_importer_spec.rb' - 'spec/lib/gitlab/hashed_storage/migrator_spec.rb' - 'spec/lib/gitlab/import/merge_request_creator_spec.rb' @@ -353,7 +373,9 @@ RSpec/ExpectChange: - 'spec/migrations/20220124130028_dedup_runner_projects_spec.rb' - 'spec/migrations/20220202105733_delete_service_template_records_spec.rb' - 'spec/migrations/20220222192525_remove_null_releases_spec.rb' + - 'spec/migrations/20220629184402_unset_escalation_policies_for_alert_incidents_spec.rb' - 'spec/migrations/backfill_cycle_analytics_aggregations_spec.rb' + - 'spec/migrations/bulk_insert_cluster_enabled_grants_spec.rb' - 'spec/migrations/cleanup_after_add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - 'spec/migrations/cleanup_after_fixing_regression_with_new_users_emails_spec.rb' @@ -363,6 +385,7 @@ RSpec/ExpectChange: - 'spec/models/alert_management/alert_spec.rb' - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' - 'spec/models/analytics/cycle_analytics/stage_event_hash_spec.rb' + - 'spec/models/application_setting_spec.rb' - 'spec/models/broadcast_message_spec.rb' - 'spec/models/chat_name_spec.rb' - 'spec/models/ci/bridge_spec.rb' @@ -375,8 +398,6 @@ RSpec/ExpectChange: - 'spec/models/ci/ref_spec.rb' - 'spec/models/ci/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - - 'spec/models/commit_signatures/gpg_signature_spec.rb' - - 'spec/models/commit_signatures/x509_commit_signature_spec.rb' - 'spec/models/commit_status_spec.rb' - 'spec/models/concerns/atomic_internal_id_spec.rb' - 'spec/models/concerns/bulk_insert_safe_spec.rb' @@ -384,6 +405,7 @@ RSpec/ExpectChange: - 'spec/models/concerns/delete_with_limit_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/concerns/require_email_verification_spec.rb' - 'spec/models/concerns/resolvable_discussion_spec.rb' - 'spec/models/concerns/resolvable_note_spec.rb' - 'spec/models/concerns/routable_spec.rb' @@ -449,7 +471,6 @@ RSpec/ExpectChange: - 'spec/requests/api/projects_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/system_hooks_spec.rb' - 'spec/requests/api/users_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/import/gitlab_groups_controller_spec.rb' @@ -504,6 +525,7 @@ RSpec/ExpectChange: - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issues/close_service_spec.rb' - 'spec/services/issues/create_service_spec.rb' + - 'spec/services/issues/import_csv_service_spec.rb' - 'spec/services/issues/move_service_spec.rb' - 'spec/services/issues/reopen_service_spec.rb' - 'spec/services/issues/update_service_spec.rb' @@ -526,6 +548,7 @@ RSpec/ExpectChange: - 'spec/services/notes/create_service_spec.rb' - 'spec/services/notes/destroy_service_spec.rb' - 'spec/services/notes/quick_actions_service_spec.rb' + - 'spec/services/packages/cleanup/update_policy_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/mark_package_for_destruction_service_spec.rb' - 'spec/services/packages/update_package_file_service_spec.rb' @@ -534,7 +557,6 @@ RSpec/ExpectChange: - 'spec/services/pages_domains/retry_acme_order_service_spec.rb' - 'spec/services/personal_access_tokens/last_used_service_spec.rb' - 'spec/services/projects/auto_devops/disable_service_spec.rb' - - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/fetch_statistics_increment_service_spec.rb' - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' @@ -562,6 +584,7 @@ RSpec/ExpectChange: - 'spec/services/todos/destroy/group_private_service_spec.rb' - 'spec/services/todos/destroy/project_private_service_spec.rb' - 'spec/services/todos/destroy/unauthorized_features_service_spec.rb' + - 'spec/services/uploads/destroy_service_spec.rb' - 'spec/services/users/approve_service_spec.rb' - 'spec/services/users/ban_service_spec.rb' - 'spec/services/users/batch_status_cleaner_service_spec.rb' @@ -571,7 +594,7 @@ RSpec/ExpectChange: - 'spec/services/users/update_highest_member_role_service_spec.rb' - 'spec/services/users/update_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - - 'spec/services/web_hooks/destroy_service_spec.rb' + - 'spec/services/work_items/parent_links/create_service_spec.rb' - 'spec/support/services/deploy_token_shared_examples.rb' - 'spec/support/services/issuable_import_csv_service_shared_examples.rb' - 'spec/support/shared_contexts/email_shared_context.rb' @@ -581,6 +604,7 @@ RSpec/ExpectChange: - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - 'spec/support/shared_examples/incident_management/issuable_escalation_statuses/build_examples.rb' - 'spec/support/shared_examples/loose_foreign_keys/have_loose_foreign_key.rb' + - 'spec/support/shared_examples/models/commit_signature_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/bulk_insert_safe_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/can_move_repository_storage_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/cron_schedulable_shared_examples.rb' @@ -613,6 +637,7 @@ RSpec/ExpectChange: - 'spec/workers/destroy_pages_deployments_worker_spec.rb' - 'spec/workers/environments/auto_delete_cron_worker_spec.rb' - 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb' + - 'spec/workers/gitlab_service_ping_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - 'spec/workers/new_issue_worker_spec.rb' @@ -627,3 +652,4 @@ RSpec/ExpectChange: - 'spec/workers/update_highest_role_worker_spec.rb' - 'spec/workers/user_status_cleanup/batch_worker_spec.rb' - 'spec/workers/users/create_statistics_worker_spec.rb' + - 'spec/workers/web_hooks/log_destroy_worker_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index cd73b76b14e..d138ea806f8 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -1,8 +1,5 @@ --- RSpec/ExpectInHook: - # Offense count: 1074 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' @@ -13,11 +10,15 @@ RSpec/ExpectInHook: - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/features/boards/new_issue_spec.rb' - 'ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - 'ee/spec/features/registrations/combined_registration_spec.rb' + - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/features/registrations/trial_during_signup_flow_spec.rb' - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' @@ -29,10 +30,14 @@ RSpec/ExpectInHook: - 'ee/spec/graphql/mutations/gitlab_subscriptions/activate_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' + - 'ee/spec/helpers/ee/groups_helper_spec.rb' + - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/kerberos_spnego_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' + - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/gon_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' @@ -44,7 +49,6 @@ RSpec/ExpectInHook: - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/generator_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' @@ -57,14 +61,15 @@ RSpec/ExpectInHook: - 'ee/spec/models/concerns/geo/replicable_model_spec.rb' - 'ee/spec/models/container_repository_spec.rb' - 'ee/spec/models/dora/daily_metrics_spec.rb' + - 'ee/spec/models/ee/namespace/storage/notification_spec.rb' - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/member_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/presenters/group_member_presenter_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' - - 'ee/spec/requests/api/graphql/ci/runner_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/groups/analytics/devops_adoption_controller_spec.rb' - 'ee/spec/requests/omniauth_kerberos_spnego_spec.rb' @@ -74,26 +79,32 @@ RSpec/ExpectInHook: - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - 'ee/spec/services/ci/runners/assign_runner_service_spec.rb' - 'ee/spec/services/ci/runners/register_runner_service_spec.rb' + - 'ee/spec/services/ci/runners/reset_registration_token_service_spec.rb' - 'ee/spec/services/ci/runners/unassign_runner_service_spec.rb' - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' - 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' - - 'ee/spec/services/ee/post_receive_service_spec.rb' - 'ee/spec/services/ee/protected_branches/destroy_service_spec.rb' - 'ee/spec/services/geo/blob_download_service_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' - - 'ee/spec/services/members/activate_service_spec.rb' + - 'ee/spec/services/members/await_service_spec.rb' - 'ee/spec/services/merge_requests/approval_service_spec.rb' + - 'ee/spec/services/merge_requests/mergeability/check_approved_service_spec.rb' + - 'ee/spec/services/merge_requests/mergeability/check_blocked_by_other_mrs_service_spec.rb' + - 'ee/spec/services/merge_requests/mergeability/check_denied_policies_service_spec.rb' - 'ee/spec/services/projects/create_from_template_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - 'ee/spec/services/security/findings/cleanup_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' + - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/elastic/cannot_read_cross_project_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' @@ -112,11 +123,13 @@ RSpec/ExpectInHook: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/composer_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_to_secondary_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' + - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb' @@ -153,13 +166,11 @@ RSpec/ExpectInHook: - 'spec/features/file_uploads/maven_package_spec.rb' - 'spec/features/groups/container_registry_spec.rb' - 'spec/features/groups/group_settings_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_hint_spec.rb' - 'spec/features/markdown/markdown_spec.rb' - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb' - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/features/oauth_login_spec.rb' - 'spec/features/profiles/password_spec.rb' - - 'spec/features/projects/clusters/gcp_spec.rb' - 'spec/features/projects/container_registry_spec.rb' - 'spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'spec/features/projects/files/user_creates_files_spec.rb' @@ -172,17 +183,20 @@ RSpec/ExpectInHook: - 'spec/features/users/login_spec.rb' - 'spec/graphql/mutations/design_management/move_spec.rb' - 'spec/helpers/commits_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' - 'spec/helpers/invite_members_helper_spec.rb' - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - - 'spec/initializers/omniauth_spec.rb' + - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/validate_database_config_spec.rb' - 'spec/lib/api/entities/merge_request_changes_spec.rb' - 'spec/lib/api/helpers/variables_helpers_spec.rb' - 'spec/lib/api/helpers_spec.rb' - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/banzai/reference_redactor_spec.rb' + - 'spec/lib/bulk_imports/common/extractors/json_extractor_spec.rb' + - 'spec/lib/bulk_imports/common/extractors/ndjson_extractor_spec.rb' - 'spec/lib/bulk_imports/ndjson_pipeline_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/file_size_validator_spec.rb' @@ -207,7 +221,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' - - 'spec/lib/gitlab/ci/trace/archive_spec.rb' - 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb' @@ -216,14 +229,18 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/contributions_calendar_spec.rb' - 'spec/lib/gitlab/current_settings_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' + - 'spec/lib/gitlab/database/background_migration/health_status_spec.rb' - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/runner_spec.rb' + - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning_spec.rb' + - 'spec/lib/gitlab/database/postgres_autovacuum_activity_spec.rb' - 'spec/lib/gitlab/database/query_analyzer_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' @@ -251,10 +268,12 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/health_checks/gitaly_check_spec.rb' - 'spec/lib/gitlab/health_checks/probes/collection_spec.rb' - 'spec/lib/gitlab/health_checks/puma_check_spec.rb' + - 'spec/lib/gitlab/health_checks/server_spec.rb' - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_object_saver_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' + - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/import_failure_service_spec.rb' - 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb' @@ -271,12 +290,14 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' + - 'spec/lib/gitlab/memory/jemalloc_spec.rb' - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' - 'spec/lib/gitlab/metrics/exporter/metrics_middleware_spec.rb' - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' - 'spec/lib/gitlab/middleware/memory_report_spec.rb' - 'spec/lib/gitlab/middleware/multipart_spec.rb' - 'spec/lib/gitlab/omniauth_initializer_spec.rb' + - 'spec/lib/gitlab/pages/deployment_update_spec.rb' - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' - 'spec/lib/gitlab/patch/database_config_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' @@ -338,6 +359,7 @@ RSpec/ExpectInHook: - 'spec/models/ssh_host_key_spec.rb' - 'spec/models/user_spec.rb' - 'spec/policies/ci/bridge_policy_spec.rb' + - 'spec/policies/project_policy_spec.rb' - 'spec/presenters/ci/build_presenter_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' - 'spec/presenters/commit_presenter_spec.rb' @@ -352,6 +374,7 @@ RSpec/ExpectInHook: - 'spec/requests/api/graphql/mutations/jira_import/import_users_spec.rb' - 'spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb' - 'spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb' + - 'spec/requests/api/graphql/terraform/state/delete_spec.rb' - 'spec/requests/api/graphql/terraform/state/lock_spec.rb' - 'spec/requests/api/graphql/terraform/state/unlock_spec.rb' - 'spec/requests/api/group_export_spec.rb' @@ -375,6 +398,7 @@ RSpec/ExpectInHook: - 'spec/rubocop/cop/performance/ar_count_each_spec.rb' - 'spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb' - 'spec/scripts/setup/find_jh_branch_spec.rb' + - 'spec/scripts/trigger-build_spec.rb' - 'spec/serializers/diffs_metadata_entity_spec.rb' - 'spec/serializers/merge_request_diff_entity_spec.rb' - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' @@ -406,6 +430,7 @@ RSpec/ExpectInHook: - 'spec/services/design_management/save_designs_service_spec.rb' - 'spec/services/discussions/capture_diff_note_position_service_spec.rb' - 'spec/services/environments/reset_auto_stop_service_spec.rb' + - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/git/base_hooks_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' - 'spec/services/git/wiki_push_service/change_spec.rb' @@ -434,6 +459,7 @@ RSpec/ExpectInHook: - 'spec/services/notes/quick_actions_service_spec.rb' - 'spec/services/notification_recipients/builder/default_spec.rb' - 'spec/services/notification_recipients/builder/new_note_spec.rb' + - 'spec/services/packages/cleanup/execute_policy_service_spec.rb' - 'spec/services/packages/debian/process_changes_service_spec.rb' - 'spec/services/packages/generic/create_package_file_service_spec.rb' - 'spec/services/packages/helm/extract_file_metadata_service_spec.rb' @@ -465,7 +491,6 @@ RSpec/ExpectInHook: - 'spec/services/protected_branches/create_service_spec.rb' - 'spec/services/protected_branches/destroy_service_spec.rb' - 'spec/services/protected_branches/update_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/search_service_spec.rb' - 'spec/services/serverless/associate_domain_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' @@ -481,6 +506,7 @@ RSpec/ExpectInHook: - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/database/reestablished_connection_stack_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/diff_file_collections_shared_examples.rb' - 'spec/support/shared_examples/lib/wikis_api_examples.rb' - 'spec/support/shared_examples/metrics/sampler_shared_examples.rb' @@ -515,6 +541,7 @@ RSpec/ExpectInHook: - 'spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb' - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/workers/build_finished_worker_spec.rb' + - 'spec/workers/bulk_imports/pipeline_worker_spec.rb' - 'spec/workers/ci/build_finished_worker_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' - 'spec/workers/concerns/limited_capacity/job_tracker_spec.rb' @@ -525,6 +552,7 @@ RSpec/ExpectInHook: - 'spec/workers/gitlab/jira_import/stage/finish_import_worker_spec.rb' - 'spec/workers/gitlab_performance_bar_stats_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' + - 'spec/workers/incident_management/close_incident_worker_spec.rb' - 'spec/workers/integrations/create_external_cross_reference_worker_spec.rb' - 'spec/workers/packages/helm/extraction_worker_spec.rb' - 'spec/workers/packages/nuget/extraction_worker_spec.rb' diff --git a/.rubocop_todo/rspec/hooks_before_examples.yml b/.rubocop_todo/rspec/hooks_before_examples.yml new file mode 100644 index 00000000000..0de9ff4b6c0 --- /dev/null +++ b/.rubocop_todo/rspec/hooks_before_examples.yml @@ -0,0 +1,76 @@ +--- +# Cop supports --auto-correct. +RSpec/HooksBeforeExamples: + Exclude: + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_spec.rb' + - 'ee/spec/graphql/mutations/boards/epic_boards/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/escalation_policy/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/issuable_resource_link/create_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/issuable_resource_link/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/destroy_spec.rb' + - 'ee/spec/graphql/mutations/incident_management/oncall_schedule/update_spec.rb' + - 'ee/spec/graphql/mutations/issues/set_escalation_policy_spec.rb' + - 'ee/spec/graphql/types/app_sec/fuzzing/coverage/corpus_type_spec.rb' + - 'ee/spec/graphql/types/dast/profile_schedule_type_spec.rb' + - 'ee/spec/graphql/types/dast/profile_type_spec.rb' + - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' + - 'ee/spec/lib/ee/gitlab/usage_data_counters/hll_redis_counter_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb' + - 'ee/spec/models/ee/merge_request_diff_spec.rb' + - 'ee/spec/models/merge_train_spec.rb' + - 'ee/spec/requests/api/boards_spec.rb' + - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' + - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' + - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' + - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' + - 'ee/spec/services/ee/projects/deploy_tokens/destroy_service_spec.rb' + - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' + - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' + - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' + - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/user/user_inherited_access_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_fork_in_web_ide_spec.rb' + - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' + - 'qa/spec/resource/reusable_collection_spec.rb' + - 'qa/spec/specs/runner_spec.rb' + - 'spec/controllers/import/github_controller_spec.rb' + - 'spec/features/projects/pages/user_configures_pages_pipeline_spec.rb' + - 'spec/graphql/resolvers/design_management/design_resolver_spec.rb' + - 'spec/graphql/resolvers/design_management/designs_resolver_spec.rb' + - 'spec/graphql/resolvers/project_pipeline_resolver_spec.rb' + - 'spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb' + - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' + - 'spec/lib/feature/definition_spec.rb' + - 'spec/lib/gitlab/auth/saml/user_spec.rb' + - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' + - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' + - 'spec/lib/gitlab/tracking/event_definition_spec.rb' + - 'spec/lib/gitlab/usage/metric_definition_spec.rb' + - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' + - 'spec/lib/mattermost/session_spec.rb' + - 'spec/models/ci/build_trace_chunk_spec.rb' + - 'spec/models/clusters/applications/ingress_spec.rb' + - 'spec/models/clusters/applications/knative_spec.rb' + - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/serializers/pipeline_details_entity_spec.rb' + - 'spec/services/feature_flags/hook_service_spec.rb' + - 'spec/services/projects/container_repository/gitlab/delete_tags_service_spec.rb' + - 'spec/support/shared_examples/lib/gitlab/cycle_analytics/deployment_metrics.rb' diff --git a/.rubocop_todo/rspec/predicate_matcher.yml b/.rubocop_todo/rspec/predicate_matcher.yml index c6a75708ae8..7b31ca3622c 100644 --- a/.rubocop_todo/rspec/predicate_matcher.yml +++ b/.rubocop_todo/rspec/predicate_matcher.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. RSpec/PredicateMatcher: - # Offense count: 2480 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/admin/elasticsearch_controller_spec.rb' - 'ee/spec/controllers/admin/geo/projects_controller_spec.rb' @@ -11,11 +8,16 @@ RSpec/PredicateMatcher: - 'ee/spec/controllers/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/groups/ldaps_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' + - 'ee/spec/elastic/migrate/20220713103500_delete_commits_from_original_index_spec.rb' - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/projects/members/member_is_removed_from_project_spec.rb' - 'ee/spec/features/projects/mirror_spec.rb' - 'ee/spec/features/signup_spec.rb' + - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' @@ -70,6 +72,7 @@ RSpec/PredicateMatcher: - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/saml_provider_spec.rb' - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' + - 'ee/spec/presenters/ci/minutes/usage_presenter_spec.rb' - 'ee/spec/requests/api/boards_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/set_subscription_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' @@ -96,6 +99,8 @@ RSpec/PredicateMatcher: - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' - 'ee/spec/services/milestones/promote_service_spec.rb' - 'ee/spec/services/protected_environments/create_service_spec.rb' + - 'ee/spec/services/vulnerabilities/create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/findings/create_from_security_finding_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - 'ee/spec/support/shared_examples/graphql/mutations/dast_on_demand_scans_shared_examples.rb' @@ -113,7 +118,6 @@ RSpec/PredicateMatcher: - 'qa/qa/specs/features/ee/browser_ui/12_geo/database_delete_replication_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/epic/roadmap_spec.rb' - 'qa/spec/runtime/env_spec.rb' - - 'qa/spec/runtime/feature_spec.rb' - 'qa/spec/specs/helpers/context_selector_spec.rb' - 'spec/components/diffs/overflow_warning_component_spec.rb' - 'spec/controllers/admin/dev_ops_report_controller_spec.rb' @@ -123,6 +127,7 @@ RSpec/PredicateMatcher: - 'spec/controllers/concerns/checks_collaboration_spec.rb' - 'spec/controllers/groups/avatars_controller_spec.rb' - 'spec/controllers/groups/clusters_controller_spec.rb' + - 'spec/controllers/groups/group_links_controller_spec.rb' - 'spec/controllers/groups/group_members_controller_spec.rb' - 'spec/controllers/groups/settings/applications_controller_spec.rb' - 'spec/controllers/omniauth_callbacks_controller_spec.rb' @@ -157,7 +162,6 @@ RSpec/PredicateMatcher: - 'spec/features/unsubscribe_links_spec.rb' - 'spec/features/users/signup_spec.rb' - 'spec/finders/group_descendants_finder_spec.rb' - - 'spec/finders/issues_finder_spec.rb' - 'spec/finders/merge_request_target_project_finder_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' @@ -169,6 +173,7 @@ RSpec/PredicateMatcher: - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/recaptcha_helper_spec.rb' - 'spec/helpers/sessions_helper_spec.rb' + - 'spec/helpers/sorting_helper_spec.rb' - 'spec/lib/backup/files_spec.rb' - 'spec/lib/bitbucket/connection_spec.rb' - 'spec/lib/bitbucket/page_spec.rb' @@ -260,7 +265,6 @@ RSpec/PredicateMatcher: - 'spec/lib/gitlab/fake_application_settings_spec.rb' - 'spec/lib/gitlab/git/blob_spec.rb' - 'spec/lib/gitlab/git/branch_spec.rb' - - 'spec/lib/gitlab/git/commit_spec.rb' - 'spec/lib/gitlab/git/keep_around_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' @@ -273,6 +277,7 @@ RSpec/PredicateMatcher: - 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb' - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' - 'spec/lib/gitlab/gpg/commit_spec.rb' + - 'spec/lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer_spec.rb' - 'spec/lib/gitlab/hashed_storage/migrator_spec.rb' - 'spec/lib/gitlab/i18n/translation_entry_spec.rb' - 'spec/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy_spec.rb' @@ -308,6 +313,7 @@ RSpec/PredicateMatcher: - 'spec/lib/gitlab/user_access_snippet_spec.rb' - 'spec/lib/gitlab/user_access_spec.rb' - 'spec/lib/gitlab/utils/sanitize_node_link_spec.rb' + - 'spec/lib/gitlab/version_info_spec.rb' - 'spec/lib/gitlab/view/presenter/base_spec.rb' - 'spec/lib/gitlab/visibility_level_spec.rb' - 'spec/lib/object_storage/direct_upload_spec.rb' @@ -400,7 +406,6 @@ RSpec/PredicateMatcher: - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/project_clusters_spec.rb' - 'spec/requests/api/project_export_spec.rb' - - 'spec/requests/api/project_hooks_spec.rb' - 'spec/requests/api/project_snippets_spec.rb' - 'spec/requests/api/projects_spec.rb' - 'spec/requests/api/resource_access_tokens_spec.rb' @@ -425,11 +430,13 @@ RSpec/PredicateMatcher: - 'spec/services/container_expiration_policies/update_service_spec.rb' - 'spec/services/customer_relations/contacts/update_service_spec.rb' - 'spec/services/customer_relations/organizations/update_service_spec.rb' + - 'spec/services/deployments/create_for_build_service_spec.rb' - 'spec/services/deployments/older_deployments_drop_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' - 'spec/services/groups/destroy_service_spec.rb' - 'spec/services/groups/group_links/create_service_spec.rb' + - 'spec/services/groups/group_links/destroy_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' - 'spec/services/issuable/bulk_update_service_spec.rb' @@ -449,6 +456,7 @@ RSpec/PredicateMatcher: - 'spec/services/note_summary_spec.rb' - 'spec/services/notes/build_service_spec.rb' - 'spec/services/notes/quick_actions_service_spec.rb' + - 'spec/services/packages/cleanup/update_policy_service_spec.rb' - 'spec/services/packages/debian/find_or_create_incoming_service_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/projects/after_rename_service_spec.rb' @@ -478,6 +486,7 @@ RSpec/PredicateMatcher: - 'spec/services/users/destroy_service_spec.rb' - 'spec/support/shared_contexts/email_shared_context.rb' - 'spec/support/shared_examples/ci/auto_merge_merge_requests_shared_examples.rb' + - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_core_shared_examples.rb' @@ -486,6 +495,7 @@ RSpec/PredicateMatcher: - 'spec/support/shared_examples/models/member_shared_examples.rb' - 'spec/support/shared_examples/models/note_access_check_shared_examples.rb' - 'spec/support/shared_examples/requests/access_tokens_controller_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb' - 'spec/tasks/gitlab/backup_rake_spec.rb' @@ -497,12 +507,13 @@ RSpec/PredicateMatcher: - 'spec/validators/namespace_path_validator_spec.rb' - 'spec/validators/project_path_validator_spec.rb' - 'spec/workers/bulk_imports/entity_worker_spec.rb' + - 'spec/workers/bulk_imports/pipeline_worker_spec.rb' - 'spec/workers/ci/delete_objects_worker_spec.rb' - - 'spec/workers/concerns/worker_attributes_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - 'spec/workers/group_destroy_worker_spec.rb' - 'spec/workers/hashed_storage/migrator_worker_spec.rb' - 'spec/workers/hashed_storage/rollbacker_worker_spec.rb' - 'spec/workers/project_destroy_worker_spec.rb' - 'spec/workers/remote_mirror_notification_worker_spec.rb' + - 'spec/workers/remove_expired_group_links_worker_spec.rb' - 'spec/workers/x509_issuer_crl_check_worker_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml index b5c4ac090ae..31c17c994a6 100644 --- a/.rubocop_todo/rspec/repeated_example_group_description.yml +++ b/.rubocop_todo/rspec/repeated_example_group_description.yml @@ -44,7 +44,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'spec/features/security/project/private_access_spec.rb' - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - - 'spec/frontend/fixtures/runner.rb' - 'spec/frontend/fixtures/startup_css.rb' - 'spec/helpers/admin/user_actions_helper_spec.rb' - 'spec/helpers/dropdowns_helper_spec.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 21cd26a0a6f..215660f31d3 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. RSpec/ReturnFromStub: - # Offense count: 703 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/controllers/admin/geo/nodes_controller_spec.rb' - 'ee/spec/controllers/groups/billings_controller_spec.rb' @@ -18,6 +15,7 @@ RSpec/ReturnFromStub: - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - 'ee/spec/features/projects/milestones/milestone_spec.rb' - 'ee/spec/features/projects/new_project_spec.rb' + - 'ee/spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - 'ee/spec/features/promotion_spec.rb' @@ -39,9 +37,9 @@ RSpec/ReturnFromStub: - 'ee/spec/lib/ee/feature_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/database_spec.rb' + - 'ee/spec/lib/ee/gitlab/git_access_project_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/build_consumption_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - - 'ee/spec/lib/gitlab/code_owners_spec.rb' - 'ee/spec/lib/gitlab/geo/health_check_spec.rb' - 'ee/spec/lib/gitlab/geo/logger_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' @@ -62,6 +60,7 @@ RSpec/ReturnFromStub: - 'ee/spec/presenters/ci/build_presenter_spec.rb' - 'ee/spec/presenters/merge_request_presenter_spec.rb' - 'ee/spec/requests/admin/credentials_controller_spec.rb' + - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' @@ -88,6 +87,7 @@ RSpec/ReturnFromStub: - 'ee/spec/support/shared_examples/services/geo_event_store_shared_examples.rb' - 'ee/spec/support/shared_examples/services/merge_merge_requests_shared_examples.rb' - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' + - 'ee/spec/views/admin/application_settings/_git_abuse_rate_limit.html.haml_spec.rb' - 'ee/spec/views/admin/groups/_form.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' @@ -191,13 +191,15 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/instrumentation/redis_base_spec.rb' - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' - - 'spec/lib/gitlab/metrics/rails_slis_spec.rb' + - 'spec/lib/gitlab/memory/reports_daemon_spec.rb' - 'spec/lib/gitlab/metrics/system_spec.rb' - 'spec/lib/gitlab/middleware/read_only_spec.rb' - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' - 'spec/lib/gitlab/prometheus_client_spec.rb' - 'spec/lib/gitlab/redis/cache_spec.rb' + - 'spec/lib/gitlab/redis/duplicate_jobs_spec.rb' - 'spec/lib/gitlab/redis/shared_state_spec.rb' + - 'spec/lib/gitlab/redis/sidekiq_status_spec.rb' - 'spec/lib/gitlab/relative_positioning/range_spec.rb' - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 069f9a15fff..93f373b0a9e 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. RSpec/ScatteredLet: - # Offense count: 720 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'ee/spec/features/groups/group_roadmap_spec.rb' - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb' @@ -19,10 +16,10 @@ RSpec/ScatteredLet: - 'ee/spec/graphql/types/instance_security_dashboard_type_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/trial_status_widget_helper_spec.rb' - - 'ee/spec/lib/banzai/reference_parser/iteration_parser_spec.rb' - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config_spec.rb' - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' + - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/formatters/dependency_list_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb' @@ -44,7 +41,6 @@ RSpec/ScatteredLet: - 'ee/spec/models/ci/minutes/notification_spec.rb' - 'ee/spec/models/ci/pipeline_spec.rb' - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - - 'ee/spec/models/ee/namespace/root_storage_size_spec.rb' - 'ee/spec/models/label_note_spec.rb' - 'ee/spec/models/sca/license_compliance_spec.rb' - 'ee/spec/policies/merge_request_policy_spec.rb' @@ -62,9 +58,12 @@ RSpec/ScatteredLet: - 'ee/spec/requests/api/graphql/project/pipelines/dast_profile_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/api/projects_spec.rb' + - 'ee/spec/requests/api/settings_spec.rb' - 'ee/spec/requests/api/vulnerability_findings_spec.rb' - 'ee/spec/requests/git_http_geo_spec.rb' + - 'ee/spec/serializers/license_compliance/collapsed_comparer_entity_spec.rb' - 'ee/spec/serializers/status_page/incident_serializer_spec.rb' + - 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb' - 'ee/spec/services/app_sec/dast/scanner_profiles/update_service_spec.rb' - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - 'ee/spec/services/arkose/user_verification_service_spec.rb' @@ -88,13 +87,13 @@ RSpec/ScatteredLet: - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb' - 'ee/spec/services/search/group_service_spec.rb' - 'ee/spec/services/search/project_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/workers/compliance_management/merge_requests/compliance_violations_worker_spec.rb' - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - 'spec/controllers/projects/environments_controller_spec.rb' @@ -126,14 +125,19 @@ RSpec/ScatteredLet: - 'spec/lib/banzai/reference_parser/project_parser_spec.rb' - 'spec/lib/banzai/reference_parser/snippet_parser_spec.rb' - 'spec/lib/banzai/reference_parser/user_parser_spec.rb' + - 'spec/lib/bulk_imports/pipeline/runner_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb' - 'spec/lib/gitlab/asciidoc/include_processor_spec.rb' - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans_spec.rb' + - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' + - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' + - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb' @@ -162,6 +166,7 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/git/blame_spec.rb' - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git_access_spec.rb' + - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_events_importer_spec.rb' - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' - 'spec/lib/gitlab/import_export/group/relation_tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/export_task_spec.rb' @@ -182,7 +187,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/spamcheck/client_spec.rb' - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/lib/gitlab/usage_data_metrics_spec.rb' - 'spec/lib/gitlab/utils/measuring_spec.rb' - 'spec/lib/gitlab/zentao/client_spec.rb' @@ -236,6 +240,7 @@ RSpec/ScatteredLet: - 'spec/requests/api/project_clusters_spec.rb' - 'spec/requests/api/project_export_spec.rb' - 'spec/requests/api/rubygem_packages_spec.rb' + - 'spec/requests/jira_routing_spec.rb' - 'spec/requests/projects/releases_controller_spec.rb' - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/scripts/pipeline_test_report_builder_spec.rb' @@ -277,6 +282,8 @@ RSpec/ScatteredLet: - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/system_notes/merge_requests_service_spec.rb' - 'spec/services/todo_service_spec.rb' + - 'spec/services/web_hook_service_spec.rb' + - 'spec/services/work_items/update_service_spec.rb' - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb' - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 84e862ff48b..70b54d5bc7f 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -210,6 +210,7 @@ RSpec/VerifiedDoubles: - ee/spec/views/layouts/header/_ee_subscribable_banner.html.haml_spec.rb - ee/spec/workers/ci/sync_reports_to_report_approval_rules_worker_spec.rb - ee/spec/workers/geo/container_repository_sync_worker_spec.rb + - ee/spec/workers/compliance_management/chain_of_custody_report_worker_spec.rb - ee/spec/workers/geo/design_repository_sync_worker_spec.rb - ee/spec/workers/geo/destroy_worker_spec.rb - ee/spec/workers/geo/event_worker_spec.rb diff --git a/.rubocop_todo/style/array_coercion.yml b/.rubocop_todo/style/array_coercion.yml deleted file mode 100644 index a49fc42967d..00000000000 --- a/.rubocop_todo/style/array_coercion.yml +++ /dev/null @@ -1,10 +0,0 @@ ---- -# Cop supports --auto-correct. -Style/ArrayCoercion: - Exclude: - - 'app/controllers/admin/ci/variables_controller.rb' - - 'app/controllers/groups/variables_controller.rb' - - 'app/controllers/projects/variables_controller.rb' - - 'ee/app/services/geo/repository_verification_secondary_service.rb' - - 'ee/lib/ee/banzai/pipeline/gfm_pipeline.rb' - - 'spec/support/helpers/lfs_http_helpers.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index fab05667adb..e0747f232a1 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -292,6 +292,7 @@ Style/ClassAndModuleChildren: - 'app/models/merge_request/metrics.rb' - 'app/models/namespace/admin_note.rb' - 'app/models/namespace/aggregation_schedule.rb' + - 'app/models/namespace/detail.rb' - 'app/models/namespace/package_setting.rb' - 'app/models/namespace/root_storage_statistics.rb' - 'app/models/namespaces/sync_event.rb' @@ -478,8 +479,6 @@ Style/ClassAndModuleChildren: - 'ee/app/models/concerns/geo/syncable.rb' - 'ee/app/models/dast/profile_schedule.rb' - 'ee/app/models/ee/ci/job_artifact.rb' - - 'ee/app/models/ee/namespace/root_excess_storage_size.rb' - - 'ee/app/models/ee/namespace/root_storage_size.rb' - 'ee/app/models/elastic/reindexing_slice.rb' - 'ee/app/models/elastic/reindexing_subtask.rb' - 'ee/app/models/elastic/reindexing_task.rb' diff --git a/.rubocop_todo/style/empty_else.yml b/.rubocop_todo/style/empty_else.yml index ed840856e19..f211d022dcd 100644 --- a/.rubocop_todo/style/empty_else.yml +++ b/.rubocop_todo/style/empty_else.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Style/EmptyElse: - # Offense count: 59 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/concerns/issuable_collections_action.rb' - 'app/controllers/concerns/sends_blob.rb' @@ -15,8 +12,8 @@ Style/EmptyElse: - 'app/graphql/mutations/concerns/mutations/spam_protection.rb' - 'app/graphql/resolvers/group_milestones_resolver.rb' - 'app/graphql/types/ci/detailed_status_type.rb' + - 'app/graphql/types/packages/package_base_type.rb' - 'app/graphql/types/packages/package_file_type.rb' - - 'app/graphql/types/packages/package_type.rb' - 'app/helpers/submodule_helper.rb' - 'app/models/commit.rb' - 'app/models/legacy_diff_discussion.rb' @@ -27,6 +24,7 @@ Style/EmptyElse: - 'app/models/resource_timebox_event.rb' - 'app/services/award_emojis/add_service.rb' - 'app/services/merge_requests/update_service.rb' + - 'app/workers/gitlab/github_import/stage/import_issue_events_worker.rb' - 'app/workers/post_receive.rb' - 'config/initializers/doorkeeper_openid_connect.rb' - 'ee/app/controllers/admin/audit_logs_controller.rb' @@ -38,13 +36,14 @@ Style/EmptyElse: - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/gitlab_subscriptions/check_future_renewal_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - - 'ee/app/workers/audit_events/audit_event_streaming_worker.rb' - 'ee/app/workers/gitlab_subscriptions/notify_seats_exceeded_worker.rb' - 'ee/db/fixtures/development/20_vulnerabilities.rb' - 'ee/lib/elastic/latest/note_instance_proxy.rb' + - 'ee/lib/gitlab/analytics/cycle_analytics/summary/change_failure_rate.rb' - 'ee/lib/gitlab/geo/oauth/logout_token.rb' - 'lib/api/subscriptions.rb' - 'lib/gitlab/auth/o_auth/provider.rb' + - 'lib/gitlab/ci/variables/collection.rb' - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb' - 'lib/gitlab/database/sha256_attribute.rb' - 'lib/gitlab/diff/parser.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index e5ce2576f8c..63b7b5d387d 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -100,7 +100,6 @@ Style/ExplicitBlockArgument: - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/support/helpers/feature_flag_helpers.rb' - - 'spec/support/helpers/features/runner_helpers.rb' - 'spec/support/helpers/features/top_nav_spec_helpers.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/helpers/modal_helpers.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index caa293b31ae..bb95d8f7fe9 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Style/FormatString: - # Offense count: 769 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/components/diffs/overflow_warning_component.rb' - 'app/controllers/admin/application_settings_controller.rb' @@ -21,6 +18,7 @@ Style/FormatString: - 'app/controllers/concerns/membership_actions.rb' - 'app/controllers/concerns/redirects_for_missing_path_on_tree.rb' - 'app/controllers/concerns/spammable_actions/akismet_mark_as_spam_action.rb' + - 'app/controllers/concerns/verifies_with_email.rb' - 'app/controllers/groups/settings/ci_cd_controller.rb' - 'app/controllers/import/bitbucket_server_controller.rb' - 'app/controllers/import/bulk_imports_controller.rb' @@ -37,6 +35,8 @@ Style/FormatString: - 'app/controllers/profiles/preferences_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - 'app/controllers/profiles_controller.rb' + - 'app/controllers/projects/google_cloud/deployments_controller.rb' + - 'app/controllers/projects/google_cloud/service_accounts_controller.rb' - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/merge_requests_controller.rb' - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' @@ -56,15 +56,18 @@ Style/FormatString: - 'app/helpers/colors_helper.rb' - 'app/helpers/emails_helper.rb' - 'app/helpers/form_helper.rb' + - 'app/helpers/groups/group_members_helper.rb' - 'app/helpers/groups_helper.rb' - 'app/helpers/import_helper.rb' - 'app/helpers/invite_members_helper.rb' - 'app/helpers/issuables_helper.rb' - 'app/helpers/issues_helper.rb' + - 'app/helpers/members_helper.rb' - 'app/helpers/merge_requests_helper.rb' - 'app/helpers/mirror_helper.rb' - 'app/helpers/preferences_helper.rb' - 'app/helpers/profiles_helper.rb' + - 'app/helpers/projects/project_members_helper.rb' - 'app/helpers/projects_helper.rb' - 'app/helpers/registrations_helper.rb' - 'app/helpers/reminder_emails_helper.rb' @@ -83,6 +86,7 @@ Style/FormatString: - 'app/mailers/emails/profile.rb' - 'app/models/application_setting.rb' - 'app/models/application_setting_implementation.rb' + - 'app/models/concerns/integrations/has_issue_tracker_fields.rb' - 'app/models/concerns/limitable.rb' - 'app/models/concerns/metric_image_uploading.rb' - 'app/models/concerns/spammable.rb' @@ -108,17 +112,21 @@ Style/FormatString: - 'app/models/integrations/external_wiki.rb' - 'app/models/integrations/flowdock.rb' - 'app/models/integrations/hangouts_chat.rb' + - 'app/models/integrations/irker.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/mattermost.rb' - 'app/models/integrations/pipelines_email.rb' - 'app/models/integrations/pivotaltracker.rb' + - 'app/models/integrations/pumble.rb' - 'app/models/integrations/pushover.rb' - 'app/models/integrations/redmine.rb' - 'app/models/integrations/unify_circuit.rb' - 'app/models/integrations/webex_teams.rb' - 'app/models/integrations/youtrack.rb' - 'app/models/integrations/zentao.rb' + - 'app/models/merge_request.rb' + - 'app/models/merge_request_diff.rb' - 'app/models/milestone.rb' - 'app/models/pages_domain.rb' - 'app/models/project.rb' @@ -129,6 +137,7 @@ Style/FormatString: - 'app/models/user.rb' - 'app/models/wiki.rb' - 'app/models/wiki_page.rb' + - 'app/models/work_items/parent_link.rb' - 'app/presenters/ci/pipeline_presenter.rb' - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/project_presenter.rb' @@ -152,6 +161,7 @@ Style/FormatString: - 'app/services/gravatar_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/import/bitbucket_server_service.rb' + - 'app/services/import/fogbugz_service.rb' - 'app/services/import/github_service.rb' - 'app/services/issuable_links/create_service.rb' - 'app/services/issues/clone_service.rb' @@ -169,7 +179,10 @@ Style/FormatString: - 'app/services/projects/create_from_template_service.rb' - 'app/services/projects/import_service.rb' - 'app/services/system_notes/design_management_service.rb' + - 'app/services/timelogs/create_service.rb' - 'app/services/users/banned_user_base_service.rb' + - 'app/services/work_items/parent_links/create_service.rb' + - 'app/services/work_items/widgets/hierarchy_service/base_service.rb' - 'app/validators/addressable_url_validator.rb' - 'app/validators/any_field_validator.rb' - 'app/validators/array_members_validator.rb' @@ -180,6 +193,14 @@ Style/FormatString: - 'config/initializers/rack_lineprof.rb' - 'danger/roulette/Dangerfile' - 'ee/app/components/billing/plan_component.rb' + - 'ee/app/components/namespaces/free_user_cap/alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/personable.rb' + - 'ee/app/components/namespaces/free_user_cap/personal_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/personal_preview_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/personal_usage_quota_limitations_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/preview_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/usage_quota_trial_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/projects_controller.rb' @@ -190,6 +211,7 @@ Style/FormatString: - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' - 'ee/app/controllers/ee/repositories/lfs_api_controller.rb' - 'ee/app/controllers/groups/saml_group_links_controller.rb' + - 'ee/app/controllers/groups/settings/reporting_controller.rb' - 'ee/app/controllers/groups/sso_controller.rb' - 'ee/app/controllers/projects/requirements_management/requirements_controller.rb' - 'ee/app/controllers/subscriptions/groups_controller.rb' @@ -197,9 +219,11 @@ Style/FormatString: - 'ee/app/helpers/billing_plans_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' + - 'ee/app/helpers/ee/groups/reporting_helper.rb' - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/import_helper.rb' + - 'ee/app/helpers/ee/members_helper.rb' - 'ee/app/helpers/ee/profiles_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/timeboxes_helper.rb' @@ -207,6 +231,7 @@ Style/FormatString: - 'ee/app/helpers/groups/sso_helper.rb' - 'ee/app/helpers/trial_registrations/reassurances_helper.rb' - 'ee/app/helpers/vulnerabilities_helper.rb' + - 'ee/app/mailers/ee/emails/admin_notification.rb' - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' - 'ee/app/models/ci/minutes/notification.rb' - 'ee/app/models/dast/profile.rb' @@ -214,8 +239,10 @@ Style/FormatString: - 'ee/app/models/dast_site_profile.rb' - 'ee/app/models/dast_site_validation.rb' - 'ee/app/models/ee/member.rb' + - 'ee/app/models/ee/namespace/storage/notification.rb' - 'ee/app/models/geo/upload_registry.rb' - 'ee/app/models/integrations/github.rb' + - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/users_security_dashboard_project.rb' - 'ee/app/services/app_sec/dast/profiles/build_config_service.rb' @@ -227,6 +254,7 @@ Style/FormatString: - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' - 'ee/app/services/dora/aggregate_metrics_service.rb' - 'ee/app/services/ee/projects/create_from_template_service.rb' + - 'ee/app/services/group_saml/saml_group_links/create_service.rb' - 'ee/app/services/incident_management/escalation_policies/base_service.rb' - 'ee/app/services/issues/build_from_vulnerability_service.rb' - 'ee/app/services/merge_requests/create_from_vulnerability_data_service.rb' @@ -236,15 +264,18 @@ Style/FormatString: - 'ee/app/services/vulnerabilities/destroy_dismissal_feedback_service.rb' - 'ee/app/services/vulnerabilities/dismiss_service.rb' - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' + - 'ee/app/services/vulnerabilities/findings/create_from_security_finding_service.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' - 'ee/app/services/vulnerability_external_issue_links/create_service.rb' + - 'ee/app/validators/user_existence_validator.rb' - 'ee/lib/audit/details.rb' - 'ee/lib/ee/audit/project_changes_auditor.rb' - 'ee/lib/ee/audit/project_setting_changes_auditor.rb' - 'ee/lib/ee/gitlab/checks/push_rules/branch_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb' - 'ee/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb' + - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb' - 'ee/lib/ee/gitlab/quick_actions/epic_actions.rb' - 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb' - 'ee/lib/ee/gitlab/quick_actions/issue_and_merge_request_actions.rb' @@ -256,11 +287,13 @@ Style/FormatString: - 'ee/lib/gitlab/auth/group_saml/response_check.rb' - 'ee/lib/gitlab/expiring_subscription_message.rb' - 'ee/lib/gitlab/geo.rb' + - 'ee/lib/gitlab/licenses/submit_license_usage_data_banner.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - 'ee/lib/gitlab/vulnerabilities/container_scanning_vulnerability.rb' - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' + - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/admin/admin_users_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb' @@ -273,6 +306,7 @@ Style/FormatString: - 'lib/gitlab/ci/ansi2json/line.rb' - 'lib/gitlab/ci/badge/coverage/template.rb' - 'lib/gitlab/ci/config/entry/tags.rb' + - 'lib/gitlab/ci/parsers/sbom/cyclonedx.rb' - 'lib/gitlab/ci/status/build/waiting_for_approval.rb' - 'lib/gitlab/config_checker/external_database_checker.rb' - 'lib/gitlab/config_checker/puma_rugged_checker.rb' @@ -293,6 +327,7 @@ Style/FormatString: - 'lib/gitlab/email/message/in_product_marketing/verify.rb' - 'lib/gitlab/exceptions_app.rb' - 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb' + - 'lib/gitlab/github_import/importer/single_endpoint_issue_events_importer.rb' - 'lib/gitlab/github_import/issuable_finder.rb' - 'lib/gitlab/github_import/label_finder.rb' - 'lib/gitlab/github_import/milestone_finder.rb' @@ -307,6 +342,7 @@ Style/FormatString: - 'lib/gitlab/log_timestamp_formatter.rb' - 'lib/gitlab/metrics/dashboard/errors.rb' - 'lib/gitlab/metrics/dashboard/validator/errors.rb' + - 'lib/gitlab/pages/cache_control.rb' - 'lib/gitlab/quick_actions/command_definition.rb' - 'lib/gitlab/quick_actions/commit_actions.rb' - 'lib/gitlab/quick_actions/issuable_actions.rb' @@ -318,11 +354,11 @@ Style/FormatString: - 'lib/gitlab/version_info.rb' - 'lib/peek/views/detailed_view.rb' - 'lib/tasks/test.rake' - - 'qa/qa/service/docker_run/gitlab_runner.rb' - 'spec/controllers/graphql_controller_spec.rb' - 'spec/factories/lfs_objects.rb' - 'spec/features/admin/admin_users_spec.rb' - 'spec/features/groups/import_export/connect_instance_spec.rb' + - 'spec/features/issues/form_spec.rb' - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' - 'spec/helpers/profiles_helper_spec.rb' @@ -345,6 +381,7 @@ Style/FormatString: - 'spec/support/shared_examples/services/jira/requests/base_shared_examples.rb' - 'spec/support/shared_examples/views/registration_features_prompt_shared_examples.rb' - 'spec/validators/any_field_validator_spec.rb' + - 'spec/views/errors/omniauth_error.html.haml_spec.rb' - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/profiles/keys/_form.html.haml_spec.rb' - 'spec/views/profiles/notifications/show.html.haml_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 7ee19ee164e..b07c29ca1df 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -1,8 +1,5 @@ --- Style/GuardClause: - # Offense count: 1014 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' @@ -28,6 +25,7 @@ Style/GuardClause: - 'app/controllers/dashboard/todos_controller.rb' - 'app/controllers/groups/application_controller.rb' - 'app/controllers/groups_controller.rb' + - 'app/controllers/ide_controller.rb' - 'app/controllers/import/gitea_controller.rb' - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' @@ -46,12 +44,14 @@ Style/GuardClause: - 'app/controllers/projects/google_cloud/base_controller.rb' - 'app/controllers/projects/imports_controller.rb' - 'app/controllers/projects/issues_controller.rb' + - 'app/controllers/projects/pipelines/tests_controller.rb' - 'app/controllers/projects/repositories_controller.rb' - 'app/controllers/projects/settings/operations_controller.rb' - 'app/controllers/projects/tree_controller.rb' - 'app/controllers/registrations_controller.rb' - 'app/controllers/repositories/git_http_controller.rb' - 'app/controllers/repositories/lfs_api_controller.rb' + - 'app/controllers/repositories/lfs_storage_controller.rb' - 'app/controllers/search_controller.rb' - 'app/controllers/sessions_controller.rb' - 'app/controllers/users/terms_controller.rb' @@ -65,6 +65,7 @@ Style/GuardClause: - 'app/graphql/mutations/design_management/delete.rb' - 'app/graphql/mutations/notes/create/note.rb' - 'app/graphql/mutations/notes/reposition_image_diff_note.rb' + - 'app/graphql/mutations/packages/destroy_files.rb' - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/board_list_issues_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' @@ -72,8 +73,8 @@ Style/GuardClause: - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/projects/jira_projects_resolver.rb' - 'app/graphql/types/ci/job_type.rb' + - 'app/graphql/types/permission_types/base_permission_type.rb' - 'app/helpers/admin/user_actions_helper.rb' - - 'app/helpers/appearances_helper.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/events_helper.rb' - 'app/helpers/issues_helper.rb' @@ -121,17 +122,18 @@ Style/GuardClause: - 'app/models/design_management/design_collection.rb' - 'app/models/diff_viewer/base.rb' - 'app/models/environment.rb' - - 'app/models/error_tracking/error_event.rb' - 'app/models/error_tracking/project_error_tracking_setting.rb' - 'app/models/experiment_subject.rb' - 'app/models/external_pull_request.rb' - 'app/models/generic_commit_status.rb' + - 'app/models/grafana_integration.rb' - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/base_third_party_wiki.rb' - 'app/models/integrations/confluence.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/emails_on_push.rb' + - 'app/models/integrations/field.rb' - 'app/models/integrations/harbor.rb' - 'app/models/integrations/jenkins.rb' - 'app/models/integrations/jira.rb' @@ -142,8 +144,6 @@ Style/GuardClause: - 'app/models/member.rb' - 'app/models/members/project_member.rb' - 'app/models/merge_request.rb' - - 'app/models/merge_request_assignee.rb' - - 'app/models/merge_request_reviewer.rb' - 'app/models/namespace.rb' - 'app/models/namespace_setting.rb' - 'app/models/operations/feature_flags/strategy.rb' @@ -161,6 +161,7 @@ Style/GuardClause: - 'app/models/project_import_state.rb' - 'app/models/project_label.rb' - 'app/models/project_setting.rb' + - 'app/models/protected_branch.rb' - 'app/models/protected_branch/push_access_level.rb' - 'app/models/repository.rb' - 'app/models/sent_notification.rb' @@ -170,6 +171,8 @@ Style/GuardClause: - 'app/models/user.rb' - 'app/models/users/in_product_marketing_email.rb' - 'app/models/wiki.rb' + - 'app/models/work_item.rb' + - 'app/models/work_items/parent_link.rb' - 'app/presenters/ci/pipeline_presenter.rb' - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/project_presenter.rb' @@ -177,15 +180,19 @@ Style/GuardClause: - 'app/services/bulk_imports/file_download_service.rb' - 'app/services/ci/create_web_ide_terminal_service.rb' - 'app/services/ci/daily_build_group_report_result_service.rb' + - 'app/services/ci/job_artifacts/destroy_batch_service.rb' - 'app/services/ci/parse_dotenv_artifact_service.rb' - 'app/services/ci/pipelines/add_job_service.rb' - 'app/services/ci/play_build_service.rb' - 'app/services/ci/retry_job_service.rb' + - 'app/services/ci/runners/reconcile_existing_runner_versions_service.rb' + - 'app/services/ci/runners/register_runner_service.rb' - 'app/services/ci/update_build_queue_service.rb' - 'app/services/clusters/agent_tokens/track_usage_service.rb' - 'app/services/clusters/aws/fetch_credentials_service.rb' - 'app/services/commits/commit_patch_service.rb' - 'app/services/commits/create_service.rb' + - 'app/services/concerns/alert_management/alert_processing.rb' - 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb' - 'app/services/concerns/rate_limited_service.rb' - 'app/services/concerns/update_repository_storage_methods.rb' @@ -205,12 +212,12 @@ Style/GuardClause: - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/import/validate_remote_git_endpoint_service.rb' - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/issuable/clone/base_service.rb' - 'app/services/issuable/common_system_notes_service.rb' - 'app/services/issuable_base_service.rb' - 'app/services/issues/clone_service.rb' - 'app/services/issues/move_service.rb' - 'app/services/issues/update_service.rb' + - 'app/services/markdown_content_rewriter_service.rb' - 'app/services/merge_requests/add_spent_time_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' @@ -238,10 +245,10 @@ Style/GuardClause: - 'app/services/projects/import_export/export_service.rb' - 'app/services/projects/import_service.rb' - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - - 'app/services/projects/update_pages_service.rb' - 'app/services/projects/update_repository_storage_service.rb' - 'app/services/projects/update_service.rb' - 'app/services/protected_branches/legacy_api_update_service.rb' + - 'app/services/repositories/changelog_service.rb' - 'app/services/snippets/repository_validation_service.rb' - 'app/services/todo_service.rb' - 'app/services/users/build_service.rb' @@ -268,20 +275,24 @@ Style/GuardClause: - 'app/validators/rsa_key_validator.rb' - 'app/validators/top_level_group_validator.rb' - 'app/validators/x509_certificate_credentials_validator.rb' - - 'app/workers/cleanup_container_repository_worker.rb' - 'app/workers/clusters/agents/delete_expired_events_worker.rb' - 'app/workers/concerns/application_worker.rb' - 'app/workers/container_registry/migration/guard_worker.rb' - 'app/workers/deployments/hooks_worker.rb' - 'app/workers/deployments/link_merge_request_worker.rb' - 'app/workers/gitlab/github_import/refresh_import_jid_worker.rb' + - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' + - 'app/workers/packages/cleanup/execute_policy_worker.rb' - 'app/workers/packages/maven/metadata/sync_worker.rb' + - 'app/workers/projects/import_export/relation_export_worker.rb' - 'app/workers/repository_update_remote_mirror_worker.rb' + - 'app/workers/terraform/states/destroy_worker.rb' - 'config/initializers/0_inject_enterprise_edition_module.rb' - 'config/initializers/carrierwave_patch.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/google_api_client_patch.rb' - 'config/initializers/postgresql_cte.rb' + - 'config/initializers/wikicloth_redos_patch.rb' - 'config/object_store_settings.rb' - 'danger/feature_flag/Dangerfile' - 'db/migrate/20210302212623_rename_vuln_fingerprints_indexes.rb' @@ -315,6 +326,7 @@ Style/GuardClause: - 'ee/app/finders/ee/template_finder.rb' - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' + - 'ee/app/graphql/mutations/concerns/mutations/shared_epic_arguments.rb' - 'ee/app/graphql/mutations/iterations/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' @@ -322,13 +334,16 @@ Style/GuardClause: - 'ee/app/graphql/resolvers/epics_resolver.rb' - 'ee/app/graphql/resolvers/iterations_resolver.rb' - 'ee/app/helpers/ee/application_helper.rb' + - 'ee/app/helpers/ee/auth_helper.rb' - 'ee/app/helpers/ee/award_emoji_helper.rb' - 'ee/app/helpers/ee/nav/new_dropdown_helper.rb' - 'ee/app/helpers/ee/nav/top_nav_helper.rb' + - 'ee/app/helpers/ee/projects/pipeline_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/models/allowed_email_domain.rb' - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - 'ee/app/models/approval_merge_request_rule_source.rb' + - 'ee/app/models/audit_events/external_audit_event_destination.rb' - 'ee/app/models/concerns/app_sec/dast/buildable.rb' - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/concerns/elastic/application_versioned_search.rb' @@ -338,6 +353,7 @@ Style/GuardClause: - 'ee/app/models/dast_site_profile.rb' - 'ee/app/models/ee/application_setting.rb' - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/group_group_link.rb' - 'ee/app/models/ee/group_member.rb' - 'ee/app/models/ee/incident_management/issuable_escalation_status.rb' - 'ee/app/models/ee/issue.rb' @@ -347,6 +363,7 @@ Style/GuardClause: - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/project.rb' + - 'ee/app/models/ee/project_group_link.rb' - 'ee/app/models/ee/project_member.rb' - 'ee/app/models/ee/user.rb' - 'ee/app/models/elasticsearch_indexed_project.rb' @@ -361,6 +378,7 @@ Style/GuardClause: - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/preloaders/environments/protected_environment_preloader.rb' - 'ee/app/models/protected_environment.rb' + - 'ee/app/models/sbom/occurrence.rb' - 'ee/app/models/users_security_dashboard_project.rb' - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/presenters/ee/merge_request_presenter.rb' @@ -384,8 +402,8 @@ Style/GuardClause: - 'ee/app/services/ee/groups/update_service.rb' - 'ee/app/services/ee/issuable/common_system_notes_service.rb' - 'ee/app/services/ee/issues/base_service.rb' + - 'ee/app/services/ee/issues/clone_service.rb' - 'ee/app/services/ee/merge_requests/merge_base_service.rb' - - 'ee/app/services/ee/merge_requests/post_merge_service.rb' - 'ee/app/services/ee/merge_requests/refresh_service.rb' - 'ee/app/services/ee/namespace_settings/update_service.rb' - 'ee/app/services/ee/projects/create_service.rb' @@ -409,11 +427,12 @@ Style/GuardClause: - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - 'ee/app/services/merge_trains/refresh_service.rb' - 'ee/app/services/namespaces/storage/email_notification_service.rb' - - 'ee/app/services/projects/slack_application_install_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/override_uuids_service.rb' - 'ee/app/services/timebox_report_service.rb' + - 'ee/app/services/vulnerabilities/security_finding/create_issue_service.rb' - 'ee/app/validators/host_validator.rb' + - 'ee/app/validators/user_existence_validator.rb' - 'ee/app/workers/ee/ci/build_finished_worker.rb' - 'ee/app/workers/ee/post_receive.rb' - 'ee/app/workers/elastic/migration_worker.rb' @@ -462,6 +481,7 @@ Style/GuardClause: - 'ee/lib/omni_auth/strategies/group_saml.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' + - 'ee/spec/support/ci/minutes_helpers.rb' - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'haml_lint/linter/documentation_links.rb' - 'lib/api/commits.rb' @@ -481,6 +501,7 @@ Style/GuardClause: - 'lib/banzai/filter/wiki_link_filter/rewriter.rb' - 'lib/bulk_imports/clients/graphql.rb' - 'lib/bulk_imports/clients/http.rb' + - 'lib/bulk_imports/pipeline/runner.rb' - 'lib/bulk_imports/projects/pipelines/project_pipeline.rb' - 'lib/container_registry/client.rb' - 'lib/feature/definition.rb' @@ -525,21 +546,24 @@ Style/GuardClause: - 'lib/gitlab/ci/reports/codequality_reports_comparer.rb' - 'lib/gitlab/ci/reports/security/vulnerability_reports_comparer.rb' - 'lib/gitlab/ci/runner/backoff.rb' + - 'lib/gitlab/ci/runner_upgrade_check.rb' - 'lib/gitlab/ci/trace.rb' - 'lib/gitlab/ci/trace/archive.rb' - 'lib/gitlab/ci/trace/stream.rb' - 'lib/gitlab/ci/yaml_processor.rb' - 'lib/gitlab/config/entry/validators.rb' + - 'lib/gitlab/daemon.rb' - 'lib/gitlab/database/background_migration/batch_optimizer.rb' - 'lib/gitlab/database/background_migration/batched_migration_wrapper.rb' - 'lib/gitlab/database/consistency_checker.rb' - - 'lib/gitlab/database/load_balancing/configuration.rb' - 'lib/gitlab/database/load_balancing/load_balancer.rb' + - 'lib/gitlab/database/lock_writes_manager.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/database/migration_helpers/v2.rb' - 'lib/gitlab/database/partitioning/partition_manager.rb' - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb' - 'lib/gitlab/database/postgresql_adapter/force_disconnectable_mixin.rb' + - 'lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection.rb' - 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb' - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/highlight.rb' @@ -550,7 +574,6 @@ Style/GuardClause: - 'lib/gitlab/email/hook/email_template_interceptor.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/endpoint_attributes/config.rb' - - 'lib/gitlab/error_tracking.rb' - 'lib/gitlab/event_store/event.rb' - 'lib/gitlab/event_store/store.rb' - 'lib/gitlab/exception_log_formatter.rb' @@ -571,10 +594,7 @@ Style/GuardClause: - 'lib/gitlab/github_import/object_counter.rb' - 'lib/gitlab/gitlab_import/client.rb' - 'lib/gitlab/gitlab_import/importer.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/null_condition.rb' - - 'lib/gitlab/graphql/pagination/keyset/order_info.rb' - - 'lib/gitlab/graphql/pagination/keyset/query_builder.rb' + - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - 'lib/gitlab/i18n/metadata_entry.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' @@ -583,14 +603,19 @@ Style/GuardClause: - 'lib/gitlab/import_export/command_line_util.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - 'lib/gitlab/import_export/importer.rb' + - 'lib/gitlab/import_export/project/relation_factory.rb' - 'lib/gitlab/import_export/repo_restorer.rb' - 'lib/gitlab/import_export/snippet_repo_restorer.rb' - 'lib/gitlab/import_export/version_checker.rb' + - 'lib/gitlab/instrumentation/global_search_api.rb' + - 'lib/gitlab/instrumentation/rate_limiting_gates.rb' - 'lib/gitlab/instrumentation/redis_cluster_validator.rb' - 'lib/gitlab/instrumentation/uploads.rb' + - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' - 'lib/gitlab/legacy_github_import/client.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/marginalia.rb' + - 'lib/gitlab/memory/watchdog.rb' - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' - 'lib/gitlab/metrics/subscribers/action_cable.rb' - 'lib/gitlab/metrics/subscribers/active_record.rb' @@ -598,6 +623,7 @@ Style/GuardClause: - 'lib/gitlab/metrics/subscribers/rails_cache.rb' - 'lib/gitlab/metrics/web_transaction.rb' - 'lib/gitlab/middleware/read_only/controller.rb' + - 'lib/gitlab/pages/deployment_update.rb' - 'lib/gitlab/pagination/gitaly_keyset_pager.rb' - 'lib/gitlab/pagination/keyset/column_order_definition.rb' - 'lib/gitlab/pagination/keyset/in_operator_optimization/array_scope_columns.rb' @@ -626,6 +652,7 @@ Style/GuardClause: - 'lib/gitlab/ssh_public_key.rb' - 'lib/gitlab/url_blocker.rb' - 'lib/gitlab/usage/metric_definition.rb' + - 'lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric.rb' - 'lib/gitlab/usage_data_counters/ci_template_unique_counter.rb' - 'lib/gitlab/utils.rb' - 'lib/gitlab/utils/override.rb' @@ -633,6 +660,7 @@ Style/GuardClause: - 'lib/mattermost/session.rb' - 'lib/release_highlights/validator/entry.rb' - 'lib/safe_zip/entry.rb' + - 'lib/service_ping/devops_report.rb' - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' - 'lib/system_check/incoming_email/mail_room_running_check.rb' - 'lib/tasks/config_lint.rake' @@ -647,22 +675,22 @@ Style/GuardClause: - 'qa/qa/page/component/snippet.rb' - 'qa/qa/page/mattermost/login.rb' - 'qa/qa/page/page_concern.rb' + - 'qa/qa/page/project/settings/deploy_tokens.rb' - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/package.rb' + - 'qa/qa/resource/project.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/reusable.rb' - 'qa/qa/resource/user_gpg.rb' - 'qa/qa/runtime/feature.rb' - 'qa/qa/runtime/search.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - - 'qa/qa/service/docker_run/gitlab_runner.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_file_template_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/group_file_template_spec.rb' - 'qa/qa/specs/helpers/feature_flag.rb' - - 'qa/qa/support/page_error_checker.rb' + - 'qa/qa/vendor/jenkins/job.rb' - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/gitlab/duplicate_spec_location.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' @@ -702,6 +730,7 @@ Style/GuardClause: - 'spec/support/import_export/export_file_helper.rb' - 'spec/support/shared_examples/features/packages_shared_examples.rb' - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' + - 'spec/tooling/lib/tooling/find_codeowners_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - 'tooling/lib/tooling/helm3_client.rb' - 'tooling/lib/tooling/image.rb' diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml index eec2e77eafd..384d2dc5fce 100644 --- a/.rubocop_todo/style/hash_as_last_array_item.yml +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -1,15 +1,11 @@ --- # Cop supports --auto-correct. Style/HashAsLastArrayItem: - # Offense count: 79 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/admin/groups_controller.rb' - 'app/controllers/admin/users_controller.rb' - 'app/controllers/boards/issues_controller.rb' - - 'app/controllers/clusters/clusters_controller.rb' - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/concerns/issuable_collections.rb' - 'app/controllers/profiles_controller.rb' @@ -29,6 +25,7 @@ Style/HashAsLastArrayItem: - 'app/models/customer_relations/contact.rb' - 'app/models/customer_relations/organization.rb' - 'app/models/deploy_key.rb' + - 'app/models/deployment.rb' - 'app/models/issue.rb' - 'app/models/merge_request.rb' - 'app/models/milestone.rb' @@ -59,4 +56,5 @@ Style/HashAsLastArrayItem: - 'spec/services/git/branch_hooks_service_spec.rb' - 'spec/services/metrics/dashboard/panel_preview_service_spec.rb' - 'spec/support/helpers/rack_attack_spec_helpers.rb' + - 'spec/workers/concerns/worker_attributes_spec.rb' - 'spec/workers/merge_worker_spec.rb' diff --git a/.rubocop_todo/style/hash_each_methods.yml b/.rubocop_todo/style/hash_each_methods.yml index 648b6fbbe08..cebfe5c0c7d 100644 --- a/.rubocop_todo/style/hash_each_methods.yml +++ b/.rubocop_todo/style/hash_each_methods.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Style/HashEachMethods: - # Offense count: 95 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' - 'app/graphql/types/alert_management/severity_enum.rb' @@ -12,6 +9,7 @@ Style/HashEachMethods: - 'app/graphql/types/ci/job_artifact_file_type_enum.rb' - 'app/graphql/types/ci/pipeline_config_source_enum.rb' - 'app/graphql/types/ci/runner_access_level_enum.rb' + - 'app/graphql/types/ci/variable_type_enum.rb' - 'app/graphql/types/clusters/agent_token_status_enum.rb' - 'app/graphql/types/container_repository_status_enum.rb' - 'app/graphql/types/data_visualization_palette/color_enum.rb' @@ -34,6 +32,7 @@ Style/HashEachMethods: - 'config/initializers/8_gitaly.rb' - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_reason_enum.rb' - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_severity_enum.rb' + - 'ee/app/graphql/types/incident_management/issuable_resource_link_type_enum.rb' - 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb' - 'ee/app/graphql/types/security_report_summary_type.rb' - 'ee/app/graphql/types/vulnerabilities_count_by_day_type.rb' @@ -69,7 +68,6 @@ Style/HashEachMethods: - 'spec/helpers/application_helper_spec.rb' - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' - 'spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb' - - 'spec/lib/gitlab/template/gitlab_ci_yml_template_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' @@ -77,6 +75,7 @@ Style/HashEachMethods: - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/concerns/has_user_type_spec.rb' - 'spec/models/packages/package_spec.rb' + - 'spec/models/project_spec.rb' - 'spec/models/user_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' - 'spec/presenters/commit_status_presenter_spec.rb' diff --git a/.rubocop_todo/style/if_inside_else.yml b/.rubocop_todo/style/if_inside_else.yml index 3ce6e5ec704..40b71d7de04 100644 --- a/.rubocop_todo/style/if_inside_else.yml +++ b/.rubocop_todo/style/if_inside_else.yml @@ -1,17 +1,13 @@ --- Style/IfInsideElse: - # Offense count: 43 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/application_controller.rb' - 'app/controllers/passwords_controller.rb' - 'app/finders/projects_finder.rb' - - 'app/finders/user_recent_events_finder.rb' - 'app/helpers/diff_helper.rb' + - 'app/helpers/issuables_helper.rb' - 'app/helpers/members_helper.rb' - 'app/helpers/search_helper.rb' - - 'app/models/ci/build.rb' - 'app/models/namespace.rb' - 'app/presenters/project_presenter.rb' - 'app/services/system_notes/commit_service.rb' @@ -22,6 +18,7 @@ Style/IfInsideElse: - 'ee/app/controllers/ee/registrations/welcome_controller.rb' - 'ee/app/controllers/groups/omniauth_callbacks_controller.rb' - 'ee/app/models/ee/namespace.rb' + - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/protected_environments/authorizable.rb' - 'ee/app/policies/ee/group_policy.rb' - 'ee/app/services/app_sec/dast/site_profiles/audit/update_service.rb' @@ -30,12 +27,15 @@ Style/IfInsideElse: - 'ee/app/services/geo/repository_base_sync_service.rb' - 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb' - 'ee/app/services/vulnerability_external_issue_links/create_service.rb' + - 'ee/app/workers/elastic/project_transfer_worker.rb' + - 'ee/app/workers/project_import_schedule_worker.rb' - 'ee/lib/gitlab/geo/base_batcher.rb' - 'lib/api/projects.rb' - 'lib/gitlab/auth.rb' - 'lib/gitlab/conflict/file.rb' - 'lib/gitlab/sql/pattern.rb' - 'lib/gitlab/usage/service_ping/payload_keys_processor.rb' + - 'lib/service_ping/build_payload.rb' - 'lib/tasks/gitlab/cleanup.rake' - 'lib/tasks/gitlab/shell.rake' - 'qa/qa/resource/protected_branch.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 1dfedcc91c0..a58f71aee8f 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -1,14 +1,10 @@ --- # Cop supports --auto-correct. Style/IfUnlessModifier: - # Offense count: 1937 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/channels/graphql_channel.rb' - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/admin/projects_controller.rb' - - 'app/controllers/admin/runners_controller.rb' - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/concerns/controller_with_cross_project_access_check.rb' @@ -25,6 +21,8 @@ Style/IfUnlessModifier: - 'app/controllers/concerns/paginated_collection.rb' - 'app/controllers/concerns/record_user_last_activity.rb' - 'app/controllers/concerns/sorting_preference.rb' + - 'app/controllers/concerns/uploads_actions.rb' + - 'app/controllers/concerns/verifies_with_email.rb' - 'app/controllers/concerns/wiki_actions.rb' - 'app/controllers/concerns/with_performance_bar.rb' - 'app/controllers/explore/projects_controller.rb' @@ -33,9 +31,9 @@ Style/IfUnlessModifier: - 'app/controllers/groups_controller.rb' - 'app/controllers/import/fogbugz_controller.rb' - 'app/controllers/import/gitea_controller.rb' + - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - - 'app/controllers/jira_connect/application_controller.rb' - 'app/controllers/jwt_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' - 'app/controllers/profiles/emails_controller.rb' @@ -53,12 +51,15 @@ Style/IfUnlessModifier: - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/merge_requests/diffs_controller.rb' - 'app/controllers/projects/merge_requests_controller.rb' + - 'app/controllers/projects/pipelines/tests_controller.rb' - 'app/controllers/projects/protected_refs_controller.rb' - 'app/controllers/projects/releases_controller.rb' - 'app/controllers/projects/runners_controller.rb' + - 'app/controllers/projects_controller.rb' - 'app/controllers/registrations_controller.rb' - 'app/controllers/repositories/git_http_controller.rb' - 'app/controllers/repositories/lfs_api_controller.rb' + - 'app/controllers/repositories/lfs_storage_controller.rb' - 'app/controllers/sessions_controller.rb' - 'app/controllers/users/terms_controller.rb' - 'app/finders/autocomplete/users_finder.rb' @@ -92,7 +93,6 @@ Style/IfUnlessModifier: - 'app/graphql/mutations/release_asset_links/delete.rb' - 'app/graphql/mutations/release_asset_links/update.rb' - 'app/graphql/mutations/todos/mark_all_done.rb' - - 'app/graphql/mutations/work_items/create.rb' - 'app/graphql/resolvers/blobs_resolver.rb' - 'app/graphql/resolvers/ci/runner_jobs_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' @@ -105,7 +105,6 @@ Style/IfUnlessModifier: - 'app/graphql/resolvers/timelog_resolver.rb' - 'app/graphql/types/ci/job_type.rb' - 'app/helpers/admin/user_actions_helper.rb' - - 'app/helpers/appearances_helper.rb' - 'app/helpers/blob_helper.rb' - 'app/helpers/button_helper.rb' - 'app/helpers/ci/status_helper.rb' @@ -116,7 +115,6 @@ Style/IfUnlessModifier: - 'app/helpers/events_helper.rb' - 'app/helpers/form_helper.rb' - 'app/helpers/groups_helper.rb' - - 'app/helpers/issuables_description_templates_helper.rb' - 'app/helpers/issuables_helper.rb' - 'app/helpers/issues_helper.rb' - 'app/helpers/lazy_image_tag_helper.rb' @@ -135,6 +133,7 @@ Style/IfUnlessModifier: - 'app/helpers/selects_helper.rb' - 'app/helpers/snippets_helper.rb' - 'app/helpers/sorting_helper.rb' + - 'app/helpers/storage_helper.rb' - 'app/helpers/submodule_helper.rb' - 'app/helpers/tab_helper.rb' - 'app/helpers/timeboxes_helper.rb' @@ -153,6 +152,7 @@ Style/IfUnlessModifier: - 'app/models/ci/build.rb' - 'app/models/ci/build_trace_chunk.rb' - 'app/models/ci/job_artifact.rb' + - 'app/models/ci/pending_build.rb' - 'app/models/ci/pipeline.rb' - 'app/models/ci/runner.rb' - 'app/models/ci/running_build.rb' @@ -170,7 +170,6 @@ Style/IfUnlessModifier: - 'app/models/concerns/ci/artifactable.rb' - 'app/models/concerns/counter_attribute.rb' - 'app/models/concerns/deprecated_assignee.rb' - - 'app/models/concerns/diff_positionable_note.rb' - 'app/models/concerns/group_descendant.rb' - 'app/models/concerns/has_wiki_page_meta_attributes.rb' - 'app/models/concerns/id_in_ordered.rb' @@ -178,10 +177,10 @@ Style/IfUnlessModifier: - 'app/models/concerns/issuable.rb' - 'app/models/concerns/issuable_link.rb' - 'app/models/concerns/issue_available_features.rb' - - 'app/models/concerns/limitable.rb' - 'app/models/concerns/mentionable.rb' - 'app/models/concerns/noteable.rb' - 'app/models/concerns/routable.rb' + - 'app/models/concerns/sha_attribute.rb' - 'app/models/concerns/timebox.rb' - 'app/models/concerns/token_authenticatable_strategies/base.rb' - 'app/models/concerns/token_authenticatable_strategies/digest.rb' @@ -195,6 +194,7 @@ Style/IfUnlessModifier: - 'app/models/error_tracking/project_error_tracking_setting.rb' - 'app/models/external_pull_request.rb' - 'app/models/generic_commit_status.rb' + - 'app/models/grafana_integration.rb' - 'app/models/group.rb' - 'app/models/integrations/asana.rb' - 'app/models/integrations/bamboo.rb' @@ -205,6 +205,7 @@ Style/IfUnlessModifier: - 'app/models/integrations/jira.rb' - 'app/models/integrations/pushover.rb' - 'app/models/integrations/teamcity.rb' + - 'app/models/issue.rb' - 'app/models/issue_email_participant.rb' - 'app/models/label_note.rb' - 'app/models/list.rb' @@ -217,7 +218,6 @@ Style/IfUnlessModifier: - 'app/models/namespace.rb' - 'app/models/namespace_setting.rb' - 'app/models/namespaces/traversal/linear.rb' - - 'app/models/namespaces/traversal/linear_scopes.rb' - 'app/models/network/graph.rb' - 'app/models/note.rb' - 'app/models/notification_setting.rb' @@ -239,7 +239,6 @@ Style/IfUnlessModifier: - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - 'app/models/route.rb' - - 'app/models/sent_notification.rb' - 'app/models/service_desk_setting.rb' - 'app/models/snippet_input_action.rb' - 'app/models/state_note.rb' @@ -247,6 +246,8 @@ Style/IfUnlessModifier: - 'app/models/synthetic_note.rb' - 'app/models/user.rb' - 'app/models/wiki.rb' + - 'app/models/work_items/parent_link.rb' + - 'app/policies/project_policy.rb' - 'app/presenters/blob_presenter.rb' - 'app/presenters/ci/pipeline_presenter.rb' - 'app/presenters/merge_request_presenter.rb' @@ -266,7 +267,6 @@ Style/IfUnlessModifier: - 'app/services/boards/lists/base_create_service.rb' - 'app/services/boards/lists/list_service.rb' - 'app/services/branches/validate_new_service.rb' - - 'app/services/bulk_imports/file_decompression_service.rb' - 'app/services/ci/create_pipeline_service.rb' - 'app/services/ci/create_web_ide_terminal_service.rb' - 'app/services/ci/job_token_scope/remove_project_service.rb' @@ -276,6 +276,8 @@ Style/IfUnlessModifier: - 'app/services/ci/register_job_service.rb' - 'app/services/ci/retry_job_service.rb' - 'app/services/ci/run_scheduled_build_service.rb' + - 'app/services/ci/runners/reconcile_existing_runner_versions_service.rb' + - 'app/services/ci/runners/register_runner_service.rb' - 'app/services/ci/update_build_state_service.rb' - 'app/services/clusters/applications/base_service.rb' - 'app/services/clusters/applications/prometheus_update_service.rb' @@ -299,6 +301,7 @@ Style/IfUnlessModifier: - 'app/services/error_tracking/collect_error_service.rb' - 'app/services/git/process_ref_changes_service.rb' - 'app/services/google_cloud/generate_pipeline_service.rb' + - 'app/services/google_cloud/setup_cloudsql_instance_service.rb' - 'app/services/groups/create_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/groups/update_statistics_service.rb' @@ -314,7 +317,6 @@ Style/IfUnlessModifier: - 'app/services/issues/relative_position_rebalancing_service.rb' - 'app/services/issues/update_service.rb' - 'app/services/lfs/lock_file_service.rb' - - 'app/services/members/approve_access_request_service.rb' - 'app/services/members/destroy_service.rb' - 'app/services/members/update_service.rb' - 'app/services/merge_requests/add_context_service.rb' @@ -322,7 +324,6 @@ Style/IfUnlessModifier: - 'app/services/merge_requests/build_service.rb' - 'app/services/merge_requests/handle_assignees_change_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - - 'app/services/merge_requests/mergeability/run_checks_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' - 'app/services/merge_requests/push_options_handler_service.rb' - 'app/services/merge_requests/refresh_service.rb' @@ -371,8 +372,8 @@ Style/IfUnlessModifier: - 'app/services/projects/overwrite_project_service.rb' - 'app/services/projects/participants_service.rb' - 'app/services/projects/transfer_service.rb' - - 'app/services/projects/update_pages_service.rb' - 'app/services/projects/update_repository_storage_service.rb' + - 'app/services/protected_branches/cache_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - 'app/services/resource_events/change_labels_service.rb' - 'app/services/snippets/create_service.rb' @@ -388,6 +389,8 @@ Style/IfUnlessModifier: - 'app/services/users/respond_to_terms_service.rb' - 'app/services/wikis/create_attachment_service.rb' - 'app/services/work_items/create_service.rb' + - 'app/services/work_items/parent_links/create_service.rb' + - 'app/services/work_items/task_list_reference_removal_service.rb' - 'app/services/work_items/task_list_reference_replacement_service.rb' - 'app/uploaders/file_mover.rb' - 'app/uploaders/object_storage.rb' @@ -408,17 +411,20 @@ Style/IfUnlessModifier: - 'app/views/projects/merge_requests/index.atom.builder' - 'app/workers/authorized_project_update/user_refresh_from_replica_worker.rb' - 'app/workers/auto_devops/disable_worker.rb' - - 'app/workers/cleanup_container_repository_worker.rb' - 'app/workers/concerns/application_worker.rb' - 'app/workers/concerns/packages/cleanup_artifact_worker.rb' - 'app/workers/concerns/project_start_import.rb' + - 'app/workers/concerns/waitable_worker.rb' - 'app/workers/concerns/worker_attributes.rb' - 'app/workers/database/batched_background_migration/single_database_worker.rb' + - 'app/workers/delete_container_repository_worker.rb' - 'app/workers/file_hook_worker.rb' + - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' - 'app/workers/issues/rebalancing_worker.rb' - 'app/workers/merge_request_mergeability_check_worker.rb' - 'app/workers/object_storage/migrate_uploads_worker.rb' - 'app/workers/process_commit_worker.rb' + - 'app/workers/projects/import_export/relation_export_worker.rb' - 'app/workers/remove_expired_members_worker.rb' - 'app/workers/repository_fork_worker.rb' - 'app/workers/repository_update_remote_mirror_worker.rb' @@ -429,11 +435,10 @@ Style/IfUnlessModifier: - 'config/initializers/1_settings.rb' - 'config/initializers/6_validations.rb' - 'config/initializers/8_devise.rb' - - 'config/initializers/active_record_data_types.rb' - 'config/initializers/active_record_transaction_patches.rb' - - 'config/initializers/content_security_policy.rb' - 'config/initializers/default_url_options.rb' - 'config/initializers/direct_upload_support.rb' + - 'config/initializers/doorkeeper.rb' - 'config/initializers/geo.rb' - 'config/initializers/google_api_client.rb' - 'config/initializers/google_api_client_patch.rb' @@ -449,7 +454,6 @@ Style/IfUnlessModifier: - 'config/initializers/zz_metrics.rb' - 'config/initializers_before_autoloader/002_sidekiq.rb' - 'config/routes.rb' - - 'config/settings.rb' - 'danger/database/Dangerfile' - 'danger/pipeline/Dangerfile' - 'danger/specs/Dangerfile' @@ -465,7 +469,8 @@ Style/IfUnlessModifier: - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb' - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - - 'ee/app/controllers/admin/audit_logs_controller.rb' + - 'db/post_migrate/20220523171107_drop_deploy_tokens_token_column.rb' + - 'ee/app/components/namespaces/storage/limit_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' @@ -495,10 +500,11 @@ Style/IfUnlessModifier: - 'ee/app/finders/merge_trains_finder.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - - 'ee/app/graphql/ee/mutations/issues/create.rb' - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/destroy.rb' + - 'ee/app/graphql/mutations/boards/scoped_board_mutation.rb' + - 'ee/app/graphql/mutations/dast_site_profiles/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver.rb' @@ -506,39 +512,37 @@ Style/IfUnlessModifier: - 'ee/app/graphql/resolvers/boards/epic_lists_resolver.rb' - 'ee/app/graphql/resolvers/iterations/cadences_resolver.rb' - 'ee/app/helpers/billing_plans_helper.rb' - - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/dashboard_helper.rb' - - 'ee/app/helpers/ee/environments_helper.rb' - 'ee/app/helpers/ee/integrations_helper.rb' - 'ee/app/helpers/ee/issues_helper.rb' - 'ee/app/helpers/ee/labels_helper.rb' - 'ee/app/helpers/ee/merge_requests_helper.rb' - 'ee/app/helpers/ee/notes_helper.rb' - 'ee/app/helpers/ee/personal_access_tokens_helper.rb' + - 'ee/app/helpers/ee/projects/pipeline_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/models/allowed_email_domain.rb' - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' + - 'ee/app/models/approval_project_rule.rb' - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/concerns/elastic/application_versioned_search.rb' - - 'ee/app/models/concerns/geo/replicable_model.rb' - 'ee/app/models/concerns/geo/verifiable_replicator.rb' - 'ee/app/models/concerns/security/scan_execution_policy.rb' - 'ee/app/models/dast_site_profile.rb' - 'ee/app/models/ee/application_setting.rb' + - 'ee/app/models/ee/ci/job_artifact.rb' + - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/group_member.rb' - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/key.rb' - 'ee/app/models/ee/list.rb' - - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/milestone_release.rb' - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/namespace/root_storage_size.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/ee/project_feature.rb' - 'ee/app/models/ee/project_team.rb' - 'ee/app/models/ee/user.rb' - - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/geo/project_registry.rb' - 'ee/app/models/geo/tracking_base.rb' - 'ee/app/models/incident_management/escalation_rule.rb' @@ -554,6 +558,7 @@ Style/IfUnlessModifier: - 'ee/app/serializers/vulnerabilities/finding_serializer.rb' - 'ee/app/services/analytics/cycle_analytics/aggregator_service.rb' - 'ee/app/services/analytics/cycle_analytics/validations.rb' + - 'ee/app/services/app_sec/dast/pipelines/find_latest_service.rb' - 'ee/app/services/app_sec/dast/profiles/build_config_service.rb' - 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb' - 'ee/app/services/app_sec/dast/scan_configs/build_service.rb' @@ -564,7 +569,6 @@ Style/IfUnlessModifier: - 'ee/app/services/app_sec/dast/site_profiles/destroy_service.rb' - 'ee/app/services/app_sec/dast/site_profiles/update_service.rb' - 'ee/app/services/app_sec/fuzzing/api/ci_configuration_create_service.rb' - - 'ee/app/services/audit_events/runner_audit_event_service.rb' - 'ee/app/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service.rb' - 'ee/app/services/billable_members/destroy_service.rb' - 'ee/app/services/boards/epic_boards/create_service.rb' @@ -572,6 +576,7 @@ Style/IfUnlessModifier: - 'ee/app/services/boards/epics/create_service.rb' - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' - 'ee/app/services/ci/subscribe_bridge_service.rb' + - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' - 'ee/app/services/compliance_management/frameworks/create_service.rb' - 'ee/app/services/compliance_management/merge_requests/create_compliance_violations_service.rb' - 'ee/app/services/deployments/auto_rollback_service.rb' @@ -581,15 +586,13 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/audit_event_service.rb' - 'ee/app/services/ee/boards/base_service.rb' - 'ee/app/services/ee/boards/issues/move_service.rb' + - 'ee/app/services/ee/ci/runners/reset_registration_token_service.rb' - 'ee/app/services/ee/commits/create_service.rb' - 'ee/app/services/ee/deploy_keys/create_service.rb' - 'ee/app/services/ee/groups/update_service.rb' - 'ee/app/services/ee/ip_restrictions/update_service.rb' - 'ee/app/services/ee/issuable_base_service.rb' - 'ee/app/services/ee/issues/base_service.rb' - - 'ee/app/services/ee/issues/clone_service.rb' - - 'ee/app/services/ee/issues/move_service.rb' - - 'ee/app/services/ee/merge_requests/base_service.rb' - 'ee/app/services/ee/merge_requests/refresh_service.rb' - 'ee/app/services/ee/merge_requests/update_service.rb' - 'ee/app/services/ee/milestones/update_service.rb' @@ -598,16 +601,18 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/projects/destroy_service.rb' - 'ee/app/services/ee/projects/gitlab_projects_import_service.rb' - 'ee/app/services/ee/protected_branches/create_service.rb' - - 'ee/app/services/ee/resource_events/change_labels_service.rb' - 'ee/app/services/ee/todo_service.rb' - 'ee/app/services/ee/users/update_service.rb' - 'ee/app/services/elastic/indexing_control_service.rb' - 'ee/app/services/elastic/process_bookkeeping_service.rb' - 'ee/app/services/epics/base_service.rb' - 'ee/app/services/epics/create_service.rb' + - 'ee/app/services/epics/epic_links/create_service.rb' + - 'ee/app/services/epics/epic_links/update_service.rb' - 'ee/app/services/epics/update_dates_service.rb' - 'ee/app/services/epics/update_service.rb' - 'ee/app/services/external_status_checks/create_service.rb' + - 'ee/app/services/geo/file_registry_removal_service.rb' - 'ee/app/services/geo/metrics_update_service.rb' - 'ee/app/services/geo/move_repository_service.rb' - 'ee/app/services/geo/prune_event_log_service.rb' @@ -625,7 +630,6 @@ Style/IfUnlessModifier: - 'ee/app/services/merge_requests/update_blocks_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - 'ee/app/services/projects/mark_for_deletion_service.rb' - - 'ee/app/services/projects/slack_application_install_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/resource_events/change_weight_service.rb' - 'ee/app/services/security/dependency_list_service.rb' @@ -649,17 +653,18 @@ Style/IfUnlessModifier: - 'ee/app/services/vulnerability_feedback/destroy_service.rb' - 'ee/app/services/vulnerability_feedback_module/update_service.rb' - 'ee/app/validators/host_validator.rb' + - 'ee/app/validators/password/complexity_validator.rb' - 'ee/app/workers/app_sec/dast/profile_schedule_worker.rb' - 'ee/app/workers/audit_events/audit_event_streaming_worker.rb' - 'ee/app/workers/concerns/elastic/migration_helper.rb' - 'ee/app/workers/ee/ci/build_finished_worker.rb' - - 'ee/app/workers/ee/post_receive.rb' + - 'ee/app/workers/elastic/project_transfer_worker.rb' - 'ee/app/workers/epics/new_epic_issue_worker.rb' - 'ee/app/workers/geo/secondary/registry_consistency_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb' - 'ee/db/geo/migrate/20170627195211_add_index_to_project_registry.rb' - 'ee/db/geo/migrate/20180402170913_add_missing_on_primary_to_job_artifact_registry..rb' - - 'ee/lib/analytics/devops_adoption/snapshot_calculator.rb' + - 'ee/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index.rb' - 'ee/lib/api/epics.rb' - 'ee/lib/api/merge_request_approval_rules.rb' - 'ee/lib/api/protected_environments.rb' @@ -679,7 +684,6 @@ Style/IfUnlessModifier: - 'ee/lib/ee/container_registry/client.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/auth/ldap/group.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'ee/lib/ee/gitlab/checks/diff_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/tag_check.rb' @@ -713,7 +717,7 @@ Style/IfUnlessModifier: - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb' - - 'ee/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate.rb' + - 'ee/lib/gitlab/graphql/aggregations/issuables/lazy_links_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/vulnerabilities/lazy_user_notes_count_aggregate.rb' - 'ee/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate.rb' @@ -741,7 +745,6 @@ Style/IfUnlessModifier: - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - - 'ee/spec/lib/gitlab/elastic/project_search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/search_results_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - 'ee/spec/models/concerns/elastic/note_spec.rb' @@ -766,7 +769,6 @@ Style/IfUnlessModifier: - 'lib/api/ci/pipeline_schedules.rb' - 'lib/api/ci/runner.rb' - 'lib/api/ci/runners.rb' - - 'lib/api/ci/secure_files.rb' - 'lib/api/commits.rb' - 'lib/api/debian_project_packages.rb' - 'lib/api/deployments.rb' @@ -775,7 +777,6 @@ Style/IfUnlessModifier: - 'lib/api/entities/member_access.rb' - 'lib/api/entities/project_import_status.rb' - 'lib/api/feature_flags.rb' - - 'lib/api/feature_flags_user_lists.rb' - 'lib/api/files.rb' - 'lib/api/groups.rb' - 'lib/api/helm_packages.rb' @@ -791,14 +792,15 @@ Style/IfUnlessModifier: - 'lib/api/helpers/projects_helpers.rb' - 'lib/api/helpers/users_helpers.rb' - 'lib/api/helpers/version.rb' + - 'lib/api/helpers/web_hooks_helpers.rb' - 'lib/api/internal/base.rb' - 'lib/api/internal/container_registry/migration.rb' + - 'lib/api/internal/error_tracking.rb' - 'lib/api/invitations.rb' - 'lib/api/maven_packages.rb' - 'lib/api/merge_requests.rb' - 'lib/api/nuget_project_packages.rb' - 'lib/api/pages_domains.rb' - - 'lib/api/project_clusters.rb' - 'lib/api/project_snippets.rb' - 'lib/api/projects.rb' - 'lib/api/projects_relation_builder.rb' @@ -840,6 +842,7 @@ Style/IfUnlessModifier: - 'lib/generators/gitlab/usage_metric_generator.rb' - 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb' - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' + - 'lib/gitlab/application_context.rb' - 'lib/gitlab/auth.rb' - 'lib/gitlab/auth/auth_finders.rb' - 'lib/gitlab/auth/ldap/adapter.rb' @@ -861,6 +864,7 @@ Style/IfUnlessModifier: - 'lib/gitlab/checks/matching_merge_request.rb' - 'lib/gitlab/checks/push_check.rb' - 'lib/gitlab/checks/push_file_count_check.rb' + - 'lib/gitlab/checks/tag_check.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/converter.rb' - 'lib/gitlab/ci/ansi2json/style.rb' @@ -876,7 +880,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/ci/config/entry/jobs.rb' - 'lib/gitlab/ci/config/entry/needs.rb' - 'lib/gitlab/ci/config/entry/policy.rb' - - 'lib/gitlab/ci/config/entry/processable.rb' - 'lib/gitlab/ci/config/entry/product/matrix.rb' - 'lib/gitlab/ci/config/extendable/entry.rb' - 'lib/gitlab/ci/config/external/file/base.rb' @@ -912,6 +915,7 @@ Style/IfUnlessModifier: - 'lib/gitlab/content_security_policy/config_loader.rb' - 'lib/gitlab/cross_project_access/check_info.rb' - 'lib/gitlab/data_builder/deployment.rb' + - 'lib/gitlab/data_builder/pipeline.rb' - 'lib/gitlab/database/as_with_materialized.rb' - 'lib/gitlab/database/background_migration/batched_job.rb' - 'lib/gitlab/database/background_migration/batched_migration_wrapper.rb' @@ -932,8 +936,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - 'lib/gitlab/database/transaction/observer.rb' - 'lib/gitlab/database/with_lock_retries.rb' - - 'lib/gitlab/diff/formatters/base_formatter.rb' - - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/repository_push.rb' @@ -942,7 +944,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/encrypted_command_base.rb' - 'lib/gitlab/encrypted_configuration.rb' - 'lib/gitlab/endpoint_attributes/config.rb' - - 'lib/gitlab/error_tracking.rb' - 'lib/gitlab/error_tracking/context_payload_generator.rb' - 'lib/gitlab/error_tracking/processor/sidekiq_processor.rb' - 'lib/gitlab/etag_caching/middleware.rb' @@ -960,7 +961,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/git_access.rb' - 'lib/gitlab/git_access_project.rb' - 'lib/gitlab/git_access_snippet.rb' - - 'lib/gitlab/git_access_wiki.rb' - 'lib/gitlab/gitaly_client.rb' - 'lib/gitlab/gitaly_client/blob_service.rb' - 'lib/gitlab/gitaly_client/operation_service.rb' @@ -971,15 +971,11 @@ Style/IfUnlessModifier: - 'lib/gitlab/gitlab_import/client.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/golang.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/base_condition.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - - 'lib/gitlab/graphql/pagination/keyset/generic_keyset_pagination.rb' - - 'lib/gitlab/graphql/pagination/keyset/order_info.rb' - - 'lib/gitlab/graphql/pagination/keyset/query_builder.rb' - 'lib/gitlab/graphql/queries.rb' - 'lib/gitlab/hashed_storage/rake_helper.rb' - 'lib/gitlab/hotlinking_detector.rb' + - 'lib/gitlab/http.rb' - 'lib/gitlab/http_io.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import/import_failure_service.rb' @@ -987,12 +983,13 @@ Style/IfUnlessModifier: - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' - 'lib/gitlab/import_export/base/relation_factory.rb' - 'lib/gitlab/import_export/fast_hash_serializer.rb' - - 'lib/gitlab/import_export/file_importer.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - 'lib/gitlab/import_export/json/legacy_writer.rb' - 'lib/gitlab/import_export/merge_request_parser.rb' - 'lib/gitlab/import_export/project/export_task.rb' + - 'lib/gitlab/import_export/project/relation_factory.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' + - 'lib/gitlab/instrumentation/rate_limiting_gates.rb' - 'lib/gitlab/instrumentation/redis_interceptor.rb' - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' @@ -1000,6 +997,7 @@ Style/IfUnlessModifier: - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/legacy_github_import/project_creator.rb' + - 'lib/gitlab/lograge/custom_options.rb' - 'lib/gitlab/mail_room.rb' - 'lib/gitlab/mail_room/authenticator.rb' - 'lib/gitlab/manifest_import/manifest.rb' @@ -1011,19 +1009,19 @@ Style/IfUnlessModifier: - 'lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter.rb' - 'lib/gitlab/metrics/dashboard/stages/variable_endpoint_inserter.rb' - 'lib/gitlab/metrics/methods.rb' - - 'lib/gitlab/metrics/rails_slis.rb' + - 'lib/gitlab/metrics/subscribers/rack_attack.rb' - 'lib/gitlab/metrics/web_transaction.rb' - 'lib/gitlab/middleware/compressed_json.rb' - 'lib/gitlab/middleware/multipart.rb' - 'lib/gitlab/middleware/same_site_cookies.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/omniauth_initializer.rb' + - 'lib/gitlab/pages/deployment_update.rb' - 'lib/gitlab/pagination/keyset/in_operator_optimization/query_builder.rb' - 'lib/gitlab/patch/database_config.rb' - 'lib/gitlab/patch/prependable.rb' - 'lib/gitlab/popen.rb' - 'lib/gitlab/query_limiting/active_support_subscriber.rb' - - 'lib/gitlab/quick_actions/command_definition.rb' - 'lib/gitlab/quick_actions/extractor.rb' - 'lib/gitlab/quick_actions/issuable_actions.rb' - 'lib/gitlab/quick_actions/issue_and_merge_request_actions.rb' @@ -1044,11 +1042,9 @@ Style/IfUnlessModifier: - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' - 'lib/gitlab/slash_commands/presenters/issue_show.rb' - 'lib/gitlab/suggestions/suggestion_set.rb' - - 'lib/gitlab/template/gitlab_ci_yml_template.rb' - 'lib/gitlab/template_parser/eval_state.rb' - 'lib/gitlab/untrusted_regexp.rb' - 'lib/gitlab/url_blocker.rb' - - 'lib/gitlab/usage/metrics/aggregates/aggregate.rb' - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data_counters/base_counter.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' @@ -1084,13 +1080,12 @@ Style/IfUnlessModifier: - 'qa/qa/ee/page/merge_request/show.rb' - 'qa/qa/ee/resource/settings/elasticsearch.rb' - 'qa/qa/flow/sign_up.rb' - - 'qa/qa/git/repository.rb' - - 'qa/qa/page/component/design_management.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/component/snippet.rb' - 'qa/qa/page/element.rb' - 'qa/qa/page/mattermost/login.rb' - 'qa/qa/page/page_concern.rb' + - 'qa/qa/page/project/settings/deploy_tokens.rb' - 'qa/qa/page/project/web_ide/edit.rb' - 'qa/qa/page/view.rb' - 'qa/qa/resource/registry_repository.rb' @@ -1099,21 +1094,17 @@ Style/IfUnlessModifier: - 'qa/qa/resource/runner.rb' - 'qa/qa/resource/snippet.rb' - 'qa/qa/runtime/application_settings.rb' - - 'qa/qa/runtime/browser.rb' - 'qa/qa/runtime/gpg.rb' - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/scenario/bootable.rb' - - 'qa/qa/scenario/template.rb' - - 'qa/qa/service/docker_run/gitlab_runner.rb' - - 'qa/qa/service/docker_run/jenkins.rb' - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/elasticsearch_api_spec.rb' + - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/commit_index/commit_index_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/issues_index/issue_index_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/main_index/blob_index_spec.rb' - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/merge_request_index/merge_request_index_spec.rb' @@ -1121,15 +1112,13 @@ Style/IfUnlessModifier: - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/nightly_elasticsearch_test_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_maven_package_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - 'qa/qa/support/loglinking.rb' - - 'qa/qa/support/page_error_checker.rb' - - 'qa/qa/support/wait_for_requests.rb' - 'qa/qa/tools/delete_projects.rb' + - 'qa/qa/tools/delete_user_projects.rb' - 'qa/qa/tools/generate_perf_testdata.rb' - - 'qa/qa/tools/test_resources_handler.rb' - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' @@ -1149,8 +1138,11 @@ Style/IfUnlessModifier: - 'scripts/setup/find-jh-branch.rb' - 'scripts/static-analysis' - 'sidekiq_cluster/cli.rb' + - 'spec/components/previews/pajamas/alert_component_preview.rb' + - 'spec/components/previews/pajamas/card_component_preview.rb' - 'spec/db/docs_spec.rb' - 'spec/factories/ci/runners.rb' + - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/container_repositories.rb' - 'spec/factories/deployments.rb' - 'spec/factories/labels.rb' @@ -1164,6 +1156,8 @@ Style/IfUnlessModifier: - 'spec/features/merge_request/batch_comments_spec.rb' - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/projects/blobs/edit_spec.rb' + - 'spec/features/projects/tree/create_directory_spec.rb' + - 'spec/features/projects/tree/create_file_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' - 'spec/helpers/invite_members_helper_spec.rb' @@ -1173,6 +1167,7 @@ Style/IfUnlessModifier: - 'spec/lib/gitlab/config/entry/validators/nested_array_helpers_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' + - 'spec/lib/gitlab/database/lock_writes_manager_spec.rb' - 'spec/lib/gitlab/rack_attack/user_allowlist_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' @@ -1186,8 +1181,10 @@ Style/IfUnlessModifier: - 'spec/policies/project_statistics_policy_spec.rb' - 'spec/requests/api/ci/jobs_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' + - 'spec/requests/api/commits_spec.rb' - 'spec/requests/api/files_spec.rb' - 'spec/requests/api/integrations_spec.rb' + - 'spec/requests/users_controller_spec.rb' - 'spec/routing/import_routing_spec.rb' - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' @@ -1207,13 +1204,11 @@ Style/IfUnlessModifier: - 'spec/support/external_authorization_service_helpers.rb' - 'spec/support/flaky_tests.rb' - 'spec/support/generate-seed-repo-rb' - - 'spec/support/helpers/cycle_analytics_helpers.rb' - 'spec/support/helpers/filter_spec_helper.rb' - 'spec/support/helpers/filtered_search_helpers.rb' - 'spec/support/helpers/gitaly_setup.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' - - 'spec/support/helpers/kubernetes_helpers.rb' - 'spec/support/helpers/lets_encrypt_helpers.rb' - 'spec/support/helpers/live_debugger.rb' - 'spec/support/helpers/modal_helpers.rb' @@ -1247,6 +1242,7 @@ Style/IfUnlessModifier: - 'spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - 'tooling/danger/product_intelligence.rb' + - 'tooling/lib/tooling/find_codeowners.rb' - 'tooling/lib/tooling/image.rb' - 'tooling/lib/tooling/test_map_packer.rb' - 'tooling/rspec_flaky/flaky_example.rb' diff --git a/.rubocop_todo/style/missing_respond_to_missing.yml b/.rubocop_todo/style/missing_respond_to_missing.yml index 4d602586342..9387ae72d00 100644 --- a/.rubocop_todo/style/missing_respond_to_missing.yml +++ b/.rubocop_todo/style/missing_respond_to_missing.yml @@ -1,8 +1,5 @@ --- Style/MissingRespondToMissing: - # Offense count: 21 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/projects/application_controller.rb' - 'app/models/network/commit.rb' diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml index ba2bd293696..4106cba955f 100644 --- a/.rubocop_todo/style/next.yml +++ b/.rubocop_todo/style/next.yml @@ -1,10 +1,8 @@ --- # Cop supports --auto-correct. Style/Next: - # Offense count: 41 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'app/models/concerns/integrations/slack_mattermost_notifier.rb' - 'app/models/preloaders/environments/deployment_preloader.rb' - 'app/models/route.rb' - 'app/services/authorized_project_update/find_records_due_for_refresh_service.rb' @@ -16,6 +14,7 @@ Style/Next: - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/gitlab_subscriptions/fetch_purchase_eligible_namespaces_service.rb' - 'ee/app/services/security/auto_fix_service.rb' + - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb' - 'ee/db/fixtures/development/20_vulnerabilities.rb' - 'ee/lib/ee/audit/protected_branches_changes_auditor.rb' - 'ee/lib/gitlab/elastic/search_results.rb' @@ -36,10 +35,9 @@ Style/Next: - 'lib/gitlab/metrics/samplers/base_sampler.rb' - 'lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy.rb' - 'lib/gitlab/reference_extractor.rb' - - 'lib/gitlab/tree_summary.rb' - 'lib/tasks/gitlab/assets.rake' - 'lib/tasks/gitlab/db/validate_config.rake' - - 'rubocop/cop/static_translation_definition.rb' - 'scripts/perf/query_limiting_report.rb' + - 'scripts/qa/quarantine-types-check' - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb' - 'spec/presenters/packages/npm/package_presenter_spec.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 16ae8989c97..ae019079a8d 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Style/PercentLiteralDelimiters: - # Offense count: 3136 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'Guardfile' - 'app/controllers/abuse_reports_controller.rb' @@ -85,6 +82,7 @@ Style/PercentLiteralDelimiters: - 'app/models/concerns/clusters/agents/authorization_config_scopes.rb' - 'app/models/concerns/diff_positionable_note.rb' - 'app/models/concerns/enums/prometheus_metric.rb' + - 'app/models/concerns/integrations/base_data_fields.rb' - 'app/models/concerns/issuable.rb' - 'app/models/concerns/issue_available_features.rb' - 'app/models/concerns/mentionable/reference_regexes.rb' @@ -98,11 +96,11 @@ Style/PercentLiteralDelimiters: - 'app/models/diff_note.rb' - 'app/models/discussion_note.rb' - 'app/models/draft_note.rb' + - 'app/models/environment.rb' - 'app/models/event.rb' - 'app/models/instance_configuration.rb' - 'app/models/integrations/asana.rb' - 'app/models/integrations/assembla.rb' - - 'app/models/integrations/base_ci.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/base_monitoring.rb' - 'app/models/integrations/base_slash_commands.rb' @@ -125,6 +123,7 @@ Style/PercentLiteralDelimiters: - 'app/models/issuable_severity.rb' - 'app/models/issue.rb' - 'app/models/lfs_download_object.rb' + - 'app/models/namespace.rb' - 'app/models/namespace/root_storage_statistics.rb' - 'app/models/note.rb' - 'app/models/notification_setting.rb' @@ -153,6 +152,7 @@ Style/PercentLiteralDelimiters: - 'app/services/feature_flags/base_service.rb' - 'app/services/files/multi_service.rb' - 'app/services/import/bitbucket_server_service.rb' + - 'app/services/import/fogbugz_service.rb' - 'app/services/import/github_service.rb' - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3.rb' @@ -172,13 +172,13 @@ Style/PercentLiteralDelimiters: - 'app/services/projects/update_service.rb' - 'app/services/prometheus/proxy_service.rb' - 'app/services/repositories/base_service.rb' - - 'app/services/repositories/destroy_service.rb' - 'app/services/repository_archive_clean_up_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - 'app/services/resource_access_tokens/revoke_service.rb' - 'app/services/search/global_service.rb' - 'app/services/search/project_service.rb' - 'app/services/snippets/update_service.rb' + - 'app/services/todos/destroy/destroyed_issuable_service.rb' - 'app/services/todos/destroy/entity_leave_service.rb' - 'app/uploaders/design_management/design_v432x230_uploader.rb' - 'app/uploaders/gitlab_uploader.rb' @@ -194,6 +194,7 @@ Style/PercentLiteralDelimiters: - 'config/initializers/content_security_policy.rb' - 'config/initializers/countries.rb' - 'config/initializers/doorkeeper.rb' + - 'config/initializers/enumerator_next_patch.rb' - 'config/initializers/fog_core_patch.rb' - 'config/initializers/forbid_sidekiq_in_transactions.rb' - 'config/initializers/health_check.rb' @@ -234,6 +235,8 @@ Style/PercentLiteralDelimiters: - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - 'ee/app/controllers/ee/projects/service_desk_controller.rb' - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' + - 'ee/app/controllers/groups/protected_environments_controller.rb' + - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' - 'ee/app/controllers/projects/protected_environments_controller.rb' - 'ee/app/controllers/trials_controller.rb' - 'ee/app/finders/iterations_finder.rb' @@ -241,6 +244,7 @@ Style/PercentLiteralDelimiters: - 'ee/app/helpers/credentials_inventory_helper.rb' - 'ee/app/helpers/ee/auth_helper.rb' - 'ee/app/helpers/ee/dashboard_helper.rb' + - 'ee/app/helpers/ee/integrations_helper.rb' - 'ee/app/helpers/ee/issues_helper.rb' - 'ee/app/helpers/ee/labels_helper.rb' - 'ee/app/helpers/ee/nav_helper.rb' @@ -264,12 +268,13 @@ Style/PercentLiteralDelimiters: - 'ee/app/models/geo/project_registry.rb' - 'ee/app/models/geo/secondary_usage_data.rb' - 'ee/app/models/geo_node_status.rb' - - 'ee/app/models/gitlab_subscription.rb' + - 'ee/app/models/incident_management/issuable_resource_link.rb' - 'ee/app/models/integrations/github.rb' - 'ee/app/models/integrations/gitlab_slack_application.rb' - 'ee/app/models/merge_requests/status_check_response.rb' - 'ee/app/models/saml_provider.rb' - 'ee/app/models/security/orchestration_policy_configuration.rb' + - 'ee/app/models/software_license_policy.rb' - 'ee/app/models/storage_shard.rb' - 'ee/app/services/approval_rules/create_service.rb' - 'ee/app/services/boards/epic_boards/update_service.rb' @@ -284,11 +289,13 @@ Style/PercentLiteralDelimiters: - 'ee/app/services/requirements_management/export_csv_service.rb' - 'ee/app/services/security/configuration/save_auto_fix_service.rb' - 'ee/app/services/security/dependency_list_service.rb' - - 'ee/lib/api/managed_licenses.rb' + - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb' + - 'ee/elastic/migrate/20220613120500_migrate_commits_to_separate_index.rb' - 'ee/lib/api/status_checks.rb' - 'ee/lib/api/visual_review_discussions.rb' - 'ee/lib/ee/api/helpers/members_helpers.rb' - 'ee/lib/ee/api/helpers/projects_helpers.rb' + - 'ee/lib/ee/api/members.rb' - 'ee/lib/ee/api/search.rb' - 'ee/lib/ee/audit/group_changes_auditor.rb' - 'ee/lib/ee/gitlab/alert_management/payload/generic.rb' @@ -320,6 +327,7 @@ Style/PercentLiteralDelimiters: - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' - 'ee/spec/controllers/groups/sso_controller_spec.rb' - 'ee/spec/controllers/projects/issues_controller_spec.rb' + - 'ee/spec/controllers/projects/legacy_pipelines_controller_spec.rb' - 'ee/spec/controllers/projects/pipelines_controller_spec.rb' - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' - 'ee/spec/elastic_integration/global_search_spec.rb' @@ -349,6 +357,7 @@ Style/PercentLiteralDelimiters: - 'ee/spec/graphql/types/vulnerable_projects_by_grade_type_spec.rb' - 'ee/spec/helpers/ee/application_settings_helper_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' + - 'ee/spec/helpers/ee/environments_helper_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' - 'ee/spec/helpers/ee/labels_helper_spec.rb' - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' @@ -359,6 +368,7 @@ Style/PercentLiteralDelimiters: - 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb' + - 'ee/spec/lib/ee/backup/repositories_spec.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/config_spec.rb' @@ -367,7 +377,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/groups_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/reports/security/reports_spec.rb' - - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_design_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' - 'ee/spec/lib/ee/gitlab/security/scan_configuration_spec.rb' @@ -380,6 +389,7 @@ Style/PercentLiteralDelimiters: - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/adapter_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' + - 'ee/spec/lib/gitlab/auth/saml/membership_updater_spec.rb' - 'ee/spec/lib/gitlab/auth/saml/user_spec.rb' - 'ee/spec/lib/gitlab/authority_analyzer_spec.rb' - 'ee/spec/lib/gitlab/cache_spec.rb' @@ -387,7 +397,7 @@ Style/PercentLiteralDelimiters: - 'ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/sast_iac_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/sast_iac_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/sast_latest_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/secret_detection_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/templates/secret_detection_latest_gitlab_ci_yaml_spec.rb' @@ -411,11 +421,11 @@ Style/PercentLiteralDelimiters: - 'ee/spec/models/concerns/ee/issuable_spec.rb' - 'ee/spec/models/concerns/ee/project_security_scanners_information_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' + - 'ee/spec/models/ee/ci/runner_spec.rb' - 'ee/spec/models/ee/groups/feature_setting_spec.rb' - 'ee/spec/models/ee/integration_spec.rb' - 'ee/spec/models/ee/integrations/jira_spec.rb' - 'ee/spec/models/ee/personal_access_token_spec.rb' - - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/project_feature_spec.rb' @@ -423,7 +433,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/models/push_rule_spec.rb' - 'ee/spec/models/repository_spec.rb' - 'ee/spec/models/saml_provider_spec.rb' - - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' - 'ee/spec/models/security/scan_spec.rb' - 'ee/spec/models/vulnerabilities/historical_statistic_spec.rb' - 'ee/spec/models/vulnerabilities/stat_diff_spec.rb' @@ -435,6 +444,7 @@ Style/PercentLiteralDelimiters: - 'ee/spec/requests/admin/user_permission_exports_controller_spec.rb' - 'ee/spec/requests/api/dependencies_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' + - 'ee/spec/requests/api/geo_spec.rb' - 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/update_spec.rb' - 'ee/spec/requests/api/graphql/project/alert_management/http_integrations_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' @@ -443,11 +453,13 @@ Style/PercentLiteralDelimiters: - 'ee/spec/requests/api/merge_requests_spec.rb' - 'ee/spec/requests/api/scim_spec.rb' - 'ee/spec/requests/api/wikis_spec.rb' + - 'ee/spec/requests/lfs_locks_api_spec.rb' - 'ee/spec/serializers/merge_request_widget_entity_spec.rb' - 'ee/spec/services/admin/email_service_spec.rb' - 'ee/spec/services/base_count_service_spec.rb' - 'ee/spec/services/ci/compare_security_reports_service_spec.rb' - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' + - 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb' - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' - 'ee/spec/services/ee/members/create_service_spec.rb' - 'ee/spec/services/ee/protected_branches/create_service_spec.rb' @@ -507,6 +519,7 @@ Style/PercentLiteralDelimiters: - 'lib/banzai/filter/table_of_contents_filter.rb' - 'lib/banzai/pipeline/base_pipeline.rb' - 'lib/banzai/pipeline/description_pipeline.rb' + - 'lib/banzai/pipeline/incident_management/timeline_event_pipeline.rb' - 'lib/bitbucket/page.rb' - 'lib/bitbucket/representation/issue.rb' - 'lib/container_registry/path.rb' @@ -520,6 +533,7 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/asciidoc/syntax_highlighter/html_pipeline_adapter.rb' - 'lib/gitlab/auth/ldap/adapter.rb' - 'lib/gitlab/auth/ldap/config.rb' + - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - 'lib/gitlab/bare_repository_import/importer.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/config/entry/bridge.rb' @@ -547,7 +561,7 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/gitaly_client.rb' - 'lib/gitlab/gitaly_client/diff.rb' - 'lib/gitlab/gitaly_client/wiki_page.rb' - - 'lib/gitlab/graphql/pagination/keyset/order_info.rb' + - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - 'lib/gitlab/hotlinking_detector.rb' - 'lib/gitlab/import_export/command_line_util.rb' - 'lib/gitlab/import_export/file_importer.rb' @@ -568,9 +582,10 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/metrics/transaction.rb' - 'lib/gitlab/metrics/web_transaction.rb' - 'lib/gitlab/middleware/read_only/controller.rb' - - 'lib/gitlab/process_supervisor.rb' - 'lib/gitlab/project_search_results.rb' - 'lib/gitlab/prometheus/query_variables.rb' + - 'lib/gitlab/query_limiting/transaction.rb' + - 'lib/gitlab/redis/multi_store.rb' - 'lib/gitlab/reference_extractor.rb' - 'lib/gitlab/regex.rb' - 'lib/gitlab/sanitizers/exception_message.rb' @@ -584,11 +599,14 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/task_helpers.rb' - 'lib/gitlab/uploads/migration_helper.rb' - 'lib/gitlab/url_blocker.rb' + - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb' - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' + - 'lib/gitlab/usage/metrics/instrumentations/numbers_metric.rb' - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data/topology.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - 'lib/gitlab/utils/sanitize_node_link.rb' + - 'lib/gitlab/web_hooks/rate_limiter.rb' - 'lib/gitlab/workhorse.rb' - 'lib/grafana/validator.rb' - 'lib/omni_auth/strategies/jwt.rb' @@ -614,40 +632,37 @@ Style/PercentLiteralDelimiters: - 'qa/qa/ee/page/project/show.rb' - 'qa/qa/ee/page/project/snippet/index.rb' - 'qa/qa/ee/page/project/wiki/show.rb' - - 'qa/qa/git/repository.rb' - 'qa/qa/resource/events/project.rb' - - 'qa/qa/resource/members.rb' + - 'qa/qa/resource/personal_access_token_cache.rb' - 'qa/qa/resource/visibility.rb' - - 'qa/qa/runtime/browser.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/api/3_create/gitaly/praefect_repo_sync_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' + - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - 'qa/spec/git/repository_spec.rb' - 'qa/spec/page/view_spec.rb' - - 'qa/spec/support/page_error_checker_spec.rb' + - 'rubocop/cop/migration/background_migrations.rb' - 'rubocop/cop/rspec/httparty_basic_auth.rb' - 'rubocop/migration_helpers.rb' + - 'scripts/qa/quarantine-types-check' - 'scripts/qa/testcases-check' - 'scripts/regenerate-schema' + - 'scripts/undercoverage' - 'sidekiq_cluster/cli.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/commands/sidekiq_cluster/cli_spec.rb' + - 'spec/components/pajamas/component_spec.rb' - 'spec/config/mail_room_spec.rb' - - 'spec/controllers/admin/clusters_controller_spec.rb' - 'spec/controllers/concerns/continue_params_spec.rb' - 'spec/controllers/graphql_controller_spec.rb' - - 'spec/controllers/groups/clusters_controller_spec.rb' - 'spec/controllers/groups/releases_controller_spec.rb' - 'spec/controllers/jira_connect/app_descriptor_controller_spec.rb' - 'spec/controllers/oauth/applications_controller_spec.rb' - 'spec/controllers/profiles/two_factor_auths_controller_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - - 'spec/controllers/projects/clusters_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - 'spec/controllers/projects/environments/prometheus_api_controller_spec.rb' - 'spec/controllers/projects/environments_controller_spec.rb' @@ -663,7 +678,6 @@ Style/PercentLiteralDelimiters: - 'spec/controllers/search_controller_spec.rb' - 'spec/controllers/snippets_controller_spec.rb' - 'spec/db/docs_spec.rb' - - 'spec/db/schema_spec.rb' - 'spec/experiments/ios_specific_templates_experiment_spec.rb' - 'spec/factories/ci/builds.rb' - 'spec/factories/ci/runners.rb' @@ -689,6 +703,8 @@ Style/PercentLiteralDelimiters: - 'spec/features/projects/integrations/user_activates_jira_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/labels/issues_sorted_by_priority_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/pipelines/pipelines_spec.rb' - 'spec/features/protected_branches_spec.rb' @@ -700,7 +716,6 @@ Style/PercentLiteralDelimiters: - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/environments/environments_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - - 'spec/finders/issues_finder_spec.rb' - 'spec/finders/license_template_finder_spec.rb' - 'spec/finders/merge_requests_finder_spec.rb' - 'spec/finders/tags_finder_spec.rb' @@ -724,19 +739,24 @@ Style/PercentLiteralDelimiters: - 'spec/helpers/clusters_helper_spec.rb' - 'spec/helpers/diff_helper_spec.rb' - 'spec/helpers/emails_helper_spec.rb' + - 'spec/helpers/issuables_description_templates_helper_spec.rb' - 'spec/helpers/issues_helper_spec.rb' - 'spec/helpers/nav_helper_spec.rb' - 'spec/helpers/page_layout_helper_spec.rb' - 'spec/helpers/profiles_helper_spec.rb' - 'spec/helpers/releases_helper_spec.rb' + - 'spec/helpers/storage_helper_spec.rb' - 'spec/helpers/tracking_helper_spec.rb' - 'spec/initializers/direct_upload_support_spec.rb' + - 'spec/initializers/enumerator_next_patch_spec.rb' - 'spec/initializers/rack_multipart_patch_spec.rb' - 'spec/lib/api/ci/helpers/runner_helpers_spec.rb' + - 'spec/lib/api/entities/user_spec.rb' - 'spec/lib/api/helpers/common_helpers_spec.rb' - 'spec/lib/atlassian/jira_connect/client_spec.rb' - 'spec/lib/backup/files_spec.rb' - 'spec/lib/backup/manager_spec.rb' + - 'spec/lib/backup/repositories_spec.rb' - 'spec/lib/banzai/filter/asset_proxy_filter_spec.rb' - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb' @@ -760,6 +780,7 @@ Style/PercentLiteralDelimiters: - 'spec/lib/banzai/pipeline/description_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' + - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - 'spec/lib/banzai/reference_parser/commit_parser_spec.rb' @@ -777,6 +798,8 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' + - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' + - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/batch_worker_context_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' @@ -784,6 +807,7 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/ci/ansi2html_spec.rb' - 'spec/lib/gitlab/ci/config/entry/bridge_spec.rb' - 'spec/lib/gitlab/ci/config/entry/commands_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/environment_spec.rb' - 'spec/lib/gitlab/ci/config/entry/image_spec.rb' - 'spec/lib/gitlab/ci/config/entry/root_spec.rb' - 'spec/lib/gitlab/ci/config/entry/service_spec.rb' @@ -793,6 +817,7 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/ci/pipeline/chain/template_usage_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/equals_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/seed/deployment_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb' - 'spec/lib/gitlab/ci/reports/security/reports_spec.rb' @@ -801,6 +826,7 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/ci/status/stage/factory_spec.rb' - 'spec/lib/gitlab/ci/templates/5_minute_production_app_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/Jobs/deploy_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Jobs/sast_iac_latest_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/variables/collection/item_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor/dag_spec.rb' @@ -844,7 +870,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/favicon_spec.rb' - 'spec/lib/gitlab/feature_categories_spec.rb' - 'spec/lib/gitlab/file_detector_spec.rb' - - 'spec/lib/gitlab/form_builders/gitlab_ui_form_builder_spec.rb' - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb' - 'spec/lib/gitlab/git/merge_base_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' @@ -887,6 +912,7 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/middleware/go_spec.rb' - 'spec/lib/gitlab/middleware/multipart_spec.rb' - 'spec/lib/gitlab/omniauth_initializer_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' - 'spec/lib/gitlab/pagination/offset_header_builder_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/popen_spec.rb' @@ -939,6 +965,8 @@ Style/PercentLiteralDelimiters: - 'spec/lib/system_check/orphans/repository_check_spec.rb' - 'spec/lib/system_check/sidekiq_check_spec.rb' - 'spec/lib/tasks/gitlab/metrics_exporter_task_spec.rb' + - 'spec/lib/unnested_in_filters/dsl_spec.rb' + - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' - 'spec/migrations/add_new_trail_plans_spec.rb' - 'spec/migrations/change_web_hook_events_default_spec.rb' @@ -984,7 +1012,6 @@ Style/PercentLiteralDelimiters: - 'spec/models/issue_spec.rb' - 'spec/models/members/member_task_spec.rb' - 'spec/models/merge_request_diff_spec.rb' - - 'spec/models/namespace_spec.rb' - 'spec/models/namespace_statistics_spec.rb' - 'spec/models/packages/package_spec.rb' - 'spec/models/packages/tag_spec.rb' @@ -1020,6 +1047,8 @@ Style/PercentLiteralDelimiters: - 'spec/requests/api/ci/triggers_spec.rb' - 'spec/requests/api/container_repositories_spec.rb' - 'spec/requests/api/deployments_spec.rb' + - 'spec/requests/api/geo_spec.rb' + - 'spec/requests/api/graphql/ci/manual_variables_spec.rb' - 'spec/requests/api/graphql/gitlab_schema_spec.rb' - 'spec/requests/api/graphql/group/container_repositories_spec.rb' - 'spec/requests/api/graphql/group/milestones_spec.rb' @@ -1045,6 +1074,7 @@ Style/PercentLiteralDelimiters: - 'spec/requests/api/issues/put_projects_issues_spec.rb' - 'spec/requests/api/members_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' + - 'spec/requests/api/metadata_spec.rb' - 'spec/requests/api/project_container_repositories_spec.rb' - 'spec/requests/api/project_templates_spec.rb' - 'spec/requests/api/projects_spec.rb' @@ -1063,6 +1093,7 @@ Style/PercentLiteralDelimiters: - 'spec/requests/lfs_locks_api_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/uploads_routing_spec.rb' + - 'spec/rubocop/cop/migration/migration_record_spec.rb' - 'spec/rubocop/cop/migration/prevent_index_creation_spec.rb' - 'spec/rubocop/cop/migration/sidekiq_queue_migrate_spec.rb' - 'spec/rubocop/cop/performance/readlines_each_spec.rb' @@ -1143,6 +1174,7 @@ Style/PercentLiteralDelimiters: - 'spec/support/shared_examples/features/wiki/user_creates_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_updates_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' + - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' - 'spec/support/shared_examples/lib/banzai/filters/sanitization_filter_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/middleware/multipart_shared_examples.rb' - 'spec/support/shared_examples/metrics/transaction_metrics_with_labels_shared_examples.rb' @@ -1165,6 +1197,7 @@ Style/PercentLiteralDelimiters: - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/tasks/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/uploads/migrate_rake_spec.rb' + - 'spec/tooling/danger/customer_success_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' - 'spec/tooling/lib/tooling/test_map_generator_spec.rb' @@ -1186,7 +1219,6 @@ Style/PercentLiteralDelimiters: - 'spec/uploaders/pages/deployment_uploader_spec.rb' - 'spec/uploaders/personal_file_uploader_spec.rb' - 'spec/validators/any_field_validator_spec.rb' - - 'spec/views/layouts/_flash.html.haml_spec.rb' - 'spec/views/layouts/_head.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/projects/commit/branches.html.haml_spec.rb' diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml index 0d3651eb7b2..3747312f2c4 100644 --- a/.rubocop_todo/style/redundant_interpolation.yml +++ b/.rubocop_todo/style/redundant_interpolation.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Style/RedundantInterpolation: - # Offense count: 285 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/components/diffs/stats_component.rb' - 'app/helpers/blob_helper.rb' @@ -13,7 +10,10 @@ Style/RedundantInterpolation: - 'app/helpers/environments_helper.rb' - 'app/helpers/icons_helper.rb' - 'app/helpers/issuables_helper.rb' + - 'app/helpers/nav_helper.rb' + - 'app/helpers/projects_helper.rb' - 'app/helpers/search_helper.rb' + - 'app/helpers/tooling/visual_review_helper.rb' - 'app/models/concerns/issuable.rb' - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/hangouts_chat.rb' @@ -24,6 +24,7 @@ Style/RedundantInterpolation: - 'app/services/users/approve_service.rb' - 'app/services/users/banned_user_base_service.rb' - 'app/services/users/reject_service.rb' + - 'db/post_migrate/20220420214703_schedule_backfill_draft_status_on_merge_requests_corrected_regex.rb' - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_reason_enum.rb' - 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb' - 'ee/app/helpers/ee/ci/runners_helper.rb' @@ -31,23 +32,29 @@ Style/RedundantInterpolation: - 'ee/app/services/geo/event_store.rb' - 'ee/app/services/geo/repository_updated_service.rb' - 'ee/app/services/security/security_orchestration_policies/create_pipeline_service.rb' + - 'ee/app/services/users/abuse/excessive_projects_download_ban_service.rb' + - 'ee/app/services/users/abuse/git_abuse/namespace_throttle_service.rb' - 'ee/db/fixtures/development/31_devops_adoption.rb' + - 'ee/lib/gitlab/insights/serializers/chartjs/base_serializer.rb' - 'ee/spec/features/epics/epic_issues_spec.rb' - 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb' - 'ee/spec/features/registrations/one_trust_spec.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' - 'ee/spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - - 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' + - 'ee/spec/lib/gitlab/insights/serializers/chartjs/line_serializer_spec.rb' + - 'ee/spec/lib/gitlab/insights/serializers/chartjs/multi_series_serializer_spec.rb' - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb' - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb' - 'ee/spec/requests/api/issues_spec.rb' - 'ee/spec/requests/api/search_spec.rb' + - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - 'ee/spec/services/search_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' + - 'ee/spec/support/shared_contexts/lib/gitlab/insights/serializers/serializers_shared_context.rb' - 'ee/spec/support/shared_examples/lib/gitlab/elastic/standalone_indices_shared_examples.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - 'lib/backup/manager.rb' @@ -72,15 +79,19 @@ Style/RedundantInterpolation: - 'lib/gitlab/utils.rb' - 'lib/kramdown/converter/commonmark.rb' - 'lib/tasks/gettext.rake' + - 'lib/tasks/gitlab/seed/group_seed.rake' + - 'qa/qa/ee/page/component/secure_report.rb' - 'qa/qa/ee/page/merge_request/new.rb' - 'qa/qa/ee/page/project/issue/show.rb' + - 'qa/qa/ee/page/project/secure/vulnerability_details.rb' - 'qa/qa/resource/events/base.rb' - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/scan_result_policy_vulnerabilities_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/project_templates_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/4_verify/parent_child_pipelines_dependent_relationship_spec.rb' - 'qa/qa/tools/generate_perf_testdata.rb' - - 'scripts/changed-feature-flags' - 'scripts/perf/gc/print_gc_stats.rb' - 'scripts/qa/testcases-check' - 'spec/controllers/admin/integrations_controller_spec.rb' @@ -93,6 +104,7 @@ Style/RedundantInterpolation: - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' - 'spec/graphql/resolvers/container_repositories_resolver_spec.rb' - 'spec/helpers/environments_helper_spec.rb' + - 'spec/helpers/snippets_helper_spec.rb' - 'spec/lib/api/helpers/packages/dependency_proxy_helpers_spec.rb' - 'spec/lib/api/validations/validators/git_ref_spec.rb' - 'spec/lib/api/validations/validators/limit_spec.rb' @@ -116,7 +128,9 @@ Style/RedundantInterpolation: - 'spec/lib/gitlab/database/batch_count_spec.rb' - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' + - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/url_spec.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' - 'spec/lib/grafana/client_spec.rb' - 'spec/mailers/notify_spec.rb' - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' @@ -134,7 +148,6 @@ Style/RedundantInterpolation: - 'spec/requests/api/terraform/state_spec.rb' - 'spec/requests/projects/google_cloud/deployments_controller_spec.rb' - 'spec/requests/projects/google_cloud/service_accounts_controller_spec.rb' - - 'spec/requests/projects/google_cloud_controller_spec.rb' - 'spec/routing/project_routing_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' diff --git a/.rubocop_todo/style/redundant_regexp_escape.yml b/.rubocop_todo/style/redundant_regexp_escape.yml index cf502711f35..5c97275ee4b 100644 --- a/.rubocop_todo/style/redundant_regexp_escape.yml +++ b/.rubocop_todo/style/redundant_regexp_escape.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Style/RedundantRegexpEscape: - # Offense count: 325 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/help_controller.rb' - 'app/controllers/import/bitbucket_server_controller.rb' @@ -16,6 +13,7 @@ Style/RedundantRegexpEscape: - 'app/models/integrations/chat_message/base_message.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/teamcity.rb' + - 'app/models/issue.rb' - 'app/models/label.rb' - 'app/models/license_template.rb' - 'app/models/milestone.rb' @@ -25,6 +23,7 @@ Style/RedundantRegexpEscape: - 'app/models/snippet.rb' - 'app/services/metrics/dashboard/grafana_metric_embed_service.rb' - 'app/uploaders/file_uploader.rb' + - 'config/initializers/wikicloth_redos_patch.rb' - 'config/routes/project.rb' - 'config/routes/uploads.rb' - 'ee/app/models/ee/epic.rb' @@ -37,18 +36,20 @@ Style/RedundantRegexpEscape: - 'ee/spec/features/read_only_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_counters/hll_redis_counter_spec.rb' + - 'ee/spec/mailers/ee/emails/admin_notification_spec.rb' + - 'ee/spec/mailers/ee/emails/profile_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/models/release_highlight_spec.rb' - 'ee/spec/support/shared_examples/services/group_saml/saml_provider/base_service_shared_examples.rb' - 'lib/api/templates.rb' - 'lib/banzai/filter/autolink_filter.rb' - 'lib/banzai/filter/inline_diff_filter.rb' + - 'lib/banzai/filter/task_list_filter.rb' - 'lib/bulk_imports/common/pipelines/uploads_pipeline.rb' - 'lib/csv_builder.rb' - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - 'lib/gitlab/ci/pipeline/expression/lexeme/not_matches.rb' - 'lib/gitlab/ci/pipeline/expression/lexeme/pattern.rb' - - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/diff/suggestions_parser.rb' - 'lib/gitlab/email/handler/create_issue_handler.rb' - 'lib/gitlab/email/handler/create_merge_request_handler.rb' @@ -57,7 +58,8 @@ Style/RedundantRegexpEscape: - 'lib/gitlab/email/reply_parser.rb' - 'lib/gitlab/git/diff.rb' - 'lib/gitlab/git/repository.rb' - - 'lib/gitlab/gitaly_client/operation_service.rb' + - 'lib/gitlab/gitaly_client.rb' + - 'lib/gitlab/harbor/query.rb' - 'lib/gitlab/incoming_email.rb' - 'lib/gitlab/jira/dvcs.rb' - 'lib/gitlab/path_regex.rb' @@ -66,6 +68,7 @@ Style/RedundantRegexpEscape: - 'lib/gitlab/quick_actions/extractor.rb' - 'lib/gitlab/regex.rb' - 'lib/gitlab/search/abuse_detection.rb' + - 'lib/gitlab/service_desk_email.rb' - 'lib/gitlab/task_helpers.rb' - 'lib/gitlab/url_sanitizer.rb' - 'lib/gitlab/utils.rb' @@ -87,6 +90,7 @@ Style/RedundantRegexpEscape: - 'spec/helpers/tab_helper_spec.rb' - 'spec/lib/banzai/filter/references/reference_filter_spec.rb' - 'spec/lib/banzai/filter/syntax_highlight_filter_spec.rb' + - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_work_item_type_id_for_issues_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' @@ -96,6 +100,7 @@ Style/RedundantRegexpEscape: - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' + - 'spec/mailers/emails/profile_spec.rb' - 'spec/models/release_highlight_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/set_draft_spec.rb' - 'spec/requests/api/graphql_spec.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 9951160ae02..65f2ea327d7 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -1,12 +1,11 @@ --- # Cop supports --auto-correct. Style/RedundantSelf: - # Offense count: 1222 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'app/channels/awareness_channel.rb' - 'app/controllers/application_controller.rb' - 'app/finders/security/jobs_finder.rb' + - 'app/graphql/types/permission_types/base_permission_type.rb' - 'app/models/abuse_report.rb' - 'app/models/analytics/usage_trends/measurement.rb' - 'app/models/application_record.rb' @@ -74,6 +73,7 @@ Style/RedundantSelf: - 'app/models/concerns/merge_request_reviewer_state.rb' - 'app/models/concerns/noteable.rb' - 'app/models/concerns/packages/debian/distribution.rb' + - 'app/models/concerns/participable.rb' - 'app/models/concerns/pg_full_text_searchable.rb' - 'app/models/concerns/protected_ref.rb' - 'app/models/concerns/protected_ref_access.rb' @@ -102,6 +102,7 @@ Style/RedundantSelf: - 'app/models/gpg_key.rb' - 'app/models/group.rb' - 'app/models/group_group_link.rb' + - 'app/models/hooks/web_hook_log.rb' - 'app/models/identity.rb' - 'app/models/integration.rb' - 'app/models/integrations/base_chat_notification.rb' @@ -112,6 +113,7 @@ Style/RedundantSelf: - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' + - 'app/models/integrations/slack.rb' - 'app/models/integrations/zentao.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' @@ -125,11 +127,10 @@ Style/RedundantSelf: - 'app/models/member.rb' - 'app/models/members/project_member.rb' - 'app/models/merge_request.rb' + - 'app/models/merge_request/cleanup_schedule.rb' - 'app/models/merge_request/metrics.rb' - - 'app/models/merge_request_assignee.rb' - 'app/models/merge_request_diff.rb' - 'app/models/merge_request_diff_commit.rb' - - 'app/models/merge_request_reviewer.rb' - 'app/models/namespaces/traversal/linear.rb' - 'app/models/note.rb' - 'app/models/packages/dependency.rb' @@ -179,10 +180,11 @@ Style/RedundantSelf: - 'app/uploaders/gitlab_uploader.rb' - 'app/uploaders/object_storage.rb' - 'app/workers/background_migration/single_database_worker.rb' + - 'app/workers/build_hooks_worker.rb' - 'app/workers/concerns/application_worker.rb' - 'app/workers/concerns/limited_capacity/worker.rb' - 'app/workers/concerns/project_start_import.rb' - - 'app/workers/concerns/waitable_worker.rb' + - 'app/workers/concerns/reenqueuer.rb' - 'app/workers/database/batched_background_migration/single_database_worker.rb' - 'app/workers/group_import_worker.rb' - 'app/workers/project_export_worker.rb' @@ -193,6 +195,7 @@ Style/RedundantSelf: - 'db/post_migrate/20210329102724_add_new_trail_plans.rb' - 'db/post_migrate/20211029102822_add_open_source_plan.rb' - 'ee/app/graphql/resolvers/geo/registries_resolver.rb' + - 'ee/app/models/approval_merge_request_rule.rb' - 'ee/app/models/approval_project_rule.rb' - 'ee/app/models/concerns/approval_rule_like.rb' - 'ee/app/models/concerns/custom_model_naming.rb' @@ -216,9 +219,12 @@ Style/RedundantSelf: - 'ee/app/models/ee/description_version.rb' - 'ee/app/models/ee/environment.rb' - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/group_member.rb' - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/iteration.rb' + - 'ee/app/models/ee/member.rb' + - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/packages/package_file.rb' - 'ee/app/models/ee/project.rb' @@ -247,13 +253,17 @@ Style/RedundantSelf: - 'ee/lib/ee/gitlab/auth/ldap/sync/groups.rb' - 'ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb' - 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' + - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' + - 'ee/lib/ee/gitlab/database.rb' - 'ee/lib/ee/gitlab/tracking.rb' - 'ee/lib/ee/legacy_model.rb' - 'ee/lib/ee/model.rb' - 'ee/lib/elastic/instance_proxy_util.rb' - 'ee/lib/elastic/latest/application_class_proxy.rb' + - 'ee/lib/elastic/latest/commit_config.rb' - 'ee/lib/elastic/latest/issue_config.rb' - 'ee/lib/elastic/latest/merge_request_config.rb' - 'ee/lib/elastic/latest/note_config.rb' @@ -275,9 +285,9 @@ Style/RedundantSelf: - 'ee/lib/gitlab/geo/oauth/logout_state.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/template/custom_template.rb' + - 'ee/lib/system_check/app/search_check.rb' - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/graph_helper_spec.rb' - - 'ee/spec/models/geo/deleted_project_spec.rb' - 'lib/api/entities/wiki_attachment.rb' - 'lib/api/helpers.rb' - 'lib/api/helpers/packages_helpers.rb' @@ -328,6 +338,7 @@ Style/RedundantSelf: - 'lib/gitlab/database/load_balancing/service_discovery.rb' - 'lib/gitlab/database/loose_foreign_keys.rb' - 'lib/gitlab/database/migration_helpers/restrict_gitlab_schema.rb' + - 'lib/gitlab/database/migrations/background_migration_helpers.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' - 'lib/gitlab/database/query_analyzers/base.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' @@ -339,6 +350,7 @@ Style/RedundantSelf: - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - 'lib/gitlab/email/smtp_config.rb' + - 'lib/gitlab/error_tracking/logger.rb' - 'lib/gitlab/feature_categories.rb' - 'lib/gitlab/git.rb' - 'lib/gitlab/git/blob.rb' @@ -347,6 +359,7 @@ Style/RedundantSelf: - 'lib/gitlab/git/tree.rb' - 'lib/gitlab/git_access.rb' - 'lib/gitlab/github_import.rb' + - 'lib/gitlab/graphql/deprecations_base.rb' - 'lib/gitlab/graphql/known_operations.rb' - 'lib/gitlab/graphql/lazy.rb' - 'lib/gitlab/graphql/representation/submodule_tree_entry.rb' @@ -399,10 +412,10 @@ Style/RedundantSelf: - 'lib/system_check/rake_task/rake_task_helpers.rb' - 'lib/uploaded_file.rb' - 'qa/lib/gitlab/page/main/sign_up.rb' - - 'qa/qa/git/repository.rb' - 'qa/qa/page/validatable.rb' - 'qa/qa/resource/base.rb' - 'qa/qa/resource/events/project.rb' + - 'qa/qa/resource/personal_access_token.rb' - 'qa/qa/resource/protected_branch.rb' - 'qa/qa/resource/reusable.rb' - 'qa/qa/resource/user_gpg.rb' @@ -416,6 +429,8 @@ Style/RedundantSelf: - 'spec/helpers/graph_helper_spec.rb' - 'spec/helpers/ide_helper_spec.rb' - 'spec/helpers/submodule_helper_spec.rb' + - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' + - 'spec/models/integration_spec.rb' - 'spec/support/before_all_adapter.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/style/rescue_modifier.yml b/.rubocop_todo/style/rescue_modifier.yml deleted file mode 100644 index 298ef3aece9..00000000000 --- a/.rubocop_todo/style/rescue_modifier.yml +++ /dev/null @@ -1,51 +0,0 @@ ---- -# Cop supports --auto-correct. -Style/RescueModifier: - # Offense count: 59 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'app/controllers/admin/system_info_controller.rb' - - 'app/controllers/users_controller.rb' - - 'app/finders/ci/daily_build_group_report_results_finder.rb' - - 'app/helpers/blob_helper.rb' - - 'app/models/concerns/diff_positionable_note.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/sent_notification.rb' - - 'app/models/todo.rb' - - 'app/services/security/ci_configuration/sast_parser_service.rb' - - 'config/initializers/active_record_data_types.rb' - - 'config/settings.rb' - - 'ee/app/models/license.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/gitlab/geo.rb' - - 'ee/lib/gitlab/geo/health_check.rb' - - 'lib/api/helpers.rb' - - 'lib/feature.rb' - - 'lib/gitlab/current_settings.rb' - - 'lib/gitlab/dependency_linker/cargo_toml_linker.rb' - - 'lib/gitlab/dependency_linker/json_linker.rb' - - 'lib/gitlab/diff/parser.rb' - - 'lib/gitlab/import_export/after_export_strategy_builder.rb' - - 'lib/gitlab/kubernetes.rb' - - 'lib/gitlab/middleware/read_only/controller.rb' - - 'lib/gitlab/process_management.rb' - - 'lib/gitlab/query_limiting/middleware.rb' - - 'lib/gitlab/quick_actions/command_definition.rb' - - 'lib/gitlab/quick_actions/spend_time_and_date_separator.rb' - - 'lib/gitlab/word_diff/segments/diff_hunk.rb' - - 'lib/gitlab/zentao/client.rb' - - 'lib/tasks/gitlab/praefect.rake' - - 'qa/qa/page/component/access_tokens.rb' - - 'qa/qa/page/profile/ssh_keys.rb' - - 'spec/finders/concerns/finder_with_cross_project_access_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/session_spec.rb' - - 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb' - - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/monitor_spec.rb' - - 'spec/models/concerns/bulk_insert_safe_spec.rb' - - 'spec/models/design_management/version_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/namespace/traversal_hierarchy_spec.rb' - - 'spec/services/design_management/delete_designs_service_spec.rb' - - 'spec/support/shared_examples/lib/gitlab/config/inheritable_shared_examples.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 8c8dbf86b1c..2330683cc18 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -1,10 +1,8 @@ --- # Cop supports --auto-correct. Style/StringConcatenation: - # Offense count: 611 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'app/components/pajamas/button_component.rb' - 'app/controllers/concerns/creates_commit.rb' - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' - 'app/controllers/jira_connect/app_descriptor_controller.rb' @@ -45,7 +43,6 @@ Style/StringConcatenation: - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - 'app/services/pages/zip_directory_service.rb' - - 'app/services/projects/update_pages_service.rb' - 'app/services/repositories/base_service.rb' - 'app/services/verify_pages_domain_service.rb' - 'app/uploaders/gitlab_uploader.rb' @@ -56,6 +53,7 @@ Style/StringConcatenation: - 'db/migrate/20210412111213_create_security_orchestration_policy_rule_schedule.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/finders/ee/issuables/label_filter.rb' + - 'ee/app/helpers/ee/geo_helper.rb' - 'ee/app/helpers/ee/gitlab_routing_helper.rb' - 'ee/app/helpers/ee/mirror_helper.rb' - 'ee/app/helpers/ee/search_helper.rb' @@ -70,6 +68,7 @@ Style/StringConcatenation: - 'ee/lib/api/project_mirror.rb' - 'ee/lib/ee/audit/project_changes_auditor.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - 'ee/lib/elastic/latest/git_class_proxy.rb' @@ -81,7 +80,6 @@ Style/StringConcatenation: - 'ee/spec/controllers/trial_registrations_controller_spec.rb' - 'ee/spec/features/boards/boards_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/search_helper_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' - 'ee/spec/lib/gitlab/auth/o_auth/user_spec.rb' @@ -94,8 +92,8 @@ Style/StringConcatenation: - 'ee/spec/models/dast_site_validation_spec.rb' - 'ee/spec/models/ee/audit_event_spec.rb' - 'ee/spec/models/geo_node_spec.rb' + - 'ee/spec/models/incident_management/issuable_resource_link_spec.rb' - 'ee/spec/models/status_page/project_setting_spec.rb' - - 'ee/spec/requests/api/internal/kubernetes_spec.rb' - 'ee/spec/services/jira/jql_builder_service_spec.rb' - 'ee/spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' @@ -138,6 +136,7 @@ Style/StringConcatenation: - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - 'lib/gitlab/lfs/client.rb' - 'lib/gitlab/logger.rb' + - 'lib/gitlab/pages/deployment_update.rb' - 'lib/gitlab/path_regex.rb' - 'lib/gitlab/prometheus/internal.rb' - 'lib/gitlab/quick_actions/extractor.rb' @@ -150,6 +149,7 @@ Style/StringConcatenation: - 'lib/gitlab/throttle.rb' - 'lib/gitlab/time_tracking_formatter.rb' - 'lib/gitlab/untrusted_regexp.rb' + - 'lib/gitlab/usage/metrics/instrumentations/issues_created_from_alerts_metric.rb' - 'lib/gitlab/usage_data_counters/quick_action_activity_unique_counter.rb' - 'lib/gitlab/usage_data_queries.rb' - 'lib/google_api/cloud_platform/client.rb' @@ -163,8 +163,8 @@ Style/StringConcatenation: - 'qa/qa/page/milestone/new.rb' - 'qa/qa/page/project/milestone/new.rb' - 'qa/qa/page/project/settings/deploy_tokens.rb' + - 'qa/qa/specs/features/browser_ui/3_create/source_editor/source_editor_toolbar_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/assign_code_owners_spec.rb' - - 'qa/qa/support/page_error_checker.rb' - 'qa/qa/tools/generate_perf_testdata.rb' - 'scripts/perf/gc/print_gc_stats.rb' - 'scripts/perf/query_limiting_report.rb' @@ -230,7 +230,6 @@ Style/StringConcatenation: - 'spec/lib/gitlab/gitaly_client/repository_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/wiki_service_spec.rb' - 'spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb' - - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/other_markup_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' @@ -246,6 +245,7 @@ Style/StringConcatenation: - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/gitlab/url_blocker_spec.rb' - 'spec/lib/gitlab/utils_spec.rb' + - 'spec/lib/gitlab/visibility_level_spec.rb' - 'spec/lib/gitlab/wiki_pages/front_matter_parser_spec.rb' - 'spec/lib/gitlab/workhorse_spec.rb' - 'spec/lib/kramdown/kramdown_spec.rb' @@ -288,12 +288,14 @@ Style/StringConcatenation: - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/notes_spec.rb' - 'spec/requests/api/pypi_packages_spec.rb' + - 'spec/requests/users_controller_spec.rb' - 'spec/routing/git_http_routing_spec.rb' - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - 'spec/services/clusters/gcp/finalize_creation_service_spec.rb' - 'spec/services/clusters/kubernetes/configure_istio_ingress_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' + - 'spec/services/groups/update_service_spec.rb' - 'spec/services/merge_requests/build_service_spec.rb' - 'spec/services/metrics/dashboard/grafana_metric_embed_service_spec.rb' - 'spec/services/packages/conan/create_package_file_service_spec.rb' @@ -303,6 +305,7 @@ Style/StringConcatenation: - 'spec/services/projects/create_service_spec.rb' - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/download_service_spec.rb' + - 'spec/services/projects/update_service_spec.rb' - 'spec/services/push_event_payload_service_spec.rb' - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/snippets/bulk_destroy_service_spec.rb' @@ -323,9 +326,9 @@ Style/StringConcatenation: - 'spec/support/shared_examples/lib/banzai/reference_parser_shared_examples.rb' - 'spec/support/shared_examples/models/packages/debian/distribution_shared_examples.rb' - 'spec/support/shared_examples/models/wiki_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - 'spec/support/shared_examples/requests/snippet_shared_examples.rb' - 'spec/support/unpack-gitlab-git-test' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' - 'spec/uploaders/job_artifact_uploader_spec.rb' - 'spec/validators/addressable_url_validator_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index ea3a505d2da..75aab7c6116 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Style/SymbolProc: - # Offense count: 341 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/admin/users_controller.rb' - 'app/controllers/concerns/renders_blob.rb' @@ -14,7 +11,10 @@ Style/SymbolProc: - 'app/controllers/profiles_controller.rb' - 'app/finders/packages/go/version_finder.rb' - 'app/graphql/mutations/commits/create.rb' + - 'app/graphql/mutations/concerns/mutations/work_items/widgetable.rb' - 'app/graphql/mutations/jira_import/start.rb' + - 'app/graphql/mutations/work_items/update_widgets.rb' + - 'app/graphql/types/work_items/widgets/description_type.rb' - 'app/helpers/graph_helper.rb' - 'app/models/ci/build_metadata.rb' - 'app/models/ci/build_trace_chunk.rb' @@ -24,6 +24,7 @@ Style/SymbolProc: - 'app/models/concerns/board_recent_visit.rb' - 'app/models/concerns/resolvable_discussion.rb' - 'app/models/container_repository.rb' + - 'app/models/deployment.rb' - 'app/models/discussion.rb' - 'app/models/environment.rb' - 'app/models/integrations/prometheus.rb' @@ -43,11 +44,9 @@ Style/SymbolProc: - 'app/serializers/build_details_entity.rb' - 'app/serializers/ci/pipeline_entity.rb' - 'app/serializers/ci/trigger_entity.rb' - - 'app/serializers/cluster_entity.rb' - 'app/serializers/deployment_cluster_entity.rb' - 'app/serializers/deployment_entity.rb' - 'app/serializers/draft_note_entity.rb' - - 'app/serializers/environment_entity.rb' - 'app/serializers/import/bitbucket_provider_repo_entity.rb' - 'app/serializers/import/fogbugz_provider_repo_entity.rb' - 'app/serializers/issuable_sidebar_basic_entity.rb' @@ -55,6 +54,7 @@ Style/SymbolProc: - 'app/serializers/linked_project_issue_entity.rb' - 'app/serializers/member_entity.rb' - 'app/serializers/member_user_entity.rb' + - 'app/serializers/merge_request_poll_widget_entity.rb' - 'app/serializers/merge_request_widget_entity.rb' - 'app/serializers/project_entity.rb' - 'app/serializers/project_mirror_entity.rb' @@ -69,7 +69,6 @@ Style/SymbolProc: - 'app/services/ci/update_build_state_service.rb' - 'app/services/clusters/agents/delete_expired_events_service.rb' - 'app/services/feature_flags/update_service.rb' - - 'app/services/google_cloud/enable_cloud_run_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/bulk_remove_attention_requested_service.rb' - 'app/services/merge_requests/reopen_service.rb' @@ -81,6 +80,7 @@ Style/SymbolProc: - 'app/workers/bulk_imports/stuck_import_worker.rb' - 'app/workers/ci/build_trace_chunk_flush_worker.rb' - 'app/workers/gitlab/import/stuck_import_job.rb' + - 'app/workers/merge_requests/update_head_pipeline_worker.rb' - 'app/workers/namespaces/prune_aggregation_schedules_worker.rb' - 'app/workers/stuck_export_jobs_worker.rb' - 'app/workers/update_head_pipeline_for_merge_request_worker.rb' @@ -92,6 +92,7 @@ Style/SymbolProc: - 'db/migrate/20210318134427_delete_security_findings_without_uuid.rb' - 'db/migrate/20210503105845_add_project_value_stream_id_to_project_stages.rb' - 'db/post_migrate/20220119094503_populate_audit_event_streaming_verification_token.rb' + - 'db/post_migrate/20220803042352_cleanup_mr_attention_request_todos.rb' - 'ee/app/helpers/ee/mirror_helper.rb' - 'ee/app/helpers/ee/registrations_helper.rb' - 'ee/app/models/concerns/epic_tree_sorting.rb' @@ -119,6 +120,7 @@ Style/SymbolProc: - 'ee/lib/ee/api/entities/geo_node.rb' - 'ee/lib/ee/api/entities/merge_request_approval_state.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' @@ -126,6 +128,7 @@ Style/SymbolProc: - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' - 'ee/lib/gitlab/custom_file_templates.rb' - 'ee/lib/gitlab/geo/oauth/logout_state.rb' + - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - 'ee/spec/factories/issues.rb' - 'ee/spec/features/billings/extend_reactivate_trial_spec.rb' - 'ee/spec/features/billings/qrtly_reconciliation_alert_spec.rb' @@ -133,13 +136,12 @@ Style/SymbolProc: - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/document_reference_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/services/groups/participants_service_spec.rb' - 'ee/spec/support/helpers/subscription_portal_helpers.rb' + - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' - 'lib/api/api_guard.rb' - 'lib/api/entities/board.rb' - - 'lib/api/entities/environment.rb' - 'lib/api/entities/issuable_references.rb' - 'lib/api/entities/merge_request_approvals.rb' - 'lib/api/entities/package.rb' @@ -148,7 +150,6 @@ Style/SymbolProc: - 'lib/api/go_proxy.rb' - 'lib/api/helpers/internal_helpers.rb' - 'lib/api/package_files.rb' - - 'lib/api/terraform/state.rb' - 'lib/atlassian/jira_connect/serializers/base_entity.rb' - 'lib/banzai/filter/inline_cluster_metrics_filter.rb' - 'lib/banzai/filter/inline_embeds_filter.rb' @@ -157,6 +158,7 @@ Style/SymbolProc: - 'lib/container_registry/client.rb' - 'lib/container_registry/gitlab_api_client.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_events.rb' + - 'lib/gitlab/auth/o_auth/auth_hash.rb' - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' @@ -164,7 +166,6 @@ Style/SymbolProc: - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/checks/changes_access.rb' - 'lib/gitlab/ci/pipeline/preloader.rb' - - 'lib/gitlab/ci/runner_upgrade_check.rb' - 'lib/gitlab/ci/trace.rb' - 'lib/gitlab/config/entry/node.rb' - 'lib/gitlab/database/async_indexes/migration_helpers.rb' @@ -172,6 +173,7 @@ Style/SymbolProc: - 'lib/gitlab/database/migrations/background_migration_helpers.rb' - 'lib/gitlab/database/migrations/instrumentation.rb' - 'lib/gitlab/diff/file_collection/base.rb' + - 'lib/gitlab/diff/rendered/notebook/diff_file_helper.rb' - 'lib/gitlab/git/diff_stats_collection.rb' - 'lib/gitlab/gitaly_client/commit_service.rb' - 'lib/gitlab/gitaly_client/wiki_service.rb' @@ -199,9 +201,9 @@ Style/SymbolProc: - 'qa/qa/resource/project_snippet.rb' - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/review_merge_request_spec.rb' + - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/custom_variable_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/online_garbage_collection_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_geo/attachment_replication_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_spec.rb' @@ -219,6 +221,7 @@ Style/SymbolProc: - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' - 'spec/controllers/concerns/redis_tracking_spec.rb' - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' + - 'spec/factories/application_settings.rb' - 'spec/factories/ci/builds.rb' - 'spec/factories/clusters/providers/aws.rb' - 'spec/factories/oauth_openid_requests.rb' @@ -234,16 +237,19 @@ Style/SymbolProc: - 'spec/finders/license_template_finder_spec.rb' - 'spec/finders/packages/go/version_finder_spec.rb' - 'spec/graphql/mutations/releases/create_spec.rb' + - 'spec/graphql/types/work_items/widget_type_enum_spec.rb' - 'spec/helpers/instance_configuration_helper_spec.rb' - 'spec/helpers/learn_gitlab_helper_spec.rb' - 'spec/helpers/members_helper_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - 'spec/lib/gitlab/database/dynamic_model_helpers_spec.rb' + - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/loose_foreign_key_helpers_spec.rb' - 'spec/lib/gitlab/git/commit_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb' - 'spec/lib/gitlab/graphql/lazy_spec.rb' + - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_spec.rb' - 'spec/lib/gitlab/optimistic_locking_spec.rb' - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' @@ -252,12 +258,14 @@ Style/SymbolProc: - 'spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb' - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - 'spec/models/member_spec.rb' + - 'spec/models/merge_request_diff_spec.rb' - 'spec/models/namespace/root_storage_statistics_spec.rb' - 'spec/models/operations/feature_flags/strategy_spec.rb' - 'spec/models/project_statistics_spec.rb' - 'spec/models/repository_spec.rb' - 'spec/models/user_spec.rb' - 'spec/presenters/projects/import_export/project_export_presenter_spec.rb' + - 'spec/requests/api/internal/mail_room_spec.rb' - 'spec/requests/api/snippet_repository_storage_moves_spec.rb' - 'spec/requests/api/tags_spec.rb' - 'spec/services/ci/pipelines/add_job_service_spec.rb' @@ -266,12 +274,14 @@ Style/SymbolProc: - 'spec/services/notification_recipients/builder/default_spec.rb' - 'spec/services/packages/go/create_package_service_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' + - 'spec/spec_helper.rb' - 'spec/support/generate-seed-repo-rb' - 'spec/support/helpers/filter_spec_helper.rb' - 'spec/support/helpers/migrations_helpers.rb' - 'spec/support/shared_contexts/finders/users_finder_shared_contexts.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/import_export/attributes_permitter_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/search_language_filter_shared_examples.rb' - 'spec/support/shared_examples/models/label_note_shared_examples.rb' - 'spec/views/layouts/_published_experiments.html.haml_spec.rb' - 'spec/workers/snippets/schedule_bulk_repository_shard_moves_worker_spec.rb' |