diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-06-20 13:43:29 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-06-20 13:43:29 +0300 |
commit | 3b1af5cc7ed2666ff18b718ce5d30fa5a2756674 (patch) | |
tree | 3bc4a40e0ee51ec27eabf917c537033c0c5b14d4 /.rubocop_todo | |
parent | 9bba14be3f2c211bf79e15769cd9b77bc73a13bc (diff) |
Add latest changes from gitlab-org/gitlab@16-1-stable-eev16.1.0-rc42
Diffstat (limited to '.rubocop_todo')
92 files changed, 112 insertions, 540 deletions
diff --git a/.rubocop_todo/api/ensure_string_detail.yml b/.rubocop_todo/api/ensure_string_detail.yml index feac99aa569..d246377fde4 100644 --- a/.rubocop_todo/api/ensure_string_detail.yml +++ b/.rubocop_todo/api/ensure_string_detail.yml @@ -1,5 +1,4 @@ --- API/EnsureStringDetail: - Details: grace period Exclude: - 'ee/lib/api/analytics/group_activity_analytics.rb' diff --git a/.rubocop_todo/cop/ignored_columns.yml b/.rubocop_todo/cop/ignored_columns.yml new file mode 100644 index 00000000000..eaba218d385 --- /dev/null +++ b/.rubocop_todo/cop/ignored_columns.yml @@ -0,0 +1,8 @@ +--- +Cop/IgnoredColumns: + Details: grace period + Exclude: + - 'app/models/loose_foreign_keys/deleted_record.rb' + - 'ee/lib/ee/gitlab/background_migration/create_vulnerability_links.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb' + - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' diff --git a/.rubocop_todo/gettext/static_identifier.yml b/.rubocop_todo/gettext/static_identifier.yml index c330ffe1482..f14c4884102 100644 --- a/.rubocop_todo/gettext/static_identifier.yml +++ b/.rubocop_todo/gettext/static_identifier.yml @@ -1,6 +1,5 @@ --- Gettext/StaticIdentifier: - Details: grace period Exclude: - 'app/graphql/types/project_type.rb' - 'app/models/integrations/apple_app_store.rb' diff --git a/.rubocop_todo/gitlab/doc_url.yml b/.rubocop_todo/gitlab/doc_url.yml index ad203c8abd3..119de2296ce 100644 --- a/.rubocop_todo/gitlab/doc_url.yml +++ b/.rubocop_todo/gitlab/doc_url.yml @@ -1,6 +1,5 @@ --- Gitlab/DocUrl: - Details: grace period Exclude: - 'app/controllers/jira_connect/app_descriptor_controller.rb' - 'app/graphql/types/merge_request_type.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 3a81130a47c..8a0dd63ae7c 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -244,7 +244,6 @@ Gitlab/NamespacedClass: - 'app/models/notification_setting.rb' - 'app/models/oauth_access_grant.rb' - 'app/models/oauth_access_token.rb' - - 'app/models/organization.rb' - 'app/models/out_of_context_discussion.rb' - 'app/models/pages_deployment.rb' - 'app/models/pages_domain.rb' @@ -1034,7 +1033,6 @@ Gitlab/NamespacedClass: - 'ee/app/workers/adjourned_project_deletion_worker.rb' - 'ee/app/workers/adjourned_projects_deletion_cron_worker.rb' - 'ee/app/workers/admin_emails_worker.rb' - - 'ee/app/workers/clear_shared_runners_minutes_worker.rb' - 'ee/app/workers/create_github_webhook_worker.rb' - 'ee/app/workers/elastic_association_indexer_worker.rb' - 'ee/app/workers/elastic_cluster_reindexing_cron_worker.rb' @@ -1167,7 +1165,6 @@ Gitlab/NamespacedClass: - 'lib/gitlab/issuables_count_for_state.rb' - 'lib/gitlab/issues_labels.rb' - 'lib/gitlab/job_waiter.rb' - - 'lib/gitlab/json_cache.rb' - 'lib/gitlab/json_logger.rb' - 'lib/gitlab/jwt_token.rb' - 'lib/gitlab/language_detection.rb' @@ -1274,5 +1271,5 @@ Gitlab/NamespacedClass: - 'spec/support/helpers/require_migration.rb' - 'spec/support/models/merge_request_without_merge_request_diff.rb' - 'spec/support/renameable_upload.rb' - - 'spec/tasks/gitlab/task_helpers_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/uploaders/object_storage_spec.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 4274e59a2a9..a6c273cc85b 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Gitlab/StrongMemoizeAttr: - Details: grace period Exclude: - 'app/components/pajamas/avatar_component.rb' - 'app/controllers/application_controller.rb' @@ -72,7 +71,6 @@ Gitlab/StrongMemoizeAttr: - 'app/models/alert_management/alert.rb' - 'app/models/application_setting_implementation.rb' - 'app/models/blob_viewer/go_mod.rb' - - 'app/models/blob_viewer/metrics_dashboard_yml.rb' - 'app/models/bulk_imports/export.rb' - 'app/models/bulk_imports/export_status.rb' - 'app/models/bulk_imports/file_transfer/base_config.rb' @@ -127,9 +125,6 @@ Gitlab/StrongMemoizeAttr: - 'app/models/namespaces/traversal/linear.rb' - 'app/models/namespaces/traversal/recursive.rb' - 'app/models/note.rb' - - 'app/models/packages/go/module.rb' - - 'app/models/packages/go/module_version.rb' - - 'app/models/packages/package.rb' - 'app/models/pages/lookup_path.rb' - 'app/models/project.rb' - 'app/models/release.rb' @@ -151,9 +146,6 @@ Gitlab/StrongMemoizeAttr: - 'app/presenters/ci/pipeline_presenter.rb' - 'app/presenters/clusters/cluster_presenter.rb' - 'app/presenters/merge_request_presenter.rb' - - 'app/presenters/packages/conan/package_presenter.rb' - - 'app/presenters/packages/nuget/packages_metadata_presenter.rb' - - 'app/presenters/packages/nuget/search_results_presenter.rb' - 'app/presenters/project_presenter.rb' - 'app/presenters/projects/settings/deploy_keys_presenter.rb' - 'app/serializers/ci/pipeline_entity.rb' @@ -190,7 +182,6 @@ Gitlab/StrongMemoizeAttr: - 'app/services/container_expiration_policies/update_service.rb' - 'app/services/dependency_proxy/image_ttl_group_policies/update_service.rb' - 'app/services/discussions/resolve_service.rb' - - 'app/services/error_tracking/collect_error_service.rb' - 'app/services/error_tracking/issue_details_service.rb' - 'app/services/feature_flags/base_service.rb' - 'app/services/git/base_hooks_service.rb' @@ -225,30 +216,6 @@ Gitlab/StrongMemoizeAttr: - 'app/services/metrics/dashboard/dynamic_embed_service.rb' - 'app/services/metrics/dashboard/gitlab_alert_embed_service.rb' - 'app/services/namespaces/package_settings/update_service.rb' - - 'app/services/packages/cleanup/execute_policy_service.rb' - - 'app/services/packages/cleanup/update_policy_service.rb' - - 'app/services/packages/composer/create_package_service.rb' - - 'app/services/packages/debian/extract_changes_metadata_service.rb' - - 'app/services/packages/debian/generate_distribution_key_service.rb' - - 'app/services/packages/debian/generate_distribution_service.rb' - - 'app/services/packages/debian/process_changes_service.rb' - - 'app/services/packages/helm/process_file_service.rb' - - 'app/services/packages/maven/metadata/base_create_xml_service.rb' - - 'app/services/packages/maven/metadata/create_plugins_xml_service.rb' - - 'app/services/packages/maven/metadata/create_versions_xml_service.rb' - - 'app/services/packages/maven/metadata/sync_service.rb' - - 'app/services/packages/npm/create_package_service.rb' - - 'app/services/packages/npm/create_tag_service.rb' - - 'app/services/packages/nuget/metadata_extraction_service.rb' - - 'app/services/packages/nuget/search_service.rb' - - 'app/services/packages/nuget/sync_metadatum_service.rb' - - 'app/services/packages/nuget/update_package_from_metadata_service.rb' - - 'app/services/packages/pypi/create_package_service.rb' - - 'app/services/packages/rpm/parse_package_service.rb' - - 'app/services/packages/rubygems/dependency_resolver_service.rb' - - 'app/services/packages/rubygems/process_gem_service.rb' - - 'app/services/packages/terraform_module/create_package_service.rb' - - 'app/services/packages/update_tags_service.rb' - 'app/services/projects/container_repository/cleanup_tags_base_service.rb' - 'app/services/projects/container_repository/third_party/cleanup_tags_service.rb' - 'app/services/projects/create_from_template_service.rb' @@ -318,7 +285,7 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/helpers/ee/registrations_helper.rb' - 'ee/app/helpers/ee/timeboxes_helper.rb' - 'ee/app/helpers/trials_helper.rb' - - 'ee/app/helpers/ee/welcome_helper.rb' + - 'ee/app/helpers/welcome_helper.rb' - 'ee/app/helpers/license_monitoring_helper.rb' - 'ee/app/helpers/subscriptions_helper.rb' - 'ee/app/models/approval_merge_request_rule.rb' @@ -509,10 +476,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/api/container_repositories.rb' - 'lib/api/entities/basic_project_details.rb' - 'lib/api/helpers/authentication.rb' - - 'lib/api/helpers/packages/basic_auth_helpers.rb' - - 'lib/api/helpers/packages/conan/api_helpers.rb' - - 'lib/api/helpers/packages/npm.rb' - - 'lib/api/helpers/packages_helpers.rb' - 'lib/api/terraform/modules/v1/packages.rb' - 'lib/api/unleash.rb' - 'lib/atlassian/jira_connect/jwt/asymmetric.rb' diff --git a/.rubocop_todo/gitlab_security/public_send.yml b/.rubocop_todo/gitlab_security/public_send.yml index 2fd77f686bf..06dfaf4dee2 100644 --- a/.rubocop_todo/gitlab_security/public_send.yml +++ b/.rubocop_todo/gitlab_security/public_send.yml @@ -1,6 +1,5 @@ --- GitlabSecurity/PublicSend: - Details: grace period Exclude: - 'ee/app/helpers/push_rules_helper.rb' - 'ee/app/models/ee/namespace_setting.rb' diff --git a/.rubocop_todo/graphql/descriptions.yml b/.rubocop_todo/graphql/descriptions.yml index ca5f9571f98..728c49ca30f 100644 --- a/.rubocop_todo/graphql/descriptions.yml +++ b/.rubocop_todo/graphql/descriptions.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Graphql/Descriptions: - Details: grace period Exclude: - 'app/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver.rb' - 'app/graphql/resolvers/alert_management/alert_resolver.rb' diff --git a/.rubocop_todo/graphql/enum_names.yml b/.rubocop_todo/graphql/enum_names.yml index 18f485b6759..1444c759e62 100644 --- a/.rubocop_todo/graphql/enum_names.yml +++ b/.rubocop_todo/graphql/enum_names.yml @@ -1,6 +1,5 @@ --- Graphql/EnumNames: - Details: grace period Exclude: - 'app/graphql/types/access_level_enum.rb' - 'app/graphql/types/availability_enum.rb' diff --git a/.rubocop_todo/graphql/enum_values.yml b/.rubocop_todo/graphql/enum_values.yml index 3984c54a9f2..3a6446c512c 100644 --- a/.rubocop_todo/graphql/enum_values.yml +++ b/.rubocop_todo/graphql/enum_values.yml @@ -1,6 +1,5 @@ --- Graphql/EnumValues: - Details: grace period Exclude: - 'app/graphql/types/alert_management/domain_filter_enum.rb' - 'app/graphql/types/blob_viewers/type_enum.rb' diff --git a/.rubocop_todo/graphql/resource_not_available_error.yml b/.rubocop_todo/graphql/resource_not_available_error.yml new file mode 100644 index 00000000000..5a9d2f9b1a2 --- /dev/null +++ b/.rubocop_todo/graphql/resource_not_available_error.yml @@ -0,0 +1,43 @@ +--- +# Cop supports --autocorrect. +Graphql/ResourceNotAvailableError: + Exclude: + - 'app/graphql/mutations/achievements/create.rb' + - 'app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb' + - 'app/graphql/mutations/ci/ci_cd_settings_update.rb' + - 'app/graphql/mutations/ci/job_artifact/bulk_destroy.rb' + - 'app/graphql/mutations/ci/runner/create.rb' + - 'app/graphql/mutations/custom_emoji/create.rb' + - 'app/graphql/mutations/custom_emoji/destroy.rb' + - 'app/graphql/mutations/design_management/move.rb' + - 'app/graphql/mutations/issues/bulk_update.rb' + - 'app/graphql/mutations/issues/set_crm_contacts.rb' + - 'app/graphql/mutations/issues/set_escalation_status.rb' + - 'app/graphql/mutations/notes/create/base.rb' + - 'app/graphql/mutations/notes/create/note.rb' + - 'app/graphql/mutations/notes/reposition_image_diff_note.rb' + - 'app/graphql/mutations/notes/update/image_diff_note.rb' + - 'app/graphql/mutations/saved_replies/create.rb' + - 'app/graphql/mutations/saved_replies/destroy.rb' + - 'app/graphql/mutations/saved_replies/update.rb' + - 'app/graphql/mutations/todos/mark_all_done.rb' + - 'app/graphql/mutations/work_items/export.rb' + - 'app/graphql/resolvers/ci/runner_setup_resolver.rb' + - 'app/graphql/resolvers/concerns/search_arguments.rb' + - 'app/graphql/resolvers/container_repository_tags_resolver.rb' + - 'app/graphql/resolvers/design_management/versions_resolver.rb' + - 'app/graphql/resolvers/kas/agent_configurations_resolver.rb' + - 'app/graphql/resolvers/kas/agent_connections_resolver.rb' + - 'app/graphql/resolvers/projects/snippets_resolver.rb' + - 'app/graphql/types/container_repository_details_type.rb' + - 'app/graphql/types/container_repository_type.rb' + - 'ee/app/graphql/ee/types/query_type.rb' + - 'ee/app/graphql/mutations/ai/action.rb' + - 'ee/app/graphql/mutations/audit_events/instance_external_audit_event_destinations/base.rb' + - 'ee/app/graphql/mutations/ci/ai/generate_config.rb' + - 'ee/app/graphql/mutations/geo/registries/update.rb' + - 'ee/app/graphql/mutations/issues/set_escalation_policy.rb' + - 'ee/app/graphql/mutations/projects/set_locked.rb' + - 'ee/app/graphql/resolvers/incident_management/oncall_shifts_resolver.rb' + - 'ee/app/graphql/resolvers/product_analytics/visualization_resolver.rb' + - 'ee/app/graphql/resolvers/remote_development/workspaces_resolver.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index bdd3a15489d..ca7dba5c8db 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/ArgumentAlignment: - Details: grace period Exclude: - 'app/graphql/mutations/achievements/create.rb' - 'app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb' @@ -506,40 +505,6 @@ Layout/ArgumentAlignment: - 'app/graphql/types/work_items/widgets/start_and_due_date_update_input_type.rb' - 'app/graphql/types/x509_certificate_type.rb' - 'app/graphql/types/x509_issuer_type.rb' - - 'app/models/discussion.rb' - - 'app/models/environment.rb' - - 'app/models/generic_commit_status.rb' - - 'app/models/grafana_integration.rb' - - 'app/models/group.rb' - - 'app/models/group_group_link.rb' - - 'app/models/hooks/web_hook.rb' - - 'app/models/integration.rb' - - 'app/models/integrations/apple_app_store.rb' - - 'app/models/integrations/base_chat_notification.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/jira_connect_installation.rb' - - 'app/models/lfs_object.rb' - - 'app/models/packages/cleanup/policy.rb' - - 'app/models/packages/conan/metadatum.rb' - - 'app/models/packages/debian/file_entry.rb' - - 'app/models/packages/package.rb' - - 'app/models/packages/rpm/metadatum.rb' - - 'app/models/pages_domain.rb' - - 'app/models/pages_domain_acme_order.rb' - - 'app/models/project.rb' - - 'app/models/project_feature.rb' - - 'app/models/project_import_data.rb' - - 'app/models/project_team.rb' - - 'app/models/prometheus_alert.rb' - - 'app/models/release.rb' - - 'app/models/releases/source.rb' - - 'app/models/remote_mirror.rb' - - 'app/models/repository.rb' - - 'app/models/resource_timebox_event.rb' - - 'app/models/service_desk_setting.rb' - - 'app/models/terraform/state.rb' - - 'app/models/time_tracking/timelog_category.rb' - - 'app/models/u2f_registration.rb' - 'app/services/compare_service.rb' - 'app/services/concerns/rate_limited_service.rb' - 'app/services/design_management/copy_design_collection/copy_service.rb' @@ -994,56 +959,6 @@ Layout/ArgumentAlignment: - 'ee/app/graphql/types/work_items/widgets/status_filter_input_type.rb' - 'ee/app/graphql/types/work_items/widgets/status_input_type.rb' - 'ee/app/graphql/types/work_items/widgets/weight_input_type.rb' - - 'ee/app/models/approval_wrapped_rule.rb' - - 'ee/app/models/dast/pre_scan_verification.rb' - - 'ee/app/models/deployments/approval.rb' - - 'ee/app/models/ee/application_setting.rb' - - 'ee/app/models/ee/ci/secure_file.rb' - - 'ee/app/models/ee/deployment.rb' - - 'ee/app/models/ee/epic.rb' - - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/identity.rb' - - 'ee/app/models/ee/member.rb' - - 'ee/app/models/ee/merge_request.rb' - - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/namespace/storage/notification.rb' - - 'ee/app/models/ee/project.rb' - - 'ee/app/models/ee/project_group_link.rb' - - 'ee/app/models/ee/projects/wiki_repository.rb' - - 'ee/app/models/ee/upload.rb' - - 'ee/app/models/ee/user.rb' - - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/models/geo/hashed_storage_migrated_event.rb' - - 'ee/app/models/geo/project_registry.rb' - - 'ee/app/models/geo/project_wiki_repository_state.rb' - - 'ee/app/models/geo/wiki_repository_state.rb' - - 'ee/app/models/geo_node.rb' - - 'ee/app/models/geo_node_status.rb' - - 'ee/app/models/gitlab_subscriptions/upcoming_reconciliation.rb' - - 'ee/app/models/group_merge_request_approval_setting.rb' - - 'ee/app/models/incident_management/escalation_rule.rb' - - 'ee/app/models/integrations/github/status_notifier.rb' - - 'ee/app/models/merge_requests/compliance_violation.rb' - - 'ee/app/models/merge_requests/external_status_check.rb' - - 'ee/app/models/package_metadata/package_version_license.rb' - - 'ee/app/models/product_analytics/dashboard.rb' - - 'ee/app/models/protected_environments/approval_rule.rb' - - 'ee/app/models/requirements_management/requirement.rb' - - 'ee/app/models/sbom/vulnerable_component_version.rb' - - 'ee/app/models/sca/license_policy.rb' - - 'ee/app/models/scim_identity.rb' - - 'ee/app/models/security/finding.rb' - - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' - - 'ee/app/models/smartcard_identity.rb' - - 'ee/app/models/status_page/project_setting.rb' - - 'ee/app/models/vulnerabilities/external_issue_link.rb' - - 'ee/app/models/vulnerabilities/feedback.rb' - - 'ee/app/models/vulnerabilities/finding/evidence.rb' - - 'ee/app/models/vulnerabilities/issue_link.rb' - - 'ee/app/models/vulnerabilities/merge_request_link.rb' - - 'ee/app/models/vulnerabilities/read.rb' - - 'ee/app/models/vulnerabilities/stat_diff.rb' - - 'ee/app/models/vulnerabilities/statistic.rb' - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/bulk_find_or_create_service.rb' - 'ee/app/services/audit_events/streaming/event_type_filters/destroy_service.rb' - 'ee/app/services/auto_merge/merge_train_service.rb' @@ -1116,7 +1031,6 @@ Layout/ArgumentAlignment: - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb' - 'ee/lib/gitlab/zoekt/search_results.rb' - 'ee/spec/components/billing/plan_component_spec.rb' - - 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/elastic/migrate/20221124090600_add_namespace_ancestry_ids_to_original_index_mapping_spec.rb' - 'ee/spec/elastic/migrate/20221221110300_backfill_traversal_ids_to_blobs_and_wiki_blobs_spec.rb' @@ -1134,7 +1048,6 @@ Layout/ArgumentAlignment: - 'ee/spec/features/groups/settings/protected_environments_spec.rb' - 'ee/spec/features/groups/usage_quotas/pipelines_tab_spec.rb' - 'ee/spec/features/markdown/metrics_spec.rb' - - 'ee/spec/features/merge_request/user_merges_with_namespace_storage_limits_spec.rb' - 'ee/spec/features/merge_request/user_sees_approval_widget_spec.rb' - 'ee/spec/features/namespace_user_cap_reached_alert_spec.rb' - 'ee/spec/features/projects/environments/environment_spec.rb' @@ -1230,7 +1143,6 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - 'ee/spec/lib/ee/gitlab/usage/service_ping_report_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - - 'ee/spec/lib/elastic/latest/git_class_proxy_spec.rb' - 'ee/spec/lib/elastic/latest/project_wiki_class_proxy_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/distinct_stage_loader_spec.rb' @@ -1268,42 +1180,6 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/gitlab/zoekt/search_results_spec.rb' - 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb' - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' - - 'ee/spec/models/approval_wrapped_code_owner_rule_spec.rb' - - 'ee/spec/models/dast/pre_scan_verification_step_spec.rb' - - 'ee/spec/models/dast_site_profile_spec.rb' - - 'ee/spec/models/deployments/approval_summary_spec.rb' - - 'ee/spec/models/dora/daily_metrics_spec.rb' - - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - - 'ee/spec/models/ee/ci/pipeline_artifact_spec.rb' - - 'ee/spec/models/ee/ci/runner_spec.rb' - - 'ee/spec/models/ee/ci/secure_file_spec.rb' - - 'ee/spec/models/ee/dependency_proxy/blob_spec.rb' - - 'ee/spec/models/ee/dependency_proxy/manifest_spec.rb' - - 'ee/spec/models/ee/event_spec.rb' - - 'ee/spec/models/ee/group_spec.rb' - - 'ee/spec/models/ee/namespace_spec.rb' - - 'ee/spec/models/ee/project_spec.rb' - - 'ee/spec/models/ee/user_spec.rb' - - 'ee/spec/models/epic_spec.rb' - - 'ee/spec/models/geo/project_registry_spec.rb' - - 'ee/spec/models/ldap_group_link_spec.rb' - - 'ee/spec/models/member_spec.rb' - - 'ee/spec/models/merge_request_spec.rb' - - 'ee/spec/models/merge_requests/external_status_check_spec.rb' - - 'ee/spec/models/namespaces/free_user_cap/notification_spec.rb' - - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' - - 'ee/spec/models/product_analytics/funnel_step_spec.rb' - - 'ee/spec/models/product_analytics/jitsu_authentication_spec.rb' - - 'ee/spec/models/productivity_analytics_spec.rb' - - 'ee/spec/models/project_import_state_spec.rb' - - 'ee/spec/models/protected_environments/approval_rule_spec.rb' - - 'ee/spec/models/remote_mirror_spec.rb' - - 'ee/spec/models/requirements_management/test_report_spec.rb' - - 'ee/spec/models/security/finding_spec.rb' - - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' - - 'ee/spec/models/upload_spec.rb' - - 'ee/spec/models/vulnerabilities/finding_spec.rb' - - 'ee/spec/models/vulnerabilities/state_transition_spec.rb' - 'ee/spec/requests/admin/impersonation_tokens_controller_spec.rb' - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' @@ -1383,7 +1259,6 @@ Layout/ArgumentAlignment: - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups/settings/domain_verification_controller_spec.rb' - 'ee/spec/requests/groups/two_factor_auths_controller_spec.rb' - - 'ee/spec/requests/registrations/project_creation_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/requests/users/identity_verification_controller_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/aggregator_service_spec.rb' @@ -1685,110 +1560,6 @@ Layout/ArgumentAlignment: - 'lib/tasks/gitlab/seed/runner_fleet.rake' - 'lib/tasks/gitlab/shell.rake' - 'lib/tasks/gitlab/uploads/sanitize.rake' - - 'qa/qa/ce/strategy.rb' - - 'qa/qa/ee/page/component/secure_report.rb' - - 'qa/qa/ee/resource/epic.rb' - - 'qa/qa/ee/resource/group_iteration.rb' - - 'qa/qa/ee/resource/scan_result_policy_commit.rb' - - 'qa/qa/ee/resource/vulnerability_item.rb' - - 'qa/qa/page/base.rb' - - 'qa/qa/page/project/issue/show.rb' - - 'qa/qa/page/project/web_ide/edit.rb' - - 'qa/qa/resource/badge_base.rb' - - 'qa/qa/resource/bulk_import_group.rb' - - 'qa/qa/resource/file.rb' - - 'qa/qa/resource/group_base.rb' - - 'qa/qa/resource/group_milestone.rb' - - 'qa/qa/resource/issue.rb' - - 'qa/qa/resource/job.rb' - - 'qa/qa/resource/members.rb' - - 'qa/qa/resource/protected_branch.rb' - - 'qa/qa/resource/registry_repository.rb' - - 'qa/qa/resource/repository/commit.rb' - - 'qa/qa/resource/repository/push.rb' - - 'qa/qa/resource/user.rb' - - 'qa/qa/scenario/test/instance/review_blocking.rb' - - 'qa/qa/scenario/test/instance/review_non_blocking.rb' - - 'qa/qa/specs/features/api/12_systems/gitaly/changing_repository_storage_spec.rb' - - 'qa/qa/specs/features/api/12_systems/gitaly/distributed_reads_spec.rb' - - 'qa/qa/specs/features/api/12_systems/gitaly/praefect_connectivity_spec.rb' - - 'qa/qa/specs/features/api/12_systems/gitaly/praefect_dataloss_spec.rb' - - 'qa/qa/specs/features/api/12_systems/gitaly/praefect_replication_queue_spec.rb' - - 'qa/qa/specs/features/api/12_systems/gitaly/praefect_repo_sync_spec.rb' - - 'qa/qa/specs/features/api/1_manage/integrations/webhook_events_spec.rb' - - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb' - - 'qa/qa/specs/features/api/3_create/repository/tag_revision_trigger_prereceive_hook_spec.rb' - - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jenkins/jenkins_build_status_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb' - - 'qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/pages/new_static_page_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_content_creation_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_content_manipulation_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_directory_management_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_list_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/source_editor/source_editor_toolbar_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_new_directory_in_web_ide_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/add_file_template_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_project_level_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/rubygems_registry_spec.rb' - - 'qa/qa/specs/features/browser_ui/7_configure/auto_devops/create_project_with_auto_devops_spec.rb' - - 'qa/qa/specs/features/ee/api/12_systems/geo/geo_nodes_spec.rb' - - 'qa/qa/specs/features/ee/api/1_manage/integrations/group_webhook_events_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/change_vulnerability_status_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/export_vulnerability_report_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/fix_vulnerability_workflow_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_audit_logs_1_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_audit_logs_2_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/instance/instance_audit_logs_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/policies_list_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/project/project_audit_logs_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/project_security_dashboard_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/scan_result_policy_vulnerabilities_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/security_reports_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerabilities_jira_integration_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/overage_modal_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/upgrade_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/user_registration_billing_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/saas_user_limit_experience_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/utilization/free_namespace_storage_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/database_delete_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/geo_replication_ci_job_log_artifacts_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/geo_replication_maven_package_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/geo_replication_npm_registry_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/geo_replication_project_snippets_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/http_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/ssh_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/wiki_http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/wiki_http_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/wiki_ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/wiki_ssh_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/merge_request_license_widget_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/15_growth/free_trial_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/group_wiki/delete_group_wiki_page_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/project_templates_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/4_verify/job_trace_archival_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/5_package/dependency_proxy_sso_spec.rb' - - 'qa/qa/vendor/jira/jira_api.rb' - - 'qa/spec/support/loglinking_spec.rb' - 'rubocop/cop/gitlab/finder_with_find_by.rb' - 'rubocop/cop/qa/ambiguous_page_object_name.rb' - 'rubocop/cop/rspec/modify_sidekiq_middleware.rb' @@ -1942,7 +1713,6 @@ Layout/ArgumentAlignment: - 'spec/graphql/types/current_user_todos_type_spec.rb' - 'spec/graphql/types/project_statistics_type_spec.rb' - 'spec/graphql/types/project_type_spec.rb' - - 'spec/graphql/types/root_storage_statistics_type_spec.rb' - 'spec/graphql/types/todo_type_spec.rb' - 'spec/initializers/00_rails_disable_joins_spec.rb' - 'spec/initializers/secret_token_spec.rb' @@ -2144,27 +1914,6 @@ Layout/ArgumentAlignment: - 'spec/lib/security/weak_passwords_spec.rb' - 'spec/lib/sidebars/projects/menus/repository_menu_spec.rb' - 'spec/lib/uploaded_file_spec.rb' - - 'spec/models/integrations/mattermost_slash_commands_spec.rb' - - 'spec/models/integrations/microsoft_teams_spec.rb' - - 'spec/models/issue_spec.rb' - - 'spec/models/lfs_object_spec.rb' - - 'spec/models/loose_foreign_keys/deleted_record_spec.rb' - - 'spec/models/member_spec.rb' - - 'spec/models/members/group_member_spec.rb' - - 'spec/models/members/project_member_spec.rb' - - 'spec/models/merge_request_diff_spec.rb' - - 'spec/models/merge_request_spec.rb' - - 'spec/models/ml/candidate_spec.rb' - - 'spec/models/namespace/package_setting_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/models/note_spec.rb' - - 'spec/models/onboarding/progress_spec.rb' - - 'spec/models/operations/feature_flags/strategy_spec.rb' - - 'spec/models/pages_domain_spec.rb' - - 'spec/models/project_spec.rb' - - 'spec/models/project_team_spec.rb' - - 'spec/models/release_spec.rb' - - 'spec/models/remote_mirror_spec.rb' - 'spec/requests/admin/applications_controller_spec.rb' - 'spec/requests/admin/impersonation_tokens_controller_spec.rb' - 'spec/requests/api/access_requests_spec.rb' @@ -2237,7 +1986,6 @@ Layout/ArgumentAlignment: - 'spec/requests/api/graphql/mutations/todos/mark_done_spec.rb' - 'spec/requests/api/graphql/mutations/todos/restore_many_spec.rb' - 'spec/requests/api/graphql/mutations/todos/restore_spec.rb' - - 'spec/requests/api/graphql/namespace/root_storage_statistics_spec.rb' - 'spec/requests/api/graphql/packages/conan_spec.rb' - 'spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb' - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' @@ -2378,7 +2126,7 @@ Layout/ArgumentAlignment: - 'spec/support/shared_examples/integrations/integration_settings_form.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/database/background_migration_job_shared_examples.rb' - - 'spec/tasks/cache/clear/redis_spec.rb' + - 'spec/tasks/cache_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences_rake_spec.rb' - 'spec/tasks/gitlab/db/truncate_legacy_tables_rake_spec.rb' diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml index 893a9338c5b..7efa857c502 100644 --- a/.rubocop_todo/layout/array_alignment.yml +++ b/.rubocop_todo/layout/array_alignment.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/ArrayAlignment: - Details: grace period Exclude: - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/admin/plan_limits_controller.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 93302cebaa1..435efc1c5b3 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/EmptyLineAfterMagicComment: - Details: grace period Exclude: - 'app/controllers/admin/instance_review_controller.rb' - 'app/controllers/concerns/render_access_tokens.rb' @@ -206,7 +205,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/app/models/dependencies/dependency_list_export.rb' - 'ee/app/models/ee/issue_assignee.rb' - 'ee/app/models/geo/ci_secure_file_state.rb' - - 'ee/app/models/namespaces/storage/limit_exclusion.rb' - 'ee/app/models/project_security_setting.rb' - 'ee/app/models/protected_environment.rb' - 'ee/app/models/sbom/vulnerable_component_version.rb' @@ -272,11 +270,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/lib/gitlab/cidr.rb' - 'ee/lib/quality/seeders/vulnerabilities.rb' - 'ee/spec/components/billing/plan_component_spec.rb' - - 'ee/spec/components/namespaces/storage/limit_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/project_pre_enforcement_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/subgroup_pre_enforcement_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/user_pre_enforcement_alert_component_spec.rb' - 'ee/spec/controllers/admin/geo/nodes_controller_spec.rb' - 'ee/spec/controllers/ee/projects/autocomplete_sources_controller_spec.rb' - 'ee/spec/controllers/ee/projects/protected_branches_controller_spec.rb' @@ -526,7 +519,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/factories/ml/candidates.rb' - 'spec/factories/ml/experiments.rb' - 'spec/factories/packages/composer/cache_files.rb' - - 'spec/factories/packages/packages.rb' - 'spec/features/issuables/sorting_list_spec.rb' - 'spec/features/merge_request/merge_request_discussion_lock_spec.rb' - 'spec/features/merge_request/user_views_merge_request_from_deleted_fork_spec.rb' @@ -592,7 +584,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb' - 'spec/lib/gitlab/health_checks/redis_spec.rb' - 'spec/lib/gitlab/import/set_async_jid_spec.rb' - - 'spec/lib/gitlab/json_cache_spec.rb' - 'spec/lib/gitlab/jwt_token_spec.rb' - 'spec/lib/gitlab/kroki_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' @@ -646,7 +637,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/requests/api/composer_packages_spec.rb' - 'spec/requests/api/conan_project_packages_spec.rb' - 'spec/requests/api/debian_group_packages_spec.rb' - - 'spec/requests/api/debian_project_packages_spec.rb' - 'spec/requests/api/feature_flags_spec.rb' - 'spec/requests/api/graphql/ci/ci_cd_setting_spec.rb' - 'spec/requests/api/graphql/ci/groups_spec.rb' @@ -746,7 +736,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/services/packages/create_dependency_service_spec.rb' - 'spec/services/packages/create_event_service_spec.rb' - 'spec/services/packages/create_package_file_service_spec.rb' - - 'spec/services/packages/debian/extract_changes_metadata_service_spec.rb' - 'spec/services/packages/debian/extract_deb_metadata_service_spec.rb' - 'spec/services/packages/debian/parse_debian822_service_spec.rb' - 'spec/services/packages/helm/extract_file_metadata_service_spec.rb' diff --git a/.rubocop_todo/layout/first_argument_indentation.yml b/.rubocop_todo/layout/first_argument_indentation.yml index fb364356a97..a22be9644cf 100644 --- a/.rubocop_todo/layout/first_argument_indentation.yml +++ b/.rubocop_todo/layout/first_argument_indentation.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/FirstArgumentIndentation: - Details: grace period Exclude: - 'app/models/customer_relations/contact.rb' - 'app/models/cycle_analytics/project_level_stage_adapter.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index f55a4e6b0dc..f8b1d9b92c8 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/FirstArrayElementIndentation: - Details: grace period Exclude: - 'app/controllers/admin/plan_limits_controller.rb' - 'app/finders/user_groups_counter.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 4537d0a499b..c95fc3010d0 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/FirstHashElementIndentation: - Details: grace period Exclude: - 'app/controllers/admin/system_info_controller.rb' - 'app/controllers/concerns/milestone_actions.rb' @@ -50,13 +49,11 @@ Layout/FirstHashElementIndentation: - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/gitlab_subscriptions/plan_upgrade_service.rb' - 'ee/app/services/iterations/create_service.rb' - - 'ee/app/services/registrations/base_namespace_create_service.rb' - 'ee/app/services/resource_events/change_iteration_service.rb' - 'ee/app/services/security/token_revocation_service.rb' - 'ee/app/services/timebox_report_service.rb' - 'ee/lib/ee/gitlab/ci/parsers.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/elastic/latest/issue_class_proxy.rb' - 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb' - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb' diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml index a2480469b9f..d07a936bb7d 100644 --- a/.rubocop_todo/layout/hash_alignment.yml +++ b/.rubocop_todo/layout/hash_alignment.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/HashAlignment: - Details: grace period Exclude: - 'config/initializers/rspec_profiling.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_leading_space.yml b/.rubocop_todo/layout/line_continuation_leading_space.yml index f2c9feec08d..3c39768b481 100644 --- a/.rubocop_todo/layout/line_continuation_leading_space.yml +++ b/.rubocop_todo/layout/line_continuation_leading_space.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/LineContinuationLeadingSpace: - Details: grace period Exclude: - 'app/graphql/resolvers/issues/base_resolver.rb' - 'app/graphql/resolvers/work_items/types_resolver.rb' @@ -48,7 +47,6 @@ Layout/LineContinuationLeadingSpace: - 'rubocop/cop/graphql/descriptions.rb' - 'rubocop/cop/migration/add_columns_to_wide_tables.rb' - 'rubocop/cop/migration/background_migrations.rb' - - 'rubocop/cop/migration/update_column_in_batches.rb' - 'scripts/lib/glfm/parse_examples.rb' - 'scripts/qa/testcases-check' - 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml index bbb9e83ce48..355ef3f3ff8 100644 --- a/.rubocop_todo/layout/line_continuation_spacing.yml +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/LineContinuationSpacing: - Details: grace period Exclude: - 'app/controllers/concerns/controller_with_cross_project_access_check.rb' - 'app/controllers/projects/google_cloud/databases_controller.rb' @@ -23,8 +22,6 @@ Layout/LineContinuationSpacing: - 'app/services/uploads/destroy_service.rb' - 'app/services/users/email_verification/validate_token_service.rb' - 'config/initializers_before_autoloader/003_gc_compact.rb' - - 'ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb' - - 'ee/app/components/namespaces/storage/user_pre_enforcement_alert_component.rb' - 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb' - 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb' - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index d1b6eddb465..7a1dd906310 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/LineEndStringConcatenationIndentation: - Details: grace period Exclude: - 'app/controllers/admin/application_settings_controller.rb' - 'app/finders/snippets_finder.rb' @@ -215,14 +214,12 @@ Layout/LineEndStringConcatenationIndentation: - 'rubocop/cop/graphql/descriptions.rb' - 'rubocop/cop/graphql/resolver_type.rb' - 'rubocop/cop/group_public_or_visible_to_user.rb' - - 'rubocop/cop/ignored_columns.rb' - 'rubocop/cop/inject_enterprise_edition_module.rb' - 'rubocop/cop/migration/add_concurrent_index.rb' - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - 'rubocop/cop/migration/create_table_with_foreign_keys.rb' - 'rubocop/cop/migration/prevent_strings.rb' - 'rubocop/cop/migration/remove_concurrent_index.rb' - - 'rubocop/cop/migration/update_column_in_batches.rb' - 'rubocop/cop/migration/with_lock_retries_with_change.rb' - 'rubocop/cop/performance/active_record_subtransaction_methods.rb' - 'rubocop/cop/performance/active_record_subtransactions.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 339edfce783..8c283bdf6ce 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -38,7 +38,6 @@ Layout/LineLength: - 'app/controllers/groups/group_members_controller.rb' - 'app/controllers/groups/settings/applications_controller.rb' - 'app/controllers/groups/settings/ci_cd_controller.rb' - - 'app/controllers/groups/settings/integrations_controller.rb' - 'app/controllers/groups/settings/repository_controller.rb' - 'app/controllers/groups_controller.rb' - 'app/controllers/import/base_controller.rb' @@ -710,7 +709,7 @@ Layout/LineLength: - 'config/initializers/active_record_force_reconnects.rb' - 'config/initializers/active_record_keyset_pagination.rb' - 'config/initializers/active_record_schema_versions.rb' - - 'config/initializers/carrierwave_patch.rb' + - 'config/initializers/carrierwave_s3_encryption_headers_patch.rb' - 'config/initializers/deprecations.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/direct_upload_support.rb' @@ -1287,10 +1286,8 @@ Layout/LineLength: - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/ee/sidebars/groups/panel.rb' - 'ee/lib/ee/sidebars/projects/menus/security_compliance_menu.rb' - - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/elastic/latest/config.rb' - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/elastic/latest/git_instance_proxy.rb' - 'ee/lib/elastic/latest/issue_class_proxy.rb' - 'ee/lib/elastic/latest/issue_instance_proxy.rb' @@ -2637,7 +2634,6 @@ Layout/LineLength: - 'lib/bulk_imports/projects/pipelines/repository_pipeline.rb' - 'lib/container_registry/base_client.rb' - 'lib/declarative_enum.rb' - - 'lib/error_tracking/collector/payload_validator.rb' - 'lib/feature.rb' - 'lib/feature/definition.rb' - 'lib/file_size_validator.rb' @@ -2729,7 +2725,6 @@ Layout/LineLength: - 'lib/gitlab/ci/status/build/waiting_for_approval.rb' - 'lib/gitlab/ci/variables/builder.rb' - 'lib/gitlab/cleanup/project_uploads.rb' - - 'lib/gitlab/cluster/puma_worker_killer_observer.rb' - 'lib/gitlab/composer/version_index.rb' - 'lib/gitlab/config/entry/configurable.rb' - 'lib/gitlab/config/entry/validators.rb' @@ -3537,7 +3532,6 @@ Layout/LineLength: - 'spec/features/user_sorts_things_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/features/users/overview_spec.rb' - - 'spec/features/users/signup_spec.rb' - 'spec/features/users/user_browses_projects_on_user_page_spec.rb' - 'spec/features/webauthn_spec.rb' - 'spec/finders/access_requests_finder_spec.rb' @@ -3724,7 +3718,6 @@ Layout/LineLength: - 'spec/helpers/snippets_helper_spec.rb' - 'spec/helpers/sorting_helper_spec.rb' - 'spec/helpers/sourcegraph_helper_spec.rb' - - 'spec/helpers/storage_helper_spec.rb' - 'spec/helpers/submodule_helper_spec.rb' - 'spec/helpers/tab_helper_spec.rb' - 'spec/helpers/time_zone_helper_spec.rb' @@ -4695,7 +4688,6 @@ Layout/LineLength: - 'spec/rubocop/cop/gitlab/mark_used_feature_flags_spec.rb' - 'spec/rubocop/cop/lint/last_keyword_argument_spec.rb' - 'spec/rubocop/cop/migration/safer_boolean_column_spec.rb' - - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/rubocop/cop/performance/readlines_each_spec.rb' - 'spec/rubocop/cop/rspec/env_assignment_spec.rb' - 'spec/rubocop/cop/rspec/expect_gitlab_tracking_spec.rb' @@ -5197,7 +5189,7 @@ Layout/LineLength: - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - 'spec/tasks/gitlab/external_diffs_rake_spec.rb' - - 'spec/tasks/gitlab/generate_sample_prometheus_data_spec.rb' + - 'spec/tasks/gitlab/generate_sample_prometheus_data_rake_spec.rb' - 'spec/tasks/gitlab/gitaly_rake_spec.rb' - 'spec/tasks/gitlab/ldap_rake_spec.rb' - 'spec/tasks/gitlab/lfs/check_rake_spec.rb' @@ -5207,7 +5199,7 @@ Layout/LineLength: - 'spec/tasks/gitlab/smtp_rake_spec.rb' - 'spec/tasks/gitlab/snippets_rake_spec.rb' - 'spec/tasks/gitlab/storage_rake_spec.rb' - - 'spec/tasks/gitlab/task_helpers_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - 'spec/tasks/gitlab/uploads/check_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' diff --git a/.rubocop_todo/layout/parameter_alignment.yml b/.rubocop_todo/layout/parameter_alignment.yml index 56a96fb82c1..8a20a207d4f 100644 --- a/.rubocop_todo/layout/parameter_alignment.yml +++ b/.rubocop_todo/layout/parameter_alignment.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/ParameterAlignment: - Details: grace period Exclude: - 'lib/gitlab/cross_project_access.rb' - 'lib/gitlab/data_builder/push.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 62aa752c376..3bc63853043 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/SpaceInLambdaLiteral: - Details: grace period Exclude: - 'app/models/bulk_imports/tracker.rb' - 'app/models/ci/build.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index b27fae0c6be..6b2f04eff7e 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Layout/SpaceInsideParens: - Details: grace period Exclude: - 'ee/app/models/ee/dependency_proxy/blob.rb' - 'ee/app/models/ee/dependency_proxy/manifest.rb' @@ -101,7 +100,7 @@ Layout/SpaceInsideParens: - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/gitlab_script_tag_helper_spec.rb' - 'spec/helpers/tab_helper_spec.rb' - - 'spec/initializers/carrierwave_patch_spec.rb' + - 'spec/initializers/carrierwave_s3_encryption_headers_patch_spec.rb' - 'spec/initializers/rdoc_segfault_patch_spec.rb' - 'spec/lib/api/entities/snippet_spec.rb' - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb' diff --git a/.rubocop_todo/layout/space_inside_percent_literal_delimiters.yml b/.rubocop_todo/layout/space_inside_percent_literal_delimiters.yml index 5e1ce3c256c..2c3744e16cb 100644 --- a/.rubocop_todo/layout/space_inside_percent_literal_delimiters.yml +++ b/.rubocop_todo/layout/space_inside_percent_literal_delimiters.yml @@ -1,6 +1,5 @@ --- # Cop supports --autocorrect. Layout/SpaceInsidePercentLiteralDelimiters: - Details: grace period Exclude: - 'spec/deprecation_toolkit_env.rb' diff --git a/.rubocop_todo/lint/ambiguous_operator_precedence.yml b/.rubocop_todo/lint/ambiguous_operator_precedence.yml index a890c6af6d0..577836b07f9 100644 --- a/.rubocop_todo/lint/ambiguous_operator_precedence.yml +++ b/.rubocop_todo/lint/ambiguous_operator_precedence.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/AmbiguousOperatorPrecedence: - Details: grace period Exclude: - 'app/controllers/explore/projects_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' @@ -31,7 +30,7 @@ Lint/AmbiguousOperatorPrecedence: - 'app/services/issues/relative_position_rebalancing_service.rb' - 'app/services/jira/requests/base.rb' - 'config/initializers/1_settings.rb' - - 'config/initializers/carrierwave_patch.rb' + - 'config/initializers/carrierwave_s3_encryption_headers_patch.rb' - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' - 'danger/roulette/Dangerfile' - 'ee/app/models/ee/integrations/jira.rb' diff --git a/.rubocop_todo/lint/ambiguous_range.yml b/.rubocop_todo/lint/ambiguous_range.yml index 155c1a36128..e91be141ef5 100644 --- a/.rubocop_todo/lint/ambiguous_range.yml +++ b/.rubocop_todo/lint/ambiguous_range.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/AmbiguousRange: - Details: grace period Exclude: - 'app/models/ci/runner.rb' - 'app/models/ci/runner_manager.rb' diff --git a/.rubocop_todo/lint/ambiguous_regexp_literal.yml b/.rubocop_todo/lint/ambiguous_regexp_literal.yml index 6f2b8f03f8a..c3b06ede5be 100644 --- a/.rubocop_todo/lint/ambiguous_regexp_literal.yml +++ b/.rubocop_todo/lint/ambiguous_regexp_literal.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/AmbiguousRegexpLiteral: - Details: grace period Exclude: - 'ee/lib/ee/gitlab/auth/ldap/group.rb' - 'ee/spec/controllers/groups/sso_controller_spec.rb' diff --git a/.rubocop_todo/lint/constant_definition_in_block.yml b/.rubocop_todo/lint/constant_definition_in_block.yml index 1758c51e55a..6d267d18713 100644 --- a/.rubocop_todo/lint/constant_definition_in_block.yml +++ b/.rubocop_todo/lint/constant_definition_in_block.yml @@ -1,6 +1,5 @@ --- Lint/ConstantDefinitionInBlock: - Details: grace period Exclude: - 'app/models/concerns/ignorable_columns.rb' - 'app/models/concerns/partitioned_table.rb' diff --git a/.rubocop_todo/lint/deprecated_constants.yml b/.rubocop_todo/lint/deprecated_constants.yml index ab0c9884e0a..644158311d7 100644 --- a/.rubocop_todo/lint/deprecated_constants.yml +++ b/.rubocop_todo/lint/deprecated_constants.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/DeprecatedConstants: - Details: grace period Exclude: - 'scripts/pipeline_test_report_builder.rb' - 'spec/scripts/pipeline_test_report_builder_spec.rb' diff --git a/.rubocop_todo/lint/duplicate_branch.yml b/.rubocop_todo/lint/duplicate_branch.yml index 6a171415cbc..4029432a9b0 100644 --- a/.rubocop_todo/lint/duplicate_branch.yml +++ b/.rubocop_todo/lint/duplicate_branch.yml @@ -1,6 +1,5 @@ --- Lint/DuplicateBranch: - Details: grace period Exclude: - 'app/controllers/concerns/issuable_collections.rb' - 'app/controllers/concerns/sorting_preference.rb' diff --git a/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml index c0d46ba9e95..41cf690e65a 100644 --- a/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml +++ b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml @@ -1,6 +1,5 @@ --- # Cop supports --autocorrect. Lint/DuplicateRegexpCharacterClassElement: - Details: grace period Exclude: - 'lib/gitlab/path_regex.rb' diff --git a/.rubocop_todo/lint/empty_block.yml b/.rubocop_todo/lint/empty_block.yml index e111703ce3b..5751ca7641f 100644 --- a/.rubocop_todo/lint/empty_block.yml +++ b/.rubocop_todo/lint/empty_block.yml @@ -1,6 +1,5 @@ --- Lint/EmptyBlock: - Details: grace period Exclude: - 'app/controllers/groups/boards_controller.rb' - 'app/controllers/projects/boards_controller.rb' diff --git a/.rubocop_todo/lint/empty_class.yml b/.rubocop_todo/lint/empty_class.yml index c7c90313992..c8caff58c35 100644 --- a/.rubocop_todo/lint/empty_class.yml +++ b/.rubocop_todo/lint/empty_class.yml @@ -1,5 +1,4 @@ --- Lint/EmptyClass: - Details: grace period Exclude: - 'spec/lib/gitlab/multi_destination_logger_spec.rb' diff --git a/.rubocop_todo/lint/incompatible_io_select_with_fiber_scheduler.yml b/.rubocop_todo/lint/incompatible_io_select_with_fiber_scheduler.yml index 7e9dd3970be..994b1d98b66 100644 --- a/.rubocop_todo/lint/incompatible_io_select_with_fiber_scheduler.yml +++ b/.rubocop_todo/lint/incompatible_io_select_with_fiber_scheduler.yml @@ -1,6 +1,5 @@ --- # Cop supports --autocorrect. Lint/IncompatibleIoSelectWithFiberScheduler: - Details: grace period Exclude: - 'lib/gitlab/stack_prof.rb' diff --git a/.rubocop_todo/lint/mixed_regexp_capture_types.yml b/.rubocop_todo/lint/mixed_regexp_capture_types.yml index 70f3773eb31..b2af57158de 100644 --- a/.rubocop_todo/lint/mixed_regexp_capture_types.yml +++ b/.rubocop_todo/lint/mixed_regexp_capture_types.yml @@ -2,6 +2,7 @@ Lint/MixedRegexpCaptureTypes: Exclude: - 'app/models/alert_management/alert.rb' + - 'app/models/integrations/clickup.rb' - 'app/models/integrations/ewm.rb' - 'app/uploaders/file_uploader.rb' - 'ee/lib/gitlab/code_owners/reference_extractor.rb' diff --git a/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml b/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml index 1d724ccc783..8a1dad40af0 100644 --- a/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml +++ b/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml @@ -1,6 +1,5 @@ --- Lint/NoReturnInBeginEndBlocks: - Details: grace period Exclude: - 'app/models/concerns/metric_image_uploading.rb' - 'app/models/merge_request.rb' diff --git a/.rubocop_todo/lint/non_atomic_file_operation.yml b/.rubocop_todo/lint/non_atomic_file_operation.yml index 924893c19de..cd700870448 100644 --- a/.rubocop_todo/lint/non_atomic_file_operation.yml +++ b/.rubocop_todo/lint/non_atomic_file_operation.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/NonAtomicFileOperation: - Details: grace period Exclude: - 'app/models/merge_request_diff.rb' - 'app/services/bulk_imports/file_decompression_service.rb' diff --git a/.rubocop_todo/lint/or_assignment_to_constant.yml b/.rubocop_todo/lint/or_assignment_to_constant.yml index 741d65e9ffa..505e7ba2935 100644 --- a/.rubocop_todo/lint/or_assignment_to_constant.yml +++ b/.rubocop_todo/lint/or_assignment_to_constant.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/OrAssignmentToConstant: - Details: grace period Exclude: - 'lib/gitlab/email/handler/base_handler.rb' - 'lib/gitlab/utils.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 6274aecec04..29f15deac2e 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -141,7 +141,6 @@ Lint/RedundantCopDisableDirective: - 'ee/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb' - 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb' - 'ee/lib/gitlab/elastic/bool_expr.rb' - 'ee/lib/gitlab/spdx/license.rb' diff --git a/.rubocop_todo/lint/redundant_dir_glob_sort.yml b/.rubocop_todo/lint/redundant_dir_glob_sort.yml index 84be6e2dd6a..1e4afd562f0 100644 --- a/.rubocop_todo/lint/redundant_dir_glob_sort.yml +++ b/.rubocop_todo/lint/redundant_dir_glob_sort.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/RedundantDirGlobSort: - Details: grace period Exclude: - 'app/models/release_highlight.rb' - 'config/application.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml index c7f8b9549fb..147cd66f993 100644 --- a/.rubocop_todo/lint/symbol_conversion.yml +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -1,15 +1,12 @@ --- # Cop supports --autocorrect. Lint/SymbolConversion: - Details: grace period Exclude: - 'app/controllers/projects/environments/sample_metrics_controller.rb' - 'app/helpers/breadcrumbs_helper.rb' - 'app/helpers/environments_helper.rb' - 'app/helpers/tooling/visual_review_helper.rb' - 'app/services/google_cloud/create_cloudsql_instance_service.rb' - - 'app/services/packages/debian/generate_distribution_key_service.rb' - - 'app/services/packages/debian/process_changes_service.rb' - 'config/puma.rb' - 'ee/app/components/billing/plan_component.rb' - 'ee/app/controllers/projects/security/scanned_resources_controller.rb' @@ -73,8 +70,6 @@ Lint/SymbolConversion: - 'spec/controllers/jira_connect/branches_controller_spec.rb' - 'spec/factories/ci/reports/codequality_degradations.rb' - 'spec/factories/evidences.rb' - - 'spec/factories/packages/helm/file_metadatum.rb' - - 'spec/factories/packages/npm/metadata.rb' - 'spec/features/file_uploads/graphql_add_design_spec.rb' - 'spec/features/projects/new_project_spec.rb' - 'spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb' @@ -127,9 +122,6 @@ Lint/SymbolConversion: - 'spec/lib/service_ping/devops_report_spec.rb' - 'spec/models/integrations/prometheus_spec.rb' - 'spec/models/merge_request_diff_commit_spec.rb' - - 'spec/models/packages/helm/file_metadatum_spec.rb' - - 'spec/models/packages/npm/metadatum_spec.rb' - - 'spec/presenters/packages/npm/package_presenter_spec.rb' - 'spec/requests/api/admin/plan_limits_spec.rb' - 'spec/requests/api/ci/job_artifacts_spec.rb' - 'spec/requests/api/ci/runner/jobs_put_spec.rb' @@ -159,4 +151,3 @@ Lint/SymbolConversion: - 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb' - 'spec/views/admin/application_settings/_repository_storage.html.haml_spec.rb' - 'spec/workers/gitlab/github_gists_import/import_gist_worker_spec.rb' - - 'spec/workers/packages/go/sync_packages_worker_spec.rb' diff --git a/.rubocop_todo/lint/to_enum_arguments.yml b/.rubocop_todo/lint/to_enum_arguments.yml index 3e5579b4afb..22b5d1f3a9d 100644 --- a/.rubocop_todo/lint/to_enum_arguments.yml +++ b/.rubocop_todo/lint/to_enum_arguments.yml @@ -1,6 +1,5 @@ --- Lint/ToEnumArguments: - Details: grace period Exclude: - 'lib/gitlab/ci/trace/stream.rb' - 'spec/lib/gitlab/ci/trace/section_parser_spec.rb' diff --git a/.rubocop_todo/lint/unexpected_block_arity.yml b/.rubocop_todo/lint/unexpected_block_arity.yml index a7ad3d0a227..39648dbad73 100644 --- a/.rubocop_todo/lint/unexpected_block_arity.yml +++ b/.rubocop_todo/lint/unexpected_block_arity.yml @@ -1,6 +1,5 @@ --- Lint/UnexpectedBlockArity: - Details: grace period Exclude: - 'app/services/issues/referenced_merge_requests_service.rb' - 'lib/gitlab/issuable_sorter.rb' diff --git a/.rubocop_todo/lint/unmodified_reduce_accumulator.yml b/.rubocop_todo/lint/unmodified_reduce_accumulator.yml index 6aec00738e7..84c5d380e7b 100644 --- a/.rubocop_todo/lint/unmodified_reduce_accumulator.yml +++ b/.rubocop_todo/lint/unmodified_reduce_accumulator.yml @@ -1,5 +1,4 @@ --- Lint/UnmodifiedReduceAccumulator: - Details: grace period Exclude: - 'qa/qa/specs/runner.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index 7676faf0275..0b4120a152c 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/UnusedBlockArgument: - Details: grace period Exclude: - 'app/controllers/application_controller.rb' - 'app/controllers/concerns/project_unauthorized.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index 45f18e605b7..bbd12e608a9 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/UnusedMethodArgument: - Details: grace period Exclude: - 'app/controllers/application_controller.rb' - 'app/controllers/concerns/authenticates_with_two_factor.rb' @@ -430,7 +429,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/cleanup/orphan_job_artifact_files.rb' - 'lib/gitlab/cleanup/orphan_job_artifact_files_batch.rb' - 'lib/gitlab/cleanup/project_upload_file_finder.rb' - - 'lib/gitlab/cluster/puma_worker_killer_observer.rb' - 'lib/gitlab/config/entry/composable_hash.rb' - 'lib/gitlab/config/entry/node.rb' - 'lib/gitlab/config/entry/validators.rb' @@ -493,7 +491,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/import_export/fast_hash_serializer.rb' - 'lib/gitlab/issuable_sorter.rb' - 'lib/gitlab/json.rb' - - 'lib/gitlab/json_cache.rb' - 'lib/gitlab/lfs/client.rb' - 'lib/gitlab/markdown_cache/redis/extension.rb' - 'lib/gitlab/memory/diagnostic_reports_logger.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index 9b6d26a53ca..02cc7d2a85c 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -95,7 +95,6 @@ Naming/HeredocDelimiterNaming: - 'spec/models/concerns/ci/maskable_spec.rb' - 'spec/models/integrations/asana_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service/cache_spec.rb' - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' diff --git a/.rubocop_todo/naming/inclusive_language.yml b/.rubocop_todo/naming/inclusive_language.yml index 465e338bbe7..8950e2e77f4 100644 --- a/.rubocop_todo/naming/inclusive_language.yml +++ b/.rubocop_todo/naming/inclusive_language.yml @@ -53,7 +53,6 @@ Naming/InclusiveLanguage: - 'rubocop/cop/destroy_all.rb' - 'rubocop/cop/graphql/id_type.rb' - 'rubocop/cop/group_public_or_visible_to_user.rb' - - 'rubocop/cop/ignored_columns.rb' - 'rubocop/cop/inject_enterprise_edition_module.rb' - 'rubocop/cop/migration/add_columns_to_wide_tables.rb' - 'spec/controllers/concerns/issuable_collections_spec.rb' diff --git a/.rubocop_todo/performance/flat_map.yml b/.rubocop_todo/performance/flat_map.yml index a7643f5fe9e..376a0b59a64 100644 --- a/.rubocop_todo/performance/flat_map.yml +++ b/.rubocop_todo/performance/flat_map.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Performance/FlatMap: - Details: grace period Exclude: - 'app/presenters/packages/nuget/service_index_presenter.rb' - 'app/services/projects/apple_target_platform_detector_service.rb' diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml index 2ea13f71fa4..1ed8ab1e2ee 100644 --- a/.rubocop_todo/performance/map_compact.yml +++ b/.rubocop_todo/performance/map_compact.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Performance/MapCompact: - Details: grace period Exclude: - 'app/graphql/resolvers/concerns/resolves_ids.rb' - 'app/graphql/resolvers/todos_resolver.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index e536c22e518..49182a51ea7 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -33,7 +33,6 @@ Rails/FilePath: - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' - 'ee/spec/validators/json_schema_validator_spec.rb' - 'lib/api/api.rb' - - 'lib/error_tracking/collector/payload_validator.rb' - 'lib/feature/definition.rb' - 'lib/gitlab/audit/type/definition.rb' - 'lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator.rb' @@ -126,5 +125,5 @@ Rails/FilePath: - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/wiki_shared_examples.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - - 'spec/tasks/gitlab/generate_sample_prometheus_data_spec.rb' + - 'spec/tasks/gitlab/generate_sample_prometheus_data_rake_spec.rb' - 'spec/tasks/gitlab/usage_data_rake_spec.rb' diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml index 59c0e14e180..30f5aaeff61 100644 --- a/.rubocop_todo/rails/inverse_of.yml +++ b/.rubocop_todo/rails/inverse_of.yml @@ -31,9 +31,7 @@ Rails/InverseOf: - 'app/models/jira_connect_subscription.rb' - 'app/models/members/group_member.rb' - 'app/models/members/project_member.rb' - - 'app/models/merge_request.rb' - 'app/models/merge_request/metrics.rb' - - 'app/models/merge_request_diff.rb' - 'app/models/namespace.rb' - 'app/models/notification_setting.rb' - 'app/models/packages/composer/cache_file.rb' @@ -60,7 +58,6 @@ Rails/InverseOf: - 'ee/app/models/ee/clusters/agent.rb' - 'ee/app/models/ee/epic.rb' - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/plan.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/ee/service_desk_setting.rb' diff --git a/.rubocop_todo/rails/lexically_scoped_action_filter.yml b/.rubocop_todo/rails/lexically_scoped_action_filter.yml index 1620fbd39b7..8a1591062ab 100644 --- a/.rubocop_todo/rails/lexically_scoped_action_filter.yml +++ b/.rubocop_todo/rails/lexically_scoped_action_filter.yml @@ -1,13 +1,11 @@ --- Rails/LexicallyScopedActionFilter: - Details: grace period Exclude: - 'app/controllers/admin/groups_controller.rb' - 'app/controllers/admin/hooks_controller.rb' - 'app/controllers/clusters/base_controller.rb' - 'app/controllers/clusters/clusters_controller.rb' - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - - 'app/controllers/concerns/integrations/actions.rb' - 'app/controllers/concerns/oauth_applications.rb' - 'app/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support.rb' - 'app/controllers/confirmations_controller.rb' diff --git a/.rubocop_todo/rails/negate_include.yml b/.rubocop_todo/rails/negate_include.yml index c99f15f98e3..22ccaa5998e 100644 --- a/.rubocop_todo/rails/negate_include.yml +++ b/.rubocop_todo/rails/negate_include.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Rails/NegateInclude: - Details: grace period Exclude: - 'app/finders/projects_finder.rb' - 'app/helpers/application_settings_helper.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 4571e1ae19e..06c0b2b1d42 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Rails/Pluck: - Details: grace period Exclude: - 'app/controllers/ldap/omniauth_callbacks_controller.rb' - 'app/finders/merge_requests/oldest_per_commit_finder.rb' diff --git a/.rubocop_todo/rspec/avoid_conditional_statements.yml b/.rubocop_todo/rspec/avoid_conditional_statements.yml index 43ffaaa452a..1e5388718ab 100644 --- a/.rubocop_todo/rspec/avoid_conditional_statements.yml +++ b/.rubocop_todo/rspec/avoid_conditional_statements.yml @@ -1,6 +1,5 @@ --- RSpec/AvoidConditionalStatements: - Details: grace period Exclude: - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/analytics/code_analytics_spec.rb' @@ -9,7 +8,6 @@ RSpec/AvoidConditionalStatements: - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/ci_shared_runner_warnings_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_spec.rb' - - 'ee/spec/features/epics/epic_show_spec.rb' - 'ee/spec/features/epics/gfm_autocomplete_spec.rb' - 'ee/spec/features/group_protected_branches_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' @@ -77,8 +75,6 @@ RSpec/AvoidConditionalStatements: - 'spec/features/projects/tree/create_file_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/search/user_uses_header_search_field_spec.rb' - - 'spec/features/snippets/explore_spec.rb' - - 'spec/features/tags/developer_creates_tag_spec.rb' - 'spec/features/usage_stats_consent_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/features/users/overview_spec.rb' diff --git a/.rubocop_todo/rspec/be.yml b/.rubocop_todo/rspec/be.yml deleted file mode 100644 index 17f857d0677..00000000000 --- a/.rubocop_todo/rspec/be.yml +++ /dev/null @@ -1,21 +0,0 @@ ---- -RSpec/Be: - Exclude: - - 'ee/spec/services/groups/transfer_service_spec.rb' - - 'spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - - 'spec/lib/gitlab/lets_encrypt/client_spec.rb' - - 'spec/lib/gitlab/search_context/builder_spec.rb' - - 'spec/migrations/20220503035221_add_gitlab_schema_to_batched_background_migrations_spec.rb' - - 'spec/models/concerns/issuable_spec.rb' - - 'spec/models/identity_spec.rb' - - 'spec/models/snippet_repository_spec.rb' - - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' - - 'spec/requests/api/pages_domains_spec.rb' - - 'spec/services/pages/delete_service_spec.rb' - - 'spec/services/pages/migrate_from_legacy_storage_service_spec.rb' - - 'spec/services/projects/update_pages_service_spec.rb' - - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' - - 'spec/uploaders/file_uploader_spec.rb' - - 'spec/uploaders/namespace_file_uploader_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index a2886ff9679..d32abc64f94 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -800,7 +800,6 @@ RSpec/ContextWording: - 'ee/spec/services/projects/operations/update_service_spec.rb' - 'ee/spec/services/projects/protect_default_branch_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' - - 'ee/spec/services/projects/slack_application_install_service_spec.rb' - 'ee/spec/services/projects/transfer_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - 'ee/spec/services/projects/update_service_spec.rb' @@ -903,7 +902,6 @@ RSpec/ContextWording: - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/ssh_keys/_ssh_key.html.haml_spec.rb' - 'ee/spec/views/shared/issuable/_sidebar.html.haml_spec.rb' - - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/workers/active_user_count_threshold_worker_spec.rb' - 'ee/spec/workers/adjourned_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/admin_emails_worker_spec.rb' @@ -972,7 +970,6 @@ RSpec/ContextWording: - 'spec/config/object_store_settings_spec.rb' - 'spec/controllers/admin/application_settings_controller_spec.rb' - 'spec/controllers/admin/instance_review_controller_spec.rb' - - 'spec/controllers/admin/integrations_controller_spec.rb' - 'spec/controllers/admin/sessions_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' @@ -1004,7 +1001,6 @@ RSpec/ContextWording: - 'spec/controllers/groups/registry/repositories_controller_spec.rb' - 'spec/controllers/groups/releases_controller_spec.rb' - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - - 'spec/controllers/groups/settings/integrations_controller_spec.rb' - 'spec/controllers/groups/settings/repository_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/help_controller_spec.rb' @@ -1508,7 +1504,7 @@ RSpec/ContextWording: - 'spec/helpers/wiki_helper_spec.rb' - 'spec/initializers/00_rails_disable_joins_spec.rb' - 'spec/initializers/1_acts_as_taggable_spec.rb' - - 'spec/initializers/carrierwave_patch_spec.rb' + - 'spec/initializers/carrierwave_s3_encryption_headers_patch_spec.rb' - 'spec/initializers/enumerator_next_patch_spec.rb' - 'spec/initializers/mail_encoding_patch_spec.rb' - 'spec/initializers/rack_multipart_patch_spec.rb' @@ -1600,7 +1596,6 @@ RSpec/ContextWording: - 'spec/lib/bulk_imports/clients/http_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/milestones_pipeline_spec.rb' - - 'spec/lib/bulk_imports/groups/transformers/member_attributes_transformer_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/ci_pipelines_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/merge_requests_pipeline_spec.rb' @@ -1961,7 +1956,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/metrics/subscribers/rack_attack_spec.rb' - 'spec/lib/gitlab/metrics_spec.rb' - 'spec/lib/gitlab/middleware/basic_health_check_spec.rb' - - 'spec/lib/gitlab/middleware/compressed_json_spec.rb' - 'spec/lib/gitlab/middleware/go_spec.rb' - 'spec/lib/gitlab/middleware/multipart_spec.rb' - 'spec/lib/gitlab/middleware/request_context_spec.rb' @@ -2394,7 +2388,6 @@ RSpec/ContextWording: - 'spec/requests/api/deploy_tokens_spec.rb' - 'spec/requests/api/deployments_spec.rb' - 'spec/requests/api/environments_spec.rb' - - 'spec/requests/api/error_tracking/collector_spec.rb' - 'spec/requests/api/files_spec.rb' - 'spec/requests/api/generic_packages_spec.rb' - 'spec/requests/api/graphql/ci/runner_spec.rb' @@ -2581,7 +2574,6 @@ RSpec/ContextWording: - 'spec/rubocop/cop/migration/safer_boolean_column_spec.rb' - 'spec/rubocop/cop/migration/schedule_async_spec.rb' - 'spec/rubocop/cop/migration/timestamps_spec.rb' - - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/rubocop/cop/migration/versioned_migration_class_spec.rb' - 'spec/rubocop/cop/performance/ar_exists_and_present_blank_spec.rb' - 'spec/rubocop/cop/qa/ambiguous_page_object_name_spec.rb' @@ -2679,7 +2671,6 @@ RSpec/ContextWording: - 'spec/services/draft_notes/publish_service_spec.rb' - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' - 'spec/services/environments/stop_service_spec.rb' - - 'spec/services/error_tracking/collect_error_service_spec.rb' - 'spec/services/error_tracking/list_issues_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/events/destroy_service_spec.rb' @@ -3118,7 +3109,7 @@ RSpec/ContextWording: - 'spec/support_specs/helpers/migrations_helpers_spec.rb' - 'spec/support_specs/helpers/stub_feature_flags_spec.rb' - 'spec/support_specs/helpers/stub_method_calls_spec.rb' - - 'spec/tasks/cache/clear/redis_spec.rb' + - 'spec/tasks/cache_rake_spec.rb' - 'spec/tasks/dev_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' @@ -3128,7 +3119,7 @@ RSpec/ContextWording: - 'spec/tasks/gitlab/lfs/migrate_rake_spec.rb' - 'spec/tasks/gitlab/packages/migrate_rake_spec.rb' - 'spec/tasks/gitlab/storage_rake_spec.rb' - - 'spec/tasks/gitlab/task_helpers_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' diff --git a/.rubocop_todo/rspec/empty_line_after_hook.yml b/.rubocop_todo/rspec/empty_line_after_hook.yml index fbfb7e8bfe0..7dc3fd235a4 100644 --- a/.rubocop_todo/rspec/empty_line_after_hook.yml +++ b/.rubocop_todo/rspec/empty_line_after_hook.yml @@ -41,7 +41,6 @@ RSpec/EmptyLineAfterHook: - 'spec/requests/api/pages/internal_access_spec.rb' - 'spec/requests/api/pages/private_access_spec.rb' - 'spec/requests/api/pages/public_access_spec.rb' - - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/services/merge_requests/execute_approval_hooks_service_spec.rb' - 'spec/services/notes/create_service_spec.rb' - 'spec/services/notes/quick_actions_service_spec.rb' diff --git a/.rubocop_todo/rspec/env_mocking.yml b/.rubocop_todo/rspec/env_mocking.yml index 5cb9666b7ec..c9e0dad986b 100644 --- a/.rubocop_todo/rspec/env_mocking.yml +++ b/.rubocop_todo/rspec/env_mocking.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. RSpec/EnvMocking: - Details: grace period Exclude: - 'ee/spec/lib/gitlab/elastic/client_spec.rb' - 'spec/initializers/net_http_patch_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 8cecf3677dc..abcd80f9b58 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. RSpec/ExpectChange: - Details: grace period Exclude: - 'ee/spec/graphql/mutations/boards/update_spec.rb' - 'ee/spec/graphql/mutations/incident_management/issuable_resource_link/create_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 4003908c97e..4b588f265c9 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -4,7 +4,6 @@ RSpec/ExpectInHook: - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/seat_usage_controller_spec.rb' - - 'ee/spec/controllers/projects/settings/slacks_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' @@ -469,7 +468,7 @@ RSpec/ExpectInHook: - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/gitaly_rake_spec.rb' - 'spec/tasks/gitlab/praefect_rake_spec.rb' - - 'spec/tasks/gitlab/task_helpers_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tooling/danger/feature_flag_spec.rb' - 'spec/tooling/rspec_flaky/listener_spec.rb' - 'spec/uploaders/file_mover_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index 3a990dcd12d..40f36f8ca26 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -6,7 +6,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb' - 'ee/spec/components/namespaces/free_user_cap/usage_quota_alert_component_spec.rb' - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/limit_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/project_pre_enforcement_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/subgroup_pre_enforcement_alert_component_spec.rb' @@ -49,9 +48,8 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/ee/todos_helper_spec.rb' - - 'ee/spec/helpers/trials_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - - 'ee/spec/helpers/ee/welcome_helper_spec.rb' + - 'ee/spec/helpers/welcome_helper_spec.rb' - 'ee/spec/helpers/ee/wiki_helper_spec.rb' - 'ee/spec/helpers/epics_helper_spec.rb' - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' @@ -79,9 +77,16 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/trial_status_widget_helper_spec.rb' + - 'ee/spec/helpers/trials_helper_spec.rb' - 'ee/spec/helpers/users/identity_verification_helper_spec.rb' - 'ee/spec/helpers/users_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' + - 'ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb' + - 'ee/spec/lib/sidebars/groups/menus/epics_menu_spec.rb' + - 'ee/spec/lib/sidebars/groups/menus/security_compliance_menu_spec.rb' + - 'ee/spec/lib/sidebars/groups/menus/wiki_menu_spec.rb' + - 'ee/spec/lib/sidebars/groups/super_sidebar_panel_spec.rb' + - 'ee/spec/lib/sidebars/projects/super_sidebar_panel_spec.rb' - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb' - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' - 'ee/spec/mailers/devise_mailer_spec.rb' @@ -224,7 +229,7 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/views/projects/security/policies/index.html.haml_spec.rb' - 'ee/spec/views/projects/security/sast_configuration/show.html.haml_spec.rb' - 'ee/spec/views/projects/settings/subscriptions/_index.html.haml_spec.rb' - - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' + - 'ee/spec/views/registrations/groups/new.html.haml_spec.rb' - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' - 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb' @@ -330,6 +335,29 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/helpers/whats_new_helper_spec.rb' - 'spec/helpers/wiki_helper_spec.rb' - 'spec/helpers/wiki_page_version_helper_spec.rb' + - 'spec/lib/sidebars/admin/menus/abuse_reports_menu_spec.rb' + - 'spec/lib/sidebars/groups/menus/ci_cd_menu_spec.rb' + - 'spec/lib/sidebars/groups/menus/group_information_menu_spec.rb' + - 'spec/lib/sidebars/groups/menus/issues_menu_spec.rb' + - 'spec/lib/sidebars/groups/menus/kubernetes_menu_spec.rb' + - 'spec/lib/sidebars/groups/menus/merge_requests_menu_spec.rb' + - 'spec/lib/sidebars/groups/menus/packages_registries_menu_spec.rb' + - 'spec/lib/sidebars/groups/menus/settings_menu_spec.rb' + - 'spec/lib/sidebars/groups/super_sidebar_panel_spec.rb' + - 'spec/lib/sidebars/projects/menus/analytics_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/confluence_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/deployments_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/hidden_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/infrastructure_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/issues_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/merge_requests_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/monitor_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/packages_registries_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/project_information_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/repository_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/security_compliance_menu_spec.rb' + - 'spec/lib/sidebars/projects/menus/shimo_menu_spec.rb' + - 'spec/lib/sidebars/projects/panel_spec.rb' - 'spec/mailers/abuse_report_mailer_spec.rb' - 'spec/mailers/devise_mailer_spec.rb' - 'spec/mailers/emails/auto_devops_spec.rb' @@ -376,7 +404,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/detail/package_presenter_spec.rb' - 'spec/presenters/packages/helm/index_presenter_spec.rb' - - 'spec/presenters/packages/npm/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/package_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_versions_presenter_spec.rb' @@ -586,8 +613,8 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/views/projects/hooks/edit.html.haml_spec.rb' - 'spec/views/projects/hooks/index.html.haml_spec.rb' - 'spec/views/projects/imports/new.html.haml_spec.rb' - - 'spec/views/projects/issues/_issue.html.haml_spec.rb' - 'spec/views/projects/issues/_service_desk_info_content.html.haml_spec.rb' + - 'spec/views/projects/issues/service_desk/_issue.html.haml_spec.rb' - 'spec/views/projects/issues/show.html.haml_spec.rb' - 'spec/views/projects/jobs/_build.html.haml_spec.rb' - 'spec/views/projects/jobs/_generic_commit_status.html.haml_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml b/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml index 456eca57804..732bfd246cf 100644 --- a/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml +++ b/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml @@ -1,6 +1,5 @@ --- RSpec/FactoryBot/StrategyInCallback: - Details: grace period Exclude: - 'ee/spec/factories/ci/builds.rb' - 'ee/spec/factories/ci/pipelines.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index fe632cdd57b..a5a0cec68d4 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -136,7 +136,6 @@ RSpec/InstanceVariable: - 'spec/requests/git_http_spec.rb' - 'spec/requests/openid_connect_spec.rb' - 'spec/requests/projects/issues/discussions_spec.rb' - - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/services/ci/process_sync_events_service_spec.rb' - 'spec/services/labels/update_service_spec.rb' - 'spec/services/members/destroy_service_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index 0382b0ff43e..0835191b8f4 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -499,7 +499,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/ee/system_note_helper_spec.rb' - 'ee/spec/helpers/ee/todos_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/ee/wiki_helper_spec.rb' - 'ee/spec/helpers/epics_helper_spec.rb' - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' @@ -695,7 +694,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/scim/value_parser_spec.rb' - 'ee/spec/lib/ee/gitlab/search_results_spec.rb' - 'ee/spec/lib/ee/gitlab/security/scan_configuration_spec.rb' - - 'ee/spec/lib/ee/gitlab/slash_commands/incident_management/incident_new_spec.rb' - 'ee/spec/lib/ee/gitlab/snippet_search_results_spec.rb' - 'ee/spec/lib/ee/gitlab/template/gitlab_ci_yml_template_spec.rb' - 'ee/spec/lib/ee/gitlab/tracking_spec.rb' @@ -1369,7 +1367,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/serializers/member_user_entity_spec.rb' - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb' - 'ee/spec/serializers/merge_request_sidebar_basic_entity_spec.rb' - - 'ee/spec/serializers/merge_request_widget_entity_spec.rb' - 'ee/spec/serializers/metrics_report_metric_entity_spec.rb' - 'ee/spec/serializers/metrics_reports_comparer_entity_spec.rb' - 'ee/spec/serializers/pipeline_serializer_spec.rb' @@ -1550,12 +1547,10 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/layouts/checkout.html.haml_spec.rb' - - 'ee/spec/views/layouts/group.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_current_user_dropdown.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_ee_subscribable_banner.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_read_only_banner.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' - - 'ee/spec/views/layouts/project.html.haml_spec.rb' - 'ee/spec/views/operations/environments.html.haml_spec.rb' - 'ee/spec/views/operations/index.html.haml_spec.rb' - 'ee/spec/views/profiles/preferences/show.html.haml_spec.rb' @@ -1573,7 +1568,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/projects/security/sast_configuration/show.html.haml_spec.rb' - 'ee/spec/views/projects/settings/merge_requests/_merge_request_approvals.html.haml_spec.rb' - 'ee/spec/views/projects/settings/subscriptions/_index.html.haml_spec.rb' - - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' - 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb' @@ -1599,7 +1593,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/shared/promotions/_promotion_link_project.html.haml_spec.rb' - 'ee/spec/views/subscriptions/buy_minutes.html.haml_spec.rb' - 'ee/spec/views/subscriptions/buy_storage.html.haml_spec.rb' - - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/views/subscriptions/new.html.haml_spec.rb' - 'ee/spec/views/trial_registrations/new.html.haml_spec.rb' - 'spec/bin/audit_event_type_spec.rb' @@ -1639,7 +1632,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/admin/hooks_controller_spec.rb' - 'spec/controllers/admin/identities_controller_spec.rb' - 'spec/controllers/admin/impersonations_controller_spec.rb' - - 'spec/controllers/admin/integrations_controller_spec.rb' - 'spec/controllers/admin/jobs_controller_spec.rb' - 'spec/controllers/admin/plan_limits_controller_spec.rb' - 'spec/controllers/admin/projects_controller_spec.rb' @@ -1702,7 +1694,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/groups/releases_controller_spec.rb' - 'spec/controllers/groups/settings/applications_controller_spec.rb' - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - - 'spec/controllers/groups/settings/integrations_controller_spec.rb' - 'spec/controllers/groups/settings/repository_controller_spec.rb' - 'spec/controllers/groups/shared_projects_controller_spec.rb' - 'spec/controllers/groups/uploads_controller_spec.rb' @@ -2646,7 +2637,7 @@ RSpec/MissingFeatureCategory: - 'spec/initializers/action_mailer_hooks_spec.rb' - 'spec/initializers/active_record_locking_spec.rb' - 'spec/initializers/asset_proxy_setting_spec.rb' - - 'spec/initializers/carrierwave_patch_spec.rb' + - 'spec/initializers/carrierwave_s3_encryption_headers_patch_spec.rb' - 'spec/initializers/cookies_serializer_spec.rb' - 'spec/initializers/database_config_spec.rb' - 'spec/initializers/direct_upload_support_spec.rb' @@ -2808,7 +2799,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/groups/pipelines/group_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/pipelines/namespace_settings_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' - - 'spec/lib/bulk_imports/groups/transformers/member_attributes_transformer_spec.rb' - 'spec/lib/bulk_imports/groups/transformers/subgroup_to_entity_transformer_spec.rb' - 'spec/lib/bulk_imports/network_error_spec.rb' - 'spec/lib/bulk_imports/pipeline/context_spec.rb' @@ -2852,9 +2842,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/csv_builder_spec.rb' - 'spec/lib/csv_builders/stream_spec.rb' - 'spec/lib/declarative_enum_spec.rb' - - 'spec/lib/error_tracking/collector/payload_validator_spec.rb' - - 'spec/lib/error_tracking/collector/sentry_auth_parser_spec.rb' - - 'spec/lib/error_tracking/collector/sentry_request_parser_spec.rb' - 'spec/lib/error_tracking/sentry_client/api_urls_spec.rb' - 'spec/lib/error_tracking/sentry_client/event_spec.rb' - 'spec/lib/error_tracking/sentry_client/issue_link_spec.rb' @@ -3307,13 +3294,11 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/status/pipeline/factory_spec.rb' - 'spec/lib/gitlab/ci/status/preparing_spec.rb' - 'spec/lib/gitlab/ci/status/running_spec.rb' - - 'spec/lib/gitlab/ci/status/scheduled_spec.rb' - 'spec/lib/gitlab/ci/status/skipped_spec.rb' - 'spec/lib/gitlab/ci/status/stage/common_spec.rb' - 'spec/lib/gitlab/ci/status/stage/factory_spec.rb' - 'spec/lib/gitlab/ci/status/stage/play_manual_spec.rb' - 'spec/lib/gitlab/ci/status/success_spec.rb' - - 'spec/lib/gitlab/ci/status/success_warning_spec.rb' - 'spec/lib/gitlab/ci/status/waiting_for_resource_spec.rb' - 'spec/lib/gitlab/ci/tags/bulk_insert_spec.rb' - 'spec/lib/gitlab/ci/templates/AWS/deploy_ecs_gitlab_ci_yaml_spec.rb' @@ -3356,8 +3341,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/closing_issue_extractor_spec.rb' - 'spec/lib/gitlab/cluster/lifecycle_events_spec.rb' - 'spec/lib/gitlab/cluster/mixins/puma_cluster_spec.rb' - - 'spec/lib/gitlab/cluster/puma_worker_killer_initializer_spec.rb' - - 'spec/lib/gitlab/cluster/puma_worker_killer_observer_spec.rb' - 'spec/lib/gitlab/cluster/rack_timeout_observer_spec.rb' - 'spec/lib/gitlab/code_navigation_path_spec.rb' - 'spec/lib/gitlab/color_schemes_spec.rb' @@ -3924,7 +3907,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/jira_import/labels_importer_spec.rb' - 'spec/lib/gitlab/jira_import/metadata_collector_spec.rb' - 'spec/lib/gitlab/jira_import_spec.rb' - - 'spec/lib/gitlab/json_cache_spec.rb' - 'spec/lib/gitlab/json_logger_spec.rb' - 'spec/lib/gitlab/json_spec.rb' - 'spec/lib/gitlab/jwt_authenticatable_spec.rb' @@ -4055,7 +4037,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/metrics/web_transaction_spec.rb' - 'spec/lib/gitlab/metrics_spec.rb' - 'spec/lib/gitlab/middleware/basic_health_check_spec.rb' - - 'spec/lib/gitlab/middleware/compressed_json_spec.rb' - 'spec/lib/gitlab/middleware/handle_ip_spoof_attack_error_spec.rb' - 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb' - 'spec/lib/gitlab/middleware/memory_report_spec.rb' @@ -5315,7 +5296,6 @@ RSpec/MissingFeatureCategory: - 'spec/rubocop/cop/graphql/old_types_spec.rb' - 'spec/rubocop/cop/graphql/resolver_type_spec.rb' - 'spec/rubocop/cop/group_public_or_visible_to_user_spec.rb' - - 'spec/rubocop/cop/ignored_columns_spec.rb' - 'spec/rubocop/cop/include_sidekiq_worker_spec.rb' - 'spec/rubocop/cop/inject_enterprise_edition_module_spec.rb' - 'spec/rubocop/cop/migration/add_columns_to_wide_tables_spec.rb' @@ -5347,7 +5327,6 @@ RSpec/MissingFeatureCategory: - 'spec/rubocop/cop/migration/schema_addition_methods_no_post_spec.rb' - 'spec/rubocop/cop/migration/sidekiq_queue_migrate_spec.rb' - 'spec/rubocop/cop/migration/timestamps_spec.rb' - - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/rubocop/cop/migration/with_lock_retries_disallowed_method_spec.rb' - 'spec/rubocop/cop/migration/with_lock_retries_with_change_spec.rb' - 'spec/rubocop/cop/performance/active_record_subtransaction_methods_spec.rb' @@ -5544,7 +5523,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/merge_request_sidebar_extras_entity_spec.rb' - 'spec/serializers/merge_request_user_entity_spec.rb' - 'spec/serializers/merge_request_widget_commit_entity_spec.rb' - - 'spec/serializers/merge_request_widget_entity_spec.rb' - 'spec/serializers/merge_requests/pipeline_entity_spec.rb' - 'spec/serializers/move_to_project_entity_spec.rb' - 'spec/serializers/move_to_project_serializer_spec.rb' @@ -5609,7 +5587,7 @@ RSpec/MissingFeatureCategory: - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - 'spec/support_specs/time_travel_spec.rb' - 'spec/tasks/admin_mode_spec.rb' - - 'spec/tasks/config_lint_spec.rb' + - 'spec/tasks/config_lint_rake_spec.rb' - 'spec/tasks/dev_rake_spec.rb' - 'spec/tasks/gitlab/artifacts/check_rake_spec.rb' - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb' @@ -5617,7 +5595,7 @@ RSpec/MissingFeatureCategory: - 'spec/tasks/gitlab/container_registry_rake_spec.rb' - 'spec/tasks/gitlab/dependency_proxy/migrate_rake_spec.rb' - 'spec/tasks/gitlab/external_diffs_rake_spec.rb' - - 'spec/tasks/gitlab/generate_sample_prometheus_data_spec.rb' + - 'spec/tasks/gitlab/generate_sample_prometheus_data_rake_spec.rb' - 'spec/tasks/gitlab/git_rake_spec.rb' - 'spec/tasks/gitlab/gitaly_rake_spec.rb' - 'spec/tasks/gitlab/ldap_rake_spec.rb' @@ -5633,7 +5611,7 @@ RSpec/MissingFeatureCategory: - 'spec/tasks/gitlab/sidekiq_rake_spec.rb' - 'spec/tasks/gitlab/smtp_rake_spec.rb' - 'spec/tasks/gitlab/snippets_rake_spec.rb' - - 'spec/tasks/gitlab/task_helpers_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - 'spec/tasks/gitlab/uploads/check_rake_spec.rb' - 'spec/tasks/gitlab/uploads/migrate_rake_spec.rb' @@ -5642,7 +5620,7 @@ RSpec/MissingFeatureCategory: - 'spec/tasks/gitlab/x509/update_rake_spec.rb' - 'spec/tasks/migrate/schema_check_rake_spec.rb' - 'spec/tasks/rubocop_rake_spec.rb' - - 'spec/tasks/tokens_spec.rb' + - 'spec/tasks/tokens_rake_spec.rb' - 'spec/tooling/danger/config_files_spec.rb' - 'spec/tooling/danger/customer_success_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' diff --git a/.rubocop_todo/rspec/misspelled_aggregate_failures.yml b/.rubocop_todo/rspec/misspelled_aggregate_failures.yml deleted file mode 100644 index 75465411b63..00000000000 --- a/.rubocop_todo/rspec/misspelled_aggregate_failures.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -# Cop supports --autocorrect. -RSpec/MisspelledAggregateFailures: - Details: grace period diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index da4c41e2f6d..20e4112da62 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -79,7 +79,6 @@ RSpec/ReturnFromStub: - 'spec/bin/feature_flag_spec.rb' - 'spec/config/settings_spec.rb' - 'spec/controllers/admin/application_settings_controller_spec.rb' - - 'spec/controllers/admin/integrations_controller_spec.rb' - 'spec/controllers/concerns/page_limiter_spec.rb' - 'spec/controllers/concerns/send_file_upload_spec.rb' - 'spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 573991418f7..479ff4fd8f9 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -72,7 +72,6 @@ RSpec/ScatteredLet: - 'ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb' - 'ee/spec/services/security/report_summary_service_spec.rb' - 'ee/spec/services/vulnerabilities/security_finding/create_issue_service_spec.rb' - - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' - 'spec/controllers/concerns/metrics_dashboard_spec.rb' - 'spec/controllers/import/bitbucket_server_controller_spec.rb' @@ -223,7 +222,6 @@ RSpec/ScatteredLet: - 'spec/requests/api/notes_spec.rb' - 'spec/requests/api/project_clusters_spec.rb' - 'spec/requests/jira_routing_spec.rb' - - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/serializers/build_details_entity_spec.rb' - 'spec/serializers/ci/job_entity_spec.rb' - 'spec/serializers/merge_requests/pipeline_entity_spec.rb' diff --git a/.rubocop_todo/rspec/shared_groups_metadata.yml b/.rubocop_todo/rspec/shared_groups_metadata.yml index ddac8bf6589..b8de7d415bb 100644 --- a/.rubocop_todo/rspec/shared_groups_metadata.yml +++ b/.rubocop_todo/rspec/shared_groups_metadata.yml @@ -1,6 +1,5 @@ --- RSpec/SharedGroupsMetadata: - Details: grace period Exclude: - 'spec/lib/gitlab/ci/config/entry/retry_spec.rb' - 'spec/lib/gitlab/git/merge_base_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 88b6f302e56..9b0432f6546 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -456,7 +456,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb' - 'spec/lib/gitlab/cleanup/project_uploads_spec.rb' - 'spec/lib/gitlab/cleanup/remote_uploads_spec.rb' - - 'spec/lib/gitlab/cluster/puma_worker_killer_observer_spec.rb' - 'spec/lib/gitlab/cluster/rack_timeout_observer_spec.rb' - 'spec/lib/gitlab/color_schemes_spec.rb' - 'spec/lib/gitlab/conan_token_spec.rb' @@ -609,7 +608,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/jira_import/metadata_collector_spec.rb' - 'spec/lib/gitlab/jira_import_spec.rb' - 'spec/lib/gitlab/job_waiter_spec.rb' - - 'spec/lib/gitlab/json_cache_spec.rb' - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kubernetes/config_map_spec.rb' - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' @@ -942,7 +940,6 @@ RSpec/VerifiedDoubles: - 'spec/support/helpers/ldap_helpers.rb' - 'spec/support/helpers/project_forks_helper.rb' - 'spec/support/helpers/stub_metrics.rb' - - 'spec/support/helpers/stub_spam_services.rb' - 'spec/support/import_export/common_util.rb' - 'spec/support/prometheus/additional_metrics_shared_examples.rb' - 'spec/support/shared_contexts/lib/gitlab/sidekiq_middleware/server_metrics_shared_context.rb' diff --git a/.rubocop_todo/search/namespaced_class.yml b/.rubocop_todo/search/namespaced_class.yml index ad27603ad47..ba2dbafb3c7 100644 --- a/.rubocop_todo/search/namespaced_class.yml +++ b/.rubocop_todo/search/namespaced_class.yml @@ -1,6 +1,5 @@ --- Search/NamespacedClass: - Details: grace period Exclude: - 'app/controllers/concerns/search_rate_limitable.rb' - 'app/controllers/search_controller.rb' @@ -22,6 +21,7 @@ Search/NamespacedClass: - 'ee/app/graphql/types/iteration_searchable_field_enum.rb' - 'ee/app/helpers/ee/search_helper.rb' - 'ee/app/models/concerns/elastic/application_versioned_search.rb' + - 'ee/app/models/concerns/elastic/maintain_elasticsearch_on_group_update.rb' - 'ee/app/models/concerns/elastic/namespace_update.rb' - 'ee/app/models/concerns/elastic/projects_search.rb' - 'ee/app/models/concerns/elastic/repositories_search.rb' @@ -54,6 +54,7 @@ Search/NamespacedClass: - 'ee/app/workers/concerns/elastic/bulk_cron_worker.rb' - 'ee/app/workers/concerns/elastic/indexing_control.rb' - 'ee/app/workers/concerns/elastic/migration_backfill_helper.rb' + - 'ee/app/workers/concerns/elastic/migration_create_index.rb' - 'ee/app/workers/concerns/elastic/migration_helper.rb' - 'ee/app/workers/concerns/elastic/migration_obsolete.rb' - 'ee/app/workers/concerns/elastic/migration_options.rb' @@ -117,6 +118,8 @@ Search/NamespacedClass: - 'ee/lib/elastic/latest/snippet_instance_proxy.rb' - 'ee/lib/elastic/latest/state_filter.rb' - 'ee/lib/elastic/latest/user_class_proxy.rb' + - 'ee/lib/elastic/latest/wiki_class_proxy.rb' + - 'ee/lib/elastic/latest/wiki_instance_proxy.rb' - 'ee/lib/elastic/latest/user_config.rb' - 'ee/lib/elastic/latest/user_instance_proxy.rb' - 'ee/lib/elastic/latest/wiki_config.rb' @@ -148,6 +151,8 @@ Search/NamespacedClass: - 'ee/lib/elastic/v12p1/snippet_instance_proxy.rb' - 'ee/lib/elastic/v12p1/user_class_proxy.rb' - 'ee/lib/elastic/v12p1/user_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/wiki_class_proxy.rb' + - 'ee/lib/elastic/v12p1/wiki_instance_proxy.rb' - 'ee/lib/gem_extensions/elasticsearch/model/adapter/active_record/importing.rb' - 'ee/lib/gem_extensions/elasticsearch/model/adapter/multiple/records.rb' - 'ee/lib/gem_extensions/elasticsearch/model/client.rb' diff --git a/.rubocop_todo/security/compound_hash.yml b/.rubocop_todo/security/compound_hash.yml index 92f6fbb7b26..6e64f14210c 100644 --- a/.rubocop_todo/security/compound_hash.yml +++ b/.rubocop_todo/security/compound_hash.yml @@ -1,6 +1,5 @@ --- Security/CompoundHash: - Details: grace period Exclude: - 'ee/app/models/vulnerabilities/finding.rb' - 'ee/lib/gitlab/ci/reports/dependency_list/vulnerability.rb' diff --git a/.rubocop_todo/security/io_methods.yml b/.rubocop_todo/security/io_methods.yml deleted file mode 100644 index 453c9e1c9e1..00000000000 --- a/.rubocop_todo/security/io_methods.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -# Cop supports --autocorrect. -Security/IoMethods: - Details: grace period diff --git a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml index a7311c1c6df..9eed58acdc7 100644 --- a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml +++ b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml @@ -1,6 +1,5 @@ --- SidekiqLoadBalancing/WorkerDataConsistency: - Details: grace period Exclude: - 'app/workers/admin_email_worker.rb' - 'app/workers/analytics/usage_trends/count_job_trigger_worker.rb' @@ -325,12 +324,10 @@ SidekiqLoadBalancing/WorkerDataConsistency: - 'ee/app/workers/arkose/blocked_users_report_worker.rb' - 'ee/app/workers/auth/saml_group_sync_worker.rb' - 'ee/app/workers/automation/execute_rule_worker.rb' - - 'ee/app/workers/ci/batch_reset_minutes_worker.rb' - 'ee/app/workers/ci/minutes/refresh_cached_data_worker.rb' - 'ee/app/workers/ci/minutes/update_project_and_namespace_usage_worker.rb' - 'ee/app/workers/ci/sync_reports_to_report_approval_rules_worker.rb' - 'ee/app/workers/ci/upstream_projects_subscriptions_cleanup_worker.rb' - - 'ee/app/workers/clear_shared_runners_minutes_worker.rb' - 'ee/app/workers/compliance_management/chain_of_custody_report_worker.rb' - 'ee/app/workers/compliance_management/merge_requests/compliance_violations_consistency_worker.rb' - 'ee/app/workers/compliance_management/merge_requests/compliance_violations_worker.rb' diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml index 132f0854700..554dc64c39c 100644 --- a/.rubocop_todo/style/bare_percent_literals.yml +++ b/.rubocop_todo/style/bare_percent_literals.yml @@ -2,13 +2,6 @@ # Cop supports --autocorrect. Style/BarePercentLiterals: Exclude: - - 'app/models/commit.rb' - - 'app/models/concerns/storage/legacy_namespace.rb' - - 'app/models/integrations/datadog.rb' - - 'app/services/feature_flags/base_service.rb' - - 'app/services/repositories/base_service.rb' - - 'ee/app/services/jira/jql_builder_service.rb' - - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/spec/features/projects/environments/environments_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' @@ -16,18 +9,6 @@ Style/BarePercentLiterals: - 'ee/spec/lib/gitlab/status_page/filter/image_filter_spec.rb' - 'ee/spec/requests/api/ci/jobs_spec.rb' - 'ee/spec/services/geo/container_repository_sync_spec.rb' - - 'lib/banzai/filter/autolink_filter.rb' - - 'lib/banzai/filter/references/reference_filter.rb' - - 'lib/banzai/filter/spaced_link_filter.rb' - - 'lib/banzai/filter/table_of_contents_filter.rb' - - 'lib/banzai/issuable_extractor.rb' - - 'lib/gitlab/authorized_keys.rb' - - 'lib/gitlab/etag_caching/middleware.rb' - - 'lib/gitlab/etag_caching/router/rails.rb' - - 'lib/gitlab/gl_repository/identifier.rb' - - 'lib/gitlab/import_export/repo_restorer.rb' - - 'lib/kramdown/parser/atlassian_document_format.rb' - - 'lib/tasks/tanuki_emoji.rake' - 'qa/qa/ee/page/dashboard/projects.rb' - 'qa/qa/ee/page/group/settings/general.rb' - 'qa/qa/ee/page/project/issue/show.rb' @@ -46,8 +27,6 @@ Style/BarePercentLiterals: - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - 'qa/spec/runtime/feature_spec.rb' - - 'scripts/regenerate-schema' - - 'scripts/trigger-build.rb' - 'spec/controllers/import/fogbugz_controller_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/design_management/designs/raw_images_controller_spec.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index 4257adbdc6f..55df73d3633 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -412,7 +412,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/groups/wikis_controller.rb' - 'ee/app/controllers/oauth/geo_auth_controller.rb' - 'ee/app/controllers/profiles/billings_controller.rb' - - 'ee/app/controllers/profiles/slacks_controller.rb' - 'ee/app/controllers/projects/analytics/issues_analytics_controller.rb' - 'ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb' - 'ee/app/controllers/projects/approver_groups_controller.rb' @@ -502,7 +501,6 @@ Style/ClassAndModuleChildren: - 'ee/lib/ee/gitlab/throttle.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - 'lib/api/error_tracking/client_keys.rb' - - 'lib/api/error_tracking/collector.rb' - 'lib/api/error_tracking/project_settings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/ci/badge/base.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index adf3e8ee9b2..184e0d926d5 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -94,7 +94,6 @@ Style/EmptyMethod: - 'ee/app/controllers/projects/security/dast_scanner_profiles_controller.rb' - 'ee/app/controllers/projects/security/dast_site_profiles_controller.rb' - 'ee/app/controllers/projects/security/sast_configuration_controller.rb' - - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/controllers/subscriptions/groups_controller.rb' - 'ee/app/models/ee/epic.rb' - 'ee/app/services/feature_flag_issues/destroy_service.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 50a823c9ee8..8613e240d9c 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -255,7 +255,7 @@ Style/GuardClause: - 'app/workers/repository_update_remote_mirror_worker.rb' - 'app/workers/terraform/states/destroy_worker.rb' - 'config/initializers/0_inject_enterprise_edition_module.rb' - - 'config/initializers/carrierwave_patch.rb' + - 'config/initializers/carrierwave_s3_encryption_headers_patch.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/postgresql_cte.rb' - 'config/object_store_settings.rb' @@ -274,7 +274,6 @@ Style/GuardClause: - 'ee/app/controllers/profiles/billings_controller.rb' - 'ee/app/controllers/projects/path_locks_controller.rb' - 'ee/app/controllers/projects/security/policies_controller.rb' - - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/controllers/smartcard_controller.rb' - 'ee/app/finders/ee/template_finder.rb' - 'ee/app/finders/iterations_finder.rb' @@ -406,7 +405,6 @@ Style/GuardClause: - 'ee/lib/ee/gitlab/gon_helper.rb' - 'ee/lib/ee/gitlab/omniauth_initializer.rb' - 'ee/lib/ee/sidebars/projects/panel.rb' - - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/base_time.rb' - 'ee/lib/gitlab/ci/config/security_orchestration_policies/processor.rb' - 'ee/lib/gitlab/ci/minutes/cost_factor.rb' @@ -430,7 +428,6 @@ Style/GuardClause: - 'ee/spec/support/ci/minutes_helpers.rb' - 'haml_lint/linter/documentation_links.rb' - 'lib/api/commits.rb' - - 'lib/api/error_tracking/collector.rb' - 'lib/api/feature_flags.rb' - 'lib/api/helpers.rb' - 'lib/api/helpers/packages/conan/api_helpers.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 78e27951786..2ca9b22f0ad 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -249,7 +249,6 @@ Style/IfUnlessModifier: - 'app/services/emails/create_service.rb' - 'app/services/environments/canary_ingress/update_service.rb' - 'app/services/environments/reset_auto_stop_service.rb' - - 'app/services/error_tracking/collect_error_service.rb' - 'app/services/git/process_ref_changes_service.rb' - 'app/services/google_cloud/generate_pipeline_service.rb' - 'app/services/groups/create_service.rb' @@ -411,7 +410,6 @@ Style/IfUnlessModifier: - 'ee/app/controllers/projects/integrations/zentao/issues_controller.rb' - 'ee/app/controllers/projects/path_locks_controller.rb' - 'ee/app/controllers/projects/push_rules_controller.rb' - - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' @@ -602,7 +600,6 @@ Style/IfUnlessModifier: - 'ee/lib/ee/sidebars/projects/menus/analytics_menu.rb' - 'ee/lib/ee/sidebars/projects/menus/security_compliance_menu.rb' - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/elastic/latest/git_instance_proxy.rb' - 'ee/lib/gitlab/auth/group_saml/session_enforcer.rb' - 'ee/lib/gitlab/authority_analyzer.rb' diff --git a/.rubocop_todo/style/lambda.yml b/.rubocop_todo/style/lambda.yml index 270cdafa855..d874a388e08 100644 --- a/.rubocop_todo/style/lambda.yml +++ b/.rubocop_todo/style/lambda.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Style/Lambda: - Details: grace period Exclude: - 'app/controllers/concerns/project_unauthorized.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' @@ -27,7 +26,6 @@ Style/Lambda: - 'ee/lib/ee/api/entities/group_push_rule.rb' - 'ee/lib/ee/banzai/filter/sanitization_filter.rb' - 'ee/lib/ee/gitlab/checks/diff_check.rb' - - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/gem_extensions/elasticsearch/model/adapter/active_record/importing.rb' - 'ee/spec/elastic_integration/global_search_spec.rb' - 'ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb' diff --git a/.rubocop_todo/style/mutable_constant.yml b/.rubocop_todo/style/mutable_constant.yml index 8e6a0a2335b..a86662db014 100644 --- a/.rubocop_todo/style/mutable_constant.yml +++ b/.rubocop_todo/style/mutable_constant.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Style/MutableConstant: - Details: grace period Exclude: - 'app/finders/group_members_finder.rb' - 'app/graphql/mutations/container_repositories/destroy_tags.rb' @@ -40,16 +39,6 @@ Style/MutableConstant: - 'lib/gitlab/sidekiq_signals.rb' - 'lib/gitlab/web_hooks/recursion_detection/uuid.rb' - 'lib/tasks/gitlab/backup.rake' - - 'rubocop/cop/background_migration/feature_category.rb' - - 'rubocop/cop/filename_length.rb' - - 'rubocop/cop/gitlab/event_store_subscriber.rb' - - 'rubocop/cop/graphql/descriptions.rb' - - 'rubocop/cop/graphql/enum_names.rb' - - 'rubocop/cop/migration/prevent_index_creation.rb' - - 'rubocop/cop/migration/versioned_migration_class.rb' - - 'rubocop/cop/migration/with_lock_retries_disallowed_method.rb' - - 'rubocop/cop/scalability/idempotent_worker.rb' - - 'rubocop/cop/sidekiq_load_balancing/worker_data_consistency.rb' - 'scripts/lib/glfm/constants.rb' - 'scripts/lint-docs-blueprints.rb' - 'scripts/perf/gc/collect_gc_stats.rb' diff --git a/.rubocop_todo/style/numbered_parameters.yml b/.rubocop_todo/style/numbered_parameters.yml index fc08515bc2f..f9500ca55f7 100644 --- a/.rubocop_todo/style/numbered_parameters.yml +++ b/.rubocop_todo/style/numbered_parameters.yml @@ -1,6 +1,5 @@ --- Style/NumberedParameters: - Details: grace period Exclude: - 'app/controllers/concerns/web_hooks/hook_actions.rb' - 'app/controllers/graphql_controller.rb' @@ -15,6 +14,7 @@ Style/NumberedParameters: - 'app/models/concerns/integrations/reset_secret_fields.rb' - 'app/models/hooks/web_hook.rb' - 'app/models/integration.rb' + - 'app/models/integrations/clickup.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/youtrack.rb' - 'app/models/project.rb' diff --git a/.rubocop_todo/style/open_struct_use.yml b/.rubocop_todo/style/open_struct_use.yml index 15e4539072d..c21b63bc22b 100644 --- a/.rubocop_todo/style/open_struct_use.yml +++ b/.rubocop_todo/style/open_struct_use.yml @@ -5,7 +5,6 @@ Style/OpenStructUse: - 'ee/spec/finders/template_finder_spec.rb' - 'ee/spec/helpers/ee/blob_helper_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/failure_handler_spec.rb' - - 'spec/factories/wiki_pages.rb' - 'spec/helpers/profiles_helper_spec.rb' - 'spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/diff_stitcher_spec.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 496f05c7cab..2e03bbf4557 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -33,7 +33,6 @@ Style/PercentLiteralDelimiters: - 'app/models/blob_viewer/godeps_json.rb' - 'app/models/blob_viewer/license.rb' - 'app/models/blob_viewer/markup.rb' - - 'app/models/blob_viewer/metrics_dashboard_yml.rb' - 'app/models/blob_viewer/notebook.rb' - 'app/models/blob_viewer/open_api.rb' - 'app/models/blob_viewer/package_json.rb' @@ -245,7 +244,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/elastic/class_proxy_util.rb' - 'ee/lib/elastic/latest/config.rb' - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/elastic/latest/project_instance_proxy.rb' - 'ee/lib/elastic/latest/snippet_class_proxy.rb' - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' @@ -1081,7 +1079,7 @@ Style/PercentLiteralDelimiters: - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - - 'spec/tasks/gitlab/task_helpers_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tooling/danger/customer_success_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml index b65fe11a9b7..c2ff275db69 100644 --- a/.rubocop_todo/style/redundant_freeze.yml +++ b/.rubocop_todo/style/redundant_freeze.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Style/RedundantFreeze: - Details: grace period Exclude: - 'app/controllers/help_controller.rb' - 'app/controllers/import/bitbucket_server_controller.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 3168a5d2150..df5c1b6172a 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -232,7 +232,6 @@ Style/RedundantSelf: - 'ee/lib/ee/legacy_model.rb' - 'ee/lib/ee/model.rb' - 'ee/lib/elastic/instance_proxy_util.rb' - - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/elastic/latest/commit_config.rb' - 'ee/lib/elastic/latest/issue_config.rb' - 'ee/lib/elastic/latest/merge_request_config.rb' diff --git a/.rubocop_todo/style/sole_nested_conditional.yml b/.rubocop_todo/style/sole_nested_conditional.yml index 9b867a430f2..65cac595cde 100644 --- a/.rubocop_todo/style/sole_nested_conditional.yml +++ b/.rubocop_todo/style/sole_nested_conditional.yml @@ -33,7 +33,6 @@ Style/SoleNestedConditional: - 'ee/app/workers/ee/post_receive.rb' - 'ee/lib/ee/gitlab/auth/o_auth/auth_hash.rb' - 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb' - - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/elastic/latest/issue_class_proxy.rb' - 'ee/lib/gitlab/code_owners/groups_loader.rb' - 'lib/api/deploy_keys.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 9403b13e1b5..4e3b17fe4c0 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -51,7 +51,6 @@ Style/StringConcatenation: - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/gitlab/elastic/search_results.rb' - 'ee/lib/gitlab/geo/git_ssh_proxy.rb' - 'ee/lib/omni_auth/strategies/kerberos.rb' diff --git a/.rubocop_todo/style/zero_length_predicate.yml b/.rubocop_todo/style/zero_length_predicate.yml index f518a5c6f2b..4d30c3e638d 100644 --- a/.rubocop_todo/style/zero_length_predicate.yml +++ b/.rubocop_todo/style/zero_length_predicate.yml @@ -1,6 +1,5 @@ --- # Cop supports --autocorrect. Style/ZeroLengthPredicate: - Details: grace period Exclude: - 'spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb' |