diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-09-20 14:18:08 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-09-20 14:18:08 +0300 |
| commit | 5afcbe03ead9ada87621888a31a62652b10a7e4f (patch) | |
| tree | 9918b67a0d0f0bafa6542e839a8be37adf73102d /.rubocop_todo | |
| parent | c97c0201564848c1f53226fe19d71fdcc472f7d0 (diff) | |
Add latest changes from gitlab-org/gitlab@16-4-stable-eev16.4.0-rc42
Diffstat (limited to '.rubocop_todo')
50 files changed, 257 insertions, 687 deletions
diff --git a/.rubocop_todo/capybara/testid_finders.yml b/.rubocop_todo/capybara/testid_finders.yml new file mode 100644 index 00000000000..a1e0c7f642e --- /dev/null +++ b/.rubocop_todo/capybara/testid_finders.yml @@ -0,0 +1,249 @@ +--- +Capybara/TestidFinders: + Exclude: + - 'ee/spec/features/admin/admin_dev_ops_reports_spec.rb' + - 'ee/spec/features/admin/admin_merge_requests_approvals_spec.rb' + - 'ee/spec/features/admin/admin_sends_notification_spec.rb' + - 'ee/spec/features/admin/admin_settings_spec.rb' + - 'ee/spec/features/admin/geo/admin_geo_projects_spec.rb' + - 'ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb' + - 'ee/spec/features/admin/subscriptions/admin_views_subscription_spec.rb' + - 'ee/spec/features/billings/billing_plans_spec.rb' + - 'ee/spec/features/boards/boards_licensed_features_spec.rb' + - 'ee/spec/features/boards/boards_spec.rb' + - 'ee/spec/features/boards/group_boards/board_deletion_spec.rb' + - 'ee/spec/features/boards/new_issue_spec.rb' + - 'ee/spec/features/boards/scoped_issue_board_spec.rb' + - 'ee/spec/features/boards/sidebar_spec.rb' + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_drag_drop_spec.rb' + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_labels_spec.rb' + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_spec.rb' + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_spec.rb' + - 'ee/spec/features/boards/user_adds_lists_to_board_spec.rb' + - 'ee/spec/features/ci/ci_catalog_spec.rb' + - 'ee/spec/features/ci/ci_minutes_spec.rb' + - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' + - 'ee/spec/features/epic_boards/epic_boards_spec.rb' + - 'ee/spec/features/epics/epic_labels_spec.rb' + - 'ee/spec/features/epics/epic_related_epics_spec.rb' + - 'ee/spec/features/epics/epic_show_spec.rb' + - 'ee/spec/features/epics/update_epic_spec.rb' + - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb' + - 'ee/spec/features/groups/analytics/ci_cd_analytics_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb' + - 'ee/spec/features/groups/contribution_analytics_spec.rb' + - 'ee/spec/features/groups/group_roadmap_spec.rb' + - 'ee/spec/features/groups/group_settings_spec.rb' + - 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb' + - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' + - 'ee/spec/features/groups/settings/user_configures_analytics_dashboards_spec.rb' + - 'ee/spec/features/groups/settings/user_configures_insights_spec.rb' + - 'ee/spec/features/groups/settings/user_configures_vsd_aggregation_spec.rb' + - 'ee/spec/features/groups/show_spec.rb' + - 'ee/spec/features/groups/usage_quotas/pipelines_tab_spec.rb' + - 'ee/spec/features/groups/usage_quotas/seats_tab_spec.rb' + - 'ee/spec/features/incidents/incident_details_spec.rb' + - 'ee/spec/features/incidents/user_uploads_metric_images_spec.rb' + - 'ee/spec/features/issues/blocking_issues_spec.rb' + - 'ee/spec/features/issues/epic_in_issue_sidebar_spec.rb' + - 'ee/spec/features/issues/issue_sidebar_spec.rb' + - 'ee/spec/features/merge_request/draft_comments_spec.rb' + - 'ee/spec/features/merge_request/user_merges_immediately_spec.rb' + - 'ee/spec/features/merge_request/user_sees_approval_widget_spec.rb' + - 'ee/spec/features/merge_request/user_sees_status_checks_widget_spec.rb' + - 'ee/spec/features/merge_request/user_sets_approval_rules_spec.rb' + - 'ee/spec/features/merge_request/user_sets_approvers_spec.rb' + - 'ee/spec/features/merge_request/user_views_blocked_merge_request_spec.rb' + - 'ee/spec/features/merge_trains/user_adds_to_merge_train_when_pipeline_succeeds_spec.rb' + - 'ee/spec/features/profiles/usage_quotas_spec.rb' + - 'ee/spec/features/projects/analytics/visualization_designer_spec.rb' + - 'ee/spec/features/projects/audit_events_spec.rb' + - 'ee/spec/features/projects/issues/user_creates_issue_spec.rb' + - 'ee/spec/features/projects/jobs/blocked_deployment_job_page_spec.rb' + - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' + - 'ee/spec/features/projects/product_analytics/dashboards_shared_examples.rb' + - 'ee/spec/features/projects/security/vulnerability_report_spec.rb' + - 'ee/spec/features/projects/settings/analytics/user_configures_analytics_custom_dashboards_spec.rb' + - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' + - 'ee/spec/features/projects/settings/merge_requests_settings_spec.rb' + - 'ee/spec/features/projects/settings/pipeline_subscriptions_spec.rb' + - 'ee/spec/features/projects/settings/protected_environments_spec.rb' + - 'ee/spec/features/projects/work_items/okr_spec.rb' + - 'ee/spec/features/protected_branches_spec.rb' + - 'ee/spec/features/registrations/combined_registration_spec.rb' + - 'ee/spec/features/registrations/identity_verification_spec.rb' + - 'ee/spec/features/remote_development/workspaces_dropdown_group_spec.rb' + - 'ee/spec/features/remote_development/workspaces_spec.rb' + - 'ee/spec/features/search/elastic/group_search_spec.rb' + - 'ee/spec/features/search/zoekt/search_spec.rb' + - 'ee/spec/features/tanuki_bot_chat_spec.rb' + - 'ee/spec/features/trials/saas/creation_with_multiple_existing_namespace_flow_spec.rb' + - 'ee/spec/features/trials/show_trial_banner_spec.rb' + - 'spec/features/admin/admin_deploy_keys_spec.rb' + - 'spec/features/admin/admin_dev_ops_reports_spec.rb' + - 'spec/features/admin/admin_groups_spec.rb' + - 'spec/features/admin/admin_projects_spec.rb' + - 'spec/features/admin/admin_runners_spec.rb' + - 'spec/features/admin/admin_settings_spec.rb' + - 'spec/features/admin/admin_uses_repository_checks_spec.rb' + - 'spec/features/admin/broadcast_messages_spec.rb' + - 'spec/features/admin/users/user_spec.rb' + - 'spec/features/admin/users/users_spec.rb' + - 'spec/features/alert_management/alert_details_spec.rb' + - 'spec/features/boards/board_filters_spec.rb' + - 'spec/features/boards/boards_spec.rb' + - 'spec/features/boards/issue_ordering_spec.rb' + - 'spec/features/boards/new_issue_spec.rb' + - 'spec/features/boards/sidebar_assignee_spec.rb' + - 'spec/features/broadcast_messages_spec.rb' + - 'spec/features/callouts/registration_enabled_spec.rb' + - 'spec/features/clusters/create_agent_spec.rb' + - 'spec/features/commits_spec.rb' + - 'spec/features/dashboard/group_spec.rb' + - 'spec/features/dashboard/issues_spec.rb' + - 'spec/features/dashboard/merge_requests_spec.rb' + - 'spec/features/dashboard/milestones_spec.rb' + - 'spec/features/dashboard/projects_spec.rb' + - 'spec/features/dashboard/todos/todos_spec.rb' + - 'spec/features/groups/board_sidebar_spec.rb' + - 'spec/features/groups/board_spec.rb' + - 'spec/features/groups/clusters/user_spec.rb' + - 'spec/features/groups/dependency_proxy_spec.rb' + - 'spec/features/groups/group_settings_spec.rb' + - 'spec/features/groups/members/leave_group_spec.rb' + - 'spec/features/groups/members/manage_groups_spec.rb' + - 'spec/features/groups/members/master_adds_member_with_expiration_date_spec.rb' + - 'spec/features/groups/members/search_members_spec.rb' + - 'spec/features/groups/members/sort_members_spec.rb' + - 'spec/features/groups/members/tabs_spec.rb' + - 'spec/features/groups/merge_requests_spec.rb' + - 'spec/features/groups/milestone_spec.rb' + - 'spec/features/groups/packages_spec.rb' + - 'spec/features/groups/settings/ci_cd_spec.rb' + - 'spec/features/groups/settings/packages_and_registries_spec.rb' + - 'spec/features/groups/show_spec.rb' + - 'spec/features/groups_spec.rb' + - 'spec/features/incidents/incident_details_spec.rb' + - 'spec/features/incidents/incident_timeline_events_spec.rb' + - 'spec/features/issuables/shortcuts_issuable_spec.rb' + - 'spec/features/issues/form_spec.rb' + - 'spec/features/issues/incident_issue_spec.rb' + - 'spec/features/issues/issue_detail_spec.rb' + - 'spec/features/issues/issue_sidebar_spec.rb' + - 'spec/features/issues/issue_state_spec.rb' + - 'spec/features/issues/user_creates_issue_spec.rb' + - 'spec/features/issues/user_edits_issue_spec.rb' + - 'spec/features/issues/user_resets_their_incoming_email_token_spec.rb' + - 'spec/features/issues/user_sees_live_update_spec.rb' + - 'spec/features/issues/user_sees_sidebar_updates_in_realtime_spec.rb' + - 'spec/features/issues/user_toggles_subscription_spec.rb' + - 'spec/features/labels_hierarchy_spec.rb' + - 'spec/features/merge_request/merge_request_discussion_lock_spec.rb' + - 'spec/features/merge_request/user_accepts_merge_request_spec.rb' + - 'spec/features/merge_request/user_assigns_themselves_spec.rb' + - 'spec/features/merge_request/user_comments_on_diff_spec.rb' + - 'spec/features/merge_request/user_comments_on_whitespace_hidden_diff_spec.rb' + - 'spec/features/merge_request/user_creates_mr_spec.rb' + - 'spec/features/merge_request/user_customizes_merge_commit_message_spec.rb' + - 'spec/features/merge_request/user_edits_mr_spec.rb' + - 'spec/features/merge_request/user_expands_diff_spec.rb' + - 'spec/features/merge_request/user_interacts_with_batched_mr_diffs_spec.rb' + - 'spec/features/merge_request/user_manages_subscription_spec.rb' + - 'spec/features/merge_request/user_merges_immediately_spec.rb' + - 'spec/features/merge_request/user_posts_notes_spec.rb' + - 'spec/features/merge_request/user_resolves_conflicts_spec.rb' + - 'spec/features/merge_request/user_reverts_merge_request_spec.rb' + - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' + - 'spec/features/merge_request/user_sees_pipelines_spec.rb' + - 'spec/features/merge_request/user_sees_suggest_pipeline_spec.rb' + - 'spec/features/merge_request/user_sees_versions_spec.rb' + - 'spec/features/merge_request/user_squashes_merge_request_spec.rb' + - 'spec/features/merge_request/user_toggles_whitespace_changes_spec.rb' + - 'spec/features/merge_request/user_views_open_merge_request_spec.rb' + - 'spec/features/milestone_spec.rb' + - 'spec/features/nav/new_nav_callout_spec.rb' + - 'spec/features/nav/new_nav_toggle_spec.rb' + - 'spec/features/nav/pinned_nav_items_spec.rb' + - 'spec/features/nav/top_nav_responsive_spec.rb' + - 'spec/features/nav/top_nav_spec.rb' + - 'spec/features/populate_new_pipeline_vars_with_params_spec.rb' + - 'spec/features/profile_spec.rb' + - 'spec/features/profiles/account_spec.rb' + - 'spec/features/profiles/keys_spec.rb' + - 'spec/features/profiles/oauth_applications_spec.rb' + - 'spec/features/profiles/password_spec.rb' + - 'spec/features/profiles/personal_access_tokens_spec.rb' + - 'spec/features/profiles/user_creates_comment_template_spec.rb' + - 'spec/features/profiles/user_deletes_comment_template_spec.rb' + - 'spec/features/profiles/user_edit_profile_spec.rb' + - 'spec/features/profiles/user_updates_comment_template_spec.rb' + - 'spec/features/project_group_variables_spec.rb' + - 'spec/features/project_variables_spec.rb' + - 'spec/features/projects/blobs/blame_spec.rb' + - 'spec/features/projects/branches/user_deletes_branch_spec.rb' + - 'spec/features/projects/branches_spec.rb' + - 'spec/features/projects/ci/editor_spec.rb' + - 'spec/features/projects/ci/lint_spec.rb' + - 'spec/features/projects/clusters/gcp_spec.rb' + - 'spec/features/projects/clusters/user_spec.rb' + - 'spec/features/projects/commit/cherry_pick_spec.rb' + - 'spec/features/projects/commit/user_sees_pipelines_tab_spec.rb' + - 'spec/features/projects/commits/user_browses_commits_spec.rb' + - 'spec/features/projects/compare_spec.rb' + - 'spec/features/projects/environments/environment_spec.rb' + - 'spec/features/projects/environments/environments_spec.rb' + - 'spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' + - 'spec/features/projects/features_visibility_spec.rb' + - 'spec/features/projects/fork_spec.rb' + - 'spec/features/projects/integrations/user_activates_jira_spec.rb' + - 'spec/features/projects/issues/design_management/user_views_designs_with_svg_xss_spec.rb' + - 'spec/features/projects/jobs/permissions_spec.rb' + - 'spec/features/projects/jobs/user_browses_job_spec.rb' + - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' + - 'spec/features/projects/jobs/user_triggers_manual_job_with_variables_spec.rb' + - 'spec/features/projects/jobs_spec.rb' + - 'spec/features/projects/members/group_member_cannot_leave_group_project_spec.rb' + - 'spec/features/projects/members/groups_with_access_list_spec.rb' + - 'spec/features/projects/members/master_adds_member_with_expiration_date_spec.rb' + - 'spec/features/projects/members/sorting_spec.rb' + - 'spec/features/projects/packages_spec.rb' + - 'spec/features/projects/pipeline_schedules_spec.rb' + - 'spec/features/projects/pipelines/pipeline_spec.rb' + - 'spec/features/projects/pipelines/pipelines_spec.rb' + - 'spec/features/projects/releases/user_creates_release_spec.rb' + - 'spec/features/projects/releases/user_views_releases_spec.rb' + - 'spec/features/projects/settings/merge_requests_settings_spec.rb' + - 'spec/features/projects/settings/monitor_settings_spec.rb' + - 'spec/features/projects/settings/project_settings_spec.rb' + - 'spec/features/projects/settings/registry_settings_cleanup_tags_spec.rb' + - 'spec/features/projects/settings/registry_settings_spec.rb' + - 'spec/features/projects/settings/repository_settings_spec.rb' + - 'spec/features/projects/settings/secure_files_spec.rb' + - 'spec/features/projects/settings/service_desk_setting_spec.rb' + - 'spec/features/projects/settings/slack_application_spec.rb' + - 'spec/features/projects/settings/user_manages_merge_requests_settings_spec.rb' + - 'spec/features/projects/settings/user_transfers_a_project_spec.rb' + - 'spec/features/projects/show/user_sees_collaboration_links_spec.rb' + - 'spec/features/projects/sub_group_issuables_spec.rb' + - 'spec/features/projects/terraform_spec.rb' + - 'spec/features/projects/tree/create_directory_spec.rb' + - 'spec/features/projects/tree/create_file_spec.rb' + - 'spec/features/projects/user_uses_shortcuts_spec.rb' + - 'spec/features/projects/work_items/work_item_children_spec.rb' + - 'spec/features/projects/work_items/work_item_spec.rb' + - 'spec/features/protected_branches_spec.rb' + - 'spec/features/runners_spec.rb' + - 'spec/features/search/user_searches_for_code_spec.rb' + - 'spec/features/search/user_searches_for_issues_spec.rb' + - 'spec/features/search/user_searches_for_merge_requests_spec.rb' + - 'spec/features/search/user_searches_for_milestones_spec.rb' + - 'spec/features/search/user_searches_for_wiki_pages_spec.rb' + - 'spec/features/search/user_uses_header_search_field_spec.rb' + - 'spec/features/search/user_uses_search_filters_spec.rb' + - 'spec/features/tags/developer_deletes_tag_spec.rb' + - 'spec/features/tags/maintainer_deletes_protected_tag_spec.rb' + - 'spec/features/triggers_spec.rb' + - 'spec/features/uploads/user_uploads_avatar_to_profile_spec.rb' + - 'spec/features/user_sees_revert_modal_spec.rb' diff --git a/.rubocop_todo/cop/experiments_test_coverage.yml b/.rubocop_todo/cop/experiments_test_coverage.yml index 1e347b2b466..07c47bc11a6 100644 --- a/.rubocop_todo/cop/experiments_test_coverage.yml +++ b/.rubocop_todo/cop/experiments_test_coverage.yml @@ -1,6 +1,5 @@ --- Cop/ExperimentsTestCoverage: - Details: grace period Exclude: - 'app/controllers/groups/boards_controller.rb' - 'app/controllers/projects/boards_controller.rb' diff --git a/.rubocop_todo/cop/ignored_columns.yml b/.rubocop_todo/cop/ignored_columns.yml index eaba218d385..a791fcd0d6d 100644 --- a/.rubocop_todo/cop/ignored_columns.yml +++ b/.rubocop_todo/cop/ignored_columns.yml @@ -1,6 +1,5 @@ --- Cop/IgnoredColumns: - Details: grace period Exclude: - 'app/models/loose_foreign_keys/deleted_record.rb' - 'ee/lib/ee/gitlab/background_migration/create_vulnerability_links.rb' diff --git a/.rubocop_todo/factory_bot/create_list.yml b/.rubocop_todo/factory_bot/create_list.yml index 289be6ef20b..9f6d3b19735 100644 --- a/.rubocop_todo/factory_bot/create_list.yml +++ b/.rubocop_todo/factory_bot/create_list.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. FactoryBot/CreateList: - Details: grace period Exclude: - 'ee/spec/controllers/ee/search_controller_spec.rb' - 'ee/spec/controllers/projects/licenses_controller_spec.rb' diff --git a/.rubocop_todo/gitlab/doc_url.yml b/.rubocop_todo/gitlab/doc_url.yml index 13537a142a1..ba9d066f94c 100644 --- a/.rubocop_todo/gitlab/doc_url.yml +++ b/.rubocop_todo/gitlab/doc_url.yml @@ -31,7 +31,7 @@ Gitlab/DocUrl: - 'lib/gitlab/ci/config/entry/processable.rb' - 'lib/gitlab/config_checker/external_database_checker.rb' - 'lib/gitlab/config_checker/puma_rugged_checker.rb' - - 'lib/gitlab/database.rb' + - 'lib/gitlab/database_warnings.rb' - 'lib/gitlab/database/migration_helpers/automatic_lock_writes_on_tables.rb' - 'lib/gitlab/database/migration_helpers/v2.rb' - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb' diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index a0c71dec923..302bf8d17c4 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -92,8 +92,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/views/compliance_management/compliance_framework/_project_settings.html.haml.rb' - 'ee/app/views/groups/epics/index.html.haml.rb' - 'ee/app/views/product_analytics/_project_settings.html.haml.rb' - - 'ee/app/views/projects/_merge_request_settings.html.haml.rb' - - 'ee/app/views/projects/_merge_request_settings_description_text.html.haml.rb' - 'ee/app/views/projects/_remove.html.haml.rb' - 'ee/app/views/projects/audit_events/index.html.haml.rb' - 'ee/app/views/projects/blob/_header_file_locks.html.haml.rb' @@ -106,6 +104,8 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/views/projects/settings/ci_cd/_auto_rollback.html.haml.rb' - 'ee/app/views/projects/settings/ci_cd/_pipeline_subscriptions.html.haml.rb' - 'ee/app/views/projects/settings/merge_requests/_merge_request_approvals_settings.html.haml.rb' + - 'ee/app/views/projects/settings/merge_requests/_merge_request_settings.html.haml.rb' + - 'ee/app/views/projects/settings/merge_requests/_merge_request_settings_description_text.html.haml.rb' - 'ee/app/views/projects/settings/operations/_status_page.html.haml.rb' - 'ee/app/views/projects/settings/repository/_protected_branches.html.haml.rb' - 'ee/app/views/protected_branches/ee/_code_owner_approval_form.html.haml.rb' @@ -130,9 +130,7 @@ Gitlab/FeatureAvailableUsage: - 'ee/lib/gitlab/ci/project_config/compliance.rb' - 'ee/lib/gitlab/code_owners.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - - 'ee/lib/incident_management/incident_sla.rb' - 'ee/spec/models/ee/project_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' - - 'ee/spec/models/license_spec.rb' - 'lib/api/helpers/related_resources_helpers.rb' - 'spec/models/concerns/featurable_spec.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 4b000876d0e..4511497315b 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -989,8 +989,6 @@ Gitlab/NamespacedClass: - 'ee/app/serializers/epic_note_serializer.rb' - 'ee/app/serializers/epic_serializer.rb' - 'ee/app/serializers/file_lock_entity.rb' - - 'ee/app/serializers/geo_design_registry_entity.rb' - - 'ee/app/serializers/geo_design_registry_serializer.rb' - 'ee/app/serializers/geo_node_serializer.rb' - 'ee/app/serializers/geo_node_status_serializer.rb' - 'ee/app/serializers/geo_project_registry_entity.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index cd58daeeab4..703c80c7667 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Gitlab/StrongMemoizeAttr: - Details: grace period Exclude: - 'app/components/pajamas/avatar_component.rb' - 'app/controllers/application_controller.rb' diff --git a/.rubocop_todo/graphql/resource_not_available_error.yml b/.rubocop_todo/graphql/resource_not_available_error.yml index 316cd4a99cb..c52cdfff6b4 100644 --- a/.rubocop_todo/graphql/resource_not_available_error.yml +++ b/.rubocop_todo/graphql/resource_not_available_error.yml @@ -35,7 +35,6 @@ Graphql/ResourceNotAvailableError: - 'ee/app/graphql/mutations/ai/action.rb' - 'ee/app/graphql/mutations/audit_events/instance_external_audit_event_destinations/base.rb' - 'ee/app/graphql/mutations/ci/ai/generate_config.rb' - - 'ee/app/graphql/mutations/geo/registries/update.rb' - 'ee/app/graphql/mutations/issues/set_escalation_policy.rb' - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/incident_management/oncall_shifts_resolver.rb' diff --git a/.rubocop_todo/internal_affairs/use_restrict_on_send.yml b/.rubocop_todo/internal_affairs/use_restrict_on_send.yml index def67cd71b1..ee5ad00d14e 100644 --- a/.rubocop_todo/internal_affairs/use_restrict_on_send.yml +++ b/.rubocop_todo/internal_affairs/use_restrict_on_send.yml @@ -1,6 +1,5 @@ --- InternalAffairs/UseRestrictOnSend: - Details: grace period Exclude: - 'rubocop/cop/gitlab/feature_available_usage.rb' - 'rubocop/cop/migration/add_concurrent_foreign_key.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 35923d68b93..c7b47be48fa 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -491,22 +491,6 @@ Layout/ArgumentAlignment: - 'app/graphql/types/work_items/widgets/start_and_due_date_update_input_type.rb' - 'app/graphql/types/x509_certificate_type.rb' - 'app/graphql/types/x509_issuer_type.rb' - - 'app/services/compare_service.rb' - - 'app/services/concerns/rate_limited_service.rb' - - 'app/services/design_management/copy_design_collection/copy_service.rb' - - 'app/services/design_management/delete_designs_service.rb' - - 'app/services/design_management/runs_design_actions.rb' - - 'app/services/design_management/save_designs_service.rb' - - 'app/services/error_tracking/base_service.rb' - - 'app/services/event_create_service.rb' - - 'app/services/files/update_service.rb' - - 'app/services/google_cloud/create_cloudsql_instance_service.rb' - - 'app/services/google_cloud/fetch_google_ip_list_service.rb' - - 'app/services/issuable_base_service.rb' - - 'app/services/issues/close_service.rb' - - 'app/services/issues/create_service.rb' - - 'app/services/issues/move_service.rb' - - 'app/services/issues/referenced_merge_requests_service.rb' - 'app/services/lfs/lock_file_service.rb' - 'app/services/markdown_content_rewriter_service.rb' - 'app/services/members/base_service.rb' @@ -529,19 +513,6 @@ Layout/ArgumentAlignment: - 'app/services/security/ci_configuration/dependency_scanning_create_service.rb' - 'app/services/security/ci_configuration/sast_iac_create_service.rb' - 'app/services/security/ci_configuration/secret_detection_create_service.rb' - - 'app/services/service_response.rb' - - 'app/services/spam/akismet_service.rb' - - 'app/services/spam/spam_action_service.rb' - - 'app/services/spam/spam_verdict_service.rb' - - 'app/services/submodules/update_service.rb' - - 'app/services/suggestions/create_service.rb' - - 'app/services/users/activity_service.rb' - - 'app/services/users/build_service.rb' - - 'app/services/users/destroy_service.rb' - - 'app/services/users/migrate_records_to_ghost_user_in_batches_service.rb' - - 'app/services/users/refresh_authorized_projects_service.rb' - - 'app/services/webauthn/authenticate_service.rb' - - 'app/services/work_items/create_service.rb' - 'app/validators/feature_flag_user_xids_validator.rb' - 'config/application.rb' - 'config/initializers/hashie_mash_permitted_patch.rb' @@ -1199,35 +1170,6 @@ Layout/ArgumentAlignment: - 'ee/spec/requests/groups/two_factor_auths_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/requests/users/identity_verification_controller_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/aggregator_service_spec.rb' - - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service_spec.rb' - - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/streaming/event_type_filters/create_service_spec.rb' - - 'ee/spec/services/audit_events/streaming/event_type_filters/destroy_service_spec.rb' - - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - - 'ee/spec/services/boards/lists/update_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/move_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/create_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/max_limits_spec.rb' - - 'ee/spec/services/ee/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/update_reviewers_service_spec.rb' - - 'ee/spec/services/ee/notification_service_spec.rb' - - 'ee/spec/services/ee/users/migrate_records_to_ghost_user_service_spec.rb' - - 'ee/spec/services/ee/vulnerability_feedback_module/update_service_spec.rb' - - 'ee/spec/services/elastic/process_bookkeeping_service_spec.rb' - - 'ee/spec/services/epics/issue_promote_service_spec.rb' - - 'ee/spec/services/geo/blob_upload_service_spec.rb' - - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/hashed_storage_attachments_migration_service_spec.rb' - - 'ee/spec/services/geo/registry_consistency_service_spec.rb' - - 'ee/spec/services/geo/replication_toggle_request_service_spec.rb' - - 'ee/spec/services/geo/repository_sync_service_spec.rb' - - 'ee/spec/services/geo/wiki_sync_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/reconciliations/check_seat_usage_alerts_eligibility_service_spec.rb' - 'ee/spec/services/groups/compliance_report_csv_service_spec.rb' - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb' @@ -1879,43 +1821,6 @@ Layout/ArgumentAlignment: - 'spec/rubocop/cop/rspec/env_mocking_spec.rb' - 'spec/rubocop/cop/style/regexp_literal_mixed_preserve_spec.rb' - 'spec/rubocop/formatter/graceful_formatter_spec.rb' - - 'spec/services/design_management/save_designs_service_spec.rb' - - 'spec/services/discussions/resolve_service_spec.rb' - - 'spec/services/draft_notes/publish_service_spec.rb' - - 'spec/services/environments/stop_service_spec.rb' - - 'spec/services/environments/stop_stale_service_spec.rb' - - 'spec/services/files/delete_service_spec.rb' - - 'spec/services/files/update_service_spec.rb' - - 'spec/services/git/branch_push_service_spec.rb' - - 'spec/services/google_cloud/create_cloudsql_instance_service_spec.rb' - - 'spec/services/google_cloud/fetch_google_ip_list_service_spec.rb' - - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' - - 'spec/services/google_cloud/get_cloudsql_instances_service_spec.rb' - - 'spec/services/groups/destroy_service_spec.rb' - - 'spec/services/groups/group_links/create_service_spec.rb' - - 'spec/services/import_export_clean_up_service_spec.rb' - - 'spec/services/issuable/process_assignees_spec.rb' - - 'spec/services/issue_links/list_service_spec.rb' - - 'spec/services/issues/create_service_spec.rb' - - 'spec/services/issues/export_csv_service_spec.rb' - - 'spec/services/issues/move_service_spec.rb' - - 'spec/services/issues/resolve_discussions_spec.rb' - - 'spec/services/issues/update_service_spec.rb' - - 'spec/services/loose_foreign_keys/batch_cleaner_service_spec.rb' - - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' - - 'spec/services/note_summary_spec.rb' - - 'spec/services/notification_service_spec.rb' - - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' - - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - - 'spec/services/preview_markdown_service_spec.rb' - - 'spec/services/protected_branches/api_service_spec.rb' - - 'spec/services/push_event_payload_service_spec.rb' - - 'spec/services/quick_actions/interpret_service_spec.rb' - - 'spec/services/releases/destroy_service_spec.rb' - - 'spec/services/resource_access_tokens/revoke_service_spec.rb' - - 'spec/services/resource_events/merge_into_notes_service_spec.rb' - - 'spec/services/security/ci_configuration/dependency_scanning_create_service_spec.rb' - - 'spec/services/security/merge_reports_service_spec.rb' - 'spec/sidekiq/cron/job_gem_dependency_spec.rb' - 'spec/support/shared_examples/initializers/uses_gitlab_url_blocker_shared_examples.rb' - 'spec/support/shared_examples/integrations/integration_settings_form.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 698247e419c..35cd5f9135d 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -256,7 +256,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/lib/ee/gitlab/ci/parsers/security/validators/schema_validator.rb' - 'ee/lib/ee/gitlab/hook_data/group_member_builder.rb' - 'ee/lib/ee/gitlab/hook_data/issue_builder.rb' - - 'ee/lib/ee/gitlab/hook_data/user_builder.rb' - 'ee/lib/ee/gitlab/scim/base_deprovisioning_service.rb' - 'ee/lib/ee/gitlab/scim/base_provisioning_service.rb' - 'ee/lib/ee/gitlab/scim/provisioning_service.rb' @@ -290,7 +289,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/features/projects/settings/merge_request_approvals_settings_spec.rb' - 'ee/spec/features/projects/settings/merge_requests_settings_spec.rb' - 'ee/spec/finders/auth/group_saml_identity_finder_spec.rb' - - 'ee/spec/finders/geo/design_registry_finder_spec.rb' - 'ee/spec/finders/geo/project_registry_status_finder_spec.rb' - 'ee/spec/frontend/fixtures/analytics/charts.rb' - 'ee/spec/frontend/fixtures/analytics/metrics.rb' @@ -318,7 +316,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/graphql/mutations/vulnerabilities/revert_to_detected_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' - - 'ee/spec/helpers/ee/invite_members_helper_spec.rb' - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/saml_providers_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' @@ -332,7 +329,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/group_member_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb' - - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/snippet_search_results_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb' diff --git a/.rubocop_todo/layout/extra_spacing.yml b/.rubocop_todo/layout/extra_spacing.yml deleted file mode 100644 index 6da17195834..00000000000 --- a/.rubocop_todo/layout/extra_spacing.yml +++ /dev/null @@ -1,8 +0,0 @@ ---- -# Cop supports --autocorrect. -Layout/ExtraSpacing: - Details: grace period - Exclude: - - 'ee/spec/requests/api/debian_project_packages_spec.rb' - - 'spec/serializers/admin/abuse_report_details_entity_spec.rb' - - 'spec/services/bulk_imports/create_service_spec.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 5f586cc6206..893a6d2242b 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -229,7 +229,6 @@ Layout/FirstHashElementIndentation: - 'spec/requests/api/ml/mlflow_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/task_completion_status_spec.rb' - - 'spec/requests/groups/email_campaigns_controller_spec.rb' - 'spec/requests/pwa_controller_spec.rb' - 'spec/rubocop/cop/usage_data/distinct_count_by_large_foreign_key_spec.rb' - 'spec/rubocop/cop/usage_data/histogram_with_large_table_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 53954249ed4..0253613849e 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -125,6 +125,7 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_deployment_approvals_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environments_required_approvals_average_metric_spec.rb' + - 'ee/spec/lib/remote_development/workspaces/reconcile/input/actual_state_calculator_spec.rb' - 'ee/spec/mailers/ee/emails/identity_verification_spec.rb' - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' @@ -141,6 +142,7 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/spec/services/geo/container_repository_sync_spec.rb' - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'ee/spec/services/users/abuse/git_abuse/application_throttle_service_spec.rb' + - 'ee/spec/support/shared_contexts/remote_development/remote_development_shared_contexts.rb' - 'ee/spec/support/shared_examples/finders/geo/framework_registry_finder_shared_examples.rb' - 'ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb' - 'ee/spec/support/shared_examples/models/license_shared_examples.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 162afb96a09..9fd3d47d8f0 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -34,7 +34,6 @@ Layout/LineLength: - 'app/controllers/dashboard/todos_controller.rb' - 'app/controllers/explore/projects_controller.rb' - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' - - 'app/controllers/groups/email_campaigns_controller.rb' - 'app/controllers/groups/group_members_controller.rb' - 'app/controllers/groups/settings/applications_controller.rb' - 'app/controllers/groups/settings/ci_cd_controller.rb' @@ -346,7 +345,6 @@ Layout/LineLength: - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/bugzilla.rb' - - 'app/models/integrations/campfire.rb' - 'app/models/integrations/chat_message/deployment_message.rb' - 'app/models/integrations/chat_message/merge_message.rb' - 'app/models/integrations/chat_message/note_message.rb' @@ -690,7 +688,6 @@ Layout/LineLength: - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' - 'config/initializers/pages_storage_check.rb' - 'config/initializers/rails_host_authorization.rb' - - 'config/initializers/session_store.rb' - 'config/initializers/validate_database_config.rb' - 'config/initializers/validate_puma.rb' - 'config/initializers/zz_metrics.rb' @@ -714,7 +711,6 @@ Layout/LineLength: - 'danger/z_metadata/Dangerfile' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/licenses_controller.rb' - 'ee/app/controllers/concerns/audit_events/date_range.rb' - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' @@ -1305,7 +1301,6 @@ Layout/LineLength: - 'ee/lib/tasks/gitlab/seed/metrics.rake' - 'ee/lib/world.rb' - 'ee/spec/controllers/admin/elasticsearch_controller_spec.rb' - - 'ee/spec/controllers/admin/geo/projects_controller_spec.rb' - 'ee/spec/controllers/admin/impersonations_controller_spec.rb' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - 'ee/spec/controllers/admin/projects_controller_spec.rb' @@ -4501,7 +4496,6 @@ Layout/LineLength: - 'spec/requests/api/v3/github_spec.rb' - 'spec/requests/dashboard_controller_spec.rb' - 'spec/requests/git_http_spec.rb' - - 'spec/requests/groups/email_campaigns_controller_spec.rb' - 'spec/requests/groups/milestones_controller_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' @@ -4724,7 +4718,6 @@ Layout/LineLength: - 'spec/services/metrics/users_starred_dashboards/delete_service_spec.rb' - 'spec/services/milestones/transfer_service_spec.rb' - 'spec/services/namespace_settings/update_service_spec.rb' - - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'spec/services/notes/build_service_spec.rb' - 'spec/services/notes/copy_service_spec.rb' - 'spec/services/notes/create_service_spec.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 01189989eec..54ed188fd26 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -79,7 +79,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/packages/maven/metadatum.rb' - 'app/models/packages/package.rb' - 'app/models/packages/tag.rb' - - 'app/models/pages_deployment.rb' - 'app/models/personal_access_token.rb' - 'app/models/project.rb' - 'app/models/project_daily_statistic.rb' diff --git a/.rubocop_todo/lint/assignment_in_condition.yml b/.rubocop_todo/lint/assignment_in_condition.yml index 0d893f4c1a0..69470c7d5f0 100644 --- a/.rubocop_todo/lint/assignment_in_condition.yml +++ b/.rubocop_todo/lint/assignment_in_condition.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/AssignmentInCondition: - Details: grace period Exclude: - 'app/controllers/concerns/uploads_actions.rb' - 'app/controllers/concerns/verifies_with_email.rb' @@ -88,7 +87,6 @@ Lint/AssignmentInCondition: - 'app/workers/concerns/gitlab/bitbucket_server_import/stage_methods.rb' - 'app/workers/concerns/gitlab/github_import/object_importer.rb' - 'app/workers/concerns/gitlab/github_import/stage_methods.rb' - - 'app/workers/concerns/gitlab/notify_upon_death.rb' - 'app/workers/deployments/hooks_worker.rb' - 'app/workers/deployments/link_merge_request_worker.rb' - 'app/workers/gitlab/github_gists_import/import_gist_worker.rb' @@ -138,7 +136,7 @@ Lint/AssignmentInCondition: - 'ee/lib/ee/gitlab/repo_path.rb' - 'ee/lib/gem_extensions/elasticsearch/model/indexing/instance_methods.rb' - 'ee/lib/gitlab/group_plans_preloader.rb' - - 'ee/lib/gitlab/llm/content_parser.rb' + - 'ee/lib/gitlab/llm/embeddings/utils/base_content_parser.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb' - 'ee/lib/system_check/geo/authorized_keys_check.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 7a07242ab29..38ea0ea12e6 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -123,7 +123,6 @@ Lint/RedundantCopDisableDirective: - 'ee/app/services/ee/search_service.rb' - 'ee/app/services/security/token_revocation_service.rb' - 'ee/app/workers/ee/issuable_export_csv_worker.rb' - - 'ee/app/workers/ee/namespaces/in_product_marketing_emails_worker.rb' - 'ee/app/workers/geo/design_repository_shard_sync_worker.rb' - 'ee/app/workers/geo/repository_shard_sync_worker.rb' - 'ee/app/workers/geo/repository_verification/secondary/shard_worker.rb' diff --git a/.rubocop_todo/lint/redundant_safe_navigation.yml b/.rubocop_todo/lint/redundant_safe_navigation.yml index 8c4b66313eb..2fda82208fe 100644 --- a/.rubocop_todo/lint/redundant_safe_navigation.yml +++ b/.rubocop_todo/lint/redundant_safe_navigation.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/RedundantSafeNavigation: - Details: grace period Exclude: - 'app/controllers/import/base_controller.rb' - 'app/graphql/resolvers/users_resolver.rb' diff --git a/.rubocop_todo/lint/redundant_string_coercion.yml b/.rubocop_todo/lint/redundant_string_coercion.yml index 8d9bb93395b..2663e0420b3 100644 --- a/.rubocop_todo/lint/redundant_string_coercion.yml +++ b/.rubocop_todo/lint/redundant_string_coercion.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Lint/RedundantStringCoercion: - Details: grace period Exclude: - 'ee/bin/geo_log_cursor' - 'ee/db/fixtures/development/31_devops_adoption.rb' diff --git a/.rubocop_todo/migration/avoid_finalize_background_migration.yml b/.rubocop_todo/migration/avoid_finalize_background_migration.yml index bde85ce3e48..89adc410f22 100644 --- a/.rubocop_todo/migration/avoid_finalize_background_migration.yml +++ b/.rubocop_todo/migration/avoid_finalize_background_migration.yml @@ -1,6 +1,5 @@ --- Migration/AvoidFinalizeBackgroundMigration: - Details: grace period Exclude: - 'db/post_migrate/20220502015011_clean_up_fix_merge_request_diff_commit_users.rb' - 'db/post_migrate/20220525131557_cleanup_backfill_integrations_enable_ssl_verification.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index 68129f910d1..fa60792bbdc 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -30,7 +30,6 @@ Naming/HeredocDelimiterNaming: - 'lib/feature/shared.rb' - 'lib/gitlab/cache/import/caching.rb' - 'lib/gitlab/conflict/file_collection.rb' - - 'lib/gitlab/database.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/database/migration_helpers/v2.rb' - 'lib/gitlab/exclusive_lease.rb' diff --git a/.rubocop_todo/performance/regexp_match.yml b/.rubocop_todo/performance/regexp_match.yml index 0248938c84b..b4a21bfe40a 100644 --- a/.rubocop_todo/performance/regexp_match.yml +++ b/.rubocop_todo/performance/regexp_match.yml @@ -1,7 +1,6 @@ --- # Cop supports --autocorrect. Performance/RegexpMatch: - Details: grace period Exclude: - 'config/initializers/wikicloth_redos_patch.rb' - 'ee/app/controllers/concerns/audit_events/enforces_valid_date_params.rb' diff --git a/.rubocop_todo/rails/output_safety.yml b/.rubocop_todo/rails/output_safety.yml index cc2f52a3ddc..85388e8a1da 100644 --- a/.rubocop_todo/rails/output_safety.yml +++ b/.rubocop_todo/rails/output_safety.yml @@ -1,6 +1,5 @@ --- Rails/OutputSafety: - Details: grace period Exclude: - 'app/controllers/concerns/confirm_email_warning.rb' - 'app/controllers/concerns/web_hooks/hook_actions.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index 00e8150585d..01dcb78bdce 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -5,13 +5,11 @@ Rails/TimeZone: - 'ee/lib/delay.rb' - 'ee/lib/gitlab/elastic/indexer.rb' - 'ee/lib/gitlab/geo/event_gap_tracking.rb' - - 'ee/lib/gitlab/geo/log_cursor/events/design_repository_updated_event.rb' - 'ee/lib/gitlab/geo/log_cursor/events/repository_updated_event.rb' - 'ee/lib/gitlab/geo/log_cursor/logger.rb' - 'ee/lib/gitlab/geo/oauth/login_state.rb' - 'ee/spec/lib/gitlab/geo/base_request_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/cache_invalidation_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_attachments_event_spec.rb' - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_migrated_event_spec.rb' diff --git a/.rubocop_todo/rspec/before_all.yml b/.rubocop_todo/rspec/before_all.yml index e7c57db9996..f1b7ac64bdd 100644 --- a/.rubocop_todo/rspec/before_all.yml +++ b/.rubocop_todo/rspec/before_all.yml @@ -1,6 +1,5 @@ --- # Cop supports --autocorrect. RSpec/BeforeAll: - Details: grace period Exclude: - 'ee/spec/support/shared_examples/finders/security/findings_finder_shared_examples.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index c74c0d93813..cc0781a337e 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -1,6 +1,5 @@ --- RSpec/BeforeAllRoleAssignment: - Details: grace period Exclude: - 'ee/spec/components/namespaces/free_user_cap/non_owner_notification_alert_component_spec.rb' - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb' @@ -1380,7 +1379,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/requests/api/wikis_spec.rb' - 'spec/requests/concerns/planning_hierarchy_spec.rb' - 'spec/requests/groups/deploy_tokens_controller_spec.rb' - - 'spec/requests/groups/email_campaigns_controller_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups/settings/applications_controller_spec.rb' - 'spec/requests/groups/usage_quotas_controller_spec.rb' @@ -1505,7 +1503,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/services/metrics/dashboard/system_dashboard_service_spec.rb' - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' - 'spec/services/metrics/dashboard/update_dashboard_service_spec.rb' - - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'spec/services/notes/build_service_spec.rb' - 'spec/services/notes/create_service_spec.rb' - 'spec/services/notes/quick_actions_service_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index ec3ac9ff220..9f6b07c397e 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -1,12 +1,10 @@ --- RSpec/ContextWording: - Details: grace period Exclude: - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - 'ee/spec/controllers/admin/audit_logs_controller_spec.rb' - 'ee/spec/controllers/admin/dev_ops_report_controller_spec.rb' - 'ee/spec/controllers/admin/emails_controller_spec.rb' - - 'ee/spec/controllers/admin/geo/projects_controller_spec.rb' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - 'ee/spec/controllers/admin/push_rules_controller_spec.rb' - 'ee/spec/controllers/admin/users_controller_spec.rb' @@ -63,7 +61,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/security/dashboard_controller_spec.rb' - 'ee/spec/controllers/security/vulnerabilities_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - - 'ee/spec/controllers/trial_registrations_controller_spec.rb' - 'ee/spec/controllers/users_controller_spec.rb' - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/elastic_integration/global_search_spec.rb' @@ -312,7 +309,6 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/gon_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/group_search_results_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/group_member_builder_spec.rb' - - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_saver_spec.rb' @@ -460,13 +456,11 @@ RSpec/ContextWording: - 'ee/spec/models/epic_issue_spec.rb' - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/geo/container_repository_registry_spec.rb' - - 'ee/spec/models/geo/design_registry_spec.rb' - 'ee/spec/models/geo/project_registry_spec.rb' - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - 'ee/spec/models/geo_node_spec.rb' - 'ee/spec/models/geo_node_status_spec.rb' - 'ee/spec/models/gitlab_subscription_spec.rb' - - 'ee/spec/models/gitlab_subscriptions/features_spec.rb' - 'ee/spec/models/group_member_spec.rb' - 'ee/spec/models/group_wiki_repository_spec.rb' - 'ee/spec/models/incident_management/escalation_rule_spec.rb' @@ -738,7 +732,6 @@ RSpec/ContextWording: - 'ee/spec/services/geo/repository_sync_service_spec.rb' - 'ee/spec/services/geo/repository_verification_reset_spec.rb' - 'ee/spec/services/geo/wiki_sync_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' - 'ee/spec/services/group_saml/group_managed_accounts/transfer_membership_service_spec.rb' @@ -2523,7 +2516,6 @@ RSpec/ContextWording: - 'spec/requests/projects/usage_quotas_spec.rb' - 'spec/requests/projects_controller_spec.rb' - 'spec/requests/rack_attack_global_spec.rb' - - 'spec/requests/sessions_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/git_http_routing_spec.rb' - 'spec/routing/group_routing_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index b0369d5180d..86f2a5abd41 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -28,7 +28,6 @@ RSpec/ExpectInHook: - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/gon_helper_spec.rb' - - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' @@ -69,7 +68,6 @@ RSpec/ExpectInHook: - 'ee/spec/services/geo/blob_download_service_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml index 640b0c7f400..009e60b5129 100644 --- a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml +++ b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml @@ -1,6 +1,5 @@ --- RSpec/FactoryBot/ExcessiveCreateList: - Details: grace period Exclude: - 'ee/spec/controllers/groups/hooks_controller_spec.rb' - 'ee/spec/features/search/elastic/global_search_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml b/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml index 732bfd246cf..696ada420c4 100644 --- a/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml +++ b/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml @@ -7,7 +7,6 @@ RSpec/FactoryBot/StrategyInCallback: - 'ee/spec/factories/description_version.rb' - 'ee/spec/factories/elastic/reindexing_tasks.rb' - 'ee/spec/factories/epic_issues.rb' - - 'ee/spec/factories/geo/design_registry.rb' - 'ee/spec/factories/geo_nodes.rb' - 'ee/spec/factories/groups.rb' - 'ee/spec/factories/merge_requests.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index 0d625f92c3f..4cc8ee1210c 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -11,7 +11,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' - 'ee/spec/controllers/projects/pipelines_controller_spec.rb' - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' - - 'ee/spec/controllers/projects_controller_spec.rb' - 'ee/spec/controllers/users_controller_spec.rb' - 'ee/spec/db/production/license_spec.rb' - 'ee/spec/elastic/migrate/20201105181100_apply_max_analyzed_offset_spec.rb' @@ -516,7 +515,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' - - 'ee/spec/helpers/trial_registrations/reassurances_helper_spec.rb' - 'ee/spec/helpers/users/identity_verification_helper_spec.rb' - 'ee/spec/initializers/1_settings_spec.rb' - 'ee/spec/initializers/database_config_spec.rb' @@ -660,8 +658,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/group_search_results_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/group_member_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb' - - 'ee/spec/lib/ee/gitlab/hook_data/user_builder_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/after_export_strategies/custom_template_export_import_strategy_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_saver_spec.rb' @@ -852,7 +848,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb' - 'ee/spec/lib/gitlab/import_export/project/object_builder_spec.rb' - 'ee/spec/lib/gitlab/import_export/project/relation_factory_spec.rb' - - 'ee/spec/lib/gitlab/import_sources_spec.rb' - 'ee/spec/lib/gitlab/incident_management_spec.rb' - 'ee/spec/lib/gitlab/ingestion/bulk_insertable_task_spec.rb' - 'ee/spec/lib/gitlab/insights/executors/issuable_executor_spec.rb' @@ -1455,8 +1450,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/projects/after_rename_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' - 'ee/spec/services/projects/cleanup_service_spec.rb' - - 'ee/spec/services/projects/create_from_template_service_spec.rb' - - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/disable_legacy_inactive_projects_service_spec.rb' - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' @@ -1526,7 +1519,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/operations/environments.html.haml_spec.rb' - 'ee/spec/views/operations/index.html.haml_spec.rb' - 'ee/spec/views/profiles/preferences/show.html.haml_spec.rb' - - 'ee/spec/views/projects/_merge_request_status_checks_settings.html.haml_spec.rb' - 'ee/spec/views/projects/edit.html.haml_spec.rb' - 'ee/spec/views/projects/issues/show.html.haml_spec.rb' - 'ee/spec/views/projects/security/corpus_management/show.html.haml_spec.rb' @@ -1539,6 +1531,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/projects/security/policies/index.html.haml_spec.rb' - 'ee/spec/views/projects/security/sast_configuration/show.html.haml_spec.rb' - 'ee/spec/views/projects/settings/merge_requests/_merge_request_approvals.html.haml_spec.rb' + - 'ee/spec/views/projects/settings/merge_requests/_merge_request_status_checks_settings.html.haml_spec.rb' - 'ee/spec/views/projects/settings/subscriptions/_index.html.haml_spec.rb' - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' - 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb' @@ -2744,7 +2737,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/common/extractors/ndjson_extractor_spec.rb' - 'spec/lib/bulk_imports/common/extractors/rest_extractor_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/badges_pipeline_spec.rb' - - 'spec/lib/bulk_imports/common/pipelines/entity_finisher_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/members_pipeline_spec.rb' - 'spec/lib/bulk_imports/common/rest/get_badges_query_spec.rb' @@ -2760,10 +2752,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/groups/pipelines/namespace_settings_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/transformers/subgroup_to_entity_transformer_spec.rb' - - 'spec/lib/bulk_imports/network_error_spec.rb' - 'spec/lib/bulk_imports/pipeline/context_spec.rb' - 'spec/lib/bulk_imports/pipeline/extracted_data_spec.rb' - - 'spec/lib/bulk_imports/pipeline/runner_spec.rb' - 'spec/lib/bulk_imports/pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/graphql/get_project_query_spec.rb' - 'spec/lib/bulk_imports/projects/graphql/get_repository_query_spec.rb' @@ -3402,12 +3392,9 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/migrations/test_background_runner_spec.rb' - 'spec/lib/gitlab/database/no_cross_db_foreign_keys_spec.rb' - 'spec/lib/gitlab/database/partitioning/detached_partition_dropper_spec.rb' - - 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb' - - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' - 'spec/lib/gitlab/database/partitioning/partition_monitoring_spec.rb' - 'spec/lib/gitlab/database/partitioning/replace_table_spec.rb' - 'spec/lib/gitlab/database/partitioning/single_numeric_list_partition_spec.rb' - - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - 'spec/lib/gitlab/database/partitioning/time_partition_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/index_helpers_spec.rb' @@ -3671,7 +3658,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/github_import/logger_spec.rb' - 'spec/lib/gitlab/github_import/markdown_text_spec.rb' - 'spec/lib/gitlab/github_import/milestone_finder_spec.rb' - - 'spec/lib/gitlab/github_import/object_counter_spec.rb' - 'spec/lib/gitlab/github_import/parallel_importer_spec.rb' - 'spec/lib/gitlab/github_import/representation/diff_note_spec.rb' - 'spec/lib/gitlab/github_import/representation/diff_notes/suggestion_formatter_spec.rb' @@ -5504,7 +5490,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/user_serializer_spec.rb' - 'spec/serializers/web_ide_terminal_entity_spec.rb' - 'spec/serializers/web_ide_terminal_serializer_spec.rb' - - 'spec/services/application_settings/update_service_spec.rb' - 'spec/services/applications/create_service_spec.rb' - 'spec/services/gpg_keys/destroy_service_spec.rb' - 'spec/services/metrics/dashboard/grafana_metric_embed_service_spec.rb' diff --git a/.rubocop_todo/rspec/useless_dynamic_definition.yml b/.rubocop_todo/rspec/useless_dynamic_definition.yml index b3dabf433a0..94a53324dee 100644 --- a/.rubocop_todo/rspec/useless_dynamic_definition.yml +++ b/.rubocop_todo/rspec/useless_dynamic_definition.yml @@ -1,6 +1,5 @@ --- RSpec/UselessDynamicDefinition: - Details: grace period Exclude: - 'ee/spec/factories/ci/builds.rb' - 'ee/spec/factories/ci/job_artifacts.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 6f2e884fc55..42d1363358b 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -162,7 +162,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/services/merge_requests/approval_service_spec.rb' - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb' - - 'ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb' - 'ee/spec/services/security/orchestration/assign_service_spec.rb' @@ -891,7 +890,6 @@ RSpec/VerifiedDoubles: - 'spec/services/metrics/dashboard/update_dashboard_service_spec.rb' - 'spec/services/metrics/users_starred_dashboards/create_service_spec.rb' - 'spec/services/milestones/update_service_spec.rb' - - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'spec/services/notes/create_service_spec.rb' - 'spec/services/notes/render_service_spec.rb' - 'spec/services/notification_service_spec.rb' @@ -1003,7 +1001,6 @@ RSpec/VerifiedDoubles: - 'spec/workers/create_commit_signature_worker_spec.rb' - 'spec/workers/environments/auto_stop_worker_spec.rb' - 'spec/workers/error_tracking_issue_link_worker_spec.rb' - - 'spec/workers/gitlab/github_import/advance_stage_worker_spec.rb' - 'spec/workers/gitlab/github_import/import_diff_note_worker_spec.rb' - 'spec/workers/gitlab/github_import/import_issue_worker_spec.rb' - 'spec/workers/gitlab/github_import/import_note_worker_spec.rb' diff --git a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml index 9eed58acdc7..1c61aa893a2 100644 --- a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml +++ b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml @@ -181,7 +181,6 @@ SidekiqLoadBalancing/WorkerDataConsistency: - 'app/workers/metrics/dashboard/schedule_annotations_prune_worker.rb' - 'app/workers/metrics/dashboard/sync_dashboards_worker.rb' - 'app/workers/migrate_external_diffs_worker.rb' - - 'app/workers/namespaces/in_product_marketing_emails_worker.rb' - 'app/workers/namespaces/process_sync_events_worker.rb' - 'app/workers/namespaces/prune_aggregation_schedules_worker.rb' - 'app/workers/namespaces/schedule_aggregation_worker.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index 55df73d3633..80e5b613fac 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -70,7 +70,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/groups/dependency_proxy_auth_controller.rb' - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' - 'app/controllers/groups/deploy_tokens_controller.rb' - - 'app/controllers/groups/email_campaigns_controller.rb' - 'app/controllers/groups/group_links_controller.rb' - 'app/controllers/groups/group_members_controller.rb' - 'app/controllers/groups/imports_controller.rb' @@ -358,7 +357,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/designs_controller.rb' - 'ee/app/controllers/admin/geo/nodes_controller.rb' - - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/geo/replicables_controller.rb' - 'ee/app/controllers/admin/geo/settings_controller.rb' - 'ee/app/controllers/admin/licenses_controller.rb' @@ -459,7 +457,6 @@ Style/ClassAndModuleChildren: - 'ee/app/models/geo/base_registry.rb' - 'ee/app/models/geo/container_repository_registry.rb' - 'ee/app/models/geo/deleted_project.rb' - - 'ee/app/models/geo/design_registry.rb' - 'ee/app/models/geo/event_log_state.rb' - 'ee/app/models/geo/group_wiki_repository_registry.rb' - 'ee/app/models/geo/job_artifact_registry.rb' diff --git a/.rubocop_todo/style/conditional_assignment.yml b/.rubocop_todo/style/conditional_assignment.yml deleted file mode 100644 index d16f2f7c3a7..00000000000 --- a/.rubocop_todo/style/conditional_assignment.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/ConditionalAssignment: - Exclude: - - 'app/helpers/icons_helper.rb' diff --git a/.rubocop_todo/style/each_for_simple_loop.yml b/.rubocop_todo/style/each_for_simple_loop.yml deleted file mode 100644 index e7f99d69528..00000000000 --- a/.rubocop_todo/style/each_for_simple_loop.yml +++ /dev/null @@ -1,6 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/EachForSimpleLoop: - Exclude: - - 'ee/spec/lib/gitlab/insights/reducers/count_per_period_reducer_spec.rb' - - 'spec/services/members/invitation_reminder_email_service_spec.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index c128f96eafe..c45ddab8441 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -80,7 +80,6 @@ Style/FormatString: - 'app/models/integrations/asana.rb' - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/bugzilla.rb' - - 'app/models/integrations/campfire.rb' - 'app/models/integrations/chat_message/pipeline_message.rb' - 'app/models/integrations/confluence.rb' - 'app/models/integrations/custom_issue_tracker.rb' @@ -160,7 +159,6 @@ Style/FormatString: - 'ee/app/components/namespaces/free_user_cap/usage_quota_trial_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/licenses_controller.rb' - 'ee/app/controllers/concerns/audit_events/date_range.rb' - 'ee/app/controllers/ee/projects/issues_controller.rb' @@ -182,7 +180,6 @@ Style/FormatString: - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/timeboxes_helper.rb' - 'ee/app/helpers/groups/sso_helper.rb' - - 'ee/app/helpers/trial_registrations/reassurances_helper.rb' - 'ee/app/helpers/vulnerabilities_helper.rb' - 'ee/app/mailers/ee/emails/admin_notification.rb' - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml index d7032af8805..b2dceb48c1b 100644 --- a/.rubocop_todo/style/hash_as_last_array_item.yml +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -39,7 +39,6 @@ Style/HashAsLastArrayItem: - 'ee/app/serializers/dashboard_environments_serializer.rb' - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/needs_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'lib/api/entities/project.rb' - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 872282a6a93..ef4fca8270d 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -389,7 +389,6 @@ Style/IfUnlessModifier: - 'ee/app/controllers/admin/elasticsearch_controller.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - - 'ee/app/controllers/admin/geo/projects_controller.rb' - 'ee/app/controllers/admin/geo/settings_controller.rb' - 'ee/app/controllers/admin/push_rules_controller.rb' - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' diff --git a/.rubocop_todo/style/mutable_constant.yml b/.rubocop_todo/style/mutable_constant.yml index f7a82be400a..d549830992f 100644 --- a/.rubocop_todo/style/mutable_constant.yml +++ b/.rubocop_todo/style/mutable_constant.yml @@ -7,7 +7,6 @@ Style/MutableConstant: - 'app/graphql/mutations/packages/bulk_destroy.rb' - 'app/helpers/blame_helper.rb' - 'app/models/ci/build_trace_chunks/redis_base.rb' - - 'app/models/design_management/repository.rb' - 'app/models/integrations/datadog.rb' - 'app/presenters/packages/helm/index_presenter.rb' - 'app/services/import/validate_remote_git_endpoint_service.rb' diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml deleted file mode 100644 index 6800ba2baf3..00000000000 --- a/.rubocop_todo/style/next.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/Next: - Exclude: - - 'lib/gitlab/fogbugz_import/importer.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index aee5872a343..59acd655d4b 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -2,230 +2,6 @@ # Cop supports --autocorrect. Style/PercentLiteralDelimiters: Exclude: - - 'Guardfile' - - 'app/helpers/auth_helper.rb' - - 'app/helpers/ci/variables_helper.rb' - - 'app/helpers/clusters_helper.rb' - - 'app/helpers/commits_helper.rb' - - 'app/helpers/diff_helper.rb' - - 'app/helpers/emails_helper.rb' - - 'app/helpers/external_link_helper.rb' - - 'app/helpers/labels_helper.rb' - - 'app/helpers/markup_helper.rb' - - 'app/helpers/nav_helper.rb' - - 'app/helpers/profiles_helper.rb' - - 'app/helpers/search_helper.rb' - - 'app/helpers/stat_anchors_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/models/application_setting.rb' - - 'app/models/application_setting_implementation.rb' - - 'app/models/blob_viewer/binary_stl.rb' - - 'app/models/blob_viewer/cargo_toml.rb' - - 'app/models/blob_viewer/cartfile.rb' - - 'app/models/blob_viewer/changelog.rb' - - 'app/models/blob_viewer/composer_json.rb' - - 'app/models/blob_viewer/contributing.rb' - - 'app/models/blob_viewer/csv.rb' - - 'app/models/blob_viewer/gemfile.rb' - - 'app/models/blob_viewer/gemspec.rb' - - 'app/models/blob_viewer/gitlab_ci_yml.rb' - - 'app/models/blob_viewer/go_mod.rb' - - 'app/models/blob_viewer/godeps_json.rb' - - 'app/models/blob_viewer/license.rb' - - 'app/models/blob_viewer/markup.rb' - - 'app/models/blob_viewer/notebook.rb' - - 'app/models/blob_viewer/open_api.rb' - - 'app/models/blob_viewer/package_json.rb' - - 'app/models/blob_viewer/pdf.rb' - - 'app/models/blob_viewer/podfile.rb' - - 'app/models/blob_viewer/podspec.rb' - - 'app/models/blob_viewer/podspec_json.rb' - - 'app/models/blob_viewer/readme.rb' - - 'app/models/blob_viewer/requirements_txt.rb' - - 'app/models/blob_viewer/route_map.rb' - - 'app/models/blob_viewer/sketch.rb' - - 'app/models/blob_viewer/svg.rb' - - 'app/models/blob_viewer/yarn_lock.rb' - - 'app/models/bulk_imports/file_transfer/group_config.rb' - - 'app/models/bulk_imports/file_transfer/project_config.rb' - - 'app/models/ci/build.rb' - - 'app/models/ci/build_runner_session.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/clusters/platforms/kubernetes.rb' - - 'app/models/commit.rb' - - 'app/models/concerns/clusters/agents/authorizations/ci_access/config_scopes.rb' - - 'app/models/concerns/diff_positionable_note.rb' - - 'app/models/concerns/enums/prometheus_metric.rb' - - 'app/models/concerns/issuable.rb' - - 'app/models/concerns/issue_available_features.rb' - - 'app/models/concerns/mentionable/reference_regexes.rb' - - 'app/models/concerns/noteable.rb' - - 'app/models/concerns/resolvable_note.rb' - - 'app/models/concerns/with_uploads.rb' - - 'app/models/container_registry/event.rb' - - 'app/models/deploy_token.rb' - - 'app/models/description_version.rb' - - 'app/models/design_management.rb' - - 'app/models/diff_note.rb' - - 'app/models/discussion_note.rb' - - 'app/models/draft_note.rb' - - 'app/models/environment.rb' - - 'app/models/event.rb' - - 'app/models/instance_configuration.rb' - - 'app/models/integrations/asana.rb' - - 'app/models/integrations/assembla.rb' - - 'app/models/integrations/base_issue_tracker.rb' - - 'app/models/integrations/base_monitoring.rb' - - 'app/models/integrations/base_slash_commands.rb' - - 'app/models/integrations/base_third_party_wiki.rb' - - 'app/models/integrations/buildkite.rb' - - 'app/models/integrations/campfire.rb' - - 'app/models/integrations/datadog.rb' - - 'app/models/integrations/drone_ci.rb' - - 'app/models/integrations/emails_on_push.rb' - - 'app/models/integrations/external_wiki.rb' - - 'app/models/integrations/field.rb' - - 'app/models/integrations/jenkins.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/integrations/packagist.rb' - - 'app/models/integrations/pivotaltracker.rb' - - 'app/models/integrations/pushover.rb' - - 'app/models/integrations/teamcity.rb' - - 'app/models/integrations/zentao.rb' - - 'app/models/issuable_severity.rb' - - 'app/models/issue.rb' - - 'app/models/lfs_download_object.rb' - - 'app/models/namespace.rb' - - 'app/models/namespace/root_storage_statistics.rb' - - 'app/models/note.rb' - - 'app/models/notification_setting.rb' - - 'app/models/performance_monitoring/prometheus_dashboard.rb' - - 'app/models/project.rb' - - 'app/models/project_feature.rb' - - 'app/models/project_setting.rb' - - 'app/models/releases/link.rb' - - 'app/models/repository.rb' - - 'app/models/resource_label_event.rb' - - 'app/models/resource_state_event.rb' - - 'app/models/resource_timebox_event.rb' - - 'app/models/user.rb' - - 'app/models/user_interacted_project.rb' - - 'app/policies/identity_provider_policy.rb' - - 'app/presenters/dev_ops_report/metric_presenter.rb' - - 'app/presenters/search_service_presenter.rb' - - 'app/serializers/pipeline_serializer.rb' - - 'app/services/application_settings/update_service.rb' - - 'app/services/auth/container_registry_authentication_service.rb' - - 'app/services/boards/update_service.rb' - - 'app/services/bulk_imports/file_download_service.rb' - - 'app/services/ci/update_instance_variables_service.rb' - - 'app/services/clusters/kubernetes/create_or_update_service_account_service.rb' - - 'app/services/feature_flags/base_service.rb' - - 'app/services/files/multi_service.rb' - - 'app/services/import/bitbucket_server_service.rb' - - 'app/services/import/fogbugz_service.rb' - - 'app/services/import/github_service.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3.rb' - - 'app/services/import_export_clean_up_service.rb' - - 'app/services/incident_management/pager_duty/process_webhook_service.rb' - - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/merge_requests/update_service.rb' - - 'app/services/metrics/dashboard/default_embed_service.rb' - - 'app/services/packages/debian/generate_distribution_service.rb' - - 'app/services/preview_markdown_service.rb' - - 'app/services/projects/apple_target_platform_detector_service.rb' - - 'app/services/projects/download_service.rb' - - 'app/services/projects/hashed_storage/migrate_attachments_service.rb' - - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - - 'app/services/projects/update_service.rb' - - 'app/services/prometheus/proxy_service.rb' - - 'app/services/repositories/base_service.rb' - - 'app/services/repository_archive_clean_up_service.rb' - - 'app/services/resource_access_tokens/create_service.rb' - - 'app/services/resource_access_tokens/revoke_service.rb' - - 'app/services/search/global_service.rb' - - 'app/services/search/project_service.rb' - - 'app/services/snippets/update_service.rb' - - 'app/services/todos/destroy/destroyed_issuable_service.rb' - - 'app/services/todos/destroy/entity_leave_service.rb' - - 'app/uploaders/design_management/design_v432x230_uploader.rb' - - 'app/uploaders/gitlab_uploader.rb' - - 'app/validators/addressable_url_validator.rb' - - 'app/validators/gitlab/zoom_url_validator.rb' - - 'app/validators/json_schema_validator.rb' - - 'app/workers/members_destroyer/unassign_issuables_worker.rb' - - 'app/workers/projects/record_target_platforms_worker.rb' - - 'config/application.rb' - - 'config/boot.rb' - - 'config/environments/production.rb' - - 'config/initializers/1_settings.rb' - - 'config/initializers/content_security_policy.rb' - - 'config/initializers/doorkeeper.rb' - - 'config/initializers/enumerator_next_patch.rb' - - 'config/initializers/fog_core_patch.rb' - - 'config/initializers/forbid_sidekiq_in_transactions.rb' - - 'config/initializers/health_check.rb' - - 'config/initializers/invisible_captcha.rb' - - 'config/initializers/lograge.rb' - - 'config/initializers/rspec_profiling.rb' - - 'config/initializers_before_autoloader/000_inflections.rb' - - 'config/object_store_settings.rb' - - 'config/spring.rb' - - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - - 'ee/app/controllers/ee/projects/service_desk_controller.rb' - - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' - - 'ee/app/controllers/groups/protected_environments_controller.rb' - - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' - - 'ee/app/controllers/projects/protected_environments_controller.rb' - - 'ee/app/finders/iterations_finder.rb' - - 'ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb' - - 'ee/app/helpers/credentials_inventory_helper.rb' - - 'ee/app/helpers/ee/auth_helper.rb' - - 'ee/app/helpers/ee/dashboard_helper.rb' - - 'ee/app/helpers/ee/integrations_helper.rb' - - 'ee/app/helpers/ee/issues_helper.rb' - - 'ee/app/helpers/ee/labels_helper.rb' - - 'ee/app/helpers/ee/nav_helper.rb' - - 'ee/app/mailers/previews/ci_minutes_usage_mailer_preview.rb' - - 'ee/app/mailers/previews/emails/namespace_storage_usage_mailer_preview.rb' - - 'ee/app/mailers/previews/license_mailer_preview.rb' - - 'ee/app/models/app_sec/fuzzing/api/scan_profile.rb' - - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - - 'ee/app/models/concerns/ee/issue_available_features.rb' - - 'ee/app/models/ee/audit_event.rb' - - 'ee/app/models/ee/description_version.rb' - - 'ee/app/models/ee/groups/feature_setting.rb' - - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/project_feature.rb' - - 'ee/app/models/ee/resource_label_event.rb' - - 'ee/app/models/ee/resource_state_event.rb' - - 'ee/app/models/ee/user.rb' - - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/models/geo/project_registry.rb' - - 'ee/app/models/geo/secondary_usage_data.rb' - - 'ee/app/models/geo_node_status.rb' - - 'ee/app/models/incident_management/issuable_resource_link.rb' - - 'ee/app/models/integrations/github.rb' - - 'ee/app/models/merge_requests/status_check_response.rb' - - 'ee/app/models/saml_provider.rb' - - 'ee/app/models/security/orchestration_policy_configuration.rb' - - 'ee/app/models/software_license_policy.rb' - - 'ee/app/models/storage_shard.rb' - - 'ee/app/services/approval_rules/create_service.rb' - - 'ee/app/services/boards/epic_boards/update_service.rb' - - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' - - 'ee/app/services/concerns/search/elasticsearchable.rb' - - 'ee/app/services/ee/boards/update_service.rb' - - 'ee/app/services/ee/search/group_service.rb' - - 'ee/app/services/ee/search/project_service.rb' - - 'ee/app/services/epics/tree_reorder_service.rb' - - 'ee/app/services/iterations/update_service.rb' - - 'ee/app/services/jira/jql_builder_service.rb' - - 'ee/app/services/security/configuration/save_auto_fix_service.rb' - - 'ee/app/services/security/dependency_list_service.rb' - - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb' - - 'ee/elastic/migrate/20220613120500_migrate_commits_to_separate_index.rb' - 'ee/lib/api/status_checks.rb' - 'ee/lib/api/visual_review_discussions.rb' - 'ee/lib/ee/api/helpers/members_helpers.rb' @@ -250,7 +26,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' - 'ee/lib/tasks/gitlab/elastic/test.rake' - - 'ee/spec/config/metrics/every_metric_definition_spec.rb' - 'ee/spec/controllers/ee/sessions_controller_spec.rb' - 'ee/spec/controllers/groups/saml_providers_controller_spec.rb' - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' @@ -284,7 +59,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/helpers/ee/application_settings_helper_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/helpers/ee/environments_helper_spec.rb' - - 'ee/spec/helpers/ee/geo_helper_spec.rb' - 'ee/spec/helpers/ee/labels_helper_spec.rb' - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - 'ee/spec/helpers/merge_requests_helper_spec.rb' @@ -301,7 +75,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/external_users_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/groups_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/reports/security/reports_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_design_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' - 'ee/spec/lib/ee/gitlab/security/scan_configuration_spec.rb' @@ -314,7 +87,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/adapter_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' - - 'ee/spec/lib/gitlab/auth/saml/membership_updater_spec.rb' - 'ee/spec/lib/gitlab/auth/saml/user_spec.rb' - 'ee/spec/lib/gitlab/authority_analyzer_spec.rb' - 'ee/spec/lib/gitlab/cache_spec.rb' @@ -348,7 +120,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'ee/spec/models/ee/ci/runner_spec.rb' - 'ee/spec/models/ee/groups/feature_setting_spec.rb' - - 'ee/spec/models/ee/integration_spec.rb' - 'ee/spec/models/ee/integrations/jira_spec.rb' - 'ee/spec/models/ee/personal_access_token_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' @@ -398,7 +169,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/support/license_scanning_reports/license_scanning_report_helper.rb' - 'ee/spec/support/prometheus/additional_metrics_shared_examples.rb' - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - 'ee/spec/support/shared_examples/finders/geo/file_registry_finder_shared_examples.rb' - 'ee/spec/support/shared_examples/finders/geo/registry_finder_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/git_access_shared_examples.rb' @@ -409,134 +179,6 @@ Style/PercentLiteralDelimiters: - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb' - 'ee/spec/workers/project_cache_worker_spec.rb' - 'ee/spec/workers/repository_import_worker_spec.rb' - - 'lib/api/ci/helpers/runner.rb' - - 'lib/api/commit_statuses.rb' - - 'lib/api/discussions.rb' - - 'lib/api/entities/note.rb' - - 'lib/api/helpers/common_helpers.rb' - - 'lib/api/helpers/notes_helpers.rb' - - 'lib/api/helpers/projects_helpers.rb' - - 'lib/api/helpers/search_helpers.rb' - - 'lib/api/maven_packages.rb' - - 'lib/api/repositories.rb' - - 'lib/api/search.rb' - - 'lib/api/users.rb' - - 'lib/backup/database.rb' - - 'lib/backup/manager.rb' - - 'lib/banzai/filter/ascii_doc_sanitization_filter.rb' - - 'lib/banzai/filter/autolink_filter.rb' - - 'lib/banzai/filter/base_sanitization_filter.rb' - - 'lib/banzai/filter/broadcast_message_sanitization_filter.rb' - - 'lib/banzai/filter/custom_emoji_filter.rb' - - 'lib/banzai/filter/emoji_filter.rb' - - 'lib/banzai/filter/gollum_tags_filter.rb' - - 'lib/banzai/filter/inline_diff_filter.rb' - - 'lib/banzai/filter/issuable_reference_expansion_filter.rb' - - 'lib/banzai/filter/references/reference_filter.rb' - - 'lib/banzai/filter/repository_link_filter.rb' - - 'lib/banzai/filter/sanitization_filter.rb' - - 'lib/banzai/filter/spaced_link_filter.rb' - - 'lib/banzai/filter/syntax_highlight_filter.rb' - - 'lib/banzai/filter/table_of_contents_filter.rb' - - 'lib/banzai/pipeline/base_pipeline.rb' - - 'lib/banzai/pipeline/description_pipeline.rb' - - 'lib/banzai/pipeline/incident_management/timeline_event_pipeline.rb' - - 'lib/bitbucket/page.rb' - - 'lib/bitbucket/representation/issue.rb' - - 'lib/container_registry/path.rb' - - 'lib/feature.rb' - - 'lib/generators/gitlab/usage_metric_definition_generator.rb' - - 'lib/generators/gitlab/usage_metric_generator.rb' - - 'lib/gitlab.rb' - - 'lib/gitlab/alert_management/payload/managed_prometheus.rb' - - 'lib/gitlab/alert_management/payload/prometheus.rb' - - 'lib/gitlab/asciidoc/syntax_highlighter/html_pipeline_adapter.rb' - - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/auth/ldap/config.rb' - - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/ci/config/entry/bridge.rb' - - 'lib/gitlab/ci/reports/codequality_reports.rb' - - 'lib/gitlab/ci/reports/test_reports_comparer.rb' - - 'lib/gitlab/cleanup/orphan_job_artifact_files.rb' - - 'lib/gitlab/cluster/rack_timeout_observer.rb' - - 'lib/gitlab/content_security_policy/config_loader.rb' - - 'lib/gitlab/database/load_balancing/connection_proxy.rb' - - 'lib/gitlab/database/migration_helpers/cascading_namespace_settings.rb' - - 'lib/gitlab/database/reindexing.rb' - - 'lib/gitlab/dependency_linker/base_linker.rb' - - 'lib/gitlab/diff/char_diff.rb' - - 'lib/gitlab/diff/inline_diff_marker.rb' - - 'lib/gitlab/diff/line.rb' - - 'lib/gitlab/etag_caching/middleware.rb' - - 'lib/gitlab/etag_caching/router/graphql.rb' - - 'lib/gitlab/etag_caching/router/rails.rb' - - 'lib/gitlab/fips.rb' - - 'lib/gitlab/git/blob.rb' - - 'lib/gitlab/git/diff.rb' - - 'lib/gitlab/git/rugged_impl/repository.rb' - - 'lib/gitlab/git/tree.rb' - - 'lib/gitlab/git_access.rb' - - 'lib/gitlab/gitaly_client.rb' - - 'lib/gitlab/gitaly_client/diff.rb' - - 'lib/gitlab/gitaly_client/wiki_page.rb' - - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - - 'lib/gitlab/hotlinking_detector.rb' - - 'lib/gitlab/import_export/command_line_util.rb' - - 'lib/gitlab/import_export/file_importer.rb' - - 'lib/gitlab/import_export/repo_restorer.rb' - - 'lib/gitlab/jira_import/metadata_collector.rb' - - 'lib/gitlab/kas.rb' - - 'lib/gitlab/kroki.rb' - - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - - 'lib/gitlab/logger.rb' - - 'lib/gitlab/lograge/custom_options.rb' - - 'lib/gitlab/metrics/background_transaction.rb' - - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - - 'lib/gitlab/metrics/dashboard/stages/url_validator.rb' - - 'lib/gitlab/metrics/requests_rack_middleware.rb' - - 'lib/gitlab/metrics/subscribers/action_view.rb' - - 'lib/gitlab/metrics/subscribers/active_record.rb' - - 'lib/gitlab/metrics/transaction.rb' - - 'lib/gitlab/metrics/web_transaction.rb' - - 'lib/gitlab/middleware/read_only/controller.rb' - - 'lib/gitlab/project_search_results.rb' - - 'lib/gitlab/prometheus/query_variables.rb' - - 'lib/gitlab/query_limiting/transaction.rb' - - 'lib/gitlab/reference_extractor.rb' - - 'lib/gitlab/regex.rb' - - 'lib/gitlab/regex/bulk_imports.rb' - - 'lib/gitlab/sanitizers/exception_message.rb' - - 'lib/gitlab/sanitizers/exif.rb' - - 'lib/gitlab/search/abuse_detection.rb' - - 'lib/gitlab/search_context.rb' - - 'lib/gitlab/slash_commands/presenters/base.rb' - - 'lib/gitlab/ssh_public_key.rb' - - 'lib/gitlab/task_helpers.rb' - - 'lib/gitlab/url_blocker.rb' - - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb' - - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' - - 'lib/gitlab/usage/metrics/instrumentations/numbers_metric.rb' - - 'lib/gitlab/usage_data.rb' - - 'lib/gitlab/usage_data/topology.rb' - - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - - 'lib/gitlab/utils/sanitize_node_link.rb' - - 'lib/gitlab/web_hooks/rate_limiter.rb' - - 'lib/gitlab/workhorse.rb' - - 'lib/grafana/validator.rb' - - 'lib/omni_auth/strategies/jwt.rb' - - 'lib/release_highlights/validator/entry.rb' - - 'lib/security/ci_configuration/sast_build_action.rb' - - 'lib/sidebars/projects/menus/repository_menu.rb' - - 'lib/system_check/app/migrations_are_up_check.rb' - - 'lib/system_check/incoming_email/mail_room_running_check.rb' - - 'lib/system_check/sidekiq_check.rb' - - 'lib/tasks/cleanup.rake' - - 'lib/tasks/gettext.rake' - - 'lib/tasks/gitlab/info.rake' - - 'lib/tasks/gitlab/shell.rake' - - 'lib/tasks/gitlab/update_templates.rake' - - 'lib/tasks/tanuki_emoji.rake' - 'metrics_server/metrics_server.rb' - 'qa/qa/ee/page/dashboard/projects.rb' - 'qa/qa/ee/page/group/settings/general.rb' @@ -568,7 +210,6 @@ Style/PercentLiteralDelimiters: - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/commands/sidekiq_cluster/cli_spec.rb' - 'spec/components/pajamas/component_spec.rb' - - 'spec/config/mail_room_spec.rb' - 'spec/controllers/concerns/continue_params_spec.rb' - 'spec/controllers/graphql_controller_spec.rb' - 'spec/controllers/groups/releases_controller_spec.rb' @@ -577,13 +218,9 @@ Style/PercentLiteralDelimiters: - 'spec/controllers/profiles/two_factor_auths_controller_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - - 'spec/controllers/projects/environments/prometheus_api_controller_spec.rb' - - 'spec/controllers/projects/environments_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' - 'spec/controllers/projects/merge_requests_controller_spec.rb' - - 'spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' @@ -663,7 +300,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb' - 'spec/lib/banzai/filter/image_link_filter_spec.rb' - - 'spec/lib/banzai/filter/inline_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/commit_range_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' @@ -682,10 +318,8 @@ Style/PercentLiteralDelimiters: - 'spec/lib/banzai/pipeline/description_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/commit_parser_spec.rb' - 'spec/lib/banzai/reference_parser/issue_parser_spec.rb' - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' - 'spec/lib/bitbucket/collection_spec.rb' @@ -779,7 +413,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/graphql/tracers/metrics_tracer_spec.rb' - 'spec/lib/gitlab/hashed_path_spec.rb' - 'spec/lib/gitlab/highlight_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/i18n/translation_entry_spec.rb' - 'spec/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy_spec.rb' - 'spec/lib/gitlab/import_export/after_export_strategies/web_upload_strategy_spec.rb' @@ -802,8 +435,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/kubernetes/role_spec.rb' - 'spec/lib/gitlab/language_data_spec.rb' - 'spec/lib/gitlab/markup_helper_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/validator/errors_spec.rb' - 'spec/lib/gitlab/metrics/rails_slis_spec.rb' - 'spec/lib/gitlab/metrics/samplers/threads_sampler_spec.rb' - 'spec/lib/gitlab/middleware/go_spec.rb' @@ -815,7 +446,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/process_management_spec.rb' - 'spec/lib/gitlab/process_supervisor_spec.rb' - - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' @@ -836,12 +466,12 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/string_range_marker_spec.rb' - 'spec/lib/gitlab/string_regex_marker_spec.rb' - 'spec/lib/gitlab/suggestions/suggestion_set_spec.rb' + - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/lib/gitlab/tracking/event_definition_spec.rb' - 'spec/lib/gitlab/url_sanitizer_spec.rb' - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - 'spec/lib/gitlab/usage/metric_spec.rb' - 'spec/lib/gitlab/usage/service_ping/instrumented_payload_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/log_limited_array_spec.rb' - 'spec/lib/gitlab/webpack/graphql_known_operations_spec.rb' @@ -889,7 +519,6 @@ Style/PercentLiteralDelimiters: - 'spec/models/concerns/reactive_caching_spec.rb' - 'spec/models/concerns/sortable_spec.rb' - 'spec/models/deployment_spec.rb' - - 'spec/models/design_management/repository_spec.rb' - 'spec/models/diff_viewer/base_spec.rb' - 'spec/models/environment_spec.rb' - 'spec/models/group_label_spec.rb' @@ -908,11 +537,9 @@ Style/PercentLiteralDelimiters: - 'spec/models/packages/package_spec.rb' - 'spec/models/packages/tag_spec.rb' - 'spec/models/pages_domain_spec.rb' - - 'spec/models/performance_monitoring/prometheus_dashboard_spec.rb' - 'spec/models/personal_access_token_spec.rb' - 'spec/models/project_feature_spec.rb' - 'spec/models/project_label_spec.rb' - - 'spec/models/project_setting_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/project_team_spec.rb' - 'spec/models/projects/topic_spec.rb' @@ -924,13 +551,11 @@ Style/PercentLiteralDelimiters: - 'spec/models/user_spec.rb' - 'spec/models/web_ide_terminal_spec.rb' - 'spec/models/zoom_meeting_spec.rb' - - 'spec/policies/group_policy_spec.rb' - 'spec/policies/project_policy_spec.rb' - 'spec/presenters/ci/pipeline_artifacts/code_coverage_presenter_spec.rb' - 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' - - 'spec/requests/api/admin/broadcast_messages_spec.rb' - 'spec/requests/api/badges_spec.rb' - 'spec/requests/api/ci/jobs_spec.rb' - 'spec/requests/api/ci/pipelines_spec.rb' @@ -1022,7 +647,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/packages/create_dependency_service_spec.rb' - 'spec/services/packages/nuget/create_dependency_service_spec.rb' - - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/packages/update_tags_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' @@ -1032,12 +656,10 @@ Style/PercentLiteralDelimiters: - 'spec/services/projects/operations/update_service_spec.rb' - 'spec/services/projects/record_target_platforms_service_spec.rb' - 'spec/services/projects/update_statistics_service_spec.rb' - - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' - 'spec/services/upload_service_spec.rb' - 'spec/sidekiq_cluster/sidekiq_cluster_spec.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - - 'spec/support/banzai/reference_filter_shared_examples.rb' - 'spec/support/capybara.rb' - 'spec/support/helpers/gpg_helpers.rb' - 'spec/support/helpers/login_helpers.rb' @@ -1049,11 +671,8 @@ Style/PercentLiteralDelimiters: - 'spec/support/import_export/configuration_helper.rb' - 'spec/support/import_export/export_file_helper.rb' - 'spec/support/matchers/markdown_matchers.rb' - - 'spec/support/prometheus/additional_metrics_shared_examples.rb' - - 'spec/support/prometheus/metric_builders.rb' - 'spec/support/shared_contexts/graphql/resolvers/runners_resolver_shared_context.rb' - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' - - 'spec/support/shared_examples/controllers/metrics_dashboard_shared_examples.rb' - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - 'spec/support/shared_examples/features/page_description_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_creates_wiki_page_shared_examples.rb' @@ -1079,7 +698,6 @@ Style/PercentLiteralDelimiters: - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' - - 'spec/lib/gitlab/task_helpers_spec.rb' - 'spec/tooling/danger/customer_success_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' @@ -1107,7 +725,6 @@ Style/PercentLiteralDelimiters: - 'spec/views/projects/commit/branches.html.haml_spec.rb' - 'spec/workers/concerns/worker_context_spec.rb' - 'spec/workers/container_registry/migration/enqueuer_worker_spec.rb' - - 'spec/workers/gitlab/github_import/advance_stage_worker_spec.rb' - 'spec/workers/groups/update_statistics_worker_spec.rb' - 'spec/workers/jira_connect/sync_branch_worker_spec.rb' - 'spec/workers/post_receive_spec.rb' diff --git a/.rubocop_todo/style/redundant_condition.yml b/.rubocop_todo/style/redundant_condition.yml deleted file mode 100644 index 535dfa9e462..00000000000 --- a/.rubocop_todo/style/redundant_condition.yml +++ /dev/null @@ -1,5 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/RedundantCondition: - Exclude: - - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml index 12126c58313..12c9200bf54 100644 --- a/.rubocop_todo/style/redundant_freeze.yml +++ b/.rubocop_todo/style/redundant_freeze.yml @@ -2,61 +2,7 @@ # Cop supports --autocorrect. Style/RedundantFreeze: Exclude: - - 'app/controllers/help_controller.rb' - - 'app/controllers/import/bitbucket_server_controller.rb' - - 'app/finders/issuable_finder.rb' - - 'app/finders/repositories/changelog_commits_finder.rb' - - 'app/helpers/auth_helper.rb' - - 'app/helpers/colors_helper.rb' - - 'app/helpers/sidekiq_helper.rb' - - 'app/models/application_setting_implementation.rb' - - 'app/models/badge.rb' - - 'app/models/blob_viewer/go_mod.rb' - - 'app/models/ci/runner.rb' - - 'app/models/commit.rb' - - 'app/models/commit_range.rb' - - 'app/models/concerns/ci/maskable.rb' - - 'app/models/concerns/pg_full_text_searchable.rb' - - 'app/models/concerns/redactable.rb' - - 'app/models/concerns/taskable.rb' - - 'app/models/custom_emoji.rb' - - 'app/models/environment_status.rb' - - 'app/models/error_tracking/project_error_tracking_setting.rb' - - 'app/models/hooks/web_hook.rb' - - 'app/models/integrations/apple_app_store.rb' - - 'app/models/integrations/campfire.rb' - - 'app/models/integrations/chat_message/base_message.rb' - - 'app/models/integrations/confluence.rb' - - 'app/models/integrations/datadog.rb' - - 'app/models/integrations/discord.rb' - - 'app/models/integrations/field.rb' - - 'app/models/integrations/teamcity.rb' - - 'app/models/license_template.rb' - - 'app/models/members/group_member.rb' - - 'app/models/members/project_member.rb' - - 'app/models/merge_request.rb' - - 'app/models/namespaces/randomized_suffix_path.rb' - - 'app/models/note.rb' - - 'app/models/packages/debian.rb' - - 'app/models/packages/debian/file_entry.rb' - - 'app/models/personal_access_token.rb' - - 'app/models/releases/link.rb' - - 'app/models/snippet_repository.rb' - - 'app/models/terraform/state.rb' - - 'app/services/clusters/agent_tokens/track_usage_service.rb' - - 'app/services/error_tracking/list_projects_service.rb' - - 'app/services/grafana/proxy_service.rb' - - 'app/services/import/validate_remote_git_endpoint_service.rb' - - 'app/services/issues/base_service.rb' - - 'app/services/projects/import_error_filter.rb' - - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - - 'app/services/prometheus/proxy_variable_substitution_service.rb' - - 'app/uploaders/file_uploader.rb' - - 'app/validators/certificate_fingerprint_validator.rb' - - 'app/validators/json_schema_validator.rb' - - 'app/validators/line_code_validator.rb' - 'lib/api/api.rb' - - 'lib/api/concerns/packages/nuget_endpoints.rb' - 'lib/api/debian_group_packages.rb' - 'lib/api/go_proxy.rb' - 'lib/api/helpers.rb' @@ -68,8 +14,6 @@ Style/RedundantFreeze: - 'lib/banzai/filter/attributes_filter.rb' - 'lib/banzai/filter/autolink_filter.rb' - 'lib/banzai/filter/blockquote_fence_filter.rb' - - 'lib/banzai/filter/dollar_math_post_filter.rb' - - 'lib/banzai/filter/dollar_math_pre_filter.rb' - 'lib/banzai/filter/footnote_filter.rb' - 'lib/banzai/filter/gollum_tags_filter.rb' - 'lib/banzai/filter/markdown_post_escape_filter.rb' @@ -90,7 +34,6 @@ Style/RedundantFreeze: - 'lib/gitlab/ci/build/artifacts/metadata.rb' - 'lib/gitlab/ci/config/entry/artifacts.rb' - 'lib/gitlab/ci/config/external/file/base.rb' - - 'lib/gitlab/ci/interpolation/block.rb' - 'lib/gitlab/ci/parsers/test/junit.rb' - 'lib/gitlab/ci/pipeline/chain/skip.rb' - 'lib/gitlab/ci/pipeline/expression/lexeme/and.rb' @@ -113,7 +56,6 @@ Style/RedundantFreeze: - 'lib/gitlab/database/background_migration/batch_optimizer.rb' - 'lib/gitlab/database/load_balancing/service_discovery.rb' - 'lib/gitlab/database/migrations/runner.rb' - - 'lib/gitlab/database/query_analyzers/query_recorder.rb' - 'lib/gitlab/dependency_linker/base_linker.rb' - 'lib/gitlab/dependency_linker/gemfile_linker.rb' - 'lib/gitlab/dependency_linker/godeps_json_linker.rb' @@ -128,7 +70,6 @@ Style/RedundantFreeze: - 'lib/gitlab/email/handler/service_desk_handler.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb' - - 'lib/gitlab/front_matter.rb' - 'lib/gitlab/git.rb' - 'lib/gitlab/git/base_error.rb' - 'lib/gitlab/git/diff.rb' @@ -140,7 +81,6 @@ Style/RedundantFreeze: - 'lib/gitlab/golang.rb' - 'lib/gitlab/graphql/queries.rb' - 'lib/gitlab/harbor/query.rb' - - 'lib/gitlab/hook_data/base_builder.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/i18n/translation_entry.rb' - 'lib/gitlab/jira/dvcs.rb' @@ -165,26 +105,3 @@ Style/RedundantFreeze: - 'lib/gitlab/regex.rb' - 'lib/gitlab/regex/packages.rb' - 'lib/gitlab/robots_txt/parser.rb' - - 'lib/gitlab/saas.rb' - - 'lib/gitlab/sanitizers/exception_message.rb' - - 'lib/gitlab/sanitizers/svg.rb' - - 'lib/gitlab/search/abuse_detection.rb' - - 'lib/gitlab/search/found_blob.rb' - - 'lib/gitlab/search/query.rb' - - 'lib/gitlab/sidekiq_config/worker_matcher.rb' - - 'lib/gitlab/slash_commands/deploy.rb' - - 'lib/gitlab/slug/path.rb' - - 'lib/gitlab/spamcheck/client.rb' - - 'lib/gitlab/sql/pattern.rb' - - 'lib/gitlab/unicode.rb' - - 'lib/gitlab/untrusted_regexp/ruby_syntax.rb' - - 'lib/gitlab/usage_data_counters/gitlab_cli_activity_unique_counter.rb' - - 'lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter.rb' - - 'lib/gitlab/usage_data_counters/vscode_extension_activity_unique_counter.rb' - - 'lib/gitlab/utils/link_header_parser.rb' - - 'lib/gitlab/utils/markdown.rb' - - 'lib/gitlab/uuid.rb' - - 'lib/gitlab/version_info.rb' - - 'lib/gitlab/x509/certificate.rb' - - 'lib/gitlab/zoom_link_extractor.rb' - - 'lib/sbom/package_url/argument_validator.rb' diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml deleted file mode 100644 index 540dcfa3ca7..00000000000 --- a/.rubocop_todo/style/redundant_parentheses.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/RedundantParentheses: - Details: grace period - Exclude: - - 'spec/graphql/types/ci/job_kind_enum_spec.rb' - - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' - - 'spec/requests/verifies_with_email_spec.rb' - - 'spec/services/projects/create_service_spec.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index df5c1b6172a..3dd497248bc 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -87,7 +87,6 @@ Style/RedundantSelf: - 'app/models/integrations/base_ci.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/base_slash_commands.rb' - - 'app/models/integrations/campfire.rb' - 'app/models/integrations/emails_on_push.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' @@ -205,7 +204,6 @@ Style/RedundantSelf: - 'ee/app/models/ee/user.rb' - 'ee/app/models/epic/metrics.rb' - 'ee/app/models/geo/base_registry.rb' - - 'ee/app/models/geo/design_registry.rb' - 'ee/app/models/geo/project_registry.rb' - 'ee/app/models/geo/upload_registry.rb' - 'ee/app/models/geo_node.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index 30a649cb4fa..c8cd3c9f074 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -6,7 +6,6 @@ Style/StringLiteralsInInterpolation: - 'app/helpers/colors_helper.rb' - 'app/models/application_setting_implementation.rb' - 'app/models/ci/namespace_mirror.rb' - - 'app/models/integrations/campfire.rb' - 'app/models/integrations/jira.rb' - 'app/services/draft_notes/publish_service.rb' - 'app/services/projects/create_service.rb' |