diff options
author | Felipe Artur <felipefac@gmail.com> | 2016-04-07 23:04:09 +0300 |
---|---|---|
committer | Felipe Artur <felipefac@gmail.com> | 2016-04-07 23:49:33 +0300 |
commit | 8d5ad4e3c9973ed34742b543cc3a5466c32b9d5b (patch) | |
tree | e02f0c5a9570e4562c20401ad2744423611e2c4e | |
parent | 9e6c61372fe0f7f2199f4e8f72b3c4e4a4219020 (diff) |
improve specs code syntax
-rw-r--r-- | spec/helpers/issues_helper_spec.rb | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/spec/helpers/issues_helper_spec.rb b/spec/helpers/issues_helper_spec.rb index df0eb22d6f6..543593cf389 100644 --- a/spec/helpers/issues_helper_spec.rb +++ b/spec/helpers/issues_helper_spec.rb @@ -80,7 +80,7 @@ describe IssuesHelper do end end - describe '#url_for_new_issue' do + describe 'url_for_new_issue' do let(:issues_url) { ext_project.external_issue_tracker.new_issue_url } let(:ext_expected) do issues_url.gsub(':project_id', ext_project.id.to_s) @@ -117,7 +117,7 @@ describe IssuesHelper do end end - describe "#merge_requests_sentence" do + describe "merge_requests_sentence" do subject { merge_requests_sentence(merge_requests)} let(:merge_requests) do [ build(:merge_request, iid: 1), build(:merge_request, iid: 2), @@ -127,7 +127,7 @@ describe IssuesHelper do it { is_expected.to eq("!1, !2, or !3") } end - describe "#note_active_class" do + describe "note_active_class" do before do @note = create :note @note1 = create :note @@ -142,22 +142,22 @@ describe IssuesHelper do end end - describe "#awards_sort" do + describe "awards_sort" do it "sorts a hash so thumbsup and thumbsdown are always on top" do data = { "thumbsdown" => "some value", "lifter" => "some value", "thumbsup" => "some value" } expect(awards_sort(data).keys).to eq(["thumbsup", "thumbsdown", "lifter"]) end end - describe "#milestone options" do - let!(:closed_milestone) { create :closed_milestone, title: "closed milestone", project: project } - let!(:milestone1) { create :milestone, title: "open milestone 1", project: project } - let!(:milestone2) { create :milestone, title: "open milestone 2", project: project } - - before { issue.update_attributes(milestone_id: closed_milestone.id) } - + describe "milestone_options" do it "gets closed milestone from current issue" do + closed_milestone = create(:closed_milestone, project: project) + milestone1 = create(:milestone, project: project) + milestone2 = create(:milestone, project: project) + issue.update_attributes(milestone_id: closed_milestone.id) + options = milestone_options(issue) + expect(options).to have_selector('option[selected]', text: closed_milestone.title) expect(options).to have_selector('option', text: milestone1.title) expect(options).to have_selector('option', text: milestone2.title) |