diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2017-01-26 23:03:45 +0300 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2017-01-27 17:27:07 +0300 |
| commit | 4ab83117fb5496be8c850925c78f32823593d5b2 (patch) | |
| tree | 3121cbd33f8029de785ad9a4c8533e71d2e97c4e | |
| parent | 4472779b7f93e07558f5afa1b1f6b23564de3ccd (diff) | |
Changes after review
| -rw-r--r-- | app/views/ci/status/_badge_link.html.haml | 4 | ||||
| -rw-r--r-- | spec/views/projects/builds/show.html.haml_spec.rb | 4 |
2 files changed, 5 insertions, 3 deletions
diff --git a/app/views/ci/status/_badge_link.html.haml b/app/views/ci/status/_badge_link.html.haml index 601fb7f0f3f..27011fe7478 100644 --- a/app/views/ci/status/_badge_link.html.haml +++ b/app/views/ci/status/_badge_link.html.haml @@ -6,6 +6,4 @@ = custom_icon(status.icon) = status.text - else - %span{ class: css_classes } - = custom_icon(status.icon) - = status.text + = render "ci/status/badge", status: status diff --git a/spec/views/projects/builds/show.html.haml_spec.rb b/spec/views/projects/builds/show.html.haml_spec.rb index 585906b9d31..44870cfcfb3 100644 --- a/spec/views/projects/builds/show.html.haml_spec.rb +++ b/spec/views/projects/builds/show.html.haml_spec.rb @@ -28,6 +28,10 @@ describe 'projects/builds/show', :view do expect(rendered).to have_css('.ci-status.ci-success', text: 'passed') end + it 'does not render a link to the build' do + expect(rendered).not_to have_link('passed') + end + it 'shows build id' do expect(rendered).to have_css('.js-build-id', text: build.id) end |